Re: [dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

2020-06-28 Thread Or Gerlitz
On Fri, Jun 26, 2020 at 7:43 PM Thomas Monjalon wrote: > Our next milestone is approaching, 20.08-rc1 should be in 12 days : > http://core.dpdk.org/roadmap/#dates > and the roadmap is very long: > http://core.dpdk.org/roadmap/#2008 > > We all want to have our code reviewed and acc

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Andrew Rybchenko
On 6/26/20 2:10 PM, Jerin Jacob wrote: > On Fri, Jun 26, 2020 at 4:16 PM Thomas Monjalon wrote: >> >> 26/06/2020 12:35, Jerin Jacob: >>> On Fri, Jun 26, 2020 at 12:59 AM Thomas Monjalon >>> wrote: 25/06/2020 19:55, Jerin Jacob: > On Thu, Jun 25, 2020 at 10:20 PM Jiawei Wang wrote:

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Andrew Rybchenko
On 6/25/20 7:26 PM, Jiawei Wang wrote: > When using full offload, all traffic will be handled by the HW, and > directed to the requested vf or wire, the control application loses > visibility on the traffic. > So there's a need for an action that will enable the control application > some visibilit

Re: [dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag

2020-06-28 Thread Andrew Rybchenko
On 6/26/20 7:56 PM, Bruce Richardson wrote: > On Wed, Apr 22, 2020 at 11:45:53PM +0200, Lukasz Wojciechowski wrote: >> A new boolean meson build flag is introduced with this patch: rte_debug. >> To enable this option add -Drte_debug=true to the meson configure command. >> >> By enabling this flag t

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-28 Thread Andrey Vesnovaty
Hi On Fri, Jun 26, 2020 at 2:44 PM Jerin Jacob wrote: > On Sat, Jun 20, 2020 at 7:02 PM Andrey Vesnovaty > wrote: > > > > Hi, and thanks a lot for your RFC v1 comments. > > > > RFC v2 emphasize the intent for sharing the flow action: > > * The term 'action context' was unclear and replaced with

[dpdk-dev] [PATCH] net/mlx5: fix flow META item validation

2020-06-28 Thread Shy Shyman
When flow is inserted with meta match item it requires a certain register support. As part of the flow validation of such flows, the validation function is missing a check that the mlx5 driver is not in legacy mode in terms of extended meta data support (MLX5_XMETA_MODE_LEGACY flag). If the driver

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-06-28 Thread Fady Bader
> Subject: Re: [PATCH v2 3/3] eal/windows: librte_net build on Windows > > > diff --git a/lib/librte_eal/common/meson.build > > b/lib/librte_eal/common/meson.build > > index e1bdaf024..05e40a26b 100644 > > --- a/lib/librte_eal/common/meson.build > > +++ b/lib/librte_eal/common/meson.build > > @@ -

Re: [dpdk-dev] [PATCH 0/3] mlx5: LACP handling for bonded devices

2020-06-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Shiri Kuzin > Sent: Tuesday, June 23, 2020 11:41 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH 0/3] mlx5: LACP handling for bonded devices > > When the driver has a bond configured, LACP traffic

[dpdk-dev] [PATCH v2 4/5] telemetry: implement empty stubs for Windows

2020-06-28 Thread Fady Bader
Telemetry didn't compile under Windows. Empty stubs implementation was added for Windows. Signed-off-by: Fady Bader --- lib/librte_telemetry/rte_telemetry.h| 4 +++ lib/librte_telemetry/telemetry.c| 51 - lib/librte_telemetry/telemetry_legacy.c | 26 +

[dpdk-dev] [PATCH v2 1/5] eal: added interrupts empty stubs

2020-06-28 Thread Fady Bader
The ethdev lib uses interrupts. Interrupts are not implemented for Windows. To solve this, empty interrupt stubs were added under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal_interrupts.c | 17 + lib/librte_eal/windows/meson.build | 1 + 2 files changed

[dpdk-dev] [PATCH v2 2/5] eal: updated export list for Windows

2020-06-28 Thread Fady Bader
Added eal functions used by ethdev lib to the export list under Windows. Signed-off-by: Fady Bader --- lib/librte_eal/rte_eal_exports.def | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 20f7346962..3b9

[dpdk-dev] [PATCH v2 0/5] compiling ethdev lib under windows

2020-06-28 Thread Fady Bader
Added needed changes in order to get ethdev compiling under windows. Depends-on: series-10382 ("compile librte_net for windows") v2: fixed logging issue in telemetry lib. Fady Bader (5): eal: added interrupts empty stubs eal: updated export list for Windows ethdev: remove structs from expo

[dpdk-dev] [PATCH v2 5/5] ethdev: compiling ethdev under Windows

2020-06-28 Thread Fady Bader
Compiling needed libraries for ethdev under Windows. Signed-off-by: Fady Bader --- lib/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 6317309ecf..34366cd614 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -37,9

[dpdk-dev] [PATCH v2 3/5] ethdev: remove structs from export list

2020-06-28 Thread Fady Bader
Some ethdev structs were present in ethdev export list. There structs were removed from the export list. Signed-off-by: Fady Bader --- lib/librte_ethdev/rte_ethdev_version.map | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_e

Re: [dpdk-dev] [PATCH v9 09/10] bus/pci: support Windows with bifurcated drivers

2020-06-28 Thread Tal Shnaiderman
> From: Narcisa Ana Maria Vasile > On Wed, Jun 24, 2020 at 11:28:46AM +0300, tal...@mellanox.com wrote: > > From: Tal Shnaiderman > > > > Uses SetupAPI.h functions to scan PCI tree. > > Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. > > Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the

Re: [dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering

2020-06-28 Thread Jerin Jacob
On Thu, Jun 4, 2020 at 11:29 AM Sunil Kumar Kori wrote: > > >-Original Message- > >From: dev On Behalf Of Harman Kalra > >Sent: Wednesday, June 3, 2020 8:22 PM > >To: Jerin Kollanukkaran ; Nithin Kumar Dabilpuram > >; Kiran Kumar Kokkilagadda > > > >Cc: dev@dpdk.org; Harman Kalra ; sta...

Re: [dpdk-dev] [PATCH] common/mlx5: fix code arrangement in tag allocation

2020-06-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:21 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] common/mlx5: fix code arrangement in tag > allocation > > Flow tag action is su

Re: [dpdk-dev] [PATCH 4/4] net/qede: add support for get register operation

2020-06-28 Thread Jerin Jacob
On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody wrote: > > Add support for .get_reg eth_dev ops which will be used to collect the > firmware debug data. > > PMD on detecting on some HW errors will collect the FW/HW Dump to a > buffer and then it will save it to a file implemented in > qede_save_fw_du

Re: [dpdk-dev] [PATCH 3/4] net/qede: add infrastructure for debug data collection

2020-06-28 Thread Jerin Jacob
On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody wrote: > > The patch adds QEDE PMD ops and APIs to calculate the size and collect > the debug dump for various firmware components. The patch adds new files > qede_debug.[ch] that has all the firmware debug data collection > infrastructure changes. > >

Re: [dpdk-dev] [PATCH v9 00/10] Windows bus/pci support

2020-06-28 Thread Tal Shnaiderman
> From: Narcisa Ana Maria Vasile > Subject: Re: [PATCH v9 00/10] Windows bus/pci support > > On Wed, Jun 24, 2020 at 11:28:37AM +0300, tal...@mellanox.com wrote: > > From: Tal Shnaiderman > > > > This patchset implements the EAL and PCI functions needed for probing > PMDs using RTE_KDRV_NONE on

Re: [dpdk-dev] [PATCH] ring: fix error vlaue of tail in the peek API for ST mode

2020-06-28 Thread Ananyev, Konstantin
> -Original Message- > From: Feifei Wang > Sent: Sunday, June 28, 2020 7:24 AM > To: Honnappa Nagarahalli ; Ananyev, Konstantin > > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; > sta...@dpdk.org > Subject: [PATCH] ring: fix error vlaue of tail in the peek API for ST mode > > The va

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Jiawei(Jonny) Wang
On Friday, June 26, 2020 7:10 PM Jerin Jacob Wrote: > > On Fri, Jun 26, 2020 at 4:16 PM Thomas Monjalon > wrote: > > > > 26/06/2020 12:35, Jerin Jacob: > > > On Fri, Jun 26, 2020 at 12:59 AM Thomas Monjalon > wrote: > > > > > > > > 25/06/2020 19:55, Jerin Jacob: > > > > > On Thu, Jun 25, 2020 a

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Jerin Jacob
On Sun, Jun 28, 2020 at 6:46 PM Jiawei(Jonny) Wang wrote: > > > On Friday, June 26, 2020 7:10 PM Jerin Jacob Wrote: > > > > On Fri, Jun 26, 2020 at 4:16 PM Thomas Monjalon > > wrote: > > > > > > 26/06/2020 12:35, Jerin Jacob: > > > > On Fri, Jun 26, 2020 at 12:59 AM Thomas Monjalon > > wrote: >

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-28 Thread Jerin Jacob
On Sun, Jun 28, 2020 at 2:14 PM Andrey Vesnovaty wrote: > > Hi > > On Fri, Jun 26, 2020 at 2:44 PM Jerin Jacob wrote: >> >> On Sat, Jun 20, 2020 at 7:02 PM Andrey Vesnovaty >> wrote: >> > >> > Hi, and thanks a lot for your RFC v1 comments. >> > >> > RFC v2 emphasize the intent for sharing the fl

Re: [dpdk-dev] [EXT] [PATCH v3 4/4] regexdev: implement regex rte level functions

2020-06-28 Thread Guy Kaneti
> +int > +rte_regexdev_rule_db_export(uint8_t dev_id, char *rule_db) { > + struct rte_regexdev *dev; > + > + RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL); > + dev = &rte_regex_devices[dev_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_db_export, > +

Re: [dpdk-dev] [PATCH 2/7] net/mlx5: use direct API to find port by device

2020-06-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 2:33 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH 2/7] net/mlx5: use direct API to find port by > device > > Using RTE_ETH_FOREACH_DEV_OF loop is n

[dpdk-dev] [PATCH 3/6] net/mlx5: add OS specific flow related utilities

2020-06-28 Thread Dekel Peled
This patch introduces the first OS specific utility functions, for use by flow engine in different OS implementation. The first utility functions are: bool mlx5_flow_os_item_supported(item) bool mlx5_flow_os_action_supported(action) They are implemented to check OS specific support for different

[dpdk-dev] [PATCH 2/6] net/mlx5: rename Verbs action to generic name

2020-06-28 Thread Dekel Peled
As part of the effort to support DPDK on Windows and other OS, rename 'verbs_action' to the generic name 'action'. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 16 drivers/net/mlx5/mlx5_flow_dv.c | 28 ++-- 2 files changed, 22 insertio

[dpdk-dev] [PATCH 0/6] net/mlx5: refactor flow infrastructure

2020-06-28 Thread Dekel Peled
As part of the effort to support DPDK on different OS, this series adds OS abstraction for flow infrastructures. The changes include renaming using generic terms, as well as OS specific functions for flow related operations and utilities. Series-acked-by: Matan Azrad Dekel Peled (6): net/mlx5:

[dpdk-dev] [PATCH 1/6] net/mlx5: rename IB flow to generic name DRV flow

2020-06-28 Thread Dekel Peled
As part of the effort to support DPDK on Windows and other OS, rename from IB related name to generic name. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h | 2 +- drivers/net/mlx5/mlx5_flow_dv.c| 11 +-- drivers/net/mlx5/mlx5_flow_verbs.c | 12 ++-- 3 file

[dpdk-dev] [PATCH 4/6] net/mlx5: add OS specific flow type selection

2020-06-28 Thread Dekel Peled
In current implementation the flow type (DV/Verbs) is selected using dedicated function flow_get_drv_type(). This patch adds OS specific function mlx5_flow_os_get_type(), to allow OS specific flow type selection. The new function is called by flow_get_drv_type(), and if it returns a valid value (D

[dpdk-dev] [PATCH 5/6] net/mlx5: add OS specific flow create and destroy

2020-06-28 Thread Dekel Peled
This patch introduces the OS specific functions, for flow create and flow destroy operations. In existing implementation, the functions to create objects (flow/table/matcher) return a pointer to the created object. The functions to destroy objects return 0 on success and errno on failure. The new

[dpdk-dev] [PATCH 6/6] net/mlx5: add OS specific flow actions operations

2020-06-28 Thread Dekel Peled
This patch introduces the OS specific functions, for flow actions create and destroy operations. In existing implementation, the functions to create flow actions return a pointer to the created action object. The new OS specific functions to create flow actions return 0 on success, and (-1) on fa

Re: [dpdk-dev] [EXT] [PATCH v3 4/4] regexdev: implement regex rte level functions

2020-06-28 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Guy Kaneti > Sent: Sunday, June 28, 2020 4:45 PM > To: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex > Rosenbau

Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-28 Thread Fady Bader
Hi Dmitry, I'm trying to run test-pmd on Windows and I ran into this error with cmdline. The error log message is : In file included from ../app/test-pmd/cmdline_flow.c:23: ..\lib\librte_cmdline/cmdline_parse_num.h:24:2: error: 'INT64' redeclared as different kind of symbol INT64 In file inclu

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-28 Thread Dekel Peled
Hi, This change is proposed for 20.11. It is suggested after internal discussions, where multiple suggestions were considered, some of them similar to the ones suggested below. Continuing the earlier correspondence in this thread, please send any other comments/suggestions you have. Regards, D

Re: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator argument

2020-06-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:30 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator > argument > > The mlx4_pci_probe function defines an struc

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Jiawei(Jonny) Wang
> -Original Message- > From: Jerin Jacob > Sent: Sunday, June 28, 2020 9:38 PM > To: Jiawei(Jonny) Wang > Cc: Thomas Monjalon ; Ori Kam > ; Slava Ovsiienko ; > Matan Azrad ; dpdk-dev ; Raslan > Darawsheh ; ian.sto...@intel.com; > f...@redhat.com; Ferruh Yigit ; Andrew Rybchenko > > Sub

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-28 Thread Phil Yang
Hi Erik, Sorry, I was on vacation. Thanks for your feedback. I will update it in the next version. Thanks, Phil > -Original Message- > From: Carrillo, Erik G > Sent: Wednesday, June 24, 2020 5:02 AM > To: Phil Yang ; dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; R

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Jiawei(Jonny) Wang
On Sunday, June 28, 2020 4:27 PM, Andrew Rybchenko wrote: > > On 6/25/20 7:26 PM, Jiawei Wang wrote: > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there's a ne

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-28 Thread Andrew Rybchenko
On 6/28/20 7:16 PM, Jiawei(Jonny) Wang wrote: > > On Sunday, June 28, 2020 4:27 PM, Andrew Rybchenko > wrote: >> >> On 6/25/20 7:26 PM, Jiawei Wang wrote: >>> When using full offload, all traffic will be handled by the HW, and >>> directed to the requested vf or wire, the control application los

[dpdk-dev] [PATCH] rte_flow: add eCPRI key fields to flow API

2020-06-28 Thread Bing Zhao
Add a new item "rte_flow_item_ecpri" in order to match eCRPI header. eCPRI is a packet based protocol used in the fronthaul interface of 5G networks. Header format definition could be found in the specification via the link below: https://www.gigalight.com/downloads/standards/ecpri-specification.p

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-28 Thread Phil Yang
> -Original Message- > From: Carrillo, Erik G > Sent: Wednesday, June 24, 2020 5:32 AM > To: Stephen Hemminger ; Phil Yang > > Cc: dev@dpdk.org; d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar ; > nd > Subject: RE: [dpdk-dev] [PATCH 2/3] eventdev: use c

[dpdk-dev] bnx2x pmd crash when launching testpmd using BCM57840 Nic.

2020-06-28 Thread Anil Kumar Koli
Hi DPDK team, 1. I am trying to run testpmd with BCM57840 NIC using DPDK 20.02.1, the process is crashing at bnx2x_write_dmae(). Had any one seen this kind of issue earlier. root@gic-mps-104-173:~/bnx2x# ./testpmd.new -l 0-3 -n 4 -w :37:00.4 -w :37:00.5 --log-level="pmd.net.bnx2x.dr

Re: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics

2020-06-28 Thread Phil Yang
Hi Erick, > -Original Message- > From: Carrillo, Erik G > Sent: Wednesday, June 24, 2020 3:39 AM > To: Phil Yang ; dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar ; > nd > Subject: RE: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barrie

Re: [dpdk-dev] [PATCH v2 4/5] telemetry: implement empty stubs for Windows

2020-06-28 Thread Stephen Hemminger
On Sun, 28 Jun 2020 13:58:50 +0300 Fady Bader wrote: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader Maybe ethdev could be modified to not depend on telemetry library directly. The current way means every application g

[dpdk-dev] [PATCH v6] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add device arguments to lock Rx/Tx contexts. Application can either choose to lock Rx or Tx contexts by using 'lock_rx_ctx' or 'lock_tx_ctx' respectively per each port. Example: -w 0002:02:00.0,lock_rx_ctx=1 -w 0002:03:00.0,lock_tx_ctx=1 Signed-off-by: Pavan Nikhil

[dpdk-dev] [PATCH] net/octeontx2: free CQ ring memzone on queue release

2020-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Free CQ ring memzone on Rx queue release. This prevents CQ using incorrect memory size when ring size is reconfigured. Signed-off-by: Pavan Nikhilesh --- This patch depends on the following patch http://patches.dpdk.org/patch/72035/ drivers/net/octeontx2/otx2_ethdev.c

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 26, 2020 10:29 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Cc: Jiang, Cheng1 ; Liang, Cunming > > Subject: Re: [PATCH v1 1/2] vhost: introduce async data path registrat

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-28 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 26, 2020 10:46 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Cc: Jiang, Cheng1 ; Liang, Cunming > > Subject: Re: [PATCH v1 2/2] vhost: introduce async enqueue for split r

Re: [dpdk-dev] [PATCH 20.08] mempool/ring: add support for new ring sync modes

2020-06-28 Thread Eads, Gage
Hi Konstantin, I think this warrants a bullet point in the release notes. With that: Acked-by: Gage Eads mailto:gage.e...@intel.com>> Thanks, Gage

[dpdk-dev] [PATCH 2/3] event/octeontx2: fix sub event type violation

2020-06-28 Thread pbhagavatula
From: Pavan Nikhilesh In OCTEONTX2 event device we use sub_event_type to store the ethernet port identifier when we receive work from OCTEONTX2 ethernet device. This violates the event device spec as sub_event_type should be 0 in the initial receive stage. Set sub_event_type to 0 after copying th

[dpdk-dev] [PATCH 1/3] event/octeontx2: fix device reconfigure

2020-06-28 Thread pbhagavatula
From: Pavan Nikhilesh When event device is re-configured maintain the event queue to event port links and event port status instead of resetting them. Fixes: cd24e70258bd ("event/octeontx2: add device configure function") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- drivers/event/oc

[dpdk-dev] [PATCH 3/3] event/octeontx2: improve datapath memory locality

2020-06-28 Thread pbhagavatula
From: Pavan Nikhilesh When event device is transmitting packet on OCTEONTX2 it needs to access the destined ethernet device TXq data. Currently, we get the TXq data through rte_eth_devices global array. Instead save the TXq address inside event port memory. Cc: sta...@dpdk.org Signed-off-by: Pa

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-28 Thread Wei Hu (Xavier)
Hi, Heinrich Kuhn & Harman Kalra & Jerin Jacob & Nithin Dabilpuram & Kiran Kumar K & Rasesh Mody & Shahed Shaikh & Qi Zhang & Xiao Wang & Beilei Xing & Jeff Guo. Could you please help to review this patch and give 'Acked-by' if there are no objects. Thanks, Xavier On 2020/6/22 16:09, Wei Hu

Re: [dpdk-dev] [PATCH v3 3/4] net/ice: support switch flow for specific L4 type

2020-06-28 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Sunday, June 28, 2020 1:02 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Lu, Nannan > ; Zhao1, Wei > Subject: [PATCH v3 3/4] net/ice: support switch flow for specific L4 type > > This patch add more specific tunnel type for

Re: [dpdk-dev] [PATCH v3 3/4] net/ice: support switch flow for specific L4 type

2020-06-28 Thread Zhao1, Wei
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 29, 2020 9:56 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Nannan > Subject: RE: [PATCH v3 3/4] net/ice: support switch flow for specific L4 type > > > > > -Original Message- > > From: Zhao1, W

Re: [dpdk-dev] [PATCH v5 00/12] enable DCF datapath configuration

2020-06-28 Thread Yang, Qiming
Reviewed-by: Qiming Yang > -Original Message- > From: Xu, Ting > Sent: Tuesday, June 23, 2020 10:38 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wu, Jingjing ; Xing, Beilei > ; Kovacevic, Marko ; > Mcnamara, John ; Xu, Ting > Subject: [PATCH v5 00/12] enable DCF datapath conf

Re: [dpdk-dev] [PATCH 4/8] net/ice/base: code clean in FDIR module

2020-06-28 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Saturday, June 27, 2020 23:06 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Stillwell Jr, Paul M > > Subject: [PATCH 4/8] net/ice/base: code clean in FDIR module > > Remove unused macro and funciton. funciton / Function > Dec

Re: [dpdk-dev] [PATCH] net/i40e: fix modifying the number of queues

2020-06-28 Thread Zhang, AlvinX
Hi Jia, > -Original Message- > From: Guo, Jia > Sent: Sunday, June 21, 2020 9:36 PM > To: Zhang, AlvinX ; dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei ; Jiang, MaoX > > Subject: Re: [PATCH] net/i40e: fix modifying the number of queues > > hi, alvin > > On 6/10/2020 8:07 PM, alvinx.z

Re: [dpdk-dev] [PATCH v2 01/42] net/e1000/base: resolve flash presence for i210 devices

2020-06-28 Thread Yang, Qiming
> -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Wednesday, June 24, 2020 15:53 > To: dev@dpdk.org > Cc: Guo, Jia ; Lu, Wenzhuo ; > Sun, GuinanX ; Neftin, Sasha > > Subject: [dpdk-dev] [PATCH v2 01/42] net/e1000/base: resolve flash > presence for i210 devices > > There

Re: [dpdk-dev] [PATCH v2 06/42] net/e1000/base: modify MAC initialization for i211

2020-06-28 Thread Yang, Qiming
This one should merge to the first patch. > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Wednesday, June 24, 2020 15:53 > To: dev@dpdk.org > Cc: Guo, Jia ; Lu, Wenzhuo ; > Sun, GuinanX ; Fujinaka, Todd > > Subject: [dpdk-dev] [PATCH v2 06/42] net/e1000/base: modify MAC

Re: [dpdk-dev] [PATCH v5 3/4] devtools: prevent use of rte atomic APIs in future patches

2020-06-28 Thread Honnappa Nagarahalli
> Subject: [PATCH v5 3/4] devtools: prevent use of rte atomic APIs in future > patches > > In order to deprecate the rte_atomic APIs, prevent the patches from using > rte_atomic APIs in the converted modules and compilers __sync built-ins in > all modules. > > The converted modules: > lib/librt

Re: [dpdk-dev] [PATCH v5 4/4] eal/atomic: add wrapper for c11 atomic thread fence

2020-06-28 Thread Honnappa Nagarahalli
> Subject: [PATCH v5 4/4] eal/atomic: add wrapper for c11 atomic thread fence > > Provide a wrapper for __atomic_thread_fence built-in to support optimized > code for __ATOMIC_SEQ_CST memory order for x86 platforms. > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Phil Yang > Reviewed-

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: Remove the re-implementation of inet_pton

2020-06-28 Thread Ibtisam Tariq
Thank you Ananyev. I will update it and send it after testing on freebsd. On Mon, Jun 22, 2020 at 5:17 PM Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > > > > > inet_pton4 and inet_pton6 was reimplemented. Replace implementation of > > inet_pton4 and inet_pton6 with libc inet_pto

[dpdk-dev] [PATCH v5 0/5] enable more PPPoE packet type for switch

2020-06-28 Thread Wei Zhao
1. add more support for switch parser of pppoe packet. 2. add check for NVGRE protocol 3. support flow for specific L4 type 4. add input set byte number check 5. fix typo This patchset is based on: [1] https://patches.dpdk.org/cover/70762/ : net/ice: base code update Depends-on: series-10300 v2:

[dpdk-dev] [PATCH v5 3/5] net/ice: support switch flow for specific L4 type

2020-06-28 Thread Wei Zhao
This patch add more specific tunnel type for ipv4/ipv6 packet, it enable tcp/udp layer of ipv4/ipv6 as L4 payload but without L4 dst/src port number as input set for the switch filter rule. Fixes: 47d460d63233 ("net/ice: rework switch filter") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- dri

[dpdk-dev] [PATCH v5 1/5] net/ice: add support more PPPoE packet type for switch

2020-06-28 Thread Wei Zhao
This patch add more support for switch parser of pppoe packet, it enable parse tcp/udp L4 layer and ipv4/ipv6 L3 layer parser for pppoe payload, so we can use L4 dst/src port and L3 ip address as input set for switch filter pppoe related rule. Signed-off-by: Wei Zhao --- doc/guides/rel_notes/rel

[dpdk-dev] [PATCH v5 2/5] net/ice: fix tunnel type for switch rule

2020-06-28 Thread Wei Zhao
This patch add check for protocol type of IPv4 packet, it need to update tunnel type when NVGRE is in payload. Fixes: 6bc7628c5e0b ("net/ice: change default tunnel type") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 7 ++- 1 file changed, 6 insertion

[dpdk-dev] [PATCH v5 5/5] net/ice: fix typo

2020-06-28 Thread Wei Zhao
fix typo of "valid". Fixes: 8f5d8e74fb38 ("net/ice: support flow for AH ESP and L2TP") Fixes: 66ff8851792f ("net/ice: support ESP/AH/L2TP") Fixes: 45b53ed3701d ("net/ice: support IPv6 NAT-T") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 76 ++

[dpdk-dev] [PATCH v5 4/5] net/ice: add input set byte number check

2020-06-28 Thread Wei Zhao
This patch add the total input set byte number check, as there is a hardware requirement for the total number of 32 byte. Fixes: 47d460d63233 ("net/ice: rework switch filter") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 43 +++--

Re: [dpdk-dev] [PATCH v5 00/12] enable DCF datapath configuration

2020-06-28 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, June 29, 2020 10:44 AM > To: Xu, Ting ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; Kovacevic, Marko > ; Mcnamara, John > Subject: RE: [PATCH v5 00/12] enable DCF datapath configuration > > Reviewed-by: Qim

Re: [dpdk-dev] [PATCH v5 3/4] devtools: prevent use of rte atomic APIs in future patches

2020-06-28 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, June 29, 2020 12:38 PM > To: Phil Yang ; dev@dpdk.org > Cc: mattias.ronnb...@ericsson.com; m...@smartsharesystems.com; > step...@networkplumber.org; tho...@monjalon.net; > bruce.richard...@intel.com; ferruh.yi...@intel.com;

Re: [dpdk-dev] [PATCH v2] net/ice: support original VF action for DCF

2020-06-28 Thread Yang, Qiming
> -Original Message- > From: Xu, Ting > Sent: Thursday, June 11, 2020 18:15 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Ye, Xiaolong > Subject: [PATCH v2] net/ice: support original VF action for DCF > > From: Qi Zhang > > Add support to allow the original VF actions in DCF.

Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-28 Thread Ranjit Menon
On 6/28/2020 7:20 AM, Fady Bader wrote: Hi Dmitry, I'm trying to run test-pmd on Windows and I ran into this error with cmdline. The error log message is : In file included from ../app/test-pmd/cmdline_flow.c:23: ..\lib\librte_cmdline/cmdline_parse_num.h:24:2: error: 'INT64' redeclared as dif