Hi,
> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Michael Baum
> Sent: Wednesday, June 24, 2020 4:30 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <ma...@mellanox.com>; Slava Ovsiienko
> <viachesl...@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx4: use anonymous DV allocator
> argument
>
> The mlx4_pci_probe function defines an struct mlx4dv_ctx_allocators type
> variable several hundred rows after it starts, with the only use it
> being passed as a parameter to the mlx4_glue->dv_set_context_attr
> function.
> However, according to DPDK Coding Style Guidelines, variables should be
> declared at the start of a block of code rather than in the middle.
> Therefore, to improve the Coding Style, the variable is passed directly
> to the function without declaring it before.
>
> Signed-off-by: Michael Baum <michae...@mellanox.com>
> Acked-by: Matan Azrad <ma...@mellanox.com>
> ---
> drivers/net/mlx4/mlx4.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index 5d72027..ff270b4 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -1054,14 +1054,13 @@ struct mlx4_conf {
> eth_dev->dev_ops = &mlx4_dev_ops;
> #ifdef HAVE_IBV_MLX4_BUF_ALLOCATORS
> /* Hint libmlx4 to use PMD allocator for data plane resources
> */
> - struct mlx4dv_ctx_allocators alctr = {
> - .alloc = &mlx4_alloc_verbs_buf,
> - .free = &mlx4_free_verbs_buf,
> - .data = priv,
> - };
> err = mlx4_glue->dv_set_context_attr
> (ctx, MLX4DV_SET_CTX_ATTR_BUF_ALLOCATORS,
> - (void *)((uintptr_t)&alctr));
> + (void *)((uintptr_t)&(struct mlx4dv_ctx_allocators){
> + .alloc = &mlx4_alloc_verbs_buf,
> + .free = &mlx4_free_verbs_buf,
> + .data = priv,
> + }));
> if (err)
> WARN("Verbs external allocator is not supported");
> else
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
