Re: [dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Coyle, David > Sent: Tuesday, June 23, 2020 11:14 AM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Brendan ; >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] meter: remove inline functions from export list

2020-06-23 Thread Thomas Monjalon
17/06/2020 10:24, Fady Bader: > The code didn't compile when using exported meter functions under windows. > > error LNK2001: unresolved external symbol > rte_meter_srtcm_color_aware_check > error LNK2001: unresolved external symbol > rte_meter_srtcm_color_blind_check > error LNK2001: unresolved e

Re: [dpdk-dev] [PATCH v2 1/2] eal: move OS common debug functions to single file

2020-06-23 Thread Thomas Monjalon
08/06/2020 10:32, tal...@mellanox.com: > From: Tal Shnaiderman > > Move common functions between Unix and Windows to eal_common_debug.c. [...] > --- /dev/null > +++ b/lib/librte_eal/common/eal_common_debug.c > @@ -0,0 +1,58 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Me

Re: [dpdk-dev] [PATCH v2 3/6] crypto/aesni_mb: add support for DOCSIS protocol

2020-06-23 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Tuesday, June 23, 2020 11:14 AM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Bren

Re: [dpdk-dev] [PATCH v2 5/6] test/crypto: add DOCSIS security test cases

2020-06-23 Thread De Lara Guarch, Pablo
Hi David, > -Original Message- > From: Coyle, David > Sent: Tuesday, June 23, 2020 11:14 AM > To: akhil.go...@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Ryan, Bren

Re: [dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-23 Thread Akhil Goyal
Hi David, > +/** DOCSIS direction */ > +enum rte_security_docsis_direction { > + RTE_SECURITY_DOCSIS_UPLINK, > + /**< Uplink > + * - Decryption, followed by CRC Verification > + */ > + RTE_SECURITY_DOCSIS_DOWNLINK, > + /**< Downlink > + * - CRC Generation, followed b

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-23 Thread Akhil Goyal
Hi Konstantin/David, > > Hi David, > > > > > > > > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > > > rte_crypto_op { > > > > > > struct rte_crypto_asym_op asym[0]; > > > > > > /**< Asymmetric operation parameters */ > > > > > >

Re: [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Monday, June 22, 2020 5:12 AM > To: Phil Yang ; dev@dpdk.org; Carrillo, Erik G > > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Dharmik Thakkar > ; nd > Subject: RE: [dpdk-dev] [PATCH 3/3

[dpdk-dev] [PATCH v3 1/2] eal: move OS common debug functions to single file

2020-06-23 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_debug.c. Those functions are rte_exit, __rte_panic and rte_dump_registers which has the same implementation on Unix and Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/eal_common_debug.c | 59

[dpdk-dev] [PATCH v3 2/2] eal/windows: support debug calls

2020-06-23 Thread talshn
From: Tal Shnaiderman Support the debug functions in eal_common_debug.c for Windows. Implementation of rte_dump_stack to get a backtrace similarly to Unix and of rte_eal_cleanup in eal.c. Signed-off-by: Tal Shnaiderman --- config/meson.build | 1 + lib/librte_eal/common/meson

[dpdk-dev] [PATCH v3 0/2] Support EAL debug functions on Windows

2020-06-23 Thread talshn
From: Tal Shnaiderman This patchset adds support for the EAL debug function on Windows by implementing backtracing in rte_dump_stack and cleanup calls in rte_eal_cleanup. Additionally, the functions rte_exit, __rte_panic and rte_dump_registers were moved to a common file to avoid code duplicat

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com > Subject: [PATCH 2/3] e

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Stephen Hemminger
On Fri, 12 Jun 2020 19:19:57 +0800 Phil Yang wrote: > /* Track which cores have actually armed a timer */ > struct { > - rte_atomic16_t v; > + int16_t v; > } __rte_cache_aligned in_use[RTE_MAX_LCORE]; Do you really need this to be cache aligned (ie one p

Re: [dpdk-dev] [PATCH v3] maintainers: update for interrupt subsystem

2020-06-23 Thread Thomas Monjalon
17/06/2020 14:28, Harman Kalra: > updating MAINTAINERS file for interrupt subsytem. > > Signed-off-by: Harman Kalra > --- > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Interrupt Subsystem > +M: Harman Kalra > +F: lib/librte_eal/*/*interrupts.* > +F: app/test/test_interrupts.c Applied, thanks for v

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, June 23, 2020 4:20 PM > To: Phil Yang > Cc: dev@dpdk.org; Carrillo, Erik G ; > d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v3 0/2] Support EAL debug functions on Windows

2020-06-23 Thread Dmitry Kozlyuk
On Tue, 23 Jun 2020 23:57:19 +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > This patchset adds support for the EAL debug function on Windows by > implementing backtracing in rte_dump_stack and cleanup calls in > rte_eal_cleanup. > > Additionally, the functions rte_exit, __rte_p

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-23 Thread Ananyev, Konstantin
> Hi Vladimir, > > > --- /dev/null > > +++ b/lib/librte_hash/k32v64_hash.c > > @@ -0,0 +1,277 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2020 Intel Corporation > > + */ > > + > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#include "k32v64_

Re: [dpdk-dev] [PATCH v8 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-23 Thread Dmitry Kozlyuk
[snip] > + /* kernel driver type is unsupported */ > + RTE_LOG(DEBUG, EAL, > + "kernel driver type for PCI device " PCI_PRI_FMT "," > + " is unsupported", Nit: log messages usually start with a capital. > + dev->a

[dpdk-dev] [PATCH 2/2] net/netvsc: detach external buffer on failure

2020-06-23 Thread longli
From: Long Li When external buffer is used, driver should detach it if it doesn't make it successfully to the queue. Signed-off-by: Long Li --- drivers/net/netvsc/hn_rxtx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c ind

[dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path

2020-06-23 Thread longli
From: Long Li When rte_pktmbuf_attach_extbuf() is used, the driver should not decrease the reference count in its callback function hn_rx_buf_free_cb, because the reference count is already decreased by rte_pktmbuf. Doing it twice may result in underflow and driver may never send an ack packet ov

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-23 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Friday, May 8, 2020 12:59 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce > Subject: [PATCH v4 1/4] hash: add kv hash library > > KV hash is a special optimized key-value sto

[dpdk-dev] [PATCH v4] net/ice: initialize and update RSS based on user request

2020-06-23 Thread Junyu Jiang
Initialize and update RSS configure based on user request (rte_eth_rss_conf) from dev_configure and .rss_hash_update ops. All previous default configure has been removed. Signed-off-by: Junyu Jiang --- v3->v4: change the return value to success when rss_hf value update to 0. v2->v3: change the

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: restrict pointer aliasing for NEON vpmd

2020-06-23 Thread Joyce Kong
> -Original Message- > From: Phil Yang > Sent: Tuesday, June 23, 2020 5:06 PM > To: Maxime Coquelin ; Joyce Kong > ; jer...@marvell.com; zhihong.w...@intel.com; > xiaolong...@intel.com; Honnappa Nagarahalli > ; Ruifeng Wang > > Cc: dev@dpdk.org > Subject: RE: [PATCH v1 1/2] net/virtio: re

Re: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch filter

2020-06-23 Thread Sun, GuinanX
Hi Guojia > -Original Message- > From: Guo, Jia > Sent: Sunday, June 21, 2020 8:29 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei > Subject: Re: [PATCH] net/i40e: enable port filter by switch filter > > hi, guinan > > On 6/11/2020 1:24 PM, Guinan Sun wrote: > > This patch enabl

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Chengchang Tang
On 2020/6/23 17:30, Andrew Rybchenko wrote: > On 6/23/20 9:48 AM, Chengchang Tang wrote: >> In common practice, PMD configure the rx_buf_size according to the data >> room size of the object in mempool. But in fact the final value is related >> to the specifications of hw, and its values will aff

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: restrict pointer aliasing for NEON vpmd

2020-06-23 Thread Stephen Hemminger
On Wed, 24 Jun 2020 02:58:28 + Joyce Kong wrote: > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other p

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
Ho Maxime Good morning From: Maxime Coquelin: > On 6/23/20 4:52 PM, Matan Azrad wrote: > > > > > >> -Original Message- > >> From: Maxime Coquelin > >> Sent: Tuesday, June 23, 2020 4:56 PM > >> To: Matan Azrad ; Xiao Wang > >> > >> Cc: dev@dpdk.org > >> Subject: Re: [PATCH v1 3/4] vhost:

<    1   2