Re: [dpdk-dev] 19.11.3 patches review and test

2020-06-10 Thread Yu, PingX
Hi Luca, Update LTS 19.11.3 test result for Intel part. All passed and no new issue is found. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e):Passed * PF(ixgbe):Passed * PF(ice):Passed * VF(i40e):Passed * VF(ixgbe):Passed * VF(ice):Passed * Build or compile: Passed * Intel

[dpdk-dev] [RFC] net/mlx5: add queue start and stop feature

2020-06-10 Thread Viacheslav Ovsiienko
The mlx5 PMD does not support queue_start and queue_stop eth_dev API routines, queue can't be suspended and resumed during device operation. There is the use case when this feature is crucial for applications: - there is the secondary process handling the queue - secondary process crashed/aborted

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-06-10 Thread Thomas Monjalon
04/05/2020 16:13, Dan Gora: > On Mon, May 4, 2020 at 5:04 AM Mattias Rönnblom > wrote: > > The make build is going away completely. > > Well it's not going away for at least a year or two It will be removed in 20.11. > and that has > nothing to do with the issues at hand here. And I sure hope

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-06-10 Thread Thomas Monjalon
09/06/2020 17:37, Dan Gora: > On Tue, Jun 2, 2020 at 2:10 AM Dan Gora wrote: > > > > Can these patches be considered again for 20.08? > > > > I thought that I addressed all of the issues or at least provided > > reasonable responses to all of the concerns. > > So I guess I'll take that as a "no".

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-10 Thread Andrew Rybchenko
On 6/10/20 8:22 AM, Jerin Jacob wrote: > On Tue, Jun 9, 2020 at 7:27 PM Bruce Richardson > wrote: >> >> On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: >>> On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: > > On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger w

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-06-10 Thread Luca Boccassi
On Wed, 2020-06-10 at 10:15 +0200, Thomas Monjalon wrote: > 09/06/2020 17:37, Dan Gora: > > On Tue, Jun 2, 2020 at 2:10 AM Dan Gora wrote: > > > Can these patches be considered again for 20.08? > > > > > > I thought that I addressed all of the issues or at least provided > > > reasonable response

Re: [dpdk-dev] 19.11.3 patches review and test

2020-06-10 Thread Luca Boccassi
On Wed, 2020-06-10 at 07:19 +, Yu, PingX wrote: > Hi Luca, > Update LTS 19.11.3 test result for Intel part. All passed and no new issue > is found. > > * Intel(R) Testing > > # Basic Intel(R) NIC testing > * PF(i40e):Passed > * PF(ixgbe):Passed > * PF(ice):Passed > * VF(i40e):Passed

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-10 Thread Jerin Jacob
On Wed, Jun 10, 2020 at 1:57 PM Andrew Rybchenko wrote: > > On 6/10/20 8:22 AM, Jerin Jacob wrote: > > On Tue, Jun 9, 2020 at 7:27 PM Bruce Richardson > > wrote: > >> > >> On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: > >>> On 6/9/20 1:00 PM, Ananyev, Konstantin wrote: >

[dpdk-dev] [PATCH] examples/ipsec-secgw: enable rte_flow based packet distribution

2020-06-10 Thread Ankur Dwivedi
From: Anoob Joseph RTE_FLOW API allows hardware parsing and steering of packets to specific queues which helps in distributing ingress traffic across various cores. Adding 'flow' rules allows user to specify the distribution required. Signed-off-by: Anoob Joseph Change-Id: I353e104cab7fae2520f7

Re: [dpdk-dev] 19.11.3 patches review and test

2020-06-10 Thread Ali Alnubani
Hi, > -Original Message- > From: luca.bocca...@gmail.com > Sent: Wednesday, June 3, 2020 10:44 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; Jo

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: enable rte_flow based packet distribution

2020-06-10 Thread Ankur Dwivedi
From: Anoob Joseph RTE_FLOW API allows hardware parsing and steering of packets to specific queues which helps in distributing ingress traffic across various cores. Adding 'flow' rules allows user to specify the distribution required. Signed-off-by: Anoob Joseph --- v2: * Removed Change-Id do

[dpdk-dev] [PATCH] maintainers: update for netcope sze/nfb

2020-06-10 Thread Jakub Neruda
Setting Martin Spinler as new and only maintainer for Netcope libsze2/nfb drivers Signed-off-by: Jakub Neruda --- MAINTAINERS | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e739b87..b026287 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

Re: [dpdk-dev] very high VIRT memory usage

2020-06-10 Thread Burakov, Anatoly
On 09-Jun-20 8:40 PM, Francesco wrote: Hi Anatoly, Thanks a lot for the detailed response! Good to know anyway there's a "fix" already done in 20.05... also because I'm not interested in supporting secondary processes or having shared memory... Looking forward for the backports in stable bra

Re: [dpdk-dev] very high VIRT memory usage

2020-06-10 Thread Burakov, Anatoly
On 09-Jun-20 4:35 PM, Stephen Hemminger wrote: On Tue, 9 Jun 2020 14:39:54 +0100 "Burakov, Anatoly" wrote: On 09-Jun-20 2:13 PM, Ferruh Yigit wrote: On 6/9/2020 1:46 PM, Burakov, Anatoly wrote: On 08-Jun-20 12:03 PM, Francesco wrote: Hi all, I upgraded an old DPDK-based app which was using

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-10 Thread Andrew Rybchenko
On 6/10/20 11:47 AM, Jerin Jacob wrote: > On Wed, Jun 10, 2020 at 1:57 PM Andrew Rybchenko > wrote: >> >> On 6/10/20 8:22 AM, Jerin Jacob wrote: >>> On Tue, Jun 9, 2020 at 7:27 PM Bruce Richardson >>> wrote: On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote: > On 6/9/

[dpdk-dev] [PATCH v1 3/8] net/mlx5: move socket files under Linux directory

2020-06-10 Thread Ophir Munk
mlx5_socket.c file is using APIs which are Linux specifics. Therefore move it (including mlx5_socket.h) from net/mlx5 directory to net/mlx5/linux directory. This commit also updates the Makefile and the meson files. Signed-off-by: Ophir Munk --- drivers/net/mlx5/Makefile| 2 +- dr

[dpdk-dev] [PATCH v1 2/8] net/mlx5: rename ib in names

2020-06-10 Thread Ophir Munk
Renames in this commit: mlx5_ibv_list -> mlx5_dev_ctx_list mlx5_alloc_shared_ibctx -> mlx5_alloc_shared_dev_ctx mlx5_free_shared_ibctx -> mlx5_free_shared_dev_ctx mlx5_ibv_shared_port -> mlx5_dev_shared_port ibv_port -> dev_port Signed-off-by: Ophir Munk --- drivers/net/mlx5/linux/mlx5_os.c |

[dpdk-dev] [PATCH v1 0/8] mlx5 PMD multi OS support - part #2

2020-06-10 Thread Ophir Munk
This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. Part #2 v1: Initial release Ophir Munk (8): net/mlx5: remove dv dependency in mlx5_dev_ctx_shared struct net/mlx5: rename ib in names net/mlx5: move socket files under Linux directory net/mlx5: split ml

[dpdk-dev] [PATCH v1 1/8] net/mlx5: remove dv dependency in mlx5_dev_ctx_shared struct

2020-06-10 Thread Ophir Munk
Replace 'struct mlx5dv_devx_cmd_comp *' with 'void *' in 'struct mlx5_dev_ctx_shared'. Signed-off-by: Ophir Munk --- drivers/net/mlx5/linux/mlx5_os.c | 12 +++- drivers/net/mlx5/mlx5.h | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/linux

[dpdk-dev] [PATCH v1 4/8] net/mlx5: split mlx5 ethdev under Linux directory

2020-06-10 Thread Ophir Munk
File mlx5_ethdev.c is partially moved to linux/mlx5_ethdev_os.c for functions which are Linux specific. Functions which are Linux agnostics remain in mlx5_ethdev.c file. Signed-off-by: Ophir Munk --- drivers/net/mlx5/Makefile |1 + drivers/net/mlx5/linux/meson.build |1

[dpdk-dev] [PATCH v1 7/8] common/mlx5: exclude OS dependency in devx commands

2020-06-10 Thread Ophir Munk
Shared function mlx5_devx_cmd_mkey_create() reads the OS pagesize by calling a Linux API: 'sysconf(_SC_PAGESIZE)'. Wrap this call with a shared API 'mlx5_os_get_page_size()' which contains the specific OS implementation. Signed-off-by: Ophir Munk --- drivers/common/mlx5/linux/mlx5_common_os.c |

[dpdk-dev] [PATCH v1 5/8] net/mlx5: refactor eth dev ops for Linux

2020-06-10 Thread Ophir Munk
There are three types of eth_dev_ops: primary, secondary and isolate. Their function calls assignments are moved from common file mlx5.c to the Linux specific file linux/mlx5_os.c. Signed-off-by: Ophir Munk --- drivers/net/mlx5/linux/mlx5_os.c | 135 ++- drive

[dpdk-dev] [PATCH v1 6/8] common/mlx5: exclude ibv dependent calls in devx commands

2020-06-10 Thread Ophir Munk
Function mlx5_devx_cmd_qp_query_tis_td() receives as parameter a pointer to verbs QP returned by ibv_create_qp. Therefore support it only if HAVE_IBV_FLOW_DV_SUPPORT is defined. Otherwise return an error ENOTSUP. Signed-off-by: Ophir Munk --- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++ 1 f

[dpdk-dev] [PATCH v1 8/8] net/mlx5: refactor statistics

2020-06-10 Thread Ophir Munk
mlx5 statistics are calculated by several methods: 1. In software when packets go through datapath. 2. Calling ioctl with ETHTOOL command (Linux specific). 3. Reading counters from SYSFS device path (Linux specific). The Linux related functions are moved to file linux/mlx5_os.c. Signed-off-by: Op

Re: [dpdk-dev] [PATCH 0/4] Bugfixes of coverity defects for hns3 PMD driver

2020-06-10 Thread Ferruh Yigit
On 6/9/2020 9:44 AM, Wei Hu (Xavier) wrote: > This series are bugfixes of coverity defects warning for hns3 PMD driver. > > Hongbo Zheng (2): > net/hns3: avoid unchecked return value in reset err process > net/hns3: fix unintended sign extension in dump operation > > Wei Hu (Xavier) (2): >

Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

2020-06-10 Thread Bruce Richardson
On Wed, Jun 10, 2020 at 12:28:53PM +0300, Andrew Rybchenko wrote: > On 6/10/20 11:47 AM, Jerin Jacob wrote: > > On Wed, Jun 10, 2020 at 1:57 PM Andrew Rybchenko > > wrote: > >> > >> On 6/10/20 8:22 AM, Jerin Jacob wrote: > >>> On Tue, Jun 9, 2020 at 7:27 PM Bruce Richardson > >>> wrote: > >

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-10 Thread Sunil Kumar Kori
>-Original Message- >From: Muhammad Bilal >Sent: Tuesday, June 2, 2020 5:57 PM >To: Sunil Kumar Kori >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh >Bhagavatula ; dev@dpdk.org; >jgraj...@cisco.com; vipin.vargh...@intel.com >Subject: Re: [EXT] [PATCH 1/5] example

Re: [dpdk-dev] very high VIRT memory usage

2020-06-10 Thread Francesco
Hi Anatoly Il giorno mer 10 giu 2020 alle ore 11:24 Burakov, Anatoly < anatoly.bura...@intel.com> ha scritto: > On 09-Jun-20 8:40 PM, Francesco wrote: > > Hi Anatoly, > > > > Thanks a lot for the detailed response! > > Good to know anyway there's a "fix" already done in 20.05... also > > because

Re: [dpdk-dev] [PATCH] lib/ring: fix the bug of HTS/RTS bulk enqueue

2020-06-10 Thread Ananyev, Konstantin
> Directly call "_rte_ring_do_enqueue_elem" function can result in the > process skips the "switch" order and cannot call the APIs of RTS and HTS > mode in "rte_ring_enqueue_bulk_elem" function. > > To fix it, remove the unnecessary function and make > "_rte_ring_do_enqueue_elem" consistent with

[dpdk-dev] [PATCH v2] net/pcap: support software Tx nanosecond timestamps

2020-06-10 Thread Vivien Didelot
When capturing packets into a PCAP file, DPDK currently uses microseconds for the timestamps. But libpcap supports interpreting tv_usec as nanoseconds depending on the file timestamp precision, as of commit ba89e4a18e8b ("Make timestamps precision configurable"). To support this, use PCAP_TSTAMP_P

Re: [dpdk-dev] [PATCH v2] net/pcap: support software Tx nanosecond timestamps

2020-06-10 Thread Vivien Didelot
Hi Stephen, On Tue, 9 Jun 2020 12:43:57 -0700, Stephen Hemminger wrote: > On Tue, 9 Jun 2020 15:07:19 -0400 > Vivien Didelot wrote: > > > > > +#define NSEC_PER_SEC 10L > > + > > static inline void > > calculate_timestamp(struct timeval *ts) { > > uint64_t cycles; > > @@

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-06-10 Thread Song, Keesang
[AMD Public Use] Hi Kevin and Luca, We are still waiting for the response. Can you help on this for the backports in 18.11 and 19.11? It would work for our customers even with changing the default value of ' CONFIG_RTE_MAX_LCORE' to 256 in common_base file in 18.11 and 19.11. Thanks, Keesang

Re: [dpdk-dev] [PATCH v6 04/11] eal/mem: extract common code for memseg list initialization

2020-06-10 Thread Burakov, Anatoly
On 09-Jun-20 3:17 PM, Dmitry Kozlyuk wrote: On Tue, 9 Jun 2020 14:36:10 +0100 "Burakov, Anatoly" wrote: On 03-Jun-20 12:03 AM, Dmitry Kozlyuk wrote: All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private fu

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-10 Thread Ananyev, Konstantin
Hi David, > > > > > > > > /** Status of crypto operation */ > > > @@ -121,6 +123,13 @@ struct rte_crypto_op { > > > struct rte_crypto_asym_op asym[0]; > > > /**< Asymmetric operation parameters */ > > > > > > +#ifdef RTE_LIBRTE_SECURITY > > > + uint8_t security[0];

Re: [dpdk-dev] 19.11.3 patches review and test

2020-06-10 Thread Luca Boccassi
On Wed, 2020-06-10 at 09:06 +, Ali Alnubani wrote: > Hi, > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Wednesday, June 3, 2020 10:44 PM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Akhil Goyal ; Ali Alnubani ; > > benjamin.wal...@intel.co

[dpdk-dev] [PATCH 00/36] bnxt fixes and enhancements

2020-06-10 Thread Somnath Kotur
This patchset consists of fixes for the host based flow table management mechanism that was introduced in 20.05. Also has some enhancements that add offload support for vxlan encap/decap and on-chip exact match flows. Kishore Padmanabha (30): bnxt/tf_ulp: Created sub Makefile for tf_ulp and tf_c

[dpdk-dev] [PATCH 03/36] net/bnxt: add vfr flag to the mark manager

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Add support for the vfr flag to the mark manager Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxr.c| 3 ++- drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c | 7 +++ drivers/net/bnxt/tf_ulp

[dpdk-dev] [PATCH 05/36] net/bnxt: remove mem field from mapper class table

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Remove the unused mem field in the ulp mapper class table structure Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 2 +- drivers/net/bnxt

[dpdk-dev] [PATCH 02/36] net/bnxt: remove svif and vlan information from header bitmap

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The svif and vlan information are removed from header bitmap signature so that the matching algorithm does not use these fields to perform matching. So flows with or without vlan tag could use the same flow template. Signed-off-by: Kishore Padmanabha Reviewed-by: Kishor

[dpdk-dev] [PATCH 04/36] net/bnxt: support for mark action for LFID rules

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The ulp mapper changes to support mark actions for non GFID entries that support only LFID rules. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 198 +++---

[dpdk-dev] [PATCH 01/36] net/bnxt: Makefile changes

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Created sub Makefile for tf_ulp and and tf_core Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/Makefile | 29 + drivers/net/bnxt/tf_core/Makefile | 17 +++

[dpdk-dev] [PATCH 10/36] net/bnxt: extend default identifier list to be global resource list

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The default identifier list in ulp mapper is extended to support other truflow resource types and not just identifiers. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 231 +

[dpdk-dev] [PATCH 08/36] net/bnxt: add support for computed header field in result opcode

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Added support for computed header fields in the result field processing. The computed header fields are fields that are extracted from header fields or derived from data that is not part of the flow command but shall be used in setting up of the flow rule. Signed-off-by:

[dpdk-dev] [PATCH 06/36] net/bnxt: support more resource functions in flow database

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Added support to include more resource functions in the flow database. The number of bits increased from 3 to 8 for storing the resource function. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ul

[dpdk-dev] [PATCH 07/36] net/bnxt: rename the ulp action bitmap enumeration values

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The ulp action bitmap enumeration values that contain open flow string are renamed Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_template_db.h | 12 ++--

[dpdk-dev] [PATCH 09/36] net/bnxt: updated compute field list and access macros

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The compute field is extended to support action fields and not just header fields, hence CHF is changed to CF. The access macro for compute field is renamed to address this. Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/bnxt_ulp_f

[dpdk-dev] [PATCH 13/36] net/bnxt: move vfr flag from computed field list to class table

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The vf representor flag is moved from computed field list to class table so it can be set in the template details. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 14 ++-

[dpdk-dev] [PATCH 15/36] net/bnxt: direction bit needs to be added to the action bitmap

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha This is a fix to add the direction bit to the action bitmap during flow parsing, so that egress flows can be matched to the template signature. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Michael Baucom S

[dpdk-dev] [PATCH 11/36] net/bnxt: add resource sub type to class and action tables

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Added support for resource sub type to class and action tables renamed table id to resource type. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 38 +--

[dpdk-dev] [PATCH 14/36] net/bnxt: add support for action bitmap opcode in result field processing

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha This enables using the action bitmap to update the action result fields in the flow creation instead of using computed header fields. An example would be the usage of the vlan pop action bitmap that is used to updated action result field as part of this commit. Signed-of

[dpdk-dev] [PATCH 12/36] net/bnxt: remove cache tbl id from the mapper class table

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The cache table id is not needed anymore since the value can be calculated from resource sub type and direction. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 21

[dpdk-dev] [PATCH 16/36] net/bnxt: remove cache_tbl_id enums

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The bnxt_ulp_cache_tbl_id enums are not required any longer since the index is now calculated using resource sub type and direction. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ccxsw Build Signed-off-by: Somnath Kotur --- drivers/net/b

[dpdk-dev] [PATCH 20/36] net/bnxt: rename regfile_wr_idx to regfile_idx

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The regfile index shall be used for both write and read operations. Hence the field is renamed. Signed-off-by: Kishore Padmanabha Reviewed-by: Venkat Duvvuru Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c |

[dpdk-dev] [PATCH 18/36] net/bnxt: use vport in the phy port act handler

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The phy port action handler should get vport details and not vnic id. The fix is to calculate the vport of the given port. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 10 +++

[dpdk-dev] [PATCH 21/36] net/bnxt: remove unused enum in regfile index

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Removed the unsed enum BNXT_ULP_REGFILE_INDEX_CACHE_ENTRY_PTR Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_template_db.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff -

[dpdk-dev] [PATCH 17/36] net/bnxt: extend index table processing to process action templates

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The index table processing is extended to address encapsulation fields so that action template index table can be processed by a common index processing function that can process both class and action index tables. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael

[dpdk-dev] [PATCH 19/36] net/bnxt: add enum to the critical resource

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The critical resource field in the template table is assigned enumeration values instead of hard coded values. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 14 +++---

[dpdk-dev] [PATCH 23/36] net/bnxt: rename the enums in the bnxt_ulp_resource_sub_type

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The enums in the bnxt_ulp_resource_sub_type are renamed to reflect the table types explicitly. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_template_db.c | 30 --

[dpdk-dev] [PATCH 26/36] net/bnxt: flow db api to get vf rep action record

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Added flow db api to get the vf representor action record for a given flow. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_flow_db.c | 200 +++--- drivers/net/bnxt

Re: [dpdk-dev] very high VIRT memory usage

2020-06-10 Thread Burakov, Anatoly
On 10-Jun-20 11:14 AM, Francesco wrote: Hi Anatoly Il giorno mer 10 giu 2020 alle ore 11:24 Burakov, Anatoly mailto:anatoly.bura...@intel.com>> ha scritto: On 09-Jun-20 8:40 PM, Francesco wrote: > Hi Anatoly, > > Thanks a lot for the detailed response! > Good to know a

[dpdk-dev] [PATCH 27/36] net/bnxt: parse ipv6 vtc_flow field for more granularly

2020-06-10 Thread Somnath Kotur
From: Venkat Duvvuru ipv6 vtc_flow contains three fields 1. Version 2. Priority / Traffic Class 3. Flow Label Currently, these are not parsed separately and also not set separately in the field bitmap by the flow parser. However, the template treats them separately. As a result, the flow matching

[dpdk-dev] [PATCH 24/36] net/bnxt: add a devarg to set max flow count

2020-06-10 Thread Somnath Kotur
From: Shuanglin Wang User could set max flow count by passing a devarg "-w :0d:00.0,max_num_kflows=64" to a DPDK application; The value must be not less than 32K and be power-of-2; the default value is 32K. Signed-off-by: Shuanglin Wang Reviewed-by: Kishore Padmanabha Signed-off-by: Somnat

[dpdk-dev] [PATCH 22/36] net/bnxt: rename an enum in the regfile index

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The BNXT_ULP_REGFILE_INDEX_ACTION_PTR_MAIN is renamed to BNXT_ULP_REGFILE_INDEX_MAIN_ACTION_PTR since it is the main action pointer. Signed-off-by: Kishore Padmanabha Reviewed-by: Somnath Kotur Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net

[dpdk-dev] [PATCH 31/36] net/bnxt: change opcode for adding pad to setting zero for common usage

2020-06-10 Thread Somnath Kotur
From: Mike Baucom The ADD_PAD opcode is now SET_TO_ZERO. This change better reflects the intent of the opcode and allows it to be used in more circumstances without overloading the term pad. Signed-off-by: Mike Baucom Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers

[dpdk-dev] [PATCH 28/36] net/bnxt: remove the implicit bitset update for vnic action

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The implicit update of the egress vnic action bitset for a flow that does not specify the forwarding port explicitly is removed. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c |

[dpdk-dev] [PATCH 33/36] net/bnxt: add support for internal exact match flows

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Added support of internal exact match flows and the action mark is supported for these flows. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h | 2 ++ drivers/net/bnxt/bnxt_rxr.c

[dpdk-dev] [PATCH 34/36] net/bnxt: enable vfr flag processing with mark db opcode

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha Removed the mark and vfr flags and replaced it with the new opcode and added the vfr flag process in mark database Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_mapper.c| 74

[dpdk-dev] [PATCH 32/36] net/bnxt: optimized key/mask/result fields to use set to zero opcode

2020-06-10 Thread Somnath Kotur
From: Mike Baucom The fields that were setting a constant zero have now been switched to use the new SET_TO_ZERO opcode as an optimization. The SET_TO_ZERO does not copy data into the key/result/mask fields, but rather simply increments the write pointer. Signed-off-by: Mike Baucom Reviewed-by

[dpdk-dev] [PATCH 36/36] net/bnxt: update ulp template database for new opcodes

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The ulp template database is updated to support the new combined opcodes. Signed-off-by: Kishore Padmanabha Reviewed-by: Venkat Duvvuru Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/ulp_templat

[dpdk-dev] [PATCH 35/36] net/bnxt: rename fields in the device params structure

2020-06-10 Thread Somnath Kotur
From: Kishore Padmanabha The fields in the device params structure are renamed to reflect the usage of those fields. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Signed-off-by: Somnath Kotur --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 12 ++-- drivers/net/bn

[dpdk-dev] [PATCH 0/3] compile librte_net for windows

2020-06-10 Thread Fady Bader
Addded needed files and fixes for windows in order to get librte_net compiling under Windows. Fady Bader (3): net: fix s_addr redefinition in Windows net: add htons to minGW for Windows eal/windows: librte_net build on Windows lib/librte_eal/common/meson.build | 1 + lib/librte

[dpdk-dev] [PATCH 1/3] net: fix s_addr redefinition in Windows

2020-06-10 Thread Fady Bader
s_addr in Windows is defined in windows.h so its undefined in order to be defined as part of rte_ether_hdr. Signed-off-by: Fady Bader --- lib/librte_net/rte_ether.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 0ae4e75b

[dpdk-dev] [PATCH 3/3] eal/windows: librte_net build on Windows

2020-06-10 Thread Fady Bader
librte_net wasn't compiling under Windows. To solve this, needed exports and files were added for Windows. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/include/netinet/in.h | 23 ++

[dpdk-dev] [PATCH 2/3] net: add htons to minGW for Windows

2020-06-10 Thread Fady Bader
htons wasnt defined in Windows for the minGW compiler. Definition of htons was added in order to use htons. Signed-off-by: Fady Bader --- lib/librte_eal/windows/include/rte_os.h | 4 lib/librte_net/rte_arp.c| 2 ++ 2 files changed, 6 insertions(+) diff --git a/lib/librte_ea

[dpdk-dev] [PATCH] bus/pci: optimize bus scan

2020-06-10 Thread jerinj
From: Jerin Jacob In order to optimize the PCI management, RTE_KDRV_NONE based device driver probing removed by not adding them to list in the scan phase. The legacy virtio is the only consumer of RTE_KDRV_NONE based device driver probe scheme. The legacy virtio support will be available through

Re: [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation

2020-06-10 Thread Somnath Kotur
On Wed, Jun 10, 2020 at 5:18 PM Somnath Kotur wrote: > > Max Rx Ring count could be < Max stat contexts. While accounting > for stat contexts, this should be also considered and > the max ring count adjusted accordingly. > > Fixes: f03e66cb64ce ("net/bnxt: limit queue count for NS3/Stingray device

[dpdk-dev] [Bug 488] mlx4: cannot reattach devices

2020-06-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=488 Bug ID: 488 Summary: mlx4: cannot reattach devices Product: DPDK Version: 18.11 Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: Norma

[dpdk-dev] [PATCH v2 0/3] compile librte_net for windows

2020-06-10 Thread Fady Bader
Addded needed files and fixes for windows in order to get librte_net compiling under Windows. Depends-on: series-10282 ("build mempool on Windows") Fady Bader (3): net: fix s_addr redefinition in Windows net: add htons to minGW for Windows eal/windows: librte_net build on Windows lib/lib

[dpdk-dev] [PATCH v2 1/3] net: fix s_addr redefinition in Windows

2020-06-10 Thread Fady Bader
s_addr in Windows is defined in windows.h so its undefined in order to be defined as part of rte_ether_hdr. Signed-off-by: Fady Bader --- lib/librte_net/rte_ether.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 0ae4e75b

[dpdk-dev] [PATCH v2 2/3] net: add htons to minGW for Windows

2020-06-10 Thread Fady Bader
htons wasnt defined in Windows for the minGW compiler. Definition of htons was added in order to use htons. Signed-off-by: Fady Bader --- lib/librte_eal/windows/include/rte_os.h | 4 lib/librte_net/rte_arp.c| 2 ++ 2 files changed, 6 insertions(+) diff --git a/lib/librte_ea

[dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-06-10 Thread Fady Bader
librte_net wasn't compiling under Windows. To solve this, needed exports and files were added for Windows. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/include/netinet/in.h | 25 ++

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-10 Thread Coyle, David
Hi Konstantin, > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > rte_crypto_op { > > > > struct rte_crypto_asym_op asym[0]; > > > > /**< Asymmetric operation parameters */ > > > > > > > > +#ifdef RTE_LIBRTE_SECURITY > > > >

Re: [dpdk-dev] [PATCH v20.11 2/2] eal: improve device probing API

2020-06-10 Thread Gaëtan Rivet
Hello Maxime, On 08/06/20 17:53 +0200, Maxime Coquelin wrote: > This patch makes rte_dev_probe() to return the > rte_device pointer on success and NULL on error > instead of returning 0 on success and negative > value on error. > > The goal is to avoid that the calling application > iterates the

[dpdk-dev] [PATCH] net/i40e: fix modifying the number of queues

2020-06-10 Thread alvinx . zhang
From: Alvin Zhang For the newly created VF, if the number of qps is greater than 4 at startup, it may fail to start. This patch updates the API `i40evf_dev_configure`. Fixes: c48eb308ed13 ("net/i40e: support VF request more queues") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/n

Re: [dpdk-dev] [PATCH v2] net/pcap: support software Tx nanosecond timestamps

2020-06-10 Thread Ferruh Yigit
On 6/9/2020 8:57 PM, Vivien Didelot wrote: > Hi Stephen, > > On Tue, 9 Jun 2020 12:43:57 -0700, Stephen Hemminger > wrote: >> On Tue, 9 Jun 2020 15:07:19 -0400 >> Vivien Didelot wrote: >> >>> >>> +#define NSEC_PER_SEC 10L >>> + >>> static inline void >>> calculate_timestamp(s

Re: [dpdk-dev] [PATCH v2 2/3] net: add htons to minGW for Windows

2020-06-10 Thread Jerin Jacob
On Wed, Jun 10, 2020 at 5:31 PM Fady Bader wrote: > > htons wasnt defined in Windows for the minGW compiler. > Definition of htons was added in order to use htons. > > Signed-off-by: Fady Bader > --- > lib/librte_eal/windows/include/rte_os.h | 4 > lib/librte_net/rte_arp.c|

[dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

2020-06-10 Thread Dekel Peled
Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just above function flow_dv_validate_item_gtp(), where it is used. Patch was applied together with other patches which modified the same file, so the mask was located further away from the function it is used in. This patch moves the

[dpdk-dev] [PATCH] usertools: fix telemetry script user socket path

2020-06-10 Thread Ciara Power
The path to the socket when running the script as a regular user needed to be updated to match the logic in EAL. Fixes: 6a2967c112a3 ("usertools: add new telemetry script") Cc: bruce.richard...@intel.com Signed-off-by: Ciara Power --- usertools/dpdk-telemetry.py | 4 ++-- 1 file changed, 2 inse

Re: [dpdk-dev] [RFC] mbuf: accurate packet Tx scheduling

2020-06-10 Thread Harman Kalra
On Wed, Jun 10, 2020 at 06:38:05AM +, Viacheslav Ovsiienko wrote: Hi Viacheslav, I have some queries below: > There is the requirement on some networks for precise traffic timing > management. The ability to send (and, generally speaking, receive) > the packets at the very precise

Re: [dpdk-dev] [PATCH] usertools: fix telemetry script user socket path

2020-06-10 Thread Bruce Richardson
On Wed, Jun 10, 2020 at 02:30:33PM +0100, Ciara Power wrote: > The path to the socket when running the script as a regular user needed > to be updated to match the logic in EAL. > > Fixes: 6a2967c112a3 ("usertools: add new telemetry script") > Cc: bruce.richard...@intel.com > > Signed-off-by: Cia

Re: [dpdk-dev] [PATCH v2] net/pcap: support software Tx nanosecond timestamps

2020-06-10 Thread Ferruh Yigit
On 6/9/2020 8:07 PM, Vivien Didelot wrote: > When capturing packets into a PCAP file, DPDK currently uses > microseconds for the timestamps. But libpcap supports interpreting > tv_usec as nanoseconds depending on the file timestamp precision, > as of commit ba89e4a18e8b ("Make timestamps precision

Re: [dpdk-dev] [RFC] [PATCH v1 3/3] net/pcap: dump hardware timestamps

2020-06-10 Thread Ferruh Yigit
On 6/9/2020 3:41 PM, Ferruh Yigit wrote: > On 6/9/2020 3:17 PM, Patrick Keroulas wrote: >> When hardware timestamping is activated, system time should no longer be >> used to timestamp dumped the packets. Instead, use value held by >> forwarded and assume they were converted to nanoseconds. >> >> S

[dpdk-dev] [PATCH v8 01/11] eal: replace rte_page_sizes with a set of constants

2020-06-10 Thread Dmitry Kozlyuk
Clang on Windows follows MS ABI where enum values are limited to 2^31-1. Enum rte_page_sizes has members valued above this limit, which get wrapped to zero, resulting in compilation error (duplicate values in enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. Remove rte_page_size

[dpdk-dev] [PATCH v8 00/11] Windows basic memory management

2020-06-10 Thread Dmitry Kozlyuk
This patchset implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * Only 2MB hugepages are supported. * IOVA is always PA, obtained through kernel-mode driver. * No 32-bit support (presumably not demanded). * Ni multi-process support (it is forceful

[dpdk-dev] [PATCH v8 02/11] eal: introduce internal wrappers for file operations

2020-06-10 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers in order to support common EAL code on Unix and Windows: * eal_file_open: open or create a file. * eal_file_lock: lock or unlock an open file. * eal_file_truncate: enforce a given size for an open file. Implementation for Linux and FreeBSD is placed in "unix" sub

[dpdk-dev] [PATCH v8 04/11] eal/mem: extract common code for memseg list initialization

2020-06-10 Thread Dmitry Kozlyuk
All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_memory.c | 95 + lib/librte_eal/commo

[dpdk-dev] [PATCH v8 05/11] eal/mem: extract common code for dynamic memory allocation

2020-06-10 Thread Dmitry Kozlyuk
Code in Linux EAL that supports dynamic memory allocation (as opposed to static allocation used by FreeBSD) is not OS-dependent and can be reused by Windows EAL. Move such code to a file compiled only for the OS that require it. Keep Anatoly Burakov maintainer of extracted code. Signed-off-by: Dmi

[dpdk-dev] [PATCH v8 06/11] trace: add size_t field emitter

2020-06-10 Thread Dmitry Kozlyuk
It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows, sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs. Tracepoints using "long" field emitter are therefore invalid there. Add dedicated field emitter for size_t and use it to store size_t values in all existing tracepoin

[dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-10 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_mem_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and reservation, while Unices reserve memory by mappi

[dpdk-dev] [PATCH v8 08/11] eal/windows: replace sys/queue.h with a complete one from FreeBSD

2020-06-10 Thread Dmitry Kozlyuk
Limited version imported previously lacks at least SLIST macros. Import a complete file from FreeBSD, since its license exception is already approved by Technical Board. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/include/sys/queue.h | 663 +++-- 1 file changed, 601

  1   2   3   >