Re: [dpdk-dev] [PATCH] net/mlx5: fix Verbs counter pool allocation

2020-05-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Friday, May 15, 2020 3:48 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; Bill Zhou > ; Wisam Monther > Subject: [PATCH] net/mlx5: fix Verbs counter pool allocation > > When create the

Re: [dpdk-dev] [PATCH] net/mlx5: fix left shift extension of doorbell bitmap

2020-05-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, May 15, 2020 11:14 AM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org; sta...@dpdk.org; Dekel Peled > Subject: [PATCH] net/mlx5: fix left shift extension of doorbell bitmap > > The doorbe

Re: [dpdk-dev] [PATCH] net/mlx5: fix left shift extension of doorbell bitmap

2020-05-17 Thread Raslan Darawsheh
> -Original Message- > From: Raslan Darawsheh > Sent: Sunday, May 17, 2020 12:19 PM > To: Bing Zhao ; Slava Ovsiienko > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org; sta...@dpdk.org; Dekel Peled > Subject: RE: [PATCH] net/mlx5: fix left shift extension of doorbell bitmap > > Hi, > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix shared counter search with nested index

2020-05-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Friday, May 15, 2020 11:36 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix shared counter search with nested index > > Currently, the shared counter sear

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix netlink buffer allocation from stack

2020-05-17 Thread Matan Azrad
From: Viacheslav Ovsiienko > The buffer size to receive netlink reply messages is relatively large (32K), > and > it is allocated on the stack and it might break in application is using > smaller > per-thread stacks. > This patch allocates temporary buffer from heap. > > Fixes: ccdcba53a3f4 (

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix bogus assert

2020-05-17 Thread Matan Azrad
From: Viacheslav Ovsiienko > The MLX5 device supports up to MLX5_MAX_MAC_ADDRESSES (256) MAC > addresses. > The code flushes all MAC devices. > > If DPDK is compiled with MLX5_DEBUG this would an assert. > PANIC in mlx5_nl_mac_addr_flush(): > line 775 assert "(size_t)(i) < sizeof(mac_own)

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix bogus assert

2020-05-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, May 14, 2020 10:09 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; step...@networkplumber.org; Alexander > Kozyrev ; sta...@dpdk.org > Subject: [PATCH v2] common/mlx5: fix bogus assert > > The MLX5 dev

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix netlink buffer allocation from stack

2020-05-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, May 14, 2020 10:11 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; step...@networkplumber.org; Nélio Laranjeiro > ; sta...@dpdk.org > Subject: [PATCH v2] common/mlx5: fix netlink buffer allocation from

Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

2020-05-17 Thread Akhil Goyal
> > Hi Jay, > > > > > > Since it will check the feature mask before running out-of-place > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode. > > > Is this feature already supported in the PMD and this patch is a fix to the > original > patch. > If that is the case, tit

Re: [dpdk-dev] [PATCH v4] Test/crypto: check valid test_stats before running test

2020-05-17 Thread Akhil Goyal
> Test_stats is an optional cryptodev op and if it is not defined by the > PMD, it should not run the test cases for it. > > Signed-off-by: Apeksha Gupta > --- Acked-by: Akhil Goyal Title and description of the patch updated as test/crypto: fix statistics case The test case - test_sta

Re: [dpdk-dev] [PATCH v3 0/2] fixes for caam_jr

2020-05-17 Thread Akhil Goyal
> > From: Yunjian Wang > > > > This series include two fixes patches for caam_jr driver. > > > > --- > > v3: > > * Add function to initialize g_uio_job_ring and g_job_rings > > * Add fix return type > > v2: > > * Change "job_ring->uio_fd" type suggested by Gagandeep Singh > > > > Yunjian Wang (

Re: [dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

2020-05-17 Thread Akhil Goyal
Hi Anoob, This patch series is pretty late for the RC3, specially your last patch. However the patches looks good to me, I have applied them to dpdk-next-crypto with some modifications in the commit titles and descriptions. Please send the fixes a bit earlier from next time. Regards, Akhil > >

Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

2020-05-17 Thread Akhil Goyal
> > > > > Hi Jay, > > > > > > > > > > Since it will check the feature mask before running out-of-place > > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode. > > > > > Is this feature already supported in the PMD and this patch is a fix to the > original > > patch. > > If th

[dpdk-dev] [pull-request] next-crypto 20.05 rc3

2020-05-17 Thread Akhil Goyal
The following changes since commit 2e9088556613ed03a15fc08e866bc96475269c0f: test/graph: fix memory leaks in performance tests (2020-05-15 11:00:55 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 05b4c45694c5b2056aa09f

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: add per core packet stats

2020-05-17 Thread Akhil Goyal
Hi Anoob/Konstantin, > > > Adding per core packet handling stats to analyze traffic distribution > > when multiple cores are engaged. > > > > Since aggregating the packet stats across cores would affect > > performance, keeping the feature disabled using compile time flags. > > > > Signed-off-by:

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-17 Thread Dumitrescu, Cristian
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, May 14, 2020 5:11 PM > To: Ray Kinsella ; Neil Horman > ; Dumitrescu, Cristian > ; Eelco Chaudron > Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon > ; David Marchand ; > sta...@dpdk.org; Luca Boccassi ; Richardson

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-17 Thread Dmitry Kozlyuk
On Wed, 13 May 2020 12:25:10 + Fady Bader wrote: [snip] > > > > I meant the code of the application that calls > > rte_mempool_create(). Or is it one of the DPDK test applications? > > I got it from dpdk\app\test\test_mempool > > Line 496: > /* create a mempool (without cache) */ > mp_noc

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-17 Thread Ye Xiaolong
On 05/15, Su, Simei wrote: >Hi, xiaolong > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Friday, May 15, 2020 2:50 PM >> To: Su, Simei >> Cc: Zhang, Qi Z ; dev@dpdk.org; Cao, Yahui >> >> Subject: Re: [PATCH] net/ice/base: fix FDIR rule passthrough mode >> >> Hi, simei >> >> On 05/

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-17 Thread Ye Xiaolong
On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") > >Signed-off-by: Simei Su >--- > drivers/net/ice/base/ice_fdir.c | 9 +

Re: [dpdk-dev] [PATCH v4] net/i40e: fix queue region issue in RSS flow

2020-05-17 Thread Ye Xiaolong
On 05/15, Shougang Wang wrote: >This patch fixes the issue that the queue region does not >take effect due to incorrectly setting the flow type. > >Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") >Cc: sta...@dpdk.org > >Signed-off-by: Shougang Wang >Reviewed-by: Jeff Guo >Tested-by: Hailin

Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

2020-05-17 Thread Zhoujian (jay)
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Saturday, May 16, 2020 1:08 AM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; roy.fan.zh...@intel.com; Huangweidong > (C) > Subject: RE: [PATCH] crypto/virtio: add OOP_LB_IN_

Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

2020-05-17 Thread Zhoujian (jay)
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Sunday, May 17, 2020 10:18 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; roy.fan.zh...@intel.com; Huangweidong > (C) > Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_I

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

2020-05-17 Thread Ye Xiaolong
Hi, guinan On 05/08, Guinan Sun wrote: >The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. >If latest is less than last, we will get wrong result. >The patch fixes the defect. There was similar patch before, https://patches.dpdk.org/patch/65131/, if I understand it correctly

Re: [dpdk-dev] [PATCH v1] net/iavf: fix setting wrong RXDID value for Rx queue

2020-05-17 Thread Ye Xiaolong
On 05/11, Ting Xu wrote: >CVL kernel PF configures all reserved queues for VF, including >Rx queue RXDID. The number of reserved queues is the maximum >between Tx and Rx queues. If the number of the enabled Rx queues >is less than that of reserved queues, required RXDID will only >be set for those

Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting

2020-05-17 Thread Zhao1, Wei
Hi, Guinian > -Original Message- > From: dev On Behalf Of Sun GuinanX > Sent: Thursday, October 31, 2019 7:32 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Sun, GuinanX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting > > macsec setting is

Re: [dpdk-dev] [PATCH v4] net/i40e: fix queue region issue in RSS flow

2020-05-17 Thread Xu, HailinX
Tested-by: Xu, Hailin Regards, Xu, Hailin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shougang Wang Sent: Friday, May 15, 2020 3:33 PM To: dev@dpdk.org Cc: Wang, ShougangX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v4] net/i40e: fix queue region issue in RS

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-17 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 6:09 PM > To: Wang, Xiao W ; Maxime Coquelin > ; Ye, Xiaolong ; > shah...@mellanox.com; ma...@mellanox.com; amore...@redhat.com; > viachesl...@mellanox.com; dev@dpdk.org > Cc: l.

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-17 Thread Jason Wang
On 2020/5/18 上午11:09, Wang, Xiao W wrote: Hi, Comments inline. Best Regards, Xiao -Original Message- From: Jason Wang Sent: Friday, May 15, 2020 6:09 PM To: Wang, Xiao W; Maxime Coquelin ; Ye, Xiaolong; shah...@mellanox.com;ma...@mellanox.com;amore...@redhat.com; viachesl...@mellano

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: add per core packet stats

2020-05-17 Thread Anoob Joseph
Hi Akhil, > > -- > Hi Anoob/Konstantin, > > > > > > Adding per core packet handling stats to analyze traffic > > > distribution when multiple cores are engaged. > > > > > > Since aggregating the packet stats across cores would a

[dpdk-dev] [PATCH] net/ice: fix tunnel type match word handling

2020-05-17 Thread Qi Zhang
Use a common function when selecting the proper word and mask match for a tunnel type when programming switch rules. Store switch recipe field mask as little endian, which avoids needing to convert back to big endian after reading recipe from FW. Obtain word mask from FW recipe. Fix word matchin

Re: [dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

2020-05-17 Thread Anoob Joseph
Hi Akhil, > Hi Anoob, > > This patch series is pretty late for the RC3, specially your last patch. > However the patches looks good to me, I have applied them to dpdk-next- > crypto with some modifications in the commit titles and descriptions. > > Please send the fixes a bit earlier from next t

Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-17 Thread Zhao1, Wei
HI, Xiaolong & guojia > -Original Message- > From: Ye, Xiaolong > Sent: Friday, May 15, 2020 3:28 PM > To: Guo, Jia > Cc: Zhao1, Wei ; dev@dpdk.org; sta...@dpdk.org; > Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild > pointer > operation > > On 0

[dpdk-dev] [PATCH v2] net/i40e: fix the core dump risk of wild pointer operation

2020-05-17 Thread Wei Zhao
In i40e PMD code of function i40e_res_pool_free(), if valid_entry is freed by "rte_free(valid_entry);" in the code, then the following code for pool update may still use the wild pointer "valid_entry" for pool info update. It seems has the risk of core dump for using wild pointer operation, we shou

Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-17 Thread Ye Xiaolong
Hi, Wei On 05/18, Zhao1, Wei wrote: >HI, Xiaolong & guojia > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Friday, May 15, 2020 3:28 PM >> To: Guo, Jia >> Cc: Zhao1, Wei ; dev@dpdk.org; sta...@dpdk.org; >> Xing, Beilei >> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix the security

[dpdk-dev] [PATCH v2] net/i40e: fix queue related exception handling

2020-05-17 Thread Qiming Yang
There should have different behavior in queue start fail and stop fail case. When queue start fail, all the next actions should be terminated and then started queues should be cleared. But for queue stop stage, one queue stop fail should not end other queues stop. This patch fixed that issue in PF

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-17 Thread Ray Kinsella
On 17/05/2020 20:52, Dumitrescu, Cristian wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, May 14, 2020 5:11 PM >> To: Ray Kinsella ; Neil Horman >> ; Dumitrescu, Cristian >> ; Eelco Chaudron >> Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon >>

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

2020-05-17 Thread Zhao1, Wei
Hi, xiaolong > -Original Message- > From: dev On Behalf Of Ye Xiaolong > Sent: Monday, May 18, 2020 9:25 AM > To: Sun, GuinanX > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of > macro in VF > > Hi, guinan > > On 05/08,