Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Saturday, May 16, 2020 1:08 AM > To: Zhoujian (jay) <jianjay.z...@huawei.com>; dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; roy.fan.zh...@intel.com; Huangweidong > (C) <weidong.hu...@huawei.com> > Subject: RE: [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag > > Hi Jay, > > > > > > Since it will check the feature mask before running out-of-place test > > cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode. > > > Is this feature already supported in the PMD and this patch is a fix to the > original > patch.
Yes. > If that is the case, title should be > Crypto/virtio: add missing OOP feature flag Also add a fixes line to link the > original > feature patch. The OOP_LB_IN_LB_OUT function is introduced by commit 82adb12a (crypto/virtio: support burst enqueue/dequeue), but the OOP_LB_IN_LB_OUT feature flag is introduced after that, which is commit 2717246e (cryptodev: replace mbuf scatter gather flag), I'm not sure which one should be added. Regards, Jay Zhou > > > Signed-off-by: Jay Zhou <jianjay.z...@huawei.com> > > ---
