[dpdk-dev] [dpdk-dev v2] net/iavf: fix input set for rss hash

2020-05-09 Thread Jeff Guo
Since some specific rss hash type need to combine with the protocol hash type when configure a rss hash rule, so add the corresponding input set to support these case for iavf hash. Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") Signed-off-by: Jeff Guo --- v2->v1: use nonfrag for

[dpdk-dev] [dpdk-dev v2] net/iavf: fix input set for rss hash

2020-05-09 Thread Jeff Guo
Since some specific rss hash type need to combine with the protocol hash type when configure a rss hash rule, so add the corresponding input set to support these case for iavf hash. Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") Signed-off-by: Jeff Guo --- v2->v1: use nonfrag for

Re: [dpdk-dev] [dpdk-dev v2] net/iavf: fix input set for rss hash

2020-05-09 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Sunday, May 10, 2020 3:30 AM > To: Xing, Beilei ; Zhang, Qi Z ; > Wu, Jingjing > Cc: Iremonger, Bernard ; Ye, Xiaolong > ; dev@dpdk.org; Guo, Jia > Subject: [dpdk-dev v2] net/iavf: fix input set for rss hash > > Since some specific rss ha

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-05-09 Thread Zhao1, Wei
Hi, guinan In this patch, you have add a new parameter of mac_ctrl_frame_fwd, it should not be clear in ixgbe_dev_stop(), Or it will be over write when do port reset, and also you should add mac_ctrl_frame_fwd in ixgbe_flow_ctrl_get() for FC info get. Although this patch has been merged, please

[dpdk-dev] [PATCH] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-05-09 Thread guohongzhi
The function of rte_ipv4_cksum for calculating the checksum of IPv4 header is incorrect. This function will return checksum value like 0x. This value, however, is considered an illegal checksum on some switches(like Trident3). RFC 1624 specifies the IPv4 checksum as follows: https://tools.iet

[dpdk-dev] net/iavf: fix rss algorithm configure issue

2020-05-09 Thread Jeff Guo
When configure rss rule, the etherdev rss hash function type should be mapped to the corresponding virtchnl rss algorithm type. Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 20 +++- 1 file changed, 11 in

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-05-09 Thread Sun, GuinanX
Hi ,zhaowei > -Original Message- > From: Zhao1, Wei > Sent: Saturday, May 9, 2020 3:35 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z ; Sun, GuinanX > ; sta...@dpdk.org; Guo, Jia > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode sett

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-05-09 Thread Zhao1, Wei
Hi,guinan More info for this problem: If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port reset process of " 1. testpmd> start 2. testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 3. testpmd> stop 4. testpmd> port stop 0 5. testpmd> port start 0 6. testpmd> start " Then a

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-05-09 Thread Sun, GuinanX
Hi, zhaowei > -Original Message- > From: Zhao1, Wei > Sent: Saturday, May 9, 2020 5:30 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z ; > sta...@dpdk.org; Guo, Jia > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting > > Hi,gui

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-05-09 Thread Zhao1, Wei
Hi,guinan More info for this problem: If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port reset process of " 1. testpmd> start 2. testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 3. testpmd> stop 4. testpmd> port stop 0 5. testpmd> port start 0 6. testpmd> start "

[dpdk-dev] [Bug 470] vmxnet3 pmd cannot received icmp6 ns packet

2020-05-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=470 Bug ID: 470 Summary: vmxnet3 pmd cannot received icmp6 ns packet Product: DPDK Version: 16.04 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v1] doc: QAT support for AES-256 DOCSIS

2020-05-09 Thread Akhil Goyal
> > Update QAT pmd to support AES-256 DOCSIS > > Signed-off-by: Mairtin o Loingsigh > --- > doc/guides/rel_notes/release_20_05.rst | 4 > 1 file changed, 4 insertions(+) > This patch does not add the DOCSIS support in QAT. The release note update should be the part of the patch which i

Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd

2020-05-09 Thread Gagandeep Singh
> -Original Message- > From: wangyunjian > Sent: Sunday, April 26, 2020 6:31 PM > To: dev@dpdk.org > Cc: Gagandeep Singh ; Hemant Agrawal > ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check o

Re: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54

2020-05-09 Thread Akhil Goyal
Hi Pablo, > +#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3) > + processed_ops = process_zuc_hash_op_mb(qp, ops, sessions, > + num_ops); > +#else > processed_ops = process_zuc_hash_op(qp, ops, sessions, > num_ops); >

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-09 Thread Akhil Goyal
Hi Ray/Arek, I still see Incompatible cryptodev even after update in the abignore list. I checked it with ./devtools/validate-abi.sh NOTICE: ABI may be incompatible, check reports/logs for details. NOTICE: Incompatible list: librte_cryptodev.so Did I miss something? > > On 07/05/2020 11:57, A

Re: [dpdk-dev] [PATCH v2] bbdev: doxygen update only

2020-05-09 Thread Akhil Goyal
> > Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib") Cc:sta...@dpdk.org > > Several doxygen markup were incorrect in header files. > > Signed-off-by: Nicolas Chautru Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: check if session is valid

2020-05-09 Thread Akhil Goyal
> > Check if session is valid after getting operation > out of the internal IPSec MB manager, in case the > session has been freed while the operation was still > inside the manager. > > Signed-off-by: Pablo de Lara > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v5] test/ipsec: measure libipsec performance

2020-05-09 Thread Akhil Goyal
> > > > Add new test-case to measure performance of > > ipsec data-path functions. > > > > Signed-off-by: Savinay Dharmappa > > --- > > Tested-by: Konstantin Ananyev > Acked-by: Konstantin Ananyev > Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH] test/security: enable tests for non-implemented ops

2020-05-09 Thread Akhil Goyal
> > After re-enabling checks for non-implemneted ops in non-debug mode > in librte_security set_pkt_metadata and get_userdata functions, > tests verifying proper work of tests can be enabled also. > > Signed-off-by: Lukasz Wojciechowski > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix DOCSIS AES-256

2020-05-09 Thread Akhil Goyal
> When adding support for DOCSIS AES-256, > when setting the cipher parameters, all key sizes > were accepted, but only 128-bit and 256-bit keys > are supported. > > Fixes: 124d04b43743 ("crypto/aesni_mb: support DOCSIS AES-256") > > Signed-off-by: Pablo de Lara > Acked-by: Mairtin o Loingsigh

Re: [dpdk-dev] [PATCH v3] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-05-09 Thread Akhil Goyal
> > > > For SA outbound packets, rte_atomic64_add_return is used to generate > > SQN atomically. Use c11 atomics with RELAXED ordering for outbound SQN > > update instead of rte_atomic ops which enforce unnecessary barriers on > > aarch64. > > > > Signed-off-by: Phil Yang > > Reviewed-by: Ruifen

Re: [dpdk-dev] [PATCH] crypto/ccp: fix fd leak on probe failure

2020-05-09 Thread Akhil Goyal
> > Acked-by: Ravi Kumar Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix display of sample test vector

2020-05-09 Thread Akhil Goyal
> > This patch disables displaying sample test vector contents when > > executing throughput and latency tests as the sample data is not > > used in those tests (not copied to input mbuf in order to achieve > > better performance). > > > > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performanc

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix computation of cd ptr in zuc and snow

2020-05-09 Thread Akhil Goyal
> > Offset of cd pointer is too big by state1size + state2size, so few extra > > unnecessary bytes will be copied into cd. Snow offset was improved as well. > > > > Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Arek Kusztal > Acked-

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: tests clean-up

2020-05-09 Thread Akhil Goyal
> > As more test cases are defined for execution, test scripts structure > > needs to be reorganized, so fewer files are needed to describe the test. > > To achieve that, new environment variables are incorporated into the > > scripts. > > Additionally, tests for mixed tunnel protocols are added. >

Re: [dpdk-dev] [PATCH] common/qat: fix queue head update

2020-05-09 Thread Akhil Goyal
> Tested-by: Zhao, Xinfeng > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: improve memory freeing

2020-05-09 Thread Akhil Goyal
Hi Lukasz, Thanks for the detailed analysis. Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks. > > This patch fixes management of memory for authentication > and encryption keys. > There were two issues with former state of implementation: > > 1) Invalid access to dpaa_sec_sess

Re: [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero

2020-05-09 Thread Akhil Goyal
> > > > > > For null cipher the iv length should be set to zero. > > > > > > Signed-off-by: Ankur Dwivedi > > > > Acked-by: Anoob Joseph > Acked-by: Fiona Trahe Title should start from test/crypto:.. Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error

2020-05-09 Thread Akhil Goyal
> gcc 10 defaults to fno-common and it reports: > > crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0): > multiple definition of `rte_kasumi_pmd_ops'; > crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here > > Fix by making rte_kasumi_pmd_ops extern in the header file. > > Fixes: 27

Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: fix negative argument passing

2020-05-09 Thread Akhil Goyal
> > Function create_ipsec_esp_flow returns a negative number in case of any > failure > > and we are passing this to strerror to display the error message. > > But strerror()'s argument cannot be negative. > > In case of failure, displaying exact error message to console is handled in > > create_ip

Re: [dpdk-dev] [PATCH] common/qat: fix stats update

2020-05-09 Thread Akhil Goyal
> > This patch fixes enqueued and dequeued count statistics that should > > contain the numer of operations enqueued by the end user app > > instead of the total number of QAT requests - bigger in case of > > a multiple-request dynamic Huffman compression operation. > > > > Fixes: c13cecf60f12 ("co

Re: [dpdk-dev] [PATCH] common/qat: fix coverity issue

2020-05-09 Thread Akhil Goyal
> > This patch fixes Coverity issue #357770 by removing the non-essential > > check for NULL pointer. > > > > Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation") > > > > Signed-off-by: Adam Dybkowski > Acked-by: Fiona Trahe The title should showcase the actual issue fixed

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of algo from NIST TDES test files

2020-05-09 Thread Akhil Goyal
> > > > Few of the NIST TDES test files don't contain TDES string. > > Added indicators to identify such files. These indicators are part of only > > NIST > > TDES test vector files. > > > > Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing") > > > > Signed-off-by: Archana Munig

Re: [dpdk-dev] [PATCH] app/test: handle -ENOTSUP from session init

2020-05-09 Thread Akhil Goyal
> The session init routine rte_cryptodev_sym_session_init(), > could return -ENOTSUP when the requested algo combination > is not supported by the PMD. This should be treated as > unsupported features. For other return values like -EINVAL > or -ENOMEM the test can be treated as failure. > > Signed

[dpdk-dev] [PATCH v3 1/2] crypto/dpaa2_sec: improve error handling

2020-05-09 Thread Akhil Goyal
The return values in cases of errors were not specified properly. With this patch appropriate error numbers are returned. Signed-off-by: Akhil Goyal --- Changes in v3: some return values were missed. It is now updated drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 120 +++- 1 fil

[dpdk-dev] [PATCH v3 2/2] crypto/dpaa_sec: improve error handling

2020-05-09 Thread Akhil Goyal
The return values in cases of errors were not specified properly. With this patch appropriate error numbers are returned. Signed-off-by: Akhil Goyal --- Changes in v3: some return values were missed. It is now updated drivers/crypto/dpaa_sec/dpaa_sec.c | 46 -- 1 fil

[dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data

2020-05-09 Thread Akhil Goyal
Some wireless algos like SNOW, ZUC may support input data in bits which are not byte aligned. However, not all PMDs can support this requirement. Hence added a new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA to identify which all PMDs can support non-byte aligned data. Signed-off-by: Akhil

[dpdk-dev] [PATCH v2 2/9] test/crypto: skip unsupported non-byte aligned cases

2020-05-09 Thread Akhil Goyal
Skipped the test cases for the PMDs which do not support RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA and subsequently removed the PMD specific checks for running that case. Signed-off-by: Apeksha Gupta Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 68 +---

[dpdk-dev] [PATCH v2 0/9] test/crypto: code cleanup

2020-05-09 Thread Akhil Goyal
Certain cases were put in PMD specific checks which should be avoided. Appropriate capability/supported feature flag should be checked before executing the test case. Added 1 missing feature flag for non-byte aligned data Enabled it for SNOW/ZUC/KASUMI PMDs. All the PMD owners are requested to veri

[dpdk-dev] [PATCH v2 5/9] test/crypto: skip unsupported session

2020-05-09 Thread Akhil Goyal
The session init routine rte_cryptodev_sym_session_init(), could return -ENOTSUP when the requested algo combination is not supported by the PMD. This should be treated as unsupported feature. Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff

[dpdk-dev] [PATCH v2 4/9] test/crypto: skip unsupported sessionless cases

2020-05-09 Thread Akhil Goyal
There were some PMD specific checks to skip the case if it is not supported. This patch checks the feature flag RTE_CRYPTODEV_FF_SYM_SESSIONLESS if PMD supports it or not. Signed-off-by: Apeksha Gupta Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 24 ++-- 1 file

[dpdk-dev] [PATCH v2 6/9] test/crypto: run PDCP cases if supported

2020-05-09 Thread Akhil Goyal
cryptodevs which support rte_security PDCP protocol, can run all PDCP cases if it sets a feature flag RTE_CRYPTODEV_FF_SECURITY. Previously, only dpaa2_sec and dpaa_sec test suites were running these tests. Now it is moved to generic test suite with a check on the feature flag and the case will be

[dpdk-dev] [PATCH v2 3/9] test/crypto: skip unsupported SG cases

2020-05-09 Thread Akhil Goyal
Checked the PMD feature flag list to identify if inplace or OOP SGLs are supported or not. If not supported the cases are skipped. Signed-off-by: Apeksha Gupta Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/app/test/te

[dpdk-dev] [PATCH v2 8/9] test/crypto: remove QAT specific check

2020-05-09 Thread Akhil Goyal
In test_queue_pair_descriptor_setup() and test_device_configure_invalid_queue_pair_ids a QAT specific check is there, however the test case can be run on any PMD. Hence removed the unnecessary check. test_queue_pair_descriptor_setup and test_device_configure_invalid_queue_pair_ids execution need t

[dpdk-dev] [PATCH v2 9/9] test/crypto: remove unused variable

2020-05-09 Thread Akhil Goyal
dev info is set but not used in test_queue_pair_descriptor_setup(). Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 4 1 file changed, 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index aa9eda5e5..c624018ee 100644 --- a/app/test/test_cryptode

[dpdk-dev] [PATCH v2 7/9] test/crypto: remove dpaaX_sec specific testsuites

2020-05-09 Thread Akhil Goyal
dpaa_sec and dpaa2_sec PMDs can run generic cryptodev_testsuite. Hence removing the specific test suites. Signed-off-by: Apeksha Gupta Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 534 +- 1 file changed, 2 insertions(+), 532 deletions(-) diff -

Re: [dpdk-dev] [PATCH 0/9] test/crypto: code cleanup

2020-05-09 Thread Akhil Goyal
Hi Ruifeng, > > Tested on armv8 platform. > armv8 PMD and null PMD are OK. > cryptodev_openssl_autotest has a failure. I have added a workaround to fix the openssl failure in v2. It is caused by the 8/9 patch Of the patchset due to some dependency. I have altered the execution of two tests And

Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd

2020-05-09 Thread Gagandeep Singh
Hi Yunjian, > -Original Message- > From: Gagandeep Singh > Sent: Saturday, May 9, 2020 11:14 PM > To: wangyunjian ; dev@dpdk.org; Akhil Goyal > > Cc: Hemant Agrawal ; jerry.lili...@huawei.com; > xudin...@huawei.com; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/caam_jr: fix wro