[dpdk-dev] [PATCH v3 19/34] net/bnxt: add support to process action tables

2020-04-14 Thread Venkat Duvvuru
From: Mike Baucom This patch processes the action template. Iterates through the list of action info templates and processes it. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH v3 16/34] net/bnxt: add support for ULP session manager init

2020-04-14 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH v3 18/34] net/bnxt: add helper functions for blob/regfile ops

2020-04-14 Thread Venkat Duvvuru
From: Mike Baucom 1. blob routines for managing key/mask/result data 2. regfile routines for managing temporal data during flow construction Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Kha

[dpdk-dev] [PATCH v3 17/34] net/bnxt: add support for ULP session manager cleanup

2020-04-14 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH v3 23/34] net/bnxt: match rte flow items with flow template patterns

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes hdr_bitmap generated from the rte_flow_items 2. Iterates through the static hdr_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: La

[dpdk-dev] [PATCH v3 20/34] net/bnxt: add support to process key tables

2020-04-14 Thread Venkat Duvvuru
From: Mike Baucom This patch creates the classifier table entries for a flow. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c| 773

[dpdk-dev] [PATCH v3 21/34] net/bnxt: add support to free key and action tables

2020-04-14 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets all the flow resources from the flow id 2. Frees all the table resources 3. Frees the flow in the flow table Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Review

[dpdk-dev] [PATCH v3 22/34] net/bnxt: add support to alloc and program key and act tbls

2020-04-14 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets the action tables information from the action template id 2. Gets the class tables information from the class template id 3. Initializes the registry file 4. Allocates a flow id from the flow table 5. Process the class & action tables Signe

[dpdk-dev] [PATCH v3 24/34] net/bnxt: match rte flow actions with flow template actions

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes act_bitmap generated from the rte_flow_actions 2. Iterates through the static act_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by:

[dpdk-dev] [PATCH v3 26/34] net/bnxt: add support for rte flow action parsing

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Registers a callback handler for each rte_flow_action type, if it is supported 2. Iterates through each rte_flow_action till RTE_FLOW_ACTION_TYPE_END 3. Invokes the action call back handler 4. Each action call back handler will populate

[dpdk-dev] [PATCH v3 29/34] net/bnxt: add support for rte flow destroy driver hook

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the flow associated with the flow id from the flow table 3. Calls ulp_mapper_resources_free which releases the key & action tables associated with that flow Signed-off-by: Kishor

[dpdk-dev] [PATCH v3 28/34] net/bnxt: add support for rte flow validate driver hook

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, returns success otherwise failure Signed-off-by:

[dpdk-dev] [PATCH v3 25/34] net/bnxt: add support for rte flow item parsing

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha 1. Registers a callback handler for each rte_flow_item type, if it is supported 2. Iterates through each rte_flow_item till RTE_FLOW_ITEM_TYPE_END 3. Invokes the header call back handler 4. Each header call back handler will populate the respective fields in hdr_fie

[dpdk-dev] [PATCH v3 27/34] net/bnxt: add support for rte flow create driver hook

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, calls ulp_mapper_flow_create to program key & a

[dpdk-dev] [PATCH v3 30/34] net/bnxt: add support for rte flow flush driver hook

2020-04-14 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the rte_flow table associated with this session 3. Iterates through all the flows in the flow table 4. Calls ulp_mapper_resources_free which releases the key & action tables assoc

[dpdk-dev] [PATCH v3 32/34] net/bnxt: disable vector mode when host based TRUFLOW is enabled

2020-04-14 Thread Venkat Duvvuru
If bp->truflow is not set then don't enable vector mode. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/driver

[dpdk-dev] [PATCH v3 33/34] net/bnxt: add support for injecting mark into packet’s mbuf

2020-04-14 Thread Venkat Duvvuru
When a flow is offloaded with MARK action (RTE_FLOW_ACTION_TYPE_MARK), each packet of that flow will have metadata set in its completion. This metadata will be used to fetch an index into a mark table where the actual MARK for that flow is stored. Fetch the MARK from the mark table and inject it in

[dpdk-dev] [PATCH v3 34/34] net/bnxt: enable meson build on truflow code

2020-04-14 Thread Venkat Duvvuru
Include tf_ulp & tf_core directories and the files inside them. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/meson.build | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/bnxt/meson.buil

[dpdk-dev] [PATCH v3 31/34] net/bnxt: register tf rte flow ops

2020-04-14 Thread Venkat Duvvuru
Register bnxt_ulp_rte_flow_ops when host based TRUFLOW is enabled. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH v4 1/2] crypto/aesni_mb: support DOCSIS AES-256

2020-04-14 Thread De Lara Guarch, Pablo
Hi Mairtin, > -Original Message- > From: O'loingsigh, Mairtin > Sent: Friday, April 10, 2020 4:03 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; O'loingsigh, Mairtin > Subject: [PATCH v4 1/2] crypto/aesni_mb: support DOCSIS AES-256 > > This patch adds support for DOCSIS AES-256 whe

[dpdk-dev] [dpdk-dev v4 0/3] add RSS configuration for iavf

2020-04-14 Thread Jeff Guo
Because the VF must be capable of configuring RSS, so add RSS configuration for iavf, VFs could add or delete a RSS rule base on the PF's capability. The supported protocol rss input set as below. eth-src-only/ eth-dst-only/ svlan/ cvlan/ ipv4/ ipv6/ l3_src_only/ l3_dst_only/ l2tpv3/ esp/ ah/ pfcp

[dpdk-dev] [dpdk-dev v4 2/3] net/iavf: add RSS configuration for VFs

2020-04-14 Thread Jeff Guo
The VF must be capable of configuring RSS. Add a virtchnl handler to parse a specific RSS configuration, and process the configuration for VFs, such as add or delete a RSS rule. Signed-off-by: Jeff Guo --- v4->v3: refine rss type checking --- doc/guides/rel_notes/release_20_05.rst |2 + driv

[dpdk-dev] [dpdk-dev v4 1/3] ethdev: add new RSS offload types

2020-04-14 Thread Jeff Guo
Defines some new RSS offload types for ETH/SVLAN/CVLAN/GTPU/L2TPV3/ ESP/AH/PFCP. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang --- v4->v3: no change --- lib/librte_ethdev/rte_ethdev.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h

[dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands

2020-04-14 Thread Jeff Guo
Add some new types, such as eth-src-only/eth-dst-only/svlan/cvlan/ l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to configure these rss input set by cmdline. Signed-off-by: Jeff Guo --- v4->v3: no change --- app/test-pmd/cmdline.c | 24 ++-- app/test-pmd/c

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-04-14 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Sunday, April 12, 2020 5:44 PM > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: De Lara Guarch, Pablo ; O'loingsigh, > Mairtin ; Doherty, Declan > ; Dybkowski, AdamX > ; Trahe, Fiona > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-14 Thread Ori Kam
> -Original Message- > From: Dong Zhou > Sent: Tuesday, April 14, 2020 11:33 AM > To: Ori Kam ; Matan Azrad ; > wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; > john.mcnam...@intel.com; marko.kovace...@intel.com; Thomas Monjalon > ; ferruh.yi...@intel.com; ary

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command

2020-04-14 Thread Ferruh Yigit
On 4/13/2020 8:56 AM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, April 9, 2020 14:56 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Thomas Monjalon ; >> bernard.iremon...@intel.com >> Subject: Re: [PATCH v2 1/3] app/testpmd: add prof

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-04-14 Thread Thomas Monjalon
14/04/2020 10:49, De Lara Guarch, Pablo: > From: Thomas Monjalon > > 10/04/2020 17:03, Mairtin o Loingsigh: > > > This patch adds test vectors for AES-256 and sets AESNI-MB as the > > > target PMD > > > > There is really something wrong in the cryptodev API. > > Why the PMD must be selected in the

Re: [dpdk-dev] [PATCH] net/ice: support mark only action for FDIR

2020-04-14 Thread Su, Simei
Hi, Qi > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, April 14, 2020 3:49 PM > To: Su, Simei ; Ye, Xiaolong > Cc: dev@dpdk.org; Cao, Yahui ; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: support mark only action for FDIR > > > > > -Original Message- > > From: Su,

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-14 Thread Bill Zhou
> -Original Message- > From: Ori Kam > Sent: Tuesday, April 14, 2020 4:50 PM > To: Bill Zhou ; Matan Azrad > ; wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; john.mcnam...@intel.com; > marko.kovace...@intel.com; Thomas Monjalon ; > ferruh.yi...@intel.com; ar

Re: [dpdk-dev] [dpdk-dev v4 1/3] ethdev: add new RSS offload types

2020-04-14 Thread Ori Kam
Hi Jeff, PSB Best, Ori > -Original Message- > From: Jeff Guo > Sent: Tuesday, April 14, 2020 8:42 PM > To: Ori Kam ; bernard.iremon...@intel.com; > xiaolong...@intel.com; qi.z.zh...@intel.com > Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com; > simei...@intel.com; jia@in

Re: [dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands

2020-04-14 Thread Ori Kam
Hi Jeff, PSB, Thanks, Ori > -Original Message- > From: Jeff Guo > Sent: Tuesday, April 14, 2020 8:42 PM > To: Ori Kam ; bernard.iremon...@intel.com; > xiaolong...@intel.com; qi.z.zh...@intel.com > Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com; > simei...@intel.com; jia

[dpdk-dev] [PATCH 1/2] test/crypto: add capability check

2020-04-14 Thread Pablo de Lara
Check if test case is supported by the crypto device, including algorithm and some of its parameter, such as key length, IV length, etc, using the capabilities API. If it is not supported, test case is skipped. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_blockcipher.c | 49 +

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-14 Thread Ferruh Yigit
On 4/10/2020 11:55 PM, Thomas Monjalon wrote: > Hi, > > Adding more people (crypto PMD maintainers) as Cc. > > 10/04/2020 16:27, David Coyle: >> Introduction >> >> >> This patchset adds a new AESNI-MB Multi-Function raw device PMD for >> utilizing multi-function capabilities of the I

[dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-14 Thread Pablo de Lara
Now that capabilities are checked to see if an algorithm is supported by a device, there is no need to check for a specific version of a library used in a PMD. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_hash_test_vectors.h | 25 - 1 file changed, 25 deletion

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix resource leak after thread exits normally

2020-04-14 Thread Ananyev, Konstantin
Hi Tao, > Because ixgbe_dev_wait_setup_link_complete() doesn't guarantee that the > thread will always complete properly. So after the wait > timeout, need to call pthread_cancel() to cancel the thread. But pthread_cancel() also doesn't guarantee immediate thread termination. You'll have to wa

Re: [dpdk-dev] supported nic

2020-04-14 Thread Ferruh Yigit
On 4/12/2020 3:07 PM, Sahil Khandelwal wrote: > I have the following nic in my system > How do i check which one can be used with dpdk > > Network devices using kernel driver > === > :03:00.0 'RTL810xE PCI Express Fast Ethernet controller 8136' if=eno1 > drv=r81

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-14 Thread Thomas Monjalon
14/04/2020 12:21, Ferruh Yigit: > On 4/10/2020 11:55 PM, Thomas Monjalon wrote: > > Hi, > > > > Adding more people (crypto PMD maintainers) as Cc. > > > > 10/04/2020 16:27, David Coyle: > >> Introduction > >> > >> > >> This patchset adds a new AESNI-MB Multi-Function raw device PMD f

Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-14 Thread Thomas Monjalon
14/04/2020 12:22, Pablo de Lara: > Now that capabilities are checked to see if an algorithm > is supported by a device, there is no need to check > for a specific version of a library used in a PMD. Yes, and even no need to check the PMD at all. All *_TEST_TARGET_PMD_* constants should be removed.

[dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check

2020-04-14 Thread Pablo de Lara
Check if test case is supported by the crypto device, including algorithm and some of its parameter, such as key length, IV length, etc, using the capabilities API. If it is not supported, test case is skipped. Signed-off-by: Pablo de Lara --- v2: - Fixed checkpatch issues app/test/test_crypto

[dpdk-dev] [PATCH v2 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-14 Thread Pablo de Lara
Now that capabilities are checked to see if an algorithm is supported by a device, there is no need to check for a specific version of a library used in a PMD. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_hash_test_vectors.h | 25 - 1 file changed, 25 deletion

Re: [dpdk-dev] [PATCH] eal: Place EAL thread stack in a reserved per-lcore memzone

2020-04-14 Thread Ananyev, Konstantin
Hi, > > Reserve a per-lcore 4MB memzone and allocate thread stack of EAL threads > there for better NUMA locality of stack-allocated variables I wonder if there any real performance improvement seen with that change? Any case (existing DPDK app/example) that can demonstrate it? Konstantin >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix resource leak after thread exits normally

2020-04-14 Thread Ananyev, Konstantin
> Hi Tao, > > > > Because ixgbe_dev_wait_setup_link_complete() doesn't guarantee that the > > thread will always complete properly. So after the wait > > timeout, need to call pthread_cancel() to cancel the thread. > > But pthread_cancel() also doesn't guarantee immediate thread termination.

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-04-14 Thread Stokes, Ian
> -Original Message- > From: Kevin Traynor > Sent: Friday, March 20, 2020 7:34 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hy

Re: [dpdk-dev] [PATCH v4 1/3] net/mlx5: add a devarg to specify MPRQ stride size

2020-04-14 Thread Ferruh Yigit
On 4/9/2020 11:23 PM, Alexander Kozyrev wrote: > Define a device parameter to configure log 2 of a stride size for MPRQ > - mprq_log_stride_size. User is able to specify a stride size in a range > allowed by an underlying hardware. The default stride size is defined as > 2048 bytes to encompass mos

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Akhil Goyal
Hi Ray/Thomas/Bruce, Could you please help review this patch wrt ABI policy? > > This patch adds versioned function rte_cryptodev_info_get. > Node 20.05 function works the same way it was working before. > Node 20.0 function strips capability added in 20.05 release > to prevent some issues with A

[dpdk-dev] [PATCH] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-14 Thread Adam Dybkowski
This patch adds support for plain SHA-1, SHA-224, SHA-256, SHA-384 and SHA-512 hashes to QAT PMD. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev_hash_test_vectors.h | 10 ++ doc/guides/cryptodevs/features/qat.ini | 5 + doc/guides/cryptodevs/qat.rst | 5 + driv

Re: [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events

2020-04-14 Thread Jerin Jacob
On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob wrote: > > On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh > wrote: > > > > Hi Mattias, > > Have a question on this fix. I understand you wanting a certain number of > > events before making a decision to migrate (in the above fix). > > However, suppose

Re: [dpdk-dev] [PATCH] net/ice: support mark only action for FDIR

2020-04-14 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Tuesday, April 14, 2020 5:12 PM > To: Zhang, Qi Z ; Ye, Xiaolong > Cc: dev@dpdk.org; Cao, Yahui ; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: support mark only action for FDIR > > Hi, Qi > > > -Original Message- > > From: Zha

Re: [dpdk-dev] [PATCH v4 1/3] net/mlx5: add a devarg to specify MPRQ stride size

2020-04-14 Thread Thomas Monjalon
14/04/2020 13:42, Ferruh Yigit: > On 4/9/2020 11:23 PM, Alexander Kozyrev wrote: > > Define a device parameter to configure log 2 of a stride size for MPRQ > > - mprq_log_stride_size. User is able to specify a stride size in a range > > allowed by an underlying hardware. The default stride size is

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Thomas Monjalon
14/04/2020 14:13, Akhil Goyal: > Hi Ray/Thomas/Bruce, > > Could you please help review this patch wrt ABI policy? > > > > This patch adds versioned function rte_cryptodev_info_get. > > Node 20.05 function works the same way it was working before. > > Node 20.0 function strips capability added in

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-14 Thread Trahe, Fiona
Hi Thomas, David, Ferruh, > -Original Message- > Subject: Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function > processing > > 14/04/2020 12:21, Ferruh Yigit: > > On 4/10/2020 11:55 PM, Thomas Monjalon wrote: > > > Hi, > > > > > > Adding more people (crypto PMD maintaine

Re: [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events

2020-04-14 Thread Mattias Rönnblom
On 2020-04-14 14:45, Jerin Jacob wrote: > On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob wrote: >> On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh >> wrote: >>> Hi Mattias, >>> Have a question on this fix. I understand you wanting a certain number of >>> events before making a decision to migrate (in

Re: [dpdk-dev] [EXT] [PATCH v6 0/2] support for VFIO-PCI VF token interface

2020-04-14 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Haiyue Wang > Sent: Tuesday, April 14, 2020 8:51 AM > To: dev@dpdk.org; tho...@monjalon.net; Vamsi Krishna Attunuru > ; Jerin Jacob Kollanukkaran ; > alex.william...@redhat.com; david.march...@redhat.com > Cc: Haiyue Wang > Subject: [EXT] [PATCH v6 0/2] supp

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-14 Thread Ananyev, Konstantin
> > > > > > > > +#ifdef ALLOW_EXPERIMENTAL_API > > > > +#include > > > > +#endif > > > > + > > > > /** > > > > * Enqueue several objects on a ring. > > > > * > > > > @@ -484,8 +520,21 @@ static __rte_always_inline unsigned int > > > > rte_ring_enqueue_bulk(struct rte_ring *r, void * const *ob

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-14 Thread Mattias Rönnblom
On 2020-04-14 06:43, Tonghao Zhang wrote: > On Tue, Apr 14, 2020 at 12:07 PM Stephen Hemminger > wrote: >> On Sun, 12 Apr 2020 16:27:53 +0800 >> xiangxia.m@gmail.com wrote: >> >>> From: Tonghao Zhang >>> >>> When rte_rand_init is invoked, and the kernel >>> (kernel version < 3.17) running dpd

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-04-14 Thread Aaron Conole
"Burakov, Anatoly" writes: > On 13-Mar-20 10:04 AM, David Marchand wrote: >> On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren >> wrote: >>> >>> This commit releases all service cores from their role, >>> returning them to ROLE_RTE on rte_service_finalize(). >>> >>> This may fix an issue relating

Re: [dpdk-dev] [PATCH v2] net/bnx2x: add multicast MAC address filtering

2020-04-14 Thread Jerin Jacob
On Tue, Apr 14, 2020 at 4:39 AM Rasesh Mody wrote: > > From: Souvik Dey > > Add support the set_mc_addr_list device operation in the bnx2xvf PMD. > > The configured addresses are stored in the device private area, so > they can be flushed before adding new ones. > Without this v6 multicast packet

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-14 Thread Thomas Monjalon
14/04/2020 15:04, Trahe, Fiona: > > 14/04/2020 12:21, Ferruh Yigit: > > http://inbox.dpdk.org/dev/mn2pr11mb35507d4b96677a41e66440c5e3...@mn2pr11mb3550.na > > mprd11.prod.outlook.com/ > > > > I am not convinced. > > I don't like rawdev in general. > > Rawdev is good only for hardware support which

Re: [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events

2020-04-14 Thread Jerin Jacob
On Tue, Apr 14, 2020 at 6:41 PM Mattias Rönnblom wrote: > > On 2020-04-14 14:45, Jerin Jacob wrote: > > On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob wrote: > >> On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh > >> wrote: > >>> Hi Mattias, > >>> Have a question on this fix. I understand you wanting

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-14 Thread David Marchand
On Tue, Apr 14, 2020 at 3:20 PM Mattias Rönnblom wrote: > > On 2020-04-14 06:43, Tonghao Zhang wrote: > > On Tue, Apr 14, 2020 at 12:07 PM Stephen Hemminger > > wrote: > >> On Sun, 12 Apr 2020 16:27:53 +0800 > >> xiangxia.m@gmail.com wrote: > >> > >>> From: Tonghao Zhang > >>> > >>> When rte

Re: [dpdk-dev] [PATCH v3] net/bnx2x: handle guest VLAN for SR-IOV case

2020-04-14 Thread Jerin Jacob
On Tue, Apr 14, 2020 at 4:39 AM Rasesh Mody wrote: > > From: Souvik Dey > > In case of bnx2xvf pmd, tx packets can support vland id in 2 ways: > 1. setting the mbuf ol_flags=PKT_TX_VLAN_PKT and passing the > vlanid in mbuf->vlan_tci. > 2. the tx packet itself has the vlan id included in the packe

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-14 Thread David Marchand
Hello Honnappa, On Mon, Apr 13, 2020 at 6:42 PM Honnappa Nagarahalli wrote: > > Reviews on those structures must be extra careful, as we are blind with > > those > > rules in place. > Yes, this is my concern. Why not remove these fixes and ignore the errors > manually (i.e. merge the patches kn

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Trahe, Fiona
Hi Akhil, Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 14, 2020 2:04 PM > To: Kusztal, ArkadiuszX > Cc: Ray Kinsella ; Richardson, Bruce > ; dev@dpdk.org; > Trahe, Fiona ; dev@dpdk.org; Akhil Goyal > > Subject: Re: [dpdk-dev] [PATCH] cryptodev: version r

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Ray Kinsella
On 18/03/2020 20:41, Arek Kusztal wrote: > This patch adds versioned function rte_cryptodev_info_get. > Node 20.05 function works the same way it was working before. > Node 20.0 function strips capability added in 20.05 release > to prevent some issues with ABI policy. To do that new capability

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-14 Thread Trahe, Fiona
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 14, 2020 2:24 PM > To: Yigit, Ferruh ; Trahe, Fiona > > Cc: Coyle, David ; dev@dpdk.org; Doherty, Declan > ; De Lara Guarch, Pablo > ; Ryan, > Brendan ; shreyansh.j...@nxp.com; > hemant.agra...@nxp.com; > a

Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat

2020-04-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Mohsin Shaikh > Sent: Thursday, April 9, 2020 11:37 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Alexander Kozyrev ; > Mohsin Shaikh > Subject: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib > stat > > fgets(3)/fread(3)

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: remove limitation for crypto sessions

2020-04-14 Thread Vladimir Medvedkin
Get rid of hardcoded limit of cryptodev sessions. Fixes: e1143d7dbbf4 ("examples/ipsec-secgw: get rid of maximum SA limitation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec-secgw.c | 12 +++- examples/ipsec-secgw/ipsec.h | 3 +

Re: [dpdk-dev] [PATCH v5] build: disable experimental API check internally

2020-04-14 Thread David Marchand
On Mon, Apr 13, 2020 at 4:56 PM David Marchand wrote: > > From: Pavan Nikhilesh > > Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and > meson.build. Instead, enable ALLOW_EXPERIMENTAL_API flag across app, lib > and drivers. > This changes reduces the clutter across the proj

Re: [dpdk-dev] [PATCH] net/ice: support mark only action for FDIR

2020-04-14 Thread Su, Simei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, April 14, 2020 8:51 PM > To: Su, Simei ; Ye, Xiaolong > Cc: dev@dpdk.org; Cao, Yahui ; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: support mark only action for FDIR > > > > > -Original Message- > > From: Su, Simei

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-14 Thread Thomas Monjalon
14/04/2020 16:02, Trahe, Fiona: > Hi Thomas, > > From: Thomas Monjalon > > 14/04/2020 15:04, Trahe, Fiona: > > > > 14/04/2020 12:21, Ferruh Yigit: > > > > > > http://inbox.dpdk.org/dev/mn2pr11mb35507d4b96677a41e66440c5e3...@mn2pr11mb3550.na > > > > mprd11.prod.outlook.com/ > > > > > > > > I am no

Re: [dpdk-dev] [PATCH v8] net/i40e: enable advanced RSS

2020-04-14 Thread Iremonger, Bernard
Hi Chenxu, > -Original Message- > From: dev On Behalf Of Chenxu Di > Sent: Tuesday, April 14, 2020 7:37 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Di, ChenxuX > > Subject: [dpdk-dev] [PATCH v8] net/i40e: enable advanced RSS > > This patch supports: > > - symmetric hash configuration >

[dpdk-dev] [PATCH v2] net/ice: support mark only action for FDIR

2020-04-14 Thread Simei Su
This patch fixes issue that doesn't support mark only case. Mark only action is equal to mark + passthru action. Fixes: f5cafa961fae ("net/ice: add flow director create and destroy") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/ice_fdir_filter.c | 14 +- 1 file ch

Re: [dpdk-dev] [PATCH] net/octeontx2: fix unnecessary error interrupts

2020-04-14 Thread Jerin Jacob
On Mon, Apr 13, 2020 at 7:15 PM Nithin Dabilpuram wrote: > > From: Nithin Dabilpuram > > Disable CQ_DISABLED error interrupt in NIX_LF_ERR_INT > to fix spurious interrupts in event dev mode. Also skip > configuring RSS when RQ count is '0' because > RSS table initialization is done incorrectly du

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-14 Thread Mattias Rönnblom
On 2020-04-14 15:35, David Marchand wrote: > On Tue, Apr 14, 2020 at 3:20 PM Mattias Rönnblom > wrote: >> On 2020-04-14 06:43, Tonghao Zhang wrote: >>> On Tue, Apr 14, 2020 at 12:07 PM Stephen Hemminger >>> wrote: On Sun, 12 Apr 2020 16:27:53 +0800 xiangxia.m@gmail.com wrote: >

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-14 Thread Mattias Rönnblom
On 2020-04-10 15:00, Jerin Jacob wrote: > On Thu, Apr 9, 2020 at 7:32 PM Mattias Rönnblom > wrote: >> On 2020-04-09 15:32, Jerin Jacob wrote: >>> On Thu, Apr 9, 2020 at 5:51 PM Mattias Rönnblom >>> wrote: On 2020-04-08 21:36, Jerin Jacob wrote: > On Wed, Apr 8, 2020 at 11:27 PM Mattias R

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-14 Thread Honnappa Nagarahalli
> > Hello Honnappa, > > On Mon, Apr 13, 2020 at 6:42 PM Honnappa Nagarahalli > wrote: > > > Reviews on those structures must be extra careful, as we are blind > > > with those rules in place. > > Yes, this is my concern. Why not remove these fixes and ignore the errors > manually (i.e. merge t

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-14 Thread Honnappa Nagarahalli
> Subject: RE: [PATCH v3 3/9] ring: introduce RTS ring mode > > > > > > > > > > > +#ifdef ALLOW_EXPERIMENTAL_API > > > > > +#include > > > > > +#endif > > > > > + > > > > > /** > > > > > * Enqueue several objects on a ring. > > > > > * > > > > > @@ -484,8 +520,21 @@ static __rte_always_inli

Re: [dpdk-dev] [PATCH v3 5/9] ring: introduce HTS ring mode

2020-04-14 Thread Ananyev, Konstantin
Hi Honnappa, > > Hi Konstantin, > Few nits/comments inline. > > > > > diff --git a/lib/librte_ring/rte_ring_hts.h > > b/lib/librte_ring/rte_ring_hts.h new > > file mode 100644 index 0..062d7be6c > > --- /dev/null > > +++ b/lib/librte_ring/rte_ring_hts.h > > @@ -0,0 +1,210 @@ > >

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-14 Thread Jerin Jacob
On Tue, Apr 14, 2020 at 9:27 PM Mattias Rönnblom wrote: > > On 2020-04-10 15:00, Jerin Jacob wrote: > > On Thu, Apr 9, 2020 at 7:32 PM Mattias Rönnblom > > wrote: > >> On 2020-04-09 15:32, Jerin Jacob wrote: > >>> On Thu, Apr 9, 2020 at 5:51 PM Mattias Rönnblom > >>> wrote: > On 2020-04-08

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-14 Thread Ananyev, Konstantin
Hi guys, > > > > Hello Honnappa, > > > > On Mon, Apr 13, 2020 at 6:42 PM Honnappa Nagarahalli > > wrote: > > > > Reviews on those structures must be extra careful, as we are blind > > > > with those rules in place. > > > Yes, this is my concern. Why not remove these fixes and ignore the errors

Re: [dpdk-dev] [PATCH v3 7/9] ring: introduce peek style API

2020-04-14 Thread Ananyev, Konstantin
> > > > For rings with producer/consumer in RTE_RING_SYNC_ST, > > RTE_RING_SYNC_MT_HTS mode, provide an ability to split enqueue/dequeue > > operation into two phases: > > - enqueue/dequeue start > > - enqueue/dequeue finish > > That allows user to inspect objects in the ring without

Re: [dpdk-dev] [PATCH v3 5/9] ring: introduce HTS ring mode

2020-04-14 Thread Honnappa Nagarahalli
> > > diff --git a/lib/librte_ring/rte_ring_hts_generic.h > > > b/lib/librte_ring/rte_ring_hts_generic.h > > > new file mode 100644 > > > index 0..da08f1d94 > > > --- /dev/null > > > +++ b/lib/librte_ring/rte_ring_hts_generic.h > > > @@ -0,0 +1,198 @@ > > > + > > > +/** > > > + * @inte

Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-14 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 14, 2020 11:34 AM > To: Doherty, Declan ; akhil.go...@nxp.com; Zhang, > Roy Fan ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: Re: [PATCH 2/2] test/crypto: do not check for IMB

[dpdk-dev] [PATCH] crypto/openssl: fix out-of-place encryption

2020-04-14 Thread Pablo de Lara
When authenticating after encrypting, if the operation is out-of-place, the destination buffer is the one that will get authenticated. If the cipher offset is higher than the authentication offset, it means that part of the text to authenticate will be plaintext, so this needs to get copied to the

[dpdk-dev] [PATCH] cryptodev: add missing feature name

2020-04-14 Thread Pablo de Lara
String for asymmetric sesionless support was missing. Fixes: f2b2a4497100 ("cryptodev: add asymmetric session-less") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev

Re: [dpdk-dev] [PATCH v3 7/9] ring: introduce peek style API

2020-04-14 Thread Honnappa Nagarahalli
> > > > > + > > > +/** > > > + * Start to enqueue several objects on the ring. > > > + * Note that no actual objects are put in the queue by this > > > +function, > > > + * it just reserves for user such ability. > > > + * User has to call appropriate enqueue_finish() to copy objects > > > +into

[dpdk-dev] [PATCH v3 0/2] Crypto test refactoring (first phase)

2020-04-14 Thread Pablo de Lara
This patchset adds crypto capability checks in the cryptodev test code, to be able to skip unsupported test cases for each crypto device, according to their capabilities. Thanks to this patchset, there is no more need to check for internal PMD information in the test code, making it more "device-a

[dpdk-dev] [PATCH v3 1/2] test/crypto: add capability check

2020-04-14 Thread Pablo de Lara
Check if test case is supported by the crypto device, including algorithm and some of its parameter, such as key length, IV length, etc, using the capabilities API. If it is not supported, test case is skipped. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_blockcipher.c | 49 +

[dpdk-dev] [PATCH v3 2/2] test/crypto: do not check for internal PMD information

2020-04-14 Thread Pablo de Lara
Now that capabilities are checked to see if an algorithm is supported by a device, there is no need to check for a specific version of a library used in a PMD. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_hash_test_vectors.h | 25 - 1 file changed, 25 deletion

Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-14 Thread Thomas Monjalon
14/04/2020 19:22, De Lara Guarch, Pablo: > Hi Thomas, > > From: Thomas Monjalon > > 14/04/2020 12:22, Pablo de Lara: > > > Now that capabilities are checked to see if an algorithm is supported > > > by a device, there is no need to check for a specific version of a > > > library used in a PMD. >

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-14 Thread Mattias Rönnblom
On 2020-04-14 18:15, Jerin Jacob wrote: > On Tue, Apr 14, 2020 at 9:27 PM Mattias Rönnblom > wrote: >> On 2020-04-10 15:00, Jerin Jacob wrote: >>> On Thu, Apr 9, 2020 at 7:32 PM Mattias Rönnblom >>> wrote: On 2020-04-09 15:32, Jerin Jacob wrote: > On Thu, Apr 9, 2020 at 5:51 PM Mattias R

[dpdk-dev] [PATCH 1/3] cryptodev: add sessionless support feature flag

2020-04-14 Thread Pablo de Lara
Add feature flag for symmetric sessionless support, so it can be checked by applications. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/features/aesni_gcm.ini | 1 + doc/guides/cryptodevs/features/aesni_mb.ini | 1 + doc/guides/cryptodevs/features/armv8.ini | 1 + doc/guides/crypto

[dpdk-dev] [PATCH 0/3] Crypto test refactoring (second phase)

2020-04-14 Thread Pablo de Lara
This patchset is the phase two of the crypto test refactoring effort. It mainly focuses on removing the PMD bitmask used to select which PMDs are used to run the tests against. Instead, now all PMDs will run all test cases and the capability checking will determine which ones are supported and ther

[dpdk-dev] [PATCH 2/3] test/crypto: check if device supports sessionless

2020-04-14 Thread Pablo de Lara
Before running any sessionless test cases, check if device supports this mode. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev_blockcipher.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_block

[dpdk-dev] [PATCH 3/3] test/crypto: do not check for PMD in tests

2020-04-14 Thread Pablo de Lara
Remove PMD bitmask, which selects the PMD to be tested for each test case. Instead, all PMDs are eligible to run all tests, and capability checking discards the PMDs which do not support each test case. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev.c | 1 - app/tes

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Trahe, Fiona
Hi Ray, We're going to need hep to understand the numbering. The examples here http://doc.dpdk.org/guides/contributing/abi_versioning.html#major-abi-versions show only major numbers in the .map file. Whereas the map files all have major.minor. The example shows that to add a new version of an ex

Re: [dpdk-dev] [PATCH] cryptodev: add missing feature name

2020-04-14 Thread Trahe, Fiona
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, April 14, 2020 6:30 PM > To: Doherty, Declan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cryptodev: add missing feature name > > String

Re: [dpdk-dev] [PATCH v3 9/9] ring: add C11 memory model for new sync modes

2020-04-14 Thread Ananyev, Konstantin
> > > > /** > > * @internal Enqueue several objects on the RTS ring. > > diff --git a/lib/librte_ring/rte_ring_rts_c11_mem.h > > b/lib/librte_ring/rte_ring_rts_c11_mem.h > > new file mode 100644 > > index 0..b72901497 > > --- /dev/null > > +++ b/lib/librte_ring/rte_ring_rts_c11_mem.h

Re: [dpdk-dev] [PATCH] cryptodev: add missing feature name

2020-04-14 Thread Lukasz Wojciechowski
W dniu 14.04.2020 o 20:29, Trahe, Fiona pisze: > >> -Original Message- >> From: dev On Behalf Of Pablo de Lara >> Sent: Tuesday, April 14, 2020 6:30 PM >> To: Doherty, Declan >> Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo >> ; >> sta...@dpdk.org >> Subject: [dpdk-dev]

  1   2   >