Hi Akhil, Thomas, > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Tuesday, April 14, 2020 2:04 PM > To: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com> > Cc: Ray Kinsella <m...@ashroe.eu>; Richardson, Bruce > <bruce.richard...@intel.com>; dev@dpdk.org; > Trahe, Fiona <fiona.tr...@intel.com>; dev@dpdk.org; Akhil Goyal > <akhil.go...@nxp.com> > Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get > function > > 14/04/2020 14:13, Akhil Goyal: > > Hi Ray/Thomas/Bruce, > > > > Could you please help review this patch wrt ABI policy? > > > > > > This patch adds versioned function rte_cryptodev_info_get. > > > Node 20.05 function works the same way it was working before. > > > Node 20.0 function strips capability added in 20.05 release > > What are Nodes 20.05 and 20.0? [Fiona] 20.0 is the designation for the API before 20.05 release.
> > > > to prevent some issues with ABI policy. To do that new capability > > > array is allocated per device and returned to user instead of the > > > original array passed by PMD. > > rte_cryptodev_info is provided by the caller of the function. > I don't understand what you explained above, and the code is missing > some comments explaining the reason of the logic. > > I still don't know whether this patch or not because it is missing > some clear explanations. [Fiona] We've identified that we also need to version the rte_cryptodev_capability_get() API as it calls rte_cryptodev_info_get(). And the version handling oly works on direct API calls, but not on calls within the API. We will send a v2 to handle this. And will add more explanation in the comments.
