Re: [dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-12 Thread Ori Kam
> -Original Message- > From: BillZhou > Sent: Friday, April 10, 2020 12:47 PM > To: Matan Azrad ; Bill Zhou ; > Ori Kam ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; > john.mcnam...@intel.com; marko.kovace...@intel.com; Thomas Monjalon > ; ferruh.yi...@in

Re: [dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-12 Thread Matan Azrad
From: Ori Kam > > -Original Message- > > From: BillZhou > > Sent: Friday, April 10, 2020 12:47 PM > > To: Matan Azrad ; Bill Zhou > ; > > Ori Kam ; wenzhuo...@intel.com; > > jingjing...@intel.com; bernard.iremon...@intel.com; > > john.mcnam...@intel.com; marko.kovace...@intel.com; Thomas

Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type

2020-04-12 Thread Ori Kam
Hi Jeff, For some reason I got the mail in HTML format So please see my comments marked by [Ori] Thanks, Ori From: Jeff Guo Sent: Tuesday, April 7, 2020 8:37 AM To: Ori Kam ; xiaolong...@intel.com; qi.z.zh...@intel.com Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com; simei...@intel

[dpdk-dev] [PATCH] doc: update LRO limitation for MLX5

2020-04-12 Thread Dekel Peled
MLX5 PMD limitation regarding use of LRO is updated. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index e13c07d..ff09e51 100644 --- a/doc/guides/nics/mlx5.

[dpdk-dev] [PATCH v2] net/ice/base: update version

2020-04-12 Thread Qi Zhang
Update base code version in readme. Signed-off-by: Qi Zhang --- v2: - Correct commit log drivers/net/ice/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 88548296d..726593971 100644 --- a/drivers/

[dpdk-dev] [PATCH v2] common/iavf: update version

2020-04-12 Thread Qi Zhang
Update base code release version in readme Signed-off-by: Qi Zhang Acked-by: Beilei Xing --- v2: - correct commit log drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7a

[dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang When rte_rand_init is invoked, and the kernel (kernel version < 3.17) running dpdk does't support *getentropy, at the same time, the cpu does't support rdseed, the rte_rand_init will invoke rte_get_timer_cycles which function will invoke rte_get_hpet_cycles (RTE_LIBEAL_USE_HPE

[dpdk-dev] supported nic

2020-04-12 Thread Sahil Khandelwal
I have the following nic in my system How do i check which one can be used with dpdk Network devices using kernel driver === :03:00.0 'RTL810xE PCI Express Fast Ethernet controller 8136' if=eno1 drv=r8169 unused=vfio-pci,uio_pci_generic :05:00.0 'Dual Band W

[dpdk-dev] [PATCH] doc: use glob terminology

2020-04-12 Thread jerinj
From: Jerin Jacob Globbing is the word used on fnmatch man page. Use globing terminology accross dpdk repo for shell pattern. Signed-off-by: Jerin Jacob --- devtools/check-includes.sh | 2 +- lib/librte_eal/include/rte_log.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v2] doc: use glob terminology

2020-04-12 Thread jerinj
From: Jerin Jacob Glob is the terminology used in fnmatch man page. Use glob terminology across DPDK for shell pattern. Signed-off-by: Jerin Jacob --- v2: - Fix typo devtools/check-includes.sh | 2 +- lib/librte_eal/include/rte_log.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [dpdk-dev] [PATCH] doc: use glob terminology

2020-04-12 Thread Thomas Monjalon
12/04/2020 16:40, jer...@marvell.com: > From: Jerin Jacob > > Globbing is the word used on fnmatch man page. Use globing > terminology accross dpdk repo for shell pattern. > > Signed-off-by: Jerin Jacob [...] > --- a/lib/librte_eal/include/rte_log.h > +++ b/lib/librte_eal/include/rte_log.h > -

Re: [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10)

2020-04-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, April 8, 2020 3:09 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10) > > In GCC 10, -fno-common will be the default. > There are 2 ways of solving issues

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect index when creating flow

2020-04-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, April 9, 2020 5:39 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org > Subject: [PATCH v2] net/mlx5: fix incorrect index when creating flow > > When creating a flow, usually the creating

Re: [dpdk-dev] [PATCH v5 14/15] doc: add event mode support to ipsec-secgw

2020-04-12 Thread Thomas Monjalon
27/02/2020 17:18, Lukasz Bartosik: > Document addition of event mode support > to ipsec-secgw application. > > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik This patch is doing more than adding event mode in doc. It should have been split to distinguish what are the real addition

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-04-12 Thread Thomas Monjalon
10/04/2020 17:03, Mairtin o Loingsigh: > This patch adds test vectors for AES-256 and sets AESNI-MB as the > target PMD There is really something wrong in the cryptodev API. Why the PMD must be selected in the tests? Isn't there some capabilities in cryptodev? Whitelisting PMD in the test prevents

Re: [dpdk-dev] [dpdk-dev v3 1/4] ethdev: add new RSS offload types

2020-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Saturday, April 11, 2020 8:10 AM > To: Ye, Xiaolong ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev v3 1/4] ethdev: add new RSS offload types > > Defines some new RSS offload typ

[dpdk-dev] [PATCH 00/10] net/mlx5: optimize flow resource allocation

2020-04-12 Thread Suanming Mou
Currently, flow may allocate several action resources during creation. Both allocate the individual resources and save the object handles have big memory overhead for the flow. Indexed memory pool is introduced to optimize the memory overhead. The resources can be allocated from the resource's own

[dpdk-dev] [PATCH 01/10] net/mlx5: add indexed memory pool

2020-04-12 Thread Suanming Mou
Currently, the memory allocated by rte_malloc() also introduced more than 64 bytes overhead. It means when allocate 64 bytes memory, the real cost in memory maybe double. And the libc malloc() overhead is 16 bytes, If users try allocating millions of small memory blocks, the overhead costing maybe

[dpdk-dev] [PATCH 03/10] net/mlx5: add trunk release for indexed pool

2020-04-12 Thread Suanming Mou
While entries are fully freed in trunk, it means the trunk is free now. User may prefer the free trunk memory can be reclaimed. Add the trunk release memory option for indexed pool in this case. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_utils.c | 37 +

[dpdk-dev] [PATCH 02/10] net/mlx5: add trunk dynamic grow for indexed pool

2020-04-12 Thread Suanming Mou
This commit add trunk dynamic grow for the indexed pool. In case for pools which are not sure the entry number needed, pools can be configured in increase progressively mode. It means the trunk size will be increased dynamically one after one, then reach a stable value. It saves memory to avoid al

[dpdk-dev] [PATCH 04/10] net/mlx5: convert encap/decap resource to indexed

2020-04-12 Thread Suanming Mou
This commit converts the flow encap/decap resource to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH 06/10] net/mlx5: convert tag resource to indexed

2020-04-12 Thread Suanming Mou
This commit convert tag resource to indexed. As tag resources are add in the hash list, to avoid introduce performance issue and keep the hash list, only the tag resource memory is allocated from indexed memory. The resources is still added to the hash list. Add four bytes index in the tag resourc

[dpdk-dev] [PATCH 07/10] net/mlx5: convert port id action to indexed

2020-04-12 Thread Suanming Mou
This commit converts port id action to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 11 +

[dpdk-dev] [PATCH 08/10] net/mlx5: convert jump resource to indexed

2020-04-12 Thread Suanming Mou
This commit convert jump resource to indexed. The table data struct is allocated from indexed memory. As it is add in the hash list, the pointer is still used for hash list search. The index is added to the table struct, and the pointer in flow handle is decrease to uint32_t type. For flow without

[dpdk-dev] [PATCH 05/10] net/mlx5: convert push VLAN resource to indexed

2020-04-12 Thread Suanming Mou
This commit converts the push VLAN resource to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH 09/10] net/mlx5: convert hrxq to indexed

2020-04-12 Thread Suanming Mou
This commit converts hrxq to indexed. Using the uint32_t index instead of pointer saves 4 bytes memory for the flow handle. For millions flows, it will save several MBytes of memory. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 31

[dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-12 Thread Shougang Wang
It's a normal behavior to change the link status to up after resetting the port. So it is unnecessary to set link down before starting port, and changing the link state(link up/down) frequently will cause link speed unstable. Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") Cc: sta...@dpdk.org

Re: [dpdk-dev] [dpdk-dev v3 2/4] net/iavf: add RSS configuration for VFs

2020-04-12 Thread Zhang, Qi Z
Hi Jeff: > -Original Message- > From: Guo, Jia > Sent: Saturday, April 11, 2020 8:10 AM > To: Ye, Xiaolong ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev v3 2/4] net/iavf: add RSS configuration for VFs > > The VF must be capa

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-12 Thread Yang, Qiming
> -Original Message- > From: Wang, ShougangX > Sent: Monday, April 13, 2020 09:39 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Wang, ShougangX ; > sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix link status after port reset > > It's a normal behavior to change the link sta

[dpdk-dev] [PATCH v1] eal: add VFIO-PCI SR-IOV support

2020-04-12 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. An example VF token option would take this form: 1. Install vfio-p

Re: [dpdk-dev] [PATCH] net/i40e: fix flow director initialisation

2020-04-12 Thread Xing, Beilei
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, April 7, 2020 11:27 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Cc: Doherty, Declan ; Ananyev, Konstantin > ; Shetty, Praveen > ; Iremonger, Bernard > ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix flow dire

[dpdk-dev] [PATCH v2] net/mlx5: fix push VLAN action wrongly use item info

2020-04-12 Thread Xiaoyu Min
Currently when PMD create push VLAN action it need to provide VID to HW and PMD get VID value from item VLAN in pattern if there is no of_set_vlan_vid action following. When user create rule like [1], which has of_set_vlan_vid action before of_push_vlan, the intention is to modify VID on existing

[dpdk-dev] [PATCH v2] net/mlx5: fix validation of push VLAN without full mask

2020-04-12 Thread Xiaoyu Min
Due the limitation of HW, when PMD create push VLAN action it needs to know what exactly the value of VID/PCP. PMD try to figure out them via: - of_set_vlan_vid/pcp actions - VLAN item in pattern If none of above is provided, default value - zero is used. However user will write rule like [1]

Re: [dpdk-dev] [PATCH] ethdev: support flow aging

2020-04-12 Thread Bill Zhou
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 10, 2020 6:14 PM > To: Bill Zhou > Cc: Matan Azrad ; Ori Kam ; > wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; john.mcnam...@intel.com; > marko.kovace...@intel.com; ferruh.yi...@intel.com; > a

[dpdk-dev] [PATCH v2] eal: add VFIO-PCI SR-IOV support

2020-04-12 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. An example VF token option would take this form: 1. Install vfio-p

Re: [dpdk-dev] [PATCH v2 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-12 Thread Ranjit Menon
On 4/10/2020 9:43 AM, Dmitry Kozlyuk wrote: This driver supports Windows EAL memory management by translating current process virtual addresses to physical addresses (IOVA). Standalone virt2phys allows using DPDK without PMD and provides a reference implementation. Signed-off-by: Dmitry Kozlyuk

[dpdk-dev] [PATCH v7] net/i40e: enable advanced RSS

2020-04-12 Thread Chenxu Di
This patch supports: - symmetric hash by rte_flow RSS action. - input set change by rte_flow RSS action. Signed-off-by: Chenxu Di --- v7: -Updated code about symmetric hash function --- doc/guides/nics/i40e.rst | 35 ++ doc/guides/rel_notes/release_20_05.rst | 7 + drivers/net/

Re: [dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson

2020-04-12 Thread Ruifeng Wang
Hi Juraj, > -Original Message- > From: dev On Behalf Of Juraj Linke? > Sent: Thursday, April 9, 2020 10:15 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson > > * Add arm-linux-gnueabihf cro

[dpdk-dev] [PATCH v3 01/11] net/igc: add igc PMD

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Implement device detection and loading. Add igc driver guid docs. Signed-off-by: Alvin Zhang v2: Update release note. Modify codes according to comments v3: Modify codes according to comments Fix secondary process hotplug fault --- MAINTAINERS

[dpdk-dev] [PATCH v3 00/11] igc pmd

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang New PMD for I225 NICs. Alvin Zhang (11): net/igc: add igc PMD net/igc: support device initialization net/igc: implement device base ops net/igc: support reception and transmission of packets net/igc: enable statistics net/igc: enable Rx queue interrupts net/igc: i

[dpdk-dev] [PATCH v3 03/11] net/igc: implement device base ops

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Bellow ops are implemented: dev_configure dev_start dev_stop dev_close dev_reset dev_set_link_up dev_set_link_down link_update fw_version_get dev_led_on dev_led_off Signed-off-by: Alvin Zhang v2: Modify codes according to comments. v3: Modify codes according to comments. ---

[dpdk-dev] [PATCH v3 05/11] net/igc: enable statistics

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Enable base statistics, extend statistics and per-queue statistics. Below ops are added: stats_get xstats_get xstats_get_by_id xstats_get_names_by_id xstats_get_names stats_reset xstats_reset queue_stats_mapping_set Signed-off-by: Alvin Zhang v2: fix xstats_get_names_by_id i

[dpdk-dev] [PATCH v3 04/11] net/igc: support reception and transmission of packets

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Below ops are added too: mac_addr_add mac_addr_remove mac_addr_set set_mc_addr_list mtu_set promiscuous_enable promiscuous_disable allmulticast_enable allmulticast_disable rx_queue_setup rx_queue_release rx_queue_count rx_descriptor_done rx_descriptor_status tx_descriptor_status

[dpdk-dev] [PATCH v3 06/11] net/igc: enable Rx queue interrupts

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Setup NIC to generate MSI-X interrupts. Set the IVAR register to map interrupt causes to vectors. Implement interrupt enable/disable functions. Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/igc_ethdev.c | 170

[dpdk-dev] [PATCH v3 07/11] net/igc: implement flow control ops

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Update feature list too. Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/igc_ethdev.c | 121 +++ 2 files changed, 122 insertions(+) diff --git a/doc/guides/nics/features/igc.ini b/doc/guides/nic

[dpdk-dev] [PATCH v3 08/11] net/igc: implement RSS API

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Below ops are added: reta_update reta_query rss_hash_update rss_hash_conf_get Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 2 + drivers/net/igc/igc_ethdev.c | 171 +++ drivers/net/igc/igc_ethdev.h | 9 +++ d

[dpdk-dev] [PATCH v3 10/11] net/igc: implement MAC-loopback mode

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang enable mac-loopback mode. Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 23 +++ drivers/net/igc/igc_txrx.c | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index b176b6e

[dpdk-dev] [PATCH v3 09/11] net/igc: implement feature of VLAN

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Below ops ware added: vlan_filter_set vlan_offload_set vlan_tpid_set vlan_strip_queue_set Signed-off-by: Alvin Zhang v2: fix max packet length fault when extend vlan is enabled or disabled v3: fix queue vlan offload fault, update docs. --- doc/guides/nics/features/igc.ini |

[dpdk-dev] [PATCH v3 11/11] net/igc: implement flow API

2020-04-12 Thread alvinx . zhang
From: Alvin Zhang Below type of flows are supported: ether-type filter, 2-tuple filter, SYN filter, RSS. Update docs too. Signed-off-by: Alvin Zhang V2: Modify codes according to comments. V3: Remove legacy ether-type, 2-tuple and tcp SYN filters API, add some examples of creating flow. --

[dpdk-dev] [PATCH v3] eal: add VFIO-PCI SR-IOV support

2020-04-12 Thread Haiyue Wang
The kernel module vfio-pci introduces the VF token to enable SR-IOV support since 5.7. The VF token can be set by a vfio-pci based PF driver and must be known by the vfio-pci based VF driver in order to gain access to the device. An example VF token option would take this form: 1. Install vfio-p