Re: [dpdk-dev] [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions

2020-03-16 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 3/5] net/fm10k: add ffu and statisti

[dpdk-dev] [Bug 419] usertools/dpdk-setup.sh crashes on non-alphanumeric input

2020-03-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=419 Bug ID: 419 Summary: usertools/dpdk-setup.sh crashes on non-alphanumeric input Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v1 5/5] net/fm10k: add switch management support

2020-03-16 Thread Wang, Xiao W
Hi Xiaojun, Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 5/5] net/fm10k: add switch management support

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-16 Thread Tonghao Zhang
On Mon, Mar 9, 2020 at 9:15 PM David Marchand wrote: > > On Mon, Mar 9, 2020 at 9:56 AM Tonghao Zhang wrote: > > On Mon, Mar 9, 2020 at 4:27 PM Olivier Matz wrote: > > > The fact that the ops index changes during mempool driver lifetime is > > > indeed frightening, especially knowning that this

[dpdk-dev] API for number of lanes in transceiver

2020-03-16 Thread Asaf Sinai
Hi, Could not find API for getting number of lanes in transceiver (e1000/ixgbe/i40e/mlx5 drivers). Is there such API? We currently use hard-coded values, according to the various SFF standards (8074, 8431, 8436, 8636, etc.). Thanks, Asaf [Radware] Asaf Sinai ND SW Engineer Email: asa...@radwar

Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name

2020-03-16 Thread Olivier Matz
Hi Tonghao, On Mon, Mar 16, 2020 at 03:43:40PM +0800, Tonghao Zhang wrote: > On Mon, Mar 9, 2020 at 9:15 PM David Marchand > wrote: > > > > On Mon, Mar 9, 2020 at 9:56 AM Tonghao Zhang > > wrote: > > > On Mon, Mar 9, 2020 at 4:27 PM Olivier Matz > > > wrote: > > > > The fact that the ops ind

[dpdk-dev] [PATCH 03/12] net/iavf: support to query DDP package info

2020-03-16 Thread Leyi Rong
Advanced iAVF supports to query DDP package info, includes package version, track id, package name, device serial number and the list of protocols that the PF supports. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h| 9 drivers/net/iavf/iavf_ethdev.c | 7 ++ drivers/

[dpdk-dev] [PATCH 02/12] net/iavf: return error if opcode is mismatched

2020-03-16 Thread Leyi Rong
Adds error return when the opcode of read message is mismatched which is received from adminQ. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_

[dpdk-dev] [PATCH 04/12] net/iavf: flexible Rx descriptor support in normal path

2020-03-16 Thread Leyi Rong
Support flexible Rx descriptor format in normal path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h| 2 + drivers/net/iavf/iavf_ethdev.c | 8 + drivers/net/iavf/iavf_rxtx.c | 507 - drivers/net/iavf/iavf_rxtx.h | 11 + drivers/n

[dpdk-dev] [PATCH 01/12] net/iavf: remove 16B Rx descriptor compile option

2020-03-16 Thread Leyi Rong
Remove CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC as it's not supported in ice PF host driver. Signed-off-by: Leyi Rong --- config/common_base| 1 - drivers/net/iavf/iavf_rxtx.c | 2 - drivers/net/iavf/iavf_rxtx.h | 14 +-- drivers/net/iavf/iavf_rxtx_vec_avx

[dpdk-dev] [PATCH] vhost: cache guest/vhost physical address mapping

2020-03-16 Thread Marvin Liu
If Tx zero copy enabled, gpa to hpa mapping table is updated one by one. This will harm performance when guest memory backend using 2M hugepages. Now add cached mapping table which will sorted by using sequence. Address translation will first check cached mapping table, now performance is back. Si

[dpdk-dev] [PATCH 00/12] framework for advanced iAVF PMD

2020-03-16 Thread Leyi Rong
This patchset enable framework for advanced iAVF, includes query DDP pkg info, flexible descriptor support, FDIR mark id and RSS hash support. Leyi Rong (12): net/iavf: remove 16B Rx descriptor compile option net/iavf: return error if opcode is mismatched net/iavf: support to query DDP packa

[dpdk-dev] [PATCH 08/12] net/iavf: support flow mark in normal data path

2020-03-16 Thread Leyi Rong
Support Flow Director mark ID parsing in normal path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 3 +++ drivers/net/iavf/iavf_rxtx.c | 37 2 files changed, 40 insertions(+) diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h inde

[dpdk-dev] [PATCH 05/12] net/iavf: flexible Rx descriptor support in AVX path

2020-03-16 Thread Leyi Rong
Support flexible Rx descriptor format in AVX path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 24 +- drivers/net/iavf/iavf_rxtx.h | 6 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 550 +- 3 files changed, 570 insertions(+), 1

[dpdk-dev] [PATCH 06/12] net/iavf: flexible Rx descriptor support in SSE path

2020-03-16 Thread Leyi Rong
Support flexible Rx descriptor format in SSE path of iAVF PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 4 +- drivers/net/iavf/iavf_rxtx.h | 5 + drivers/net/iavf/iavf_rxtx_vec_sse.c | 414 +++ 3 files changed, 421 insertions(+), 2 d

[dpdk-dev] [PATCH 09/12] net/iavf: support flow mark in AVX path

2020-03-16 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in AVX path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 82 +-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf

[dpdk-dev] [PATCH 07/12] net/iavf: add flow director enabled switch value

2020-03-16 Thread Leyi Rong
The commit adds fdir_enabled flag into iavf_adapter structure to identify if fdir id is active. Rx data path can be benefit if fdir id parsing is not needed, especially in vector path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_rxtx.h | 26 +++

[dpdk-dev] [PATCH 10/12] net/iavf: support flow mark in SSE path

2020-03-16 Thread Leyi Rong
Support Flow Director mark ID parsing from Flex Rx descriptor in SSE path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/i

[dpdk-dev] [PATCH 11/12] net/iavf: add RSS hash parsing in AVX path

2020-03-16 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in AVX data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 92 ++- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH 12/12] net/iavf: add RSS hash parsing in SSE path

2020-03-16 Thread Leyi Rong
Support RSS hash parsing from Flex Rx descriptor in SSE data path. Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 86 ++-- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH] vhost: fix packed ring zero-copy

2020-03-16 Thread Marvin Liu
Available buffer ID should be stored in the zmbuf in the packed-ring dequeue path. There's no guarantee that local queue avail index is equal to buffer ID. Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reported-by: Yin

[dpdk-dev] [PATCH] app/testpmd: enhance GTP support

2020-03-16 Thread Dekel Peled
This patch adds CLI option to enter the v_pt_rsv_flags value for GTP flow pattern item. It also adds GTP as valid item in raw_encap nad raw_decap setting. Signed-off-by: Dekel Peled --- app/test-pmd/cmdline_flow.c | 12 1 file changed, 12 insertions(+) diff --git a/app/test-pmd/cmd

[dpdk-dev] DPDK 20.05 Mellanox Roadmap

2020-03-16 Thread Gal Cohen
Below is Mellanox's roadmap for DPDK20.05: Reduce memory consumption in mlx5 PMD - [1] Reduce flow memory (entry size) footprint/consumption. [2] Remove flow rules caching. Change the mlx5 PMD implementation of rte_eth_dev_stop()/rte_eth_dev_start() to stop caching flow rules (freeing resour

Re: [dpdk-dev] [PATCH v3 0/4] no-huge unit test

2020-03-16 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Friday, March 13, 2020 23:54 > To: Aaron Conole > Cc: Ruifeng Wang ; Michael Santana > ; Bruce Richardson > ; Ananyev, Konstantin > ; Cristian Dumitrescu > ; Wang, Yipeng1 > ; Gobriel, Sameh ; > dev ; Burakov, Anatoly ; > Gavin Hu ; Hon

[dpdk-dev] [rte_ethdev] mac_addrs as part of dev_private may cause primary process crash

2020-03-16 Thread 胡林帆
Hi all, struct rte_eth_dev_data has a member named dev_private and another named mac_addrs, as shown below: struct rte_eth_dev_data { ... void *dev_private; /**< PMD-specific private data. * @see rte_eth_dev_release_port() */ struct ether_addr *mac_addrs; /**< Device Ethernet link address.

[dpdk-dev] [PATCH] net/mlx5: fix CVLAN tag set in IP item translation

2020-03-16 Thread Dekel Peled
Previous fix added, at the end of functions flow_dv_translate_item_ipv4() and flow_dv_translate_item_ipv6(), the setting of cvlan_tag mask. In the case of unspecified item (item->spec == null) these functions return, and the new code section is not reached. This patch moves the setting of cvlan_ta

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-16 Thread Ori Kam
Hi Xiang, > -Original Message- > From: Wang Xiang > Sent: Monday, March 16, 2020 3:26 AM > To: Ori Kam > Cc: jer...@marvell.com; dev@dpdk.org; pbhagavat...@marvell.com; Shahaf > Shuler ; hemant.agra...@nxp.com; Opher Reviv > ; Alex Rosenbaum ; > dov...@marvell.com; pkap...@marvell.com; n

[dpdk-dev] Garbage value is returned while reading moudle eeprom for i40e (PF) with DPDK 18.11

2020-03-16 Thread Anubhav Choudhary
Hi, I am using Intel X710 along with FINISAR module (FTLX1471D3BCL). I am trying to read the module's eeprom but I am getting garbage values when DPDK is used. However, it is working perfectly fine when device is bound to the linux kernel. I have attached the device details along with the eeprom

[dpdk-dev] [PATCH 0/8] add new features to octeontx PMD

2020-03-16 Thread Harman Kalra
This patchset adds following new features to octeontx PMD: * Multi segment support * MTU support * Setting link up and down * VLAN filter offload * flow control - pause frames * Rx Tx checksum offload Harman Kalra (6): net/octeontx: add multi segment support net/octeontx: add framework for Rx/

[dpdk-dev] [PATCH 1/8] net/octeontx: add multi segment support

2020-03-16 Thread Harman Kalra
Adding multi segment support to the octeontx PMD. Also adding the logic to share rx/tx ofloads with the eventdev code. Signed-off-by: Harman Kalra --- doc/guides/nics/features/octeontx.ini| 1 + doc/guides/nics/octeontx.rst | 1 + drivers/event/octeontx/ssovf_worker.c

[dpdk-dev] [PATCH 4/8] net/octeontx: add MTU support

2020-03-16 Thread Harman Kalra
Adding support for mtu eth operation which configures mtu based on max pkt len. Signed-off-by: Harman Kalra --- doc/guides/nics/features/octeontx.ini | 1 + doc/guides/nics/octeontx.rst | 1 + drivers/net/octeontx/base/octeontx_bgx.c | 17 + drivers/net/octeontx/base/o

[dpdk-dev] [PATCH 2/8] net/octeontx: add framework for Rx/Tx offloads

2020-03-16 Thread Harman Kalra
Adding macro based framework to hook rx/tx burst function pointers to the appropriate function based on rx/tx offloads. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_worker.c | 9 +- drivers/net/octeontx/octeontx_ethdev.c | 27 ++-- drivers/net/octeontx/octeontx_ethdev.h | 12

[dpdk-dev] [PATCH 3/8] net/octeontx: add fast mbuf free support

2020-03-16 Thread Harman Kalra
This patch adds capability to fast release of mbuf following successful transmission. Signed-off-by: Harman Kalra --- drivers/net/octeontx/octeontx_ethdev.c | 4 +- drivers/net/octeontx/octeontx_ethdev.h | 1 + drivers/net/octeontx/octeontx_rxtx.c | 9 +-- drivers/net/octeontx/octeontx_rxtx

[dpdk-dev] [PATCH 8/8] net/octeontx: support Rx Tx checksum offload

2020-03-16 Thread Harman Kalra
This patch implements rx/tx checksum offload. In case of wrong checksum received (inner/outer l3/l4) it reports the corresponding layer which has bad checksum and also corrects it if hw checksum is enabled on tx side. Signed-off-by: Harman Kalra --- doc/guides/nics/features/octeontx.ini | 4 +

[dpdk-dev] [PATCH 7/8] net/octeontx: add flow control support

2020-03-16 Thread Harman Kalra
From: Vamsi Attunuru Patch adds ethdev flow control set/get callback ops, pmd enables modifying flow control attributes like rx_pause, tx_pause, high & low water mark. Signed-off-by: Vamsi Attunuru --- doc/guides/nics/features/octeontx.ini | 1 + drivers/net/octeontx/base/octeontx_bgx.c

[dpdk-dev] [PATCH 5/8] net/octeontx: add VLAN filter offload support

2020-03-16 Thread Harman Kalra
From: Vamsi Attunuru Patch adds support for vlan filter offload support. MBOX messages for vlan filter on/off and vlan filter entry add/rm are added to configure PCAM entries to filter out the vlan traffic on a given port. Patch also defines rx_offload_flag for vlan filtering. Signed-off-by: Va

[dpdk-dev] [PATCH 6/8] net/octeontx: add set link up down support

2020-03-16 Thread Harman Kalra
Adding support for setting link up/down eth operation. It is used to enable disable lmac. Also implemented a poll function for getting the link status at regular intervals. Signed-off-by: Harman Kalra --- doc/guides/nics/features/octeontx.ini | 1 + drivers/net/octeontx/base/octeontx_bgx

[dpdk-dev] [PATCH] testpmd: added rte_eth_dev_fw_version_get in testpmd rte_eth_dev_fw_version_get() was not called in test pmd. Added rte_eth_dev_fw_version_get() in testpmd under show port info

2020-03-16 Thread Muhammad Ahmad
From: Muhammad Ahmad Bugzilla ID: 225 Cc: dev@dpdk.org Reported-by: Thomas Monjalon Signed-off-by: Muhammad Ahmad --- app/test-pmd/config.c | 6 ++ app/test-pmd/testpmd.h | 3 ++- app/test-pmd/util.c| 14 ++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation

2020-03-16 Thread Kevin Traynor
On 16/03/2020 02:02, Li, Xiaoyun wrote: > > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Saturday, March 14, 2020 03:16 >> To: Li, Xiaoyun ; Zhike Wang ; >> dev@dpdk.org >> Cc: Xing, Beilei ; Zhang, Qi Z ; >> sta...@dpdk.org >> Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > 14/03/2020 00:38, Dmitry Kozlyuk: > > > I suggest this change (I can send a patch fixing the issue in other .h > > > files): > > > > > > +/* > > > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > > > + * while a hos

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > I suggest this change (I can send a patch fixing the issue in other .h > > > > files): > > > > > > > > +/* > > > > + *

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Thomas Monjalon
16/03/2020 12:02, Bruce Richardson: > On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > I suggest this change (I can send a patch fixing the issue in other > > > >

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 12:14:51PM +0100, Thomas Monjalon wrote: > 16/03/2020 12:02, Bruce Richardson: > > On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > > I

[dpdk-dev] [PATCH] pci: fix unneeded includes in public header file

2020-03-16 Thread Bruce Richardson
The rte_pci.h file includes more header files than are actually needed, which means that all users of it also include those headers. This patch removes the unneeded headers - adding them elsewhere where other components were requiring them but not including them directly. Fixes: c752998b5e2e ("pci

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 12:14:51PM +0100, Thomas Monjalon wrote: > 16/03/2020 12:02, Bruce Richardson: > > On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > > I

[dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-16 Thread Thomas Monjalon
RTE_TOOLCHAIN_* macros are defining the target compiler. Some API may be used in a host application like pmdinfogen. That's why the the public headers should check the effective compiler in use instead of the target compiler. Detecting the compiler with macros is easy, except for __GNUC__ which is

[dpdk-dev] [PATCH v2] [RFC] ethdev: support flow aging

2020-03-16 Thread BillZhou
One of the reasons to destroy a flow is the fact that no packet matches the flow for "timeout" time. For example, when TCP\UDP sessions are suddenly closed. Currently, there is no any dpdk mechanism for flow aging and the applications use there own ways to detect and destroy aged-out flows. This

Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes

2020-03-16 Thread Chauskin, Igor
Hi Gavin, Thank you for the contribution. Please do not merge these changes (patches 0..7) till we (the ENA team) properly review and ack/nack. These changes can potentially provide performance improvement, yet we need to ensure they are applicable for all possible scenarios. Specifically, the

[dpdk-dev] [PATCH v3 2/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-16 Thread Adam Dybkowski
This patch adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 9 -

[dpdk-dev] [PATCH v3 1/2] common/qat: get version of QAT firmware

2020-03-16 Thread Adam Dybkowski
This patch adds the function for retrieving QAT firmware version, required to check the internal capabilities that depend on the FW version. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw.h | 2 + drivers/common/qat/qat_qp.c | 93 + d

[dpdk-dev] [PATCH v3 0/2] crypto/qat: handle mixed hash-cipher crypto on GEN2 QAT

2020-03-16 Thread Adam Dybkowski
This patch set adds handling of mixed hash-cipher algorithms available on GEN2 QAT in particular firmware versions. Also the documentation is updated to show the mixed crypto algorithms are supported on QAT GEN2. v2: * minor fixes and improvements v3: * include missing header file Adam Dybkowski

[dpdk-dev] [PATCH v2] [RFC] ethdev: support flow aging

2020-03-16 Thread BillZhou
One of the reasons to destroy a flow is the fact that no packet matches the flow for "timeout" time. For example, when TCP\UDP sessions are suddenly closed. Currently, there is no any dpdk mechanism for flow aging and the applications use there own ways to detect and destroy aged-out flows. This

Re: [dpdk-dev] [PATCH v4 1/2] net/axgbe: support flow control API

2020-03-16 Thread Ferruh Yigit
On 3/16/2020 3:53 AM, Kumar, Ravi1 wrote: <...>>> From: Amaranath Somalapuram >> >> Adding api for flow_ctrl_get and flow_ctrl_set. >> By default axgbe driver flow control is disabled. >> Adding dpdk flow control to set water high and low. >> >> Signed-off-by: Amaranath Somalapuram > > For series

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-03-16 Thread Trahe, Fiona
Hi, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, February 13, 2020 2:51 PM > To: Trahe, Fiona ; Thomas Monjalon > > Cc: David Marchand ; nhor...@tuxdriver.com; > bl...@debian.org; > ktray...@redhat.com; Ray Kinsella ; dev@dpdk.org; Akhil Goyal > ; Yigit, Ferruh ;

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-03-16 Thread Thomas Monjalon
16/03/2020 13:57, Trahe, Fiona: > From: Kusztal, ArkadiuszX > > > > > The patch we're working on will provide two versions of > > > > > rte_cryptodev_info_get(), both call the same PMD function from the > > > dev_ops info_get fn ptr. > > > > > The default version operates s as normal, the 19.11 ve

[dpdk-dev] [PATCH 0/2] support CPU crypto for AESNI MB PMD

2020-03-16 Thread Konstantin Ananyev
Add support for CPU crypto API into aesni_mb PMD and extend cryptodev UT to cover this new functionality. Konstantin Ananyev (2): crypto/aesni_mb: support CPU crypto test/crypto: add CPU crypto mode for AESNI MB app/test/test_cryptodev.c | 146 +-- doc/guides/cryptode

[dpdk-dev] [PATCH 2/2] test/crypto: add CPU crypto mode for AESNI MB

2020-03-16 Thread Konstantin Ananyev
This patch adds ability to run unit tests in cpu crypto mode for AESNI MB cryptodev. Signed-off-by: Konstantin Ananyev --- app/test/test_cryptodev.c | 146 ++ 1 file changed, 115 insertions(+), 31 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support CPU crypto

2020-03-16 Thread Konstantin Ananyev
Add support for CPU crypto mode by introducing required handler. Signed-off-by: Konstantin Ananyev --- doc/guides/cryptodevs/aesni_mb.rst| 3 + doc/guides/cryptodevs/features/aesni_mb.ini | 1 + .../crypto/aesni_mb/aesni_mb_pmd_private.h| 5 +- drivers/crypto/aesni_mb/rte

Re: [dpdk-dev] [PATCH v3 0/4] no-huge unit test

2020-03-16 Thread Aaron Conole
Ruifeng Wang writes: >> -Original Message- >> From: David Marchand >> Sent: Friday, March 13, 2020 23:54 >> To: Aaron Conole >> Cc: Ruifeng Wang ; Michael Santana >> ; Bruce Richardson >> ; Ananyev, Konstantin >> ; Cristian Dumitrescu >> ; Wang, Yipeng1 >> ; Gobriel, Sameh ; >> dev ; Bu

Re: [dpdk-dev] [PATCH v1 1/3] net/axgbe: support for rxq and txq info API

2020-03-16 Thread Ferruh Yigit
On 3/14/2020 6:16 PM, Kumar, Ravi1 wrote: > [AMD Public Use] <...> > >> From: Amaranath Somalapuram >> >> Adding API for axgbe_rxq_info_get, axgbe_txq_info_get >> >> Signed-off-by: Amaranath Somalapuram > > For series, > Acked-by: Ravi Kumar > Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-16 Thread Wang Xiang
Hi Ori, On Mon, Mar 16, 2020 at 09:09:06AM +, Ori Kam wrote: > Hi Xiang, > > > -Original Message- > > From: Wang Xiang > > Sent: Monday, March 16, 2020 3:26 AM > > To: Ori Kam > > Cc: jer...@marvell.com; dev@dpdk.org; pbhagavat...@marvell.com; Shahaf > > Shuler ; hemant.agra...@nxp.

Re: [dpdk-dev] [PATCH] ethdev: add DBDF action to RTE Flow

2020-03-16 Thread Ori Kam
Hi Kiran, > -Original Message- > From: kirankum...@marvell.com > Sent: Tuesday, March 10, 2020 6:06 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org; Kiran

[dpdk-dev] [PATCH 1/3] hash: add dwk hash library

2020-03-16 Thread Vladimir Medvedkin
DWK hash is a Double Word Key(uint32_t) hash table. The value is uint64_t. This table is hash function agnostic so user must provide precalculated hash signature for add/delete/lookup operations. Signed-off-by: Vladimir Medvedkin --- lib/Makefile | 2 +- lib/librte_hash

[dpdk-dev] [PATCH 3/3] test: add dwk perf tests

2020-03-16 Thread Vladimir Medvedkin
Add performance tests for rte_dwk_hash. Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 81 +++ 1 file changed, 81 insertions(+) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index a438eae..f616af1 100644 --- a/a

[dpdk-dev] [PATCH 2/3] test: add dwk hash autotests

2020-03-16 Thread Vladimir Medvedkin
Add autotests for rte_dwk_hash library Signed-off-by: Vladimir Medvedkin --- app/test/Makefile| 1 + app/test/meson.build | 1 + app/test/test_dwk_hash.c | 229 +++ 3 files changed, 231 insertions(+) create mode 100644 app/test/test_dw

[dpdk-dev] [PATCH 0/3] add new Double Word Key hash table

2020-03-16 Thread Vladimir Medvedkin
Currently DPDK has a special implementation of a hash table for 4 byte keys which is called FBK hash. Unfortunately its main drawback is that it only supports 2 byte values. The new implementation called DWK (double word key) hash supports 8 byte values, which is enough to store a pointer. It woul

[dpdk-dev] [PATCH] ipsec: introduce dwk hash in ipsec sad library

2020-03-16 Thread Vladimir Medvedkin
Use dwk hash table as a placeholder for SPI_ONLY sa rules instead of current cuckoo hash to increase lookup performance. Signed-off-by: Vladimir Medvedkin --- This patch depends on https://patches.dpdk.org/patch/66712/ lib/librte_ipsec/ipsec_sad.c | 119 +

Re: [dpdk-dev] [dpdk-users] Issue while running DPDK19.11 test-pmd with Intel X722 Nic

2020-03-16 Thread Puneet Singh
Hi Xiaoyun Li , With changes you suggested ,Testpmd works fine on my setup. But With my own application, the port is detected properly, the queue setup to NIC also does not give any error. But my application is not getting any packets on the rx burst polls. Any suggestions on what is the best way

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-16 Thread Ori Kam
Hi Wang, PSB, if you don't have any objections and other comments, I will start working on the class and will address all of this thread comments in the v1 patch, Thanks, Ori > -Original Message- > From: Wang Xiang > Sent: Monday, March 16, 2020 10:48 PM > To: Ori Kam > Cc: jer...@m

Re: [dpdk-dev] [PATCH] vhost: cache guest/vhost physical address mapping

2020-03-16 Thread Ye Xiaolong
Hi, Marvin On 03/16, Marvin Liu wrote: >If Tx zero copy enabled, gpa to hpa mapping table is updated one by >one. This will harm performance when guest memory backend using 2M >hugepages. Now add cached mapping table which will sorted by using >sequence. Address translation will first check cached

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-16 Thread Wang Xiang
Hi Ori, Yes, please go ahead with the patch. Thanks, Xiang On Mon, Mar 16, 2020 at 01:49:51PM +, Ori Kam wrote: > Hi Wang, > > PSB, if you don't have any objections and other comments, > I will start working on the class and will address all of this thread > comments > in the v1 patch, >

Re: [dpdk-dev] [PATCH v3 0/4] no-huge unit test

2020-03-16 Thread Aaron Conole
David Marchand writes: > On Fri, Mar 13, 2020 at 2:04 PM Aaron Conole wrote: >> >> Aaron Conole writes: >> >> > Ruifeng Wang writes: >> > >> >> For environments (such as containers) where hugetlbfs are not available, >> >> some unit tests can be run with 'no-huge' option. >> >> >> >> fast-test

Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-16 Thread Thomas Monjalon
16/03/2020 13:04, Thomas Monjalon: > RTE_TOOLCHAIN_* macros are defining the target compiler. > Some API may be used in a host application like pmdinfogen. > That's why the the public headers should check the effective compiler > in use instead of the target compiler. > > Detecting the compiler wi

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Thomas Monjalon
14/03/2020 00:38, Dmitry Kozlyuk: > > I suggest this change (I can send a patch fixing the issue in other .h > > files): > > > > +/* > > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > > + * while a host application (like pmdinfogen) may have another compiler. > > + * RTE_CC_IS_GN

Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file

2020-03-16 Thread Thomas Monjalon
16/03/2020 12:29, Bruce Richardson: > The rte_pci.h file includes more header files than are actually needed, > which means that all users of it also include those headers. This patch > removes the unneeded headers - adding them elsewhere where other components > were requiring them but not includi

Re: [dpdk-dev] [PATCH 0/3] add new Double Word Key hash table

2020-03-16 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Vladimir Medvedkin > Sent: Monday, March 16, 2020 2:38 PM > > Currently DPDK has a special implementation of a hash table for > 4 byte keys which is called FBK hash. Unfortunately its main drawback > is that it only supports 2 byte values. > T

Re: [dpdk-dev] [PATCH v3 0/4] no-huge unit test

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 10:13:23AM -0400, Aaron Conole wrote: > David Marchand writes: > > > On Fri, Mar 13, 2020 at 2:04 PM Aaron Conole wrote: > >> > >> Aaron Conole writes: > >> > >> > Ruifeng Wang writes: > >> > > >> >> For environments (such as containers) where hugetlbfs are not availabl

[dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats

2020-03-16 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this patch introduce new API to get traffic statistics per virtio queue. The statistics are taken directly from the vDPA driver managing the HW device. Signed-off-by

[dpdk-dev] [PATCH 0/4] event/octeontx: support new features

2020-03-16 Thread Harman Kalra
Since event-octeontx PMD and net-octeontx PMD works very tightly, so this patchset implements the event-octeontx side changes to support new features added to net-octeontx PMD. This patchset is based on: [1] https://patches.dpdk.org/cover/66691/ Depends-on: series-8923 Harman Kalra (3): event/

[dpdk-dev] [PATCH 1/4] event/octeontx: add multi segment support to eventdev

2020-03-16 Thread Harman Kalra
Adding support for multi segment to the eventdev PMD. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_evdev.c | 33 +++--- drivers/event/octeontx/ssovf_evdev.h | 13 drivers/event/octeontx/ssovf_worker.c | 90 --- drivers/event/octeontx/ssovf_worke

[dpdk-dev] [PATCH 2/4] event/octeontx: add framework for Rx/Tx offloads

2020-03-16 Thread Harman Kalra
Adding macro based framework to hook dequeue/enqueue function pointers to the appropriate function based on rx/tx offloads. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_evdev.c | 36 drivers/event/octeontx/ssovf_evdev.h | 24 +-- drivers/event/octeontx/ssovf_worker.c | 2

[dpdk-dev] [PATCH 4/4] event/octeontx: support Rx Tx checksum offload

2020-03-16 Thread Harman Kalra
Adding support for rx checksum offload. In case of wrong checksum received (inner/outer l3/l4) it reports the corresponding layer which has bad checksum. It also adds rx burst function pointer hook for rx checksum offload to event PMD. Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf

[dpdk-dev] [PATCH 3/4] event/octeontx: add VLAN filter offload support

2020-03-16 Thread Harman Kalra
From: Vamsi Attunuru Adding rx burst function pointer hooks for vlan filter offload in event PMD. Signed-off-by: Vamsi Attunuru --- drivers/event/octeontx/ssovf_worker.c | 38 +++ drivers/event/octeontx/ssovf_worker.h | 9 +++ drivers/net/octeontx/octeontx_rxtx.h

[dpdk-dev] [PATCH] net/mlx5: reduce txq completion index memory loads

2020-03-16 Thread Alexander Kozyrev
There is a non-optimal check if doorbel is needed present in the mlx5_tx_handle_completion() function. Advancing a copy of the txq consumer index and checking this copy with initial value causes unnecessary memory loads and hurts the performance. It is better to have a simple small boolean variable

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value

2020-03-16 Thread Slava Ovsiienko
Hi, Didier First, thank you for the patch. If we have a look at the description of rte_eth_rx_queue_count(): "Get the number of used descriptors of a rx queue". It means the DPDK generic descriptors, not PMD specific ones. "DPDK descriptor" means the entity which can handle one packet. rte_eth_

[dpdk-dev] [PATCH v2 0/6] check for owned ports in portmask

2020-03-16 Thread Stephen Hemminger
The failsafe, bonding, and netvsc PMD use eth dev port ownership to control sub devices. These sub devices are hidden in the normal iteration over ports but some applications use a direct port mask. In these cases, user may still (incorrectly) try to directly use the sub devices. This patch set i

[dpdk-dev] [PATCH v2 1/6] rte_ethdev: add function to check if device is owned

2020-03-16 Thread Stephen Hemminger
This is a simple helper function to check if device is owned (being used as a sub-device). It is more convienent than having applications call rte_eth_dev_owner_get and check the result. Signed-off-by: Stephen Hemminger --- v2 - rename the helper function and use rte_eth_dev_owner_get lib/librt

[dpdk-dev] [PATCH v2 3/6] examples/l3fwd: block attempts to use owned ports

2020-03-16 Thread Stephen Hemminger
If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of l3fwd. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l3fwd/Makefile| 3 +++ examples/l3fwd/main.c |

[dpdk-dev] [PATCH v2 2/6] examples/l2fwd-cat: block attempts to use owned ports

2020-03-16 Thread Stephen Hemminger
If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/Makefile| 2 ++ examples/l2fwd-cat/

[dpdk-dev] [PATCH v2 6/6] examples/tep_termination: block attempts to use owned ports

2020-03-16 Thread Stephen Hemminger
If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/tep_termination/Makefile| 2 ++ examples/tep_

Re: [dpdk-dev] [PATCH] bus/pci: support iova=va on PowerNV systems

2020-03-16 Thread David Christensen
Bare metal PowerNV systems include a DPDK supported IOMMU that allows IOVA=VA support. Test for the platform type and report virtual address support if running on a PowerNV system. ... + + char *line = 0; Nit: NULL Fixed. + /* Check for a PowerNV platform */ + while (get

[dpdk-dev] [PATCH v2 5/6] examples/l3fwd-power: block attempts to use owned ports

2020-03-16 Thread Stephen Hemminger
If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of l3fwd. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 4 1 file changed, 4 insertio

[dpdk-dev] [PATCH v2 4/6] examples/l3fwd-acl: block attempts to use owned ports

2020-03-16 Thread Stephen Hemminger
If a ethdev port is in use for a sub device, then it should not be allowed in the portmask of application. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- examples/l3fwd-acl/Makefile| 3 +++ examples/l3fwd-acl

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

2020-03-16 Thread Stephen Hemminger
On Thu, 6 Jun 2019 12:15:50 + Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Matan Azrad > > Sent: Thursday, June 6, 2019 4:22 PM > > To: Jerin Jacob Kollanukkaran ; Adrien Mazarguil > > ; dev@dpdk.org > > Subject: [EXT] RE: [PATCH] [RFC] ethdev: support flow aging

Re: [dpdk-dev] [PATCH 1/2] crypto/qat: add aes-gcm J0 handling

2020-03-16 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, March 13, 2020 6:08 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH 1/2] crypto/qat: add aes-gcm J0 handling > > This patch adds J0 capability to Intel QuickAssi

Re: [dpdk-dev] [PATCH 2/2] test: add crypto aes-gcm J0 test case

2020-03-16 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, March 13, 2020 6:08 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH 2/2] test: add crypto aes-gcm J0 test case > > This patch adds crypto J0 test case to AES-GCM

Re: [dpdk-dev] [PATCH] testpmd: added rte_eth_dev_fw_version_get in testpmd rte_eth_dev_fw_version_get() was not called in test pmd. Added rte_eth_dev_fw_version_get() in testpmd under show port info

2020-03-16 Thread Ferruh Yigit
On 3/16/2020 10:07 AM, Muhammad Ahmad wrote: > From: Muhammad Ahmad > Hi Muhammed, Can you please keep the patch title short, ~70 chars, and put the detail in the commit log? > Bugzilla ID: 225 > > Cc: dev@dpdk.org > Reported-by: Thomas Monjalon > Signed-off-by: Muhammad Ahmad > --- > app/

[dpdk-dev] [PATCH] pci: fix missing off_t define on FreeBSD

2020-03-16 Thread Bruce Richardson
When removing the extra headers from rte_pci.h stdlib should have been removed instead of stdio, since off_t is missing for BSD builds when just including stdlib.h Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson ---

[dpdk-dev] [RFC PATCH] ci: reduce examples built for static builds

2020-03-16 Thread Bruce Richardson
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds. Signed-off-by: Bruce Richardson --- .ci/linux-build.sh | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index d500c4c00.

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value

2020-03-16 Thread Didier Pallard
Well, you're right, another way to fix the problem could be to set up the queue size assuming the provided number is a number of packets in queue rather than a number of mbufs in queue. But not sure it's better, it's also important for the application/user to know the number of mbufs that could fit

  1   2   >