16/03/2020 12:29, Bruce Richardson: > The rte_pci.h file includes more header files than are actually needed, > which means that all users of it also include those headers. This patch > removes the unneeded headers - adding them elsewhere where other components > were requiring them but not including them directly. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: gaetan.ri...@6wind.com > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> [...] > --- a/lib/librte_pci/rte_pci.h > +++ b/lib/librte_pci/rte_pci.h > -#include <stdio.h> > #include <stdlib.h> > #include <limits.h> > -#include <errno.h> > #include <sys/queue.h> > -#include <stdint.h> > #include <inttypes.h> > > -#include <rte_debug.h> > -#include <rte_interrupts.h>
Removing useless includes (or lines in general) is always good. Acked-by: Thomas Monjalon <tho...@monjalon.net> Applied, thanks