[dpdk-dev] [PATCH] net/bnxt: fix to handle default mac address setting when port is stopped

2020-02-27 Thread Kalesh A P
From: Kalesh AP Driver destroys the vnic when the port is brought down. Port hw filter setting such as default mac address and unicast mac filters will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Fixes: 39b88344e364 ("net/bnxt: fix

[dpdk-dev] [PATCH] eal: fix log message print for regex

2020-02-27 Thread Sunil Kumar Kori
If user passes log-level eal parameter to enable log level based on regex then in case of error message is being printed for pattern match instead of regex. Following is the warning message thrown: Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_options.c.o'. In function

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices

2020-02-27 Thread Sunil Kumar Kori
Hello All, Is there any thought on this ? Otherwise it can be merged. Regards Sunil Kumar Kori >-Original Message- >From: Sunil Kumar Kori >Sent: Thursday, January 23, 2020 2:13 PM >To: Stephen Hemminger ; Jerin Jacob >Kollanukkaran >Subject: FW: [dpdk-dev] [EXT] Re: [PATCH] bus/pci:

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-27 Thread Wang Xiang
Hi Ori, Look forward to your v4:). Thanks, Xiang On Thu, Feb 27, 2020 at 07:31:48AM +, Ori Kam wrote: > Hi Xiang, > > > -Original Message- > > From: Wang Xiang > > Sent: Thursday, February 27, 2020 11:26 AM > > To: Ori Kam > > Cc: Jerin Jacob ; Jerin Jacob ; > > dpdk-dev ; Pavan Ni

Re: [dpdk-dev] [PATCH v1] net/axgbe: add debug logs

2020-02-27 Thread Ferruh Yigit
On 2/16/2020 6:49 AM, Kumar, Ravi1 wrote: <...> >> -Original Message- >> From: Namburu, Chandu-babu >> Sent: Tuesday, February 11, 2020 1:50 PM >> To: dev@dpdk.org >> Cc: Kumar, Ravi1 ; Somalapuram, Amaranath >> >> Subject: [PATCH v1] net/axgbe: add debug logs >> >> From: Chandu Babu N

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-02-27 Thread Jerin Jacob
On Tue, Feb 25, 2020 at 7:11 PM Ananyev, Konstantin wrote: > We do have a run-time check in our current enqueue()/dequeue implementation. > In fact we support both modes: we have generic > rte_ring_enqueue(/dequeue)_bulk(/burst) > where sync behaviour is determined at runtime by value of prod(/c

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix log message print for regex

2020-02-27 Thread David Marchand
On Thu, Feb 27, 2020 at 9:25 AM Sunil Kumar Kori wrote: > > If user passes log-level eal parameter to enable log level based on regex > then in case of error message is being printed for pattern match instead of > regex. Following is the warning message thrown: > > Compiling C object > 'lib/76b5a

[dpdk-dev] [dpdk-announce] DPDK 17.11.10 (LTS) released

2020-02-27 Thread luca . boccassi
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-17.11.10.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=17.11 This is the last point release of the 17.11 LTS series, which is now EOL. Luca Boccassi --- MAINTAINERS

Re: [dpdk-dev] [PATCH] version: 20.05-rc0

2020-02-27 Thread David Marchand
On Wed, Feb 26, 2020 at 2:55 PM Thomas Monjalon wrote: > > 26/02/2020 14:38, David Marchand: > > Start a new release cycle with empty release notes. > > ABI must now be checked with v20.02 as a reference. > > > > Signed-off-by: David Marchand > > --- > > .travis.yml|

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] eal: fix log message print for regex

2020-02-27 Thread Sunil Kumar Kori
Hello David, We have two build machine with two different version of GCC. So the issue is reported on one setup only not on the other one. It looks like because of different version of GCC, this warning is caught. Regards Sunil Kumar Kori >-Original Message- >From: David Marchand >Sen

Re: [dpdk-dev] [dpdk-dev PATCH v1 1/1] net/octeontx2: update link information for loopback port

2020-02-27 Thread Jerin Jacob
On Thu, Feb 6, 2020 at 5:36 PM Ashish Gupta wrote: > > loopback devices are exposed as ethdev device in octeontx2. > dpdk link update APIs updating the link information for cgx > ports but skipping loopback ports. > > When stack uses loopback port for forwarding, packets are > dropped as link stat

Re: [dpdk-dev] [PATCH] version: 20.05-rc0

2020-02-27 Thread Bruce Richardson
On Wed, Feb 26, 2020 at 03:01:04PM +0100, David Marchand wrote: > On Wed, Feb 26, 2020 at 2:55 PM Thomas Monjalon wrote: > > > > 26/02/2020 14:38, David Marchand: > > > Start a new release cycle with empty release notes. > > > ABI must now be checked with v20.02 as a reference. > > > > > > Signed-

Re: [dpdk-dev] [PATCH] version: 20.05-rc0

2020-02-27 Thread David Marchand
On Thu, Feb 27, 2020 at 12:17 PM Bruce Richardson wrote: > > On Wed, Feb 26, 2020 at 03:01:04PM +0100, David Marchand wrote: > > On Wed, Feb 26, 2020 at 2:55 PM Thomas Monjalon wrote: > > > > > > 26/02/2020 14:38, David Marchand: > > > > Start a new release cycle with empty release notes. > > > >

Re: [dpdk-dev] [PATCH] version: 20.05-rc0

2020-02-27 Thread Thomas Monjalon
27/02/2020 12:23, David Marchand: > On Thu, Feb 27, 2020 at 12:17 PM Bruce Richardson > wrote: > > > > On Wed, Feb 26, 2020 at 03:01:04PM +0100, David Marchand wrote: > > > On Wed, Feb 26, 2020 at 2:55 PM Thomas Monjalon > > > wrote: > > > > > > > > 26/02/2020 14:38, David Marchand: > > > > > St

Re: [dpdk-dev] [PATCH] version: 20.05-rc0

2020-02-27 Thread David Marchand
On Thu, Feb 27, 2020 at 12:01 PM David Marchand wrote: > > On Wed, Feb 26, 2020 at 2:55 PM Thomas Monjalon wrote: > > > > 26/02/2020 14:38, David Marchand: > > > Start a new release cycle with empty release notes. > > > ABI must now be checked with v20.02 as a reference. > > > > > > Signed-off-by

Re: [dpdk-dev] [PATCH] net/thunderx: add link up and down ops

2020-02-27 Thread Jerin Jacob
On Wed, Feb 5, 2020 at 2:57 PM Harman Kalra wrote: > > Add support for .set_link_up/down() eth ops to bring > link up and down. > > Signed-off-by: Harman Kalra Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/thunderx/base/nicvf_mbox.c | 10 > d

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-27 Thread Akhil Goyal
> > Hi Lukasz, > > > > > > > Is it not possible to use the existing functions for finding routes, > > > checking > > packet types and checking security policies. > > > It will be very difficult to manage two separate functions for same work. > > > I > can > > see that the pkt->data_offs > > > A

[dpdk-dev] DPDK Release Status Meeting 27/02/2020

2020-02-27 Thread Ferruh Yigit
Minutes 27 February 2020 Agenda: * Release Dates * 20.02 Retrospective * Subtrees * OvS Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.02 is released on Tuesday, 25 February. * https://mails.dpdk.

[dpdk-dev] [PATCH v5 0/4] net/virtio: add link speed devarg

2020-02-27 Thread Ivan Dyukov
[PATCH v5 1/4] net/virtio: refactor devargs parsing [PATCH v5 2/4] net/virtio: add link speed devarg [PATCH v5 3/4] net/virtio-user: fix devargs parsing [PATCH v5 4/4] net/virtio-user: adding link speed devarg --- v5 changes: * fixed code style * fixed commit message and logging text v4 changes: *

[dpdk-dev] [PATCH v5 1/4] net/virtio: refactor devargs parsing

2020-02-27 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 34 +- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev

Re: [dpdk-dev] [PATCH 20.05] net/af_packet: support default mac address change

2020-02-27 Thread Ferruh Yigit
On 2/15/2020 7:20 PM, Stephen Hemminger wrote: > Since packet is talking to a network device (probably tap) > it is possible for the device driver to change the hardware address > by making an ioctl to kernel. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit Applied to dpdk-next-

[dpdk-dev] [PATCH v5 2/4] net/virtio: add link speed devarg

2020-02-27 Thread Ivan Dyukov
Some applications like pktgen use link speed to calculate transmission rate. It limits outcome traffic to hardcoded 10G. This patch adds speed devarg which allows to configure link speed of virtio device. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 7 +++ drivers/net/vi

[dpdk-dev] [PATCH v5 4/4] net/virtio-user: adding link speed devarg

2020-02-27 Thread Ivan Dyukov
virtio driver already parses speed devarg. virtio-user should add it to list of valid devargs and call eth_virtio_dev_init function which init speed value. eth_virtio_dev_init already is called from virtio_user_pmd_probe function. The only change is required to enable speed devargs: adding speed t

[dpdk-dev] [PATCH v5 3/4] net/virtio-user: fix devargs parsing

2020-02-27 Thread Ivan Dyukov
strtoull returns 0 if it fails to parse input string. It's ignored in get_integer_arg. This patch handles error cases for strtoull function. Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_user_ethdev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/d

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-02-27 Thread Ferruh Yigit
On 2/27/2020 6:33 AM, sseba...@amd.com wrote: > From: Selwin Sebastian > > Enable scattered rx support and add jumbo packet transmit capability > > Signed-off-by: Selwin Sebastian <...> > @@ -789,11 +789,17 @@ axgbe_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) >

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-27 Thread Lukas Bartosik
Hi Akhil, Please see my answer below. Thanks, Lukasz On 27.02.2020 13:07, Akhil Goyal wrote: >> >> Hi Lukasz, >> Is it not possible to use the existing functions for finding routes, checking >>> packet types and checking security policies. It will be very difficult to manage

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-02-27 Thread Sebastian, Selwin
[AMD Official Use Only - Internal Distribution Only] Hi Ferruh, For validation of scatter using the testpmd method mentioned in dpdk docs, we need to have these Tx offloads also enabled. Thanks and Regards Selwin Sebastian   -Original Message- From: Ferruh Yigit Sent: Thursda

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-02-27 Thread Ferruh Yigit
On 2/27/2020 2:35 PM, Sebastian, Selwin wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Ferruh, > For validation of scatter using the testpmd method mentioned in dpdk > docs, we need to have these Tx offloads also enabled. [Please don't top post, it makes conversatio

[dpdk-dev] [RFC v4] regexdev: introduce regexdev subsystem

2020-02-27 Thread Ori Kam
From: Jerin Jacob Even though there are some vendors which offer Regex HW offload, due to lack of standard API, It is diffcult for DPDK consumer to use them in a portable way. This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK. This RFC crafted based on SW Regex API framewor

Re: [dpdk-dev] [RFC v4] regexdev: introduce regexdev subsystem

2020-02-27 Thread Jerin Jacob
On Thu, Feb 27, 2020 at 8:11 PM Ori Kam wrote: > > From: Jerin Jacob > > Even though there are some vendors which offer Regex HW offload, due to > lack of standard API, It is diffcult for DPDK consumer to use them > in a portable way. > > This _RFC_ attempts to standardize the RegEx/DPI offload A

[dpdk-dev] [Bug 413] rte_ring: capacity was set uncorrectly

2020-02-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=413 Bug ID: 413 Summary: rte_ring: capacity was set uncorrectly Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [RFC v5] regexdev: introduce regexdev subsystem

2020-02-27 Thread Ori Kam
From: Jerin Jacob Even though there are some vendors which offer Regex HW offload, due to lack of standard API, It is diffcult for DPDK consumer to use them in a portable way. This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK. This RFC crafted based on SW Regex API framewor

Re: [dpdk-dev] Windows Draft Build

2020-02-27 Thread William Tu
> 3. Patch instruction is a bit involved: > > * Base on windpdk-v18.08-clang. > * Import drivers/net/virtio from v18.08 (not attached due to size). > * Apply windpdk-virtio-1.patch (attached). > * Apply multi-BAR patches (not attached due to not being mine). > * Apply windpdk-virtio-2.patch (attach

Re: [dpdk-dev] Windows Draft Build

2020-02-27 Thread David Marchand
On Thu, Feb 27, 2020 at 4:27 PM William Tu wrote: > > > 3. Patch instruction is a bit involved: > > > > * Base on windpdk-v18.08-clang. > > * Import drivers/net/virtio from v18.08 (not attached due to size). > > * Apply windpdk-virtio-1.patch (attached). > > * Apply multi-BAR patches (not attached

[dpdk-dev] net/netvsc: subchannel configuration failed due to unexpected NVS response

2020-02-27 Thread Min Tang
Hi Stephen: I saw the following error messages when using DPDK 18.11.2 in Azure: hn_nvs_execute(): unexpected NVS resp 0x6b, expect 0x85 hn_dev_configure(): subchannel configuration failed It was not easy to reproduce it and it only occurred with multiple queues enabled. In hn_nvs_execute it exp

[dpdk-dev] [PATCH v5 00/15] add eventmode to ipsec-secgw

2020-02-27 Thread Lukasz Bartosik
This series introduces event-mode additions to ipsec-secgw. With this series, ipsec-secgw would be able to run in eventmode. The worker thread (executing loop) would be receiving events and would be submitting it back to the eventdev after the processing. This way, multicore scaling and h/w assist

[dpdk-dev] [PATCH v5 02/15] examples/ipsec-secgw: add framework for eventmode helper

2020-02-27 Thread Lukasz Bartosik
From: Anoob Joseph Add framework for eventmode helper. Event mode involves initialization of multiple devices like eventdev, ethdev and etc. Add routines to initialize and uninitialize event device. Generate a default config for event device if it is not specified in the configuration. Currently

[dpdk-dev] [PATCH v5 03/15] examples/ipsec-secgw: add eventdev port-lcore link

2020-02-27 Thread Lukasz Bartosik
From: Anoob Joseph Add event device port-lcore link and specify which event queues should be connected to the event port. Generate a default config for event port-lcore links if it is not specified in the configuration. This routine will check the number of available ports and then create links a

[dpdk-dev] [PATCH v5 01/15] examples/ipsec-secgw: add default rte flow for inline Rx

2020-02-27 Thread Lukasz Bartosik
From: Ankur Dwivedi The default flow created would enable security processing on all ESP packets. If the default flow is created, SA based rte_flow creation would be skipped. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 61 +

[dpdk-dev] [PATCH v5 04/15] examples/ipsec-secgw: add Rx adapter support

2020-02-27 Thread Lukasz Bartosik
From: Anoob Joseph Add Rx adapter support. The event helper init routine will initialize the Rx adapter according to the configuration. If Rx adapter config is not present it will generate a default config. If there are enough event queues available it will map eth ports and event queues 1:1 (one

[dpdk-dev] [PATCH v5 06/15] examples/ipsec-secgw: add routines to display config

2020-02-27 Thread Lukasz Bartosik
From: Anoob Joseph Add routines to display the eventmode configuration and provide an overview of the devices used. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 207 examples/ipsec-secgw/event_helper.

[dpdk-dev] [PATCH v5 07/15] examples/ipsec-secgw: add routines to launch workers

2020-02-27 Thread Lukasz Bartosik
In eventmode workers can be drafted differently according to the capabilities of the underlying event device. The added functions will receive an array of such workers and probe the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- example

[dpdk-dev] [PATCH v5 05/15] examples/ipsec-secgw: add Tx adapter support

2020-02-27 Thread Lukasz Bartosik
From: Anoob Joseph Add Tx adapter support. The event helper init routine will initialize the Tx adapter according to the configuration. If Tx adapter config is not present it will generate a default config. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ev

[dpdk-dev] [PATCH v5 08/15] examples/ipsec-secgw: add support for internal ports

2020-02-27 Thread Lukasz Bartosik
Add support for Rx and Tx internal ports. When internal ports are available then a packet can be received from eth port and forwarded to event queue by HW without any software intervention. The same applies to Tx side where a packet sent to an event queue can by forwarded by HW to eth port without

[dpdk-dev] [PATCH v5 09/15] examples/ipsec-secgw: add event helper config init/uninit

2020-02-27 Thread Lukasz Bartosik
Add eventmode helper eh_conf_init and eh_conf_uninit functions which purpose is to initialize and unitialize eventmode helper configuration. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 103 examples/ip

[dpdk-dev] [PATCH v5 10/15] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-02-27 Thread Lukasz Bartosik
Add eventmode support to ipsec-secgw. With the aid of event helper configure and use the eventmode capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 3 + examples/ipsec-secgw/event_helper.h | 14 ++ examples/ipsec-secgw/ipsec-s

[dpdk-dev] [PATCH v5 13/15] examples/ipsec-secgw: make number of buffers dynamic

2020-02-27 Thread Lukasz Bartosik
Make number of buffers in a pool nb_mbuf_in_pool dependent on number of ports, cores and crypto queues. Add command line option -s which when used overrides dynamic calculation of number of buffers in a pool. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ip

[dpdk-dev] [PATCH v5 15/15] examples/ipsec-secgw: reserve crypto queues in event mode

2020-02-27 Thread Lukasz Bartosik
Reserve minimum number of crypto queues equal to number of ports. This is to fulfill inline protocol offload requirements. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec-secgw.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) dif

[dpdk-dev] [PATCH v5 12/15] examples/ipsec-secgw: add app mode worker

2020-02-27 Thread Lukasz Bartosik
Add application inbound/outbound worker thread and IPsec application processing code for event mode. Example ipsec-secgw command in app mode: ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=128 -w 0002:03:00.0,ipsec_in_max_spi=128 -w 0002:0e:00.0 -w 0002:10:00.1 --log-level=8 -c 0x1 -- -P -p 0x3 -u 0

[dpdk-dev] [PATCH v5 14/15] doc: add event mode support to ipsec-secgw

2020-02-27 Thread Lukasz Bartosik
Document addition of event mode support to ipsec-secgw application. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- doc/guides/sample_app_ug/ipsec_secgw.rst | 135 ++- 1 file changed, 113 insertions(+), 22 deletions(-) diff --git a/doc/guides/sample_a

[dpdk-dev] [PATCH v5 11/15] examples/ipsec-secgw: add driver mode worker

2020-02-27 Thread Lukasz Bartosik
Add driver inbound and outbound worker thread for ipsec-secgw. In driver mode application does as little as possible. It simply forwards packets back to port from which traffic was received instructing HW to apply inline security processing using first outbound SA configured for a given port. If a

Re: [dpdk-dev] [PATCH v1] net/axgbe: add register dump support

2020-02-27 Thread Ferruh Yigit
On 2/16/2020 6:47 AM, Kumar, Ravi1 wrote: <...> >> >> -Original Message- >> From: Namburu, Chandu-babu >> Sent: Tuesday, February 11, 2020 3:58 PM >> To: dev@dpdk.org >> Cc: Kumar, Ravi1 ; Somalapuram, Amaranath >> >> Subject: [PATCH v1] net/axgbe: add register dump support >> >> From:

Re: [dpdk-dev] [PATCH 1/2] net/memif: enable loopback

2020-02-27 Thread Ferruh Yigit
On 2/19/2020 8:18 AM, Július Milan wrote: > With this patch it is possible to connect 2 DPDK memifs into loopback, > i.e. when they have the same id and different roles, as for example: > "--vdev=net_memif0,role=master,id=0" > "--vdev=net_memif1,role=slave,id=0" > > Signed-off-by: Július Milan

Re: [dpdk-dev] Questions about rte_timer APIs

2020-02-27 Thread Honnappa Nagarahalli
Thanks Erik. We will create some patches and send them for review. > -Original Message- > From: Carrillo, Erik G > Sent: Wednesday, February 26, 2020 10:58 AM > To: Honnappa Nagarahalli ; Robert > Sanford > Cc: dev ; nd ; Phil Yang > ; Gavin Hu ; > david.march...@redhat.com; tho...@monja

Re: [dpdk-dev] [PATCH 1/2] net/memif: enable loopback

2020-02-27 Thread Ferruh Yigit
On 2/19/2020 8:18 AM, Július Milan wrote: > With this patch it is possible to connect 2 DPDK memifs into loopback, > i.e. when they have the same id and different roles, as for example: > "--vdev=net_memif0,role=master,id=0" > "--vdev=net_memif1,role=slave,id=0" > > Signed-off-by: Július Milan

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix MAC address when switching active port

2020-02-27 Thread Ferruh Yigit
On 2/25/2020 9:29 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > Currently, based on a active-backup bond device, when the link status of > the primary port changes from up to down, one slave port changes to the > primary port, but the new primary port's MAC address cannot change to the

[dpdk-dev] [PATCH] telemetry: fix struct reset after value assignment

2020-02-27 Thread Ciara Power
The ep struct is used to track what type of stats are required by the client. For PORT_STATS type, it contains the lists of port and metric ids to query, and the number of ids in each list. The ep struct has values set (num of port and metric ids) when a request for port stats values by name is re

Re: [dpdk-dev] [PATCH] af_packet: allow configuring number of rings

2020-02-27 Thread Ferruh Yigit
On 2/24/2020 11:11 PM, Stephen Hemminger wrote: > The maximum number of rings in af_packet is hard coded as 16. > The user should be able to configure this as part of DPDK config. > > Signed-off-by: Stephen Hemminger > --- > config/common_base| 1 + > drivers/net/af_packe

Re: [dpdk-dev] [PATCH] telemetry: fix struct reset after value assignment

2020-02-27 Thread Laatz, Kevin
> The ep struct is used to track what type of stats are required by the client. > For PORT_STATS type, it contains the lists of port and metric ids to query, > and > the number of ids in each list. > > The ep struct has values set (num of port and metric ids) when a request for > port stats value

Re: [dpdk-dev] [PATCH v2 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-02-27 Thread Cornelia Huck
On Wed, 19 Feb 2020 11:54:18 -0700 Alex Williamson wrote: > The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device > agnostic ioctl for setting, retrieving, and probing device features. > This implementation provides a 16-bit field for specifying a feature > index, where the data

Re: [dpdk-dev] net/netvsc: subchannel configuration failed due to unexpected NVS response

2020-02-27 Thread Stephen Hemminger
On Thu, 27 Feb 2020 11:16:01 -0500 Min Tang wrote: > Hi Stephen: > > I saw the following error messages when using DPDK 18.11.2 in Azure: > > hn_nvs_execute(): unexpected NVS resp 0x6b, expect 0x85 > hn_dev_configure(): subchannel configuration failed > > It was not easy to reproduce it and it

Re: [dpdk-dev] [PATCH v1 1/2] doc/failsafe: improve fail-safe documentation

2020-02-27 Thread Ferruh Yigit
On 2/22/2020 12:14 AM, Gaetan Rivet wrote: > Reading the fail-safe doc with a few years added, a few phrasing > choices are ambiguous or confusing. > > Signed-off-by: Gaetan Rivet cc'ed Marco & John for documentation (structure & language) perspective review.

Re: [dpdk-dev] [PATCH] af_packet: allow configuring number of rings

2020-02-27 Thread Stephen Hemminger
On Thu, 27 Feb 2020 17:20:45 + Ferruh Yigit wrote: > On 2/24/2020 11:11 PM, Stephen Hemminger wrote: > > The maximum number of rings in af_packet is hard coded as 16. > > The user should be able to configure this as part of DPDK config. > > > > Signed-off-by: Stephen Hemminger > > --- > >

Re: [dpdk-dev] [PATCH] af_packet: allow configuring number of rings

2020-02-27 Thread Ferruh Yigit
On 2/27/2020 5:51 PM, Stephen Hemminger wrote: > On Thu, 27 Feb 2020 17:20:45 + > Ferruh Yigit wrote: > >> On 2/24/2020 11:11 PM, Stephen Hemminger wrote: >>> The maximum number of rings in af_packet is hard coded as 16. >>> The user should be able to configure this as part of DPDK config. >>

Re: [dpdk-dev] net/netvsc: subchannel configuration failed due to unexpected NVS response

2020-02-27 Thread Min Tang
That quick fix was just to verify my guess. I agree that it needs more comprehensive fix. Yes, race condition is another issue here. In addition to that, I think in the function that sends the NVS_TYPE_RNDIS message, it needs to drain the response message. I looked at the netvsc driver in Linux ke

[dpdk-dev] [PATCH v2] net/af_packet: remove limitation on number of qpairs

2020-02-27 Thread Stephen Hemminger
Since qpairs is part of the vdev arguments, there is no need to limit it to 16. The queue arrays can be dynamically sized based on the requested parameters. Signed-off-by: Stephen Hemminger --- drivers/net/af_packet/rte_eth_af_packet.c | 23 +-- 1 file changed, 17 insertions(

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove limitation on number of qpairs

2020-02-27 Thread John W. Linville
On Thu, Feb 27, 2020 at 12:00:03PM -0800, Stephen Hemminger wrote: > Since qpairs is part of the vdev arguments, there is no need to > limit it to 16. The queue arrays can be dynamically sized based > on the requested parameters. > > Signed-off-by: Stephen Hemminger LGTM! Acked-by: John W. Linv

[dpdk-dev] [Bug 414] mlx5: test/debug_autotest failed when enable CONFIG_RTE_LIBRTE_MLX5_PMD=y

2020-02-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=414 Bug ID: 414 Summary: mlx5: test/debug_autotest failed when enable CONFIG_RTE_LIBRTE_MLX5_PMD=y Product: DPDK Version: 20.02 Hardware: POWER OS: Linux Sta

[dpdk-dev] [PATCH] drivers/crypto: fix build with make

2020-02-27 Thread Thomas Monjalon
In the check for the version of intel-ipsec-mb library, there is a backslash in front of the #include. It is not clear why this backslash is for. It is not clear why there was no error so far. In an up-to-date ArchLinux, these errors were seen: syntax error near unexpected token `|' `grep -e "IMB

Re: [dpdk-dev] [RFC 0/6] New sync modes for ring

2020-02-27 Thread David Christensen
On Tue, Feb 25, 2020 at 7:11 PM Ananyev, Konstantin wrote: We do have a run-time check in our current enqueue()/dequeue implementation. In fact we support both modes: we have generic rte_ring_enqueue(/dequeue)_bulk(/burst) where sync behaviour is determined at runtime by value of prod(/cons).s

Re: [dpdk-dev] [RFC 1/1] lib/ring: add scatter gather and serial dequeue APIs

2020-02-27 Thread Honnappa Nagarahalli
> > > Hi Honnappa, Thanks Konstantin for the comments. > > > Add scatter gather APIs to avoid intermediate memcpy. Serial dequeue > > APIs are added to support access to ring elements before actual > > dequeue. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > Reviewed

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix MAC address when switching active port

2020-02-27 Thread Wei Hu (Xavier)
Hi,Ferruh Yigit On 2020/2/28 1:03, Ferruh Yigit wrote: On 2/25/2020 9:29 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, based on a active-backup bond device, when the link status of the primary port changes from up to down, one slave port changes to the primary port, but the ne

[dpdk-dev] [PATCH] net/i40e: enable dst MAC address as FDIR input set

2020-02-27 Thread Lunyuan Cui
When OVS-DPDK is working as a pure L2 switch, Destination MAC match offload with Mark+RSS action would help the performance speed up. And FVL FDIR should support to change input set to be destination MAC. When create a FDIR rule which pattern only has ether dst_mac like below: flow create 0 ingres

[dpdk-dev] net/i40e: add promiscuous configure unsupported check

2020-02-27 Thread Xiao Zhang
Return ENOTSUP error code when configuring i40evf promiscuous mode to fix port start hang issue on platforms which are unsupported to configure promiscuous mode. Fixes: ddc7cb0d9453 ("net/i40e: re-program promiscuous mode on VF interface") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- drive

[dpdk-dev] [PATCH v2 0/2] no-huge test suite

2020-02-27 Thread Ruifeng Wang
For environments (such as containers) where hugetlbfs are not available, some unit tests can be run with 'no-huge' option. A suite is added. It includes cases that can run without hugetlbfs support. To avoid Travis CI job bloating, multiple test suites are allowed to run in one job. v2: Add a p

[dpdk-dev] [PATCH v2 1/2] ci: allow multiple test suites to run in one job

2020-02-27 Thread Ruifeng Wang
Run multiple test suites in a single Travis CI job helps to avoid job bloating and save build time. When RUN_TESTS is set, TEST_SUITES includes a list of suites that need to run in the job, otherwise fast-tests is run by default. Suggested-by: David Marchand Signed-off-by: Ruifeng Wang Reviewed

[dpdk-dev] [PATCH v2 2/2] ci: add test suite run without hugepage

2020-02-27 Thread Ruifeng Wang
This test suite is derived from fast-tests suite. Cases in this suite are run with '--no-huge' flag. The suite aims to cover as many as possible test cases out of the fast-tests suites in the environments without huge pages support, like containers. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin

[dpdk-dev] DSW eventdev bug?

2020-02-27 Thread Venky Venkatesh
Hi, This is concerning the DSW PMD for eventdev. In our application we put some debugs to see that the same ATOMIC flow isn't scheduled to 2 different cores. Strangely enough we hit it. Not sure if we are missing something OR it is a bug. We put some instrumentation code inside DSW and found the f

[dpdk-dev] [RFC PATCH 0/5] virtio-net support for Windows draft

2020-02-27 Thread Dmitry Kozlyuk
This patchset provides reference of the changes made to run virtio-net PMD with Windows draft DPDK, so that this could be reproduced. Is is not intended to be merged neither soon, nor "as is". Patches must be applied over "multi-BAR" patchset yet to be released by Microsoft, those patches are not

[dpdk-dev] [RFC PATCH 2/5] net: add stub for RARP packet generation on Windows

2020-02-27 Thread Dmitry Kozlyuk
RARP packets are optionally generated by virtio-net PMD. Signed-off-by: Dmitry Kozlyuk --- lib/librte_net/rte_net.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/librte_net/rte_net.c b/lib/librte_net/rte_net.c index 56a13e3c4..8391ceae7 100644 --- a/lib/librte_net/rte_net

[dpdk-dev] [RFC PATCH 3/5] pci/windows: split config I/O into series of fixed-size operations

2020-02-27 Thread Dmitry Kozlyuk
PCI bus kernel driver mandates accessing config space in a series of reads/writes by 4, 2, or 1 bytes. NETUIO driver checks this requirement before performing config space I/O. Users of DPDK PCI bus driver, however, access config space without regard for this requirement. Make DPDK PCI bus driver

[dpdk-dev] [RFC PATCH 1/5] pci/windows: add stubs for port IO

2020-02-27 Thread Dmitry Kozlyuk
NetUIO does not currently implement port I/O, which is used by some drivers, notable virtio-net in legacy mode. Signed-off-by: Dmitry Kozlyuk --- drivers/bus/pci/windows/pci.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/bus/pci/windows/pci.c b/dr

[dpdk-dev] [RFC PATCH 4/5] netuio: change class for Net to custom

2020-02-27 Thread Dmitry Kozlyuk
This resolves the issue with timeout on driver loading. Signed-off-by: Dmitry Kozlyuk --- drivers/bus/pci/windows/pci.c| 3 ++- kernel/windows/netuio/netuio.inf | 11 +-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/

[dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD

2020-02-27 Thread Dmitry Kozlyuk
Signed-off-by: Dmitry Kozlyuk --- drivers/net/virtio/virtio_ethdev.c| 4 + kernel/windows/netuio/netuio.inf | 6 + lib/librte_eal/windows/eal/eal.c | 4 + mk/exec-env/windows/dpdk.sln | 754 +- mk/exec-env/windows/l2fwd/