On 2/27/2020 2:35 PM, Sebastian, Selwin wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Ferruh, > For validation of scatter using the testpmd method mentioned in dpdk > docs, we need to have these Tx offloads also enabled.
[Please don't top post, it makes conversation hard to follow.] Can you point where there testpmd requirement in the code? Also these offloads should be enabled when HW/Driver supports it, not for it is required by testpmd. > > Thanks and Regards > Selwin Sebastian > > -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@intel.com> > Sent: Thursday, February 27, 2020 7:59 PM > To: Sebastian, Selwin <selwin.sebast...@amd.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx > > [CAUTION: External Email] > > On 2/27/2020 6:33 AM, sseba...@amd.com wrote: >> From: Selwin Sebastian <selwin.sebast...@amd.com> >> >> Enable scattered rx support and add jumbo packet transmit capability >> >> Signed-off-by: Selwin Sebastian <selwin.sebast...@amd.com> > > <...> > >> @@ -789,11 +789,17 @@ axgbe_dev_info_get(struct rte_eth_dev *dev, struct >> rte_eth_dev_info *dev_info) >> DEV_RX_OFFLOAD_IPV4_CKSUM | >> DEV_RX_OFFLOAD_UDP_CKSUM | >> DEV_RX_OFFLOAD_TCP_CKSUM | >> + DEV_RX_OFFLOAD_JUMBO_FRAME | >> + DEV_RX_OFFLOAD_SCATTER | >> DEV_RX_OFFLOAD_KEEP_CRC; >> >> dev_info->tx_offload_capa = >> DEV_TX_OFFLOAD_IPV4_CKSUM | >> DEV_TX_OFFLOAD_UDP_CKSUM | >> + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | >> + DEV_TX_OFFLOAD_UDP_TSO | >> + DEV_TX_OFFLOAD_SCTP_CKSUM | >> + DEV_TX_OFFLOAD_MULTI_SEGS | >> DEV_TX_OFFLOAD_TCP_CKSUM; > > Is the Tx offload capability update related to the this change? If it is not > can you please send these updates as a separate patch, and a send new version > of this patch without this bit? > > Thanks, > ferruh >
