Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-23 Thread Ori Kam
Hi Jerin, Thanks, for the review. PSB Ori Kam > -Original Message- > From: Jerin Jacob > Sent: Saturday, February 22, 2020 6:52 PM > To: Ori Kam > Cc: Jerin Jacob ; xiang.w.w...@intel.com; dpdk-dev > ; Pavan Nikhilesh ; Shahaf > Shuler ; Hemant Agrawal > ; Opher Reviv ; Alex > Rosenbau

[dpdk-dev] [PATCH] doc: update mlx5 encap/decap limitations

2020-02-23 Thread Raslan Darawsheh
Document validation limitations for encap/decap. Signed-off-by: Raslan Darawsheh Acked-by: Ori kam --- doc/guides/nics/mlx5.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index dd2fbde..7991da9 100644 --- a/doc/guides/nic

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-23 Thread Jerin Jacob
On Sun, Feb 23, 2020 at 2:12 PM Ori Kam wrote: > > Hi Jerin, > > Thanks, for the review. > PSB Hi Ori Since we are finalizing the specification part, I thought of enumerating the list of work needs to be completed for a new subsystem in DPDK. 0) Finalize the first version of the spec. Hope v4

[dpdk-dev] [PATCH v1] doc: update release notes for 20.02

2020-02-23 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 20.02 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_20_02.rst | 70 +++--- 1 file changed, 31 insertions(+), 39 deletions(-) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-23 Thread Ori Kam
Hi Jerin, Best, Ori > -Original Message- > From: Jerin Jacob > Sent: Sunday, February 23, 2020 11:54 AM > To: Ori Kam > Cc: Jerin Jacob ; xiang.w.w...@intel.com; dpdk-dev > ; Pavan Nikhilesh ; Shahaf > Shuler ; Hemant Agrawal > ; Opher Reviv ; Alex > Rosenbaum ; dov...@marvell.com; Prasu

Re: [dpdk-dev] [RFC 1/7] net/igc: base driver

2020-02-23 Thread Zhang, AlvinX
Hi Ferruh, I have add some new features to the module last few weeks, I'm going to resubmit all codes as you suggest. Thanks very much BR, Alvin > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 22, 2020 12:27 AM > To: Zhang, AlvinX ; Wang, Haiyue > ; Zhang, Qi Z ;

Re: [dpdk-dev] [RFC 3/7] drivers/net: add igc make

2020-02-23 Thread Zhang, AlvinX
Hi Ferruh, Thanks for your advice, I'm going to check whether all these libraries and flags are really required or not. BR, Alvin > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 22, 2020 12:44 AM > To: Zhang, AlvinX ; Wang, Haiyue > ; Zhang, Qi Z ; Xing, Beilei >

Re: [dpdk-dev] [PATCH v4 00/15] add eventmode to ipsec-secgw

2020-02-23 Thread Anoob Joseph
Hi Konstantin, Akhil, Do you have any further comments on this series? Regarding the config parameter change which was discussed in the last submission, we have deferred it and went back to Konstantin's suggestion of updating qp only for our case. Hope now you can Ack the series. Thanks, Anoob

[dpdk-dev] [Bug 406] ethtool doesn't compile if you installed with ninja rather than make

2020-02-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=406 Bug ID: 406 Summary: ethtool doesn't compile if you installed with ninja rather than make Product: DPDK Version: 19.11 Hardware: All OS: Linux Status: UN

Re: [dpdk-dev] [PATCH] doc: deprecate using MAX values as array size

2020-02-23 Thread Akhil Goyal
> > On 1/30/2020 2:20 PM, Ferruh Yigit wrote: > > Adding the deprecation notice as reminder for next ABI breakage release > > (20.11). > > This one time breakage is required to be able to extend enum/define > > without breaking ABI. > > > > Signed-off-by: Ferruh Yigit > > --- > > doc/guides/rel

[dpdk-dev] [RFC]app/testpmd: time-consuming question of mlockall function execution

2020-02-23 Thread humin (Q)
We found that if OS transparent hugepage uses non 'always', mlockall function in the main function of testpmd takes more than 25s to execute. The results of running on both x86 and ARM are the same. It's very unreasonable and deadly. The enable status of transparent hugepage on OS can be viewed

[dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-02-23 Thread Phil Yang
Volatile has no ordering semantics. The rte_timer structure defines timer status as a volatile variable and uses the rte_r/wmb barrier to guarantee inter-thread visibility. This patch optimized the volatile operation with c11 atomic operations and one-way barrier to save the performance penalty. A

[dpdk-dev] [PATCH 1/2] lib/timer: protect timer subsystem initialized with lock

2020-02-23 Thread Phil Yang
From: Honnappa Nagarahalli rte_timer_subsystem_initialized is a global variable that can be accessed by multiple processes simultaneously. Hence, any access to rte_timer_subsystem_initialized should be protected by rte_mcfg_timer_lock. Fixes: f9d6cd8bfe9e ("timer: fix resource leak in finalize")

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: deprecation notice to move igb_uio to a new repo

2020-02-23 Thread Maxime Coquelin
On 1/30/20 5:58 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Based on the tech board meeting held on 2019-11-06, > It's been decided to move igb_uio kernel module to a new repository > hosted by dpdk.org in v20.11 release. > > http://mails.dpdk.org/archives/dev/2019-November/151763.h

[dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid

2020-02-23 Thread Marvin Liu
zc mbufs should record available buffer id when doing dequeue zcopy. There's no guarantee that local queue avail index equal to buffer index. Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reported-by: Yinan Wang diff

Re: [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid

2020-02-23 Thread Maxime Coquelin
I would make the title a bit more generic, e.g.: vhost: fix packed ring zero-copy On 2/24/20 3:50 PM, Marvin Liu wrote: > zc mbufs should record available buffer id when doing dequeue zcopy. Available buffer ID should be stored in the mbuf in the packed-ring dequeue path. > There's no guarantee

Re: [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid

2020-02-23 Thread Ye Xiaolong
For the subject, what about: vhost: fix invalid zmbuf buffer id On 02/24, Marvin Liu wrote: >zc mbufs should record available buffer id when doing dequeue zcopy. >There's no guarantee that local queue avail index equal to buffer index. s/equal to/is equal to > >Fixes: d1eafb532268 ("vhost: add

[dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy

2020-02-23 Thread Marvin Liu
Available buffer ID should be stored in the zmbuf in the packed-ring dequeue path. There's no guarantee that local queue avail index is equal to buffer ID. Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reported-by: Yin

Re: [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid

2020-02-23 Thread Liu, Yong
Thanks, xiaolong & maxime. Commits log has been fixed in v2. > -Original Message- > From: Ye, Xiaolong > Sent: Monday, February 24, 2020 3:26 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; dev@dpdk.org; Bie, Tiwei > ; Wang, Zhihong ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PAT