Hi Ferruh, I have add some new features to the module last few weeks, I'm going to resubmit all codes as you suggest. Thanks very much
BR, Alvin > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 22, 2020 12:27 AM > To: Zhang, AlvinX <alvinx.zh...@intel.com>; Wang, Haiyue > <haiyue.w...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Xing, Beilei > <beilei.x...@intel.com>; Ye, Xiaolong <xiaolong...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 1/7] net/igc: base driver > > On 1/10/2020 3:00 AM, alvinx.zh...@intel.com wrote: > > From: Alvin Zhang <alvinx.zh...@intel.com> > > > > Add shared code source files to support basic operations to be called > > in poll mode driver. > > > > Signed-off-by: Alvin Zhang <alvinx.zh...@intel.com> > > Hi Alvin, > > I would suggest a different organization of the patches. > > Currently first patch dumps all shared code, second all the DPDK driver files. > Later patches does in each patch, Makefile based build system, meson based > build system and documentation. > > First question if all shared code are used, if not please drop the ones that > are > not used as much as possible. > > Second please try to split into the logical pieces, like a logical piece can > be > setting MTU (just a sample) and you can put shared code, dpdk code and > documentation related to it in same patch. > > Also can you please start the series with a skeleton, which introduces the > build system files, configs, Maintainer file update, generic docs. At this > stage > code can be empty, and the driver can be disabled by default. > And if you have to, second patch can have a minimum required shared code > drop. > After this the driver can be built gradually feature by feature, perhaps > starting from the probe/remove support. > > Thanks, > ferruh
