Re: [dpdk-dev] [PATCH v3] net/ice: use the copy API to do MAC assignment

Hi, haiyue On 01/03, Haiyue Wang wrote: >Use the API rte_ether_addr_copy to do MAC assignment, instead of >calling rte_memcpy function directly. Please add Fix tags and cc stable. Thanks, Xiaolong > >Signed-off-by: Haiyue Wang >--- >v3: Update the commit message > >v2: Update the commit title a

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Monday, January 13, 2020 11:22 AM > To: Sexton, Rory ; dev@dpdk.org; Zhang, Qi Z > ; adrien.mazarg...@6wind.com; or...@mellanox.com > Cc: Jagus, DariuszX > Subject: Re: [dpdk-dev] [PATCH v3

Re: [dpdk-dev] [PATCH v3] net/ice: use the copy API to do MAC assignment

> -Original Message- > From: Ye, Xiaolong > Sent: Monday, January 13, 2020 16:06 > To: Wang, Haiyue > Cc: dev@dpdk.org; step...@networkplumber.org; Zhang, Qi Z > ; Yang, Qiming > > Subject: Re: [PATCH v3] net/ice: use the copy API to do MAC assignment > > Hi, haiyue > > On 01/03, Haiy

[dpdk-dev] [PATCH v4] net/ice: use the copy API to do MAC assignment

Use the API rte_ether_addr_copy to do MAC assignment, instead of calling rte_memcpy function directly. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang Acked-by: Qiming Yang --- v4: update the fix tags v3: Update the commit message v2

Re: [dpdk-dev] [PATCH v4] net/ice: use the copy API to do MAC assignment

On 01/13, Haiyue Wang wrote: >Use the API rte_ether_addr_copy to do MAC assignment, instead of >calling rte_memcpy function directly. > >Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") >Cc: sta...@dpdk.org > >Signed-off-by: Haiyue Wang >Acked-by: Qiming Yang >--- >v4: update the fix

[dpdk-dev] [PATCH 1/2] app/testpmd: add dynamic flag support

DPDK now supports registration of dynamic flags (dynf) to the mbuf. dynf can be given any name, and can be used with a supporting PMD or supporting application. Due to the generic concept of the dynf, it is impossible and meaningless, to define register set/get function for each flag. This commit

[dpdk-dev] [PATCH 0/2] net/mlx5: add PMD dynf

This patch-set uses the dynf feature to give the mlx5 pmd hint if inline is needed. The first patch,adds a generic way to regiter dynf and setting it in case of Tx packet. Ori Kam (2): app/testpmd: add dynamic flag support net/mlx5: add fine grain dynamic flag support app/test-pmd/cmdline.c

[dpdk-dev] [PATCH 2/2] net/mlx5: add fine grain dynamic flag support

The inline feature is designed to save PCI bandwidth by copying some of the data to the wqe. This feature if enabled works for all packets. In some cases when using external memory, the PCI bandwidth is not relevant since the memory can be accessed by other means. This commit introduce the abilit

Re: [dpdk-dev] [PATCH] net/octeontx2: fix get supported ptype callback

On Thu, Dec 12, 2019 at 11:29 PM Harman Kalra wrote: > > Setting up supported ptypes using testpmd command is failing > because supported_ptypes_get callback will never return ptypes > supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags > is zero by default in testpmd. > > Fixes: d2706e15

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: set RSS based on device capabilities

On Mon, Dec 16, 2019 at 11:16 AM Jerin Jacob wrote: > > On Mon, Dec 16, 2019 at 11:07 AM wrote: > > > > From: Pavan Nikhilesh > > > > Setup RSS configuration based on underlying device capabilities. > > > > Signed-off-by: Satananda Burla > > Signed-off-by: Pavan Nikhilesh > > --- > > > Please

Re: [dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage

Hi, This series will be removed from next-net-mlx, will apply V3 instead. Kindest regards, Raslan Darawsheh > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, January 9, 2020 12:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH

Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: remove Tx descriptor reserved field usage

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, January 9, 2020 7:16 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v3 0/4] net/mlx5: remove Tx descriptor reserved field usage > > The current Tx datapath implementation in

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mempool: fix mempool obj alignment for non x86

On Mon, Jan 13, 2020 at 7:49 AM wrote: > > From: Jerin Jacob > > The existing optimize_object_size() function address the memory object > alignment constraint on x86 for better performance. > > Different (micro) architecture may have different memory alignment > constraint for better performance

[dpdk-dev] [PATCH v9 0/4] drivers/net: cleanup Tx buffers

Add support to the drivers inclulding i40e, ice, ixgbe and igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. --- v9: removed function pointer in ixgbe. changed function to static. v8: deleted function pointer by using other way. v7: changed the design of code,

[dpdk-dev] [PATCH v9 2/4] net/ice: cleanup Tx buffers

Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 111 +++ drivers/net/ice/ice_rxtx.h | 2 + 3 files ch

[dpdk-dev] [PATCH v9 1/4] net/i40e: cleanup Tx buffers

Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 107 ++

[dpdk-dev] [PATCH v9 4/4] net/e1000: cleanup Tx buffers

Add support to the igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe

[dpdk-dev] [PATCH v9 3/4] net/ixgbe: cleanup Tx buffers

Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 + drivers/net/ixgbe/ixgbe_rxtx.c | 109 +++ drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-

Re: [dpdk-dev] [PATCH] net/af_xdp: use single-prod-and-cons ring

> > The ring is used only by af_xdp pmd itself, so no need to support > multi-producer and multi-consumer mode. This patch changes the ring > to single-producer and single-consumer mode, which could yield better > performance for addr enqueue and dequeue. > > Signed-off-by: Xiao Wang LGTM. I r

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP

Hi Beilei, PSB Regards, Rory > > Sorry, NACK the patch since there's compilation issue with clang and coding > style issue. > Please check > http://mails.dpdk.org/archives/test-report/2020-January/112422.html and > http://mails.dpdk.org/archives/test-report/2020-January/112412.html > BTW, Do

[dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. Signed-off-by: Arek Kusztal Acked-by: Fiona Trahe --- v2: - moved release notes to 20.02 v3: - added algorithm strings doc/guides/cryptodevs/features/default.ini | 13 +++-- doc/guides/rel_notes/release_20_02.rst | 4 +

Re: [dpdk-dev] [RFC] DPDK Trace support

Hi Jerin, Any idea why lttng performance is so poor? I would have naturally gone there to benefit from the existing toolchain. Have you looked at the FD.io logging/tracing infrastructure for inspiration? https://wiki.fd.io/view/VPP/elog Ray K On 13/01/2020 10:40, Jerin Jacob Kollanukkaran wrote

Re: [dpdk-dev] [PATCH] lmp: add lookup x4 with x4 default values

Hi Pavan, I don't think it is a good idea to add extra function because: 1) it is just a copy of an existing rte_lpm_lookupx4() except the last 4 ternary ops 2) What is a real world use case for that? Usually returned value is used as an index in an array of next_hop structs. 3) You can ha

Re: [dpdk-dev] [PATCH v9 3/4] net/ixgbe: cleanup Tx buffers

> -Original Message- > From: dev On Behalf Of Chenxu Di > Sent: Monday, January 13, 2020 9:57 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > Subject: [dpdk-dev] [PATCH v9 3/4] net/ixgbe: cleanup Tx buffers > > Add support to the ixgbe driver for the API rte_eth_tx_done_clean

Re: [dpdk-dev] [PATCH v9 1/4] net/i40e: cleanup Tx buffers

> -Original Message- > From: dev On Behalf Of Chenxu Di > Sent: Monday, January 13, 2020 9:57 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > Subject: [dpdk-dev] [PATCH v9 1/4] net/i40e: cleanup Tx buffers > > Add support to the i40e driver for the API rte_eth_tx_done_cleanup

Re: [dpdk-dev] [PATCH v9 4/4] net/e1000: cleanup Tx buffers

> > Add support to the igb vf for the API rte_eth_tx_done_cleanup > to force free consumed buffers on Tx ring. > > Signed-off-by: Chenxu Di > --- > drivers/net/e1000/igb_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_et

Re: [dpdk-dev] [PATCH v3 0/7] remove 'typedef int bool'

On 1/10/2020 8:51 PM, Dharmik Thakkar wrote: > Replace 'typedef int bool' with 'stdbool.h' > Thus, avoid future compilation problems when 'stdbool.h' > gets included in these files. > > --- > v3: > - Rebase on dpdk-next-net > - Fix build issue in net/ixgbe > --- > v2: > - Remove 'typedef int bool'

Re: [dpdk-dev] [PATCH 01/14] examples/ipsec-secgw: add default rte_flow for inline Rx

> > >>> > > >>> Signed-off-by: Ankur Dwivedi > > >>> Signed-off-by: Anoob Joseph > > >>> --- > > >>> examples/ipsec-secgw/ipsec-secgw.c | 56 > > >> ++ > > >>> examples/ipsec-secgw/ipsec.c | 8 ++ > > >>> examples/ipsec-secgw/ipsec.h | 6 ++

[dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless PMDs

The three Intel SW Crypto PMDs supporting SNOW3G, ZUC and KASUMI link against libSSO libraries. The Intel IPSec Multi-buffer library recently integrated the code from these libraries, in version v0.53. This library can be downloaded from https://github.com/intel/intel-ipsec-mb. KASUMI, SNOW3G an

[dpdk-dev] [PATCH v2 1/3] crypto/zuc: use IPSec library

Link against Intel IPSec Multi-buffer library, which added support for ZUC-EEA3 and ZUC-EIA3 from version v0.53, moving from libSSO ZUC library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 6 ++-- doc/guides/cryptodevs/zuc.rst | 52

[dpdk-dev] [PATCH v2 2/3] crypto/kasumi: use IPSec library

Link against Intel IPSec Multi-buffer library, which added support for KASUMI-F8 and KASUMI-F9 from version v0.53, moving from libSSO KASUMI library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 6 +-- doc/guides/cryptodevs/kasumi.rst | 62

[dpdk-dev] [PATCH v2 3/3] crypto/snow3g: use IPSec library

Link against Intel IPSec Multi-buffer library, which added support for SNOW3G-UEA2 and SNOW3G-UIA2 from version v0.53, moving from libSSO SNOW3G library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 4 +- doc/guides/cryptodevs/snow3g.rst | 58 +

[dpdk-dev] [RFC] DPDK Trace support

Hi All, I would like to add tracing support for DPDK. I am planning to add this support in v20.05 release. This RFC attempts to get feedback from the community on a) Tracing Use cases. b) Tracing Requirements. b) Implementation choices. c) Trace format. Use-cases - - Most of the cases,

Re: [dpdk-dev] [PATCH v4 33/36] net/i40e/base: introduce firmware EMP reset register offsets

ACK -Original Message- From: Ye, Xiaolong Sent: Monday, January 13, 2020 3:40 AM To: Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Ye, Xiaolong ; Kwapulinski, Piotr Subject: [PATCH v4 33/36] net/i40e/base: introduce firmware EMP reset register offsets Introduce offsets of firmware re

Re: [dpdk-dev] [PATCH v4 24/36] net/i40e/base: make i40e_set_mac_type() public

ACK -Original Message- From: Ye, Xiaolong Sent: Monday, January 13, 2020 3:40 AM To: Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Ye, Xiaolong ; Kwapulinski, Piotr Subject: [PATCH v4 24/36] net/i40e/base: make i40e_set_mac_type() public Make i40e_set_mac_type() public. i40e driver re

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v3] mempool: fix mempool obj alignment for non x86

> -Original Message- > From: David Marchand > Sent: Monday, January 13, 2020 3:17 PM > To: Jerin Jacob Kollanukkaran > Cc: dev ; Thomas Monjalon ; Olivier > Matz ; Andrew Rybchenko > ; Bruce Richardson > ; Ananyev, Konstantin > ; Hemant Agrawal > ; Shahaf Shuler ; > Honnappa Nagarahalli ;

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

> > > > > > > > > > > > > + > > > > > > > > > > > > +static __rte_always_inline void > > > > > > > > > > > > +enqueue_elems_128(struct rte_ring *r, uint32_t > > > > > > > > > > > > +prod_head, const void *obj_table, uint32_t n) { > > > > > > > > > > > > +unsigned int i; const uint32_t size = >

[dpdk-dev] [PATCH v4 2/3] net/i40e: support FDIR for L2TPv3 over IP

Adding FDIR support for L2TPv3 over IP header matching and adding a new customized pctype for l2tpv3 over IP. Signed-off-by: Rory Sexton Signed-off-by: Dariusz Jagus --- v3 changes: * removing testpmd doc update as this patch focus only on i40e PMD * remove unused structure from i40e_ethdev.h v

[dpdk-dev] [PATCH v4 1/3] ethdev: add L2TPv3 over IP header to flow API

This patch adds the new flow item RTE_FLOW_ITEM_TYPE_L2TPV3OIP to flow API to match a L2TPv3 over IP header. This patch supports only L2TPv3 over IP header format which is different to L2TPv2/L2TPv3 over UDP. The difference in header formats between L2TPv3 over IP and L2TP over UDP require a separa

[dpdk-dev] [PATCH v4 3/3] doc: add release notes for L2TPv3 over IP flow addition

Release note for L2TPv3 over IP flow addition to rte_flow, net/i40e and testpmd. Signed-off-by: Rory Sexton --- v4 changes: adding release notes update to patchset --- --- doc/guides/rel_notes/release_20_02.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/rel_no

Re: [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows

Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 2:01 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 5/9] net/i40e: process ESP flows >

Re: [dpdk-dev] [PATCH v3 00/11] example/l3fwd: introduce event device support

Series Acked-by: Nipun Gupta > -Original Message- > From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Saturday, January 11, 2020 7:17 PM > To: jer...@marvell.com; konstantin.anan...@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 00/11] example/l3fw

Re: [dpdk-dev] [EXT] Re: [RFC] DPDK Trace support

> -Original Message- > From: Ray Kinsella > Sent: Monday, January 13, 2020 4:30 PM > To: Jerin Jacob Kollanukkaran ; dpdk-dev > ; d...@barachs.net > Subject: [EXT] Re: [RFC] [dpdk-dev] DPDK Trace support > > External Email > > -

[dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format

Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format. Signed-off-by: Yunjian Wang --- drivers/net/e1000/em_ethdev.c | 2 +- drivers/net/e1000/igb_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c

Re: [dpdk-dev] [PATCH] lmp: add lookup x4 with x4 default values

>-Original Message- >From: dev On Behalf Of Medvedkin, >Vladimir >Sent: Monday, January 13, 2020 4:37 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Bruce Richardson >; Gavin Hu >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] lmp: add lookup x4 with x4 default >valu

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for EC Point Multiplication

> > From: Balakrishna Bhamidipati > > Elliptic Curve Point Multiplication xform type and op > parameters are added. Description should convey that it is an asymmetric crypto feature. > > Signed-off-by: Anoob Joseph > Signed-off-by: Balakrishna Bhamidipati > Signed-off-by: Sunila Sahu Ti

Re: [dpdk-dev] [PATCH v2 1/3] crypto/zuc: use IPSec library

On Mon, Jan 13, 2020 at 11:40:23AM +, Pablo de Lara wrote: > Link against Intel IPSec Multi-buffer library, which > added support for ZUC-EEA3 and ZUC-EIA3 from version v0.53, > moving from libSSO ZUC library. > > Signed-off-by: Pablo de Lara > --- > devtools/test-build.sh |

Re: [dpdk-dev] [PATCH v2 1/3] crypto/zuc: use IPSec library

On Mon, Jan 13, 2020 at 12:45:14PM +, Bruce Richardson wrote: > On Mon, Jan 13, 2020 at 11:40:23AM +, Pablo de Lara wrote: > > Link against Intel IPSec Multi-buffer library, which > > added support for ZUC-EEA3 and ZUC-EIA3 from version v0.53, > > moving from libSSO ZUC library. > > > > Si

[dpdk-dev] 17.11.10 (LTS) patches review and test

Hi all, Here is a list of patches targeted for LTS release 17.11.10. This will be the last 17.11 release. The planned date for the final release is the 30th of January. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the fi

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

Hi Anoob, Could you please send the updated patch with the changes suggested? We need to merge it by Wednesday(15th Jan). Thanks, Akhil

[dpdk-dev] [PATCH v3 1/5] ipsec: move ipsec sad name length into .h

Move IPSEC_SAD_NAMESIZE into public header and rename it to RTE_IPSEC_SAD_NAMESIZE Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/ipsec_sad.c | 20 ++-- lib/librte_ipsec/rte_ipsec_sad.h | 2 ++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/libr

[dpdk-dev] [PATCH v3 3/5] examples/ipsec-secgw: integrate inbound SAD

Integrate ipsec SAD support into secgw app: 1. Use SAD library for inbound SA lookup 2. Changes in struct sa_ctx: - sa array allocates dynamically depending on number of configured sa - All SA's are kept one by one without using SPI2IDX 3. SP's userdata now contain index of SA in sa_ctx instea

[dpdk-dev] [PATCH v3 4/5] examples/ipsec-secgw: get rid of maximum sa limitation

Get rid of maximum SA limitation. Keep parsed SA's into the sorted by SPI value array. Use binary search in the sorted SA array to find appropriate SA for a given SPI. Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec.h | 1 - examples/ipsec-secgw/parser.c | 2 ++ examples/ipse

[dpdk-dev] [PATCH v3 0/5] integrate librte_ipsec SAD into ipsec-secgw

This series integrates SA database (SAD) capabilities from ipsec library. The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. Also patch series removes hardcoded limitation for maximum number of SA's and SP's. v3: - parse SA and SP into sorted array instead of linked list v2: -

[dpdk-dev] [PATCH v3 2/5] examples/ipsec-secgw: implement inbound SAD

Add initial support for librte_ipsec SAD library Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec.h | 11 ++ examples/ipsec-secgw/sad.c | 94 examples/ipsec-secgw/sad.h | 74 ++ 3 files changed,

[dpdk-dev] [PATCH v3 5/5] examples/ipsec-secgw: get rid of maximum sp limitation

Get rid of maximum SP limitation. Keep parsed SP's into the sorted by SPI value array. Use binary search in the sorted SP array to find appropriate SP for a given SPI. Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/parser.c | 2 + examples/ipsec-secgw/parser.h | 6 +++ examples/ips

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 10:40:13AM +, Jerin Jacob Kollanukkaran wrote: > Hi All, > > I would like to add tracing support for DPDK. > I am planning to add this support in v20.05 release. > > This RFC attempts to get feedback from the community on > > a) Tracing Use cases. > b) Tracing Require

[dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format

Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format. Signed-off-by: Yunjian Wang --- drivers/net/nfp/nfp_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 3aafa7f80..64d9d218d 100644 --- a/drivers/n

Re: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless PMDs

Hi, > -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Monday, January 13, 2020 1:40 PM > To: akhil.go...@nxp.com; declan.dohe...@intel.com > Cc: dev@dpdk.org; Pablo de Lara > Subject: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless > PMDs > > The three

[dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type

The doorbell register is mapped using mmap() and offset must have off_t instead of unsigned int. Bug is not critical due to only least significant bits of offset are currently tested to determine mapping mode. Fixes: 8409a28573d3 ("net/mlx5: control transmit doorbell register mapping") Cc: sta...@

Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type

From: Viacheslav Ovsiienko > The doorbell register is mapped using mmap() and offset must have off_t > instead of unsigned int. Bug is not critical due to only least significant > bits of > offset are currently tested to determine mapping mode. > > Fixes: 8409a28573d3 ("net/mlx5: control trans

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 6:36 PM Bruce Richardson wrote: > > > > So, Probably it good to have native CTF emitter in DPDK and reuse all > > open-source trace viewer(babeltrace and TraceCompass) and format(CTF) > > infrastructure. > > I think, it would be best of both world. > > > > Any thoughts on

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 08:16:07PM +0530, Jerin Jacob wrote: > On Mon, Jan 13, 2020 at 6:36 PM Bruce Richardson > wrote: > > > > > > > So, Probably it good to have native CTF emitter in DPDK and reuse all > > > open-source trace viewer(babeltrace and TraceCompass) and format(CTF) > > > infrastru

Re: [dpdk-dev] [PATCH v4] net/virtio: packed ring notification data feature support

On 1/13/20 4:31 AM, Cheng Jiang wrote: > This patch supports the feature that the driver passes extra data > (besides identifying the virtqueue) in its device notifications, > expanding the notifications to include the avail index and avail > wrap counter. > > Signed-off-by: Cheng Jiang > ---

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 8:28 PM Bruce Richardson wrote: > > On Mon, Jan 13, 2020 at 08:16:07PM +0530, Jerin Jacob wrote: > > On Mon, Jan 13, 2020 at 6:36 PM Bruce Richardson > > wrote: > > > > > > > > > > So, Probably it good to have native CTF emitter in DPDK and reuse all > > > > open-source tr

Re: [dpdk-dev] [PATCH] test/compress: add cycle-count mode to the perf tool

> -Original Message- > From: Trybula, ArturX > Sent: Wednesday, December 11, 2019 3:50 PM > To: dev@dpdk.org; Trahe, Fiona ; shal...@marvell.com; > Dybkowski, AdamX > ; Danilewicz, MarcinX > ; Trybula, > ArturX ; akhil.go...@nxp.com > Subject: [PATCH] test/compress: add cycle-count mo

Re: [dpdk-dev] [RFC] DPDK Trace support

On Mon, Jan 13, 2020 at 08:43:01PM +0530, Jerin Jacob wrote: > On Mon, Jan 13, 2020 at 8:28 PM Bruce Richardson > wrote: > > > > On Mon, Jan 13, 2020 at 08:16:07PM +0530, Jerin Jacob wrote: > > > On Mon, Jan 13, 2020 at 6:36 PM Bruce Richardson > > > wrote: > > > > > > > > > > > > > So, Probably

Re: [dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA

Hi Akhil, Do you suggest any change for the title here? As in, should I make it, cryptodev: support ECDSA @Arek, please see inline for responses. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, January 9, 2020 6:34 PM > To: Anoob Joseph ; Akhil Goyal ;

Re: [dpdk-dev] [PATCH] ethdev: rte_eth_dev_callback_unregister() fails with cb_arg == -1

On 1/7/2020 3:51 PM, Ricardo Roldan wrote: > The function was checking -1 against the callback data instead of > the given cb_arg parameter. > > Signed-off-by: Ricardo Roldan Updated title as: ethdev: fix callback unregister with wildcard argument list Also adding following metadata to the

Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf with pinned external buffer

Hi, Stephen Thanks a lot for the comment. > -Original Message- > From: Stephen Hemminger > Sent: Friday, January 10, 2020 20:24 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > > Subject: Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf

Re: [dpdk-dev] [PATCH v2] net/axgbe: add a HW quirk for register definitions

On 1/9/2020 12:39 PM, Selwin Sebastian wrote: > V1000/R1000 processors are using the same PCI ids for the network > device as SNOWYOWL processor but has altered register definitions > for determining the window settings for the indirect PCS access. > Add support to check for this hardware and if fo

[dpdk-dev] [PATCH v8 2/6] lib/ring: apis to support configurable element size

Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

[dpdk-dev] [PATCH v8 1/6] test/ring: use division for cycle count calculation

Use division instead of modulo operation to calculate more accurate cycle count. Signed-off-by: Honnappa Nagarahalli Acked-by: Olivier Matz --- app/test/test_ring_perf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test/test_ring_perf.c b/app/

[dpdk-dev] [PATCH v8 0/6] lib/ring: APIs to support custom element size

The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

[dpdk-dev] [PATCH v8 3/6] test/ring: add functional tests for rte_ring_xxx_elem APIs

Add basic infrastructure to test rte_ring_xxx_elem APIs. Adjust the existing test cases to test for various ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 1244 ++ app/test/test_ring.h | 187 +

[dpdk-dev] [PATCH v8 5/6] lib/hash: use ring with 32b element size to save memory

The freelist and external bucket indices are 32b. Using rings that use 32b element sizes will save memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_hash/rte_cuckoo_hash.c | 97 --- lib/librte_hash/rte_cuckoo

[dpdk-dev] [PATCH v8 4/6] test/ring: modify perf test cases to use rte_ring_xxx_elem APIs

Adjust the performance test cases to test rte_ring_xxx_elem APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 454 +++--- 1 file changed, 273 insertions(+), 181 deletions(-) diff --git a/app/test/test_ring_perf.c b/a

[dpdk-dev] [PATCH v8 6/6] lib/eventdev: use custom element size ring for event rings

Use custom element size ring APIs to replace event ring implementation. This avoids code duplication. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_eventdev/rte_event_ring.c | 147 ++- lib/librte_eventdev/rte_event_r

Re: [dpdk-dev] [PATCH] lmp: add lookup x4 with x4 default values

Hi, On 13/01/2020 12:34, Pavan Nikhilesh Bhagavatula wrote: -Original Message- From: dev On Behalf Of Medvedkin, Vladimir Sent: Monday, January 13, 2020 4:37 PM To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob Kollanukkaran ; Bruce Richardson ; Gavin Hu Cc: dev@dpdk.org Subject: Re: [dpdk

[dpdk-dev] [PATCH RFC V2 0/2] TCP flow classification using 4-tuple and flags

V2 updates: checkpatch fixes, revert accidently spelling error introduced in V1; The problem space of TCP flow tracking and classification based on TCP state requires the ability to classify TCP flows on more packet properties than just the 4-tuple, e.g., TCP flags. This patch-set investigates the

[dpdk-dev] [PATCH RFC V2 1/2] Hooks to allow the setting of filters on tcp flags

The rte_eth_ntuple_filter allows tcp_flags which can check for things like #define RTE_TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */ #define RTE_TCP_ECE_FLAG 0x40 /**< ECN-Echo */ #define RTE_TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */ #define RTE_TCP_ACK_FLAG

[dpdk-dev] [PATCH RFC V2 2/2] Allow the flow_classify example to add an ACL table for tcp.

The struct rte_flow_classifier can have upto RTE_FLOW_CLASSIFY_TABLE_MAX (32) classifier tables, but the existing flow_classify examples only adds a single table for the L4 5-tuple. When dealing with tcp flows, we frequently want to add add ACLs and filters to filter based on the state of the TC

[dpdk-dev] patches not showing up on list?

I just sent a couple of (RFC) patches to dev@dpdk.org and they are showing up in the patch queue, but not on the list, is there something wrong with my mail headers? How can I debug this? Patches I am referring to are: https://patchwork.dpdk.org/patch/64574/ https://patchwork.dpdk.org/patch/64

[dpdk-dev] [PATCH 2/2] net/netvsc: eliminate numa specific allocation for control messages

The control messages do not need NUMA specific allocation. Numa node is not set anyway in most kernels anyway. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rndis.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/netvsc/hn_rndis.c b/driver

[dpdk-dev] [PATCH 1/2] net/netvsc: fix crash in secondary process

The secondary process would crash trying to get the offload capability of the device. Since the device capabilities were already set by the primary process this was unnecessary. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH 0/2] net/netvsc: fix secondary process issues

First patch is a bug fix for crash in info_get in secondary process. Second one is modification to prevent similar issues in future. Stephen Hemminger (2): net/netvsc: fix crash in secondary process net/netvsc: eliminate numa specific allocation for control messages drivers/net/netvsc/hn_eth

[dpdk-dev] [PATCH] maintainers: update for Windows

Since Anand is no longer with Intel, Pallavi will replace him as maintainer. Signed-off-by: Ranjit Menon --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4395d8df1..f6c35cf77 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -318,7 +

[dpdk-dev] net/cxgbe: DEV_TX_OFFLOAD_MULTI_SEGS support?

It looks like the cxgbe driver doesn't set the DEV_TX_OFFLOAD_MULTI_SEGS offload capability. However, it looks like sge.c does have support for sending mbuf chains, e.g. write_sgl(). Is this just an oversight or is there something fundamentally broken here?

[dpdk-dev] [PATCH v5 0/9] Windows patchset with additional EAL functionalities

This patchset includes additional functionalities for Windows EAL to support command-line parsing feature and some EAL common code on Windows. This patchset can be applied to windpdk-next-dev branch in the draft repo. v5 changes: Fixed indentation in patch 6. v4 changes: Modified

[dpdk-dev] [PATCH v5 2/9] eal: dirent.h implementation for windows

Adding dirent.h on Windows to support common code. eal_common_options.c includes this file. The original contribution is under MIT license. https://github.com/tronkko/dirent Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles ---

[dpdk-dev] [PATCH v5 1/9] license: add license exception for windows

The Governing Board and Tech Board have provided exceptions for MIT and BSD-2-Clause license files for DPDK support on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- license/exceptions.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lice

[dpdk-dev] [PATCH v5 5/9] eal: getopt implementation for windows

Adding getopt files to support parsing option on Windows. The original contribution is under BSD-2 license. https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.c https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.h Signed-off-by: Antara Ganesh Kola

[dpdk-dev] [PATCH v5 3/9] eal: add windows compatible header files

Modified \common\include\arch\x86\rte_vect.h to include SSE4 header for Windows. Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support functions and path defines for files and directories on Windows. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v5 4/9] eal: add additional function overrides in windows header files

Adding additional function definitions for pthread, cpuset implementation, asprintf implementation, in order to support common code. Signed-off-by: Bruce Richardson Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/include/pthread.h

[dpdk-dev] [PATCH v5 7/9] eal: remove syslog support for windows

Added #ifndef WIN64 to exclude syslog definitions and parameters from Windows builds. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/common/eal_common_options.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_

[dpdk-dev] [PATCH v5 9/9] eal: add minimum viable code to support parsing

Adding specific logic for eal.c to support parsing on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c | 133 ++- 1 file changed, 130 insertions(+), 3 de

[dpdk-dev] [PATCH v5 8/9] build: add additional common files support

Added support for additional common files in meson build to expand Windows EAL and to support the lcore parsing feature on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/meson.build | 8

[dpdk-dev] [PATCH v5 6/9] eal: add function to detect process type

Adding a function to detect process type, also included header files to contain suitable function declarations and to support extra warning flags. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/

Re: [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table

09/01/2020 12:00, Matan Azrad: > +Useful links > + > + > + * `OASIS: Virtual I/O Device (VIRTIO) Version 1.1 > `_. > + * `QEMU: Vhost-user Protocol > `_. .ht

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

09/01/2020 12:00, Matan Azrad: > --- a/drivers/vdpa/Makefile > +++ b/drivers/vdpa/Makefile > +ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > +ifeq ($(CONFIG_RTE_EAL_VFIO),y) > +DIRS-$(CONFIG_RTE_LIBRTE_IFC_PMD) += ifc > +endif > +endif # $(CONFIG_RTE_LIBRTE_VHOST) All vDPA drivers will need vhost lib. As i

  1   2   >