Re: [dpdk-dev] [PATCH v4 0/6] OCTEON TX2 End Point Driver

2020-01-08 Thread Gavin Hu
Hi Mahipal, Please cc me in your future optimization patches. Series-reviewed-by: Gavin Hu > -Original Message- > From: Mahipal Challa > Sent: Wednesday, January 8, 2020 3:32 PM > To: dev@dpdk.org; tho...@monjalon.net; jer...@marvell.com; Gavin Hu > > Cc: jer...@marvell.com; Narayan

Re: [dpdk-dev] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, December 20, 2019 12:48 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set > > The tx_burst routine supporting

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread David Marchand
Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: > > In current led control API we have no way to know if a device is able > to handle on/off requests coming from the application. > Knowing if the device is led control capable could be useful to a

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata item endianness conversion

2020-01-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, December 24, 2019 4:21 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix metadata item endianness conversion > > The metadata register c0 field

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 8:56 AM, David Marchand wrote: > Hello Laurent, > > Bonne année. > > Cc: maintainers. > > On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: >> >> In current led control API we have no way to know if a device is able >> to handle on/off requests coming from the application. >> Know

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2020-01-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Tonghao Zhang > Sent: Tuesday, January 7, 2020 8:39 AM > To: Suanming Mou > Cc: Matan Azrad ; Shahaf Shuler > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action > conf is NULL > > On Mon, Dec 16,

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Olivier Matz
On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: > On 1/8/2020 8:56 AM, David Marchand wrote: > > Hello Laurent, > > > > Bonne année. > > > > Cc: maintainers. > > > > On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy > > wrote: > >> > >> In current led control API we have no way to kno

Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit

2020-01-08 Thread Iremonger, Bernard
Hi Stephen, > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Tuesday, January 7, 2020 7:00 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit > > The rte_eal_cleanup code is not exercised by testpmd which i

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread David Marchand
On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: > > On 1/8/2020 8:56 AM, David Marchand wrote: > > Hello Laurent, > > > > Bonne année. > > > > Cc: maintainers. > > > > On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy > > wrote: > >> > >> In current led control API we have no way to know if a dev

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

2020-01-08 Thread Ananyev, Konstantin
> > > > > > > > > + > > > > > > > > +static __rte_always_inline void enqueue_elems_128(struct > > > > > > > > +rte_ring *r, uint32_t prod_head, const void *obj_table, > > > > > > > > +uint32_t n) { unsigned int i; const uint32_t size = > > > > > > > > +r->size; uint32_t idx = prod_head & r->mas

[dpdk-dev] [PATCH] maintainers: resign from flow API maintenance

2020-01-08 Thread Adrien Mazarguil
Unfortunately due to lack of time, I've been unable to even participate to flow API discussions for several months. Better make it official since this is not going to improve anytime soon. This doesn't mean I won't contribute to rte_flow in the future! Cc: sta...@dpdk.org Signed-off-by: Adrien M

Re: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers

2020-01-08 Thread Di, ChenxuX
Hi, Konstantin Thanks for your read. for our research, we don't think it is a good plan that reuse ixgbe_xmit_cleanup() or ixgbe_tx_free_bufs. following two opinion will show the reason. first, it doesn't solve the isituations when cnt % rs_thresh != 0 even by using your plan. For example, t

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
Hi all, On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: In current led control API we have no way to k

[dpdk-dev] [PATCH v2] net/mlx5: fix incorrect pointer operation in meter

2020-01-08 Thread Suanming Mou
The meter suffix flow item pointer restore is not correct to decrease a fixed value. The incorrect operation will cause incorrect match to the meter suffix flow, the flow create will fail once the magic number in the wrong offset memory start with RTE_FLOW_ITEM_TYPE_END. The pointer should decrease

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-08 Thread Matan Azrad
Hi all Thanks very much for the review. Please see below. From: Andrew Rybchenko > On 1/8/20 8:28 AM, Tiwei Bie wrote: > > On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin wrote: > >> On 12/25/19 4:19 PM, Matan Azrad wrote: > >>> Add vDPA devices features table and explanation. > >>> > >

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-08 Thread Matan Azrad
Hi Xu From: Xu, Rosen > Hi Matan, > > Did you think about OVS DPDK? > vDPA is a basic module for OVS, currently it will take some exception path > packet processing for OVS, so it still needs to integrate eth_dev. I don't understand your question. What do you mean by "integrate eth_dev"? > Tha

[dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread David Marchand
meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes in Ubuntu 16.04. Let's pin meson to 0.52.0 while the fix is being prepared in meson. 1: https://github.com/mesonbuild/meson/issues/6427 Signed-off-by: David Marchand --- .ci/linux-setup.sh | 2 +- 1 file changed, 1 inse

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Luca Boccassi
On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > comes > in Ubuntu 16.04. > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > > 1: > https://github.com/mesonbuild/meson/issues/6427 > > > Signed

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread David Marchand
On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wrote: > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > > comes > > in Ubuntu 16.04. > > Let's pin meson to 0.52.0 while the fix is being prepared in meson. > > > >

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Bruce Richardson
On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wrote: > > > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that > > > comes > > > in Ubuntu 16.04. > >

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 9:42 AM, Olivier Matz wrote: > On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: >> On 1/8/2020 8:56 AM, David Marchand wrote: >>> Hello Laurent, >>> >>> Bonne année. >>> >>> Cc: maintainers. >>> >>> On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy >>> wrote: In curr

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Olivier Matz
On Wed, Jan 08, 2020 at 12:12:11PM +, Ferruh Yigit wrote: > On 1/8/2020 9:42 AM, Olivier Matz wrote: > > On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: > >> On 1/8/2020 8:56 AM, David Marchand wrote: > >>> Hello Laurent, > >>> > >>> Bonne année. > >>> > >>> Cc: maintainers. > >>>

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 9:55 AM, David Marchand wrote: > On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: >> >> On 1/8/2020 8:56 AM, David Marchand wrote: >>> Hello Laurent, >>> >>> Bonne année. >>> >>> Cc: maintainers. >>> >>> On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy >>> wrote: In current

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-08 Thread Xu, Rosen
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Wednesday, January 08, 2020 18:46 > To: Xu, Rosen ; Maxime Coquelin > ; Bie, Tiwei ; Wang, > Zhihong ; Wang, Xiao W > > Cc: Yigit, Ferruh ; dev@dpdk.org; Thomas Monjalon > ; Pei, Andy > Subject: RE: [dpdk-dev] [PATCH v1 0/3] Int

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-08 Thread Thomas Monjalon
08/01/2020 13:39, Xu, Rosen: > From: Matan Azrad > > From: Xu, Rosen > > > Did you think about OVS DPDK? > > > vDPA is a basic module for OVS, currently it will take some exception > > > path packet processing for OVS, so it still needs to integrate eth_dev. > > > > I don't understand your questi

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 10:31 AM, Laurent Hardy wrote: > Hi all, > > On 1/8/20 10:55 AM, David Marchand wrote: >> On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: >>> On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread David Marchand
On Wed, Jan 8, 2020 at 1:30 PM Ferruh Yigit wrote: > On 1/8/2020 9:55 AM, David Marchand wrote: > > On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: > >> Why it is an ABI break, dev_ops should be between library and drivers, so > >> it > >> should be out of the ABI concern, isn't it. > > > >

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 13:59, Ferruh Yigit: > On 1/8/2020 10:31 AM, Laurent Hardy wrote: > > Hi all, > > > > On 1/8/20 10:55 AM, David Marchand wrote: > >> On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit > >> wrote: > >>> On 1/8/2020 8:56 AM, David Marchand wrote: > Hello Laurent, > > Bonne anné

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:00 PM, David Marchand wrote: > On Wed, Jan 8, 2020 at 1:30 PM Ferruh Yigit wrote: >> On 1/8/2020 9:55 AM, David Marchand wrote: >>> On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: Why it is an ABI break, dev_ops should be between library and drivers, so it should

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-08 Thread Andrew Rybchenko
On 1/8/20 1:42 PM, Matan Azrad wrote: > Hi all > > Thanks very much for the review. > Please see below. > > From: Andrew Rybchenko >> On 1/8/20 8:28 AM, Tiwei Bie wrote: >>> On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin wrote: On 12/25/19 4:19 PM, Matan Azrad wrote: > Add vDP

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > 08/01/2020 13:59, Ferruh Yigit: >> On 1/8/2020 10:31 AM, Laurent Hardy wrote: >>> Hi all, >>> >>> On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: > On 1/8/2020 8:56 AM, David Marchand wrote:

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 14:20, Ferruh Yigit: > On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > > 08/01/2020 13:59, Ferruh Yigit: > >> But for dev_ops, instead of having another capabilities indicator, which > >> requires PMDs to keep this synchronized, I think it is better if we can > >> self > >> contain this i

Re: [dpdk-dev] [PATCH] net/mlx5: allow install more meter actions

2020-01-08 Thread Suanming Mou
Hi, > -Original Message- > From: Tonghao Zhang > Sent: Monday, January 6, 2020 9:47 AM > To: Suanming Mou > Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad ; > Slava Ovsiienko > Subject: Re: [PATCH] net/mlx5: allow install more meter actions > > On Fri, Jan 3, 2020 at 11:38 AM Suanming

Re: [dpdk-dev] [PATCH] net/mlx5: allow install more meter actions

2020-01-08 Thread Suanming Mou
Hi, > -Original Message- > From: Tonghao Zhang > Sent: Monday, January 6, 2020 9:47 AM > To: Suanming Mou > Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad ; > Slava Ovsiienko > Subject: Re: [PATCH] net/mlx5: allow install more meter actions > > On Fri, Jan 3, 2020 at 11:38 AM Suanming

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 14:25, Thomas Monjalon: > 08/01/2020 14:20, Ferruh Yigit: > > On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > > > 08/01/2020 13:59, Ferruh Yigit: > > >> But for dev_ops, instead of having another capabilities indicator, which > > >> requires PMDs to keep this synchronized, I think it is be

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:25 PM, Thomas Monjalon wrote: > 08/01/2020 14:20, Ferruh Yigit: >> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: >>> 08/01/2020 13:59, Ferruh Yigit: But for dev_ops, instead of having another capabilities indicator, which requires PMDs to keep this synchronized, I think it is

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:34 PM, Thomas Monjalon wrote: > 08/01/2020 14:25, Thomas Monjalon: >> 08/01/2020 14:20, Ferruh Yigit: >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: > But for dev_ops, instead of having another capabilities indicator, which > requires PMDs

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 2:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: On 1/8/2020 10:31 AM, Laurent Hardy wrote: Hi all, On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne anné

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:52 PM, Ferruh Yigit wrote: > On 1/8/2020 1:25 PM, Thomas Monjalon wrote: >> 08/01/2020 14:20, Ferruh Yigit: >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: > But for dev_ops, instead of having another capabilities indicator, which > require

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 14:58, Laurent Hardy: > About the 'is_supported()' versions of APIs, in the current patch I > factorize > the check on dev ops on and off availability in a same function named > "led_ctrl_capable" but I can rename it if required. > > Just in this specific case I don't dissociate on and

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 12:27 PM, Olivier Matz wrote: > On Wed, Jan 08, 2020 at 12:12:11PM +, Ferruh Yigit wrote: >> On 1/8/2020 9:42 AM, Olivier Matz wrote: >>> On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: > Hello Laurent, > > Bo

[dpdk-dev] [PATCH] maintainers: update for failsafe and pci lib

2020-01-08 Thread Gaetan Rivet
My email address has changed, gaetan.ri...@6wind.com is no longer valid. Signed-off-by: Gaetan Rivet --- Sorry, I did not take the time to change it while I controlled it. MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4395d8

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Andrew Rybchenko
On 1/8/20 4:52 PM, Ferruh Yigit wrote: > On 1/8/2020 1:25 PM, Thomas Monjalon wrote: >> 08/01/2020 14:20, Ferruh Yigit: >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: > But for dev_ops, instead of having another capabilities indicator, which > requires

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread David Marchand
On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson wrote: > > On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wrote: > > > > > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: > > > > meson 0.53.0 has a compatibility issue [

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 15:15, Andrew Rybchenko: > On 1/8/20 4:52 PM, Ferruh Yigit wrote: > > On 1/8/2020 1:25 PM, Thomas Monjalon wrote: > >> 08/01/2020 14:20, Ferruh Yigit: > >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > 08/01/2020 13:59, Ferruh Yigit: > > But for dev_ops, instead of having anoth

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-08 Thread Medvedkin, Vladimir
Hi Anoob, On 23/12/2019 13:34, Ananyev, Konstantin wrote: The rte_security API which enables inline protocol/crypto feature mandates that for every security session an rte_flow is created. This would internally translate to a rule in the hardware which would do packet classification. In rte

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Andrew Rybchenko
On 1/8/20 5:27 PM, Thomas Monjalon wrote: > 08/01/2020 15:15, Andrew Rybchenko: >> On 1/8/20 4:52 PM, Ferruh Yigit wrote: >>> On 1/8/2020 1:25 PM, Thomas Monjalon wrote: 08/01/2020 14:20, Ferruh Yigit: > On 1/8/2020 1:06 PM, Thomas Monjalon wrote: >> 08/01/2020 13:59, Ferruh Yigit: >>>

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 9:17 AM, Raslan Darawsheh wrote: > Hi, > >> -Original Message- >> From: dev On Behalf Of Tonghao Zhang >> Sent: Tuesday, January 7, 2020 8:39 AM >> To: Suanming Mou >> Cc: Matan Azrad ; Shahaf Shuler >> ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid cras

Re: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP

2020-01-08 Thread Ori Kam
Hi just small comment inside. Thanks, Ori > -Original Message- > From: dev On Behalf Of Bernard Iremonger > Sent: Tuesday, December 17, 2019 12:16 PM > To: dev@dpdk.org; beilei.x...@intel.com; qi.z.zh...@intel.com; > declan.dohe...@intel.com > Cc: konstantin.anan...@intel.com; bernard.ire

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 3:08 PM, Ferruh Yigit wrote: On 1/8/2020 12:27 PM, Olivier Matz wrote: On Wed, Jan 08, 2020 at 12:12:11PM +, Ferruh Yigit wrote: On 1/8/2020 9:42 AM, Olivier Matz wrote: On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: H

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix matcher metadata register c0 field setup

2020-01-08 Thread Ferruh Yigit
On 12/20/2019 7:48 AM, Viacheslav Ovsiienko wrote: > The metadata register c0 field in the matcher might be split > into two independent fields - the source vport index and META > item value. These fields have no permanent assigned bits, the > configuration is queried from the kernel drivers. > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-08 Thread Ferruh Yigit
On 12/20/2019 10:48 AM, Viacheslav Ovsiienko wrote: > The tx_burst routine supporting multi-segment packets with > legacy MPW and without inline was missed, and there was no > valid selection for these options, patch adds the missing > routine. > > Fixes: 82e75f8323bf ("net/mlx5: fix legacy multi-

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 2:53 PM, Ferruh Yigit wrote: > On 12/20/2019 10:48 AM, Viacheslav Ovsiienko wrote: >> The tx_burst routine supporting multi-segment packets with >> legacy MPW and without inline was missed, and there was no >> valid selection for these options, patch adds the missing >> routine. >> >> F

[dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func

2020-01-08 Thread Dekel Peled
Previous patch added support of GENEVE pattern item in flow rule. Function flow_item_default_mask() was not updated, so using it with GENEVE item returns null. Using testpmd command "set raw_decap" or "set raw_encap" with GENEVE item, without specifying any parameters, results in segmentation fault

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 2:38 PM, Ferruh Yigit wrote: > On 1/8/2020 9:17 AM, Raslan Darawsheh wrote: >> Hi, >> >>> -Original Message- >>> From: dev On Behalf Of Tonghao Zhang >>> Sent: Tuesday, January 7, 2020 8:39 AM >>> To: Suanming Mou >>> Cc: Matan Azrad ; Shahaf Shuler >>> ; dev@dpdk.org >>> Subj

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Aaron Conole
David Marchand writes: > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > wrote: >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wrote: >> > > >> > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: >> > > > meson

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2020-01-08 Thread Raslan Darawsheh
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 8, 2020 4:39 PM > To: Raslan Darawsheh ; Tonghao Zhang > ; Suanming Mou > > Cc: Matan Azrad ; Shahaf Shuler > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action > conf is NULL >

Re: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers

2020-01-08 Thread Ananyev, Konstantin
Hi Chenxu, > Thanks for your read. > > for our research, we don't think it is a good plan that reuse > ixgbe_xmit_cleanup() or ixgbe_tx_free_bufs. > following two opinion will show the reason. I think there is a main misunderstandings between us: TXD.DD bit setting. You expect that for every

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 3:07 PM, Thomas Monjalon wrote: 08/01/2020 14:58, Laurent Hardy: About the 'is_supported()' versions of APIs, in the current patch I factorize the check on dev ops on and off availability in a same function named "led_ctrl_capable" but I can rename it if required. Just in this speci

Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit

2020-01-08 Thread Stephen Hemminger
On Wed, 8 Jan 2020 09:45:54 + "Iremonger, Bernard" wrote: > Hi Stephen, > > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Tuesday, January 7, 2020 7:00 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v2] testpmd: call c

[dpdk-dev] [PATCH] net/mlx5: fix set Rx hash fields only if needed

2020-01-08 Thread Dekel Peled
Previous fix added translation of Rx hash fields to PRM format. This patch optimizes the fix, to perform value translation only if value is not zero. In case value is zero, there is no need to translate it. Fixes: 24753f9da454 ("net/mlx5: fix setting of Rx hash fields") Cc: sta...@dpdk.org Signe

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-08 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 8, 2020 16:55 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; sta...@dpdk.org; > Thomas Monjalon > Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burs

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Bruce Richardson
On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: > David Marchand writes: > > > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > > wrote: > >> > >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: > >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wrote: > >> > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 3:50 PM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, January 8, 2020 16:55 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Ori Kam ; sta...@dpdk.org; >> Thomas Monjalon >> Subject: Re:

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Kevin Traynor
On 08/01/2020 14:22, David Marchand wrote: > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > wrote: >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >>> On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wrote: On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: >

Re: [dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP

2020-01-08 Thread Loftus, Ciara
> > Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just > call it directly, like elsewhere in the driver. > > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Cc: sta...@dpdk.org > > Signed-off-by: Xiao Wang > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 5

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

2020-01-08 Thread Aaron Conole
Ruifeng Wang writes: >> -Original Message- >> From: Aaron Conole >> Sent: Monday, January 6, 2020 21:34 >> To: Ruifeng Wang >> Cc: maicolgabr...@hotmail.com; tho...@monjalon.net; >> ferruh.yi...@intel.com; arybche...@solarflare.com; dev@dpdk.org; >> david.march...@redhat.com; Gavin Hu ;

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

2020-01-08 Thread Aaron Conole
Honnappa Nagarahalli writes: > > >> > >> > > Add Travis compilation jobs for aarch64. gcc/clang compilations for >> > > static/shared libraries are added. >> > > >> > > Some limitations for current aarch64 Travis support: >> > > 1. Container is used. Huge page is not available due to security re

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: >> David Marchand writes: >> >> > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson >> > wrote: >> >> >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >> >> > On Wed, Jan 8, 2020 at 12:2

Re: [dpdk-dev] [PATCH 0/4] Add external contiguous memory support to Virtio-user

2020-01-08 Thread Maxime Coquelin
Hi Anatoly, Any feedback on the series? This is important for vDPA support, to be compliant with containeriez application using external memory. Thanks, Maxime On 12/13/19 3:13 PM, Maxime Coquelin wrote: > Somme applications/frameworks using DPDK allocate their own memory > for its buffers. This

[dpdk-dev] [PATCH 2/4] net/mlx5: update Tx error handling routine

2020-01-08 Thread Viacheslav Ovsiienko
This is preparation step, we are going to store the index of elts to free on completion in the dedicated free on completion queue, this patch updates the elts freeing routine and updates Tx error handling routine to be synched with coming new queue. Signed-off-by: Viacheslav Ovsiienko Acked-by: M

[dpdk-dev] [PATCH 4/4] net/mlx5: engage free on completion queue

2020-01-08 Thread Viacheslav Ovsiienko
The free on completion queue keeps the indices of elts array, all mbuf stored below this index should be freed on arrival of normal send completion. In debug version it also contains an index of completed transmitting descriptor (WQE) to check queues synchronization. Signed-off-by: Viacheslav Ovsi

[dpdk-dev] [PATCH 3/4] net/mlx5: add free on completion queue

2020-01-08 Thread Viacheslav Ovsiienko
The new software manged entity is introduced in Tx datapath - free on completion queue. This queue keeps the information how many buffers stored in elts array must freed on send comletion. Each element of the queue contains transmitting descriptor index to be in synch with completion entries (in de

[dpdk-dev] [PATCH 0/4] net/mlx5: remove Tx descriptor reserved field usage

2020-01-08 Thread Viacheslav Ovsiienko
The current Tx datapath implementation in mlx5 PMD uses the 16-bit reserved field within transmit descriptor to store the indices of the elts array keeping the mbuf pointers to be freed on transmit completion. On completion PMD fetches the descriptor index, then fetches the elts array index from re

[dpdk-dev] [PATCH 1/4] net/mlx5: move Tx complete request routine

2020-01-08 Thread Viacheslav Ovsiienko
The complete request flag is set once per Tx burst call, the code of appropriate routine moved to the end of sending loop. This is preparation step to remove WQE reserved field usage to store index of elts to free. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/m

Re: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP

2020-01-08 Thread Iremonger, Bernard
Hi Ori, Thanks for the review. > Subject: RE: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > command line for ESP > > Hi just small comment inside. > Thanks, > Ori > > > -Original Message- > > From: dev On Behalf Of Bernard Iremonger > > Sent: Tuesday, December 17, 2019 12:16

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-08 Thread Matan Azrad
Hi Andrew From: Andrew Rybchenko > Sent: Wednesday, January 8, 2020 3:11 PM > To: Matan Azrad ; Tiwei Bie ; > Maxime Coquelin > Cc: Zhihong Wang ; Xiao Wang > ; Ferruh Yigit ; > dev@dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table > > On 1/8/20 1:42

Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0

2020-01-08 Thread Bruce Richardson
On Wed, Jan 08, 2020 at 11:09:59AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: > >> David Marchand writes: > >> > >> > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson > >> > wrote: > >> >> > >> >> On Wed, Jan 08, 202

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

2020-01-08 Thread Bruce Richardson
On Wed, Jan 08, 2020 at 11:05:21AM -0500, Aaron Conole wrote: > Ruifeng Wang writes: > > >> -Original Message- > >> From: Aaron Conole > >> Sent: Monday, January 6, 2020 21:34 > >> To: Ruifeng Wang > >> Cc: maicolgabr...@hotmail.com; tho...@monjalon.net; > >> ferruh.yi...@intel.com; ary

Re: [dpdk-dev] [PATCH v3 0/9] updates for hns3 PMD driver

2020-01-08 Thread Ferruh Yigit
On 12/21/2019 10:32 AM, Wei Hu (Xavier) wrote: > This series are updates for hns3 ethernet PMD driver. > > Hao Chen (4): > net/hns3: support Rx interrupt > net/hns3: optimize RSS's default algorithm > net/hns3: remove the redundant function call > net/hns3: remove the unused macros > > Ho

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-08 Thread Kevin Traynor
On 24/12/2019 10:07, Yu, PingX wrote: > Kevin, > Update the regression test result of Intel part. See the details as below. > Hi Yu Ping, thanks for the report and the log files. > # Basic Intel(R) NIC testing > * PF(i40e): Pass > * PF(ixgbe): Pass > * VF: Pass > * Build or compile: 2 bugs are

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-08 Thread Kevin Traynor
On 24/12/2019 10:07, Yu, PingX wrote: > Kevin, > Update the regression test result of Intel part. See the details as below. > Hi Yu Ping, thanks for the report and the log files. > # Basic Intel(R) NIC testing > * PF(i40e): Pass > * PF(ixgbe): Pass > * VF: Pass > * Build or compile: 2 bugs are

Re: [dpdk-dev] [PATCH v1 1/3] drivers: introduce vDPA class

2020-01-08 Thread Thomas Monjalon
07/01/2020 18:32, Maxime Coquelin: > Hi Matan, > > On 12/25/19 4:19 PM, Matan Azrad wrote: > > The vDPA (vhost data path acceleration) drivers provide support for > > the vDPA operations introduced by the rte_vhost library. > > > > Any driver which provides the vDPA operations should be moved\add

Re: [dpdk-dev] [PATCH] update Intel roadmap for 20.02

2020-01-08 Thread Thomas Monjalon
13/12/2019 12:02, Ferruh Yigit: > Signed-off-by: Ferruh Yigit > --- > Roadmap provided by: > Cc: Tim O'Driscoll > Cc: John Mcnamara > --- > --- a/content/roadmap/_index.md > +++ b/content/roadmap/_index.md > +- Add cryptodev support for chachapoly symmetric algorithm in Intel QAT > devices > +-

[dpdk-dev] [PATCH 4/4] net/vhost: make secondary probe complete

2020-01-08 Thread Itsuro Oda
add lacking member setting and make secondary probe complete. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 44f44cea3..485a88794

[dpdk-dev] [PATCH 1/4] net/vhost: remove an unused member

2020-01-08 Thread Itsuro Oda
remove an unused member from pmd_internal. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 46f01a7f4..d4e3485ce 100644 --- a/dr

[dpdk-dev] [PATCH 0/4] make vhost PMD available for secondary processes

2020-01-08 Thread Itsuro Oda
vhost PMD has not been available for secondary processes since DPDK v18.11. (https://bugs.dpdk.org/show_bug.cgi?id=194) (for a long term !) This series of patches intend to make vhost PMD available for secondary processes. Because now setting vhost driver to communicate with a vhost-user master (e

[dpdk-dev] [PATCH 2/4] net/vhost: allocate iface_name from heap

2020-01-08 Thread Itsuro Oda
allocate iface_name of pmd_internal from heap in order to be able to refer from secondary processes. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/

[dpdk-dev] [PATCH 3/4] net/vhost: delay vhost driver setup

2020-01-08 Thread Itsuro Oda
setting vhost driver is delayed at eth_dev configuration in order to be able to set it from a secondary process. Signed-off-by: Itsuro Oda --- drivers/net/vhost/rte_eth_vhost.c | 130 ++ 1 file changed, 78 insertions(+), 52 deletions(-) diff --git a/drivers/net/vhost

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

2020-01-08 Thread Honnappa Nagarahalli
> > > > > > > > > + > > > > > > > > > +static __rte_always_inline void > > > > > > > > > +enqueue_elems_128(struct rte_ring *r, uint32_t > > > > > > > > > +prod_head, const void *obj_table, uint32_t n) { > > > > > > > > > +unsigned int i; const uint32_t size = > > > > > > > > > +r->size; uint32_t

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

2020-01-08 Thread Ananyev, Konstantin
> > > > > > > > > > > + > > > > > > > > > > +static __rte_always_inline void > > > > > > > > > > +enqueue_elems_128(struct rte_ring *r, uint32_t > > > > > > > > > > +prod_head, const void *obj_table, uint32_t n) { > > > > > > > > > > +unsigned int i; const uint32_t size = > > > > > > > > > > +r

Re: [dpdk-dev] l2fwd application are not sending continuous packets .

2020-01-08 Thread satyavalli rama
Can anyone please help us with this? On Mon, Jan 6, 2020, 11:25 satyavalli rama wrote: > > > > Hello Dpdk Team, > > I'm facing issue while forwarding packets in DPDK's l2fwd application. > While sending 1 Lac packets from Scapy, I could see sometimes packets are > sending from one VM to another

Re: [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table

2020-01-08 Thread Tiwei Bie
On Wed, Jan 08, 2020 at 10:42:48AM +, Matan Azrad wrote: > Hi all > > Thanks very much for the review. > Please see below. > > From: Andrew Rybchenko > > On 1/8/20 8:28 AM, Tiwei Bie wrote: > > > On Tue, Jan 07, 2020 at 06:39:36PM +0100, Maxime Coquelin wrote: > > >> On 12/25/19 4:19 PM, Mata

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 08, 2020 20:59 > To: Matan Azrad ; Maxime Coquelin > ; Bie, Tiwei ; Wang, > Zhihong ; Wang, Xiao W > ; Xu, Rosen > Cc: Yigit, Ferruh ; dev@dpdk.org; Pei, Andy > > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce

[dpdk-dev] [PATCH v4 0/9] Windows patchset with additional EAL functionalities

2020-01-08 Thread Pallavi Kadam
This patchset includes additional functionalities for Windows EAL to support command-line parsing feature and some EAL common code on Windows. This patchset can be applied to windpdk-next-dev branch in the draft repo. v4 changes: Modified license/exceptions.txt file The following

[dpdk-dev] [PATCH v4 3/9] eal: add windows compatible header files

2020-01-08 Thread Pallavi Kadam
Modified \common\include\arch\x86\rte_vect.h to include SSE4 header for Windows. Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support functions and path defines for files and directories on Windows. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v4 9/9] eal: add minimum viable code to support parsing

2020-01-08 Thread Pallavi Kadam
Adding specific logic for eal.c to support parsing on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c | 133 ++- 1 file changed, 130 insertions(+), 3 de

[dpdk-dev] [PATCH v4 1/9] license: add license exception for windows

2020-01-08 Thread Pallavi Kadam
The Governing Board and Tech Board have provided exceptions for MIT and BSD-2-Clause license files for DPDK support on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- license/exceptions.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lice

[dpdk-dev] [PATCH v4 2/9] eal: dirent.h implementation for windows

2020-01-08 Thread Pallavi Kadam
Adding dirent.h on Windows to support common code. eal_common_options.c includes this file. The original contribution is under MIT license. https://github.com/tronkko/dirent Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles ---

[dpdk-dev] [PATCH v4 5/9] eal: getopt implementation for windows

2020-01-08 Thread Pallavi Kadam
Adding getopt files to support parsing option on Windows. The original contribution is under BSD-2 license. https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt .c https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt .h Signed-off-by: Antara Ganesh Kol

  1   2   >