On 1/8/20 3:07 PM, Thomas Monjalon wrote:
08/01/2020 14:58, Laurent Hardy:
About the 'is_supported()' versions of APIs, in the current patch I
factorize
the check on dev ops on and off availability in a same function named
"led_ctrl_capable" but I can rename it if required.
Just in this specific case I don't dissociate on and off capability, as
being
able to set the led off without a way to set it on again sounds a bit
unusual :)
The other alternatives are in rte_eth_dev_info and dev_flags.
Basically we just need to decide whether we prefer a new function
or a new flag.
Until now, capabilities were given in flags.
Why a function here?
For this case, (led control API) all material is already available at
rte_ethdev layer.
So you could rely on led_off/on ops availability without the need to
add/maintain in
all pmds some flags to expose such capabilities.
What do you suggest to set a capability flag for the device at
rte_ethdev level?
