Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-27 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 27, 2019 1:02 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; Bruce Richardson ; > david.march...@redhat.com; jer...@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; Joyce Kong

[dpdk-dev] [PATCH] MAINTAINERS: update armv8 crypto PMD maintainership

2019-11-27 Thread Ruifeng Wang
Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4a0c9a47e..5f7213872 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -940,7 +940,7 @@ F: doc/guides/cryptodevs/ccp.rst F: doc/guide

Re: [dpdk-dev] [PATCH] MAINTAINERS: update armv8 crypto PMD maintainership

2019-11-27 Thread Jerin Jacob
On Wed, Nov 27, 2019 at 5:15 PM Ruifeng Wang wrote: > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > --- Request to add some git comments while merging or sending the v2. Something like below, It is expected to update this PMD to be in line with ARM's crypto library. Update the mainta

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/5] drivers/octeontx2: allow experimental symbols

2019-11-27 Thread Sunil Kumar Kori
Regards Sunil Kumar Kori >-Original Message- >From: Thomas Monjalon >Sent: Tuesday, November 26, 2019 9:51 PM >To: dev@dpdk.org >Cc: Sunil Kumar Kori ; Jerin Jacob Kollanukkaran >; Nithin Kumar Dabilpuram >; Vamsi Krishna Attunuru >; Kiran Kumar Kokkilagadda >; Satha Koteswara Rao Kott

Re: [dpdk-dev] [PATCH v5] doc: clarify virtio PMD path selection

2019-11-27 Thread Maxime Coquelin
On 11/27/19 4:19 PM, Yinan wrote: > From: Yinan Wang > > Add virtio paths selection and usage introduction for better > virtio usability. > > Signed-off-by: Yinan Wang > --- > doc/guides/howto/index.rst| 1 + > .../virtio_paths_selection_and_usage.rst | 126 ++

[dpdk-dev] [PATCH v2] MAINTAINERS: update armv8 crypto PMD maintainership

2019-11-27 Thread Ruifeng Wang
It is expected to update this PMD to be in line with Arm's crypto library. Update the maintainership to refect the change. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Acked-by: Jerin Jacob --- v2: Add git comments to explain the change. (Jerin) MAINTAINERS | 2 +- 1 file changed, 1 inse

[dpdk-dev] [PATCH v8 0/1] fbarray: fix duplicated fbarray file in secondary

2019-11-27 Thread Yasufumi Ogawa
In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve unique name other than fir

[dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-27 Thread Yasufumi Ogawa
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve uni

Re: [dpdk-dev] [PATCH] MAINTAINERS: update armv8 crypto PMD maintainership

2019-11-27 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, November 27, 2019 16:34 > To: Ruifeng Wang (Arm Technology China) > Cc: jer...@marvell.com; dpdk-dev ; Gavin Hu (Arm > Technology China) ; Honnappa Nagarahalli > ; nd > Subject: Re: [dpdk-dev] [PATCH] MAINTAINERS: update armv8

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 08:09:22AM +, Phil Yang (Arm Technology China) wrote: > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, November 27, 2019 1:02 AM > > To: Phil Yang (Arm Technology China) > > Cc: dev@dpdk.org; Bruce Richardson ; > > david.march...@redhat.co

Re: [dpdk-dev] [PATCH] vhost: fix insecure temporary file

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 02:19:39AM +, Yu, Jin wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, November 26, 2019 6:00 PM > > To: Yu, Jin > > Cc: Maxime Coquelin ; Bie, Tiwei > > ; Wang, Zhihong ; > > dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH] examples/vhost_blk: fix the TOCTOU

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 02:36:01AM +, Yu, Jin wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, November 26, 2019 6:26 PM > > To: Yu, Jin > > Cc: Maxime Coquelin ; Bie, Tiwei > > ; Wang, Zhihong ; > > dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/5] drivers/octeontx2: allow experimental symbols

2019-11-27 Thread Thomas Monjalon
27/11/2019 09:34, Sunil Kumar Kori: > From: Thomas Monjalon > >26/11/2019 07:15, Sunil Kumar Kori: > >> Multiple experimental symbols are used. They must be allowed to avoid > >> compilation error. > > > >If there was an error, > >1/ I would see it in my compilation test 2/ There would be some "Fi

[dpdk-dev] [PATCH] net/mlx5: fix default mark copy flow

2019-11-27 Thread Viacheslav Ovsiienko
In extensive metadata mode the MARK copy table is engaged, if the application creates the flow with zero MARK ID action: flow create 1 ingress pattern eth / ... / end actions mark id 0 / .. end And then destroys that, the traffic to the port stops. This happens due to default flow for the copy ta

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-27 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, November 27, 2019 5:30 PM > To: Phil Yang (Arm Technology China) > Cc: tho...@monjalon.net; dev@dpdk.org; david.march...@redhat.com; > jer...@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; Joyce Ko

[dpdk-dev] [PATCH v2 2/4] common/octeontx2: add interrupt offset to mbox structure

2019-11-27 Thread Sunil Kumar Kori
mbox response are triggered at bar2 + RVU_PF_INT or bar2 + RVU_VF_INT, depending upon the device. To process these interrupts different irq handlers are installed. To unify it, added offset field into mbox structure which is initialized with RVU_PF_INT or RVU_VF_INT at the time of otx2_mbox_init.

[dpdk-dev] [PATCH v2 1/4] eal: add API to check if its interrupt context

2019-11-27 Thread Sunil Kumar Kori
Added an API to check if current execution is in interrupt context. This will be helpful to handle nested interrupt cases. Signed-off-by: Harman Kalra Signed-off-by: Sunil Kumar Kori --- v2: - Rebased patch on 19.11-rc4 lib/librte_eal/common/include/rte_interrupts.h | 15 +++ lib/

[dpdk-dev] [PATCH v2 3/4] common/octeontx2: add polling based response mbox message

2019-11-27 Thread Sunil Kumar Kori
Currently otx2_mbox_get_rsp get response once AF driver interrupts after completion. But this funciton will get into deadlock if called in another interrupt context. To avoid it, implemented another version of this function which polls on dedicated memory for a given timeout. Also after clearing

[dpdk-dev] [PATCH v2 4/4] drivers/octeontx2: enhancing mbox APIs to get response

2019-11-27 Thread Sunil Kumar Kori
Based on thread context, mbox API will get response for submitted request. If thread runs in interrupt context then it uses polling based get response API otherwise interrupt based. Signed-off-by: Sunil Kumar Kori --- v2: - Included Makefile and meson build changes. - Rebased patch on 19.11-rc4

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-27 Thread Burakov, Anatoly
On 26-Nov-19 7:40 PM, Yasufumi Ogawa wrote: Hi David, Sorry for slow reply. On 2019/11/14 21:27, David Marchand wrote: On Thu, Nov 14, 2019 at 12:42 PM Yasufumi Ogawa wrote: On 2019/11/14 2:01, Burakov, Anatoly wrote: On 13-Nov-19 9:43 PM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-27 Thread Thomas Monjalon
27/11/2019 11:00, Phil Yang (Arm Technology China): > > -Original Message- > > From: Bruce Richardson > > Sent: Wednesday, November 27, 2019 5:30 PM > > To: Phil Yang (Arm Technology China) > > Cc: tho...@monjalon.net; dev@dpdk.org; david.march...@redhat.com; > > jer...@marvell.com; Honna

[dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2019-11-27 Thread jerinj
From: Jerin Jacob Add tested Marvell integrated NIC platforms to v19.11 release note. Signed-off-by: Jerin Jacob --- doc/guides/rel_notes/release_19_11.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Li, Xiaoyun
Hi The patch is fine. But please polish the commit log first. You can use expression like "This patch checked the return value of rte_eth_dev_info_get function." Best Regards, Xiaoyun Li > -Original Message- > From: T D, Shashank > Sent: Wednesday, November 27, 2019 10:34 > To: dev@dpdk.

[dpdk-dev] [PATCH] event/octeontx: handle partial receive packets

2019-11-27 Thread pbhagavatula
From: Pavan Nikhilesh When net/octeontx is connected to event/octeontx as an event Rx adapter, PKI aka 'net/octeontx' can forward packets directly to SSO aka 'event/octeontx'. When pumping traffic to PKI if flow control is disabled internal FIFOs might be overrun causing partial l2 packets to be

[dpdk-dev] [PATCH] maintainers: update maintainers for nfp PMD

2019-11-27 Thread Heinrich Kuhn
As Alejandro is no longer with Netronome we appointed two new maintainers for the Netronome PMD Signed-off-by: Heinrich Kuhn --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4a0c9a47e..6bac90c25 100644 --- a/MAINTAINERS +++ b/M

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

2019-11-27 Thread Van Haaren, Harry
> -Original Message- > From: Aaron Conole > Sent: Tuesday, November 26, 2019 1:57 PM > To: Van Haaren, Harry > Cc: Thomas Monjalon ; Amber, Kumar > ; dev@dpdk.org; Wang, Yipeng1 > ; Yigit, Ferruh ; Thakur, > Sham Singh ; David Marchand > > Subject: Re: [dpdk-dev] [PATCH v3] hash: added a

Re: [dpdk-dev] [PATCH] event/octeontx: handle partial receive packets

2019-11-27 Thread Jerin Jacob
On Wed, Nov 27, 2019 at 8:05 PM wrote: > > From: Pavan Nikhilesh > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > PKI aka 'net/octeontx' can forward packets directly to SSO aka > 'event/octeontx'. > When pumping traffic to PKI if flow control is disabled internal FIF

Re: [dpdk-dev] [EXT] Re: [PATCH] event/octeontx: handle partial receive packets

2019-11-27 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Jerin Jacob >Sent: Wednesday, November 27, 2019 5:14 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; dpdk-dev > >Subject: [EXT] Re: [dpdk-dev] [PATCH] event/octeontx: handle partial >receive packets > >External Email > >---

Re: [dpdk-dev] [PATCH v2 4/8] doc: remove reference to old versions of FreeBSD

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: FreeBSD 10 is now EOL and all testing with DPDK takes place on BSD versions 11 and 12, so we can just remove the note. The BSD ports are supported on all non-EOL versions of BSD. Signed-off-by: Bruce Richardson --- Acked-by: Anatoly Burakov -- T

Re: [dpdk-dev] [PATCH v2 5/8] doc: update examples output in FreeBSD GSG

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: The output of running the helloworld example on FreeBSD was a little out-of-date and can be shortened by using the latest version of DPDK. Update appropriately. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_gsg/install_from_ports.rst | 56

Re: [dpdk-dev] [PATCH v2 6/8] doc: add meson install instructions for FreeBSD

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: Update the FreeBSD GSG doc with instructions for installing using meson and ninja rather than make. Signed-off-by: Bruce Richardson --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 5/8] doc: update examples output in FreeBSD GSG

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 12:11:41PM +, Burakov, Anatoly wrote: > On 25-Nov-19 2:55 PM, Bruce Richardson wrote: > > The output of running the helloworld example on FreeBSD was a little > > out-of-date and can be shortened by using the latest version of DPDK. > > Update appropriately. > > > > Sig

Re: [dpdk-dev] [PATCH v2 7/8] doc: update documentation on build and running FreeBSD apps

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: Update the documentation on building and running apps on FreeBSD, taking account of having used meson for building. We can also update the section on the command-line parameters, rather than claiming to be a complete list of parameters, it should desc

Re: [dpdk-dev] [PATCH v2 8/8] doc: drop EAL command-line reference from FreeBSD GSG

2019-11-27 Thread Burakov, Anatoly
On 25-Nov-19 2:55 PM, Bruce Richardson wrote: The EAL command-line reference section duplicated material covered in a previous chapter, was out of date, and generally is unnecessary as options are best queried directly by passing "--help" to a DPDK binary. Therefore we can drop this section to av

[dpdk-dev] [PATCH] net/mlx5: fix legacy non-inline multi-packet performance

2019-11-27 Thread Viacheslav Ovsiienko
The legacy multi-packet write is the feature allowing to put multiple packets into one transmitting descriptor, this feature is supported by only NIC ConnectX-4LX. The number of packets should be limited to provide optimal size descriptor and better performance. Fixes: 18a1c20044c0 ("net/mlx5: imp

[dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling

2019-11-27 Thread pbhagavatula
From: Pavan Nikhilesh When net/octeontx is connected to event/octeontx as an event Rx adapter, PKI aka 'net/octeontx' can forward packets directly to SSO aka 'event/octeontx'. When pumping traffic to PKI if flow control is disabled internal FIFOs might be overrun causing partial l2 packets to be

Re: [dpdk-dev] [PATCH v2] vhost-blk: fix the unused return value

2019-11-27 Thread Maxime Coquelin
On 11/27/19 1:16 PM, Jin Yu wrote: > add the assert to handle error. > > Coverity issue: 350592 > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: sta...@dpdk.org > > Signed-off-by: Jin Yu > --- > v2 - add the error hander > --- > examples/vhost_blk/vhost_blk.

[dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2019-11-27 Thread Viacheslav Ovsiienko
The legacy multi-packet write is the feature allowing to put multiple packets into one transmitting descriptor, this feature is supported by only NIC ConnectX-4LX. The number of packets should be limited to provide optimal size descriptor and better performance. Fixes: 18a1c20044c0 ("net/mlx5: imp

Re: [dpdk-dev] [PATCH v2] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Li, Xiaoyun
> -Original Message- > From: T D, Shashank > Sent: Wednesday, November 27, 2019 12:04 > To: dev@dpdk.org > Cc: Li, Xiaoyun > Subject: [PATCH v2] examples/tep_termination: resolve unchecked return value > > This patch checked the return value of rte_eth_dev_info_get function. > Coverity is

[dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Harry van Haaren
This commit fixes a sporadic failure of the service_autotest unit test, as seen in the DPDK CI. The failure occurs as the main test thread did not wait on the service-thread to return, and allowing it to read a flag before the service was able to write to it. The fix changes the wait API call to s

[dpdk-dev] [PATCH V3] doc: add tested Intel platforms with Intel NICs

2019-11-27 Thread Chen, Zhaoyan
From: Wenjie Li V3: Use symbols from isonum.txt to optimize the doc. V2: Fix some typos. V1: Add tested Intel platforms with Intel NICs to v19.11 release note. Signed-off-by: Wenjie Li --- doc/guides/rel_notes/release_19_11.rst | 99 ++ 1 file changed, 99 insertions(

Re: [dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling

2019-11-27 Thread Jerin Jacob
On Wed, Nov 27, 2019 at 9:36 PM wrote: > > From: Pavan Nikhilesh > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > PKI aka 'net/octeontx' can forward packets directly to SSO aka > 'event/octeontx'. > When pumping traffic to PKI if flow control is disabled internal FIF

[dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow

2019-11-27 Thread Viacheslav Ovsiienko
In extensive metadata mode the MARK copy table is engaged, if the application creates the flow with zero MARK ID action: flow create 1 ingress pattern eth / ... / end actions mark id 0 / .. end And then destroys that, the traffic to the port stops. This happens due to default flow for the copy ta

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from NFP PMD maintainer

2019-11-27 Thread Heinrich Kuhn
On 2019/11/25 20:52, thomas at monjalon.net (Thomas Monjalon) wrote: > 13/11/2019 14:05, Alejandro Lucero: >> On Wed, Nov 13, 2019 at 12:55 PM Ferruh Yigit >> wrote: >>> On 11/13/2019 12:47 PM, Alejandro Lucero wrote: [...] >>> Can it be possible to nominate someone? >>> It would be good to have a

[dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
A buffer overflow happens in testpmd with some drivers since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. The advertised capabilities of mlx4, mlx5 and softnic for the number of queues were the maximum number: UINT16_MAX. They must be limited by the configured RTE_MAX_QUEUES_PER_PORT t

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow

2019-11-27 Thread Ori Kam
> -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, November 27, 2019 3:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v2] net/mlx5: fix default mark copy flow > > In extensive metadata mode the MARK copy table is engaged,

Re: [dpdk-dev] [PATCH v2 8/8] doc: drop EAL command-line reference from FreeBSD GSG

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 12:31:10PM +, Burakov, Anatoly wrote: > On 25-Nov-19 2:55 PM, Bruce Richardson wrote: > > The EAL command-line reference section duplicated material covered in a > > previous chapter, was out of date, and generally is unnecessary as options > > are best queried directly

Re: [dpdk-dev] [PATCH] net/nfp: replace license text with SPDX tag

2019-11-27 Thread Heinrich Kuhn
On 2019/09/27 10:33, hemant.agrawal at nxp.com (Hemant Agrawal) wrote: > Signed-off-by: Hemant Agrawal Acked-by: Heinrich Kuhn

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy non-inline multi-packet performance

2019-11-27 Thread Matan Azrad
From: Viacheslav Ovsiienko > The legacy multi-packet write is the feature allowing to put multiple packets > into one transmitting descriptor, this feature is supported by only NIC > ConnectX-4LX. > The number of packets should be limited to provide optimal size descriptor > and better performa

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2019-11-27 Thread Matan Azrad
From: Viacheslav Ovsiienko > The legacy multi-packet write is the feature allowing to put multiple packets > into one transmitting descriptor, this feature is supported by only NIC > ConnectX-4LX. > The number of packets should be limited to provide optimal size descriptor > and better performan

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Ferruh Yigit
On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > A buffer overflow happens in testpmd with some drivers > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > The advertised capabilities of mlx4, mlx5 and softnic > for the number of queues were the maximum number: UINT16_MAX. > They m

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: > > On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > > A buffer overflow happens in testpmd with some drivers > > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > > > The advertised capabilities of mlx4, mlx5 and softnic > > for

Re: [dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Aaron Conole
Harry van Haaren writes: > This commit fixes a sporadic failure of the service_autotest > unit test, as seen in the DPDK CI. The failure occurs as the main test > thread did not wait on the service-thread to return, and allowing it > to read a flag before the service was able to write to it. > >

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
27/11/2019 15:07, David Marchand: > On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: > > > > On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > > > A buffer overflow happens in testpmd with some drivers > > > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > > > > > The advertised

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Ferruh Yigit
On 11/27/2019 2:11 PM, Thomas Monjalon wrote: > 27/11/2019 15:07, David Marchand: >> On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: >>> >>> On 11/27/2019 1:42 PM, Thomas Monjalon wrote: A buffer overflow happens in testpmd with some drivers since the queue arrays are limited to RTE_

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread Ferruh Yigit
On 11/27/2019 2:14 PM, Ferruh Yigit wrote: > On 11/27/2019 2:11 PM, Thomas Monjalon wrote: >> 27/11/2019 15:07, David Marchand: >>> On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > A buffer overflow happens in testpmd with some drive

Re: [dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Van Haaren, Harry
> -Original Message- > From: Aaron Conole > Sent: Wednesday, November 27, 2019 2:10 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH] test/service: fix wait for service core > > Harry van Haaren writes: > > > This commit fixes a sporadic failure of the service_autote

[dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues

2019-11-27 Thread xiangxia . m . yue
From: Tonghao Zhang If configuring the number of tx/rx queue with rte_eth_dev_configure to nr_queues + hairpin_nr_queues, and setting tx/rx queues to nr_queues with rte_eth_tx/rx_queue_setup. But not configuring the hairpin queues via rte_eth_tx/rx_hairpin_queue_setup. When starting the netdev,

[dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq

2019-11-27 Thread xiangxia . m . yue
From: Tonghao Zhang The mlx5_rxq_obj_hairpin_new doesn't alloc the cq anymore. When releasing it, don't check it. Fixes: e79c9be91515 ("net/mlx5: support Rx hairpin queues") Cc: Ori Kam Signed-off-by: Tonghao Zhang --- drivers/net/mlx5/mlx5_rxq.c | 1 - 1 file changed, 1 deletion(-) diff --g

[dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment

2019-11-27 Thread xiangxia . m . yue
From: Tonghao Zhang The type of txq has been assigned in mlx5_txq_hairpin_new. Fixes: ae18a1ae9692 ("net/mlx5: support Tx hairpin queues") Cc: Ori Kam Signed-off-by: Tonghao Zhang --- drivers/net/mlx5/mlx5_txq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/

Re: [dpdk-dev] [PATCH v3] mk: add support for UBSAN

2019-11-27 Thread Aaron Conole
Harman Kalra writes: > UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior > detector. UBSan modifies the program at compile-time to catch > various kinds of undefined behavior during program execution. > > This patch introduces support for UBSan to the DPDK. > > See: doc/guides/prog_

Re: [dpdk-dev] [PATCH] ethdev: limit maximum number of queues

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:11 PM Thomas Monjalon wrote: > > 27/11/2019 15:07, David Marchand: > > On Wed, Nov 27, 2019 at 3:06 PM Ferruh Yigit wrote: > > > > > > On 11/27/2019 1:42 PM, Thomas Monjalon wrote: > > > > A buffer overflow happens in testpmd with some drivers > > > > since the queue arr

[dpdk-dev] [PATCH v2] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
A buffer overflow happens in testpmd with some drivers since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. The advertised capabilities of mlx4, mlx5 and softnic for the number of queues were the maximum number: UINT16_MAX. They must be limited by the configured RTE_MAX_QUEUES_PER_PORT t

Re: [dpdk-dev] [PATCH v2] ethdev: limit maximum number of queues

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:31 PM Thomas Monjalon wrote: > > A buffer overflow happens in testpmd with some drivers > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > The advertised capabilities of mlx4, mlx5 and softnic > for the number of queues were the maximum number: UINT16_MA

Re: [dpdk-dev] [dpdk-users] What is the 'unit of timestamp' assigned to mbuf packet in DPDK?

2019-11-27 Thread Tom Barbette
Hi Gokul, As Setphen said, only Mellanox sets the hardware timestamp. If you have a Mellanox card, you can actually follow the example given in the rxtx_callback sample application that precisely gives the number of CPU cycles a packet spent into the queue. Tom Le 22/11/2019 à 18:00, Gokul

Re: [dpdk-dev] [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin queues

2019-11-27 Thread Ori Kam
> -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 1/3] net/mlx5: avoid crash when setting hairpin > queues > > From: Tonghao Zhang > > If configuring the nu

Re: [dpdk-dev] [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment

2019-11-27 Thread Ori Kam
> -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 2/3] net/mlx5: clean up redundant assignment > > From: Tonghao Zhang > > The type of txq has been assigned

Re: [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq

2019-11-27 Thread Ori Kam
This patch is not correct, You are using old code. This was already solved. Thanks, Ori > -Original Message- > From: xiangxia.m@gmail.com > Sent: Wednesday, November 27, 2019 4:19 PM > To: dev@dpdk.org > Cc: Tonghao Zhang ; Ori Kam > > Subject: [PATCH dpdk-dev 3/3] net/mlx5: remove

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: limit maximum number of queues

2019-11-27 Thread Thomas Monjalon
27/11/2019 15:47, David Marchand: > On Wed, Nov 27, 2019 at 3:31 PM Thomas Monjalon wrote: > > > > A buffer overflow happens in testpmd with some drivers > > since the queue arrays are limited to RTE_MAX_QUEUES_PER_PORT. > > > > The advertised capabilities of mlx4, mlx5 and softnic > > for the num

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-27 Thread Wiles, Keith
> On Nov 26, 2019, at 2:21 AM, Nirmal Sarkar wrote: > > Hello, > > To support Jumbo frame in dpdk-pktgen, changes were suggested in dpdk > libraries also apart from pktgen code. > lib/librte_mbuf/rte_mbuf.h > lib/common/pg_inet.h > > But dpdk framework already supports jumbo frame [using

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix default mark copy flow

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:45, Ori Kam: > From: Viacheslav Ovsiienko > Sent: Wednesday, November 27, 2019 3:37 PM > > > In extensive metadata mode the MARK copy table is engaged, > > if the application creates the flow with zero MARK ID action: > > > > flow create 1 ingress pattern eth / ... / end actions ma

[dpdk-dev] [PATCH] doc: use the latest numactl release

2019-11-27 Thread Ali Alnubani
Previous versions of numactl may produce the following error on some systems (at least on Fedora 30 and RHEL7.4): ./.libs/libnuma.so: undefined reference to `minor' ./.libs/libnuma.so: undefined reference to `major' collect2: error: ld returned 1 exit status This was fixed in upstream commi

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy non-inline multi-packet performance

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:53, Matan Azrad: > From: Viacheslav Ovsiienko > > The legacy multi-packet write is the feature allowing to put multiple > > packets > > into one transmitting descriptor, this feature is supported by only NIC > > ConnectX-4LX. > > The number of packets should be limited to provide op

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:54, Matan Azrad: > From: Viacheslav Ovsiienko > > The legacy multi-packet write is the feature allowing to put multiple > > packets > > into one transmitting descriptor, this feature is supported by only NIC > > ConnectX-4LX. > > The number of packets should be limited to provide opt

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-27 Thread Ali Alnubani
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 26, 2019 2:01 PM > To: Ali Alnubani > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu > as a prerequisite > > On Tue, Nov 26, 2019 at 10:41:08AM +, Ali Alnubani wrote:

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2019 at 03:54:55PM +, Ali Alnubani wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, November 26, 2019 2:01 PM > > To: Ali Alnubani > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu > > as a pre

Re: [dpdk-dev] [PATCH 1/2] config: set the pkgconfig executable

2019-11-27 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 08:14:22AM +, Ali Alnubani wrote: > Meson fails to find a pkg-config executable if pkgconfig > isn't set for aarch64. The environment variable `PKG_CONFIG_PATH` > is useless in this case, and meson fails to locate dependencies > that are built in non-standard paths. > >

[dpdk-dev] [Bug 372] ixgbevf: cannot probe or start port if PF link is unstable

2019-11-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=372 Bug ID: 372 Summary: ixgbevf: cannot probe or start port if PF link is unstable Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIR

[dpdk-dev] [PATCH] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Shashank T D
resolve the unchecked return value from the function rte_eth_dev_info_get. Coverity issue: 349922 Signed-off-by: Shashank T D --- examples/tep_termination/vxlan_setup.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/tep_termination/vxlan_setup.c b/examples/te

[dpdk-dev] [PATCH v2] examples/tep_termination: resolve unchecked return value

2019-11-27 Thread Shashank T D
This patch checked the return value of rte_eth_dev_info_get function. Coverity issue: 349922 Signed-off-by: Shashank T D --- examples/tep_termination/vxlan_setup.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_ter

Re: [dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:32, Jerin Jacob: > On Wed, Nov 27, 2019 at 9:36 PM wrote: > > > > From: Pavan Nikhilesh > > > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > > PKI aka 'net/octeontx' can forward packets directly to SSO aka > > 'event/octeontx'. > > When pumping traffic

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix wait for service core

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:16 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: Aaron Conole > > Sent: Wednesday, November 27, 2019 2:10 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] test/service: fix wait for service core > > > > Harry van Haaren

Re: [dpdk-dev] [dpdk-announce] release candidate 19.11-rc4

2019-11-27 Thread Stokes, Ian
On 11/26/2019 11:56 PM, Thomas Monjalon wrote: A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.11-rc4 93 patches were integrated. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_19_11.html It should be completed w

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Aaron Conole
David Marchand writes: > On Wed, Nov 27, 2019 at 3:16 PM Van Haaren, Harry > wrote: >> >> > -Original Message- >> > From: Aaron Conole >> > Sent: Wednesday, November 27, 2019 2:10 PM >> > To: Van Haaren, Harry >> > Cc: dev@dpdk.org >> > Subject: Re: [PATCH] test/service: fix wait for s

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix wait for service core

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 3:16 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: Aaron Conole > > Sent: Wednesday, November 27, 2019 2:10 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] test/service: fix wait for service core > > > > Harry van Haaren

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-27 Thread David Marchand
On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > So far, we did not pay attention to direct access to variables but they > > are part of the API/ABI too and should be clearly identified. > > > > Introduce a __rte_experimental_

Re: [dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread David Marchand
On Wed, Nov 27, 2019 at 2:20 PM Harry van Haaren wrote: > > This commit fixes a sporadic failure of the service_autotest > unit test, as seen in the DPDK CI. The failure occurs as the main test > thread did not wait on the service-thread to return, and allowing it > to read a flag before the servi

Re: [dpdk-dev] [PATCH] git: ignore more build directories

2019-11-27 Thread Thomas Monjalon
20/11/2019 10:48, David Marchand: > On Sat, Sep 14, 2019 at 5:05 PM Thomas Monjalon wrote: > > > > Build directories commonly have compiler in their names. > > In order to filter build directories not starting with "build-" > > (common with make), patterns for gcc and clang are added to .gitignore

[dpdk-dev] [PATCH] eal: fix unitialized data warning

2019-11-27 Thread Stephen Hemminger
Valgrind reports that eal interrupt thread is calling epoll_ctl with uninitialized data. Trivial to fix by initializing it. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal_interrupts.c | 2 +- 1 file changed, 1 i

[dpdk-dev] [PATCH v2] devtools: control location of test builds

2019-11-27 Thread Thomas Monjalon
From: Bruce Richardson By default, both test-build.sh and test-meson-builds.sh scripts create the builds they generate in the current working directory, leading to a large number of build directories being present when testing patches. This patchset modifies both scripts to use a DPDK_BUILD_TEST_

Re: [dpdk-dev] [PATCH] devtools: reset compilation flags for each target

2019-11-27 Thread Thomas Monjalon
02/10/2019 18:55, David Marchand: > Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite > useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS > for cross compilation or libraries that won't provide a pkg-config file. > > Fixes: 272236741258 ("devtools: load targe

Re: [dpdk-dev] [PATCH] devtools: check coverity and bugzilla tags

2019-11-27 Thread Thomas Monjalon
09/10/2019 15:43, Kevin Traynor: > On 08/10/2019 16:52, David Marchand wrote: > > Let's try to check for discrepancies in covery and bugzilla tags. > > s/covery/coverity/ - you are trying to fool your patch? :-) > > > The contributing guide specifies that: > > - for coverity issues, the tag is 'C

Re: [dpdk-dev] [PATCH] maintainers: update maintainers for nfp PMD

2019-11-27 Thread Thomas Monjalon
27/11/2019 12:36, Heinrich Kuhn: > As Alejandro is no longer with Netronome we appointed two new > maintainers for the Netronome PMD > > Signed-off-by: Heinrich Kuhn Applied, thanks

Re: [dpdk-dev] [PATCH v2] MAINTAINERS: update armv8 crypto PMD maintainership

2019-11-27 Thread Thomas Monjalon
27/11/2019 09:47, Ruifeng Wang: > It is expected to update this PMD to be in line with Arm's crypto library. > Update the maintainership to refect the change. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > Acked-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH v2 1/4] eal: add API to check if its interrupt context

2019-11-27 Thread Stephen Hemminger
On Wed, 27 Nov 2019 15:52:19 +0530 Sunil Kumar Kori wrote: > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Check if currently executing in interrupt context > + * > + * @return > + * - positive in case of interrupt context > + * - zero in ca

Re: [dpdk-dev] [PATCH] doc: add info about codespell config

2019-11-27 Thread Thomas Monjalon
20/11/2019 14:27, Kevin Traynor: > Document the config to use codespell with checkpatches.sh. > > Signed-off-by: Kevin Traynor > --- > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > -This, and any other configuration variables required by the development

Re: [dpdk-dev] [PATCH v5] doc: clarify virtio PMD path selection

2019-11-27 Thread Thomas Monjalon
27/11/2019 16:19, Yinan: > From: Yinan Wang > > Add virtio paths selection and usage introduction for better > virtio usability. > > Signed-off-by: Yinan Wang > --- > doc/guides/howto/index.rst| 1 + > .../virtio_paths_selection_and_usage.rst | 126 ++

Re: [dpdk-dev] [PATCH V3] doc: add tested Intel platforms with Intel NICs

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:21, Chen, Zhaoyan: > From: Wenjie Li > > V3: > Use symbols from isonum.txt to optimize the doc. > > V2: > Fix some typos. > > V1: > Add tested Intel platforms with Intel NICs to v19.11 release note. > > Signed-off-by: Wenjie Li Applied, thanks Few notes: - changelog should be

Re: [dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

2019-11-27 Thread Thomas Monjalon
27/11/2019 11:58, jer...@marvell.com: > From: Jerin Jacob > > Add tested Marvell integrated NIC platforms to v19.11 release note. > > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH] net/nfp: replace license text with SPDX tag

2019-11-27 Thread Thomas Monjalon
27/11/2019 14:47, Heinrich Kuhn: > On 2019/09/27 10:33, hemant.agrawal at nxp.com (Hemant Agrawal) wrote: > > Signed-off-by: Hemant Agrawal > > Acked-by: Heinrich Kuhn Applied, thanks

  1   2   >