27/11/2019 09:34, Sunil Kumar Kori: > From: Thomas Monjalon <tho...@monjalon.net> > >26/11/2019 07:15, Sunil Kumar Kori: > >> Multiple experimental symbols are used. They must be allowed to avoid > >> compilation error. > > > >If there was an error, > >1/ I would see it in my compilation test 2/ There would be some "Fixes:" tag > >to > >point the root cause > > Actually change is part of below series which is started using experimental > symbols in mentioned driver. > Apart of these drivers, FLAGs are already present in other drivers so that > there is no error found. > Error occurs when applying below series. > > So I had two options to get it done. Either I can do Makefile changes along > with the corresponding changes or > make them as a separate patch. I have chosen second option.
This is the wrong choice :) When you do a change, it should be atomic, i.e. includes changes which are dependent. > And because of this is new change, it does not contain any "Fixes" tag. > > > >I guess this patch is not critical. > >Where are patches 2, 3, 4, 5? > Following are the series of patches: > http://patches.dpdk.org/patch/63299/ > http://patches.dpdk.org/patch/63271/ > http://patches.dpdk.org/patch/63272/ > http://patches.dpdk.org/patch/63273/ > http://patches.dpdk.org/patch/63274/ > Not all the patches are reworked for next versions that's why same is not > reflected in subject line. When you send a new version, you should send the whole series again. And please don't forget changelogs and --in-reply-to. Thanks
