Re: [dpdk-dev] [PATCH 1/2] buildtools: fix experimental symbols listing

2019-11-26 Thread David Marchand
On Mon, Nov 25, 2019 at 2:26 PM Neil Horman wrote: > > On Mon, Nov 25, 2019 at 09:10:06AM +0100, David Marchand wrote: > > The map-list-symbol.sh script displays the filename, section and symbol > > names of map files. > > > > Example: > > $ buildtools/map-list-symbol.sh -S EXPERIMENTAL \ > >

[dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-26 Thread Ali Alnubani
The package pkg-config-aarch64-linux-gnu is required with meson for detecting dependencies installed in nonstandard paths. Signed-off-by: Ali Alnubani --- doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/linux_gsg/cross_bu

[dpdk-dev] [PATCH 1/2] config: set the pkgconfig executable

2019-11-26 Thread Ali Alnubani
Meson fails to find a pkg-config executable if pkgconfig isn't set for aarch64. The environment variable `PKG_CONFIG_PATH` is useless in this case, and meson fails to locate dependencies that are built in non-standard paths. Signed-off-by: Ali Alnubani --- config/arm/arm64_armada_linux_gcc|

[dpdk-dev] [PATCH] build: install missing header files

2019-11-26 Thread Ali Alnubani
The following header files weren't being installed by meson: - rte_vfio.h - rte_function_versioning.h - rte_test.h This patch adds them to the common_headers list so that they are installed. Signed-off-by: Ali Alnubani --- lib/librte_eal/common/meson.build | 5 - 1 file changed, 4 ins

[dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver

2019-11-26 Thread Dekel Peled
Recent patch [1] sets the DV (Direct Verbs) flow engine as default. Newer versions of DV flow engine use the DR (Direct Rules) features. DR is supported from RDMA Core library version rdma-core-24.0. This cause failure to start port when using older rdma-core version, without DR support. This patc

[dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

2019-11-26 Thread Ali Alnubani
The header mlx5_glue.h includes rte_byteorder.h, which isn't pulled by global_inc. This patch adds the missing include directory and fixes the build error: In file included from drivers/net/mlx5/mlx5_glue.c:31: drivers/net/mlx5/mlx5_glue.h:12:10: fatal error: rte_byteorder.h: No such file or

[dpdk-dev] Enable TPH in i40e PMD

2019-11-26 Thread Phil Yang (Arm Technology China)
Hi Qi, I hope this mail finds you well. I am trying to benchmark the TLP Processing Hints (TPH) feature in XL710 NIC i40e PMD on our platform. Our test server supports the TPH identification feature. But It seems that the NIC can't work as expected in TPH enabled mode. I am not sure I did the r

Re: [dpdk-dev] [PATCH 1/3] sched: documentation update

2019-11-26 Thread Thomas Monjalon
29/10/2019 14:19, Jasvinder Singh: > Updates documentation to reflect the changes in the qos scheduler > library. > > Signed-off-by: Jasvinder Singh > --- > .../prog_guide/img/sched_hier_per_port.png| Bin 58973 -> 0 bytes > .../prog_guide/img/sched_hier_per_port.svg| Bin 0 -> 1463490 by

[dpdk-dev] [PATCH] ethdev: fix missed item expansion for RSS flow

2019-11-26 Thread Matan Azrad
When the last item in flow pattern includes "next protocol" field which is relevant for RSS flow expansion, a new item is added to the pattern according to the "next protocol" field. This field is called missed field. The missed field wrongly was not initialized what caused to some of the flow ite

Re: [dpdk-dev] [PATCH 1/3] sched: documentation update

2019-11-26 Thread Thomas Monjalon
29/10/2019 14:19, Jasvinder Singh: > diff --git a/doc/guides/prog_guide/img/sched_hier_per_port.svg > b/doc/guides/prog_guide/img/sched_hier_per_port.svg > new file mode 100644 > index > ..d77ee70a2dd06eedc2c10f44621902921a820806 > GIT binary patch I misse

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver

2019-11-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, November 26, 2019 10:34 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core > ver > > Recent patch

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread Ray Kinsella
My 2c is that it feels a little unweildy to have to annotate, every variable declaration. and also extern reference with __rte_experimental_var. Is there any easier way? Other minor comments below. On 25/11/2019 16:13, David Marchand wrote: > So far, we did not pay attention to direct access

Re: [dpdk-dev] [PATCH] build: install missing header files

2019-11-26 Thread Thomas Monjalon
The title should mention EAL: eal: fix header files install with meson 26/11/2019 09:16, Ali Alnubani: > The following header files weren't being installed by meson: > - rte_vfio.h > - rte_function_versioning.h > - rte_test.h > > This patch adds them to the common_headers list so th

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread David Marchand
On Tue, Nov 26, 2019 at 10:26 AM Ray Kinsella wrote: > > > My 2c is that it feels a little unweildy to have to annotate, every variable > declaration. > and also extern reference with __rte_experimental_var. > > Is there any easier way? We use this framework so that the users are aware they are

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 08:14:25AM +, Ali Alnubani wrote: > The package pkg-config-aarch64-linux-gnu is required with meson for > detecting dependencies installed in nonstandard paths. > > Signed-off-by: Ali Alnubani > --- > doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 8 >

Re: [dpdk-dev] [PATCH] build: install missing header files

2019-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 10:34:11AM +0100, Thomas Monjalon wrote: > The title should mention EAL: > eal: fix header files install with meson > > 26/11/2019 09:16, Ali Alnubani: > > The following header files weren't being installed by meson: > > - rte_vfio.h > > - rte_function_versioning.

[dpdk-dev] [PATCH] example/vhost_crypto: fix incorrect fetch size

2019-11-26 Thread Fan Zhang
Coverity issue: 343401 Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: roy.fan.zh...@intel.com Signed-off-by: Fan Zhang --- examples/vhost_crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_cr

Re: [dpdk-dev] [PATCH 1/3] sched: documentation update

2019-11-26 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 26, 2019 9:17 AM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Mcnamara, John ; Kovacevic, Marko > > Subject: Re: [dpdk-dev] [PATCH 1/3] sched: documentation update > > 29/10/2019 14:19, Jasv

Re: [dpdk-dev] [PATCH] vhost: fix insecure temporary file

2019-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 11:19:00PM +0800, Jin Yu wrote: > When using mkstemp(), remember to safely set the umask > before to restrict the resulting temporary file > permissions to only the owner. > > Coverity issue: 350367 > Fixes: d87f1a1cb7b6 ("vhost: support inflight info sharing") > Cc: sta...

Re: [dpdk-dev] [PATCH] examples/vhost_blk: fix the TOCTOU

2019-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 11:32:14PM +0800, Jin Yu wrote: > Fix the time of check time of use warning in example code > > Coverity issue: 350589 158663 > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: sta...@dpdk.org > > Signed-off-by: Jin Yu > --- > examples/vho

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-26 Thread Ali Alnubani
Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 26, 2019 11:52 AM > To: Ali Alnubani > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu > as a prerequisite > > On Tue, Nov 26, 2019 at 08:14:25AM +, Ali Aln

[dpdk-dev] [PATCH] net/mlx5: fix legacy multi-packet Tx descriptors

2019-11-26 Thread Viacheslav Ovsiienko
ConnectX-4LX supports multiple packets within the single Tx descriptor. This feature is named as "Legacy Multi-Packet Write" and imposes a lot of limitations: - no ACLs, it means no NIC Tx Flows are supported and Tx metadata become meaningless - the required minimal inline data must be zer

[dpdk-dev] [PATCH] net/kni: fix crash caused by double stop

2019-11-26 Thread Ferruh Yigit
'close()' calls 'stop()' and 'stop()' cancels pthread without any check. Calling 'stop()' & 'close()' sequentially tries to cancel pthread twice which will cause a crash. Adding a state check in 'stop()' before canceling the pthread to prevent multiple stop. Fixes: 696fbc7bb4fc ("net/kni: remove

[dpdk-dev] [PATCH v2] eal: fix header files install with meson

2019-11-26 Thread Ali Alnubani
The following header files weren't being installed by meson: - rte_vfio.h - rte_function_versioning.h - rte_test.h This patch adds them to the common_headers list so that they are installed. Fixes: 610beca42ea4 ("build: remove library special cases") Cc: bruce.richard...@intel.com Cc: sta..

Re: [dpdk-dev] [PATCH v2] eal: fix header files install with meson

2019-11-26 Thread Thomas Monjalon
26/11/2019 11:51, Ali Alnubani: > The following header files weren't being installed by meson: > - rte_vfio.h > - rte_function_versioning.h > - rte_test.h > > This patch adds them to the common_headers list so that > they are installed. > > Fixes: 610beca42ea4 ("build: remove library specia

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 8:34 AM, Dekel Peled wrote: > Recent patch [1] sets the DV (Direct Verbs) flow engine as default. > Newer versions of DV flow engine use the DR (Direct Rules) features. > DR is supported from RDMA Core library version rdma-core-24.0. > This cause failure to start port when using older

[dpdk-dev] [PATCH v2] fix lacp check system address

2019-11-26 Thread Vadim
Signed-off-by: Vadim fix lacp check system address --- drivers/net/bonding/rte_eth_bond_8023ad.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index b77a37ddb..d4dda790

[dpdk-dev] [PATCH v2] fix lacp check system address

2019-11-26 Thread Vadim
Signed-off-by: Vadim fix lacp check system address --- drivers/net/bonding/rte_eth_bond_8023ad.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index b77a37ddb..d4dda790

Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite

2019-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 10:41:08AM +, Ali Alnubani wrote: > Hi Bruce, > > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, November 26, 2019 11:52 AM > > To: Ali Alnubani > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ifc: fix unchecked return value

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 6:08 AM, Ye Xiaolong wrote: > On 11/26, Xiao Wang wrote: >> It's possible that we fail to get the IOMMU group of ifcvf device, this >> patch adds a check on the return value. >> >> Coverity issue: 349894 >> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") >> Cc: sta...@dpdk.or

Re: [dpdk-dev] [pull-request] next-eventdev 19.11 RC4

2019-11-26 Thread Thomas Monjalon
26/11/2019 08:03, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks Symbols added in 19.08 section are moved to the new section 20.0.

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver

2019-11-26 Thread Dekel Peled
Thanks, PSB > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 26, 2019 1:29 PM > To: Dekel Peled ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma- > core ver > >

Re: [dpdk-dev] [PATCH] mem: clarify documentation for rte_mem_virt2iova

2019-11-26 Thread Burakov, Anatoly
On 25-Nov-19 11:32 PM, Thomas Monjalon wrote: 18/11/2019 14:14, Olivier Matz: On Thu, Nov 14, 2019 at 02:13:06PM +, Anatoly Burakov wrote: It may not be immediately clear that rte_mem_virt2iova does not actually check the internal memseg table, and will instead either return VA (in IOVA as

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Burakov, Anatoly
On 25-Nov-19 11:24 PM, Thomas Monjalon wrote: 21/11/2019 16:14, Burakov, Anatoly: On 21-Nov-19 2:25 PM, Xueming Li wrote: This patch fixes wrong inner memory element size when joining two elements. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Xueming Li ---

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow engine select by rdma-core ver

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 12:48 PM, Dekel Peled wrote: > Thanks, PSB > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, November 26, 2019 1:29 PM >> To: Dekel Peled ; Matan Azrad >> ; Shahaf Shuler ; Slava >> Ovsiienko >> Cc: Ori Kam ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

2019-11-26 Thread Van Haaren, Harry
Hi Aaron, > -Original Message- > From: Aaron Conole > Sent: Monday, November 25, 2019 10:54 PM > To: Thomas Monjalon > Cc: Van Haaren, Harry ; Amber, Kumar > ; dev@dpdk.org; Wang, Yipeng1 > ; Yigit, Ferruh ; Thakur, > Sham Singh ; David Marchand > > Subject: Re: [dpdk-dev] [PATCH v3] ha

Re: [dpdk-dev] [PATCH] ethdev: fix missed item expansion for RSS flow

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 9:04 AM, Matan Azrad wrote: > When the last item in flow pattern includes "next protocol" field which > is relevant for RSS flow expansion, a new item is added to the pattern > according to the "next protocol" field. This field is called missed > field. > > The missed field wrongly w

Re: [dpdk-dev] [PATCH v2] eal: fix header files install with meson

2019-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2019 at 12:17:41PM +0100, Thomas Monjalon wrote: > 26/11/2019 11:51, Ali Alnubani: > > The following header files weren't being installed by meson: > > - rte_vfio.h > > - rte_function_versioning.h > > - rte_test.h > > > > This patch adds them to the common_headers list so tha

Re: [dpdk-dev] [PATCH v2] fix lacp check system address

2019-11-26 Thread Ferruh Yigit
Hi Vadim, On 11/26/2019 11:55 AM, Vadim wrote: > Signed-off-by: Vadim Can you please provide full "Name Surname " signature? This is bonding patch, please cc bonding maintainers (Chas, instead of John W. Linville). > > fix lacp check system address Can you please give more details, what is

[dpdk-dev] [PATCH v2 1/3] sched: documentation update

2019-11-26 Thread Jasvinder Singh
Updates documentation to reflect the changes in the qos scheduler library. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v2: - fix svg format .../prog_guide/img/sched_hier_per_port.png| Bin 58973 -> 0 bytes .../prog_guide/img/sched_hier_per_port.svg| 492 +++

[dpdk-dev] [PATCH v2 2/3] examples/qos_sched: documentation update

2019-11-26 Thread Jasvinder Singh
Update documentation according to the changes made to qos sample app. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- doc/guides/sample_app_ug/qos_scheduler.rst | 92 +++--- 1 file changed, 81 insertions(+), 11 deletions(-) diff --git a/doc/guides/sample_app_ug

[dpdk-dev] [PATCH v2 3/3] examples/ip_pipeline: documentation update

2019-11-26 Thread Jasvinder Singh
Updates documentation for traffic manager cli as per the changes made to qos scheduler library. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- doc/guides/sample_app_ug/ip_pipeline.rst | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

2019-11-26 Thread Van Haaren, Harry
> -Original Message- > From: Van Haaren, Harry > Sent: Tuesday, November 26, 2019 1:19 PM > To: Aaron Conole ; Thomas Monjalon > > EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service > core > > function call had no effect. > > > > So I'll spend some time in this area,

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Thomas Monjalon
26/11/2019 13:57, Burakov, Anatoly: > On 25-Nov-19 11:24 PM, Thomas Monjalon wrote: > > 21/11/2019 16:14, Burakov, Anatoly: > >> On 21-Nov-19 2:25 PM, Xueming Li wrote: > >>> This patch fixes wrong inner memory element size when joining two > >>> elements. > >>> > >>> Fixes: af75078fece3 ("first pu

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 26, 2019 9:30 PM > To: Burakov, Anatoly > Cc: Xueming(Steven) Li ; dev@dpdk.org; Asaf > Penso ; sta...@dpdk.org; > david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Thomas Monjalon
26/11/2019 14:39, Xueming(Steven) Li: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, November 26, 2019 9:30 PM > > To: Burakov, Anatoly > > Cc: Xueming(Steven) Li ; dev@dpdk.org; Asaf > > Penso ; sta...@dpdk.org; > > david.march...@redhat.com > > Subject: Re: [dpdk

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

2019-11-26 Thread Ferruh Yigit
On 11/25/2019 5:13 PM, Stephen Hemminger wrote: > In order to change RSS parameters, the host requires that RSS > is disable first. > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") > Cc: sta...@dpdk.org > Signed-off-by: Dexuan Cui > Signed-off-by: Stephen Hemminger App

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

2019-11-26 Thread Aaron Conole
"Van Haaren, Harry" writes: >> -Original Message- >> From: Van Haaren, Harry >> Sent: Tuesday, November 26, 2019 1:19 PM >> To: Aaron Conole ; Thomas Monjalon > > > >> > EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service >> core >> > function call had no effect. >> >

[dpdk-dev] [PATCH] net/mlx5: add GENEVE in tunnel offloads cap query

2019-11-26 Thread Suanming Mou
GENEVE is available in tunnel offloads. Add it as the default support option. Signed-off-by: Suanming Mou Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 4 +++- drivers/net/mlx5/mlx5_txq.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/dri

[dpdk-dev] [PATCH] net/mlx5: fix GRE key handle before GRE header issue

2019-11-26 Thread Suanming Mou
When set the GRE item, GRE key should follow after GRE header, or the header gre_item pointer used by the key will be invalid. Currently in the mlx5_flow_validate_item_gre_key() function, the header gre_item pointer is access before checking if the key is after the header or not. Once the key item

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread Neil Horman
On Tue, Nov 26, 2019 at 09:25:49AM +, Ray Kinsella wrote: > > My 2c is that it feels a little unweildy to have to annotate, every variable > declaration. > and also extern reference with __rte_experimental_var. > > Is there any easier way? > Note, just to be clear, its not every variable, o

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread Neil Horman
On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > So far, we did not pay attention to direct access to variables but they > are part of the API/ABI too and should be clearly identified. > > Introduce a __rte_experimental_var tag and mark existing variables. > > Fixes: a4bcd61de82d

Re: [dpdk-dev] [PATCH] add drop statistic for af_packet

2019-11-26 Thread Ferruh Yigit
Hi Vadim, On 11/25/2019 1:41 PM, Vadim wrote: > --- > drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) Please include your sign off, and add some description in the commit log. > > diff --git a/drivers/net/af_packet/rte_eth_af_packet

[dpdk-dev] [PATCH v2] add drop statistic for af_packet

2019-11-26 Thread Vadim
Signed-off-by: Vadim --- drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index f5806bf42..da54f82f7 100644 --- a/drivers/net/af_packet/r

Re: [dpdk-dev] [pull-request] next-crypto 19.11 rc4

2019-11-26 Thread Thomas Monjalon
25/11/2019 13:30, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH v2] add drop statistic for af_packet

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 2:32 PM, Vadim wrote: > Signed-off-by: Vadim Can you please provide full "Name Surname " syntax? > --- > drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c > b/d

Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 10:50 AM, Ferruh Yigit wrote: > 'close()' calls 'stop()' and 'stop()' cancels pthread without any check. > Calling 'stop()' & 'close()' sequentially tries to cancel pthread twice > which will cause a crash. > > Adding a state check in 'stop()' before canceling the pthread to prevent

Re: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

2019-11-26 Thread Thomas Monjalon
26/11/2019 09:35, Ali Alnubani: > The header mlx5_glue.h includes rte_byteorder.h, which isn't > pulled by global_inc. This patch adds the missing include directory > and fixes the build error: > > In file included from drivers/net/mlx5/mlx5_glue.c:31: > drivers/net/mlx5/mlx5_glue.h:12:10: fat

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Burakov, Anatoly
On 26-Nov-19 1:45 PM, Thomas Monjalon wrote: 26/11/2019 14:39, Xueming(Steven) Li: -Original Message- From: Thomas Monjalon Sent: Tuesday, November 26, 2019 9:30 PM To: Burakov, Anatoly Cc: Xueming(Steven) Li ; dev@dpdk.org; Asaf Penso ; sta...@dpdk.org; david.march...@redhat.com Sub

[dpdk-dev] [PATCH] service: don't walk out of bounds when checking services

2019-11-26 Thread Aaron Conole
The service_valid call is used without properly bounds checking the input parameter. Almost all instances of the service_valid call are inside a for() loop that prevents excessive walks, but some of the public APIs don't bounds check and will pass invalid arguments. Prevent this by using SERVICE_

Re: [dpdk-dev] [PATCH] vhost-blk: delete the unused return value

2019-11-26 Thread Maxime Coquelin
On 11/26/19 4:37 PM, Jin Yu wrote: > Coverity issue: 350592 > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: sta...@dpdk.org > > Signed-off-by: Jin Yu > --- > examples/vhost_blk/vhost_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Thomas Monjalon
26/11/2019 14:45, Thomas Monjalon: > 26/11/2019 14:39, Xueming(Steven) Li: > > > > > -Original Message- > > > From: Thomas Monjalon > > > Sent: Tuesday, November 26, 2019 9:30 PM > > > To: Burakov, Anatoly > > > Cc: Xueming(Steven) Li ; dev@dpdk.org; Asaf > > > Penso ; sta...@dpdk.org; >

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy multi-packet Tx descriptors

2019-11-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 26, 2019 12:45 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix legacy multi-packet Tx descriptors > > ConnectX-4LX supports multiple packets within the

Re: [dpdk-dev] [PATCH v2] fix lacp check system address

2019-11-26 Thread podovinnikov
Hi Ferruh This is bonding patch, please cc bonding maintainers (Chas, instead of John W. Linville). Sorry about that. I have 2 patches ( one for af packet, one for bonding). I am a little confused. Can you please give more details, what is failing what is the impact etc. In bond (lacp) we

Re: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

2019-11-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Ali Alnubani > Sent: Tuesday, November 26, 2019 10:35 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage > > The header mlx5_glue.h includes rte_byteorder.h, which isn't > pulled by global_inc. Thi

Re: [dpdk-dev] [PATCH v2 1/3] sched: documentation update

2019-11-26 Thread Thomas Monjalon
26/11/2019 15:28, Jasvinder Singh: > Updates documentation to reflect the changes in the qos scheduler > library. > > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH] net/mlx5: add GENEVE in tunnel offloads cap query

2019-11-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, November 26, 2019 4:06 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: [PATCH] net/mlx5: add GENEVE in tunnel offloads cap query > > GENEVE is available in tunnel offload

Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding

2019-11-26 Thread Thomas Monjalon
21/11/2019 16:14, Burakov, Anatoly: > On 21-Nov-19 2:25 PM, Xueming Li wrote: > > This patch fixes wrong inner memory element size when joining two > > elements. > > > > Fixes: af75078fece3 ("first public release") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Xueming Li > > Reviewed-by: Anato

Re: [dpdk-dev] [PATCH] net/mlx5: fix GRE key handle before GRE header issue

2019-11-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, November 26, 2019 4:09 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org; Jack Min > > Subject: [PATCH] net/mlx5: fix GRE key handle before GRE header issue > > When set the GRE item

[dpdk-dev] [PATCH v3] eal: fix header file install with meson

2019-11-26 Thread Ali Alnubani
The header file 'rte_vfio.h' might be required by some external apps. This patch adds it to the list of common_headers so that it's installed by meson. Fixes: 610beca42ea4 ("build: remove library special cases") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani Revie

Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop

2019-11-26 Thread Wang, Yinan
Test-by :Wang, Yinan > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: 2019年11月26日 22:47 > To: Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop > > On 11/26/2019 10:50 AM, Ferruh Yigit wrote: > > 'close()' call

[dpdk-dev] [PATCH v3] add drop statistic for af_packet

2019-11-26 Thread Vadim Podovinnikov
From: Vadim add drop statistic for af_packet Signed-off-by: Vadim Podovinnikov --- drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c in

Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id

2019-11-26 Thread Aaron Conole
"Van Haaren, Harry" writes: > Hi Aaron, > >> -Original Message- >> From: Aaron Conole >> Sent: Monday, November 25, 2019 10:54 PM >> To: Thomas Monjalon >> Cc: Van Haaren, Harry ; Amber, Kumar >> ; dev@dpdk.org; Wang, Yipeng1 >> ; Yigit, Ferruh ; Thakur, >> Sham Singh ; David Marchand >

Re: [dpdk-dev] [PATCH v3] eal: fix header file install with meson

2019-11-26 Thread Thomas Monjalon
26/11/2019 16:38, Ali Alnubani: > The header file 'rte_vfio.h' might be required by some external apps. > This patch adds it to the list of common_headers so that it's > installed by meson. > > Fixes: 610beca42ea4 ("build: remove library special cases") > Cc: bruce.richard...@intel.com > Cc: sta..

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-26 Thread Nirmal Sarkar
Hello, To support Jumbo frame in dpdk-pktgen, changes were suggested in dpdk libraries also apart from pktgen code. *lib/librte_mbuf/rte_mbuf.h * *lib/common/pg_inet.h * But dpdk framework already supports jumbo frame [using *--enable-jumbo* & *--max-pkt-len* flag]. Can you please help me to un

Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

2019-11-26 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Monday, November 25, 2019 7:29 PM > To: Stephen Hemminger ; dev@dpdk.org; > donald_...@trendmicro.com > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters > > > From: Stephen Hemminger > > Sent: Monday, November 25, 2019 9:13 A

Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

2019-11-26 Thread Dexuan Cui
> From: Stephen Hemminger > Sent: Monday, November 25, 2019 9:13 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; sta...@dpdk.org; > Dexuan Cui > > In order to change RSS parameters, the host requires that RSS > is disable first. > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS para

Re: [dpdk-dev] [PATCH v2 1/5] drivers/octeontx2: allow experimental symbols

2019-11-26 Thread Thomas Monjalon
26/11/2019 07:15, Sunil Kumar Kori: > Multiple experimental symbols are used. They must be allowed > to avoid compilation error. If there was an error, 1/ I would see it in my compilation test 2/ There would be some "Fixes:" tag to point the root cause I guess this patch is not critical. Where ar

Re: [dpdk-dev] [PATCH] examples/ioat: fix possible null dereference

2019-11-26 Thread David Marchand
On Mon, Nov 25, 2019 at 5:48 PM Bruce Richardson wrote: > > When searching for raw devices with the correct type, we check the driver > name using strcmp, without first checking that the call to info get > succeeded and assigned a value to that pointer. > > If the call to get the device info fails

Re: [dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat dequeue

2019-11-26 Thread David Marchand
On Mon, Nov 25, 2019 at 5:23 PM Bruce Richardson wrote: > > On Mon, Nov 25, 2019 at 03:23:03PM +, Bruce Richardson wrote: > > On a failure with the ioat dequeue, -1 is returned, which was not properly > > handled. This could lead to out-of-bounds reads on a later loop which > > assumed a posit

Re: [dpdk-dev] [PATCH] examples/ioat: handle error when querying number of stats

2019-11-26 Thread David Marchand
On Mon, Nov 25, 2019 at 4:36 PM Bruce Richardson wrote: > > To get the amount of memory needed for stats, we call the xstats_get_names > function with a NULL parameter, which can return -1 on error. This negative > value was not previously handled correctly, so we adjust things to quit the > stats

Re: [dpdk-dev] [PATCH v1] doc/power: add commands for core query from VM

2019-11-26 Thread David Marchand
On Fri, Nov 15, 2019 at 1:52 PM David Hunt wrote: > > This patch adds some minor updates for the vm_power_manager and guest_cli > example applications. > > Now that the virtio-serial channels between vm_power manager and > the guest_cli has bi-directional capability, there are some new commands. >

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix typo in EAL programmer's guide

2019-11-26 Thread David Marchand
On Thu, Nov 21, 2019 at 1:39 PM Anatoly Burakov wrote: > > The correct name for virt2memseg API is `rte_mem_virt2memseg`, not > `rte_virt2memseg`. > > Fixes: 950e8fb4e194 ("mem: allow registering external memory areas") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks.

Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture

2019-11-26 Thread Thomas Monjalon
12/11/2019 07:40, Phil Yang (Arm Technology China): > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, November 12, 2019 2:03 PM > > To: Phil Yang (Arm Technology China) > > Cc: Bruce Richardson ; dev@dpdk.org; > > david.march...@redhat.com; jer...@marvell.com; Honnappa N

Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 3:32 AM, Dexuan Cui wrote: >> From: Dexuan Cui >> Sent: Monday, November 25, 2019 7:29 PM >> To: Stephen Hemminger ; dev@dpdk.org; >> donald_...@trendmicro.com >> Cc: sta...@dpdk.org >> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters >> >>> From: Stephen Hemmin

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

2019-11-26 Thread Ferruh Yigit
On 11/26/2019 5:02 PM, Ferruh Yigit wrote: > On 11/26/2019 3:32 AM, Dexuan Cui wrote: >>> From: Dexuan Cui >>> Sent: Monday, November 25, 2019 7:29 PM >>> To: Stephen Hemminger ; dev@dpdk.org; >>> donald_...@trendmicro.com >>> Cc: sta...@dpdk.org >>> Subject: RE: [PATCH] net/netvsc: disable before

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-26 Thread Yasufumi Ogawa
Hi David, Sorry for slow reply. On 2019/11/14 21:27, David Marchand wrote: On Thu, Nov 14, 2019 at 12:42 PM Yasufumi Ogawa wrote: On 2019/11/14 2:01, Burakov, Anatoly wrote: On 13-Nov-19 9:43 PM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a

Re: [dpdk-dev] [PATCH] doc: clarify virtio PMD path selection

2019-11-26 Thread Thomas Monjalon
18/11/2019 11:29, Yinan: ++ > + |Virtio path\ DPDK version | v16.11 | v17.02 | v17.05 | > v17.08 | v17.11 | v18.02 | v18.05 |

Re: [dpdk-dev] [PATCH] ci: add minimal check on testpmd

2019-11-26 Thread Thomas Monjalon
24/11/2019 19:12, Thomas Monjalon: > 24/11/2019 15:17, David Marchand: > > On Fri, Nov 22, 2019 at 5:29 PM Thomas Monjalon wrote: > > > > > > 22/11/2019 16:54, David Marchand: > > > > --- a/.ci/linux-build.sh > > > > +++ b/.ci/linux-build.sh > > > > +if [ "$AARCH64" != "1" ]; then > > > > +./d

Re: [dpdk-dev] [PATCH] doc: add abi policy changes to release notes

2019-11-26 Thread Thomas Monjalon
> > Add some pointers to the releases notes on the changes to the abi policy, > > the introduction of project-level ABI management and the deprecation of > > library-level management. > > > > Signed-off-by: Ray Kinsella > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] usertools: fix bind failed can not regression

2019-11-26 Thread Thomas Monjalon
26/11/2019 07:49, Hui Wei: > nic bind to mlx5_core, enable sriov, nic has one pf and 8 vfs, > bind pf to vfio-pci failed, can not regress to mlx5_core I don't understand what you try to do. For info, mlx5 does not bind to VFIO, but uses a bifurcated driver model.

Re: [dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection

2019-11-26 Thread Thomas Monjalon
02/11/2019 15:23, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Some kernel modules use '-' in their name when registering through > `pci_register_driver` and the same name is populated in > '/sys/bus/pci/drivers/'. > But the kernel always populates modules names replacing '-' with '_' >

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 19.11

2019-11-26 Thread Thomas Monjalon
25/11/2019 13:38, John McNamara: > Fix grammar, spelling and formatting of DPDK 19.11 release notes. > > Signed-off-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel NICs

2019-11-26 Thread Thomas Monjalon
22/11/2019 03:13, Chen, Zhaoyan: > From: Wenjie Li > +* Intel(R) platforms with Intel(R) NICs combinations Thanks to isonum.txt, you can use |reg| or other symbols. > + > + * CPU The first level of items have an extra space (2 spaces per indent is enough) > + > + * Intel(R) Atom(TM) CPU

Re: [dpdk-dev] [PATCH] maintainers: update for raw ifpga

2019-11-26 Thread Thomas Monjalon
28/10/2019 06:47, Xiaolong Ye: > Add raw/ifpga to next-net-intel tree. > > Signed-off-by: Xiaolong Ye Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH] maintainers: update for raw ifpga

2019-11-26 Thread Thomas Monjalon
27/11/2019 00:29, Thomas Monjalon: > 28/10/2019 06:47, Xiaolong Ye: > > Add raw/ifpga to next-net-intel tree. > > > > Signed-off-by: Xiaolong Ye > > Acked-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH] maintainers: replace for AVP driver

2019-11-26 Thread Thomas Monjalon
07/11/2019 21:48, Allain Legacy: > Resigning my maintainership of the AVP driver and adding Steve Webster > as a new maintainer. > > Signed-off-by: Allain Legacy Applied

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of ptpclient example app

2019-11-26 Thread Thomas Monjalon
> > Claim maintainership of examples/ptpclient/ > > > > Signed-off-by: Kirill Rybalchenko > > Thanks for stepping up! > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [dpdk-announce] release candidate 19.11-rc4

2019-11-26 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.11-rc4 93 patches were integrated. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_19_11.html It should be completed with a list of tested hardware. This is the last rel

Re: [dpdk-dev] [PATCH v4] hash: added a new API to hash to query key id

2019-11-26 Thread Wang, Yipeng1
>-Original Message- >From: Amber, Kumar >Sent: Monday, November 25, 2019 6:39 PM >To: dev@dpdk.org >Cc: Wang, Yipeng1 >Subject: [PATCH v4] hash: added a new API to hash to query key id > >Adding new API function to query the maximum key ID >that could possibly be returned by rte_hash_add_k

  1   2   >