On Tue, Nov 26, 2019 at 12:17:41PM +0100, Thomas Monjalon wrote: > 26/11/2019 11:51, Ali Alnubani: > > The following header files weren't being installed by meson: > > - rte_vfio.h > > - rte_function_versioning.h > > - rte_test.h > > > > This patch adds them to the common_headers list so that > > they are installed. > > > > Fixes: 610beca42ea4 ("build: remove library special cases") > > I am not sure this is the right root cause. > At least for rte_function_versioning.h, it has been added recently. >
Thanks for pointing this out. The rte_function_versioning.h file I deliberately omitted from the meson install since it's really for internal use only. It's not really recommended for external app use, since it relies on some DPDK defines etc. > > Cc: bruce.richard...@intel.com > > Cc: sta...@dpdk.org > > > > Signed-off-by: Ali Alnubani <alia...@mellanox.com> > > Reviewed-by: Thomas Monjalon <tho...@monjalon.net> > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > > >