[dpdk-dev] [PATCH] net/mlx5: fix vport index in port action

2019-11-17 Thread Viacheslav Ovsiienko
The rdma_core routine mlx5dv_dr_create_flow_action_dest_vport() requires the vport id parameter to create port action. The register c[0] value was used to deduce the port id value and it fails in bonding configuration. The correct way is to apply vport_num value queried from the rdma_core library.

[dpdk-dev] [PATCH v2] net/mlx5: fix flow table hash list conversion

2019-11-17 Thread Matan Azrad
For the case when DR is not supported and DV is supported: multi-tables feature is off. In this case, only table 0 is supported. Table 0 structure wrongly was not created what prevented any matcher object to be created and even caused crashes. Create the table hash

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix flow table hash list conversion

2019-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Sunday, November 17, 2019 2:15 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Bing Zhao > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix flow table hash list conversion > > For the case when DR is not supported and DV

Re: [dpdk-dev] [PATCH] net/mlx5: fix vport index in port action

2019-11-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Sunday, November 17, 2019 10:48 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix vport index in port action > > The rdma_core routine mlx5dv_dr_create_flow_action_dest_vp

[dpdk-dev] [PATCH v15 0/2] kni: support IOVA mode

2019-11-17 Thread David Marchand
Sending this to track the changes I did on the v14 patchset from Vamsi. Changelog since v14: - reworded commitlogs, - added missing documentation update, - fixed release notes, -- David Marchand Vamsi Attunuru (2): kni: support userspace VA eal/linux: remove KNI restriction on IOVA .../pr

[dpdk-dev] [PATCH v15 2/2] eal/linux: remove KNI restriction on IOVA

2019-11-17 Thread David Marchand
From: Vamsi Attunuru Now that KNI supports VA (with kernel versions starting 4.6.0), we can accept IOVA as VA, but KNI must be configured for this. Pass iova_mode when creating KNI netdevs. So far, IOVA detection policy forced IOVA as PA when KNI is loaded, whatever the buses IOVA requirements w

[dpdk-dev] [PATCH v15 1/2] kni: support userspace VA

2019-11-17 Thread David Marchand
From: Vamsi Attunuru Patch adds support for kernel module to work in IOVA = VA mode by providing address translation routines to convert userspace VA to kernel VA. KNI performance using PA is not changed by this patch. But comparing KNI using PA to KNI using VA, the latter will have lower perfor

[dpdk-dev] [PATCH] app/testpmd: report invalid command line parameter

2019-11-17 Thread David Marchand
We currently do not check that a non option string has been passed to testpmd. Example: $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf 2048 [...] testpmd> show config fwd io packet forwarding - ports=2 - cores=1 - streams=2 - N

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: report invalid command line parameter

2019-11-17 Thread David Marchand
On Sun, Nov 17, 2019 at 6:10 PM David Marchand wrote: > After this patch: > $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ > --vdev net_null1 -- -i -nb-cores=2 --total-num-mbuf 2048 Sorry wrong example, s/-nb-cores/nb-cores/ > [...] > Invalid parameter: nb-cores=2 > EAL: Erro

[dpdk-dev] [PATCH] eal: check for interrupt context

2019-11-17 Thread Harman Kalra
Added an API to check if current execution is in interrupt context. This will be helpful to handle nested interrupt cases. Signed-off-by: Harman Kalra --- lib/librte_eal/common/include/rte_interrupts.h | 13 + lib/librte_eal/freebsd/eal/eal_interrupts.c| 8 lib/librte_e

Re: [dpdk-dev] [PATCH] eal: check for interrupt context

2019-11-17 Thread Stephen Hemminger
On Sun, 17 Nov 2019 19:36:11 + Harman Kalra wrote: > +int rte_thread_is_intr(void) > +{ > + if (pthread_equal(intr_thread, pthread_self())) > + return true; > + else > + return false; > +} A couple of things here. 1. true/false implies that this is of type bo

Re: [dpdk-dev] [PATCH] eal: check for interrupt context

2019-11-17 Thread Stephen Hemminger
On Sun, 17 Nov 2019 19:36:11 + Harman Kalra wrote: > Added an API to check if current execution is in interrupt > context. This will be helpful to handle nested interrupt cases. > > Signed-off-by: Harman Kalra Please add a user of this routine. Unused code is added burden.

[dpdk-dev] [PATCH v3] net/ice: add flow mark hint support

2019-11-17 Thread Qi Zhang
Since not all data paths support flow mark, the driver need a hint from application to select the correct data path if flow mark is required. The patch introduce a devarg "flow-mark-support" as a workaround solution, since a standard way is still ongoing. Signed-off-by: Qi Zhang --- v3: - add "e

[dpdk-dev] [PATCH] doc: clarify virtio PMD path selection

2019-11-17 Thread Yinan
From: Yinan Wang add virtio paths selection and usage introduction for better virtio usability. Signed-off-by: Yinan Wang --- .../virtio_paths_selection_and_usage.rst | 130 ++ 1 file changed, 130 insertions(+) create mode 100644 doc/guides/howto/virtio_paths_selection_an

[dpdk-dev] [PATCH v3] net/ixgbe: fix link status

2019-11-17 Thread Lunyuan Cui
After ports reset, tx laser register will be reset. The link status for 82599eb got from link status register was not correct. Set tx laser disable when port resets. ixgbe_flap_tx_laser_multispeed_fiber() can cause link status change from down to up. This treatment should work after port starts.

Re: [dpdk-dev] [PATCH] doc: clarify virtio PMD path selection

2019-11-17 Thread Stephen Hemminger
On Mon, 18 Nov 2019 05:29:23 -0500 Yinan wrote: > From: Yinan Wang > > add virtio paths selection and usage introduction for better > virtio usability. > > Signed-off-by: Yinan Wang > --- Nice to have this documented. Do you think it would make sense to link to the virtio standard that defi

Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update

2019-11-17 Thread Ye Xiaolong
On 11/15, Lunyuan Cui wrote: >Unassigned variable should not be used as judgment, and there >is no need to update link status according to old link status. >This patch fix the issue. > >Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") >Cc: sta...@dpdk.org > >Signed-off-by: Lunyua

Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update

2019-11-17 Thread Cui, LunyuanX
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Monday, November 18, 2019 11:07 AM > To: Cui, LunyuanX > Cc: dev@dpdk.org; Lu, Wenzhuo ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update > > On 11/15, Lunyuan Cui wrote: > >Unassigned

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix link status

2019-11-17 Thread Ye Xiaolong
On 11/18, Lunyuan Cui wrote: >After ports reset, tx laser register will be reset. The link >status for 82599eb got from link status register was not correct. >Set tx laser disable when port resets. Above message is unclear to me, what's the relation between tx laser register and link status regist

Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update

2019-11-17 Thread Ye Xiaolong
On 11/18, Cui, LunyuanX wrote: >Hi, Xiaolong > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Monday, November 18, 2019 11:07 AM >> To: Cui, LunyuanX >> Cc: dev@dpdk.org; Lu, Wenzhuo ; >> sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update >> >> O

[dpdk-dev] [PATCH] doc: add matching list for ice

2019-11-17 Thread Qi Zhang
Add kernel driver, firmware and DDP package matching list for ice PMD. Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 1a426438d..7ff33d7f0 100644 --- a/doc/guides/

[dpdk-dev] [PATCH] net/ice/base: update base code version info

2019-11-17 Thread Qi Zhang
Update base code version info in readme. Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 708f60793..88548296d 100644 --- a/drivers/net/ice/base/README +++ b

Re: [dpdk-dev] [PATCH] net/ice/base: update base code version info

2019-11-17 Thread Ye Xiaolong
On 11/18, Qi Zhang wrote: >Update base code version info in readme. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/base/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README >index 708f60793..88548296d 100644 >---

Re: [dpdk-dev] [PATCH] doc: add matching list for ice

2019-11-17 Thread Ye Xiaolong
On 11/18, Qi Zhang wrote: >Add kernel driver, firmware and DDP package matching list >for ice PMD. > >Signed-off-by: Qi Zhang >--- > doc/guides/nics/ice.rst | 18 ++ > 1 file changed, 18 insertions(+) > >diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst >index 1a426438d

Re: [dpdk-dev] [PATCH v3] net/ice: add flow mark hint support

2019-11-17 Thread Yang, Qiming
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Monday, November 18, 2019 8:43 AM > To: Yang, Qiming ; Cao, Yahui > ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v3] net/ice: add flow mark hint support > > Since not all data paths support flow mark, the driver n

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-11-17 Thread Hideyuki Yamashita
Hi Slava, Thanks for your response. 1. Is the bug number is the follwoing? https://bugs.dpdk.org/show_bug.cgi?id=96 2.I've sent packets using scapy with the follwing script and I think it is unicast ICMP. How did you thought the packets are broadcast/muticast? Note that I am not familiar with l

[dpdk-dev] [PATCH v3] net/ice: fix FDIR flow type conflict

2019-11-17 Thread Qi Zhang
Flow type "IPv4 + UDP" or "IPv4 + TCP" is conflict with "IPv4 + any" flow type. If a rule for IPv4 + any is created, we should reject any rule for IPv4 + UDP otherwise the first rule may be impacted, same decision should be made on a reverse order. For IPv6 and IPv4 GTPU inner case, we have the sam

[dpdk-dev] [PATCH v3] net/e1000: fix link status update

2019-11-17 Thread Lunyuan Cui
Unassigned variable should not be used as judgment, and there is no need to update link status according to old link status. This patch fix the issue. Change the variable from link_check to link_up. Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") Cc: sta...@dpdk.org Signed-of

Re: [dpdk-dev] [PATCH] fips_validation: fix auth verify

2019-11-17 Thread Akhil Goyal
Hi Marko, Could you please ack this patch if no issues. > > Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing") > Cc: marko.kovace...@intel.com > Cc: sta...@dpdk.org > > This patch fixes the incorrect mbuf write and digest memory leak in > fips_validation authentication verif

Re: [dpdk-dev] [PATCH v3] net/e1000: fix link status update

2019-11-17 Thread Ye Xiaolong
Hi, wenzhuo Could you help ack this patch if you are ok with this change? Thanks, Xiaolong On 11/18, Lunyuan Cui wrote: >Unassigned variable should not be used as judgment, and there >is no need to update link status according to old link status. >This patch fix the issue. > >Change the variable

[dpdk-dev] [PATCH v2] eal: add API to check if its interrupt context

2019-11-17 Thread Harman Kalra
Added an API to check if current execution is in interrupt context. This will be helpful to handle nested interrupt cases. Signed-off-by: Harman Kalra --- V2: * Removed unnecessary if statement. * Reworded subject line * Updated return values of API lib/librte_eal/common/include/rte_interrupts.

[dpdk-dev] [PATCH v4] net/ixgbe: fix link status

2019-11-17 Thread Lunyuan Cui
The link status for 82599eb got from link status register was not correct. Check the enable/disable flag of tx laser, set the link status down if tx laser disabled. Then, we can get correct status. But after port reset, tx laser register will be reset enable. Link status will always be up. So set t

Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-11-17 Thread Akhil Goyal
Hi Dharmik, As per the recent communication with Honnappa on a separate mail chain, ARM has agreed to Host the armv8_crypto library. If it is happening in 19.11 timeframe, we should rebase this patch And add documentation for changed location of the repo and if it is not in 19.11 timeframe we

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: update default configuration

2019-11-17 Thread Akhil Goyal
> > @Akhil, do we need this submitted to dpdk-stable? > Yes this is a candidate for stable. > Acked-by: Anoob Joseph > Acked-by: Akhil Goyal Fixed title and tagged for stable. Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] examples/ipsec-segw: add SPDX license tag

2019-11-17 Thread Akhil Goyal
> > Signed-off-by: Stephen Hemminger > > --- > > examples/ipsec-secgw/test/bypass_defs.sh | 1 + > > examples/ipsec-secgw/test/common_defs.sh | 1 + > > examples/ipsec-secgw/test/common_defs_secgw.sh | 1 + > > examples/ipsec-secgw/tes