[dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process

2019-11-15 Thread David Marchand
On Thu, Nov 14, 2019 at 8:32 PM Kevin Traynor wrote: > > On 12/11/2019 20:31, David Marchand wrote: > > From: Krzysztof Kanas > > > > Caught while investigating timeouts on a ARM64 server. > > > > Stracing a test process running the eal_flags_autotest, we can see that > > the fork helper is check

Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptp configurations for VF

2019-11-15 Thread Jerin Jacob
On Mon, Nov 11, 2019 at 11:19 AM Harman Kalra wrote: > > Issue has been observed if PTP is already enabled on PF and > later VFs are configured. Since PTP requires mbuf data off > to be shifted by 8 bytes, due to this l3fwd/l2fwd was not > working with VFs. > Also some extra garbage bytes were obs

Re: [dpdk-dev] [PATCH 1/2] mempool: use actual IOVA addresses when populating

2019-11-15 Thread Olivier Matz
On Thu, Nov 14, 2019 at 01:58:20PM +, Anatoly Burakov wrote: > Currently, when mempool is being populated, we get IOVA address > of every segment using rte_mem_virt2iova(). This works for internal > memory, but does not really work for external memory, and does not > work on platforms which ret

Re: [dpdk-dev] [PATCH 2/2] mempool: remove check for bad IOVA when populating

2019-11-15 Thread Olivier Matz
On Thu, Nov 14, 2019 at 01:58:21PM +, Anatoly Burakov wrote: > Currently, mempool will check if IOVA is bad for a segment, and reject > the IOVA if hugepages are also enabled. This check is wrong because now > that we have external memory segments, they are allowed to have their > IOVA's to be

Re: [dpdk-dev] [PATCH v2] doc: add oss-security to the security process

2019-11-15 Thread David Marchand
On Fri, Sep 27, 2019 at 9:21 AM Maxime Coquelin wrote: > On 9/21/19 4:52 PM, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > The OSS-security project functions as a single point of contact for > > pre-release, embargoed security notifications. Distributions and major > > vendors ar

Re: [dpdk-dev] [PATCH] doc: fix internal links for older releases

2019-11-15 Thread David Marchand
On Thu, Oct 10, 2019 at 12:57 AM Stephen Hemminger wrote: > On Tue, 8 Oct 2019 11:47:36 +0200 > David Marchand wrote: > > > Using external explicit references to http://doc.dpdk.org makes older > > releases documentation point to the current master documentation pages. > > Switch to internal ref

Re: [dpdk-dev] [PATCH] ethdev: fix missing new line token at end of line

2019-11-15 Thread Ferruh Yigit
On 11/14/2019 7:31 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Fix missing new line token at the end of log. > > Fixes: 5d308972954 ("ethdev: add mbuf RSS update as an offload") > > Signed-off-by: Pavan Nikhilesh Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master,

Re: [dpdk-dev] [PATCH] doc: fix address type description for IOAT rawdev

2019-11-15 Thread David Marchand
On Thu, Oct 17, 2019 at 3:48 PM Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 08:01:47PM -0400, Xiao Wang wrote: > > Align the description to what the code snippet shows. > > > > Fixes: 0a92e63fc4cd ("raw/ioat: add local API to perform copies") Cc: sta...@dpdk.org > > > > Signed-off-by: Xiao

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR programming status check issue

2019-11-15 Thread Ferruh Yigit
On 11/14/2019 7:23 AM, Ye Xiaolong wrote: > On 11/14, Yahui Cao wrote: >> To make sure if FDIR programming succeed or fail, legacy programming >> status descriptor WB format is enabled and FDIR queue irq is opened. >> >> Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") >> Cc: beilei.x..

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: fix link to AESNI mb external library

2019-11-15 Thread David Marchand
On Tue, Nov 12, 2019 at 8:31 PM David Marchand wrote: > > Add missing _. > > Fixes: 2977a13657ab ("doc: fix AESNI_MB guide") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied. -- David Marchand

[dpdk-dev] rte_eal_init() behavior

2019-11-15 Thread Bao-Long Tran
Hi, In most of the examples, the argc and argv from main are passed directly to rte_eal_init(). This has the implication that argv[0] is the program name. When a user crafts his own argv, he must submit a placeholder at argv[0] as well, or else the EAL parameters won't be parsed correctly. Below

Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-15 Thread Andrew Rybchenko
Hi Stephen, On 11/14/19 7:56 PM, Stephen Hemminger wrote: On Thu, 14 Nov 2019 16:40:50 + Andrew Rybchenko wrote: By default RSS hash delivery (offload) is bound to RSS mode and it is incorrect to advertise it as enabled if Rx multi-queue mode has no RSS. Fixes: 8b945a7f7dcb ("drivers/net

Re: [dpdk-dev] [PATCH v18 13/19] raw/ifpga/base: add secure support

2019-11-15 Thread Ferruh Yigit
On 11/14/2019 11:05 PM, Zhang, Tianfei wrote: > >> -Original Message- >> From: Xu, Rosen >> Sent: Thursday, November 14, 2019 5:03 PM >> To: dev@dpdk.org >> Cc: Xu, Rosen ; Zhang, Tianfei ; >> Pei, Andy ; Ye, Xiaolong ; Yigit, >> Ferruh >> Subject: [PATCH v18 13/19] raw/ifpga/base: add se

Re: [dpdk-dev] [PATCH 1/2] mempool: use actual IOVA addresses when populating

2019-11-15 Thread Burakov, Anatoly
On 15-Nov-19 8:46 AM, Olivier Matz wrote: On Thu, Nov 14, 2019 at 01:58:20PM +, Anatoly Burakov wrote: Currently, when mempool is being populated, we get IOVA address of every segment using rte_mem_virt2iova(). This works for internal memory, but does not really work for external memory, and

Re: [dpdk-dev] [PATCH v4] net/octeontx2: add set supported types op

2019-11-15 Thread Jerin Jacob
On Thu, Nov 7, 2019 at 8:23 AM wrote: > > From: Pavan Nikhilesh > > Add support to set supported ptypes for octeontx2. Added extra git commit log: Add support to set supported ptypes for octeontx2 and remove devarg scheme to disable ptype parsing support as application can use rte_e

[dpdk-dev] [PATCH] devtools: fix example build with old pkg-config

2019-11-15 Thread Ferruh Yigit
The old version of the pkg-config [1] doesn't support '-define-prefix' and '--path' arguments which is causing failure building the examples [2]. Added checks for pkg-config arguments support and build examples only if they are supported. [1] CentOS Linux release 7.7.1908 (Core) pkg-config versio

Re: [dpdk-dev] [PATCH] doc/guides: clean repeated words

2019-11-15 Thread David Marchand
On Wed, Nov 13, 2019 at 11:47 AM Kevin Traynor wrote: > > On 12/11/2019 19:33, David Marchand wrote: > > Shoot repeated words in all our guides. Cc: sta...@dpdk.org > > > > Signed-off-by: David Marchand > > Can add 'Cc: sta...@dpdk.org' and whatever applies applies. > > Acked-by: Kevin Traynor

Re: [dpdk-dev] [PATCH] devtools: fix example build with old pkg-config

2019-11-15 Thread Bruce Richardson
On Fri, Nov 15, 2019 at 10:35:25AM +, Ferruh Yigit wrote: > The old version of the pkg-config [1] doesn't support '-define-prefix' > and '--path' arguments which is causing failure building the > examples [2]. > Yes for the define-prefix option, no for the path one. The define-prefix argumen

[dpdk-dev] [PATCH v13 0/2] kni: support IOVA mode

2019-11-15 Thread vattunuru
From: Vamsi Attunuru --- V13 Changes: * For KNI case, to restore the existing behaviour, forcing IOVA as PA if bus iommu returns IOVA_DC. * Restored phys_addr and kni_lib defination checks. * Simplified patch titles. * Updated documentation about patch set's impact on performance and kernel versi

[dpdk-dev] [PATCH v13 1/2] kni: support IOVA mode in kernel module

2019-11-15 Thread vattunuru
From: Vamsi Attunuru Patch adds support for kernel module to work in IOVA = VA mode by providing address translation routines to convert IOVA aka user space VA to kernel virtual addresses. When compared with IOVA = PA mode, KNI netdev ports does not have any impact on performance with this appro

[dpdk-dev] [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread vattunuru
From: Vamsi Attunuru Current KNI implementation only operates in IOVA_PA mode patch adds required functionality to enable KNI in IOVA_VA mode. KNI loopback mode tests will have performance impact in this mode due to IOVA to KVA address translations. However, In KNI real world use cases, the perf

Re: [dpdk-dev] [PATCH] doc: update release notes for AESNI PMDs

2019-11-15 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, November 14, 2019 1:51 PM > To: De Lara Guarch, Pablo ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: update release notes for AESNI PMDs > > Hi Pablo, > > > AESNI MB and AESNI GCM

[dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell write memory barrier

2019-11-15 Thread Viacheslav Ovsiienko
As the result of testing it was found that some hosts have the performance penalty imposed by required write memory barrier after doorbell writing. Before 19.08 release there was some heuristics to decide whether write memory barrier should be performed. For the bursts of recommended size (or multi

[dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
The name in rte_kni_device_info is passed to the kernel, which allows interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a longer name currently trigger a kernel BUG in alloc_netdev_mqs in net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. Signed-off-by: Michael P

Re: [dpdk-dev] [PATCH] app/testpmd: fix cleanup of Tx metadata offload

2019-11-15 Thread Iremonger, Bernard
> -Original Message- > From: Dekel Peled > Sent: Thursday, November 14, 2019 1:59 PM > To: Mcnamara, John ; Kovacevic, Marko > ; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard > > Cc: dev@dpdk.org; viachesl...@mellanox.com > Subject: [PATCH] app/testpmd: fix cleanup of Tx metadata offl

Re: [dpdk-dev] [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 11:18 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Current KNI implementation only operates in IOVA_PA mode > patch adds required functionality to enable KNI in > IOVA_VA mode. > > KNI loopback mode tests will have performance impact in > this mode due to IOVA to KVA

Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled

2019-11-15 Thread Liang, Ma
Hi Mattias, On 14 Nov 15:10, Mattias Rönnblom wrote: > Calling pstate's or acpi's rte_power_freq_up() when on the highest > non-turbo frequency results in an error, if turbo is disabled. The > error is in the form of a return code and a RTE_LOG() entry on the ERR > level. > > According to the API

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Igor Ryzhov
Hi Michael, Isn't it better to set it to IFNAMSIZ instead of 16? Best regards, Igot On Fri, Nov 15, 2019 at 2:41 PM Michael Pfeiffer < michael.pfeif...@tu-ilmenau.de> wrote: > The name in rte_kni_device_info is passed to the kernel, which allows > interface names with at most 16 bytes (IFNAMSIZ

Re: [dpdk-dev] [PATCH v18 13/19] raw/ifpga/base: add secure support

2019-11-15 Thread Zhang, Tianfei
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, November 15, 2019 5:54 PM > To: Zhang, Tianfei ; Xu, Rosen ; > dev@dpdk.org > Cc: Pei, Andy ; Ye, Xiaolong > Subject: Re: [PATCH v18 13/19] raw/ifpga/base: add secure support > > On 11/14/2019 11:05 PM, Zhang, Tianfei wrote: > >

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 12:30 PM, Igor Ryzhov wrote: > Hi Michael, > > Isn't it better to set it to IFNAMSIZ instead of 16? I was thinking same, but "linux/if.h" included only for kernel, so instead of introducing new dependency in user side, perhaps better to keep it as hardcoded value. > > Best regards

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
Hi Igor, you're right, RTE_KNI_NAMESIZE == IFNAMSIZ is the intention. However, to my understanding linux/if.h (where IFNAMSIZ is defined) is only included when building kernel code. I thought maybe this was intentional to keep rte_kni_common.h free of Linux kernel dependencies (when building userla

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 12:43 PM, Michael Pfeiffer wrote: > Hi Igor, > you're right, RTE_KNI_NAMESIZE == IFNAMSIZ is the intention. However, > to my understanding linux/if.h (where IFNAMSIZ is defined) is only > included when building kernel code. I thought maybe this was > intentional to keep rte_kni_common

Re: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups

2019-11-15 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Friday, November 8, 2019 4:47 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups > > These are a couple of small cleanups for 19.10 which came out of work on > pcapn

[dpdk-dev] [PATCH v1] doc/power: add commands for core query from VM

2019-11-15 Thread David Hunt
This patch adds some minor updates for the vm_power_manager and guest_cli example applications. Now that the virtio-serial channels between vm_power manager and the guest_cli has bi-directional capability, there are some new commands. Firstly, the command in vm_power_manager to enable queries for

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
Hi Ferruh, On Fri, 2019-11-15 at 12:49 +, Ferruh Yigit wrote: > On 11/15/2019 12:43 PM, Michael Pfeiffer wrote: > > Hi Igor, > > you're right, RTE_KNI_NAMESIZE == IFNAMSIZ is the intention. > > However, > > to my understanding linux/if.h (where IFNAMSIZ is defined) is only > > included when bu

Re: [dpdk-dev] [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread David Marchand
I can't see an interest in splitting this patch from the kmod update. Ferruh, what do you think? On Fri, Nov 15, 2019 at 12:19 PM wrote: > > From: Vamsi Attunuru > > Current KNI implementation only operates in IOVA_PA mode > patch adds required functionality to enable KNI in > IOVA_VA mode. > >

[dpdk-dev] [PATCH v2] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
The name in rte_kni_device_info is passed to the kernel, which allows interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a longer name currently trigger a kernel BUG in alloc_netdev_mqs in net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. Signed-off-by: Michael P

Re: [dpdk-dev] [PATCH v1] doc/power: add commands for core query from VM

2019-11-15 Thread Mcnamara, John
> -Original Message- > From: Hunt, David > Sent: Friday, November 15, 2019 12:51 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Hunt, David > > Subject: [PATCH v1] doc/power: add commands for core query from VM > Acked-by: John McNamara

Re: [dpdk-dev] [PATCH v2] kni: reduce interface name size

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 1:03 PM, Michael Pfeiffer wrote: > The name in rte_kni_device_info is passed to the kernel, which allows > interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a > longer name currently trigger a kernel BUG in alloc_netdev_mqs in > net/core/dev.c. Reduce RTE_KNI_NAMESI

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-15 Thread David Marchand
On Fri, Nov 15, 2019 at 5:14 AM Tiwei Bie wrote: > > On Thu, Nov 14, 2019 at 09:52:30AM +0100, Maxime Coquelin wrote: > > Maybe change the title to something like: > > > > vhost: fix vring requests validation broken if no FD in payload For the title, aligning to backport patches: "vhost: fix vrin

Re: [dpdk-dev] [EXT] Re: [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread Vamsi Krishna Attunuru
> -Original Message- > From: David Marchand > Sent: Friday, November 15, 2019 6:29 PM > To: Vamsi Krishna Attunuru ; Yigit, Ferruh > > Cc: dev ; Thomas Monjalon ; Jerin > Jacob Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Olivier Matz ; > Burakov, Anatoly ; Andrew Rybchenko > ; Stephen H

[dpdk-dev] MLX5 NIC: net_mlx5: port 0 cannot enable promiscuous mode: Cannot allocate memory

2019-11-15 Thread vikram T
Hi, I am facing an issue with mlx5 with error in "promiscous mode" in MLX5 NIC card. The Application initializes successfully and the traffic/packets are not processed. Error Snippet Below: Nov 12 09:28:09 OCOM-PROBE-2 systemd: Stopped OCSM Media Sniffer. Nov 12 09:28:09 OCOM-PROBE-2 systemd: Star

Re: [dpdk-dev] [EXT] Re: [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread David Marchand
On Fri, Nov 15, 2019 at 2:36 PM Vamsi Krishna Attunuru wrote: > > > > -Original Message- > > From: David Marchand > > Sent: Friday, November 15, 2019 6:29 PM > > To: Vamsi Krishna Attunuru ; Yigit, Ferruh > > > > Cc: dev ; Thomas Monjalon ; Jerin > > Jacob Kollanukkaran ; Kiran Kumar Kok

Re: [dpdk-dev] [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread Jerin Jacob
On Fri, Nov 15, 2019 at 6:29 PM David Marchand wrote: > > I can't see an interest in splitting this patch from the kmod update. > Ferruh, what do you think? > > > On Fri, Nov 15, 2019 at 12:19 PM wrote: > > > > From: Vamsi Attunuru > > > > Current KNI implementation only operates in IOVA_PA mode

Re: [dpdk-dev] [PATCH v4] net/octeontx2: add set supported types op

2019-11-15 Thread Ferruh Yigit
On 11/7/2019 2:52 AM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add support to set supported ptypes for octeontx2. > > Signed-off-by: Pavan Nikhilesh <...> > @@ -62,6 +62,21 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) > return NULL; > } > >

Re: [dpdk-dev] [EXT] Re: [PATCH v4] net/octeontx2: add set supported types op

2019-11-15 Thread Pavan Nikhilesh Bhagavatula
>On 11/7/2019 2:52 AM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add support to set supported ptypes for octeontx2. >> >> Signed-off-by: Pavan Nikhilesh > ><...> > >> @@ -62,6 +62,21 @@ otx2_nix_supported_ptypes_get(struct >rte_eth_dev *eth_dev) >> return NULL; >

[dpdk-dev] [dpdk-announce] DPDK 17.11.9 (LTS) released

2019-11-15 Thread Luca Boccassi
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-17.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=17.11 This release fixes an errata in the previous 17.11.8 release that caused a regression with vhost. The fix was tested by Intel via the

[dpdk-dev] [dpdk-announce] DPDK 16.11.11 released

2019-11-15 Thread Luca Boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-16.11.11.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=16.11 This release fixes an errata in the previous 16.11.10 release that caused a regression with vhost. The fix was tested by Intel vi

Re: [dpdk-dev] [EXT] Re: [PATCH] mk: add support for UBSAN

2019-11-15 Thread Harman Kalra
On Mon, Nov 11, 2019 at 08:07:00AM +0100, Thomas Monjalon wrote: > External Email > > -- > Hi, > > Sorry for the very late review. > I hope someone else would try it. > > I tried this: > devtools/test-build.sh -v x86_64-native-l

[dpdk-dev] [PATCH v2] mk: add support for UBSAN

2019-11-15 Thread Harman Kalra
UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior detector. UBSan modifies the program at compile-time to catch various kinds of undefined behavior during program execution. This patch introduces support for UBSan to the DPDK. See: doc/guides/prog_guide/ubsan.rst for more informatio

Re: [dpdk-dev] [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread David Marchand
On Fri, Nov 15, 2019 at 2:40 PM Jerin Jacob wrote: > On Fri, Nov 15, 2019 at 6:29 PM David Marchand > wrote: > > So far, KNI could not work with IOVA as VA. > > Your patchset adds support for IOVA as VA if kernel is >= 4.6. > > We need achive the following. > > IOVA as PA has performance implica

Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 9:41 AM, Andrew Rybchenko wrote: > Hi Stephen, > > On 11/14/19 7:56 PM, Stephen Hemminger wrote: >> On Thu, 14 Nov 2019 16:40:50 + >> Andrew Rybchenko wrote: >> >>> By default RSS hash delivery (offload) is bound to RSS mode and >>> it is incorrect to advertise it as enabled if

Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-15 Thread Ferruh Yigit
On 11/14/2019 4:40 PM, Andrew Rybchenko wrote: > By default RSS hash delivery (offload) is bound to RSS mode and > it is incorrect to advertise it as enabled if Rx multi-queue mode > has no RSS. > > Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") > > Signed-off-by: An

[dpdk-dev] [PATCH v2 0/2] support older pkg-config

2019-11-15 Thread Bruce Richardson
Not all pkg-config installs support --define-prefix and --path flags, so ensure we can still build examples without those flags, and that we don't get errors when using test-meson-builds.sh with/without those flags. Bruce Richardson (2): devtools: fix example builds with older pkg-config examp

[dpdk-dev] [PATCH v2 2/2] examples: suppress errors for missing pkg-config path flag

2019-11-15 Thread Bruce Richardson
Some versions of pkg-config don't support the --path flag, which is not a fatal error when building the apps. Without the flag, the makefile just cannot track the .pc file of DPDK as a dependency of the build. Therefore, we can ignore the error and suppress it by redirecting to /dev/null the stderr

[dpdk-dev] [PATCH v2 1/2] devtools: fix example builds with older pkg-config

2019-11-15 Thread Bruce Richardson
Not all versions of pkg-config in distros have support for the --define-prefix flag [1], causing errors when building examples manually or with test-meson-builds.sh script [2]. For the former case, we need to remove the hard-coded use of the flag in the Makefiles. For the latter case, the flag is

Re: [dpdk-dev] [PATCH v13 2/2] kni: support IOVA mode

2019-11-15 Thread Jerin Jacob
On Fri, Nov 15, 2019 at 8:27 PM David Marchand wrote: > > On Fri, Nov 15, 2019 at 2:40 PM Jerin Jacob wrote: > > On Fri, Nov 15, 2019 at 6:29 PM David Marchand > > wrote: > > > So far, KNI could not work with IOVA as VA. > > > Your patchset adds support for IOVA as VA if kernel is >= 4.6. > > >

[dpdk-dev] [PATCH v3] mk: add support for UBSAN

2019-11-15 Thread Harman Kalra
UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior detector. UBSan modifies the program at compile-time to catch various kinds of undefined behavior during program execution. This patch introduces support for UBSan to the DPDK. See: doc/guides/prog_guide/ubsan.rst for more informatio

Re: [dpdk-dev] [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF

2019-11-15 Thread Ferruh Yigit
On 11/8/2019 10:02 AM, Reshma Pattan wrote: > Use new macro RTE_IPV4_VHL_DEF instead of IP_VHL_DEF > wherever applicable. > > CC: xiaoyun...@intel.com > CC: ferruh.yi...@intel.com > CC: Bernard Iremonger > CC: John Daley > CC: Hyong Youb Kim > > Signed-off-by: Reshma Pattan Reviewed-by: Ferr

Re: [dpdk-dev] [PATCH v4] net/bonding: fix selection logic

2019-11-15 Thread Ferruh Yigit
On 11/13/2019 8:22 AM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Arrays agg_count and agg_bandwidth should be indexed by slave_id not by > aggregator port_id. > > The new_agg_id should be chosen as slave_id from slaves table in > different selection modes. > > Fixes: 6d72657ce379 ("

Re: [dpdk-dev] [PATCH] app/testpmd: fix cleanup of Tx metadata offload

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 12:05 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Dekel Peled >> Sent: Thursday, November 14, 2019 1:59 PM >> To: Mcnamara, John ; Kovacevic, Marko >> ; Lu, Wenzhuo ; Wu, >> Jingjing ; Iremonger, Bernard >> >> Cc: dev@dpdk.org; viachesl...@mellanox.com >> Su

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Stephen Hemminger
On Fri, 15 Nov 2019 12:41:07 +0100 Michael Pfeiffer wrote: > The name in rte_kni_device_info is passed to the kernel, which allows > interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a > longer name currently trigger a kernel BUG in alloc_netdev_mqs in > net/core/dev.c. Reduce

Re: [dpdk-dev] [PATCH] net: constify pointer to ipv6 header

2019-11-15 Thread Ferruh Yigit
On 11/15/2019 12:02 AM, Stephen Hemminger wrote: > The function rte_ipv6_get_next_ext does not modify > the header that is passed in. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-15 Thread Stephen Hemminger
On Fri, 15 Nov 2019 12:41:16 +0300 Andrew Rybchenko wrote: > Hi Stephen, > > On 11/14/19 7:56 PM, Stephen Hemminger wrote: > > On Thu, 14 Nov 2019 16:40:50 + > > Andrew Rybchenko wrote: > > > >> By default RSS hash delivery (offload) is bound to RSS mode and > >> it is incorrect to adver

Re: [dpdk-dev] [PATCH v2] net/ice: add flow mark hint support

2019-11-15 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev On Behalf Of Qi Zhang > Sent: Thursday, November 14, 2019 7:42 PM > To: Ye, Xiaolong > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2] net/ice: add flow mark hint support > > Since not all data paths support flow mark, the driver need a

Re: [dpdk-dev] [PATCH v6] net/memif: zero-copy slave

2019-11-15 Thread Ferruh Yigit
On 11/11/2019 3:49 PM, David Marchand wrote: > On Mon, Nov 11, 2019 at 4:21 PM Ferruh Yigit wrote: >> >> On 11/4/2019 11:03 AM, Jakub Grajciar wrote: >>> Zero-copy slave support for memif PMD. >>> Slave interface exposes DPDK memory to >>> master interface. Only single file segments >>> are suppor

[dpdk-dev] [PATCH v14 2/2] kni: support IOVA mode

2019-11-15 Thread vattunuru
From: David Marchand Current KNI implementation only operates in IOVA_PA mode patch adds required functionality to enable KNI in IOVA_VA mode. Due to IOVA to KVA address translations, based on the KNI use case there can be a performance impact. To mitigate the impact on performance,forcing IOVA

[dpdk-dev] [PATCH v14 0/2] kni: support IOVA mode

2019-11-15 Thread vattunuru
From: Vamsi Attunuru --- V14 Changes: * Simplified forcing IOVA as PA scheme. * Updated documentation V13 Changes: * For KNI case, to restore the existing behaviour, forcing IOVA as PA if bus iommu returns IOVA_DC. * Restored phys_addr and kni_lib defination checks. * Simplified patch titles. *

[dpdk-dev] [PATCH v14 1/2] kni: support IOVA mode in kernel module

2019-11-15 Thread vattunuru
From: Vamsi Attunuru Patch adds support for kernel module to work in IOVA = VA mode by providing address translation routines to convert IOVA aka user space VA to kernel virtual addresses. When compared with IOVA = PA mode, KNI netdev ports does not have any impact on performance with this appro

Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-15 Thread Andrew Rybchenko
On 11/15/19 7:35 PM, Stephen Hemminger wrote: On Fri, 15 Nov 2019 12:41:16 +0300 Andrew Rybchenko wrote: Hi Stephen, On 11/14/19 7:56 PM, Stephen Hemminger wrote: On Thu, 14 Nov 2019 16:40:50 + Andrew Rybchenko wrote: By default RSS hash delivery (offload) is bound to RSS mode and

[dpdk-dev] [dpdk-announce] DPDK 19.08.2 released

2019-11-15 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.08.2.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.08 This release fixes an errata in the previous 19.08.1 release that caused a regression with vhost. The fix was tested by Intel via

[dpdk-dev] [dpdk-announce] DPDK 18.11.5 (LTS) released

2019-11-15 Thread Kevin Traynor
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-18.11.5.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=18.11 This release fixes an errata in the previous 18.11.4 release that caused a regression with vhost. The fix was tested by Intel via the

Re: [dpdk-dev] [dpdk-security] DPDK security advisory: CVE-2019-14818

2019-11-15 Thread Ferruh Yigit
On 11/14/2019 11:25 AM, Ferruh Yigit wrote: > On 11/12/2019 3:15 PM, Ferruh Yigit wrote: >> A vulnerability was fixed in DPDK. >> >> Some downstream stakeholders were warned in advance in order to coordinate >> the >> release of fixes and reduce the vulnerability window. >> >> Problem: >> A malici

Re: [dpdk-dev] [PATCH v2] net/ice: add flow mark hint support

2019-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Stillwell Jr, Paul M > Sent: Saturday, November 16, 2019 12:37 AM > To: Zhang, Qi Z ; Ye, Xiaolong > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v2] net/ice: add flow mark hint support > > > > -Original Message- > > From: dev