On Fri, 15 Nov 2019 12:41:16 +0300
Andrew Rybchenko <arybche...@solarflare.com> wrote:
> Hi Stephen,
>
> On 11/14/19 7:56 PM, Stephen Hemminger wrote:
> > On Thu, 14 Nov 2019 16:40:50 +0000
> > Andrew Rybchenko <arybche...@solarflare.com> wrote:
> >
> >> By default RSS hash delivery (offload) is bound to RSS mode and
> >> it is incorrect to advertise it as enabled if Rx multi-queue mode
> >> has no RSS.
> >>
> >> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload
> >> capabilities")
> >>
> >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
> >
> > If you have to change so many drivers, why not just handle it in
> > common rte_ethdev code?
>
> rte_ethdev cannot set the offload itself since it has no knowledge that
> the offload cannot be disabled.
> rte_ethdev can blacklist the automatically set offloads in the case of
> non-RSS Rx multi-queue mode, but I don't like it since it adds to many
> layers where we change offloads.
> That's why I prefer this way.
>
> Andrew.
Makes sense, just concerned that other (or new) drivers will
have same issue.
