Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-14 Thread Venumadhav Josyula
Hi Oliver,Bruce, - we were using --SOCKET-MEM Eal flag. - We did not wanted to avoid going back to legacy mode. - we also wanted to avoid 1G huge-pages. Thanks for your inputs. Hi Anatoly, We were using vfio with iommu, but by default it s iova-mode=pa, after changing to iova-mode=va

Re: [dpdk-dev] [PATCH v3 2/3] config: add arm neoverse N1 SDP configuration

2019-11-14 Thread Jerin Jacob
On Mon, Nov 11, 2019 at 11:12 AM Gavin Hu wrote: > > Arm N1 SDP is an infrastructure segment development platform > based on armv8.2-a Neoverse N1 CPU. For more information, refer to: > https://community.arm.com/developer/tools-software/oss-platforms/w/ > docs/440/neoverse-n1-sdp > > Signed-off-by

Re: [dpdk-dev] [PATCH] net/mlx5: fix environment variable recovery

2019-11-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, November 13, 2019 6:25 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix environment variable recovery > > The state of environment variable MLX5_BF_SHUT_UP was

Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-14 Thread Maxime Coquelin
Maybe change the title to something like: vhost: fix vring requests validation broken if no FD in payload On 11/13/19 12:03 PM, Zhike Wang wrote: > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > so validate_msg_fds() will return error. In this case, > the negotiation of vring message

[dpdk-dev] [PATCH] net/mlx5: fix vport id value in port id action

2019-11-14 Thread Viacheslav Ovsiienko
The kernel driver (starting from OFED 4.7.3.1.3) uses the upper half of metadata register C0 to provide VHCA and vport id's. The mlx5 PMD should check the actual mask of register C0 and shift the vport id value for port actions appropriately. Fixes: f07341e7aed3 ("net/mlx5: update source and desti

[dpdk-dev] [PATCH v18 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-11-14 Thread Rosen Xu
This patch set adds PCIe AER disable and FPGA interrupt support for ipn3ke. It also provides a small rework for port bonding between FPGA line side port and I40e PF port. What is the PCI Express AER(Advanced Error Reporting)? Advanced Error Reporting capability is implemented with a PCI Express ad

[dpdk-dev] [PATCH v18 02/19] raw/ifpga/base: add irq support

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Add irq support for ifpga FME global error, port error and uint unit. We implmented this feature by vfio interrupt mechanism. To build this feature, CONFIG_RTE_EAL_VFIO should be enabled. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- config/common_base

[dpdk-dev] [PATCH v18 01/19] net/i40e: i40e support ipn3ke FPGA port bonding

2019-11-14 Thread Rosen Xu
From: Andy Pei In ipn3ke, each FPGA network side port bonding to an i40e pf, each i40e pf link status should get data from FPGA network, side port. This patch provide bonding relationship. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/i40e/base/i40e_type.h | 3 +++

[dpdk-dev] [PATCH v18 03/19] raw/ifpga/base: clear pending bit

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Every defined bit in FME_ERROR0 is RW1C. Other reserved bits are always 0 when readout and it will plan to be RW1C if needed in future. So it is safe just write the read back value to clear all the errors. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/ra

[dpdk-dev] [PATCH v18 06/19] raw/ifpga/base: align the send buffer for SPI

2019-11-14 Thread Rosen Xu
From: Tianfei zhang The length of send buffer of SPI bus should be 4bytes align. Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_spi_transaction.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v18 04/19] raw/ifpga/base: add SEU error support

2019-11-14 Thread Rosen Xu
From: Tianfei zhang This patch exposes SEU error information to application then application could compare this information (128bit) with its own SMH file to know if this SEU is a fatal error or not. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines

[dpdk-dev] [PATCH v18 07/19] raw/ifpga/base: add sensor support

2019-11-14 Thread Rosen Xu
From: Tianfei zhang The sensor devices are connected in MAX10 FPGA. we used the device tree to describe those sensor devices. Parse the device tree to get the sensor devices and add them into a list. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_intel_ma

[dpdk-dev] [PATCH v18 08/19] raw/ifpga/base: introducing sensor APIs

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Introducing sensor APIs to PMD driver for PAC N3000 card. Those sensor APIs: 1. opae_mgr_for_each_sensor() 2. opae_mgr_get_sensor_by_name() 3. opae_mgr_get_sensor_by_id() 4. opae_mgr_get_sensor_value_by_name() 5. opae_mgr_get_sensor_value_by_id() 6. opae_mgr_get_sensor_value(

[dpdk-dev] [PATCH v18 05/19] raw/ifpga/base: add device tree support

2019-11-14 Thread Rosen Xu
From: Tianfei zhang In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage the board configuration, like sensors, flash controller, QSFP, powers. And this is a SPI bus connected between A10 FPGA and MAX10, we can access the MAX10 registers over this SPI bus. In BMC, there are abo

[dpdk-dev] [PATCH v18 11/19] raw/ifpga: add PCIe BDF devices tree scan

2019-11-14 Thread Rosen Xu
Add PCIe BDF devices tree scan for ipn3ke. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 551 ++- drivers/raw/ifpga/ifpga_rawdev.h | 16 ++ 2 files changed, 562 insertions(+), 5 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v18 12/19] net/ipn3ke: remove configuration for i40e port bonding

2019-11-14 Thread Rosen Xu
The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, so it doesn't need to provide configuration for i40e port bonding. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/ipn3ke/Makefile | 1 + drivers/net/ipn3ke/ipn3ke_ethdev.c| 292 ++

[dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler

2019-11-14 Thread Rosen Xu
Add SEU interrupt support for FPGA. Signed-off-by: Tianfei zhang Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 241 +++ 1 file changed, 241 insertions(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/if

[dpdk-dev] [PATCH v18 13/19] raw/ifpga/base: add secure support

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Add secure max10 device support. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h| 2 + drivers/raw/ifpga/base/ifpga_fme.c| 26 -- drivers/raw/ifpga/base/opae_intel_max10.c | 137 +---

[dpdk-dev] [PATCH v18 09/19] raw/ifpga/base: update SEU register definition

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Update the SEU registser definition. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_defines.h b/drivers/raw/ifpga/base/ifpg

[dpdk-dev] [PATCH v18 17/19] raw/ifpga: add lightweight fpga image support

2019-11-14 Thread Rosen Xu
From: Andy Pei if fpga image support lightweight feature, set afu uuid to all 0, ipn3ke representor will not be probed. Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 44 +--- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v18 15/19] raw/ifpga/base: clean fme errors

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Clean fme errors register when some fme errors occurred. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme_error.c | 24 ++-- drivers/raw/ifpga/ifpga_rawdev.c | 22 ++ 2 files changed,

[dpdk-dev] [PATCH v18 14/19] raw/ifpga/base: configure FEC mode

2019-11-14 Thread Rosen Xu
From: Tianfei zhang We can change the PKVL FEC mode when the A10 NIOS FW initialization. The end-user can use this feature the change the FEC mode, the default mode is RS FEC mode. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme.c | 42 +++

[dpdk-dev] [PATCH v18 18/19] raw/ifpga/base: add multiple cards support

2019-11-14 Thread Rosen Xu
From: Tianfei zhang In PAC N3000 card, there is one MAX10 chip in each card, and all of the sensors are connected to MAX10 chip. To support multiple cards in one server, we introducing a sensor device list under intel_max10_device instead of a global list. On the other hand, we using separate int

[dpdk-dev] [PATCH v18 19/19] raw/ifpga: introducing new irq API

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Introducing new register and unregister API for ifpga interrupt. 1. register FME and AFU interrupt ifpga_register_msix_irq() 2. unregister FME and AFU interrupt ifpga_unregister_msix_irq() On PAC N3000 card, there is one PCIe MSIX interrupt for FME managerment, like th

[dpdk-dev] [PATCH v18 16/19] raw/ifpga/base: add new API get board info

2019-11-14 Thread Rosen Xu
From: Tianfei zhang Add new API to get the board info. opae_mgr_get_board_info() Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_api.c | 11 +++ drivers/raw/ifpga/base/ifpga_defines.h | 55 ++ drivers/raw/ifpga/base

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-14 Thread Burakov, Anatoly
On 13-Nov-19 9:01 PM, Venumadhav Josyula wrote: Hi Anatoly, By default w/o specifying --iova-mode option is iova-mode=pa by default ? Thanks Venu In 18.11, there is a very specific set of circumstances that will default to IOVA as VA mode. Future releases have become more aggressive, to th

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-14 Thread Burakov, Anatoly
On 14-Nov-19 8:12 AM, Venumadhav Josyula wrote: Hi Oliver,Bruce, * we were using --SOCKET-MEM Eal flag. * We did not wanted to avoid going back to legacy mode. * we also wanted to avoid 1G huge-pages. Thanks for your inputs. Hi Anatoly, We were using vfio with iommu, but by default it s

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-14 Thread Venumadhav Josyula
Hi Anatoly, Thanks for quick response. We want to understand, if there will be performance implications because of iova-mode being va. We want to understand, specifically in terms following - cache misses - Branch misses etc - translation of va addr -> phy addr when packet is receieved

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-14 Thread Venumadhav Josyula
Hi Anatoly, > I would also suggest using --limit-mem if you desire to limit the > maximum amount of memory DPDK will be able to allocate. We are already using that. Thanks and regards, Venu On Thu, 14 Nov 2019 at 15:19, Burakov, Anatoly wrote: > On 14-Nov-19 8:12 AM, Venumadhav Josyula wrote:

Re: [dpdk-dev] time taken for allocation of mempool.

2019-11-14 Thread Burakov, Anatoly
On 14-Nov-19 9:50 AM, Venumadhav Josyula wrote: Hi Anatoly, Thanks for quick response. We want to understand, if there will be performance implications because of iova-mode being va. We want to understand,  specifically in terms following * cache misses * Branch misses etc * translatio

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-14 Thread Burakov, Anatoly
On 13-Nov-19 9:43 PM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of container

Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-14 Thread 王志克
Thanks Maxime. Go ahead, your proposal sounds good. Br, Zhike Wang JDCloud, Product Development, IaaS   Mobile/+86 13466719566 E- mail/wangzh...@jd.com Address/5F Building A,North-Star Century Cente

Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-14 Thread Maxime Coquelin
On 11/14/19 11:16 AM, 王志克 wrote: > Thanks Maxime. > Go ahead, your proposal sounds good. Thanks, could you provide the qemu command line you used to reproduce the issue, and also the kernel version? It will help to document the commit message. Regards, Maxime > Br, > Zhike Wang > JDCloud,

Re: [dpdk-dev] [PATCH v12 1/2] kni: add IOVA=VA mode support

2019-11-14 Thread David Marchand
On Tue, Nov 5, 2019 at 12:05 PM wrote: > > From: Vamsi Attunuru > > Current KNI implementation only operates in IOVA_PA mode > patch adds required functionality to enable KNI in > IOVA_VA mode. > > KNI can operate in IOVA_VA mode when this mode is requested > using eal option (`iova-mode=va`) or

Re: [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-14 Thread 王志克
Hi Maxime, Usually I define some xml file, and use virsh to start the VM. Below is got from ps command. /usr/libexec/qemu-kvm -name guest=test_virtio,debug-threads=on -S -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain-4-test_virtio/master-key.aes -machine pc-i440fx-rh

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix link status

2019-11-14 Thread Ilya Maximets
On 14.11.2019 4:45, Cui, LunyuanX wrote: > Hi, Ilya Maximets > > Before my patch, original treatment is as follows: > esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP); > if ((esdp_reg & IXGBE_ESDP_SDP3)) > link_up = 0; > > if (link_up == 0) { > if (ixgbe_get

Re: [dpdk-dev] [PATCH v12 1/2] kni: add IOVA=VA mode support

2019-11-14 Thread David Marchand
On Thu, Nov 14, 2019 at 11:57 AM David Marchand wrote: > On Tue, Nov 5, 2019 at 12:05 PM wrote: > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c > > index 9e2d50c..a1c5bf6 100644 > > --- a/lib/librte_eal/linux/eal/eal.c > > +++ b/lib/librte_eal/linux/eal/eal.c > >

Re: [dpdk-dev] [dpdk-security] DPDK security advisory: CVE-2019-14818

2019-11-14 Thread Ferruh Yigit
On 11/12/2019 3:15 PM, Ferruh Yigit wrote: > A vulnerability was fixed in DPDK. > > Some downstream stakeholders were warned in advance in order to coordinate the > release of fixes and reduce the vulnerability window. > > Problem: > A malicious container which has direct access to the vhost-user

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-14 Thread Yasufumi Ogawa
On 2019/11/14 2:01, Burakov, Anatoly wrote: On 13-Nov-19 9:43 PM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries ru

Re: [dpdk-dev] [PATCH] net/mlx5: fix vport id value in port id action

2019-11-14 Thread Matan Azrad
From: Viacheslav Ovsiienko > The kernel driver (starting from OFED 4.7.3.1.3) uses the upper half of > metadata register C0 to provide VHCA and vport id's. The mlx5 PMD should > check the actual mask of register C0 and shift the vport id value for port > actions appropriately. > > Fixes: f0734

Re: [dpdk-dev] [EXT] Re: [PATCH v12 1/2] kni: add IOVA=VA mode support

2019-11-14 Thread Vamsi Krishna Attunuru
> -Original Message- > From: David Marchand > Sent: Thursday, November 14, 2019 4:43 PM > To: Vamsi Krishna Attunuru > Cc: dev ; Thomas Monjalon ; Jerin > Jacob Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Olivier Matz ; Yigit, > Ferruh ; Burakov, Anatoly > ; Andrew Rybchenko > ; Stephe

Re: [dpdk-dev] [PATCH] net/mlx5: fix vport id value in port id action

2019-11-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, November 14, 2019 10:57 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix vport id value in port id action > > The kernel driver (starting from OFED 4.7.3.1.3) u

Re: [dpdk-dev] [EXT] Re: [PATCH v12 1/2] kni: add IOVA=VA mode support

2019-11-14 Thread David Marchand
On Thu, Nov 14, 2019 at 1:10 PM Vamsi Krishna Attunuru wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Thursday, November 14, 2019 4:43 PM > > To: Vamsi Krishna Attunuru > > Cc: dev ; Thomas Monjalon ; Jerin > > Jacob Kollanukkaran ; Kiran Kumar Kokkilagadda > > ;

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-14 Thread David Marchand
On Thu, Nov 14, 2019 at 12:42 PM Yasufumi Ogawa wrote: > > On 2019/11/14 2:01, Burakov, Anatoly wrote: > > On 13-Nov-19 9:43 PM, yasufu...@gmail.com wrote: > >> From: Yasufumi Ogawa > >> > >> In secondary_msl_create_walk(), it creates a file for fbarrays with its > >> PID for reserving unique nam

[dpdk-dev] DPDK Release Status Meeting 14/11/2019

2019-11-14 Thread Ferruh Yigit
Minutes 14 November 2019 Agenda: * Release Dates * RC2 Status * Subtrees * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * NXP * Red Hat Release Dates - * v19.11 dates: * RC2 is released on Tuesday 12 November * https://mails.dpdk.org/arc

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-14 Thread Ferruh Yigit
On 11/13/2019 6:02 PM, Ferruh Yigit wrote: > On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> index 30c0379d4..8c1caac18 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-14 Thread David Marchand
On Wed, Nov 13, 2019 at 10:44 PM wrote: > From: Yasufumi Ogawa > > In secondary_msl_create_walk(), it creates a file for fbarrays with its > PID for reserving unique name among secondary processes. However, it > does not work if several secondaries run as app containers because each > of containe

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-14 Thread Jerin Jacob
On Wed, Nov 13, 2019 at 11:32 PM Ferruh Yigit wrote: > > On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 30c0379d4..8c1caac18 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drive

Re: [dpdk-dev] [PATCH v4] bus/pci: align next mapping address on page boundary

2019-11-14 Thread David Marchand
On Wed, Nov 13, 2019 at 8:17 AM Wangyu (Eric) wrote: > > Currently, the next address picked by PCI mapping infrastructure > may be page-unaligned due to BAR length being smaller than page size. > This leads to a situation where the requested map address is invalid, > resulting in mmap() call retur

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-14 Thread Andrew Rybchenko
On 11/14/19 3:57 PM, Jerin Jacob wrote: On Wed, Nov 13, 2019 at 11:32 PM Ferruh Yigit wrote: On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 30c0379d4..8c1caac18 100644 --- a/drivers/net/ixgbe/ixgbe_e

[dpdk-dev] [PATCH] doc: update release notes for AESNI PMDs

2019-11-14 Thread Pablo de Lara
AESNI MB and AESNI GCM PMDs were updated to support latest IPSec Multi buffer library (v0.53), and the user guide of hose drivers were updated but not release notes. Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/release_19_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [dpdk-dev] [PATCH] doc: update release notes for AESNI PMDs

2019-11-14 Thread Akhil Goyal
Hi Pablo, > AESNI MB and AESNI GCM PMDs were updated to support > latest IPSec Multi buffer library (v0.53), and the user guide > of hose drivers were updated but not release notes. > > Signed-off-by: Pablo de Lara > --- > doc/guides/rel_notes/release_19_11.rst | 9 + > 1 file changed,

[dpdk-dev] [PATCH 2/2] mempool: remove check for bad IOVA when populating

2019-11-14 Thread Anatoly Burakov
Currently, mempool will check if IOVA is bad for a segment, and reject the IOVA if hugepages are also enabled. This check is wrong because now that we have external memory segments, they are allowed to have their IOVA's to be invalid. This check also doesn't make much sense in the first place, beca

[dpdk-dev] [PATCH 1/2] mempool: use actual IOVA addresses when populating

2019-11-14 Thread Anatoly Burakov
Currently, when mempool is being populated, we get IOVA address of every segment using rte_mem_virt2iova(). This works for internal memory, but does not really work for external memory, and does not work on platforms which return RTE_BAD_IOVA as a result of this call (such as FreeBSD). Moreover, ev

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-14 Thread Ferruh Yigit
On 11/14/2019 1:24 PM, Andrew Rybchenko wrote: > On 11/14/19 3:57 PM, Jerin Jacob wrote: >> On Wed, Nov 13, 2019 at 11:32 PM Ferruh Yigit wrote: >>> On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >>

[dpdk-dev] [PATCH] app/testpmd: fix cleanup of Tx metadata offload

2019-11-14 Thread Dekel Peled
Previous patch [1] removed the match_metadata Tx offload. This patch removes the option to select this offload from testpmd menu, help text and documentation. It also modifies the cmd_show_tx_metadata_parsed() function, to display the value correctly, and the dump_pkt_burst() function to display th

Re: [dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities

2019-11-14 Thread Ferruh Yigit
On 11/8/2019 8:48 AM, Andrew Rybchenko wrote: > On 11/7/19 8:22 PM, Ferruh Yigit wrote: >> On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: >>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >>> index ed8cbd849..37df1c40a 100644 >>> --- a/drivers/net/i40e/i40e_eth

[dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled

2019-11-14 Thread Mattias Rönnblom
Calling pstate's or acpi's rte_power_freq_up() when on the highest non-turbo frequency results in an error, if turbo is disabled. The error is in the form of a return code and a RTE_LOG() entry on the ERR level. According to the API documentation, the frequency is scaled up "according to the avail

[dpdk-dev] [PATCH] mem: clarify documentation for rte_mem_virt2iova

2019-11-14 Thread Anatoly Burakov
It may not be immediately clear that rte_mem_virt2iova does not actually check the internal memseg table, and will instead either return VA (in IOVA as VA mode), or will fall back to kernel page table walk (in IOVA as PA mode). Add a note to API documentation indicating the above. Signed-off-by:

Re: [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities

2019-11-14 Thread Ferruh Yigit
On 11/14/2019 1:59 PM, Ferruh Yigit wrote: > On 11/14/2019 1:24 PM, Andrew Rybchenko wrote: >> On 11/14/19 3:57 PM, Jerin Jacob wrote: >>> On Wed, Nov 13, 2019 at 11:32 PM Ferruh Yigit >>> wrote: On 11/11/2019 1:19 PM, pbhagavat...@marvell.com wrote: > diff --git a/drivers/net/ixgbe/ixgb

Re: [dpdk-dev] [PATCH 1/2] malloc: fix realloc wrong copy size

2019-11-14 Thread Burakov, Anatoly
On 12-Nov-19 2:50 PM, Xueming Li wrote: In rte_realloc, if the old element has pad and need to allocate a new memory, the padding size was not deducted, so more data was copied to new data area. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- Re

Re: [dpdk-dev] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-14 Thread Burakov, Anatoly
On 12-Nov-19 2:50 PM, Xueming Li wrote: When resize a memory with next element, the original element size grows. If the orginal element has padding, the real inner element size didn't grow as well and this causes trailer verification failure when malloc debug enabled. Fixes: af75078fece3 ("first

[dpdk-dev] [PATCH] net/mlx5: fix flow table hash list conversion

2019-11-14 Thread Matan Azrad
For the case when DR is not supported and DV is supported: multi-tables feature is off. In this case, only table 0 is supported. Table 0 structure wrongly was not created what prevented any matcher object to be created and even caused crashes. Create the table hash

Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled

2019-11-14 Thread Hunt, David
Hi Mattias, On 14/11/2019 14:10, Mattias Rönnblom wrote: Calling pstate's or acpi's rte_power_freq_up() when on the highest non-turbo frequency results in an error, if turbo is disabled. The error is in the form of a return code and a RTE_LOG() entry on the ERR level. According to the API docum

[dpdk-dev] [PATCH 2/3] ethdev: decrease verbosity of not disabled offload logs

2019-11-14 Thread Andrew Rybchenko
Right now a PMD decides if it is critical that an offload cannot be disabled (i.e. not requested, but still enabled). If PMD treaks it as OK, we should not spam logs with corresponding messsages by default. Default log level in ethdev is INFO, so change the message level to DEBUG. Fixes: 1daa33805

[dpdk-dev] [PATCH 3/3] ethdev: improve message about not disabled offload

2019-11-14 Thread Andrew Rybchenko
Avoid usaged of "failed" in the message about not requested but enabled offload, since it is not a failure. Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD") Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-14 Thread Andrew Rybchenko
By default RSS hash delivery (offload) is bound to RSS mode and it is incorrect to advertise it as enabled if Rx multi-queue mode has no RSS. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Signed-off-by: Andrew Rybchenko --- drivers/net/bnxt/bnxt_ethdev.c | 3

Re: [dpdk-dev] [PATCH 2/3] ethdev: decrease verbosity of not disabled offload logs

2019-11-14 Thread Ferruh Yigit
On 11/14/2019 4:40 PM, Andrew Rybchenko wrote: > Right now a PMD decides if it is critical that an offload cannot > be disabled (i.e. not requested, but still enabled). If PMD treaks > it as OK, we should not spam logs with corresponding messsages > by default. Default log level in ethdev is INFO,

Re: [dpdk-dev] [PATCH 3/3] ethdev: improve message about not disabled offload

2019-11-14 Thread Ferruh Yigit
On 11/14/2019 4:40 PM, Andrew Rybchenko wrote: > Avoid usaged of "failed" in the message about not requested but > enabled offload, since it is not a failure. > > Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD") > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if Rx mode is RSS only

2019-11-14 Thread Stephen Hemminger
On Thu, 14 Nov 2019 16:40:50 + Andrew Rybchenko wrote: > By default RSS hash delivery (offload) is bound to RSS mode and > it is incorrect to advertise it as enabled if Rx multi-queue mode > has no RSS. > > Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") > > Sig

Re: [dpdk-dev] [PATCH 2/3] ethdev: decrease verbosity of not disabled offload logs

2019-11-14 Thread Stephen Hemminger
On Thu, 14 Nov 2019 16:40:51 + Andrew Rybchenko wrote: > Right now a PMD decides if it is critical that an offload cannot > be disabled (i.e. not requested, but still enabled). If PMD treaks > it as OK, we should not spam logs with corresponding messsages > by default. Default log level in et

Re: [dpdk-dev] [PATCH 3/3] ethdev: improve message about not disabled offload

2019-11-14 Thread Stephen Hemminger
On Thu, 14 Nov 2019 16:40:52 + Andrew Rybchenko wrote: > Avoid usaged of "failed" in the message about not requested but > enabled offload, since it is not a failure. > > Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD") > > Signed-off-by: Andrew Rybchenko Acked-by: Stephen Hem

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-14 Thread Ananyev, Konstantin
> -Original Message- > From: yasufu...@gmail.com > Sent: Wednesday, November 13, 2019 9:44 PM > To: Burakov, Anatoly ; david.march...@redhat.com; > Ananyev, Konstantin > Cc: dev@dpdk.org; sta...@dpdk.org; yasufu...@gmail.com; Yasufumi Ogawa > > Subject: [PATCH v7 1/1] fbarray: fix d

Re: [dpdk-dev] [PATCH v12 1/2] kni: add IOVA=VA mode support

2019-11-14 Thread David Marchand
On Thu, Nov 14, 2019 at 11:57 AM David Marchand wrote: > On Tue, Nov 5, 2019 at 12:05 PM wrote: > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c > > index 9e2d50c..a1c5bf6 100644 > > --- a/lib/librte_eal/linux/eal/eal.c > > +++ b/lib/librte_eal/linux/eal/eal.c > >

Re: [dpdk-dev] [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF

2019-11-14 Thread Ferruh Yigit
On 11/8/2019 10:02 AM, Reshma Pattan wrote: > diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c > index a1598b822..e3e3d737b 100644 > --- a/drivers/net/enic/enic_fm_flow.c > +++ b/drivers/net/enic/enic_fm_flow.c > @@ -17,9 +17,6 @@ > #include "vnic_nic.h" > > #defin

[dpdk-dev] [PATCH] ethdev: fix missing new line token at end of line

2019-11-14 Thread pbhagavatula
From: Pavan Nikhilesh Fix missing new line token at the end of log. Fixes: 5d308972954 ("ethdev: add mbuf RSS update as an offload") Signed-off-by: Pavan Nikhilesh --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethd

Re: [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process

2019-11-14 Thread Kevin Traynor
On 12/11/2019 20:31, David Marchand wrote: > From: Krzysztof Kanas > > Caught while investigating timeouts on a ARM64 server. > > Stracing a test process running the eal_flags_autotest, we can see that > the fork helper is checking all possible file descriptors from > getdtablesize() to 2, and c

Re: [dpdk-dev] [PATCH v18 13/19] raw/ifpga/base: add secure support

2019-11-14 Thread Zhang, Tianfei
> -Original Message- > From: Xu, Rosen > Sent: Thursday, November 14, 2019 5:03 PM > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei ; > Pei, Andy ; Ye, Xiaolong ; Yigit, > Ferruh > Subject: [PATCH v18 13/19] raw/ifpga/base: add secure support > > From: Tianfei zhang > > Add secure

[dpdk-dev] [PATCH] net: constify pointer to ipv6 header

2019-11-14 Thread Stephen Hemminger
The function rte_ipv6_get_next_ext does not modify the header that is passed in. Signed-off-by: Stephen Hemminger --- lib/librte_net/rte_ip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h index e3300fd0fe18..1ceb7b79312f 100

[dpdk-dev] [PATCH] lib/bpf: fix clang build warnings for aarch64

2019-11-14 Thread Ruifeng Wang
Couple of warnings will block build when warnings been treated as errors. Clang version 8.0 was used. Warning messages during build: ../lib/librte_bpf/bpf_jit_arm64.c:1438:26: warning: incompatible pointer types passing 'uint32_t *' (aka 'unsigned int *') to parameter of type 'char *' [-Wincompati

[dpdk-dev] [PATCH] net/ice: add flow mark hint support

2019-11-14 Thread Qi Zhang
Since not all data pathes support flow mark, the driver need a hint from application to select the correct data path if flow mark is required. The patch introduce the a devarg "flow-mark-support" as a workaround solution, since a standard way is still ongoing. Signed-off-by: Qi Zhang --- doc/gui

[dpdk-dev] [PATCH v2] net/ice: add flow mark hint support

2019-11-14 Thread Qi Zhang
Since not all data paths support flow mark, the driver need a hint from application to select the correct data path if flow mark is required. The patch introduce a devarg "flow-mark-support" as a workaround solution, since a standard way is still ongoing. Signed-off-by: Qi Zhang --- v2: - fix ty

Re: [dpdk-dev] [PATCH] lib/bpf: fix clang build warnings for aarch64

2019-11-14 Thread Jerin Jacob
On Fri, Nov 15, 2019 at 8:48 AM Ruifeng Wang wrote: > > Couple of warnings will block build when warnings been treated as errors. > Clang version 8.0 was used. > > Warning messages during build: > ../lib/librte_bpf/bpf_jit_arm64.c:1438:26: warning: incompatible pointer > types passing 'uint32_t *'

Re: [dpdk-dev] [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF

2019-11-14 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 14, 2019 10:09 AM > To: John Daley (johndale) ; Hyong Youb Kim (hyonkim) > > Cc: Reshma Pattan ; dev@dpdk.org; > xiaoyun...@intel.com; Bernard Iremonger ; > David Harton (dharton) > Subject: Re: [PATCH] net: replace IP

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix vring message handling broken in some case

2019-11-14 Thread Tiwei Bie
On Thu, Nov 14, 2019 at 09:52:30AM +0100, Maxime Coquelin wrote: > Maybe change the title to something like: > > vhost: fix vring requests validation broken if no FD in payload > > On 11/13/19 12:03 PM, Zhike Wang wrote: > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > > so validate

[dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx

2019-11-14 Thread Somnath Kotur
From: Kalesh AP Update "mbuf->ol_flags" correctly for 'Checksum Unknown' errors for both tunneled and non-tunneled IP packets. Fixes: b875339622a3 ("net/bnxt: fix L4 checksum indication in non-vector Rx") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxr.c | 6

Re: [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx

2019-11-14 Thread Ajit Khaparde
On Thu, Nov 14, 2019 at 8:58 PM Somnath Kotur wrote: > From: Kalesh AP > > Update "mbuf->ol_flags" correctly for 'Checksum Unknown' errors > for both tunneled and non-tunneled IP packets. > > Fixes: b875339622a3 ("net/bnxt: fix L4 checksum indication in non-vector > Rx") > > Signed-off-by: Kales

[dpdk-dev] [PATCH v2] lib/bpf: fix clang build warnings for aarch64

2019-11-14 Thread Ruifeng Wang
Clang has different prototype for __builtin___clear_cache(). It requires 'char *' parameters while gcc requires 'void *'. Clang version 8.0 was used. Warning messages during build: ../lib/librte_bpf/bpf_jit_arm64.c:1438:26: warning: incompatible pointer types passing 'uint32_t *' (aka 'unsigned in

[dpdk-dev] [PATCH v2] net/e1000: fix link status update

2019-11-14 Thread Lunyuan Cui
Unassigned variable should not be used as judgment, and there is no need to update link status according to old link status. This patch fix the issue. Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") Cc: sta...@dpdk.org Signed-off-by: Lunyuan Cui --- drivers/net/e1000/em_ethd

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-11-14 Thread Thomas Monjalon
07/11/2019 06:02, Jerin Jacob: > On Thu, Nov 7, 2019 at 4:03 AM Alex Williamson > wrote: > > Ideas have been suggested > > upstream for for quarantining VFs generated from user owned PFs such > > that we require an opt-in to make use of them in this way. Nobody > > seems to be pursuing such ideas

Re: [dpdk-dev] [PATCH 00/11] example/l3fwd: introduce event device support

2019-11-14 Thread Thomas Monjalon
> > If it's not feasible to review for current release we could push it to > > 20.02. > > > > We at least want to push l2fwd-event example for this release. > > http://patches.dpdk.org/project/dpdk/list/?series=6498 l2fwd-event was pushed in DPDK 19.11. Please make sure this series (eventdev in

Re: [dpdk-dev] [PATCH v6 1/1] net/octeontx2: add Rx/Tx burst mode get callbacks

2019-11-14 Thread Jerin Jacob
On Tue, Nov 12, 2019 at 2:32 PM Sunil Kumar Kori wrote: > > Retrieve burst mode information according to the selected Rx/Tx mode and > offloads. > > Signed-off-by: Sunil Kumar Kori # Updated missing doc/guides/nics/features/octeontx2_vec.ini and doc/guides/nics/features/octeontx2_vf.ini doc upda

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-11-14 Thread Jerin Jacob
On Fri, Nov 15, 2019 at 12:27 PM Thomas Monjalon wrote: > > 07/11/2019 06:02, Jerin Jacob: > > On Thu, Nov 7, 2019 at 4:03 AM Alex Williamson > > wrote: > > > Ideas have been suggested > > > upstream for for quarantining VFs generated from user owned PFs such > > > that we require an opt-in to ma

Re: [dpdk-dev] [PATCH v2] lib/bpf: fix clang build warnings for aarch64

2019-11-14 Thread Jerin Jacob
On Fri, Nov 15, 2019 at 12:18 PM Ruifeng Wang wrote: > > Clang has different prototype for __builtin___clear_cache(). It requires > 'char *' parameters while gcc requires 'void *'. > > Clang version 8.0 was used. > Warning messages during build: > ../lib/librte_bpf/bpf_jit_arm64.c:1438:26: warning

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-11-14 Thread Slava Ovsiienko
Hi, Hideyuki The frame in your report is broadcast/multicast. Please, try unicast one. For broadcast we have the ticket, currently issue is under investigation. Anyway, thanks for reporting. With best regards, Slava > -Original Message- > From: Hideyuki Yamashita > Sent: Thursday, Novem

Re: [dpdk-dev] [PATCH] net/octeontx2: fix exit paths after cq init

2019-11-14 Thread Jerin Jacob
On Mon, Nov 11, 2019 at 6:51 PM Anoob Joseph wrote: > > After otx2_nix_register_cq_irqs() is called and the IRQs are setup, > otx2_nix_unregister_cq_irqs() need to be called in the subsequent error > exit paths. > > Fixes: d34db5ccbf30 ("net/octeontx2: fix driver reconfiguration") > > Signed-off-b

Re: [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices

2019-11-14 Thread Jerin Jacob
On Thu, Nov 7, 2019 at 4:42 PM Sunil Kumar Kori wrote: > > Patch adds skeleton for feature metrices for event dev s/metrices/matrices > and Rx/Tx adapters. > > Signed-off-by: Sunil Kumar Kori > + > + = = = = = = = > + Feature d d d