Re: [dpdk-dev] [dpdk-techboard] [RFC 0/4] cpu-crypto API choices

2019-11-06 Thread Ananyev, Konstantin
> > > > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > > > > process the crypto workload asynchronously. This way provides > > > > uniformity to > > > > both PMD types, but also introduce unnecessary performance penalty to SW > > > > PMDs that have to "simulate" HW async

Re: [dpdk-dev] 答复: [PATCH v2] bus/pci: resolve multiple NICs address conflicts

2019-11-06 Thread Burakov, Anatoly
On 06-Nov-19 6:15 AM, Wangyu (Eric) wrote: In 64K pagesize system, DPDK will read the size NIC need in uio/uio1/maps/map1/size, when the size small than pagesize(e.g.,82599 is 16K), dev->mem_resource[i].len will be 16K, but the mmap function applies for at least 1 page size, which is 64K. Th

Re: [dpdk-dev] [PATCH v2] bus/pci: resolve multiple NICs address conflicts

2019-11-06 Thread Burakov, Anatoly
On 06-Nov-19 7:37 AM, David Marchand wrote: On Wed, Nov 6, 2019 at 7:16 AM Wangyu (Eric) wrote: In 64K pagesize system, DPDK will read the size NIC need in uio/uio1/maps/map1/size, when the size small than pagesize(e.g.,82599 is 16K), dev->mem_resource[i].len will be 16K, but the mmap func

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-06 Thread Burakov, Anatoly
On 05-Nov-19 11:41 AM, Ananyev, Konstantin wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, November 5, 2019 11:31 AM To: David Marchand ; Yasufumi Ogawa Cc: Ananyev, Konstantin ; dev ; dpdk stable ; Yasufumi Ogawa Subject: Re: [PATCH v6 1/1] fbarray: fix duplicated

Re: [dpdk-dev] [PATCH v4 0/7] mempool: avoid objects allocations across pages

2019-11-06 Thread Thomas Monjalon
05/11/2019 16:36, Olivier Matz: > Olivier Matz (7): > mempool: allow unaligned addr/len in populate virt > mempool: reduce wasted space on mempool populate > mempool: remove optimistic IOVA-contiguous allocation > mempool: introduce function to get mempool page size > mempool: introduce h

Re: [dpdk-dev] [PATCH] test/mempool: fix false positive test result

2019-11-06 Thread Thomas Monjalon
04/11/2019 13:42, Andrew Rybchenko: > On 11/4/19 1:06 PM, Olivier Matz wrote: > > The ret variable, initialized to -1, is changed to 0 during the test, > > making the test successful in some cases where it should return a > > failure. > > > > Fix this by always using the GOTO_ERR() macro that sets

[dpdk-dev] [PATCH] drivers: copyrights update for nxp files

2019-11-06 Thread Sachin Saxena
Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman/fman.c| 2 +- drivers/bus/dpaa/base/fman/netcfg_layer.c| 2 +- drivers/bus/dpaa/rte_dpaa_bus.h | 2 +- drivers/bus/fslmc/mc/dpci.c | 1 + drivers/bus/fslmc/mc/dpcon.c

Re: [dpdk-dev] [PATCH v12 0/2] add IOVA=VA mode support

2019-11-06 Thread Thomas Monjalon
For info, the mempool patches are merged now. 05/11/2019 12:04, vattun...@marvell.com: > Vamsi Attunuru (2): > kni: add IOVA=VA mode support > kni: add IOVA=VA support in kernel module Should the kernel support be the first patch? About the titles, can it be simply "support IOVA mode"?

Re: [dpdk-dev] [PATCH v3] ethdev: enhance the API for getting burst mode information

2019-11-06 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 17:20 > To: Wang, Haiyue > Cc: dev@dpdk.org; jerinjac...@gmail.com; Yigit, Ferruh > ; > arybche...@solarflare.com; viachesl...@mellanox.com; damar...@cisco.com; Ye, > Xiaolong > ; Sun, Chenmin ; Kinsella, R

[dpdk-dev] [PATCH] fips_validation: fix auth verify

2019-11-06 Thread Fan Zhang
Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing") Cc: marko.kovace...@intel.com Cc: sta...@dpdk.org This patch fixes the incorrect mbuf write and digest memory leak in fips_validation authentication verify. Signed-off-by: Fan Zhang --- examples/fips_validation/main.c | 58 +

Re: [dpdk-dev] [PATCH v2] net/bnx2x: fix meson build failure

2019-11-06 Thread Thomas Monjalon
06/11/2019 06:45, Rasesh Mody: > Use kernel headers for __le* types to avoid potential conflicts > resulting in redefinition errors for Linux build environments. Errors happen only with "some" Linux environments. > Add check for FreeBSD execution environments. > > Without this fix, aarch64 build

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-11-06 Thread Hideyuki Yamashita
Dear Slava, Additional question. When I use testpmd in dpdk-next-net repo, it works in general. However when I use dpdk19.11-rc1, testpmd does not recognize connectX-5 NIC. Is it correct that ConnectX-5 will be recognized in 19.11 release finally? If yes, which release candidate the necessary ch

Re: [dpdk-dev] [PATCH] drivers: copyrights update for nxp files

2019-11-06 Thread Thomas Monjalon
06/11/2019 11:43, Sachin Saxena: > --- a/drivers/bus/dpaa/base/fman/fman.c > +++ b/drivers/bus/dpaa/base/fman/fman.c > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) > * > * Copyright 2010-2016 Freescale Semiconductor Inc. > - * Copyright 2017 NXP > + * Copyright 2017-

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

2019-11-06 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:19 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Kiran > Kumar Kokkilagadda ; olivier.m...@6wind.com; > ferruh.yi...@intel.com; anatoly.bura...@intel.com; > arybche...@s

Re: [dpdk-dev] [PATCH v2] bus/pci: resolve multiple NICs address conflicts

2019-11-06 Thread Burakov, Anatoly
On 06-Nov-19 7:37 AM, David Marchand wrote: On Wed, Nov 6, 2019 at 7:16 AM Wangyu (Eric) wrote: In 64K pagesize system, DPDK will read the size NIC need in uio/uio1/maps/map1/size, when the size small than pagesize(e.g.,82599 is 16K), dev->mem_resource[i].len will be 16K, but the mmap func

[dpdk-dev] Docker container OVS-dpdk: vhost_user_setup(): connect error

2019-11-06 Thread Deepak Gowda
Hi, I'm trying to run test-pmd with this virtual devices created by the ovs-dpdk from inside a docker container. I see EAL probing failing every time, i did try restarting the ovs, no luck. I see these vhost-user ports created from the log, i do see these from the 'ovs-vsctl show'. Can't seem to f

Re: [dpdk-dev] [PATCH] net/mlx5: allow pattern start from IP

2019-11-06 Thread Ori Kam
> -Original Message- > From: Xiaoyu Min > Sent: Tuesday, November 5, 2019 10:03 AM > To: Ori Kam ; Matan Azrad ; > Shahaf Shuler ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: allow pattern start from IP > > Some applications, i.e. OVS, have rule like: > > [1] pa

[dpdk-dev] [PATCH v3 1/1] net/octeontx2: add Rx/Tx burst mode get callbacks

2019-11-06 Thread Sunil Kumar Kori
Retrieve burst mode information according to the selected Rx/Tx mode and offloads. Signed-off-by: Sunil Kumar Kori --- v3: - Rebased the patch over patches.dpdk.org/patch/62368/ v2: - Rebased the patch on latest commit. - Update feature matrix for the support. doc/guides/nics/features/octeon

Re: [dpdk-dev] [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring

2019-11-06 Thread Trybula, ArturX
> -Original Message- > From: Trybula, ArturX > Sent: Monday, November 4, 2019 3:55 PM > To: Shally Verma ; dev@dpdk.org; Trahe, Fiona > ; Dybkowski, AdamX ; > akhil.go...@nxp.com > Subject: RE: [EXT] [PATCH v3 1/1] test/compress: unit tests > refactoring > > Hi Shally, > > Please fi

Re: [dpdk-dev] [dpdk-techboard] [RFC 0/4] cpu-crypto API choices

2019-11-06 Thread Ananyev, Konstantin
> > > > > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > > > > > process the crypto workload asynchronously. This way provides > > > > > uniformity to > > > > > both PMD types, but also introduce unnecessary performance penalty to > > > > > SW > > > > > PMDs that have to

[dpdk-dev] [PATCH v2 1/3] ethdev: support API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This patch implements [1], to support API for configuration and validation of max size for LRO aggregated packet. API change notice [2] is removed, and release notes for 19.11 are updated accordingly. Various PMDs using LRO offload are updated, the new data members are initialized to ensure they d

[dpdk-dev] [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. It adds command-line and runtime commands to configure this value, and adds option to show the supported value. Documentation is updated accordingly. Signed-off-by: Dekel Peled --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v2 0/3] support API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This series implements support and use of API for configuration and validation of max size for LRO aggregated packet. v2: Updated ethdev patch per review comments. Dekel Peled (3): ethdev: support API to set max LRO packet size net/mlx5: use API to set max LRO packet size app/testpmd: use A

[dpdk-dev] [PATCH v2 2/3] net/mlx5: use API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. Rx queue create is updated to use the relevant configuration. Documentation is updated accordingly. Signed-off-by: Dekel Peled --- doc/guides/nics/mlx5.rst| 2 ++ drivers/net/mlx5/mlx5_rxq.c | 4 +++- 2 files changed, 5

Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries

2019-11-06 Thread Medvedkin, Vladimir
Hi David, -Original Message- From: David Marchand Sent: Wednesday, November 6, 2019 5:51 AM To: Thomas Monjalon ; Medvedkin, Vladimir Cc: dev ; Richardson, Bruce ; Ananyev, Konstantin ; Aaron Conole Subject: Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries On Wed, Nov

Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries

2019-11-06 Thread Medvedkin, Vladimir
Hi Thomas, -Original Message- From: Thomas Monjalon Sent: Wednesday, November 6, 2019 7:51 AM To: Medvedkin, Vladimir Cc: David Marchand ; dev ; Richardson, Bruce ; Ananyev, Konstantin ; Aaron Conole Subject: Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries 06/11/2019 0

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

2019-11-06 Thread Thomas Monjalon
06/11/2019 12:09, Vamsi Krishna Attunuru: > From: Thomas Monjalon > > 05/11/2019 12:04, vattun...@marvell.com: > > > Vamsi Attunuru (2): > > > kni: add IOVA=VA mode support > > > kni: add IOVA=VA support in kernel module > > > > Should the kernel support be the first patch? > > But required

Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries

2019-11-06 Thread Thomas Monjalon
06/11/2019 12:53, Medvedkin, Vladimir: > From: Thomas Monjalon > > 06/11/2019 06:50, David Marchand: > > > On Wed, Nov 6, 2019 at 12:14 AM Thomas Monjalon > > > wrote: > > > > Applied, thanks > > > > > > The added tests are timeouting: > > > https://travis-ci.com/DPDK/dpdk/jobs/253293904 > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

2019-11-06 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 5:23 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Kiran > Kumar Kokkilagadda ; olivier.m...@6wind.com; > ferruh.yi...@intel.com; anatoly.bura...@intel.com; > arybche...@s

[dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-06 Thread Thomas Monjalon
The constants like AF_INET are in sys/socket.h in FreeBSD. The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD in order to be consistent across DPDK files, and allow to grep for EXEC_ENV among other benefits. Signed-off-by: Thomas Monjalon --- app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH] net/mlx5: allow pattern start from IP

2019-11-06 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Tuesday, November 5, 2019 10:03 > To: Ori Kam ; Matan Azrad ; > Shahaf Shuler ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: allow pattern start from IP > > Some applications, i.e. OVS, have rule like: > > [1] pattern

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-06 Thread Burakov, Anatoly
On 06-Nov-19 12:09 PM, Thomas Monjalon wrote: The constants like AF_INET are in sys/socket.h in FreeBSD. The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD in order to be consistent across DPDK files, and allow to grep for EXEC_ENV among other benefits. Signed-off-by: Thomas Monj

Re: [dpdk-dev] Limiting packet buffers under 4GB

2019-11-06 Thread Burakov, Anatoly
On 04-Nov-19 12:59 PM, Jerin Jacob Kollanukkaran wrote: Hi Anatoly and All, Just wondering what would the side effect of lowering a _bit_ of static uint64_t baseaddr = 0x1 in lib/librte_eal/common/eal_common_memory.c for 64bit systems. Use case: If we _reserve_ VA address which less t

Re: [dpdk-dev] [dpdk-techboard] [RFC 0/4] cpu-crypto API choices

2019-11-06 Thread Thomas Monjalon
06/11/2019 12:33, Ananyev, Konstantin: > > > > > > > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > > > > > > process the crypto workload asynchronously. This way provides > > > > > > uniformity to > > > > > > both PMD types, but also introduce unnecessary performance pena

[dpdk-dev] [PATCH 1/2] test/rib: speed up rib autotests

2019-11-06 Thread Vladimir Medvedkin
Split slow part of rib_autotest into rib_slow_autotest Fixes: b35df4dd666e ("test/rib: add autotests") Signed-off-by: Vladimir Medvedkin --- app/test/autotest_data.py | 6 ++ app/test/meson.build | 1 + app/test/test_rib.c | 20 ++-- 3 files changed, 25 insertio

Re: [dpdk-dev] [dpdk-techboard] [RFC 0/4] cpu-crypto API choices

2019-11-06 Thread Hemant Agrawal
> 06/11/2019 12:33, Ananyev, Konstantin: > > > > > > > > > Originally both SW and HW crypto PMDs use rte_crypot_op > > > > > > > based API to process the crypto workload asynchronously. > > > > > > > This way provides uniformity to both PMD types, but also > > > > > > > introduce unnecessary perf

[dpdk-dev] [PATCH 2/2] test/rib: speed up rib6 autotests

2019-11-06 Thread Vladimir Medvedkin
Split slow part of rib6_autotest into rib6_slow_autotest Fixes: abab6d2966dc ("test/rib: add IPv6 autotests") Signed-off-by: Vladimir Medvedkin --- app/test/autotest_data.py | 6 ++ app/test/meson.build | 1 + app/test/test_rib6.c | 20 ++-- 3 files changed, 25 i

Re: [dpdk-dev] [PATCH v1 02/13] net/ppfe: introduce ppfe net poll mode driver

2019-11-06 Thread Ferruh Yigit
On 11/6/2019 9:38 AM, Bruce Richardson wrote: > On Tue, Nov 05, 2019 at 04:02:52PM +, Ferruh Yigit wrote: >> On 11/4/2019 11:06 AM, Bruce Richardson wrote: >>> On Tue, Oct 29, 2019 at 09:27:22AM +, Ferruh Yigit wrote: On 10/28/2019 5:18 PM, Stephen Hemminger wrote: > On Mon, 26 Aug

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: support API to set max LRO packet size

2019-11-06 Thread Thomas Monjalon
06/11/2019 12:34, Dekel Peled: > This patch implements [1], to support API for configuration and > validation of max size for LRO aggregated packet. > API change notice [2] is removed, and release notes for 19.11 > are updated accordingly. > > Various PMDs using LRO offload are updated, the new da

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size

2019-11-06 Thread Iremonger, Bernard
Hi Dekel, > -Original Message- > From: Dekel Peled > Sent: Wednesday, November 6, 2019 11:35 AM > To: Mcnamara, John ; Kovacevic, Marko > ; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov, > Anatoly ; xuanziya...@huawei.com; > cloud.wangxiao...@hua

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: support API to set max LRO packet size

2019-11-06 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 2:26 PM > To: Dekel Peled > Cc: john.mcnam...@intel.com; marko.kovace...@intel.com; > nhor...@tuxdriver.com; ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; anatoly.bura...@intel.com;

Re: [dpdk-dev] Limiting packet buffers under 4GB

2019-11-06 Thread Jerin Jacob
On Wed, 6 Nov, 2019, 5:46 pm Burakov, Anatoly, wrote: > On 04-Nov-19 12:59 PM, Jerin Jacob Kollanukkaran wrote: > > Hi Anatoly and All, > > > > Just wondering what would the side effect of lowering a _bit_ of static > uint64_t baseaddr = 0x1 in > > lib/librte_eal/common/eal_common_memory

Re: [dpdk-dev] [PATCH] drivers: copyrights update for NXP files

2019-11-06 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:36 PM > To: dev@dpdk.org > Cc: Sachin Saxena ; ferruh.yi...@intel.com; > Hemant Agrawal ; techbo...@dpdk.org > Subject: Re: [PATCH] drivers: copyrights update for nxp files > Importance: High > > 06/11/2019

[dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list

2019-11-06 Thread Bing Zhao
Introduce simple hash list to the mlx5 utilities. User can define its own data structure containing the mlx5_hlist_entry and create the hash list table via the creation interface. Then the entry will be inserted into the table and linked to the corresponding list head. User should guarantee there i

Re: [dpdk-dev] [PATCH v3 01/13] crypto/dpaa_sec: fix to set PDCP capability flags

2019-11-06 Thread Akhil Goyal
> -Original Message- > From: Hemant Agrawal > Sent: Wednesday, November 6, 2019 10:47 AM > To: dev@dpdk.org > Cc: Akhil Goyal > Subject: [PATCH v3 01/13] crypto/dpaa_sec: fix to set PDCP capability flags > > set the pdcp capa_flags to 0 by default. > > Fixes: a1173d55598c ("crypto/dp

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add retry timeout in packet enqueue API

2019-11-06 Thread Akhil Goyal
> > This patch adds retry in the DPAA2 SEC packet enqueue API > > Signed-off-by: Nipun Gupta > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: use API to set max LRO packet size

2019-11-06 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, November 6, 2019 2:36 PM > To: Dekel Peled ; Mcnamara, John > ; Kovacevic, Marko > ; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov, > Anatoly ; xuanziya...@huawei.com

Re: [dpdk-dev] [PATCH v6 1/3] security: add anti replay window size

2019-11-06 Thread Akhil Goyal
> At present the ipsec xfrom is missing the important step > to configure the anti replay window size. > The newly added field will also help in to enable or disable > the anti replay checking, if available in offload by means > of non-zero or zero value. > > Signed-off-by: Hemant Agrawal > Ack

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SHA256-HMAC digest length

2019-11-06 Thread Akhil Goyal
> > From: Vakul Garg > > As per RFC4868, SHA-256 should use 128 bits of ICV. > Fixes: b5350285ce6e ("examples/ipsec-secgw: support SHA256 HMAC") > Cc: sta...@dpdk.org > > Signed-off-by: Vakul Garg > Acked-by: Akhil Goyal > --- Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH] doc: replace license text with SPDX tag for NFP nic

2019-11-06 Thread Alejandro Lucero
On Fri, Sep 27, 2019 at 10:06 AM Hemant Agrawal wrote: > Cc: Alejandro Lucero > > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/nfp.rst | 28 +--- > 1 file changed, 1 insertion(+), 27 deletions(-) > > diff --git a/doc/guides/nics/nfp.rst b/doc/guides/nics/nfp.rs

Re: [dpdk-dev] [PATCH v6 2/3] ipsec: remove redundant replay_win_sz

2019-11-06 Thread Ananyev, Konstantin
Hi guys, > The rte_security lib has introduced replay_win_sz, > so it can be removed from the rte_ipsec lib. > > The relaved tests,app are also update to reflect > the usages. > > Note that esn and anti-replay fileds were earlier used > only for ipsec library, they were enabling the libipsec >

Re: [dpdk-dev] [PATCH v6 2/3] ipsec: remove redundant replay_win_sz

2019-11-06 Thread Akhil Goyal
Hi Konstantin, > > Hi guys, > > > The rte_security lib has introduced replay_win_sz, > > so it can be removed from the rte_ipsec lib. > > > > The relaved tests,app are also update to reflect > > the usages. > > > > Note that esn and anti-replay fileds were earlier used > > only for ipsec library

Re: [dpdk-dev] [PATCH] vfio: fix getting default container

2019-11-06 Thread David Marchand
On Mon, Nov 4, 2019 at 8:35 PM David Marchand wrote: > > On Mon, Nov 4, 2019 at 6:41 PM Anatoly Burakov > wrote: > > > > When requesting DMA mapping to default container, we are meant to > > supply the RTE_VFIO_DEFAULT_CONTAINER_FD value, however this is > > not handled correctly by get_vfio_cfg_

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-11-06 Thread David Marchand
On Fri, Oct 25, 2019 at 2:23 PM Burakov, Anatoly wrote: > > On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: > > > > > >> On 25 Oct 2019, at 00:32, Thomas Monjalon wrote: > >> > >> 24/10/2019 21:09, David Marchand: > >>> On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov > >>> wrote: > >

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-11-06 Thread Thomas Monjalon
06/11/2019 14:48, David Marchand: > On Fri, Oct 25, 2019 at 2:23 PM Burakov, Anatoly > wrote: > > > > On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: > > > > > > > > >> On 25 Oct 2019, at 00:32, Thomas Monjalon wrote: > > >> > > >> 24/10/2019 21:09, David Marchand: > > >>> On Thu, Oct 24,

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-11-06 Thread David Marchand
On Tue, Nov 5, 2019 at 6:14 PM Burakov, Anatoly wrote: > > On 05-Nov-19 3:18 PM, Burakov, Anatoly wrote: > > On 05-Nov-19 2:10 PM, Rajesh Ravi wrote: > >> Thanks a lot Anatoly. > >> Will the same solution work with DPDK 19.02 as well? We 're actually > >> using DPDK 19.02 for memory allocations f

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-11-06 Thread Burakov, Anatoly
On 06-Nov-19 1:50 PM, Thomas Monjalon wrote: 06/11/2019 14:48, David Marchand: On Fri, Oct 25, 2019 at 2:23 PM Burakov, Anatoly wrote: On 25-Oct-19 12:13 PM, Damjan Marion (damarion) wrote: On 25 Oct 2019, at 00:32, Thomas Monjalon wrote: 24/10/2019 21:09, David Marchand: On Thu, Oct 2

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-11-06 Thread Anoob Joseph
Hi Akhil, Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, November 4, 2019 8:55 PM > To: Akhil Goyal ; Iremonger, Bernard > ; Thomas Monjalon > Cc: dev@dpdk.org; Anoob Joseph ; Jerin Jacob > Kollanukkaran ; dpdk-techboard >

Re: [dpdk-dev] [PATCH 19.11] vfio: fix DMA mapping of externally allocated heaps

2019-11-06 Thread David Marchand
On Tue, Nov 5, 2019 at 6:15 PM Burakov, Anatoly wrote: > > On 05-Nov-19 3:15 PM, Anatoly Burakov wrote: > > Currently, externally created heaps are supposed to be automatically > > mapped for VFIO DMA by EAL, however they only do so if, at the time of > > heap creation, VFIO is initialized and has

Re: [dpdk-dev] [PATCH] doc: replace license text with SPDX tag for NFP nic

2019-11-06 Thread Ferruh Yigit
On 11/6/2019 1:19 PM, Alejandro Lucero wrote: > On Fri, Sep 27, 2019 at 10:06 AM Hemant Agrawal > wrote: > >> Cc: Alejandro Lucero >> >> Signed-off-by: Hemant Agrawal >> --- >> doc/guides/nics/nfp.rst | 28 +--- >> 1 file changed, 1 insertion(+), 27 deletions(-) >> >> d

Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd

2019-11-06 Thread David Marchand
Hello Ruifeng, On Mon, Sep 16, 2019 at 4:30 AM Ruifeng Wang (Arm Technology China) wrote: > > Not sure why it has to be master core? > > Why interrupt thread wouldn't do? > > I think what we need to: > > 1. introduce reading routes from config file instead of having them hard- > > coded within t

Re: [dpdk-dev] [PATCH v2 1/2] net/virtio: do not limit packed ring size

2019-11-06 Thread Maxime Coquelin
On 10/30/19 10:24 AM, Marvin Liu wrote: > Virtio spec only set rule that packed ring maximum size is up to 2^15 > entries. Should not limit packed ring size to power of two. > > Fixes: aea29aa5d37b ("net/virtio: enable packed virtqueues by default") > Cc: sta...@dpdk.org > > Signed-off-by: Mar

Re: [dpdk-dev] [PATCH v4] app/test: add tests for atomic exchanges

2019-11-06 Thread David Marchand
On Fri, Oct 18, 2019 at 10:31 PM David Christensen wrote: > > The test works by creating a token comprised of random data > and a CRC8 value, using the rte_atomicXX_exchange to exchange > the new token for a previously generated token, and then > verifying that the exchanged data is intact (i.e. t

Re: [dpdk-dev] [PATCH v2 2/2] vhost: do not limit packed ring size

2019-11-06 Thread Maxime Coquelin
On 10/30/19 10:24 AM, Marvin Liu wrote: > Virtio spec only set rule that packed ring maximum size is up to 2^15 > entries. Should not limit packed ring size to power of two. > > Fixes: 708e14d8b9ac ("vhost: advertize packed ring layout support") > Cc: sta...@dpdk.org > > Signed-off-by: Marvin

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix implicit selection of library mode

2019-11-06 Thread Konstantin Ananyev
Right now majority of lib mode functional tests enable library mode with '-w N' option. It worked till recently, as legacy mode didn't support replay window. Now it changed. To fix - use '-l' option to enable library mode explicitly. Fixes: 929784452094 ("examples/ipsec-secgw: add scripts for func

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix implicit selection of library mode

2019-11-06 Thread Akhil Goyal
> Right now majority of lib mode functional tests enable > library mode with '-w N' option. > It worked till recently, as legacy mode didn't support replay window. > Now it changed. > To fix - use '-l' option to enable library mode explicitly. > > Fixes: 929784452094 ("examples/ipsec-secgw: add

Re: [dpdk-dev] [PATCH v6 2/3] ipsec: remove redundant replay_win_sz

2019-11-06 Thread Ananyev, Konstantin
> > > The rte_security lib has introduced replay_win_sz, > > > so it can be removed from the rte_ipsec lib. > > > > > > The relaved tests,app are also update to reflect > > > the usages. > > > > > > Note that esn and anti-replay fileds were earlier used > > > only for ipsec library, they were en

[dpdk-dev] [PATCH v3 0/3] support API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This series implements support and use of API for configuration and validation of max size for LRO aggregated packet. v2: Updated ethdev patch per review comments. v3: Updated ethdev and testpmd patches per review comments. Dekel Peled (3): ethdev: support API to set max LRO packet size net/m

[dpdk-dev] [PATCH v3 1/3] ethdev: support API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This patch implements [1], to support API for configuration and validation of max size for LRO aggregated packet. API change notice [2] is removed, and release notes for 19.11 are updated accordingly. Various PMDs using LRO offload are updated, the new data members are initialized to ensure they d

[dpdk-dev] [PATCH v3 3/3] app/testpmd: use API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. It adds command-line and runtime commands to configure this value, and adds option to show the supported value. Documentation is updated accordingly. Signed-off-by: Dekel Peled --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v3 2/3] net/mlx5: use API to set max LRO packet size

2019-11-06 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. Rx queue create is updated to use the relevant configuration. Documentation is updated accordingly. Signed-off-by: Dekel Peled --- doc/guides/nics/mlx5.rst| 2 ++ drivers/net/mlx5/mlx5_rxq.c | 4 +++- 2 files changed, 5

Re: [dpdk-dev] [PATCH v6 2/3] ipsec: remove redundant replay_win_sz

2019-11-06 Thread Akhil Goyal
> > > > > The rte_security lib has introduced replay_win_sz, > > > > so it can be removed from the rte_ipsec lib. > > > > > > > > The relaved tests,app are also update to reflect > > > > the usages. > > > > > > > > Note that esn and anti-replay fileds were earlier used > > > > only for ipsec lib

Re: [dpdk-dev] [EXT] Re: [PATCH v2] test: fix process dup fd close

2019-11-06 Thread David Marchand
On Mon, Nov 4, 2019 at 8:52 AM Krzysztof Kanas wrote: > > On 19-10-30 10:06, David Marchand wrote: > > External Email > > > > -- > > On Mon, Sep 2, 2019 at 11:50 AM wrote: > > > > > > From: Krzysztof Kanas > > > > > > process_du

Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries

2019-11-06 Thread Aaron Conole
Thomas Monjalon writes: > 06/11/2019 12:53, Medvedkin, Vladimir: >> From: Thomas Monjalon >> > 06/11/2019 06:50, David Marchand: >> > > On Wed, Nov 6, 2019 at 12:14 AM Thomas Monjalon >> > > wrote: >> > > > Applied, thanks >> > > >> > > The added tests are timeouting: >> > > https://travis-c

[dpdk-dev] [PATCH] net: fix the IPv4 IHL and VHL define value

2019-11-06 Thread Flavia Musatescu
Fix the RTE_IPV4_VHL_DEF macro that represents the value for the IPv4 VHL and Minimum IHL header fields according to rfc791. Fixes: 2318d8d54565 ("net: define IPv4 IHL and VHL") Cc: saleh...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Flavia Musatescu --- lib/librte_net/rte_ip.h | 2 +- 1 f

Re: [dpdk-dev] [RFC 3/4] cryptodev: introduce cpu-crypto API

2019-11-06 Thread Ananyev, Konstantin
Hi Akhil, > > This patch extends rte_cryptodev API with CPU-CRYPTO mode. > > This is done by reusing existing rte_crypto_sym_session structure itself > > and related control-path cryptodev API (init/clear/get_size/etc.) > > For data-path new sym_cpu_ process() function is added into > > rte_cryp

Re: [dpdk-dev] [PATCH v2] test: fix process dup fd close

2019-11-06 Thread David Marchand
On Mon, Sep 2, 2019 at 11:50 AM wrote: > > From: Krzysztof Kanas > > process_dup was intending to close it's own fd's but failed to do so Please, explain how you caught the issue and what the impact was on your system. > > Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org > > Si

[dpdk-dev] [PATCH 2/2] event/dpaa2: support ordered queue case type

2019-11-06 Thread Nipun Gupta
Ordered queue is supported on DPAA2. Enable this case. Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 4ee2c460e..d713616

Re: [dpdk-dev] [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring

2019-11-06 Thread Shally Verma
> -Original Message- > From: Trybula, ArturX > Sent: Wednesday, November 6, 2019 5:03 PM > To: Shally Verma ; dev@dpdk.org; Trahe, Fiona > ; Dybkowski, AdamX > ; akhil.go...@nxp.com; Ashish Gupta > > Subject: RE: [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring > > > >

[dpdk-dev] [PATCH 1/2] raw/dpaa2_qdma: add support for route by port in DMA

2019-11-06 Thread Nipun Gupta
RBP or route by ports can help in translating the DMA address over the PCI. Thus adding the RBP support with long and short formats Signed-off-by: Minghuan Lian Signed-off-by: Sachin Saxena Signed-off-by: Nipun Gupta --- .../bus/fslmc/qbman/include/fsl_qbman_base.h | 84 drivers/raw/dpa

[dpdk-dev] [PATCH 01/19] net/mlx5: add meter operation callback

2019-11-06 Thread Suanming Mou
Add the new mlx5_flow_meter.c file for metering support. Signed-off-by: Suanming Mou --- drivers/net/mlx5/Makefile | 6 ++ drivers/net/mlx5/meson.build | 3 +++ drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 4 drivers/net/mlx5/mlx5_fl

[dpdk-dev] [PATCH 02/19] net/mlx5: fill meter capabilities using DevX

2019-11-06 Thread Suanming Mou
This commit add the support of fill and get the meter capabilities from DevX. Support items: 1. The srTCM color bind mode. 2. Meter share with multiple flows. 3. Action drop. The color aware mode and multiple meter chaining in a flow are not supported. New internal function in rte_mtr_ops callba

[dpdk-dev] [PATCH 03/19] net/mlx5: allocate flow meter registers

2019-11-06 Thread Suanming Mou
Meter need the metadata REG_C to have the color match between the prefix flow and the meter flow. As the user define or metadata feature will both use the REG_C in the suffix flow, the color match register meter uses will not impact the register use in the later sub flow. Another case is that tag

[dpdk-dev] [PATCH 00/19] net/mlx5: support meter

2019-11-06 Thread Suanming Mou
The patches introduce the meter action support for mlx5. The design of the implementation was introduced in RFC as below: http://inbox.dpdk.org/dev/b994cd03-02f6-cd50-120f-dcf0941e4...@mellanox.com The implementation is followed RFC to split flow with meter to three sub flows. Prefix flow -> Meter

[dpdk-dev] [PATCH 04/19] net/mlx5: support meter profile operations

2019-11-06 Thread Suanming Mou
This commit add the support of meter profile add and delete operations. New internal functions in rte_mtr_ops callback: 1. meter_profile_add() 2. meter_profile_delete() Only RTE_MTR_SRTCM_RFC2697 algorithm is supported and can be added. To add other algorithm will report an error. Signed-off-by:

[dpdk-dev] [PATCH 09/19] net/mlx5: add meter action creation to the glue

2019-11-06 Thread Suanming Mou
This commit add the meter action creation to the glue code. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_glue.c | 30 ++ drivers/net/mlx5/mlx5_glue.h | 9 + 2 files changed, 39 insertions(+) diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/ml

[dpdk-dev] [PATCH 07/19] net/mlx5: add policer rules operations

2019-11-06 Thread Suanming Mou
This commit create the color rules on the meter table for the packets. As the prefix flow with meter action colors the packets, the packets are transferred to the meter table with meter color match flows. Here we create the flow rules with green yellow red actions on the meter table. Packets matc

[dpdk-dev] [PATCH 11/19] net/mlx5: support meter profile update

2019-11-06 Thread Suanming Mou
This commit add the meter profile update support. New internal function in rte_mtr_ops callback: 1. meter_profile_update() Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_meter.c | 70 +- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 08/19] net/mlx5: support basic meter operations

2019-11-06 Thread Suanming Mou
This commit add the basic meter operations for meter create and destroy. New internal functions in rte_mtr_ops callback: 1. create() 2. destroy() The create() callback will create the corresponding flow rules on the meter table. The destroy() callback destroys the flow rules on the meter table.

[dpdk-dev] [PATCH 05/19] net/mlx5: validate meter profile

2019-11-06 Thread Suanming Mou
The add meter profile should be validated if it is valid or has been add to the list. Invalid and exist profile should not be add to the list. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_meter.c | 70 ++ drivers/net/mlx5/mlx5_prm.h| 5 +

[dpdk-dev] [PATCH 06/19] net/mlx5: prepare meter flow tables

2019-11-06 Thread Suanming Mou
This commit prepare the meter table and suffix table. A flow with meter will be split to three flows. The three flows are created on differnet tables. The packets transfer between the flows on the tables as below: Prefix flow -> Meter flow -> Suffix flow Prefix flow does the user defined match a

[dpdk-dev] [PATCH 10/19] net/mlx5: support meter modification operations

2019-11-06 Thread Suanming Mou
This commit add meter enable and disable supoort. New internal functions in rte_mtr_ops callback: 1. meter_enable() 2. meter_disable() The meter_enable() enables the meter action and the meter_disable() disables the meter action. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH 12/19] net/mlx5: expose flow counters management

2019-11-06 Thread Suanming Mou
Expose the flow counter management mechanism for other components to use. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5.h | 4 ++ drivers/net/mlx5/mlx5_flow.c| 83 + drivers/net/mlx5/mlx5_flow.h| 11 ++ drivers/net/mlx5/mlx5_fl

[dpdk-dev] [PATCH 14/19] net/mlx5: add meter statistics read and update

2019-11-06 Thread Suanming Mou
This commit add the meter statistics read and update to check the meter statistics. New internal functions in rte_mtr_ops callback: 1. stats_update() 2. stats_read() Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_meter.c | 140 - 1 file changed, 1

[dpdk-dev] [PATCH 15/19] net/mlx5: add meter attach and detach

2019-11-06 Thread Suanming Mou
Add the meter attach and detach for the flow create. When create the flow with meter, first try to find any created meter action matches the flow meter id. If the meter action is already created, just attach to it and increase the ref_cnt. If not, create one. For the dettach, decrease the ref_cnt

[dpdk-dev] [PATCH 17/19] net/mlx5: split meter flow

2019-11-06 Thread Suanming Mou
The flow with meter action will be divided to three sub flows, the prefix flow, the meter flow and the suffix flow. For these three sub flows, as the prefix flow and meter flow have the meter color match. In order the make the packet from prefix flow to match with the suffix flow, an extra metadat

[dpdk-dev] [PATCH 16/19] net/mlx5: support meter flow action

2019-11-06 Thread Suanming Mou
Add meter flow action support in flow validate and translate. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 95 + 1 file changed, 95 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index ded

[dpdk-dev] [PATCH 19/19] net/mlx5: clean meter resources

2019-11-06 Thread Suanming Mou
When the port is closed or program exits ungraceful, the meter rulers should be flushed after the flow destroyed. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5.c| 1 + drivers/net/mlx5/mlx5_flow.h | 2 ++ drivers/net/mlx5/mlx5_flow_meter.c | 61 +++

[dpdk-dev] [PATCH 18/19] net/mlx5: share tag between meter and metadata

2019-11-06 Thread Suanming Mou
In the meter flow split, metadata flow will be as the sub flow of meter suffix flow. In meter suffix flow, there is already a unique id tag exist as for the meter prefix and suffix flow match. Make metadata feature and meter both share the unique id tag for match. Signed-off-by: Suanming Mou ---

Re: [dpdk-dev] [PATCH v3] ethdev: enhance the API for getting burst mode information

2019-11-06 Thread Ferruh Yigit
On 11/6/2019 10:49 AM, Wang, Haiyue wrote: >> -Original Message- >> From: Thomas Monjalon >> Sent: Wednesday, November 6, 2019 17:20 >> To: Wang, Haiyue >> Cc: dev@dpdk.org; jerinjac...@gmail.com; Yigit, Ferruh >> ; >> arybche...@solarflare.com; viachesl...@mellanox.com; damar...@cisco.c

<    1   2   3   >