Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-11-05 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > > > > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > > > > > Hi All, > > > > > > > > > > > > > > > > This patchset would need ack from more vendors as it will impact > > > > > > > > user > > > > > > > experience > > > > > > > > on a key example appl

[dpdk-dev] [PATCH 00/20] net/mlx5: implement extensive metadata feature

2019-11-05 Thread Viacheslav Ovsiienko
The modern networks operate on the base of the packet switching approach, and in-network environment data are transmitted as the packets. Within the host besides the data, actually transmitted on the wire as packets, there might some out-of-band data helping to process packets. These data are named

[dpdk-dev] [PATCH 03/20] net/mlx5: add metadata register copy

2019-11-05 Thread Viacheslav Ovsiienko
Add flow metadata register copy action which is supported through modify header command. As it is an internal action, not exposed to users, item type (MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG) is negative value. This can be used when creating PMD internal subflows. Signed-off-by: Yongseok Koh Signed-o

[dpdk-dev] [PATCH 02/20] net/mlx5: update modify header action translator

2019-11-05 Thread Viacheslav Ovsiienko
When composing device command for modify header action, provided mask should be taken more accurate into account thus length and offset in action should be set accordingly at precise bit-wise boundaries. For the future use, metadata register copy action is also added. Signed-off-by: Yongseok Koh

[dpdk-dev] [PATCH 01/20] net/mlx5: convert internal tag endianness

2019-11-05 Thread Viacheslav Ovsiienko
Public API RTE_FLOW_ACTION_TYPE_TAG and RTE_FLOW_ITEM_TYPE_TAG present data in host-endian format, as all metadata related entities. The internal mlx5 tag related action and item should use the same endianness to be conformed. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH 05/20] net/mlx5: update flow functions

2019-11-05 Thread Viacheslav Ovsiienko
Update flow creation/destroy functions for future reuse. List operations can be skipped inside functions and done separately out of flow creation. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 14 ++ 1 file

[dpdk-dev] [PATCH 06/20] net/mlx5: update meta register matcher set

2019-11-05 Thread Viacheslav Ovsiienko
Introduce the dedicated matcher register field setup routine. Update the code to use this unified one. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 171 +++- 1 file changed, 82 in

[dpdk-dev] [PATCH 04/20] net/mlx5: refactor flow structure

2019-11-05 Thread Viacheslav Ovsiienko
Some rte_flow fields which are local to subflows have been moved to mlx5_flow structure. RSS attributes are grouped by mlx5_flow_rss structure. tag_resource is moved to mlx5_flow_dv structure. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net

[dpdk-dev] [PATCH 07/20] net/mlx5: rename structure and function

2019-11-05 Thread Viacheslav Ovsiienko
There are some renaming: - in the DV flow engine overall: flow_d_* -> flow_dv_* - in flow_dv_translate(): res -> mhdr_res Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 151 1

[dpdk-dev] [PATCH 09/20] net/mlx5: add devarg for extensive metadata support

2019-11-05 Thread Viacheslav Ovsiienko
The PMD parameter dv_xmeta_en is added to control extensive metadata support. A nonzero value enables extensive flow metadata support if device is capable and driver supports it. This can enable extensive support of MARK and META item of rte_flow. The newly introduced SET_TAG and SET_META actions d

[dpdk-dev] [PATCH 10/20] net/mlx5: adjust shared register according to mask

2019-11-05 Thread Viacheslav Ovsiienko
The metadata register reg_c[0] might be used by kernel or firmware for their internal purposes. The actual used mask can be queried from the kernel. The remaining bits can be used by PMD to provide META or MARK feature. The code queries the mask of reg_c[0] and adjust the resource usage dynamically

[dpdk-dev] [PATCH 11/20] net/mlx5: check the maximal modify actions number

2019-11-05 Thread Viacheslav Ovsiienko
If the extensive metadata registers are supported, it can be regarded inclusively that the extensive metadata support is possible. E.g. metadata register copy action, supporting 16 modify header actions, reserving register across different steering domain (FDB and NIC) and so on. This patch handle

[dpdk-dev] [PATCH 12/20] net/mlx5: update metadata register id query

2019-11-05 Thread Viacheslav Ovsiienko
The NIC might support up to 8 extensive metadata registers. These registers are supposed to be used by multiple features. There is register id query routine to allow determine which register is actually used by specified feature. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- dri

[dpdk-dev] [PATCH 13/20] net/mlx5: add flow tag support

2019-11-05 Thread Viacheslav Ovsiienko
Add support of new rte_flow item and action - TAG and SET_TAG. TAG is a transient value which can be kept during flow matching. This is supported through device metadata register reg_c[]. Although there are 8 registers are available on the current mlx5 device, some of them can be reserved for firm

[dpdk-dev] [PATCH 08/20] net/mlx5: check metadata registers availability

2019-11-05 Thread Viacheslav Ovsiienko
The metadata registers reg_c provide support for TAG and SET_TAG features. Although there are 8 registers are available on the current mlx5 devices, some of them can be reserved. The availability should be queried by iterative trial-and-error implemented by mlx5_flow_discover_mreg_c() routine. If

[dpdk-dev] [PATCH v2 1/2] config: remove redundant dpaa2 build

2019-11-05 Thread Hemant Agrawal
dpaa and dpaa2 config have evolved to be same. The same binary can now work across the platforms. So, there is no need to maintain two different build configs. The dpaa config shall work for both generation of dpaa platforms. Signed-off-by: Hemant Agrawal --- config/arm/arm64_dpaa2_linux_gcc

[dpdk-dev] [PATCH v2 2/2] doc: bump the supported SDK and firmware version

2019-11-05 Thread Hemant Agrawal
This patch bump the supported SDK and MC firmware version to the latest. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 4 ++-- doc/guides/eventdevs/dpaa2.rst | 4 ++-- doc/guides/nics/dpaa2.rst | 4 ++-- doc/guides/platform/dpaa2.rst | 7 +-- do

[dpdk-dev] [PATCH 16/20] net/mlx5: add meta data support to Rx datapath

2019-11-05 Thread Viacheslav Ovsiienko
This patch moves metadata from completion descriptor to appropriate dynamic mbuf field. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_prm.h | 6 -- drivers/net/mlx5/mlx5_rxtx.c | 6 ++ drivers/

[dpdk-dev] [PATCH 15/20] net/mlx5: extend flow meta data support

2019-11-05 Thread Viacheslav Ovsiienko
META item is supported on both Rx and Tx. 'transfer' attribute is also supported. SET_META action is also added. Due to restriction on reg_c[meta], various bit width might be available. If devarg parameter dv_xmeta_en=1, the META uses metadata register reg_c[0], which may be required for internal

[dpdk-dev] [PATCH 14/20] net/mlx5: extend flow mark support

2019-11-05 Thread Viacheslav Ovsiienko
Flow MARK item is newly supported along with MARK action. MARK action and item are supported on both Rx and Tx. It works on the metadata reg_c[] only if extensive flow metadata register is supported. Without the support, MARK action behaves same as before - valid only on Rx and no MARK item is vali

[dpdk-dev] [PATCH 18/20] net/mlx5: introduce flow splitters chain

2019-11-05 Thread Viacheslav Ovsiienko
The mlx5 hardware has some limitations and flow might require to be split into multiple internal subflows. For example this is needed to provide the meter object sharing between multiple flows or to provide metadata register copying before final queue/rss action. The multiple features might requir

[dpdk-dev] [PATCH 20/20] net/mlx5: add metadata register copy table

2019-11-05 Thread Viacheslav Ovsiienko
While reg_c[meta] can be copied to reg_b simply by modify-header action (it is supported by hardware), it is not possible to copy reg_c[mark] to the STE flow_tag as flow_tag is not a metadata register and this is not supported by hardware. Instead, it should be manually set by a flow per each uniqu

[dpdk-dev] [PATCH 17/20] net/mlx5: add simple hash table

2019-11-05 Thread Viacheslav Ovsiienko
Simple hash table is added. Hash function is modulo operator and no conflict is allowed. Key must be unique. It would be useful in managing a resource pool having finite unique keys, e.g. flow table entry with unique flow ID. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-

[dpdk-dev] [PATCH] net/mlx5: allow pattern start from IP

2019-11-05 Thread Xiaoyu Min
Some applications, i.e. OVS, have rule like: [1] pattern ipv4 / end actions ... which intends to match ipv4 only on non-vlan ethernet and MLX5 NIC supports this. So PMD should accept this. Fixes: 906a2efae8da ("net/mlx5: validate flow rule item order") Signed-off-by: Xiaoyu Min --- drivers/n

[dpdk-dev] [PATCH 19/20] net/mlx5: split Rx flows to provide metadata copy

2019-11-05 Thread Viacheslav Ovsiienko
Values set by MARK and SET_META actions should be carried over to the VF representor in case of flow miss on Tx path. However, as not all metadata registers are preserved across the different domains (NIC Rx/Tx and E-Switch FDB), as a workaround, those values should be carried by reg_c's which are

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-05 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 5, 2019 8:50 AM > To: Ori Kam ; Thomas Monjalon > > Cc: dev@dpdk.org; pbhagavat...@marvell.com; ferruh.yi...@intel.com; > jer...@marvell.com; John McNamara ; Marko > Kovacevic ; Adrien Mazarguil > ; david.march...@r

[dpdk-dev] [PATCH] net/ice: fix FDIR counter resource release

2019-11-05 Thread Wang ShougangX
To avoid memory leak, all the counter resources should be released when teardown. Fixes: 0f880c3df192 ("net/ice: add flow director counter resource init/release") Cc: sta...@dpdk.org Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 7 ++- 1 file changed, 6 insertions(+)

[dpdk-dev] [PATCH 0/3] support API to set max LRO packet size

2019-11-05 Thread Dekel Peled
This series implements support and use of API for configuration and validation of max size for LRO aggregated packet. Dekel Peled (3): ethdev: support API to set max LRO packet size net/mlx5: use API to set max LRO packet size app/testpmd: use API to set max LRO packet size app/test-pmd/cm

[dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size

2019-11-05 Thread Dekel Peled
This patch implements [1], to support API for configuration and validation of max size for LRO aggregated packet. API change notice [2] is removed, and release notes for 19.11 are updated accordingly. Various PMDs using LRO offload are updated, the new data members are initialized to ensure they d

[dpdk-dev] [PATCH 2/3] net/mlx5: use API to set max LRO packet size

2019-11-05 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. Rx queue create is updated to use the relevant configuration. Documentation is updated accordingly. Signed-off-by: Dekel Peled --- doc/guides/nics/mlx5.rst| 2 ++ drivers/net/mlx5/mlx5_rxq.c | 4 +++- 2 files changed, 5

[dpdk-dev] [PATCH 3/3] app/testpmd: use API to set max LRO packet size

2019-11-05 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. It adds command-line and runtime commands to configure this value, and adds option to show the supported value. Documentation is updated accordingly. Signed-off-by: Dekel Peled --- app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

2019-11-05 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > > > > > > Hi All, > > > > > > > > > > > > > > > > > > This patchset would need ack from more vendors as it will > > > > > > > > > impact > > > > > > > > > user > > > > > > > > experience > > > > > > > > > on a k

[dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec

2019-11-05 Thread Xiaoyu Min
When rte_flow_expand_rss expands rte_flow item list based on the RSS types. In another word, it will add some rte_flow items if the user specified items are not complete, for example: ... pattern eth / end actions rss type tcp end ... above flow will be expaned to: ... pattern eth / end acti

Re: [dpdk-dev] [PATCH v2 1/2] config: remove redundant dpaa2 build

2019-11-05 Thread David Marchand
On Tue, Nov 5, 2019 at 9:05 AM Hemant Agrawal wrote: > > dpaa and dpaa2 config have evolved to be same. The same binary > can now work across the platforms. So, there is no need to maintain > two different build configs. > The dpaa config shall work for both generation of dpaa platforms. > > Signe

Re: [dpdk-dev] [PATCH v2 2/2] doc: bump the supported SDK and firmware version

2019-11-05 Thread David Marchand
On Tue, Nov 5, 2019 at 9:05 AM Hemant Agrawal wrote: > > This patch bump the supported SDK and MC firmware version > to the latest. > > Signed-off-by: Hemant Agrawal > --- > doc/guides/cryptodevs/dpaa2_sec.rst | 4 ++-- > doc/guides/eventdevs/dpaa2.rst | 4 ++-- > doc/guides/nics/dpaa2.rst

[dpdk-dev] [PATCH] net/ice: fix removal of FDIR profile

2019-11-05 Thread Wang ShougangX
The removal of FDIR profile should start from ICE_FLTR_PTYPE_NONF_IPV4_UDP. Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") Cc: sta...@dpdk.org Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH 0/3] support API to set max LRO packet size

2019-11-05 Thread Matan Azrad
From: Dekel Peled > This series implements support and use of API for configuration and > validation of max size for LRO aggregated packet. > > Dekel Peled (3): > ethdev: support API to set max LRO packet size > net/mlx5: use API to set max LRO packet size > app/testpmd: use API to set ma

Re: [dpdk-dev] [PATCH 00/20] net/mlx5: implement extensive metadata feature

2019-11-05 Thread Matan Azrad
From: Viacheslav Ovsiienko > The modern networks operate on the base of the packet switching > approach, and in-network environment data are transmitted as the packets. > Within the host besides the data, actually transmitted on the wire as packets, > there might some out-of-band data helping to

[dpdk-dev] [PATCH] net/ice: fix wild pointer

2019-11-05 Thread Wang ShougangX
To avoid wild pointer, pointers should be set to NULL after free them. Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Cc: sta...@dpdk.org Signed-off-by: Wang ShougangX --- drivers/net/ice/ice_fdir_filter.c |

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/ixgbe: add ptype parse for aarch64 vector PMD

2019-11-05 Thread Ferruh Yigit
On 10/24/2019 3:58 AM, Ruifeng Wang wrote: > Ptype parse is missing in aarch64 vector PMD. It makes packet type info > provided by NIC get lost, thus requires extra CPU cycles to do this. > Add the parse process to utilize NIC hardware capability. > > In test with l3fwd (removed port conf DEV_RX_O

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-11-05 Thread Luca Boccassi
On Mon, 2019-11-04 at 11:16 +, Bruce Richardson wrote: > On Fri, Nov 01, 2019 at 11:54:45AM +, Luca Boccassi wrote: > > For distros, out-of-tree kernel modules are painful. From my POV, > > it > > would be preferable to try and find a solution upstream, even if it > > is > > going to be dif

Re: [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec

2019-11-05 Thread Thomas Monjalon
Hi Jack, If it is a fix, please change your title. 05/11/2019 10:16, Xiaoyu Min: > When rte_flow_expand_rss expands rte_flow item list based on the RSS > types. There is no verb in this sentence. > In another word, it will add some rte_flow items if the user What is "it"? > specified items ar

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-05 Thread David Marchand
Hello Anatoly, Yasufumi, On Mon, Nov 4, 2019 at 11:20 AM Burakov, Anatoly wrote: > > On 01-Nov-19 9:04 AM, yasufu...@gmail.com wrote: > > From: Yasufumi Ogawa > > > > In secondary_msl_create_walk(), it creates a file for fbarrays with its > > PID for reserving unique name among secondary process

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-11-05 Thread Hideyuki Yamashita
Dear Slava, Thanks for your response. Inputting other flows failed while some flows are created. Please help on the following two cases. 1) I would like to detag vlan tag which has specific destionation MAC address. No condition about vlan id value. testpmd> flow create 0 ingress group 1 patte

[dpdk-dev] [PATCH v12 0/2] add IOVA=VA mode support

2019-11-05 Thread vattunuru
From: Vamsi Attunuru --- V12 Changes: * Removed previously added `--legacy-kni` eal option. * Removed previously added kni specific mempool create routines and mempool populate routines. This patch set(V12) is dependent on following patch set, since the mempool related support to enable KNI in I

[dpdk-dev] [PATCH v12 1/2] kni: add IOVA=VA mode support

2019-11-05 Thread vattunuru
From: Vamsi Attunuru Current KNI implementation only operates in IOVA_PA mode patch adds required functionality to enable KNI in IOVA_VA mode. KNI can operate in IOVA_VA mode when this mode is requested using eal option (`iova-mode=va`) or when bus iommu scheme is selected as RTE_IOVA_VA. Durin

[dpdk-dev] [PATCH v12 2/2] kni: add IOVA=VA support in kernel module

2019-11-05 Thread vattunuru
From: Vamsi Attunuru Patch adds support for kernel module to work in IOVA = VA mode by providing address translation routines to convert IOVA aka user space VA to kernel virtual addresses. When compared with IOVA=PA mode, there is no drop in performance with this approach, also there is no perfo

Re: [dpdk-dev] [PATCH v5 01/10] config: change ABI versioning to global

2019-11-05 Thread David Marchand
On Thu, Oct 24, 2019 at 11:46 AM Anatoly Burakov wrote: > > From: Marcin Baran > > As per new ABI policy, all of the libraries are now versioned using > one global ABI version. Changes in this patch implement the > necessary steps to enable that. > > Signed-off-by: Marcin Baran > Signed-off-by:

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Ferruh Yigit
On 10/30/2019 11:53 PM, Ori Kam wrote: > This commit introduce hairpin queue type. > > The hairpin queue in build from Rx queue binded to Tx queue. > It is used to offload traffic coming from the wire and redirect it back > to the wire. > > There are 3 new functions: > - rte_eth_dev_hairpin_capab

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 11:35 AM, Ori Kam wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, November 5, 2019 8:50 AM >> To: Ori Kam ; Thomas Monjalon >> >> Cc: dev@dpdk.org; pbhagavat...@marvell.com; ferruh.yi...@intel.com; >> jer...@marvell.com; John McNamara ; Marko >> K

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-05 Thread Burakov, Anatoly
On 05-Nov-19 10:13 AM, David Marchand wrote: Hello Anatoly, Yasufumi, On Mon, Nov 4, 2019 at 11:20 AM Burakov, Anatoly wrote: On 01-Nov-19 9:04 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving uniq

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 5, 2019 1:25 PM > To: Ori Kam ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Andrew Rybchenko > Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org; Jerin > Jacob > Subject: Re: [PATCH v7 0

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-11-05 Thread Burakov, Anatoly
On 04-Nov-19 10:25 AM, Burakov, Anatoly wrote: On 30-Oct-19 7:50 PM, Rajesh Ravi wrote: Thanks Anatoly. Please findĀ  inline below: [Anatoly] vfio_mem_event_callback() is called every time memory is added to a heap. That includes internal and external memory [Rajesh] malloc_heap_add_external_

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

2019-11-05 Thread Ananyev, Konstantin
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, November 5, 2019 11:31 AM > To: David Marchand ; Yasufumi Ogawa > > Cc: Ananyev, Konstantin ; dev ; > dpdk stable ; Yasufumi Ogawa > > Subject: Re: [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary > > On

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 2:36 PM, Ori Kam wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, November 5, 2019 1:25 PM >> To: Ori Kam ; John McNamara >> ; Marko Kovacevic >> ; Thomas Monjalon ; >> Andrew Rybchenko >> Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 5, 2019 1:49 PM > To: Ori Kam ; Ferruh Yigit ; > John McNamara ; Marko Kovacevic > ; Thomas Monjalon > Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org; Jerin > Jacob > Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Ferruh Yigit
On 11/5/2019 11:49 AM, Andrew Rybchenko wrote: > On 11/5/19 2:36 PM, Ori Kam wrote: >> >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Tuesday, November 5, 2019 1:25 PM >>> To: Ori Kam ; John McNamara >>> ; Marko Kovacevic >>> ; Thomas Monjalon ; >>> Andrew Rybchenko >>> Cc: de

Re: [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec

2019-11-05 Thread Jack Min
On Tue, 19-11-05, 11:11, Thomas Monjalon wrote: > Hi Jack, > > If it is a fix, please change your title. > Ok, I will add 'fix' in title. > 05/11/2019 10:16, Xiaoyu Min: > > When rte_flow_expand_rss expands rte_flow item list based on the RSS > > types. > > There is no verb in this sentence. >

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 3:05 PM, Ferruh Yigit wrote: > On 11/5/2019 11:49 AM, Andrew Rybchenko wrote: >> On 11/5/19 2:36 PM, Ori Kam wrote: >>> >>> -Original Message- From: Ferruh Yigit Sent: Tuesday, November 5, 2019 1:25 PM To: Ori Kam ; John McNamara ; Marko Kovacevic ;

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-05 Thread Ilya Maximets
On 04.11.2019 21:33, Shahaf Shuler wrote: Monday, November 4, 2019 12:28 PM, Ilya Maximets: Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host On 03.11.2019 7:48, Shahaf Shuler wrote: Friday, November 1, 2019 11:33 AM, Ilya Maximets: Subject: Re: [dpdk-dev] [PATCH v2

Re: [dpdk-dev] [PATCH v3 7/7] mempool: use the specific macro for object alignment

2019-11-05 Thread Andrew Rybchenko
On 11/4/19 6:12 PM, Olivier Matz wrote: > For consistency, RTE_MEMPOOL_ALIGN should be used in place of > RTE_CACHE_LINE_SIZE. They have the same value, because the only arch > that was defining a specific value for it has been removed from dpdk. > > Signed-off-by: Olivier Matz > Reviewed-by: Andr

Re: [dpdk-dev] [PATCH v3 5/7] mempool: introduce helpers for populate and calc mem size

2019-11-05 Thread Andrew Rybchenko
On 11/4/19 6:12 PM, Olivier Matz wrote: > Introduce new functions that can used by mempool drivers to > calculate required memory size and to populate mempool. > > For now, these helpers just replace the *_default() functions > without change. They will be enhanced in next commit. > > Signed-off-by

Re: [dpdk-dev] [PATCH v7 0/4] add fallback session

2019-11-05 Thread Akhil Goyal
> > Add fallback session feature allowing to process packets that inline > processor is unable to handle (e.g. fragmented traffic). Processing > takes place in a secondary session defined for SA in a configuration > file. > > This feature is limited to ingress IPsec traffic only. IPsec > anti-rep

Re: [dpdk-dev] [PATCH v3 6/7] mempool: prevent objects from being across pages

2019-11-05 Thread Andrew Rybchenko
On 11/4/19 6:12 PM, Olivier Matz wrote: > When populating a mempool, ensure that objects are not located across > several pages, except if user did not request iova contiguous objects. > > Signed-off-by: Vamsi Krishna Attunuru > Signed-off-by: Olivier Matz > Acked-by: Nipun Gupta Acked-by: Andr

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Ferruh Yigit
On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: > On 11/5/19 3:05 PM, Ferruh Yigit wrote: >> On 11/5/2019 11:49 AM, Andrew Rybchenko wrote: >>> On 11/5/19 2:36 PM, Ori Kam wrote: > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 5, 2019 1:25 PM >

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 3:23 PM, Ferruh Yigit wrote: > On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: >> On 11/5/19 3:05 PM, Ferruh Yigit wrote: >>> On 11/5/2019 11:49 AM, Andrew Rybchenko wrote: On 11/5/19 2:36 PM, Ori Kam wrote: > >> -Original Message- >> From: Ferruh Yigit >> Se

Re: [dpdk-dev] [PATCH] vfio: fix getting default container

2019-11-05 Thread Shahaf Shuler
Monday, November 4, 2019 9:35 PM, David Marchand: > Subject: Re: [PATCH] vfio: fix getting default container > > On Mon, Nov 4, 2019 at 6:41 PM Anatoly Burakov > wrote: > > > > When requesting DMA mapping to default container, we are meant to > > supply the RTE_VFIO_DEFAULT_CONTAINER_FD value, ho

Re: [dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 11:40 AM, Dekel Peled wrote: > This patch implements [1], to support API for configuration and > validation of max size for LRO aggregated packet. > API change notice [2] is removed, and release notes for 19.11 > are updated accordingly. > > Various PMDs using LRO offload are updated, th

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function

2019-11-05 Thread Andrew Rybchenko
On 11/2/19 1:25 AM, Thomas Monjalon wrote: > 01/11/2019 11:55, Andrew Rybchenko: >> On 10/31/19 7:38 PM, Pavan Nikhilesh Bhagavatula wrote: 29/10/2019 16:37, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > Removed Items > - > --- a/lib/librte_ethdev/rte_ethde

Re: [dpdk-dev] [PATCH v3 7/7] mempool: use the specific macro for object alignment

2019-11-05 Thread Olivier Matz
On Tue, Nov 05, 2019 at 03:15:13PM +0300, Andrew Rybchenko wrote: > On 11/4/19 6:12 PM, Olivier Matz wrote: > > For consistency, RTE_MEMPOOL_ALIGN should be used in place of > > RTE_CACHE_LINE_SIZE. They have the same value, because the only arch > > that was defining a specific value for it has be

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Andrew Rybchenko
On 11/3/19 6:16 PM, Matan Azrad wrote > From: Andrew Rybchenko >> On 11/3/19 9:57 AM, Matan Azrad wrote: >>> Hi >>> >>> From: Andrew Rybchenko On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: >> From: Pavan Nikhilesh Bhagavatula >>> Hi Matan, >>> Hi Pavan >

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Thomas Monjalon
05/11/2019 13:27, Andrew Rybchenko: > On 11/5/19 3:23 PM, Ferruh Yigit wrote: > > On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: > >> On 11/5/19 3:05 PM, Ferruh Yigit wrote: > >>> On 11/5/2019 11:49 AM, Andrew Rybchenko wrote: > On 11/5/19 2:36 PM, Ori Kam wrote: >> From: Ferruh Yigit >

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 3:51 PM, Thomas Monjalon wrote: > 05/11/2019 13:27, Andrew Rybchenko: >> On 11/5/19 3:23 PM, Ferruh Yigit wrote: >>> On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: On 11/5/19 3:05 PM, Ferruh Yigit wrote: > On 11/5/2019 11:49 AM, Andrew Rybchenko wrote: >> On 11/5/19 2:36 PM,

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Thomas Monjalon
05/11/2019 13:53, Andrew Rybchenko: > On 11/5/19 3:51 PM, Thomas Monjalon wrote: > > 05/11/2019 13:27, Andrew Rybchenko: > >> On 11/5/19 3:23 PM, Ferruh Yigit wrote: > >>> On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: > On 11/5/19 3:05 PM, Ferruh Yigit wrote: > > On 11/5/2019 11:49 AM, An

Re: [dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size

2019-11-05 Thread Thomas Monjalon
05/11/2019 13:39, Andrew Rybchenko: > On 11/5/19 11:40 AM, Dekel Peled wrote: > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > +static inline int > > +rte_eth_check_lro_pkt_size(uint16_t port_id, uint32_t config_size, > > + uint32_t dev_info

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Ori Kam
Hi All > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 5, 2019 3:02 PM > To: Andrew Rybchenko > Cc: Ferruh Yigit ; Ori Kam ; > John McNamara ; Marko Kovacevic > ; dev@dpdk.org; jingjing...@intel.com; > step...@networkplumber.org; Jerin Jacob > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Thomas Monjalon
05/11/2019 14:23, Ori Kam: > From: Thomas Monjalon > > 05/11/2019 13:53, Andrew Rybchenko: > > > On 11/5/19 3:51 PM, Thomas Monjalon wrote: > > > > 05/11/2019 13:27, Andrew Rybchenko: > > > >> On 11/5/19 3:23 PM, Ferruh Yigit wrote: > > > >>> On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: > > > >>

Re: [dpdk-dev] [PATCH] net/mlx5: introdue mlx5 hash list

2019-11-05 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Tuesday, November 5, 2019 15:27 > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; Bing Zhao > Subject: [PATCH] net/mlx5: introdue mlx5 hash list > > From: Bing Zhao > > Introduce simple hash list to the mlx5 utiliti

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 4:27 PM, Thomas Monjalon wrote: > 05/11/2019 14:23, Ori Kam: >> From: Thomas Monjalon >>> 05/11/2019 13:53, Andrew Rybchenko: On 11/5/19 3:51 PM, Thomas Monjalon wrote: > 05/11/2019 13:27, Andrew Rybchenko: >> On 11/5/19 3:23 PM, Ferruh Yigit wrote: >>> On 11/5/2019 12:

Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 4:02 PM, Thomas Monjalon wrote: > 05/11/2019 13:53, Andrew Rybchenko: >> On 11/5/19 3:51 PM, Thomas Monjalon wrote: >>> 05/11/2019 13:27, Andrew Rybchenko: On 11/5/19 3:23 PM, Ferruh Yigit wrote: > On 11/5/2019 12:12 PM, Andrew Rybchenko wrote: >> On 11/5/19 3:05 PM, Ferruh

[dpdk-dev] [PATCH v2] ethdev: fix expand RSS flows

2019-11-05 Thread Xiaoyu Min
rte_flow_expand_rss expands rte_flow item list based on the RSS types. In another word, some additional rules are added if the user specified items are not complete enough according to the RSS type, for example: ... pattern eth / end actions rss type tcp end ... User only provides item eth but

Re: [dpdk-dev] [PATCH v5 01/10] config: change ABI versioning to global

2019-11-05 Thread Bruce Richardson
On Tue, Nov 05, 2019 at 12:05:15PM +0100, David Marchand wrote: > On Thu, Oct 24, 2019 at 11:46 AM Anatoly Burakov > wrote: > > > > From: Marcin Baran > > > > As per new ABI policy, all of the libraries are now versioned using > > one global ABI version. Changes in this patch implement the > > ne

Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove

2019-11-05 Thread Ferruh Yigit
On 10/28/2019 5:51 AM, Yang, Qiming wrote: > Hi, > >> -Original Message- >> From: Di, ChenxuX >> Sent: Thursday, October 24, 2019 9:03 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Yang, Qiming >> ; Di, ChenxuX >> Subject: [PATCH] app/testpmd: fix device hotplug remove >> >> Hotplug remove

[dpdk-dev] Query on the old patch: examples/l3fwd: use reserved IPv4/IPv6 addresses

2019-11-05 Thread Hemant Agrawal
Hi Stephen, In one of your old patch, you have changed the default IP addresses to the range of 192.18.0.0 citing RFC 5735. commit 37afe381bde4277f0078116b8d4d7a315c8e39b3 Author: Stephen Hemminger Date: Wed Apr 10 10:41:31 2019 -0700 examples/l3fwd: use reserved IP addresses how

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Matan Azrad
From: Andrew Rybchenko > On 11/3/19 6:16 PM, Matan Azrad wrote > > From: Andrew Rybchenko > >> On 11/3/19 9:57 AM, Matan Azrad wrote: > >>> Hi > >>> > >>> From: Andrew Rybchenko > On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: > >> From: Pavan Nikhilesh Bhagavatula > >>> Hi

Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime configmmap issue

2019-11-05 Thread David Marchand
Hello Li Han, On Sat, Oct 26, 2019 at 6:07 PM David Marchand wrote: > I took Anatoly patches since his work on the subject preceded your patch. > Please, test the current master branch and see if you still have issues. Did you have a chance to test with the -rc1 tag? Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size

2019-11-05 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 5, 2019 2:40 PM > To: Dekel Peled ; john.mcnam...@intel.com; > marko.kovace...@intel.com; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > anatoly.bura...@intel.com; xuan

[dpdk-dev] [PATCH v10 0/2] extend flow metadata feature

2019-11-05 Thread Viacheslav Ovsiienko
This patchset just combines two metadata related patches to provide right applying order. The first patch introduces the ingress metadata with mbuf dynamic field usage, the second one moves egress metadata to the dynamic field presented by first patch. Viacheslav Ovsiienko (2): ethdev: extend fl

[dpdk-dev] [PATCH v10 2/2] ethdev: move egress metadata to dynamic field

2019-11-05 Thread Viacheslav Ovsiienko
The dynamic mbuf fields were introduced by [1]. The egress metadata is good candidate to be moved from statically allocated field tx_metadata to dynamic one. Because mbufs are used in half-duplex fashion only, it is safe to share this dynamic field with ingress metadata. The shared dynamic field c

[dpdk-dev] [PATCH v10 1/2] ethdev: extend flow metadata

2019-11-05 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r

Re: [dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 5:18 PM, Dekel Peled wrote: > Thanks, PSB. > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, November 5, 2019 2:40 PM >> To: Dekel Peled ; john.mcnam...@intel.com; >> marko.kovace...@intel.com; nhor...@tuxdriver.com; >> ajit.khapa...@broadcom.com; somnath.ko..

Re: [dpdk-dev] [PATCH v2] bus/pci: resolve multiple NICs address conflicts

2019-11-05 Thread David Marchand
On Tue, Nov 5, 2019 at 8:27 AM Wangyu (Turing Solution Development Dep) wrote: > > > NIC address conflicts on 64K pagesize when using multiple NICs, > as system will mmap 64K pagesize for NIC, > but dev->mem_resource[i].len is 16K. Please, can you describe the problem you want to fix? Is this a p

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 5:05 PM, Matan Azrad wrote: > From: Andrew Rybchenko >> On 11/3/19 6:16 PM, Matan Azrad wrote >>> From: Andrew Rybchenko On 11/3/19 9:57 AM, Matan Azrad wrote: > Hi > > From: Andrew Rybchenko >> On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: From: P

[dpdk-dev] [PATCH 0/9 v4] DPAA and FSLMC driver fixes and cleanup

2019-11-05 Thread Nipun Gupta
These patches incllude various fixes and some cleanups related to DPAA and FSLMC drivers Changes in v4: - Rebased on master branch. Due to some other changes patches were not getting applied on master Changes in v3: - Report error instead of panic for low FPBR's in BMAN (patch #7) Changes i

[dpdk-dev] [PATCH 1/9 v4] net/dpaa: fix supported RSS types

2019-11-05 Thread Nipun Gupta
This patch fixes the supported RSS types on DPAA platform Fixes: 15aa2a1b02e6 ("net/dpaa: update RSS offload types") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) d

[dpdk-dev] [PATCH 2/9 v4] net/dpaa: fix LS1043 alignment check

2019-11-05 Thread Nipun Gupta
On LS1043, we are good to check 128 byte alignment of offset to transmit out the packet Fixes: f8c7a17a48c9 ("net/dpaa: support scatter gather in Tx for non DPAA buffer") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 2 +- 1 file ch

[dpdk-dev] [PATCH 8/9 v4] bus/dpaa: moving qbman global init to bus

2019-11-05 Thread Nipun Gupta
From: Hemant Agrawal DPAA SEC shall be able to work independent of DPAA ETH driver. This patch moves qbman init to bus, so that any driver can use them even when no eth resources are present or none of the eth devices are probed. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers

[dpdk-dev] [PATCH 3/9 v4] common/dpaax: fallback to check separate memory node for VM

2019-11-05 Thread Nipun Gupta
In Virtual Machine the memory node in the device tree is at '/proc/device-tree/memory/reg' which is separate from the memory node path on the host. This patch enables check on both the paths. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-

[dpdk-dev] [PATCH 4/9 v4] net/dpaa2: add retry and timeout in packet enqueue API

2019-11-05 Thread Nipun Gupta
In the packet transmit, if the QBMAN is not able to process the packets, the Tx function loops infinitely to send the packet out. This patch changes the logic retry for some time (count) and then return. Fixes: cd9935cec873 ("net/dpaa2: enable Rx and Tx operations") Fixes: 16c4a3c46ab7 ("bus/fslmc

[dpdk-dev] [PATCH 5/9 v4] raw/dpaa2_qdma: add retry and timeout in packet enqueue API

2019-11-05 Thread Nipun Gupta
This patch adds the logic in the DPAA2 QDMA packet enqueue API Fixes: 4d9a3f2a0159 ("raw/dpaa2_qdma: support RBP mode") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletio

  1   2   3   >