On Tue, Nov 05, 2019 at 03:15:13PM +0300, Andrew Rybchenko wrote:
> On 11/4/19 6:12 PM, Olivier Matz wrote:
> > For consistency, RTE_MEMPOOL_ALIGN should be used in place of
> > RTE_CACHE_LINE_SIZE. They have the same value, because the only arch
> > that was defining a specific value for it has been removed from dpdk.
> >
> > Signed-off-by: Olivier Matz <olivier.m...@6wind.com>
> > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com>
> > Acked-by: Nipun Gupta <nipun.gu...@nxp.com>
> > ---
> > drivers/mempool/bucket/rte_mempool_bucket.c | 8 +++++++-
> > lib/librte_mempool/rte_mempool.c | 2 +-
> > lib/librte_mempool/rte_mempool.h | 3 +++
> > lib/librte_mempool/rte_mempool_ops_default.c | 2 +-
> > 4 files changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c
> > b/drivers/mempool/bucket/rte_mempool_bucket.c
> > index b978fd220..5ce1ef16f 100644
> > --- a/drivers/mempool/bucket/rte_mempool_bucket.c
> > +++ b/drivers/mempool/bucket/rte_mempool_bucket.c
> > @@ -401,6 +401,11 @@ bucket_alloc(struct rte_mempool *mp)
> > struct bucket_data *bd;
> > unsigned int i;
> > unsigned int bucket_header_size;
> > + size_t pg_sz;
> > +
> > + rc = rte_mempool_get_page_size(mp, &pg_sz);
> > + if (rc < 0)
> > + return rc;
>
> Looks unrelated to the patch.
Oops, indeed, every change in rte_mempool_bucket.c should be in patch 6/7
"mempool: prevent objects from being across pages", Thanks for spotting it.
>
> > bd = rte_zmalloc_socket("bucket_pool", sizeof(*bd),
> > RTE_CACHE_LINE_SIZE, mp->socket_id);
>
> [snip]
>
>
