Re: [dpdk-dev] [PATCH v2] cryptodev: fix check related to device id

Hi Julien, A couple of nits. Please see inline. Apart from that Acked-by: Akhil Goyal > > Each cryptodev are indexed with dev_id in the global rte_crypto_devices > variable. nb_devs is incremented / decremented each time a cryptodev is > created / deleted. The goal of nb_devs was to prevent th

Re: [dpdk-dev] [PATCH v2] net/ice: invoke callback func when link status change

> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, October 16, 2019 2:41 PM > To: Rong, Leyi > Cc: Lu, Wenzhuo ; Zhang, Qi Z ; > dev@dpdk.org > Subject: Re: [PATCH v2] net/ice: invoke callback func when link status change > > On 10/16, Leyi Rong wrote: > >Needs to call _rte_et

Re: [dpdk-dev] [PATCH v2] cryptodev: fix check related to device id

Hi, Inline reply On 16/10/2019 09:02, Akhil Goyal wrote: > Hi Julien, > > A couple of nits. Please see inline. > > Apart from that > Acked-by: Akhil Goyal > >> >> Each cryptodev are indexed with dev_id in the global rte_crypto_devices >> variable. nb_devs is incremented / decremented each tim

Re: [dpdk-dev] [PATCH v5] eventdev: flag to identify same destined packets enqueue

On Fri, Oct 11, 2019 at 6:48 PM Nipun Gupta wrote: > > This patch introduces a `flag` in the Eth TX adapter enqueue API. > Some drivers may support burst functionality only with the packets > having same destination device and queue. > > The flag `RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST` can be

Re: [dpdk-dev] rte_mempool_get_bulk uses either cache or common pool

Hi Morten, On Fri, Oct 11, 2019 at 01:24:00PM +0200, Morten Brørup wrote: > The rte_mempool_get_bulk() documentation says: > > "If cache is enabled, objects will be retrieved first from cache, > subsequently from the common pool." > > But __mempool_generic_get() only uses the cache if the reque

[dpdk-dev] [PATCH v2] net/mlx5: retry when link update fails

mlx5_link_update immediately returns when called with no-wait parameter and its call for retrieving the link status returns with EAGAIN error. This is too harsh on busy systems where a first call fails with EAGAIN from time to time. This patch adds a (very limited) retry on such cases in order to a

Re: [dpdk-dev] [PATCH v8 1/2] mbuf: add bulk free function

Hi, On Fri, Oct 11, 2019 at 12:14:57PM +, Morten Brørup wrote: > Add function for freeing a bulk of mbufs. > > Signed-off-by: Morten Brørup > Acked-by: Konstantin Ananyev > Reviewed-by: Andrew Rybchenko > Acked-by: Stephen Hemminger [...] > +/** > + * Size of the array holding mbufs fro

Re: [dpdk-dev] [PATCH 1/2] event/dpaa2: set priority as per the dpcon device

On Thu, Oct 10, 2019 at 5:59 PM Hemant Agrawal wrote: > > Acked-by: Hemant Agrawal There is a build issue with shared lib. config: x86_64-native-linuxapp-gcc+shared+debug /usr/bin/ld: dpaa2_eventdev.c:(.text+0x87): undefined reference to `rte_eth_dev_is_valid_port' /usr/bin/ld: dpaa2_eventdev

Re: [dpdk-dev] [PATCH v2] eal: don't call RTE_LOG before init

On Thu, Sep 19, 2019 at 3:31 PM Stephen Hemminger wrote: > > rte_init_alert is called before rte_log is initialized. rte_eal_init_alert* > Therefore RTE_LOG() should not be used (only stderr). There should be nothing disastrous when calling RTE_LOG() before rte_eal_log_init has been called. RTE

Re: [dpdk-dev] [PATCH v2] net/mlx5: retry when link update fails

> -Original Message- > From: Moti Haimovsky > Sent: Wednesday, October 16, 2019 10:34 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v2] net/mlx5: retry when link update fails > > mlx5_link_update immediately returns when called with no-wait parameter > a

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs

On Tue, Oct 15, 2019 at 1:20 PM Joyce Kong wrote: > > There are a lot functions of bit operations scattered and > duplicated in PMDs, consolidating them into a common API > family is necessary. Furthermore, the bit operation is > mostly applied to the IO devices, so use __ATOMIC_ACQ_REL > to ensur

Re: [dpdk-dev] [PATCH v8 2/2] mbuf: add unit test for bulk alloc/free functions

Hi Morten, On Fri, Oct 11, 2019 at 12:14:58PM +, Morten Brørup wrote: > Add unit test for functions for allocating and freeing a bulk of mbufs. > > Signed-off-by: Morten Brørup Few minor comments below. You can add my ack in the next version. > --- > app/test/test_mbuf.c | 171 +++

Re: [dpdk-dev] [PATCH 1/2] event/dpaa: fix number of supported atomic flows

On Wed, Oct 16, 2019 at 12:11 PM Hemant Agrawal wrote: > > Acked-by: Hemant Agrawal > Series applied to dpdk-next-eventdev/master. Thanks.

Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo

On Fri, Oct 4, 2019 at 3:05 PM Gujjar, Abhinandan S wrote: > > Hi Hemanth, > > I tried to test the series of patches on test with SW adapter. > Looks like, test hangs after 3rd case! > Not sure, if I am missing any params to be passed to the app or anything else > has to be done. Waiting for you

Re: [dpdk-dev] [PATCH v4 0/6] use WFE for locks and ring on aarch64

Hello guys, This series got a lot of attention from ARM people and it seems ready for integration. But I did not see comment from other architectures, could you have a look please? Thanks. -- David Marchand On Thu, Aug 22, 2019 at 8:13 AM Gavin Hu wrote: > > DPDK has multiple use cases where

[dpdk-dev] [PATCH v5] net/iavf: enable AVX2 for iavf

This patch enables AVX data path for iavf PMD. Signed-off-by: Leyi Rong --- v5: - Eliminates CONFIG_RTE_LIBRTE_IAVF_INC_VECTOR and __rte_weak. v4: - Romoves redundant IAVF_NO_VECTOR_FLAGS define. v3: - Adds release note. v2: - Fixes build error on aarch64. --- config/common_base

Re: [dpdk-dev] [PATCH v2 2/3] mbuf: move mbuf definition into a separate file

On Fri, Sep 27, 2019 at 02:50:53PM +0100, Konstantin Ananyev wrote: > Right now inclusion of rte_mbuf.h header can cause inclusion of > some arch/os specific headers. > That prevents it to be included directly by some > non-DPDK (but related) entities: KNI, BPF programs, etc. > To overcome that pro

[dpdk-dev] [PATCH] doc: fix unmatched double quotation mark

Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst b/doc/guides/sample_a

[dpdk-dev] [PATCH 1/2] net/mlx5: query HCA for enabled FLEX parser protos

This commit add querying the HCA which FLEX protocols are already enabled. Signed-off-by: Moti Haimovsky --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/net/mlx5/mlx5_prm.h | 12 3 files changed, 15 insertions(+) diff --git a/d

[dpdk-dev] [PATCH 2/2] net/mlx5: add flow match on GENEVE item

This commit adds support for matching flows on Geneve headers. Signed-off-by: Moti Haimovsky --- doc/guides/nics/mlx5.rst | 10 +++- doc/guides/rel_notes/release_19_11.rst | 1 + drivers/net/mlx5/mlx5.h| 2 + drivers/net/mlx5/mlx5_devx_cmds.c | 6 +++ driver

Re: [dpdk-dev] [PATCH v2 1/1] doc: document new compress perf option

Hi Adam, > > This patch documents the new compress perf tool > option --external-mbufs. > > Signed-off-by: Adam Dybkowski > --- This patch should have been merged with the " app/compress-perf: add --external-mbufs option" Please make sure that all documentation related patches go in the corre

Re: [dpdk-dev] [PATCH v9 00/18] add PCIe AER disable and IRQ support for ipn3ke

Hi, Andy I saw there are several compilation issues reported in patchwork, could you check it? Thanks, Xiaolong On 10/14, Andy Pei wrote: >This patch set adds PCIe AER disable and IRQ support for ipn3ke. >Disable PCIe AER is very useful when FPGA reload. IRQ is used very >widely in interrupt pro

[dpdk-dev] [Bug 354] net/tap can not get rx packet drop stats when packets be dropped in kernel (net/driver/tun.c)

https://bugs.dpdk.org/show_bug.cgi?id=354 Bug ID: 354 Summary: net/tap can not get rx packet drop stats when packets be dropped in kernel (net/driver/tun.c) Product: DPDK Version: 18.11 Hardware: x86 OS: Lin

Re: [dpdk-dev] [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare exchange

> -Original Message- > From: David Marchand > Sent: Tuesday, October 15, 2019 8:16 PM > To: Phil Yang (Arm Technology China) > Cc: tho...@monjalon.net; jer...@marvell.com; Gage Eads > ; dev ; hemant.agra...@nxp.com; > Honnappa Nagarahalli ; Gavin Hu (Arm > Technology China) ; nd > Subjec

Re: [dpdk-dev] make install with igb_uio

On Wed, Oct 16, 2019 at 05:26:49AM +, sachin gupta wrote: > + dev > On Tuesday, October 15, 2019, 04:28:11 PM GMT+5:30, sachin gupta > wrote: > > Hi,I would like to compile dpdk source without the igb_uio driver.Can > someone help with this. > RegardsSachin For builds using meso

[dpdk-dev] [PATCH v4 1/2] compress/qat: overflow catch for stateless compression

This patch adds out-of-space recoverable feature for stateless compression scenario to QuickAssist compressdev driver Signed-off-by: Artur Trybula --- drivers/compress/qat/qat_comp.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/compres

[dpdk-dev] [PATCH v4 0/2] Add overflow recovery for stateless compression

This patch adds out-of-space recoverable feature for stateless compression scenario to QuickAssist compressdev driver. Unit test was also created to verify the new feature. v4: - if a device doesn't support out-of-space recoverable feature, then instead of "failed", "unsupported" resul

[dpdk-dev] [PATCH v4 2/2] test/compress: unit test for stateless overflow recovery

Added unit test to check out-of-space recoverable feature. Signed-off-by: Artur Trybula --- app/test/test_compressdev.c | 280 ++-- 1 file changed, 233 insertions(+), 47 deletions(-) diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c index d47

Re: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add enqueue/dequeue ops

Hi Gavin, Thanks for your review and suggestion. I agree with your suggestion and would be taking up the rework. But since we are close to RC1, I would like to defer this to the next release cycle. This change would touch all features supported and hence, will require an extensive QA internally

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On 10/15/2019 5:19 PM, Jerin Jacob wrote: > On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit wrote: >> >> On 10/15/2019 3:16 PM, Jerin Jacob wrote: >>> @@ -36,13 +36,6 @@ VMDq = >>> SR-IOV = >>> DCB = >>> VLAN filter = >

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

Hi Flavio, On 10/15/19 8:59 PM, Flavio Leitner wrote: > The rte_vhost_dequeue_burst supports two ways of dequeuing data. > If the data fits into a buffer, then all data is copied and a > single linear buffer is returned. Otherwise it allocates > additional mbufs and chains them together to return

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On Wed, 16 Oct, 2019, 3:32 PM Ferruh Yigit, wrote: > On 10/15/2019 5:19 PM, Jerin Jacob wrote: > > On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit > wrote: > >> > >> On 10/15/2019 3:16 PM, Jerin Jacob wrote: > >>> @@ -36,13 +36,6 @@ VMDq = > >>> SR-IOV = > >>

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On 10/16/2019 11:08 AM, Jerin Jacob wrote: > > > On Wed, 16 Oct, 2019, 3:32 PM Ferruh Yigit, > wrote: > > On 10/15/2019 5:19 PM, Jerin Jacob wrote: > > On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit > wrote: > >> >

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On Wed, 16 Oct, 2019, 3:46 PM Ferruh Yigit, wrote: > On 10/16/2019 11:08 AM, Jerin Jacob wrote: > > > > > > On Wed, 16 Oct, 2019, 3:32 PM Ferruh Yigit, > > wrote: > > > > On 10/15/2019 5:19 PM, Jerin Jacob wrote: > > > On Tue, Oct 15, 2019 at 9:26 PM Ferruh

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

> > > > > Ok, so to confirm: > > Your only issue here is that patch is that we have to split ipsec-secgw > > SADB into > > two? > > > > No objections to other part: > > - search for given SPI value across both SPDs (IPv4 and IPv6) > > - for each positive result create a new SA. > > So if we ha

[dpdk-dev] [PATCH v3] cryptodev: fix check related to device id

Each cryptodev are indexed with dev_id in the global rte_crypto_devices variable. nb_devs is incremented / decremented each time a cryptodev is created / deleted. The goal of nb_devs was to prevent the user to get an invalid dev_id. Let's imagine DPDK has configured N cryptodevs. If the cryptodev=

Re: [dpdk-dev] [PATCH v6 01/13] vhost: add packed ring indexes increasing function

On 10/15/19 6:07 PM, Marvin Liu wrote: > When vhost doing [de]nqueue, vq's local variable last_[used/avail]_idx > will be inceased. Adding inline functions can avoid duplicated codes. When enqueuing or dequeuing, the virtqueue's local available and used indexes are increased. Other than that:

Re: [dpdk-dev] [PATCH v6 03/13] vhost: try to unroll for each loop

Hi Marvin, On 10/15/19 6:07 PM, Marvin Liu wrote: > Create macro for adding unroll pragma before for each loop. Batch > functions will be contained of several small loops which can be > optimized by compilers' loop unrolling pragma. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhos

Re: [dpdk-dev] [PATCH v6 06/13] vhost: add packed ring batch dequeue

On 10/15/19 6:07 PM, Marvin Liu wrote: > Add batch dequeue function like enqueue function for packed ring, batch > dequeue function will not support chained descritpors, single packet > dequeue function will handle it. > > Signed-off-by: Marvin Liu > > diff --git a/lib/librte_vhost/vhost.h b/

Re: [dpdk-dev] [PATCH v6 2/4] examples/ipsec-secgw: add fallback session feature

> > > > Inline processing is limited to a specified subset of traffic. It is > > > > often unable to handle more complicated situations, such as fragmented > > > > traffic. When using inline processing such traffic is dropped. > > > > > > > > Introduce fallback session for inline processing allo

Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU

On 10/16/2019 7:40 AM, David Marchand wrote: > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit wrote: >> >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote: >>> Starting with kernel version 4.10, there are new min/max MTU values in >>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by >

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

> > > > > Hi All, > > > > > > > > > > This patchset would need ack from more vendors as it will impact > > > > > user > > > > experience > > > > > on a key example application which is normally demonstrated to > > > customers. > > > > > > > > > > IPSec library is still evolving and there are new

Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU

On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit wrote: > > On 10/16/2019 7:40 AM, David Marchand wrote: > > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit wrote: > >> > >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote: > >>> Starting with kernel version 4.10, there are new min/max MTU values in > >>> net_

Re: [dpdk-dev] [RFC] Chacha20 Poly1305 Support

Hi Fiona, Thanks for your feedback, > > Hi, > > due to increasing interest of crypto protocols in Chacha20-Poly1305 > algorithm I would like to start discussion about adding it to cryptodev. > I would suggest adding something like: > > @@ -348,6 +348,8 @@ enum rte_crypto_aead_algorithm { >

Re: [dpdk-dev] [PATCH v6 07/13] vhost: flush enqueue updates by batch

On 10/15/19 6:07 PM, Marvin Liu wrote: > Buffer vhost enqueue shadowed ring flush action buffered number exceed > one batch. Thus virtio can receive packets at a faster frequency. The commit message isn't very clear to me. Could you please improve it? > Signed-off-by: Marvin Liu > > diff --g

Re: [dpdk-dev] [PATCH v6 08/13] vhost: flush batched enqueue descs directly

On 10/15/19 6:07 PM, Marvin Liu wrote: > Flush used elements when batched enqueue function is finished. > Descriptor's flags are pre-calculated as they will be reset by vhost. > > Signed-off-by: Marvin Liu > Reviewed-by: Gavin Hu > Reviewed-by: Maxime Coquelin

Re: [dpdk-dev] [PATCH v4 0/2] virtio: one way barrier for packed vring flags

On 9/17/19 7:28 AM, Joyce Kong wrote: > This patch set replaces the two-way barriers with C11 one-way barriers > for packed vring flags, when the frontend and backend are implemented > in software. > > By doing vhost-user + virtio-user case benchmarking, 9% performance gain > in the RFC2544 tes

Re: [dpdk-dev] [PATCH] net/virtio: get all pending Rx packets in altivec vectorized paths

On 9/30/19 8:42 PM, David Christensen wrote: > The loop to read packets does not take all packets as the number of > available packets (nb_used) is decremented in the loop. > Take all available packets provides a performance improvement of 3%. > > Fixes: fc3d66212fed ("virtio: add vector Rx") >

Re: [dpdk-dev] [PATCH v6 0/3] vhost: add support for IOVA_VA mode

On 10/9/19 1:54 PM, Adrian Moreno wrote: > Currently, IOVAs are assumed to be GPA when the dirty page logging > is performed. > > Add support for guest IOVA_VA mode by translating addresses > to GPA before doing the dirty page logging. > > Also, the guest_pages tracking mechanism used for zero

Re: [dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec vectorized functions

On 9/30/19 8:27 PM, David Christensen wrote: > With vectorized functions, only the rx stats for number of packets is > incremented. > Update also the other statistics. > Performance impact is about 2% > > Fixes: fc3d66212fed ("virtio: add vector Rx") > Cc: sta...@dpdk.org > Cc: thibaut.col...@6

Re: [dpdk-dev] [PATCH v11 0/9] vhost: support inflight share memory protocol feature

On 10/9/19 10:48 PM, Jin Yu wrote: > v2: > - specify the APIs are split-ring only > > v3: > - fix APIs issues and judge split or packed > > v4: > - add rte_vhost_ prefix and fix issues > > v5: > - add the packed ring support and add the vhost_blk example > > v6: > - revise get_vring_base fun

Re: [dpdk-dev] [PATCH] net/virtio: fix broken transmit functionality

On 10/15/19 10:11 AM, Andrew Rybchenko wrote: > Previous fix removes usage of rte_pktmbuf_prepend() to get pointer > to virtio net header which changes mbuf data_off and data_len. > Size of virtio net header is added to segment length when Tx descriptor > is composed, but segment address (calcul

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On 10/15/19 8:59 PM, Flavio Leitner wrote: > The rte_vhost_dequeue_burst supports two ways of dequeuing data. > If the data fits into a buffer, then all data is copied and a > single linear buffer is returned. Otherwise it allocates > additional mbufs and chains them together to return a multipl

Re: [dpdk-dev] [PATCH v4 0/2] Add overflow recovery for stateless compression

> -Original Message- > From: Trybula, ArturX > Sent: Wednesday, October 16, 2019 10:41 AM > To: dev@dpdk.org; Trahe, Fiona ; shal...@marvell.com; > Dybkowski, AdamX > ; Trybula, ArturX ; > akhil.go...@nxp.com > Subject: [PATCH v4 0/2] Add overflow recovery for stateless compression >

Re: [dpdk-dev] [EXT] Re: [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 15, 2019 9:16 PM > To: Yigit, Ferruh > Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; > tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > olivier.m...@6wind.com; ferruh.yi...@intel.com; anatoly.bura...@intel.com; > ar

Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library

On Sat, Oct 12, 2019 at 1:04 PM wrote: > > From: Jerin Jacob > > Update the armv8 crypto PMD maintainership. > > https://github.com/caviumnetworks/armv8_crypto external crypto > the library will not be maintained and probably removed soon > therefor updating the PMD documentation to reflect the s

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

> > > > > > no-iommu case is different where we cannot screw Linux netdev driver, you > > can create a damage to your self that's an acceptable compromise. > > > > In this case, when DPDK PF bound application dies then it will impact > > netdev VF driver as gets stalled and there is a security is

Re: [dpdk-dev] [PATCH v2 0/7] support all examples in a meson build

On Tue, 2019-10-15 at 14:35 +0100, Bruce Richardson wrote: > When build with meson, some examples were skipped when "- > Dexamples=all" > parameter was passed. Ignoring examples slated for removal by other > patches[1], this set adds support for building the rest of the > examples. > The only excep

Re: [dpdk-dev] [PATCH v3 0/3] add fallback session

> > Once again - you keep making statements without any evidence. > > Provide something more concrete here - description of packet and code flow > > (function names, exact lines of code) that you think will cause a problem. > > I saw atleast the ones below. It would be frivolous to assume that th

Re: [dpdk-dev] [pull-request] next-eventdev 19.11 PRE-RC1

On Wed, Oct 16, 2019 at 12:37 AM Thomas Monjalon wrote: > > 05/10/2019 15:50, Jerin Jacob Kollanukkaran: > > http://dpdk.org/git/next/dpdk-next-eventdev > > Was pulled on last Saturday. Thanks a lot. > > > Note: > > - I will be on vacation next week. > > - Following are the pending patches in

Re: [dpdk-dev] [PATCH v10 0/5] kni: add IOVA=VA support

> -Original Message- > From: dev On Behalf Of Yigit, Ferruh > Sent: Tuesday, October 15, 2019 9:05 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > olivier.m...@6wind.com; ferruh.yi...@intel.com; anatoly.bura...@intel.com; > arybche.

[dpdk-dev] [PATCH v3 0/1] doc: fix missing compress perf option

This patch documents the new compress perf tool option --external-mbufs. --- v3: * Change short log line, add missing Fixes header. v2: * Fix the indentation in comp_perf.rst file. Adam Dybkowski (1): doc: fix missing compress perf option doc/guides/rel_notes/release_19_11.rst | 5 + doc/

[dpdk-dev] [PATCH v3 1/1] doc: fix missing compress perf option

This patch documents the new compress perf tool option --external-mbufs. Fixes: c02e33b03075 ("app/compress-perf: add --external-mbufs option") Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_19_11.rst | 5 + doc/guides/tools/comp_perf.rst | 2 ++ 2 files changed, 7 i

Re: [dpdk-dev] [PATCH v6 09/13] vhost: buffer packed ring dequeue updates

On 10/15/19 6:07 PM, Marvin Liu wrote: > Buffer used ring updates as many as possible in vhost dequeue function > for coordinating with virtio driver. For supporting buffer, shadow used > ring element should contain descriptor's flags. First shadowed ring > index was recorded for calculating buf

Re: [dpdk-dev] [PATCH v6 00/10] example/l2fwd-event: introduce l2fwd-event example

On Mon, Oct 14, 2019 at 11:52 PM wrote: > > From: Pavan Nikhilesh > > This patchset adds a new application to demonstrate the usage of event > mode. The poll mode is also available to help with the transition. > > The following new command line parameters are added: > --mode: Dictates the mode o

Re: [dpdk-dev] [PATCH v6 10/13] vhost: optimize packed ring enqueue

On 10/15/19 6:07 PM, Marvin Liu wrote: > Optimize vhost device packed ring enqueue function by splitting batch > and single functions. Packets can be filled into one desc will be > handled by batch and others will be handled by single as before. > > Signed-off-by: Marvin Liu > Reviewed-by:

[dpdk-dev] [PATCH v2 00/10] Implement the new ABI policy and add helper scripts

This patchset prepares the codebase for the new ABI policy and adds a few helper scripts. There are two new scripts for managing ABI versions added. The first one is a Python script that will read in a .map file, flatten it and update the ABI version to the ABI version specified on the command-lin

[dpdk-dev] [PATCH v2 04/10] timer: remove deprecated code

From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_timer/rte_timer.c | 90 ++

[dpdk-dev] [PATCH v2 03/10] buildtools: add ABI update shell script

In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add this patch to split the shell script from previous commit - Fixup mi

[dpdk-dev] [PATCH v2 02/10] buildtools: add script for updating symbols abi version

From: Pawel Modrak Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is. Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov --- Notes: v2: - Reworked script to be pep8-compliant

[dpdk-dev] [PATCH v2 01/10] config: change ABI versioning for global

From: Marcin Baran The libraries should be maintained using global ABI versioning. The changes includes adding global ABI version support for both makefile and meson build system. Experimental libraries should be marked as 0. Signed-off-by: Marcin Baran Signed-off-by: Pawel Modrak Signed-off-b

[dpdk-dev] [PATCH v2 10/10] buildtools: add ABI versioning check script

From: Marcin Baran Add a shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, or EXPERIMENTAL). The following command was used to verify current source tree (assuming build directory is in ./build): find ./build/lib ./build/drivers -nam

[dpdk-dev] [PATCH v2 05/10] lpm: remove deprecated code

From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_lpm/rte_lpm.c | 996 ++--

[dpdk-dev] [PATCH v2 07/10] lib: change function suffix in distributor

From: Marcin Baran The functions and structures version 2.0 is still in use in librte_distributor for single packet mode but the version suffix "_v20" needs to be changed to "_single" in order to avoid confusion. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: Dave:

[dpdk-dev] [PATCH v2 08/10] drivers/octeontx: add missing public symbol

The logtype symbol was missing from the .map file. Add it. Fixes: d8dd31652cf4 ("common/octeontx: move mbox to common folder") Cc: pbhagavat...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: - add this patch to avoid compile breakage when bumping AB

[dpdk-dev] [PATCH v2 06/10] distributor: remove deprecated code

From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_distributor/rte_distributor.c | 56 +++--

Re: [dpdk-dev] [PATCH v3] cryptodev: fix check related to device id

> > Each cryptodev are indexed with dev_id in the global rte_crypto_devices > variable. nb_devs is incremented / decremented each time a cryptodev is > created / deleted. The goal of nb_devs was to prevent the user to get an > invalid dev_id. > > Let's imagine DPDK has configured N cryptodevs.

Re: [dpdk-dev] [PATCH v3 1/1] doc: fix missing compress perf option

> > This patch documents the new compress perf tool > option --external-mbufs. > > Fixes: c02e33b03075 ("app/compress-perf: add --external-mbufs option") > > Signed-off-by: Adam Dybkowski > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] doc: fix unmatched double quotation mark

> > Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide") > Cc: sta...@dpdk.org > > Signed-off-by: Xiao Wang > --- > doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [RFC PATCH 00/13] add eventmode to ipsec-secgw

> This series introduces event-mode additions to ipsec-secgw. This effort > is based on the proposed changes for l2fwd-event and the additions in > l3fwd for event support. > > With this series, ipsec-secgw would be able to run in eventmode. The > worker thread (executing loop) would be receivin

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, October 15, 2019 4:02 PM > To: Ananyev, Konstantin ; Zhang, Roy Fan > ; 'dev@dpdk.org' ; > De Lara Guarch, Pablo ; 'Thomas Monjalon' > ; Doherty, Declan > > Cc: 'Anoob Joseph' ; Jerin Jacob ; > Hem

Re: [dpdk-dev] [PATCH v4 0/2] Add overflow recovery for stateless compression

> > > -Original Message- > > From: Trybula, ArturX > > Sent: Wednesday, October 16, 2019 10:41 AM > > To: dev@dpdk.org; Trahe, Fiona ; > shal...@marvell.com; Dybkowski, AdamX > > ; Trybula, ArturX ; > akhil.go...@nxp.com > > Subject: [PATCH v4 0/2] Add overflow recovery for stateless com

[dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device

The rawdev xstats_reset function is now enabled. It is called when the ioat autotest completes, to reset all xstat values after they have been modified during testing. Signed-off-by: Ciara Power --- drivers/raw/ioat/ioat_rawdev.c | 38 + drivers/raw/ioat/ioat_ra

[dpdk-dev] [PATCH v2 1/2] sched: add support for 64 bit values

To support high bandwidth network interfaces, all rates (port, subport level token bucket and traffic class rates, pipe level token bucket and traffic class rates) and stats counters defined in public data structures (rte_sched.h) are modified to support 64 bit counters. Signed-off-by: Jasvinder S

[dpdk-dev] [PATCH v2 2/2] sched: modify internal structs and functions for 64 bit values

Modify internal structure and functions to support 64-bit values for rates and stats parameters. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- v2: - remove rte_sched_min_val_2_u32() from rte_sched_common.h - replace rte_sched_min_val_2_u32() by RTE_MIN in rte_sched.c - repla

Re: [dpdk-dev] [PATCH v2 07/10] lib: change function suffix in distributor

On 16/10/2019 13:43, Anatoly Burakov wrote: From: Marcin Baran The functions and structures version 2.0 is still in use in librte_distributor for single packet mode but the version suffix "_v20" needs to be changed to "_single" in order to avoid confusion. Signed-off-by: Marcin Baran Signed

[dpdk-dev] [PATCH] net/memif: add multiple memif data transmission support

When Multiple slave/master Memif interfaces are created in single process data transmission over second connection is not successful. Issue is because of "mq->in_port" is not initialized with "dev->data->port_id" in memif_msg_enq_add_ring() and memif_msg_receive_add_ring() functions, and while tra

Re: [dpdk-dev] [PATCH v2 01/10] config: change ABI versioning for global

On Wed, Oct 16, 2019 at 01:43:16PM +0100, Anatoly Burakov wrote: > From: Marcin Baran > > The libraries should be maintained using global > ABI versioning. The changes includes adding global > ABI version support for both makefile and meson > build system. Experimental libraries should be > marke

Re: [dpdk-dev] [PATCH v2 02/10] buildtools: add script for updating symbols abi version

On Wed, Oct 16, 2019 at 01:43:17PM +0100, Anatoly Burakov wrote: > From: Pawel Modrak > > Add a script that automatically merges all stable ABI's under one > ABI section with the new version, while leaving experimental > section exactly as it is. > > Signed-off-by: Pawel Modrak > Signed-off-by:

Re: [dpdk-dev] [PATCH v2 00/12] add OCTEON TX2 crypto PMD

Please rebase this series. Build cannot be verified by CI. There are apply issues. > > The series introduces poll mode driver to enable crypto offload engine > on Marvell OCTEON TX2 SoC. > > Changes in v2: > * Merged series adding sym features and asym features into one. > * Squashed patches as

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On 16.10.2019 13:13, Maxime Coquelin wrote: On 10/15/19 8:59 PM, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allocates additional mbufs and ch

Re: [dpdk-dev] [PATCH v2 03/10] buildtools: add ABI update shell script

On Wed, Oct 16, 2019 at 01:43:18PM +0100, Anatoly Burakov wrote: > In order to facilitate mass updating of version files, add a shell > script that recurses into lib/ and drivers/ directories and calls > the ABI version update script. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2:

Re: [dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device

On Wed, Oct 16, 2019 at 02:16:26PM +0100, Ciara Power wrote: > The rawdev xstats_reset function is now enabled. It is called when the > ioat autotest completes, to reset all xstat values after they have been > modified during testing. > > Signed-off-by: Ciara Power Reviewed-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v3 0/3] add fallback session

> > Hi Konstantin, > > Thanks for clarifying your stand on review comments. > > From the comments we(Marvell/Cavium) have received on multiple features, my > impression is that the feature need to be correct/fully > done/acceptable to the overall community. Features are usually agreed upon if

Re: [dpdk-dev] [PATCH v2 00/12] add OCTEON TX2 crypto PMD

Hi Akhil, I'll rebase the series and send in a short while. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 16, 2019 7:02 PM > To: Anoob Joseph ; Pablo de Lara > > Cc: Fiona Trahe ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Shally

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On 10/16/19 3:32 PM, Ilya Maximets wrote: > On 16.10.2019 13:13, Maxime Coquelin wrote: >> >> >> On 10/15/19 8:59 PM, Flavio Leitner wrote: >>> The rte_vhost_dequeue_burst supports two ways of dequeuing data. >>> If the data fits into a buffer, then all data is copied and a >>> single linear buf

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On Wed, 16 Oct 2019 15:46:15 +0200 Maxime Coquelin wrote: > On 10/16/19 3:32 PM, Ilya Maximets wrote: > > On 16.10.2019 13:13, Maxime Coquelin wrote: > >> > >> > >> On 10/15/19 8:59 PM, Flavio Leitner wrote: > >>> The rte_vhost_dequeue_burst supports two ways of dequeuing data. > >>> If the d

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On 16.10.2019 15:46, Maxime Coquelin wrote: On 10/16/19 3:32 PM, Ilya Maximets wrote: On 16.10.2019 13:13, Maxime Coquelin wrote: On 10/15/19 8:59 PM, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is cop

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On 16.10.2019 16:02, Flavio Leitner wrote: On Wed, 16 Oct 2019 15:46:15 +0200 Maxime Coquelin wrote: On 10/16/19 3:32 PM, Ilya Maximets wrote: On 16.10.2019 13:13, Maxime Coquelin wrote: On 10/15/19 8:59 PM, Flavio Leitner wrote: The rte_vhost_dequeue_burst supports two ways of dequeuing

Re: [dpdk-dev] [PATCH v5] vhost: add support for large buffers

On Wed, 16 Oct 2019 16:08:54 +0200 Ilya Maximets wrote: > On 16.10.2019 16:02, Flavio Leitner wrote: > > On Wed, 16 Oct 2019 15:46:15 +0200 > > Maxime Coquelin wrote: > > > >> On 10/16/19 3:32 PM, Ilya Maximets wrote: > >>> On 16.10.2019 13:13, Maxime Coquelin wrote: > > >

  1   2   >