Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build

2019-10-08 Thread Jerin Jacob
On Mon, 7 Oct, 2019, 3:49 PM Jerin Jacob, wrote: > > > On Sun, 6 Oct, 2019, 11:36 PM Thomas Monjalon, > wrote: > >> 05/10/2019 17:28, Jerin Jacob: >> > On Fri, Oct 4, 2019 at 4:27 AM Dharmik Thakkar >> wrote: >> > > >> > > Add new meson.build file for crypto/armv8 >> > > >> > > Signed-off-by: D

Re: [dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-08 Thread Adrian Moreno
On 10/8/19 8:30 AM, Tiwei Bie wrote: > On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote: >> Note that the API facing rte_vhost_log_write is not modified. >> So, make explicit that it expects the address in GPA space. >> >> Fixes: 69c90e98f483 ("vhost: enable IOMMU support") >> Cc: maxi

Re: [dpdk-dev] [PATCH v3 3/3] vhost: prevent zero copy mode if iommu is on

2019-10-08 Thread Adrian Moreno
On 10/8/19 8:23 AM, Tiwei Bie wrote: > On Fri, Sep 27, 2019 at 08:37:59PM +0200, Adrian Moreno wrote: >> The simltaneous use of dequeue_zero_copy and IOMMU is problematic. >> Not only because IOVA_VA mode is not supported but also because the >> potential invalidation of guest pages while the buffe

Re: [dpdk-dev] [PATCH 02/51] app/testpmd: check status of getting ethdev info

2019-10-08 Thread Zhao1, Wei
Thank you, this patch work well. > -Original Message- > From: Zhang, Qi Z > Sent: Monday, September 30, 2019 4:49 PM > To: Zhao1, Wei ; Andrew Rybchenko > ; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard > ; Adrien Mazarguil > > Cc: dev@dpdk.org; Ivan Ilchenko > Subject: RE: [dpdk-de

Re: [dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-08 Thread Maxime Coquelin
On 10/8/19 9:38 AM, Adrian Moreno wrote: > On 10/8/19 8:30 AM, Tiwei Bie wrote: >> On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote: >>> Note that the API facing rte_vhost_log_write is not modified. >>> So, make explicit that it expects the address in GPA space. >>> >>> Fixes: 69c90

[dpdk-dev] [PATCH v9 03/10] vhost: add the inflight structure

2019-10-08 Thread Jin Yu
This patch adds the inflight queue region structure include the split and packed. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 43 1 file changed, 43 insertions(+) diff --git

[dpdk-dev] [PATCH v9 01/10] vhost: add the inflight description

2019-10-08 Thread Jin Yu
This patch add the inflight message description and the inflight share fd protocol feature flag. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu Reviewed-by: Maxime Coquelin --- v1 - specify the APIs are split-ring only v2 - fix APIs and judge split o

[dpdk-dev] [PATCH v9 04/10] vhost: add two new messages to support a shared buffer

2019-10-08 Thread Jin Yu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/vhost.h | 7

[dpdk-dev] [PATCH v9 02/10] vhost: add packed ring

2019-10-08 Thread Jin Yu
This patch add the packed ring in the rte_vhost_vring. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu Reviewed-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost.h | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/

[dpdk-dev] [PATCH v9 00/10] vhost: support inflight share memory protocol feature

2019-10-08 Thread Jin Yu
This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Now It can both support split and packed ring. The example code show how these API work. The test has passed. How to test the example

[dpdk-dev] [PATCH v9 05/10] vhost: checkout the resubmit inflight information

2019-10-08 Thread Jin Yu
This patch shows how to checkout the inflight ring and construct the resubmit information also include destroying resubmit info. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 19 +++ lib/librte_vhost/vhost.c

[dpdk-dev] [PATCH v9 10/10] vhost: add vhost-user-blk example which support inflight

2019-10-08 Thread Jin Yu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so it can show how these APIs work to support inflight feature. Signed-off-by: Jin Yu --- V1 - add the case. V2 - add the rte_vhost prefix. V3 - add packed ring support --- examples/v

[dpdk-dev] [PATCH v9 09/10] vhost: add an API for judging vq format

2019-10-08 Thread Jin Yu
This patch introduces an API for getting virtqueue format. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 13 + lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/vhost.c

[dpdk-dev] [PATCH v9 08/10] vhost: add vring functions packed ring support

2019-10-08 Thread Jin Yu
This patch add packed ring support in two APIs so user can get the packed ring`. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/vhost.c | 68 +--- 1 file changed, 49 insertions(+), 19 deletions

[dpdk-dev] [PATCH v9 07/10] vhost: add APIs for user getting inflight ring

2019-10-08 Thread Jin Yu
This patch introduces two APIs. one is for getting inflgiht ring and the other is for getting base. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 40 + lib/librte_vhost/rte_vhost_version.m

[dpdk-dev] [PATCH v9 06/10] vhost: add the APIs to operate inflight ring

2019-10-08 Thread Jin Yu
This patch introduces three APIs to operate the inflight ring. Three APIs are set, set last and clear. It includes split and packed ring. Signed-off-by: Lin Li Signed-off-by: Xun Ni Signed-off-by: Yu Zhang Signed-off-by: Jin Yu --- lib/librte_vhost/rte_vhost.h | 116 +++ lib

Re: [dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-08 Thread Tiwei Bie
On Tue, Oct 08, 2019 at 09:43:48AM +0200, Maxime Coquelin wrote: > On 10/8/19 9:38 AM, Adrian Moreno wrote: > > On 10/8/19 8:30 AM, Tiwei Bie wrote: > >> On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote: > >>> Note that the API facing rte_vhost_log_write is not modified. > >>> So, make

Re: [dpdk-dev] [PATCH v7] test/ring: ring perf test case enhancement

2019-10-08 Thread Olivier Matz
On Mon, Sep 09, 2019 at 01:19:00PM +0800, Joyce Kong wrote: > Run ring perf test on all available cores to really verify MPMC operations. > The old way of running on a pair of cores is not enough for MPMC rings. > > Suggested-by: Gavin Hu > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang

Re: [dpdk-dev] [PATCH v5 1/5] mbuf: don't generate invalid mbuf in clone test

2019-10-08 Thread Olivier Matz
On Mon, Oct 07, 2019 at 08:43:39AM -0700, Stephen Hemminger wrote: > The test for cloning changed mbuf would generate an mbuf > whose length and segments were invalid. This would cause a crash > if test was run with mbuf debugging enabled. > > Fixes: f1022aba76a5 ("app/test: rename mbuf variable")

Re: [dpdk-dev] [PATCH v5 2/5] mbuf: delinline rte_pktmbuf_linearize

2019-10-08 Thread Olivier Matz
On Mon, Oct 07, 2019 at 08:43:40AM -0700, Stephen Hemminger wrote: > This copy part of this function is too big to be put inline. > The places it is used are only in special exception paths > where a highly fragmented mbuf arrives at a device that can't handle it. > > Signed-off-by: Stephen Hemmin

Re: [dpdk-dev] [PATCH v5 3/5] mbuf: deinline rte_pktmbuf_clone

2019-10-08 Thread Olivier Matz
On Mon, Oct 07, 2019 at 08:43:41AM -0700, Stephen Hemminger wrote: > Cloning mbufs requires allocations and iteration > and therefore should not be an inline. > > Signed-off-by: Stephen Hemminger > Acked-by: Andrew Rybchenko Acked-by: Olivier Matz

[dpdk-dev] [PATCH v4 0/3] vhost: add support for IOVA_VA mode

2019-10-08 Thread Adrian Moreno
Currently, IOVAs are assumed to be GPA when the dirty page logging is performed. Add support for guest IOVA_VA mode by translating addresses to GPA before doing the dirty page logging. Also, the guest_pages tracking mechanism used for zero_copy will not work either if IOVA_VA is enabled. In fact,

[dpdk-dev] [PATCH v4 1/3] vhost: translate incoming log address to gpa

2019-10-08 Thread Adrian Moreno
When IOMMU is enabled the incoming log address is in IOVA space. In that case, look in IOTLB table and translate the resulting HVA to GPA. If IOMMU is not enabled, the incoming log address is already a GPA so no transformation is needed. Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: max

[dpdk-dev] [PATCH v4 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-08 Thread Adrian Moreno
Create IOVA versions of dirty page logging functions. Note that the API facing rte_vhost_log_write is not modified. So, make explicit that it expects the address in GPA space. Fixes: 69c90e98f483 ("vhost: enable IOMMU support") Cc: maxime.coque...@redhat.com Cc: sta...@dpdk.org Signed-off-by: Adr

[dpdk-dev] [PATCH v4 3/3] vhost: prevent zero copy mode if iommu is on

2019-10-08 Thread Adrian Moreno
The simltaneous use of dequeue_zero_copy and IOMMU is problematic. Not only because IOVA_VA mode is not supported but also because the potential invalidation of guest pages while the buffers are in use, is not handled. Prevent these two features to be enabled simultaneosly. Fixes: 69c90e98f483 ("

Re: [dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging

2019-10-08 Thread Adrian Moreno
On 10/8/19 10:01 AM, Tiwei Bie wrote: > On Tue, Oct 08, 2019 at 09:43:48AM +0200, Maxime Coquelin wrote: >> On 10/8/19 9:38 AM, Adrian Moreno wrote: >>> On 10/8/19 8:30 AM, Tiwei Bie wrote: On Fri, Sep 27, 2019 at 08:37:58PM +0200, Adrian Moreno wrote: > Note that the API facing rte_vhost_

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-08 Thread Bruce Richardson
On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > wrote: > > > This code was added 7+ years ago: > > > > commit fb022b85bae4 ("timer: check TSC reliability") > > > > presumably when variant TSCs were still somewhat common? But

Re: [dpdk-dev] [PATCH v6 RESEND] eal: add tsc_hz to rte_mem_config

2019-10-08 Thread Bruce Richardson
On Mon, Oct 07, 2019 at 08:28:21AM -0700, Jim Harris wrote: > This ensures secondary processes never have to > calculate the TSC rate themselves, which can be > noticeable in VMs that don't have access to > arch-specific detection mechanism (such as > CPUID leaf 0x15 or MSR 0xCE on x86). > > Since

Re: [dpdk-dev] [PATCH 04/10] net/bnxt: remove redundant header file inclusion

2019-10-08 Thread Ferruh Yigit
On 10/4/2019 6:02 AM, Ajit Khaparde wrote: > From: Kalesh AP > > bnxt.h header includes bnxt_cpr.h and bnxt_util.h. > There is no need to include these headers file explicitly. > > This commit does not cause any functional change. > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde don

[dpdk-dev] [PATCH] net/octeontx2: add set supported types op

2019-10-08 Thread pbhagavatula
From: Pavan Nikhilesh Add support to set supported ptypes for octeontx2. Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series http://patches.dpdk.org/project/dpdk/list/?series=6715 drivers/net/octeontx2/otx2_ethdev.c | 1 + drivers/net/octeontx2/otx2_ethdev

Re: [dpdk-dev] [PATCH 10/10] net/bnxt: remove a useless check in validate flow routine

2019-10-08 Thread Ferruh Yigit
On 10/4/2019 6:02 AM, Ajit Khaparde wrote: > From: Kalesh AP > > Since vnic->rx_queue_cnt is already checked against non-zero, > removed the useless check from the inside condition check. > > Fixes: 4be31562a4ba ("net/bnxt: allow flow creation when RSS is enabled") > > Signed-off-by: Kalesh AP

Re: [dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-08 Thread Olivier Matz
Hi Stephen, Thank you for this patch. Few comments below. On Mon, Oct 07, 2019 at 08:43:42AM -0700, Stephen Hemminger wrote: > This is a commonly used operation that surprisingly the > DPDK has not supported. The new rte_pktmbuf_copy does a > deep copy of packet. This is a complete copy including

Re: [dpdk-dev] [PATCH v5 5/5] mbuf: add pktmbuf copy test

2019-10-08 Thread Olivier Matz
On Mon, Oct 07, 2019 at 08:43:43AM -0700, Stephen Hemminger wrote: > New test for rte_pktmbuf_copy based of the clone tests. > > Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v10 1/5] mempool: populate mempool with the page sized chunks

2019-10-08 Thread Olivier Matz
On Fri, Aug 16, 2019 at 11:42:48AM +0530, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Patch adds a routine to populate mempool from page aligned and > page sized chunks of memory to ensure memory objs do not fall > across the page boundaries. It's useful for applications that > requir

Re: [dpdk-dev] [PATCH v2] net/mlx5: adjust inline setting for large Tx queue sizes

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, October 1, 2019 9:54 AM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > > Subject: [PATCH v2] net/mlx5: adjust inline setting for large Tx queue sizes > > The hardware may have limitations on maximal amount

Re: [dpdk-dev] [PATCH] net/mlx5: fix port id action domain check

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, October 7, 2019 4:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > > Subject: [PATCH] net/mlx5: fix port id action domain check > > The validating routines flow_dv_validate_action_port_id() and > flow_d

Re: [dpdk-dev] [PATCH] net/mlx5: fix device scan within switch domain

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, October 7, 2019 4:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > > Subject: [PATCH] net/mlx5: fix device scan within switch domain > > In LAG configuration the devices in the same switch domain might

[dpdk-dev] [PATCH] mempool: clarify default populate function

2019-10-08 Thread Olivier Matz
No functional change. Clarify the populate function to make the next commit easier to understand. Rename the variables: - to avoid negation in the name - to have more understandable names Remove useless variable (no_pageshift is equivalent to pg_sz == 0). Remove duplicate affectation of "externa

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/cxgbe: fix races while executing rte_flow operations

2019-10-08 Thread Ferruh Yigit
On 10/4/2019 3:24 PM, Rahul Lakkireddy wrote: > When rules are being inserted from multiple cores, there are several > race conditions during rte_flow operations. > > For example, when inserting rules from 2 cores simultaneously, both > the cores try to fetch a free available filter entry and they

Re: [dpdk-dev] [PATCH] net/mlx5: fix vport id translation for LAG configuration

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, October 7, 2019 4:58 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > > Subject: [PATCH] net/mlx5: fix vport id translation for LAG configuration > > The vport id value was taken from wrong field. > > Fix

Re: [dpdk-dev] [PATCH] net/mlx5: fix direct call to rdma-core library

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Monday, October 7, 2019 4:58 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > > Subject: [PATCH] net/mlx5: fix direct call to rdma-core library > > The routine mlx5dv_query_devx_port() was called directly instead

Re: [dpdk-dev] [RFC 1/4] mempool: clarify default populate function

2019-10-08 Thread Olivier Matz
On Fri, Jul 19, 2019 at 06:42:06PM +0300, Andrew Rybchenko wrote: > On 7/19/19 4:38 PM, Olivier Matz wrote: > > No functional change. Clarify the populate function to make > > the next commit easier to understand. > > > > Rename the variables: > > - to avoid negation in the name > > - to have more

Re: [dpdk-dev] [PATCH] net/dpaa2: set port in the mbuf

2019-10-08 Thread Ferruh Yigit
On 10/4/2019 12:01 PM, Nipun Gupta wrote: > This patch sets the port in mbuf for all the scenarios within > fd to mbuf API Hi Nipun, What is the impact of not setting 'port' field for all the scenarios? If it breaks something, do you want to backport this patch? By converting it to a fix patch..

[dpdk-dev] [PATCH v3 2/5] ipsec: add SAD create/destroy implementation

2019-10-08 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_create(), rte_ipsec_sad_destroy() and rte_ipsec_sad_find_existing() API stubs with actual implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile| 2 +- lib/librte_ipsec/ipsec_sad.c | 230 +-- lib/librte_

[dpdk-dev] [PATCH v3 1/5] ipsec: add inbound SAD API

2019-10-08 Thread Vladimir Medvedkin
Add inbound security association database (SAD) API and stub implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile | 2 + lib/librte_ipsec/ipsec_sad.c | 50 ++ lib/librte_ipsec/meson.build | 4 +- lib/librte_ipsec/rte_ipsec.

[dpdk-dev] [PATCH v3 0/5] ipsec: add inbound SAD

2019-10-08 Thread Vladimir Medvedkin
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD). For each incoming inbound IPSec-protected packet (ESP or AH) it has to perform a lookup within it’s SAD. Lookup should be performed by: Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP) or SPI +

[dpdk-dev] [PATCH v3 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-08 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is addressed by SPI only or SPI+DIP or SPI+DIP+SIP) Signed-off-by: Vladimir Medvedkin

[dpdk-dev] [PATCH v3 4/5] test/ipsec: add ipsec SAD autotests

2019-10-08 Thread Vladimir Medvedkin
add unittests for ipsec SAD library Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 1 + app/test/test_ipsec_sad.c | 885 ++ 4 files changed, 893 insertions(+) c

[dpdk-dev] [PATCH v3 5/5] app: add test-sad application

2019-10-08 Thread Vladimir Medvedkin
Introduce new application to provide user to evaluate and perform custom functional and performance tests for IPsec SAD implementation. Signed-off-by: Vladimir Medvedkin --- app/Makefile | 1 + app/meson.build | 3 +- app/test-sad/Makefile| 18 ++ app/test-sad/main.

Re: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute

2019-10-08 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Thursday, September 26, 2019 13:22 > To: Matan Azrad > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute > > The receive queues list size is based on the siz

Re: [dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order

2019-10-08 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Wednesday, September 11, 2019 11:46 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: improve validation of item order > > The Item order validation between L

[dpdk-dev] [PATCH] doc: fix internal links for older releases

2019-10-08 Thread David Marchand
Using external explicit references to http://doc.dpdk.org makes older releases documentation point to the current master documentation pages. Switch to internal references. Fixes: 59ad25fe2184 ("doc: add overview of qat guide") Fixes: 30e7fbd62839 ("doc: add event timer adapter guide") Fixes: b7f8

Re: [dpdk-dev] [PATCH] net/bnxt: fix a check in rxq start op

2019-10-08 Thread Ferruh Yigit
On 10/7/2019 8:41 PM, Ajit Khaparde wrote: > From: Kalesh AP > > This patch fixes a wrong check in rxq start operation. > Driver should check for rxq start state. > > Fixes: 4316e043cbcb ("net/bnxt: fix RxQ stop/start handling") > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde Squashed

[dpdk-dev] [PATCH] lib/distributor: fix deadlock issue for aarch64

2019-10-08 Thread Ruifeng Wang
Distributor and worker threads rely on data structs in cache line for synchronization. The shared data structs were not protected. This caused deadlock issue on weaker memory ordering platforms as aarch64. Fix this issue by adding memory barriers to ensure synchronization among cores. Bugzilla ID:

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix description of links to EAL options pages

2019-10-08 Thread David Marchand
Nit: this patch title does not reflect what the issue was. Hard to tell when just looking at it what the impact of your patch is. On Tue, Aug 13, 2019 at 1:26 PM Dekel Peled wrote: > > Documentation includes separate pages of EAL command-line options for > Linux and for FreeBSD. > Links to these

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-10-08 Thread Yu, PingX
Kevin, FYI. All build are passed in 18.11.3-RC2 except Win10 no support. No issues are found now. Regards, Yu Ping -Original Message- From: Kevin Traynor [mailto:ktray...@redhat.com] Sent: Thursday, October 3, 2019 9:30 PM To: Yu, PingX ; sta...@dpdk.org; dev@dpdk.org Cc: Akhil Goyal ;

Re: [dpdk-dev] [PATCH v2 0/3] Add dual threading in QAT PMD

2019-10-08 Thread Trahe, Fiona
Hi Akhil, We're going to defer this patchset this to 20.02. We want to add another patch to it to mitigate some performance impacts it causes.# I'm not sure of the process for this - do I just mark it in patchwork as deferred? Or is there a tag I can put in an email, like Deferred-by? Fiona > -

Re: [dpdk-dev] [PATCH] net/mlx5: fix vport id translation for LAG configuration

2019-10-08 Thread Ferruh Yigit
On 10/8/2019 10:35 AM, Raslan Darawsheh wrote: > Hi, > >> -Original Message- >> From: Viacheslav Ovsiienko >> Sent: Monday, October 7, 2019 4:58 PM >> To: dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> >> Subject: [PATCH] net/mlx5: fix vport id translation for LAG configuration >>

Re: [dpdk-dev] [PATCH] net/mlx5: fix port id action domain check

2019-10-08 Thread Ferruh Yigit
On 10/8/2019 10:34 AM, Raslan Darawsheh wrote: > Hi, > >> -Original Message- >> From: Viacheslav Ovsiienko >> Sent: Monday, October 7, 2019 4:56 PM >> To: dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> >> Subject: [PATCH] net/mlx5: fix port id action domain check >> >> The validat

Re: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier

2019-10-08 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> > -Original Message- > > From: dev On Behalf Of Phil Yang > > Sent: Monday, August 26, 2019 7:00 PM > > To: jgraj...@cisco.com; dev@dpdk.org > > Cc: tho...@monjalon.net; jer...@marvell.com; Honnappa Nagarahalli > > ; damar...@cisco.com; nd > > > Subject: [dpdk-dev] [PATCH v1] net/memif:

Re: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Thursday, September 26, 2019 1:22 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute > > The receive queues list size is based on

Re: [dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order

2019-10-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, September 11, 2019 11:46 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix the alloc size of rqt attribute

2019-10-08 Thread Ferruh Yigit
On 9/26/2019 11:22 AM, Ori Kam wrote: > The receive queues list size is based on the size of uint32_t, so > when allocating the memory, the correct value should be used. Or > else there is risk to corrupt the memory, depending on the queues > number, because there is some pad area for alignment. If

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-10-08 Thread Yigit, Ferruh
On 7/29/2019 4:06 PM, Adrien Mazarguil wrote: > On Sun, Jul 14, 2019 at 02:46:58PM +0300, Andrew Rybchenko wrote: >> On 11.07.2019 10:44, Adrien Mazarguil wrote: >>> On Wed, Jul 10, 2019 at 04:37:46PM +, Yongseok Koh wrote: > On Jul 10, 2019, at 5:26 AM, Thomas Monjalon wrote: > >

[dpdk-dev] [PATCH v3 0/3] QAT: handle Single Pass GCM

2019-10-08 Thread Adam Dybkowski
This patch improves the performance of AES GCM by using the Single Pass Crypto Request when running on GEN3 QAT. --- v3: * Block GCM session prepared on QAT GEN3 to be used for executing op on QAT GEN1/2 * Update QAT sym. crypto documentation v2: * Fix the session preparation function and request

[dpdk-dev] [PATCH v3 1/3] test/crypto: add more AES GCM tests for QAT PMD

2019-10-08 Thread Adam Dybkowski
This patch adds 256-bit AES GCM tests for QAT PMD (which already existed for AESNI and OpenSSL) and also adds a number of negative unit tests for AES GCM for QAT PMD, in order to verify authenticated encryption and decryption with modified data. Signed-off-by: Adam Dybkowski --- app/test/test_cr

[dpdk-dev] [PATCH v3 2/3] common/qat: add new QAT GEN3 definitions

2019-10-08 Thread Adam Dybkowski
This patch adds few definitions specific to GEN3 QAT. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw_la.h | 19 +++ drivers/common/qat/qat_adf/icp_qat_hw.h| 19 +++ 2 files changed, 34 insertions(+), 4 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH] lib/distributor: fix deadlock issue for aarch64

2019-10-08 Thread Hunt, David
On 08/10/2019 10:55, Ruifeng Wang wrote: Distributor and worker threads rely on data structs in cache line for synchronization. The shared data structs were not protected. This caused deadlock issue on weaker memory ordering platforms as aarch64. Fix this issue by adding memory barriers to ensu

[dpdk-dev] [PATCH v3 3/3] crypto/qat: handle Single Pass Crypto Requests on GEN3 QAT

2019-10-08 Thread Adam Dybkowski
This patch improves the performance of AES GCM by using the Single Pass Crypto Request functionality when running on GEN3 QAT. Falls back to the classic 2-pass mode on older hardware. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 11 doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-10-08 Thread Yigit, Ferruh
On 7/11/2019 2:59 AM, Yongseok Koh wrote: > On Tue, Jul 09, 2019 at 10:38:06AM +0200, Adrien Mazarguil wrote: >> On Fri, Jul 05, 2019 at 06:05:50PM +, Yongseok Koh wrote: On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil wrote: On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok

Re: [dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-10-08 Thread Yigit, Ferruh
On 8/19/2019 8:09 AM, Akhil Goyal wrote: > Hi Anoob, >> >> Hi Akhil, >> The rte_security API which enables inline protocol/crypto feature mandates that for every security session an rte_flow is >>> created. This would internally translate to a rule in the hardwar

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-10-08 Thread Slava Ovsiienko
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 8, 2019 15:51 > To: Adrien Mazarguil ; Andrew Rybchenko > > Cc: Yongseok Koh ; Thomas Monjalon > ; Olivier Matz ; Bruce > Richardson ; Shahaf Shuler > ; Ferruh Yigit ; dev > ; Slava Ovsiienko > Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-10-08 Thread Slava Ovsiienko
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 8, 2019 15:57 > To: Yongseok Koh ; Adrien Mazarguil > > Cc: Shahaf Shuler ; Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Olivier Matz > ; dev ; Slava Ovsiienko > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add f

Re: [dpdk-dev] [PATCH v2 01/10] security: introduce CPU Crypto action type and API

2019-10-08 Thread Ananyev, Konstantin
Hi Fan, > > This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action type to > security library. The type represents performing crypto operation with CPU > cycles. The patch also includes a new API to process crypto operations in > bulk and the function pointers for PMDs. > > Signed-o

Re: [dpdk-dev] [PATCH v2 02/10] crypto/aesni_gcm: add rte_security handler

2019-10-08 Thread Ananyev, Konstantin
> > This patch add rte_security support support to AESNI-GCM PMD. The PMD now > initialize security context instance, create/delete PMD specific security > sessions, and process crypto workloads in synchronous mode with > scatter-gather list buffer supported. > > Signed-off-by: Fan Zhang > --

Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-08 Thread Trahe, Fiona
Hi Arek, Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 4, 2019 12:34 PM > To: Akhil Goyal ; Anoob Joseph ; > Kusztal, ArkadiuszX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Shally Verma > Subject: RE: [EXT] [PATCH v2] cryptodev: extend api

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: add NSH key field to flow API

2019-10-08 Thread Ferruh Yigit
On 9/30/2019 4:45 PM, Yigit, Ferruh wrote: > On 7/25/2019 10:03 AM, kirankum...@marvell.com wrote: >> From: Kiran Kumar K >> >> Add new rte_flow_item_nsh in order to match the network service header >> based on RFC 8300. >> >> Signed-off-by: Kiran Kumar K > > Hi Adrien, Ori, > > Any concern/obj

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-10-08 Thread Yigit, Ferruh
On 7/31/2019 7:11 AM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> On 7/30/2019 7:34 PM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit On 7/30/2019 4:56 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> Sent: Tuesday, July 30, 2019 6:22 PM >> To

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: add bits per second to statistics

2019-10-08 Thread Yigit, Ferruh
On 7/30/2019 12:41 PM, Moti Haimovsky wrote: >> -Original Message- >> From: dev On Behalf Of Matan Azrad >> Sent: Monday, July 29, 2019 3:37 PM >> To: Wenzhuo Lu ; Jingjing Wu >> >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 2/2] app/testpmd: add bits per second to >> statistics >> >>

Re: [dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-10-08 Thread Yigit, Ferruh
On 7/30/2019 4:59 PM, Thomas Monjalon wrote: > Since the concept of representors was introduced, > we do not need any specific API for VF ports. > Any VF port should be able to be configured through > its representor port in a more generic fashion. I think we need a confirmation that functionality

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in selection logic

2019-10-08 Thread Yigit, Ferruh
On 8/5/2019 3:44 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Bonding selection logic uses agg_bandwidth, agg_count indexed by port_id > but those arrays are 8 entries long. > > Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") > Cc: danielx.t.mrzyg...@intel.com > > S

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix selection logic

2019-10-08 Thread Yigit, Ferruh
On 8/5/2019 3:44 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Fix max_index to return uint16_t as it is valid slave_id type. > > Arrays agg_count and agg_bandwidth should be indexed by slave_id not by > aggregator port_id. The port_id type has been fixed already with another patch

[dpdk-dev] [PATCH 0/3] Add scanning for experimental symbols to meson

2019-10-08 Thread Bruce Richardson
The meson builds were missing support for scanning experimental symbols in the .o/.a files and matching that against those tagged as experimental in the version file. This set adds that missing support. Bruce Richardson (3): check-experimental-syms: remove use of environmental var lib: add exp

[dpdk-dev] [PATCH 1/3] check-experimental-syms: remove use of environmental var

2019-10-08 Thread Bruce Richardson
The check-experimental-syms.sh script was finding the map-list-symbol.sh script using $RTE_SDK, which is the variable set when using the "make" build system. To make this script more independent, we just use the current path of the script as the location to find its companion script. Signed-off-by

[dpdk-dev] [PATCH 2/3] lib: add experimental symbols check to meson build

2019-10-08 Thread Bruce Richardson
Call check-experimental-syms.sh script as part of the meson build to ensure that all functions are correctly tagged. Signed-off-by: Bruce Richardson --- buildtools/meson.build | 2 ++ lib/meson.build| 12 +++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/buildt

[dpdk-dev] [PATCH 0/3] Add scanning for experimental symbols to meson

2019-10-08 Thread Bruce Richardson
The meson builds were missing support for scanning experimental symbols in the .o/.a files and matching that against those tagged as experimental in the version file. This set adds that missing support. Bruce Richardson (3): check-experimental-syms: remove use of environmental var lib: add exp

[dpdk-dev] [PATCH 3/3] drivers: process shared lib link dependencies as for libs

2019-10-08 Thread Bruce Richardson
For the public APIs of DPDK libraries we run checks for correct use of experimental tags, and also do dynamic generation of the version file to its window's equivalent. Although must drivers don't export APIs, some do, so these checks are relevant and should be copied from lib/meson.build to driver

Re: [dpdk-dev] [PATCH v9 1/7] ethdev: add set ptype function

2019-10-08 Thread Andrew Rybchenko
On 10/7/19 9:51 AM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t wan

Re: [dpdk-dev] [PATCH v2 14/14] doc: add hairpin feature

2019-10-08 Thread Andrew Rybchenko
On 10/4/19 10:54 PM, Ori Kam wrote: This commit adds the hairpin feature to the release notes. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_19_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b

Re: [dpdk-dev] [PATCH v3 0/3] QAT: handle Single Pass GCM

2019-10-08 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, October 8, 2019 1:45 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 0/3] QAT: handle Single Pass GCM > > This patch improves the performance of

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-08 Thread Stephen Hemminger
On Fri, 6 Sep 2019 14:42:30 +0530 wrote: > From: Vamsi Attunuru > > The DPDK use case such as VF representer or OVS offload etc > would call for PF and VF PCIe devices to bind vfio-pci > module to enable IOMMU protection. > > In addition to vSwitch use case, unlike, other PCI class of > device

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-10-08 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. hinic pmd driver doesn't support 32-bit build, we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc". and “defconfig_x86_x32-native-linux-gcc”. I don't know why it also build in 32-bit platform, can you tell me where also need me to

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2019 09:36:49 +0100 Bruce Richardson wrote: > On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > > wrote: > > > > > This code was added 7+ years ago: > > > > > > commit fb022b85bae4 ("timer: check TSC reliabili

Re: [dpdk-dev] [PATCH v3 18/19] net/hinic: optimize RX performance

2019-10-08 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. I think you're right, i will modify it with Patch V4. Also I change it with the same structure for X86-64 and ARM platform with cache-aligned, and test the RX performance, all is OK. Best Regards Xiaoyun Wang 在 2019/9/30 23:10, Ferruh Yigit 写道: On 9/3

Re: [dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2019 11:03:34 +0200 Olivier Matz wrote: > > > > +/** > > + * Creates a full copy of a given packet mbuf. > > Although it's not consistent everywhere, I think the imperative > form is preferred ("Create" instead of "Creates"). > > > + * Copies all the data from a given packet m

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-08 Thread Jerin Jacob
On Tue, 8 Oct, 2019, 8:42 PM Stephen Hemminger, wrote: > On Fri, 6 Sep 2019 14:42:30 +0530 > wrote: > > > From: Vamsi Attunuru > > > > The DPDK use case such as VF representer or OVS offload etc > > would call for PF and VF PCIe devices to bind vfio-pci > > module to enable IOMMU protection. >

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-10-08 Thread Ferruh Yigit
On 10/8/2019 4:14 PM, Wangxiaoyun (Cloud, Network Chip Application Development Dept) wrote: > Hi Ferruh, > Thanks for your comments. hinic pmd driver doesn't support 32-bit build, > we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc". > and “defconfig_x86_x32-native-li

[dpdk-dev] [PATCH] devtools: check coverity and bugzilla tags

2019-10-08 Thread David Marchand
Let's try to check for discrepancies in covery and bugzilla tags. The contributing guide specifies that: - for coverity issues, the tag is 'Coverity issue:' - for bugzilla issues, the tag is 'Bugzilla ID:' Signed-off-by: David Marchand --- devtools/check-git-log.sh | 18 ++ 1 fil

Re: [dpdk-dev] [PATCH v2 01/14] ethdev: add support for hairpin queue

2019-10-08 Thread Andrew Rybchenko
Hi Ori, thanks for updated version. See my notes below. There are few style notes about line breaks which are not defined in coding style. Of course, it may be ignored. On 10/4/19 10:54 PM, Ori Kam wrote: This commit introduce hairpin queue type. The hairpin queue in build from Rx queue binde

Re: [dpdk-dev] [PATCH v2 05/10] crypto/aesni_mb: add rte_security handler

2019-10-08 Thread Ananyev, Konstantin
Hi Fan, > This patch add rte_security support support to AESNI-MB PMD. The PMD now > initialize security context instance, create/delete PMD specific security > sessions, and process crypto workloads in synchronous mode. > > Signed-off-by: Fan Zhang > --- > drivers/crypto/aesni_mb/meson.buil

  1   2   >