On Fri, Jul 19, 2019 at 06:42:06PM +0300, Andrew Rybchenko wrote: > On 7/19/19 4:38 PM, Olivier Matz wrote: > > No functional change. Clarify the populate function to make > > the next commit easier to understand. > > > > Rename the variables: > > - to avoid negation in the name > > - to have more understandable names > > > > Remove useless variable (no_pageshift is equivalent to pg_sz == 0). > > > > Remove duplicate affectation of "external" variable. > > > > Signed-off-by: Olivier Matz <olivier.m...@6wind.com> > > LGTM > > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> >
I submitted this one in a separate patch: http://patchwork.dpdk.org/patch/60687/