Addresed issues reported by coverity: NULL pointer dereferencing
issues, unchecked return value, uinitialized scalar value,
probable deadcode cases, unintended sign extension, bad bit
shift operation, Wrong sizeof argument (SIZEOF_MISMATCH)
Coverity issue: 343396, 345028, 344977, 345015, 345025, 3
Hi Stephen
From: Stephen Hemminger
> On Fri, 2 Aug 2019 05:33:20 +
> Matan Azrad wrote:
>
> > Hi Stephen
> >
> > One more small comment inline
> >
> > From: Stephen Hemminger
> > > Sent: Friday, August 2, 2019 5:58 AM
> > > To: dev@dpdk.org
> > > Cc: Stephen Hemminger
> > > Subject: [dpdk
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Wednesday, July 31, 2019 17:58
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH 5/5] net/mlx5: remove blank lines at eof
>
> Whitespace fix.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Via
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Thursday, August 1, 2019 4:23 PM
> To: Yongseok Koh ; Slava Ovsiienko
> ; Shahaf Shuler
> Cc: Ori Kam ; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables
> number
>
> MLX5 PMD li
Hi,
> -Original Message-
> From: dev On Behalf Of David Christensen
> Sent: Thursday, August 1, 2019 1:41 AM
> To: Slava Ovsiienko
> Cc: dev@dpdk.org; David Christensen
> Subject: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-
> 5 adapters
>
> The function mlx5_set_m
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343416
Fixes: fe65e1e1 ("fm10k: add vector scatter Rx")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/fm10k/fm10k_rxtx_vec.c | 1
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343447
Fixes: 319c421f ("net/avf: enable SSE Rx Tx")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/iavf/iavf_rxtx_vec_sse.c | 1 +
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343422
Coverity issue: 343403
Fixes: ca74903b ("net/i40e: extract non-x86 specific code from vector
driver")
Cc: sta...@dpdk.org
Signed-off-by: Xi
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343452
Coverity issue: 343407
Fixes: c68a52b8 ("net/ice: support vector SSE in Rx")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 13245
Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector
driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/n
Add return value checking when reading configure information from PCI
register to avoid coverity issue.
Fixes: 1fc97012 ("net/e1000: fix i219 hang on reset/close")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/e1000/em_rxtx.c | 18 +++---
1 file changed, 15 insertion
There is the limit on completion descriptor fetch to improve
latency. If burst size is large there might be not enough
resources freed in completion processing. This fix reiterates
sending loop and allows multiple completion descriptor fetch
and processing.
Fixes: 18a1c20044c0 ("net/mlx5: implemen
If packets are completely inline the mbuf is freed immediately
after data copying and no pointer is stored into elts array
to be free on completion. This leads the elts_head is not
updated and completion request buffer counter works incorrect.
This patch decrements the base value elts_comp used to
This patch fixes the default settings for packet size to inline
with Enhanced Multi-Packet Write feature, allowing 256B packets
to be inlined with Out-Of-the-Box settings.
Fixes: 50724e1bba76 ("net/mlx5: update Tx definitions")
Signed-off-by: Viacheslav Ovsiienko
---
doc/guides/nics/mlx5.rst
The completion loop speed optimizations for error-free
operations are done - no CQE field fetch on each loop
iteration. Also, code size is oprimized - the flush
buffers routine is invoked once.
Fixes: 318ea4cfa1b1 ("net/mlx5: fix Tx completion descriptors fetching loop")
Signed-off-by: Viacheslav
If the minimal inline data are required the data inline feature
must be engaged. There were the incorrect settings enabling the
entire small packet inline (in size up to 82B) which may result
in sending rate declining if there is no enough cores. The same
problem was raised if inline was enabled to
On Thu, Aug 01, 2019 at 02:41:23PM +0200, Thomas Monjalon wrote:
> In order to prepare for a long term stable API, the mbuf library
> has to change: allowing more features as dynamic fields,
> and fixing the lack of rte_ prefix in the namespace.
> The namespace fix should not break the compatibilit
Hi, Xiao
It's better to have a cover letter for a patch series that contains more than
1 patches, where you can have an overall description of the patchset.
On 08/05, Xiao Zhang wrote:
>The address of receive queue start segment was not updated when found by
>iterated checking, update the address
-David Marchand wrote: -
>To: dev@dpdk.org
>From: David Marchand
>Date: 08/02/2019 07:14PM
>Cc: anatoly.bura...@intel.com, t...@jp.ibm.com,
>d...@linux.vnet.ibm.com
>Subject: [PATCH] bus/pci: always check IOMMU capabilities
>
>IOMMU capabilities won't change and must be checked even if n
> -Original Message-
> From: Harman Kalra
> Sent: Sunday, August 4, 2019 12:51 PM
> To: Jerin Jacob Kollanukkaran ; Nithin Kumar
> Dabilpuram ; Vamsi Krishna Attunuru
> ; Kiran Kumar Kokkilagadda
>
> Cc: dev@dpdk.org; Harman Kalra
> Subject: [PATCH] drivers/octeontx2: fix coverity iss
This patch fixes null pointer dereference issues found by coverity scan.
Coverity issue: 344981, 344991, 345000, 345002, 345006, 345024
Fixes: 277310027965 ("raw/ntb: introduce NTB raw device driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiaoyun Li
---
drivers/raw/ntb/ntb.c | 18 +++--
This patch adds return value checking for fseek function to fix
error handling issue found by coverity scan.
Coverity issue: 344996
Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
Cc: sta...@dpdk.org
Signed-off-by: Xiaoyun Li
---
examples/ntb/ntb_fwd.c | 13 +++--
1 file chang
On 08/05, Xiao Zhang wrote:
>Add return value checking when reading configure information from PCI
>register to avoid coverity issue.
>
>Fixes: 1fc97012 ("net/e1000: fix i219 hang on reset/close")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Xiao Zhang
>---
> drivers/net/e1000/em_rxtx.c | 18 +++
Update workaround changes for erratas that are fixed on 96xx A1.
This patch also enables cq drop for all the passes for
maintaining performance along with updating a default
Rx ring size in dev_info.
Signed-off-by: Nithin Dabilpuram
---
drivers/common/octeontx2/otx2_dev.h | 16 ++
On 08/05, Xiaoyun Li wrote:
>This patch fixes null pointer dereference issues found by coverity scan.
>
>Coverity issue: 344981, 344991, 345000, 345002, 345006, 345024
>Fixes: 277310027965 ("raw/ntb: introduce NTB raw device driver")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Xiaoyun Li
>---
> drivers
outer IP header is formed at the time of session initialization
using the ipsec xform. This outer IP header will be appended by
hardware for each packet.
Signed-off-by: Akhil Goyal
---
drivers/crypto/dpaa_sec/dpaa_sec.c | 69 ++
drivers/crypto/dpaa_sec/dpaa_sec.h | 11
outer IP header is formed at the time of session initialization
using the ipsec xform. This outer IP header will be appended by
hardware for each packet.
Signed-off-by: Akhil Goyal
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 71 +++--
drivers/crypto/dpaa2_sec/dpaa2_sec_priv
IPv6 tunnels are already supported in case of inline and
lookaside none cases. In case of protocol offload, the details
for IPv6 header need to be added in session configuration
for security session create.
Signed-off-by: Akhil Goyal
---
examples/ipsec-secgw/ipsec.c | 14 +-
1 file c
On 08/05, Xiaoyun Li wrote:
>This patch adds return value checking for fseek function to fix
>error handling issue found by coverity scan.
>
>Coverity issue: 344996
>Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Xiaoyun Li
>---
> examples/ntb/ntb_
On Mon, Aug 5, 2019 at 5:57 AM Takeshi T Yoshimura wrote:
>
> -David Marchand wrote: -
>
> >To: dev@dpdk.org
> >From: David Marchand
> >Date: 08/02/2019 07:14PM
> >Cc: anatoly.bura...@intel.com, t...@jp.ibm.com,
> >d...@linux.vnet.ibm.com
> >Subject: [PATCH] bus/pci: always check IOMMU c
IOMMU capabilities won't change and must be checked even if no PCI device
seem to be supported yet when EAL initialised.
This is to accommodate with SPDK that registers its drivers after
rte_eal_init(), especially on PPC platform where the IOMMU does not
support VA.
Fixes: 703458e19c16 ("bus/pci:
> -Original Message-
> From: Nithin Dabilpuram
> Sent: Monday, August 5, 2019 11:11 AM
> To: Jerin Jacob Kollanukkaran ; Nithin Kumar
> Dabilpuram ; Vamsi Krishna Attunuru
> ; Kiran Kumar Kokkilagadda
>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/octeontx2: add 96xx A1 silicon revision supp
On Sat, Aug 3, 2019 at 12:00 AM Thomas Monjalon wrote:
>
> 02/08/2019 23:25, Aaron Conole:
> > This series turns the fast unit tests on for a limited set of
> > builds under the travis build system. An example run is available
> > at:
> >
> > https://travis-ci.org/orgcandman/dpdk/builds/565991679
Sure. Will update in v2. Thx.
> -Original Message-
> From: Ye, Xiaolong
> Sent: Monday, August 5, 2019 14:05
> To: Li, Xiaoyun
> Cc: Wu, Jingjing ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/ntb: fix error handling
>
> On 08/05, Xiaoyun Li wrote:
> >This pat
This patch adds return value checking for fseek function to fix
error handling issue found by coverity scan.
Coverity issue: 344996
Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
Cc: sta...@dpdk.org
Signed-off-by: Xiaoyun Li
---
examples/ntb/ntb_fwd.c | 10 --
1 file changed,
From: Viacheslav Ovsiienko
> This patch fixes the default settings for packet size to inline with Enhanced
> Multi-Packet Write feature, allowing 256B packets to be inlined with Out-Of-
> the-Box settings.
>
> Fixes: 50724e1bba76 ("net/mlx5: update Tx definitions")
>
> Signed-off-by: Viachesl
From: Viacheslav Ovsiienko
> There is the limit on completion descriptor fetch to improve latency. If burst
> size is large there might be not enough resources freed in completion
> processing. This fix reiterates sending loop and allows multiple completion
> descriptor fetch and processing.
>
From: Viacheslav Ovsiienko
> If packets are completely inline the mbuf is freed immediately after data
> copying and no pointer is stored into elts array to be free on completion.
> This
> leads the elts_head is not updated and completion request buffer counter
> works incorrect.
> This patch d
From: Viacheslav Ovsiienko
> If the minimal inline data are required the data inline feature must be
> engaged. There were the incorrect settings enabling the entire small packet
> inline (in size up to 82B) which may result in sending rate declining if
> there is
> no enough cores. The same pr
From: Viacheslav Ovsiienko
> The completion loop speed optimizations for error-free operations are done
> - no CQE field fetch on each loop iteration. Also, code size is oprimized -
> the
> flush buffers routine is invoked once.
>
> Fixes: 318ea4cfa1b1 ("net/mlx5: fix Tx completion descriptors
Hi,
In dpdk 16.11, most of mlnx device APIs except RX/TX are protected by a private
lock. In DPDK 18.11, these locks are removed, from the code it seems this is
due to all APIs will create a disposable socket and the socket will be used to
set/get specific device features, and will be close
41 matches
Mail list logo
