Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-08 Thread Akhil Goyal
> > 07/07/2019 07:41, Liron Himi: > > From: Akhil Goyal > > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform key > > > data type change for mvsam driver. > > > > > > Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant") > > > > > > Signed-off-by: Fan Zhang > >

[dpdk-dev] [PATCH 2/2] [2/2]vhost: Add vhost-user-blk example which support inflight

2019-07-08 Thread JinYu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so It can show how there APIs work to support inflight feature. Signed-off-by: JinYu --- V1 - add the case. --- examples/vhost_blk/Makefile | 67 +++ examples/vhost_blk/blk

[dpdk-dev] [PATCH 1/2] [1/2]vhost: support inflight share memory protocol feature

2019-07-08 Thread JinYu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the shared buffer from backend. Then qemu should send it back through VHOST_USER_S

[dpdk-dev] [PATCH 0/2] support inflight share memory protocol feature

2019-07-08 Thread JinYu
This patches series introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. This shared buffer is used to process inflight I/O when backend reconnect. The example show how these new APIs work. JinYu (

Re: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux

2019-07-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Monday, July 8, 2019 10:18 AM > To: Matan Azrad ; Shahaf Shuler > ; Yongseok Koh ; Slava > Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux > > Currently mlx4/mlx5 supp

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-08 Thread Ilya Maximets
On 08.07.2019 20:13, Marvin Liu wrote: > In fast enqueue function, will first check whether descriptors are > cache aligned. Fast enqueue function will check prerequisites in the > beginning. Fast enqueue function do not support chained mbufs, normal > function will handle that. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v2] net/mlx5: zero out UDP csum for IPv6 encap headers

2019-07-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, July 4, 2019 2:16 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Eli Britstein > > Subject: [PATCH v2] net/mlx5: zero out UDP csum for IPv6 encap headers > > From: Eli Britstein > > Mellanox NICs do not support UD

Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support matching on ICMP/ICMP6

2019-07-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Xiaoyu Min > Sent: Wednesday, July 3, 2019 10:23 AM > To: Raslan Darawsheh ; Slava Ovsiienko > ; Shahaf Shuler ; > Yongseok Koh ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v3] net/mlx5: support matching o

[dpdk-dev] DPDK techboard minutes of July 3

2019-07-08 Thread Ferruh Yigit
Meeting notes for the DPDK technical board meeting held on 2018-07-3 Attendees: - Bruce Richardson - Ferruh Yigit - Jerin Jacob - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Thomas Monjalon 1) Adding eventmode helper library - Dec

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno

2019-07-08 Thread Akhil Goyal
Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [PATCH] common/octeontx2: cleanup void returns

2019-07-08 Thread kkanas
From: Krzysztof Kanas mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value. mbox_unregister_irq also returns void. Clang with flags '-Wall -Wextra -pedantic' complains about: void function should not return void expression Signed-off-by: Krzysztof Kanas --- drivers/common/octe

Re: [dpdk-dev] [PATCH] common/octeontx2: cleanup void returns

2019-07-08 Thread Thomas Monjalon
08/07/2019 14:18, kka...@marvell.com: > From: Krzysztof Kanas > > mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value. > mbox_unregister_irq also returns void. > > Clang with flags '-Wall -Wextra -pedantic' complains about: > void function should not return void expression > >

Re: [dpdk-dev] [PATCH v4 2/2] doc: update according to the fifo per core impl

2019-07-08 Thread Burakov, Anatoly
On 13-Jun-19 10:21 AM, Hajkowski wrote: From: Marcin Hajkowski Updated power management docs for fifo JSON API. Removed from JSON API: * 'name' * 'resource_id' * 'core_list' Signed-off-by: Marcin Hajkowski Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- I think current

Re: [dpdk-dev] [PATCH v4 1/2] power: add fifo per core for JSON interface

2019-07-08 Thread Burakov, Anatoly
On 13-Jun-19 10:21 AM, Hajkowski wrote: From: Marcin Hajkowski This patch implement a separate FIFO for each cpu core. For proper handling JSON interface, removed fields from cmds: core_list, resource_id, name. Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski Signed-off-by: Ma

[dpdk-dev] [PATCH 0/4] net/mlx5: accelerate DV flow counters mangement

2019-07-08 Thread Matan Azrad
New features in devx to query and allocate flow counters by batch commands allow to accelerate flow counter create/destroy/query. Matan Azrad (4): net/mlx5: accelerate DV flow counter transactions net/mlx5: resize a full counter container net/mlx5: accelerate DV flow counter query net/mlx

[dpdk-dev] [PATCH 1/4] net/mlx5: accelerate DV flow counter transactions

2019-07-08 Thread Matan Azrad
The DevX interface exposes a new feature to the PMD that can allocate a batch of counters by one FW command. It can improve the flow transaction rate (with count action). Add a new counter pools mechanism to manage HW counters in the PMD. So, for each flow with counter creation the PMD will try to

[dpdk-dev] [PATCH 2/4] net/mlx5: resize a full counter container

2019-07-08 Thread Matan Azrad
When the counter countainer has no more space to store more counter pools try to resize the container to allow more pools to be created. So, the only limitation for the maximum counter number is the memory. Signed-off-by: Matan Azrad Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow_dv.c

[dpdk-dev] [PATCH 4/4] net/mlx5: allow basic counter management fallback

2019-07-08 Thread Matan Azrad
In case the asynchronous devx commands are not supported in RDMA core fallback to use a basic counter management. Here, the PMD counters cashe is redundant and the host thread doesn't update it. hence, each counter operation will go to the FW and the acceleration reduces. Signed-off-by: Matan Azr

[dpdk-dev] [PATCH 3/4] net/mlx5: accelerate DV flow counter query

2019-07-08 Thread Matan Azrad
All the DV counters are cashed in the PMD memory and are contained in pools which are contained in containers according to the counters allocation type - batch or single. Currently, the flow counter query is done synchronously in pool resolution means that on the user request a FW command is trigg

[dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-08 Thread jerinj
From: Jerin Jacob Existing logic fails to select IOVA mode as VA if driver request to enable IOVA as VA. IOVA as VA has more strict requirement than other modes, so enabling positive logic for IOVA as VA selection. This patch also updates the default IOVA mode as PA for PCI devices as it has to

Re: [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations

2019-07-08 Thread Thomas Monjalon
08/04/2019 05:02, Phil Yang: > Phil Yang (3): > packet_ordering: add statistics for each worker thread > test/distributor: replace sync builtins with atomic builtins > test/ring_perf: replace sync builtins with atomic builtins After months of wait for comments, Applied, thanks

Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: check port ownership

2019-07-08 Thread Stephen Hemminger
On Mon, 8 Jul 2019 06:37:14 + Matan Azrad wrote: > Hi Stephen > > From: Stephen Hemminger > > Sent: Sunday, July 7, 2019 7:47 PM > > To: Matan Azrad > > Cc: anatoly.bura...@intel.com; dev@dpdk.org; Stephen Hemminger > > > > Subject: Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: che

[dpdk-dev] /run/dpdk cleanup

2019-07-08 Thread Shubhachint, Chaitanya
Hello, I run my dpdk applications with "file-prefix" option, so I can run them concurrently. I see that it creates a runtime directory under /var/run/dpdk. This directory still persists after the application has terminated. The code calls rte_eal_cleanup before exiting but that doesn't seem to

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-08 Thread Thomas Monjalon
08/07/2019 12:26, Thomas Monjalon: > 07/07/2019 07:41, Liron Himi: > > From: Akhil Goyal > > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform key > > > data type change for mvsam driver. > > > > > > Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant") > > > >

Re: [dpdk-dev] /run/dpdk cleanup

2019-07-08 Thread Stephen Hemminger
On Mon, 8 Jul 2019 15:00:43 + "Shubhachint, Chaitanya" wrote: > Hello, > > I run my dpdk applications with "file-prefix" option, so I can run them > concurrently. I see that it creates a runtime directory under /var/run/dpdk. > This directory still persists after the application has termin

Re: [dpdk-dev] [PATCH v4 2/2] doc: update according to the fifo per core impl

2019-07-08 Thread Hunt, David
Hi Anatoly, On 08/07/2019 14:34, Burakov, Anatoly wrote: On 13-Jun-19 10:21 AM, Hajkowski wrote: From: Marcin Hajkowski Updated power management docs for fifo JSON API. Removed from JSON API: * 'name' * 'resource_id' * 'core_list' Signed-off-by: Marcin Hajkowski Signed-off-by: Lukasz Krako

Re: [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address

2019-07-08 Thread Ferruh Yigit
On 7/1/2019 11:36 AM, Andy Pei wrote: > ipn3ke can work on 10G mode and 25G mode. > 10G mode and 25G mode has different MAC register address for statistics. > This patch implemente statistics registers for 10G mode and 25G mode. > > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") > Cc: rosen...

[dpdk-dev] [RFC] net/memif: allow for full key size in socket name

2019-07-08 Thread Stephen Hemminger
The key size for memif is 256 but the unix domain socket structure has space for 100 bytes. Change it to use a larger buffer and not hard code the keysize everywhere. Not sure what purpose of socket is anyway since there is no code which connects to it in the current tree anyway? Signed-off-by: S

Re: [dpdk-dev] [PATCH] net/mvneta: remove resources when port is closed

2019-07-08 Thread Ferruh Yigit
On 7/7/2019 11:25 AM, Jerin Jacob Kollanukkaran wrote: >> -Original Message- >> From: lir...@marvell.com >> Sent: Wednesday, July 3, 2019 1:28 PM >> To: Jerin Jacob Kollanukkaran >> Cc: dev@dpdk.org; Liron Himi ; Yuri Chipchev >> >> Subject: [PATCH] net/mvneta: remove resources when port

Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support

2019-07-08 Thread Thomas Monjalon
05/07/2019 15:58, Olivier Matz: > - As "readlink -e" and "readlink -m" do not exist on freebsd, > use "readlink -f", it should not have any impact in these cases. > - "sed -ri" is invalid on freebsd and should be replaced by > "sed -ri=''" > - Use gmake instead of make. > > This fixes the foll

Re: [dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare

2019-07-08 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Thursday, July 4, 2019 10:33 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: Gavin Hu (Arm Technology China) ; Ruifeng Wang (Arm >Technology China) ; >

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-08 Thread David Christensen
Please, any review or ack for this patch? 07/06/2019 04:28, Takeshi Yoshimura: sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. However, Linux 4.17 or before returns incorrect page_shift for Power9. I added the code for retrying creation of sPAPR DMA window. Signed-off-by:

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-08 Thread Wang, Yipeng1
>-Original Message- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: Thursday, July 4, 2019 9:10 AM >To: Honnappa Nagarahalli >Cc: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo >; gavin...@arm.com; >ruifeng.w...@arm.com; n...@arm.com

Re: [dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-07-08 Thread David Christensen
01/07/2019 22:41, Bruce Richardson: On Mon, Jul 01, 2019 at 09:30:02PM +0200, Thomas Monjalon wrote: 29/05/2019 17:41, Bruce Richardson: Use the flag checking functions and a couple of empty stubs to remove the ifdefs from the middle of the C code, and replace them with more readable regular

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: support raw encap/decap actions

2019-07-08 Thread Ferruh Yigit
On 7/2/2019 2:53 PM, Xiaoyu Min wrote: > This patch intend to support > action_raw_encap/decap [1] in a generic and convenient way. > > Two new commands - set raw_encap, set raw_decap are introduced just > like the other commands for encap/decap, i.e. set vxlan. > > These two commands have corres

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-08 Thread Thomas Monjalon
08/07/2019 18:47, David Christensen: > > Please, any review or ack for this patch? > > > > 07/06/2019 04:28, Takeshi Yoshimura: > >> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. > >> However, Linux 4.17 or before returns incorrect page_shift for Power9. > >> I added the c

Re: [dpdk-dev] [PATCH v7 0/4] match on GRE's key

2019-07-08 Thread Ferruh Yigit
On 7/5/2019 10:54 AM, Xiaoyu Min wrote: > This series patchs are based on RFC [1], which enable the matching on > GRE's key field. > And enabled MLX5 device supports on this. > > [1] https://patches.dpdk.org/patch/53432/ > > --- > v2: > * remove struct rte_flow_item_gre_key in order to comply n

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: rework api of rsa algorithm

2019-07-08 Thread Kusztal, ArkadiuszX
Hi Shally, With [AK] > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Saturday, July 6, 2019 3:14 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shally.ve...@caviumnetworks.com > Subject: RE: [PATCH v2 1/3] cryptodev:

Re: [dpdk-dev] [EXT] Re: [PATCH] net/af_packet: append system error to error msgs

2019-07-08 Thread Ferruh Yigit
On 7/5/2019 10:35 AM, Krzysztof Kanas wrote: > On 19-07-04 19:59, Ferruh Yigit wrote: >> External Email >> >> -- >> On 7/4/2019 3:39 PM, kka...@marvell.com wrote: >>> From: Krzysztof Kanas >>> >>> Print system error to make easier

Re: [dpdk-dev] [PATCH] net/af_xdp: correct xdp frame size

2019-07-08 Thread Ferruh Yigit
On 7/7/2019 4:57 PM, Xiaolong Ye wrote: > XSK_UMEM__DEFAULT_FRAME_SIZE has been changed to 4096 in kernel commit > 123e8da1d330 (xsk: Change the default frame size to 4096 and allow > controlling it), but we still need to keep ETH_AF_XDP_FRAME_SIZE as 2048 to > fit most dpdk apps. > > Signed-off-b

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-08 Thread Thomas Monjalon
08/07/2019 18:51, Wang, Yipeng1: >From: Thomas Monjalon [mailto:tho...@monjalon.net] > >02/07/2019 23:16, Honnappa Nagarahalli: > >> v2 > >> - Dropped moving the tbl_chng_cnt to the beginning of the cache line > >>commit > >> - Changed the commit log for patch 1 to indicate that it improves >

Re: [dpdk-dev] [PATCH] doc: fix a grammar mistake in rawdev guide

2019-07-08 Thread Thomas Monjalon
06/06/2019 11:32, Shreyansh Jain: > Though John has already acked it, and I was original culprit, more than one > Ack doesn't look bad :D > > From: Xiaolong Ye > > Fixes: a9bb0c44c775 ("doc: add rawdev library guide and doxygen page") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Xiaolong Ye

[dpdk-dev] [PATCH v8 0/7] add multiple cores feature to test-compress-perf

2019-07-08 Thread Artur Trybula
This patchset adds multiple cores feature to compression perf tool. All structures have been aligned and are consistent with crypto perf tool. All test cases have constructor, runner and destructor and can use more cores and compression devices at the same time. v8 changes: - some minor fixes (e

[dpdk-dev] [PATCH v8 1/7] app/test-compress-perf: add weak functions for multi-cores test

2019-07-08 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds template functions for multi-cores performance version of compress-perf-tool Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 3 +- app/test-compress-perf/comp_perf.h

[dpdk-dev] [PATCH v8 2/7] app/test-compress-perf: add ptest command line option

2019-07-08 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds --ptest option to make possible to choose test case from command line. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- .../comp_perf_options_parse.c | 32 +++ 1 file changed, 32 inser

[dpdk-dev] [PATCH v8 3/7] app/test-compress-perf: add verification test case

2019-07-08 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a verification part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile | 1 + .../

[dpdk-dev] [PATCH v8 4/7] app/test-compress-perf: add benchmark test case

2019-07-08 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a benchmark part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Also updates release notes. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/Makefile

[dpdk-dev] [PATCH v8 5/7] doc: update dpdk-test-compress-perf description

2019-07-08 Thread Artur Trybula
From: Tomasz Jozwiak This patch updates dpdk-test-compress-perf documentation. Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- doc/guides/tools/comp_perf.rst | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/comp

[dpdk-dev] [PATCH v8 7/7] app/test-compress-perf: 'magic numbers' removed

2019-07-08 Thread Artur Trybula
This patch fixes some minor problems like 'magic numbers', spelling mistakes, enumes naming. Signed-off-by: Artur Trybula --- app/test-compress-perf/comp_perf_options.h | 10 -- app/test-compress-perf/comp_perf_options_parse.c | 6 +++--- app/test-compress-perf/comp_perf_test_comm

[dpdk-dev] [PATCH v8 6/7] app/test-compress-perf: add force process termination

2019-07-08 Thread Artur Trybula
From: Tomasz Jozwiak This patch adds a possibility to force controlled process termination as a result of two signals: SIGTERM and SIGINT Signed-off-by: Tomasz Jozwiak Acked-by: Artur Trybula --- app/test-compress-perf/comp_perf_options.h| 1 + .../comp_perf_test_benchmark.c

[dpdk-dev] [PATCH v9 00/11] ether: improvements and optimizations

2019-07-08 Thread Stephen Hemminger
This is a collection of patches around the ethernet address manipulation routines in librte_net/rte_ether. v9 add missing librte_net for new octoeonx2 v8 set rte_errno in rte_eth_unformat_addr drop ether_address alignment patch. Bruce can handle deprecation and sending the patches late

[dpdk-dev] [PATCH v9 01/11] net/ether: deinline non-critical functions

2019-07-08 Thread Stephen Hemminger
Formatting Ethernet address and getting a random value are not in critical path so they should not be inlined. Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen Reviewed-by: Andrew Rybchenko Acked-by: Olivier Matz --- drivers/net/axgbe/Makefile | 2 +- drivers/net/memif/Makefile

[dpdk-dev] [PATCH v9 02/11] net/ether: add function to convert string to ethernet address

2019-07-08 Thread Stephen Hemminger
Make a function that can be used in place of eth_aton_r to convert a string to rte_ether_addr. This function allows both byte (xx:xx:xx:xx:xx:xx) and word (::) format and has the same lack of error handling as the original. This also allows ethdev to no longer have a hard dependency on

[dpdk-dev] [PATCH v9 04/11] net/ether: use bitops to speedup comparison

2019-07-08 Thread Stephen Hemminger
Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko Acked-by: Olivier Matz --- lib/librte_net/r

[dpdk-dev] [PATCH v9 03/11] ethdev: use new ethernet parsing function

2019-07-08 Thread Stephen Hemminger
Use rte_eth_unformat_addr, so that ethdev can be built and work without the cmdline library. The dependency on cmdline was an arrangement of convenience anyway. Signed-off-by: Stephen Hemminger --- lib/Makefile | 1 - lib/librte_ethdev/Makefile| 2 +- lib/librte_ethd

[dpdk-dev] [PATCH v9 07/11] app/testpmd: use new ethernet address parser

2019-07-08 Thread Stephen Hemminger
The cmdline_parse_ether_addr does not need to be used everywhere in testpmd. Can use rte_ether_unformat_addr instead. As an added bonus it eliminates some code for copying. Signed-off-by: Stephen Hemminger Acked-by: Bernard Iremonger --- app/test-pmd/cmdline_flow.c | 5 ++--- app/test-pmd/conf

[dpdk-dev] [PATCH v9 05/11] cmdline: use new ethernet address parser

2019-07-08 Thread Stephen Hemminger
Now that there is a version of ether_aton in rte_ether, it can be used by the cmdline ethernet address parser. Note: ether_aton_r can not be used in cmdline because the old code would accept either bytes XX:XX:XX:XX:XX:XX or words :: and we need to keep compatiablity. Signed-off-by: S

[dpdk-dev] [PATCH v9 08/11] net/virtio: use new ether addr parsing

2019-07-08 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/

[dpdk-dev] [PATCH v9 06/11] net/bonding: use new ethernet address parser

2019-07-08 Thread Stephen Hemminger
The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile| 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +- 3 fil

[dpdk-dev] [PATCH v9 09/11] net/failsafe: use common ether address parsing routine

2019-07-08 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args

[dpdk-dev] [PATCH v9 10/11] net/vdev_netvsc: use common ethernet address parsing

2019-07-08 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_ne

[dpdk-dev] [PATCH v9 11/11] net/memif: use common ethernet address parsing routine

2019-07-08 Thread Stephen Hemminger
Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index e9ddf6413597..00c9b396ab85

Re: [dpdk-dev] [PATCH] doc: fix link to pdf document

2019-07-08 Thread Thomas Monjalon
26/06/2019 17:23, Ali Alnubani: > The old link redirected to https://www.dpdk.org/events/. > > Signed-off-by: Ali Alnubani Applied, thanks

Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-08 Thread David Marchand
On Mon, Jul 8, 2019 at 4:25 PM wrote: > From: Jerin Jacob > > Existing logic fails to select IOVA mode as VA > if driver request to enable IOVA as VA. > > IOVA as VA has more strict requirement than other modes, > so enabling positive logic for IOVA as VA selection. > > This patch also updates t

Re: [dpdk-dev] [PATCH v2 1/1] net/hinic: use mutex replace spin lock

2019-07-08 Thread Ferruh Yigit
On 7/5/2019 7:47 AM, Ziyang Xuan wrote: > Using spin lock to protect critical resources > of sending mgmt messages. This will make high > CPU usage for rte_delay_ms when sending mgmt > messages frequently. We can use mutex to protect > the critical resources and usleep to reduce CPU > usage while k

Re: [dpdk-dev] [PATCH] net/mvneta: remove resources when port is closed

2019-07-08 Thread Liron Himi
Ack Regards, Liron -Original Message- From: Ferruh Yigit Sent: Monday, July 8, 2019 19:12 To: Jerin Jacob Kollanukkaran ; Liron Himi Cc: dev@dpdk.org; Yuri Chipchev Subject: Re: [PATCH] net/mvneta: remove resources when port is closed On 7/7/2019 11:25 AM, Jerin Jacob Kollanukkaran

Re: [dpdk-dev] [PATCH v9 00/11] ether: improvements and optimizations

2019-07-08 Thread Ferruh Yigit
On 7/8/2019 7:26 PM, Stephen Hemminger wrote: > This is a collection of patches around the ethernet address > manipulation routines in librte_net/rte_ether. > > v9 >add missing librte_net for new octoeonx2 > v8 >set rte_errno in rte_eth_unformat_addr >drop ether_address alignment patch

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-08 Thread Jerin Jacob Kollanukkaran
See below, Please send the email as text to avoid formatting issue.(No HTML) From: David Marchand Sent: Tuesday, July 9, 2019 12:09 AM To: Jerin Jacob Kollanukkaran Cc: dev ; Thomas Monjalon ; Ben Walker ; Burakov, Anatoly Subject: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode se

Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide

2019-07-08 Thread Thomas Monjalon
Hi please find some comments below: 06/06/2019 13:59, Hari Kumar Vemula: > +++ b/doc/guides/prog_guide/meson_ut.rst > @@ -0,0 +1,151 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Useless blank line. > +Copyright(c) 2018-2019 Intel Corporation. > + > +.. _meson_unit_tests: Useless anch

Re: [dpdk-dev] [PATCH v1 2/2] doc: update usage field for port-queue

2019-07-08 Thread Thomas Monjalon
07/05/2019 08:51, Vipin Varghese: > Usage option q is reflect how many port-queue pair can run per lcore. > Updating usage field to refelct port-queue is done for one RX and TX > only. > > Signed-off-by: Vipin Varghese > --- > +.. note:: > + > +DPDK port-queue pair configured is only one for

Re: [dpdk-dev] [PATCH] doc/api: add missing header file to API documentation

2019-07-08 Thread Thomas Monjalon
26/06/2019 18:32, Ferruh Yigit: > On 6/26/2019 4:20 PM, A.McLoughlin wrote: > > The APIs in the rte_bus_vdev.h file were not part of the API > > documentation. I added this header file to the doxygen config file with > > the name vdev. > > > > Signed-off-by: A.McLoughlin > > Acked-by: Ferruh Yig

Re: [dpdk-dev] [PATCH v2] doc: add search feature to API doc page

2019-07-08 Thread Thomas Monjalon
27/06/2019 15:58, A.McLoughlin: > I modified the API config file to incorperate a search button into the > API documentation page. > > Signed-off-by: A.McLoughlin Applied, thanks

Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide

2019-07-08 Thread Aaron Conole
Thomas Monjalon writes: > Hi please find some comments below: > > 06/06/2019 13:59, Hari Kumar Vemula: >> +++ b/doc/guides/prog_guide/meson_ut.rst >> @@ -0,0 +1,151 @@ >> +.. SPDX-License-Identifier: BSD-3-Clause >> + > > Useless blank line. > >> +Copyright(c) 2018-2019 Intel Corporation. >>

[dpdk-dev] [dpdk-announce] release candidate 19.08-rc1

2019-07-08 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.08-rc1 During the last two months, we have merged 823 new patches. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_19_08.html Please think about updating the release not

Re: [dpdk-dev] Compilation failure when disabling Cavium OCTEONTX network PMD driver

2019-07-08 Thread Daniel Pharos
Huh, looks like I've been hitting "Reply" instead of the required "Reply all", and the mailing list got dropped from the CC. Below is our conversation so far (might be incomplete). Kind regards, DanielPharos From: Daniel Pharos Sent: 08 July 2019 22:50 To: Jerin Jacob Kollanukkaran Subject: R

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-08 Thread Yongseok Koh
> On Jul 5, 2019, at 11:05 AM, Yongseok Koh wrote: > > > >> On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil >> wrote: >> >> On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: >>> A tag is a transient data which can be used during flow match. This can be >>> used to store match resu

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-08 Thread Liu, Yong
Thank, Ilya. > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, July 08, 2019 7:38 PM > To: Liu, Yong ; Bie, Tiwei ; > maxime.coque...@redhat.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue > function

Re: [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address

2019-07-08 Thread Pei, Andy
HI Ferruh OK. Thanks for your effort. Best Regards, -Original Message- From: Yigit, Ferruh Sent: Tuesday, July 9, 2019 12:01 AM To: Pei, Andy ; dev@dpdk.org Cc: Xu, Rosen Subject: Re: [dpdk-dev] [PATCH v5 1/4] net/ipn3ke: add new register address On 7/1/2019 11:36 AM, Andy Pei wrote: >

[dpdk-dev] (no subject)

2019-07-08 Thread dev-bounces
Eilon Greenstein ";" Yohad Tor ";" Raslan "rasl...@mellanox.com;" Jeff "jeffrey.tip...@microsoft.com;" Omar Cardona ";" Khoa "k...@microsoft.com;" Shahed Shaikh "shsha...@marvell.com;" Nareshkumar "nareshkumar@broadcom.com;" Satish "sati...@chelsio.com;" Indranil "indra...@chelsio.com;" Ra

[dpdk-dev] DPDK Windows Community call - 26 June 2019

2019-07-08 Thread Ranjit Menon
Attendees: (present) - Cathal Pallavi Ranjit Harini Haseeb Thomas Absent/apologies: Eilon Greenstein Yohad Tor Raslan rasl...@mellanox.com Bruce Jeff jeffrey.tip...@microsoft.com; Omar Cardona ; Harini harini.ramakrish...@microsoft.com; Khoa k...@microsoft.com; S

Re: [dpdk-dev] [v2] net/e1000: i219 unit hang issue fix on reset/close

2019-07-08 Thread Zhang, Xiao
Hi Wei, Thanks for your point. I219 supports dual rx and tx queues, I will update the fix. BR, Xiao > -Original Message- > From: Zhao1, Wei > Sent: Monday, July 8, 2019 4:36 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Zhang, Xiao > Subject: RE: [dpdk-dev] [v2] net/e1000: i219 unit hang is

[dpdk-dev] [v3] net/e1000: i219 unit hang issue fix on reset/close

2019-07-08 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. This state can be detected by configure status by bit 8 in register. If the bit is set and there are pending descriptors in one of the rings, we must flush them before reset or close. Signed-off-by: Xiao

Re: [dpdk-dev] [v3] net/e1000: i219 unit hang issue fix on reset/close

2019-07-08 Thread Zhao1, Wei
Acked-by: Wei Zhao > -Original Message- > From: Zhang, Xiao > Sent: Tuesday, July 9, 2019 8:23 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Zhang, Xiao > Subject: [v3] net/e1000: i219 unit hang issue fix on reset/close > > Unit hang may occur if multiple descriptors are available in the rin

[dpdk-dev] [PATCH] net/ice: fixed wrong return value

2019-07-08 Thread Qiming Yang
Fixed error return value check and wrong error message. Fixes: d76116a4678f ("net/ice: add generic flow API") Signed-off-by: Qiming Yang --- drivers/net/ice/ice_generic_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/n

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: support raw encap/decap actions

2019-07-08 Thread Jack Min
On Mon, 19-07-08, 18:41, Ferruh Yigit wrote: > On 7/2/2019 2:53 PM, Xiaoyu Min wrote: > > This patch intend to support > > action_raw_encap/decap [1] in a generic and convenient way. > > > > Two new commands - set raw_encap, set raw_decap are introduced just > > like the other commands for encap/d

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

2019-07-08 Thread Honnappa Nagarahalli
> > > > > > > > Compiler could generate non-atomic stores for whole table entry updating. > > > This may cause incorrect nexthop to be returned, if the byte with > > > valid flag is updated prior to the byte with next hot is updated. > >^^

Re: [dpdk-dev] [Suspected-Phishing][PATCH v7 3/4] net/mlx5: match GRE's key and present bits

2019-07-08 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Friday, July 5, 2019 12:54 > To: Adrien Mazarguil ; Ori Kam > ; Slava Ovsiienko ; > John McNamara ; Marko Kovacevic > ; Shahaf Shuler ; > Yongseok Koh > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v7 3/4] net/mlx5: match GRE's key

Re: [dpdk-dev] [Suspected-Phishing][PATCH v7 1/4] ethdev: add GRE key field to flow API

2019-07-08 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Friday, July 5, 2019 12:54 > To: Adrien Mazarguil ; Ori Kam > ; Slava Ovsiienko ; > John McNamara ; Marko Kovacevic > ; Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v7 1/4] et

Re: [dpdk-dev] [Suspected-Phishing][PATCH v7 4/4] app/testpmd: match GRE's key and present bits

2019-07-08 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Friday, July 5, 2019 12:54 > To: Adrien Mazarguil ; Ori Kam > ; Slava Ovsiienko ; > Wenzhuo Lu ; Jingjing Wu > ; Bernard Iremonger > ; John McNamara > ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v7 4/4] ap

Re: [dpdk-dev] [Suspected-Phishing][PATCH v7 2/4] net/mlx5: support match GRE protocol on DR engine

2019-07-08 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Friday, July 5, 2019 12:54 > To: Adrien Mazarguil ; Ori Kam > ; Slava Ovsiienko ; > Shahaf Shuler ; Yongseok Koh > > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v7 2/4] net/mlx5: support match GRE > protocol on DR engine > > DR e

Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: check port ownership

2019-07-08 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > On Mon, 8 Jul 2019 06:37:14 + > Matan Azrad wrote: > > > Hi Stephen > > > > From: Stephen Hemminger > > > Sent: Sunday, July 7, 2019 7:47 PM > > > To: Matan Azrad > > > Cc: anatoly.bura...@intel.com; dev@dpdk.org; Stephen Hemminger > > > > > > Subject:

Re: [dpdk-dev] [RFC] ethdev: support input set change by RSS action

2019-07-08 Thread Zhang, Qi Z
Hi Adrien: > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, July 4, 2019 10:09 PM > To: Zhang, Qi Z > Cc: Su, Simei ; Wu, Jingjing ; > Xing, Beilei ; Yang, Qiming ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] ethdev: support input set

Re: [dpdk-dev] [v3] net/e1000: i219 unit hang issue fix on reset/close

2019-07-08 Thread Anand H. Krishnan
Comments inline. On Tue, Jul 9, 2019 at 8:58 AM Xiao Zhang wrote: > > Unit hang may occur if multiple descriptors are available in the rings > during reset or close. This state can be detected by configure status > by bit 8 in register. If the bit is set and there are pending descriptors > in one

[dpdk-dev] [PATCH v5] net/i40e: i40e get link status update from ipn3ke

2019-07-08 Thread Andy Pei
Add switch_mode argument for i40e PF to specify the specific FPGA that i40e PF is connected to. i40e PF get link status update via the connected FPGA. Add bool switch_ethdev_support_flag to struct i40e_pf to specify if there are switch_mode argues in cmd. Add switch_ethdev to struct i40e_pf to trac

[dpdk-dev] [PATCH] net/mlx: allow build only on Linux

2019-07-08 Thread Thomas Monjalon
Currently mlx4/mlx5 support only Linux. Signed-off-by: Thomas Monjalon --- drivers/net/mlx4/meson.build | 11 +-- drivers/net/mlx5/meson.build | 10 +- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build inde

Re: [dpdk-dev] [PATCH] [v1]vhost: support inflight share memory protocol feature

2019-07-08 Thread Yu, Jin
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, July 5, 2019 4:47 PM > To: Yu, Jin ; dev@dpdk.org > Cc: Liu, Changpeng ; LinLi ; > XunNi ; YuZhang ; Bie, Tiwei > > Subject: Re: [dpdk-dev] [PATCH] [v1]vhost: support inflight share memory > protocol feature > > Hi Jin, >

Re: [dpdk-dev] [PATCH v4] net/i40e: i40e get link status update from ipn3ke

2019-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Pei, Andy > Sent: Monday, July 8, 2019 11:03 AM > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Qi Z ; Wu, > Jingjing ; Xing, Beilei ; Yigit, > Ferruh ; Xu, Rosen ; Ye, > Xiaolong ; Zhang, Roy Fan > ; sta...@dpdk.org > Subject: [PATCH v4] net/i40e: i40e get link

[dpdk-dev] [PATCH] net/af_xdp: correct xdp frame size

2019-07-08 Thread Xiaolong Ye
XSK_UMEM__DEFAULT_FRAME_SIZE has been changed to 4096 in kernel commit 123e8da1d330 (xsk: Change the default frame size to 4096 and allow controlling it), but we still need to keep ETH_AF_XDP_FRAME_SIZE as 2048 to fit most dpdk apps. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_x

[dpdk-dev] [Bug 308] Tap driver may leave some pending frame there but not retrieve

2019-07-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=308 Bug ID: 308 Summary: Tap driver may leave some pending frame there but not retrieve Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRME

Re: [dpdk-dev] [PATCH] net/af_xdp: correct xdp frame size

2019-07-08 Thread David Marchand
On Mon, Jul 8, 2019 at 10:03 AM Xiaolong Ye wrote: > XSK_UMEM__DEFAULT_FRAME_SIZE has been changed to 4096 in kernel commit > 123e8da1d330 (xsk: Change the default frame size to 4096 and allow > controlling it), but we still need to keep ETH_AF_XDP_FRAME_SIZE as 2048 to > fit most dpdk apps. > I

  1   2   >