08/07/2019 18:47, David Christensen: > > Please, any review or ack for this patch? > > > > 07/06/2019 04:28, Takeshi Yoshimura: > >> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. > >> However, Linux 4.17 or before returns incorrect page_shift for Power9. > >> I added the code for retrying creation of sPAPR DMA window. > >> > >> Signed-off-by: Takeshi Yoshimura <t...@jp.ibm.com> > > I've shared my comments with Takeshi and I don't think the patch is > ready in it's current state. It appears to modify x86 functionality and > I'm not comfortable with signing off on that since it's in an anrea I'm > not familiar with.
It is a function specific to sPAPR. So there is no risk for x86 or Arm. As you didn't share your comments publicly, this patch has been merged in 19.08-rc1.
