[dpdk-dev] [PATCH v2] net/mlx5: fix RSS validation function

2019-04-14 Thread Ori Kam
The RSS validation function was missing the verifcation that if RSS is requested on inner packet, the flow must have tunnel data. Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: sta...@dpdk.org Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- v2: * resend. --

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor

2019-04-14 Thread Shahaf Shuler
Hi Slava, Friday, April 12, 2019 6:48 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor > > On BlueField platform we have the new entity - PF representor. > This one represents the PCI PF attached to external host on the side of ARM. > The traffi

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS validation function

2019-04-14 Thread Shahaf Shuler
Sunday, April 14, 2019 10:05 AM, Ori Kam: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS validation function > > The RSS validation function was missing the verifcation that if RSS is > requested on inner packet, the flow must have tunnel data. > > Fixes: 23c1d42c7138 ("net/mlx5: split flow v

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-14 Thread Ruifeng Wang (Arm Technology China)
Hi Shreyansh, > -Original Message- > From: Shreyansh Jain > Sent: Friday, April 12, 2019 17:25 > To: Ananyev, Konstantin ; Ruifeng Wang > (Arm Technology China) ; dev@dpdk.org > Cc: nd > Subject: RE: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer > pool per port > > Hi Konst

[dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-14 Thread viveksharma
From: Vivek Sharma Enable missing support for QinQ strip rx offload in vlan offload set/get methods. Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") Cc: sta...@dpdk.org Signed-off-by: Vivek Sharma --- lib/librte_ethdev/rte_ethdev.c | 17 + lib/librte_

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Pavan Nikhilesh Bhagavatula
Hi Thomas, There is no guarantee of primary part number (machine names) uniqueness between implementors. If we limit lookups to only machine names through primary part number we would have a lot of repetitive defines. Also, moving the arrays into the python script is not feasible as meson need

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Thomas Monjalon
14/04/2019 16:40, Pavan Nikhilesh Bhagavatula: > Hi Thomas, > > There is no guarantee of primary part number (machine names) uniqueness > between implementors. I think we don't speak the same language :) By machine name, I mean what we set in RTE_MACHINE, like octeontx2. > If we limit lookups

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, April 14, 2019 11:14 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org; > jerinjac...@gmail.com; ys...@mellanox.com; bruce.richard...@intel.com > Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: ad

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Thomas Monjalon
14/04/2019 20:19, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > 14/04/2019 16:40, Pavan Nikhilesh Bhagavatula: > > > Hi Thomas, > > > > > > There is no guarantee of primary part number (machine names) uniqueness > > between implementors. > > > > I think we don't speak the same language :

[dpdk-dev] [PATCH] net/mlx5: fix release of jump to queue action

2019-04-14 Thread Ori Kam
Currenlty the allocation of the jump to QP is done in flow apply, this results in memory leak. This patch fixes this issue by moving the allocation and release of the jump to QP action to the responsiblity of the hrxq. Fixes: cbb66daa3c85 ("net/mlx5: prepare Direct Verbs for Direct Rule") Cc: sta

[dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group

2019-04-14 Thread Ori Kam
the flow group should be initialized. For example selecting if the encapsulation is for root or private tables is based on the flow->group value. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 1 + 1 file changed, 1 insertion(

[dpdk-dev] [PATCH] net/mlx5: fix modify header action position

2019-04-14 Thread Ori Kam
According to RTE flow the action order should be the order that the actions were given. In the case of modify actions the position of the action was always last. This commit solves this issue by saving the position of the first modify action, and then adds to this position the pointer to the modif

Re: [dpdk-dev] [PATCH v8 3/3] test/ticketlock: add ticket lock test case

2019-04-14 Thread Thomas Monjalon
08/04/2019 22:18, David Marchand: > On Mon, Mar 25, 2019 at 12:12 PM Joyce Kong wrote: > > --- a/app/test/autotest_data.py > > +++ b/app/test/autotest_data.py > > @@ -171,6 +171,12 @@ > > "Report": None, > > }, > > { > > +"Name":"Ticketlock autotest", > > +"

[dpdk-dev] [PATCH 0/9] net/mlx5: add Direct Verbs E-Switch support

2019-04-14 Thread Ori Kam
Currently MLX5 PMD supports 3 flow engines: Verbs, Direct Verbs and TCF. The first two engines are for Nic steering while the TCF is for E-Switch steering. This series add E-Switch steering support also for the DV engine. In order to support the new capability there should be support from both th

[dpdk-dev] [PATCH 1/9] net/mlx5: fix translate vport function name

2019-04-14 Thread Ori Kam
Modify the translate vport function to match other translate items naming convestions. Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") Cc: viachesl...@mellanox.com Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 12 ++-- 1 file changed, 6 inser

[dpdk-dev] [PATCH 3/9] net/mlx5: add Direct Rules configuration support

2019-04-14 Thread Ori Kam
This commit provides the basic configuration needed in order to support Direct Rules eswitch. Signed-off-by: Ori Kam --- drivers/net/mlx5/Makefile | 5 + drivers/net/mlx5/meson.build | 2 + drivers/net/mlx5/mlx5.c | 52 +- drivers/net/mlx5/mlx5.h | 12 +

[dpdk-dev] [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs

2019-04-14 Thread Ori Kam
This commits adds the port ID action to DV steering. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.h| 12 drivers/net/mlx5/mlx5_flow_dv.c | 149 drivers/net/mlx5/mlx5_glue.c| 14 drivers

[dpdk-dev] [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-14 Thread Ori Kam
This commit adds support for drop action when creating E-Switch flow using DV. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 26 -- drivers/net/mlx5/mlx5_glue.c| 12

[dpdk-dev] [PATCH 6/9] net/mlx5: add transfer attribute to matcher

2019-04-14 Thread Ori Kam
In current implementation the DV steering supported only NIC steering. This commit adds the transfer attribute in order to create a matcher on the FDB tabels. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c| 1 + drivers/net/mlx5/mlx5_flow.h| 2 ++ drivers/net/mlx5/mlx5_flow_dv

[dpdk-dev] [PATCH 4/9] net/mlx5: add validation for Direct Rule E-Switch

2019-04-14 Thread Ori Kam
Add validation logic for E-Switch using Direct Rules. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_ethdev.c | 39 +++ drivers/net/mlx5/mlx5_flow.h| 5 + drivers/net/mlx5/mlx5_flow_dv.c | 252 ++-- 4 file

[dpdk-dev] [PATCH 5/9] net/mlx5: add port ID item to Direct Verbs

2019-04-14 Thread Ori Kam
Adds the port ID item to the DV steering code. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 86 ++--- 1 file changed, 63 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index fedc6c

[dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules

2019-04-14 Thread Ori Kam
The meson build was missing the define for Direct Rules. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Cc: or...@mellanox.com Signed-off-by: Ori Kam --- drivers/net/mlx5/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/me

[dpdk-dev] [PATCH 8/9] net/mlx5: add Forward Database table type

2019-04-14 Thread Ori Kam
Actions like encap/decap, modify header require setting the flow table type. Until now we supported only Nic RX and Nic TX, this commits adds the support for FDB table type for those actions. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 54 ++--

Re: [dpdk-dev] [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72

2019-04-14 Thread Honnappa Nagarahalli
> > > > -- > > Per the email discussion [1], the default cache line size of armv8 > > cortex-a72 is changed to 64 bytes. > > IMO, In git commit you remove the reference to specific discussion and > Update the reason correctly. >

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-04-14 Thread Honnappa Nagarahalli
> > > > CONFIG_RTE_MACHINE="armv8a" > > +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=y > > This approach is not scalable. Even, it is not good for BlueField as you you > need to maintain two images. > > Unlike other CPU flags, arm64's crypto cpu flag is really _optional_. > Access to crypto instructions is a

[dpdk-dev] [PATCH v8 01/14] bus/ifpga: add AFU shared data

2019-04-14 Thread Rosen Xu
AFU can be implemented into many different acceleration devices, these devices need shared data to store private information when they are handled by users. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/rte_bus_ifpga.h | 7 +++ 1 file changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH v8 00/14] Add patch set for IPN3KE

2019-04-14 Thread Rosen Xu
v8 updates: = - Fix meter color definition replacement v7 updates: = - Fix Stephen comments v6 updates: == - Fix v5 comments - Fix TM Shaper rate issue v5 updates: == - Fix EXPERIMENTAL symbol definition issue v4 updates: == - Fix coding style issue

[dpdk-dev] [PATCH v8 03/14] net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-14 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE ethdev PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- MAINTAINERS | 6 + config/common_base| 4 + doc/guides/nics/features/ipn3ke.ini | 55

[dpdk-dev] [PATCH v8 06/14] net/ipn3ke: add IPN3KE Flow of PMD driver

2019-04-14 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE Flow of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |5 + drivers/net/ipn3ke/ipn3ke_ethdev.h |1 + drivers/ne

[dpdk-dev] [PATCH v8 04/14] net/ipn3ke: add IPN3KE representor of PMD driver

2019-04-14 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE representor of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile | 2 + drivers/net/ipn3ke/ipn3ke_ethdev.c | 4 +- drivers/net/ipn3ke/ipn3ke_ethdev.h | 25 + drive

[dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name

2019-04-14 Thread Rosen Xu
In many scenarios, AFU is needed searched by name, this function add the feature. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/ifpga_bus.c | 13 + drivers/bus/ifpga/rte_bus_ifpga.h | 9 + drivers/bus/ifpga/rte_bus_ifpga_versi

[dpdk-dev] [PATCH v8 05/14] net/ipn3ke: add IPN3KE TM of PMD driver

2019-04-14 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE TM of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |3 + drivers/net/ipn3ke/ipn3ke_ethdev.h |7 + drivers/net/

[dpdk-dev] [PATCH v8 09/14] raw/ifpga_rawdev: add SPI and MAX10 device driver

2019-04-14 Thread Rosen Xu
From: Tianfei zhang There is a SPI bus link between A10 FPGA and MAX10 FPGA. MAX10 is in charge of board management, like power management, sensors, flash devices. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile | 3 + drivers/raw/ifpga_rawdev/base/ifpga_d

[dpdk-dev] [PATCH v8 07/14] raw/ifpga_rawdev: clean up code for ifpga share code

2019-04-14 Thread Rosen Xu
From: Tianfei zhang clean up code: 1. use opae_memcpy instead of memcpy 2. use opae_memset instead of memset 3. disable opae_adapter_dump by default Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 2 +- drivers/raw/ifpga_rawdev/base/ifpga_feature_dev

[dpdk-dev] [PATCH v8 08/14] raw/ifpga_rawdev: store private features in FME and Port

2019-04-14 Thread Rosen Xu
From: Tianfei zhang Get private features attrubite like size, id, address after enumeration, and insert into FEM or Port dedicate list. when initial the private feature driver, we just compare the private feature id between the list and feature drivers array to match the proper drivers. This pa

[dpdk-dev] [PATCH v8 12/14] raw/ifpga_rawdev: add version description on README

2019-04-14 Thread Rosen Xu
From: Tianfei zhang add verion description on READ about ifpga base code. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/README | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/raw/ifpga_rawdev/base/README b/drivers/raw/ifpga_rawdev/base/README inde

[dpdk-dev] [PATCH v8 11/14] raw/ifpga_rawdev: add eth group driver

2019-04-14 Thread Rosen Xu
From: Tianfei zhang There is two eth group devices in PAC N3000 card, each eth group include PHY device and MAC device. Exposing APIs for DPDK PMD driver to access those devices. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile| 1 + drivers/raw/ifpga_rawde

[dpdk-dev] [PATCH v8 13/14] raw/ifpga_rawdev: using prefix name for feature and its ops

2019-04-14 Thread Rosen Xu
From: Tianfei zhang Using prefix name "ifpga_" for feature and feature_ops data struct on ifpga base code, which is suggested by Yigit, Ferruh. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c | 8 +-- drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c | 4 +-

[dpdk-dev] [PATCH v8 10/14] raw/ifpga_rawdev: add I2C and at24 EEPROM driver

2019-04-14 Thread Rosen Xu
From: Tianfei zhang 1. Add Altera I2C master device driver 2. Add at24 eeprom driver which is i2c slave device 3. Introducing a new ops for opae_manager: opae_manager_networking_ops. This ops will include some networking operation by FPGA, like vBNG operation, MAC ROM operation and so on. Signed

Re: [dpdk-dev] [PATCH v7 00/14] Add patch set for IPN3KE

2019-04-14 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Saturday, April 13, 2019 0:53 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia > Subject: Re: [PATCH v7 00/14] Add

[dpdk-dev] [PATCH v8 14/14] raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-04-14 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev. Signed-off-by: Rosen Xu Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga_rawdev/Makefile | 1 + drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 248 +++- drivers/raw/ifpga_r

Re: [dpdk-dev] TX unable to enqueue packets to NIC due to no free TX descriptor

2019-04-14 Thread Xiao, Xiaohong (NSB - CN/Shanghai)
Hello We met similar issue. DPDK17.11 + i40e. Tx queue seems full and hanging, no packets could be sent out at all. Has this issue gone and how? Thank you very much. Regards Nokia, Xiao Xiaohong -Original Message- From: users [mailto:users-boun...@dpdk.org] On Behalf Of Soni, Shivam Sen

[dpdk-dev] [PATCH] net/ice: enable RSS for IPv4/IPv6 packets

2019-04-14 Thread Leyi Rong
Signed-off-by: Leyi Rong --- drivers/net/ice/ice_ethdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9d0101870..8cc0e5447 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1657,

Re: [dpdk-dev] [PATCH v2] vhost: fix passing destroyed device to destroy callback

2019-04-14 Thread Tiwei Bie
On Fri, Apr 12, 2019 at 11:32:28AM +0300, Ilya Maximets wrote: > Application should be able to obtain information like 'ifname' from > the 'vid' passed to 'destroy_connection' callback. Currently, all the > API calls with passed 'vid' fails with 'device not found'. > > Fixes: efba12a78ddf ("vhost:

Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure

2019-04-14 Thread Tiwei Bie
On Thu, Apr 11, 2019 at 01:23:06PM +0300, Ilya Maximets wrote: > Need to destroy allocated device if application fails to > add new connection or we have fdset failure. > > Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") > Fixes: efba12a78ddf ("vhost: add user callbacks fo

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: share Memory Regions for multiport device

2019-04-14 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 22:22 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Shahaf Shuler > Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx5: share Memory Regions for > multiport device > > On Fri, Apr 12, 2019 at 03:45:40PM +, Viacheslav Ovsi

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-14 Thread Shreyansh Jain
Hi Ruifeng, [...] > > > > For hardware backed pools, hardware access and exclusion are > expensive. By > > segregating pool/port/lcores it is possible to attain a conflict free > path. This is > > the use-case this patch targets. > > And anyways, this is an optional feature. > > > > > Konstantin