> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, April 13, 2019 0:53
> To: Xu, Rosen <rosen...@intel.com>; dev@dpdk.org
> Cc: Zhang, Tianfei <tianfei.zh...@intel.com>; Wei, Dan
> <dan....@intel.com>; Pei, Andy <andy....@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>; Chen,
> Santos <santos.c...@intel.com>; Zhang, Zhang <zhang.zh...@intel.com>;
> Lomartire, David <david.lomart...@intel.com>; Hu, Jia <jia...@intel.com>
> Subject: Re: [PATCH v7 00/14] Add patch set for IPN3KE
>
> On 4/10/2019 7:27 AM, Rosen Xu wrote:
> > v7 updates:
> > =========
> > - Fix Stephen comments
> >
> > v6 updates:
> > ==========
> > - Fix v5 comments
> > - Fix TM Shaper rate issue
> >
> > v5 updates:
> > ==========
> > - Fix EXPERIMENTAL symbol definition issue
> >
> > v4 updates:
> > ==========
> > - Fix coding style issues
> >
> > v3 updates:
> > ==========
> > - Fix v2 comments
> > - Update MAC BAR of AFU index get ops
> > - Remove OPAE share code dependency of libfdt
> >
> > v2 updates:
> > ==========
> > - Fix v1 comments
> > - Add support for 10G Base Line Design Bitstream
> > - Add support for 25G Base Line Design Bitstream
> >
> > This patch set adds the support of a new net PMD, Intel® FPGA
> > Programmable Acceleration Card N3000, also called ipn3ke.
> >
> > The ipn3ke PMD (librte_pmd_ipn3ke) provides poll mode driver support
> > for Intel® FPGA PAC(Programmable Acceleration Card) N3000 based on the
> > Intel Ethernet Controller X710/XXV710 and Intel Arria 10 FPGA.
> >
> > In this card, FPGA is an acceleration bridge between network interface
> > and the Intel Ethernet Controller. Although both FPGA and Ethernet
> > Controllers are connected to CPU with PCIe Gen3x16 Switch, all the
> > packet RX/TX is handled by Intel Ethernet Controller. So from
> > application point of view the data path is still the legacy Intel
> > Ethernet Controller
> > X710/XXV710 PMD. Besides this, users can enable more acceleration
> > features by FPGA IP.
> >
> > Rosen Xu (7):
> > bus/ifpga: add AFU shared data
> > bus/ifpga: add function for AFU search by name
> > net/ipn3ke: add IPN3KE ethdev PMD driver
> > net/ipn3ke: add IPN3KE representor of PMD driver
> > net/ipn3ke: add IPN3KE TM of PMD driver
> > net/ipn3ke: add IPN3KE Flow of PMD driver
> > raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev
> >
> > Tianfei zhang (7):
> > raw/ifpga_rawdev: clean up code for ifpga share code
> > raw/ifpga_rawdev: store private features in FME and Port
> > raw/ifpga_rawdev: add SPI and MAX10 device driver
> > raw/ifpga_rawdev: add I2C and at24 EEPROM driver
> > raw/ifpga_rawdev: add eth group driver
> > raw/ifpga_rawdev: add version description on README
> > raw/ifpga_rawdev: using prefix name for feature and its ops
>
> Getting following build error [1], some tm enums seems merged into main
> repo, can you please send a new version with fix?
>
>
> [1]
> .../drivers/net/ipn3ke/ipn3ke_tm.c: In function
> ‘ipn3ke_tm_tdrop_profile_check’:
> .../drivers/net/ipn3ke/ipn3ke_tm.c:816:20: error: storage size of ‘color’
> isn’t
> known
> enum rte_tm_color color;
> ^~~~~
> .../drivers/net/ipn3ke/ipn3ke_tm.c:843:15: error: ‘RTE_TM_GREEN’
> undeclared (first use in this function); did you mean ‘RTE_COLOR_GREEN’?
> for (color = RTE_TM_GREEN; color <= RTE_TM_GREEN; color++) {
> ^~~~~~~~~~~~
> RTE_COLOR_GREEN
> .../drivers/net/ipn3ke/ipn3ke_tm.c:843:15: note: each undeclared identifier
> is reported only once for each function it appears in
> .../drivers/net/ipn3ke/ipn3ke_tm.c:816:20: error: unused variable ‘color’
> [-Werror=unused-variable]
> enum rte_tm_color color;
> ^~~~~
> .../drivers/net/ipn3ke/ipn3ke_tm.c: In function
> ‘ipn3ke_tm_tdrop_profile_add’:
> .../drivers/net/ipn3ke/ipn3ke_tm.c:919:31: error: ‘RTE_TM_GREEN’
> undeclared (first use in this function); did you mean ‘RTE_COLOR_GREEN’?
> min_th = profile->red_params[RTE_TM_GREEN].min_th;
> ^~~~~~~~~~~~
> RTE_COLOR_GREEN
> cc1: all warnings being treated as errors
> make[4]: *** [.../mk/internal/rte.compile-pre.mk:116: ipn3ke_tm.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
>
Fixed in v8.
