Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 12:14 PM > To: Jerin Jacob Kollanukkaran > Cc: Pavan Nikhilesh Bhagavatula ; Thomas > Monjalon ; dev ; > jerinjac...@gmail.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support > machine spec

[dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

2019-04-12 Thread Ayuj Verma
rte_crypto_sym.h is included prior to rte_crypto_asym.h in rte_crypto.h, which breaks alphabetical order. include rte_crypto_sym.h in rte_crypto_asym.h fixes this. Ayuj Verma (1): lib/crypto: fix alphabetical ordering of headers lib/librte_cryptodev/rte_crypto.h | 1 - lib/librte_cryptod

[dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers

2019-04-12 Thread Ayuj Verma
include rte_crypto_sym.h in rte_crypto_asym.h in place of including it in rte_crypto.h. Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- lib/librte_cryptodev/rte_crypto.h | 1 - lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v2 01/13] net/enetc: support physical addressing mode

2019-04-12 Thread Gagandeep Singh
Support added for physical addressing mode and change driver flags to don't care. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 22 -- drivers/net/enetc/enetc_rxtx.c | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v2 04/13] net/enetc: set interface mode for SXGMII

2019-04-12 Thread Gagandeep Singh
Support for SXGMII port has been enabled. It will depends on boot loader information passed through IERB. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 13 - drivers/net/enetc/enetc_ethdev.c | 11 +++ 2 files changed, 23 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 03/13] net/enetc: use correct buffer allocation API

2019-04-12 Thread Gagandeep Singh
rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 5 +++-- 1 file changed, 3 i

[dpdk-dev] [PATCH v2 02/13] net/enetc: fix SMMU unhandled context fault

2019-04-12 Thread Gagandeep Singh
First configure ring with BDs properly then enable the ring. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enetc/en

[dpdk-dev] [PATCH v2 00/13] ENETC PMD basic features and bug fixes

2019-04-12 Thread Gagandeep Singh
V1 log: * support added for MTU, jumbo frame, queue start/stop, promiscuous, multicast, crc offload, RX checksum validation, basic stats * some bug fixes V2 change-log: * remove unneeded code from stats get * fix big endian compilation Gagandeep Singh (13): net/enetc: support physical address

[dpdk-dev] [PATCH v2 05/13] net/enetc: add basic statistics

2019-04-12 Thread Gagandeep Singh
Enable basic statistics APIs enetc_stats_get and enetc_stats_reset. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 27 - drivers/net/enetc/enetc_ethdev.c | 41

[dpdk-dev] [PATCH v2 06/13] net/enetc: replace register read/write macros with functions

2019-04-12 Thread Gagandeep Singh
Replacing read-write macros with already available read-write functions. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc.h| 7 + drivers/net/enetc/enetc_ethdev.c | 61 2 files changed, 31 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH v2 08/13] net/enetc: enable promiscuous and allmulticast feature

2019-04-12 Thread Gagandeep Singh
Promiscuous and allmulticast enable/disable APIs added. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 3 +- drivers/net/enetc/enetc_ethdev.c | 90 ---

[dpdk-dev] [PATCH v2 07/13] net/enetc: remove forward declarations

2019-04-12 Thread Gagandeep Singh
Remove unneeded forward declarations and re-order the code. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 237 ++- 1 file changed, 107 insertions(+), 130 deletions(-) diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/en

[dpdk-dev] [PATCH v2 09/13] net/enetc: add MTU update and jumbo frames support

2019-04-12 Thread Gagandeep Singh
Enable the jumbo frames and mtu update feature. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 6 ++- drivers/net/enetc/enetc.h | 5 +++ drivers/net/enetc/enetc_ethdev.c |

[dpdk-dev] [PATCH v2 13/13] net/enetc: fix crash at high speed traffic

2019-04-12 Thread Gagandeep Singh
On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.si...@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 +++

[dpdk-dev] [PATCH v2 10/13] net/enetc: enable Rx-Tx queue start/stop feature

2019-04-12 Thread Gagandeep Singh
Rx and Tx queue start-stop and deferred queue start features enabled. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/enetc_ethdev.c | 185 ++--- 3 files changed, 134 in

[dpdk-dev] [PATCH v2 12/13] net/enetc: enable Rx checksum offload validation

2019-04-12 Thread Gagandeep Singh
Checksum Validation on Rx is supported. Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 15 +- drivers/net/enetc/enetc_rxtx.c | 107 - 4 f

[dpdk-dev] [PATCH v2 11/13] net/enetc: enable CRC offload feature

2019-04-12 Thread Gagandeep Singh
CRC offload keep feature supported Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 1 + drivers/net/enetc/enetc.h | 1 + drivers/net/enetc/enetc_ethdev.c | 20 ++

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-12 Thread Ayuj Verma
Hi Fiona, Please see inline. Thanks and regards Ayuj Verma From: Trahe, Fiona Sent: 09 April 2019 20:47 To: Ayuj Verma; akhil.go...@nxp.com; Kusztal, ArkadiuszX; De Lara Guarch, Pablo Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Yongseok Koh
> On Apr 11, 2019, at 11:43 PM, Yongseok Koh wrote: > > >> On Apr 11, 2019, at 11:07 PM, Jerin Jacob Kollanukkaran >> wrote: >> >> >> >>> -Original Message- >>> From: Yongseok Koh >>> Sent: Friday, April 12, 2019 7:35 AM >>> To: Pavan Nikhilesh Bhagavatula >>> Cc: Thomas Monjalon

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 12, 2019 5:07 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran > Cc: dev@dpdk.org; jerinjac...@gmail.com; ys...@mellanox.com; > bruce.richard...@intel.com > Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: a

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Yongseok Koh
> On Apr 12, 2019, at 12:00 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Yongseok Koh >> Sent: Friday, April 12, 2019 12:14 PM >> To: Jerin Jacob Kollanukkaran >> Cc: Pavan Nikhilesh Bhagavatula ; Thomas >> Monjalon ; dev ; >> jerinjac...@gmail.com >> Subjec

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 12:39 PM > To: Jerin Jacob Kollanukkaran > Cc: Pavan Nikhilesh Bhagavatula ; Thomas > Monjalon ; dev ; > jerinjac...@gmail.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support > machine sp

Re: [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores

2019-04-12 Thread David Marchand
On Thu, Apr 11, 2019 at 9:52 PM Aaron Conole wrote: > The arguments being passed will cause failures on laptops that have, > for instance, 2 cores only. Most of the tests don't require more > than a single core. Some require multiple cores (but those tests > should be modified to 'SKIP' when th

Re: [dpdk-dev] [PATCH 2/3] travis: add a distinguisher to the 'extra' builds

2019-04-12 Thread David Marchand
On Thu, Apr 11, 2019 at 9:52 PM Aaron Conole wrote: > This helps in two ways: > 1. When looking at travis page for dpdk, it's a visual distinction > > 2. For ccache support, the build IDs include the 'env', so we get unique > cache data. > > Signed-off-by: Aaron Conole > --- > .travis.

Re: [dpdk-dev] [PATCH 1/3] travis: enable ccache

2019-04-12 Thread David Marchand
On Thu, Apr 11, 2019 at 9:52 PM Aaron Conole wrote: > We try to make the planet happy travis builds dpdk. > > Also, the 'sudo' flag was recently deprecated. Drop it. > > Suggested-by: Luca Boccassi > Signed-off-by: Aaron Conole > --- > .travis.yml | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Yongseok Koh
> On Apr 12, 2019, at 12:35 AM, Jerin Jacob Kollanukkaran > wrote: > > > >> -Original Message- >> From: Yongseok Koh >> Sent: Friday, April 12, 2019 12:39 PM >> To: Jerin Jacob Kollanukkaran >> Cc: Pavan Nikhilesh Bhagavatula ; Thomas >> Monjalon ; dev ; >> jerinjac...@gmail.com >>

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-12 Thread Ilya Maximets
On 12.04.2019 7:39, Tiwei Bie wrote: > On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote: >> Application should be able to obtain information like 'ifname' from >> the 'vid' passed to 'destroy_connection' callback. Currently, all the >> API calls with passed 'vid' fails with 'device not

[dpdk-dev] [PATCH] build: automatically create windows exports file

2019-04-12 Thread Bruce Richardson
Rather than having a separate version.map file for linux/BSD and an exports definition file for windows for each library, generate the latter from the former automatically at build time. Signed-off-by: Bruce Richardson --- buildtools/map_to_def.py | 40 b

[dpdk-dev] [PATCH v2] vhost: fix passing destroyed device to destroy callback

2019-04-12 Thread Ilya Maximets
Application should be able to obtain information like 'ifname' from the 'vid' passed to 'destroy_connection' callback. Currently, all the API calls with passed 'vid' fails with 'device not found'. Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH v2 03/13] net/enetc: use correct buffer allocation API

2019-04-12 Thread Thomas Monjalon
12/04/2019 09:04, Gagandeep Singh: > rte_pktmbuf_alloc API should be used to allocate mbuf > instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf > information. > > Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") > Cc: g.si...@nxp.com You should mention it is also fixing big endian com

Re: [dpdk-dev] [PATCH] net/bnxt: Fix big endian build

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 10:16 AM, Somnath Kotur wrote: > The result of the endian conversion was not being used incorrectly. > > Reported-by: Thomas Monjalon > Signed-off-by: Somnath Kotur Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Thomas Monjalon
12/04/2019 09:12, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > 10/04/2019 18:13, jerinjac...@gmail.com: > > > From: Pavan Nikhilesh > > > > > > Currently, RTE_* flags are set based on the implementer ID but there > > > might be some micro arch specific differences from the same vendor e

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-12 Thread Igor Russkikh
>>> Please can you explain how it is related to rte_security? >> >> It is not. >> Do you mean macsec control API could be moved and logically be a part of >> rte_security api? >> I can't comment now on how feasible is this. Moreover this depends on how >> Intel considers >> and uses the existing

Re: [dpdk-dev] [EXT] Re: [PATCH v2 03/13] net/enetc: use correct buffer allocation API

2019-04-12 Thread Gagandeep Singh
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 12, 2019 2:08 PM > To: Gagandeep Singh > Cc: dev@dpdk.org; ferruh.yi...@intel.com> > > 12/04/2019 09:04, Gagandeep Singh: > > rte_pktmbuf_alloc API should be used to allocate mbuf > > instead of rte_pktmbuf_raw_alloc

Re: [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores

2019-04-12 Thread Bruce Richardson
On Fri, Apr 12, 2019 at 09:46:17AM +0200, David Marchand wrote: >On Thu, Apr 11, 2019 at 9:52 PM Aaron Conole <[1]acon...@redhat.com> >wrote: > > The arguments being passed will cause failures on laptops that have, > for instance, 2 cores only. Most of the tests don't require mo

Re: [dpdk-dev] [PATCH 1/3] travis: enable ccache

2019-04-12 Thread Luca Boccassi
On Thu, 2019-04-11 at 15:52 -0400, Aaron Conole wrote: > We try to make the planet happy travis builds dpdk. > > Also, the 'sudo' flag was recently deprecated. Drop it. > > Suggested-by: Luca Boccassi < > bl...@debian.org > > > Signed-off-by: Aaron Conole < > acon...@redhat.com > > > --- > .tra

Re: [dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores

2019-04-12 Thread Luca Boccassi
On Thu, 2019-04-11 at 15:52 -0400, Aaron Conole wrote: > The arguments being passed will cause failures on laptops that have, > for instance, 2 cores only. Most of the tests don't require more > than a single core. Some require multiple cores (but those tests > should be modified to 'SKIP' when t

Re: [dpdk-dev] [PATCH 2/3] travis: add a distinguisher to the 'extra' builds

2019-04-12 Thread Luca Boccassi
On Thu, 2019-04-11 at 15:52 -0400, Aaron Conole wrote: > This helps in two ways: > 1. When looking at travis page for dpdk, it's a visual distinction > > 2. For ccache support, the build IDs include the 'env', so we get > unique > cache data. > > Signed-off-by: Aaron Conole < > acon...@r

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-12 Thread Shreyansh Jain
Hi Konstantin, Ruifeng, > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, April 8, 2019 3:00 PM > To: Ruifeng Wang (Arm Technology China) ; > Shreyansh Jain ; dev@dpdk.org > Cc: nd > Subject: RE: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer > pool per port >

[dpdk-dev] [PATCH V2] doc: add guideines for initial PMD submission

2019-04-12 Thread Rami Rosen
This patch for DPDK Contributor's Guidelines indicates the repos against which a new PMD should be prepared; for example, for new network ethernet PMDs it should be dpdk-next-net, and for new crypto PMDs it should be dpdk-next-crypto. For other new PMDs, the contributor should refer to the MAINT

[dpdk-dev] [PATCH 1/1] net/qede: update feature support matrix with flow API

2019-04-12 Thread Shahed Shaikh
Commit 267d32de46a8 ("net/qede: support generic flow API") added a support for RTE_FLOW APIs but did not update the feature support matrix. Fixes: 267d32de46a8 ("net/qede: support generic flow API") Signed-off-by: Shahed Shaikh --- doc/guides/nics/features/qede.ini | 1 + 1 file changed, 1 inse

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-12 Thread Trahe, Fiona
Hi Ayuj From: Ayuj Verma [mailto:ayve...@marvell.com] Sent: Friday, April 12, 2019 8:08 AM To: Trahe, Fiona ; akhil.go...@nxp.com; Kusztal, ArkadiuszX ; De Lara Guarch, Pablo Cc: Shally Verma ; Sunila Sahu ; Kanaka Durga Kotamarthy ; Arvind Desai ; dev@dpdk.org Subject: Re: [PATCH v2] app/tes

[dpdk-dev] [PATCH V3] doc: add guideines for initial PMD submission

2019-04-12 Thread Rami Rosen
This patch for DPDK Contributor's Guidelines indicates the repos against which a new PMD should be prepared; for example, for new network ethernet PMDs it should be dpdk-next-net, and for new crypto PMDs it should be dpdk-next-crypto. For other new PMDs, the contributor should refer to the MAINT

Re: [dpdk-dev] [PATCH] app/test/ipsec: fix logic around dequeue burst

2019-04-12 Thread Ananyev, Konstantin
Hi Bernard, /ipsec: fix logic around dequeue burst > > Call rte_crypto_dequeue_burst() in a loop with > a delay to ensure that all the packets are dequeued > from the crtpto device. > > Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") > Cc: sta...@dpdk.org > Signed-off-by: Bernard Iremo

[dpdk-dev] [PATCH v3 02/13] net/enetc: fix SMMU unhandled context fault

2019-04-12 Thread Gagandeep Singh
First configure ring with BDs properly then enable the ring. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enetc/en

[dpdk-dev] [PATCH v3 03/13] net/enetc: fix big endian build and correct buffer allocation

2019-04-12 Thread Gagandeep Singh
There was an error at rte_constant_bswap64 while compiling with big endian toolchain. so fixing it by adding type cast. Also, rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx a

[dpdk-dev] [PATCH v3 01/13] net/enetc: support physical addressing mode

2019-04-12 Thread Gagandeep Singh
Support added for physical addressing mode and change driver flags to don't care. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 22 -- drivers/net/enetc/enetc_rxtx.c | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v3 00/13] ENETC PMD basic features and bug fixes

2019-04-12 Thread Gagandeep Singh
V1 log: * support added for MTU, jumbo frame, queue start/stop, promiscuous, multicast, crc offload, RX checksum validation, basic stats * some bug fixes V2 change-log: * remove unneeded code from stats get * fix big endian compilation v3 change-log: * commit message updated for 03/13 pat

[dpdk-dev] [PATCH v3 04/13] net/enetc: set interface mode for SXGMII

2019-04-12 Thread Gagandeep Singh
Support for SXGMII port has been enabled. It will depends on boot loader information passed through IERB. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 13 - drivers/net/enetc/enetc_ethdev.c | 11 +++ 2 files changed, 23 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v3 07/13] net/enetc: remove forward declarations

2019-04-12 Thread Gagandeep Singh
Remove unneeded forward declarations and re-order the code. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 237 ++- 1 file changed, 107 insertions(+), 130 deletions(-) diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/en

[dpdk-dev] [PATCH v3 06/13] net/enetc: replace register read/write macros with functions

2019-04-12 Thread Gagandeep Singh
Replacing read-write macros with already available read-write functions. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc.h| 7 + drivers/net/enetc/enetc_ethdev.c | 61 2 files changed, 31 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH v3 05/13] net/enetc: add basic statistics

2019-04-12 Thread Gagandeep Singh
Enable basic statistics APIs enetc_stats_get and enetc_stats_reset. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 27 - drivers/net/enetc/enetc_ethdev.c | 41

[dpdk-dev] [PATCH v3 08/13] net/enetc: enable promiscuous and allmulticast feature

2019-04-12 Thread Gagandeep Singh
Promiscuous and allmulticast enable/disable APIs added. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 3 +- drivers/net/enetc/enetc_ethdev.c | 90 ---

[dpdk-dev] [PATCH v3 10/13] net/enetc: enable Rx-Tx queue start/stop feature

2019-04-12 Thread Gagandeep Singh
Rx and Tx queue start-stop and deferred queue start features enabled. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/enetc_ethdev.c | 185 ++--- 3 files changed, 134 in

[dpdk-dev] [PATCH v3 11/13] net/enetc: enable CRC offload feature

2019-04-12 Thread Gagandeep Singh
CRC offload keep feature supported Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 1 + drivers/net/enetc/enetc.h | 1 + drivers/net/enetc/enetc_ethdev.c | 20 ++

[dpdk-dev] [PATCH v3 09/13] net/enetc: add MTU update and jumbo frames support

2019-04-12 Thread Gagandeep Singh
Enable the jumbo frames and mtu update feature. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 6 ++- drivers/net/enetc/enetc.h | 5 +++ drivers/net/enetc/enetc_ethdev.c |

[dpdk-dev] [PATCH v3 12/13] net/enetc: enable Rx checksum offload validation

2019-04-12 Thread Gagandeep Singh
Checksum Validation on Rx is supported. Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 15 +- drivers/net/enetc/enetc_rxtx.c | 107 - 4 f

[dpdk-dev] [PATCH v3 13/13] net/enetc: fix crash at high speed traffic

2019-04-12 Thread Gagandeep Singh
On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 +++

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-12 Thread Thomas Monjalon
12/04/2019 10:50, Igor Russkikh: > > >>> Please can you explain how it is related to rte_security? > >> > >> It is not. > >> Do you mean macsec control API could be moved and logically be a part of > >> rte_security api? > >> I can't comment now on how feasible is this. Moreover this depends on h

Re: [dpdk-dev] [PATCH] app/test/ipsec: fix logic around dequeue burst

2019-04-12 Thread Iremonger, Bernard
Hi Konstantin, > > Call rte_crypto_dequeue_burst() in a loop with a delay to ensure that > > all the packets are dequeued from the crtpto device. > > > > Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") > > Cc: sta...@dpdk.org > > Signed-off-by: Bernard Iremonger > > --- > > app/test/t

Re: [dpdk-dev] [PATCH v7] net/nfb: new netcope driver

2019-04-12 Thread Ferruh Yigit
On 4/7/2019 4:03 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay <...> > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config > --cflags ne

Re: [dpdk-dev] [PATCH v7] net/nfb: new netcope driver

2019-04-12 Thread Ferruh Yigit
On 4/7/2019 4:03 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay Hi Rastislav, Welcome to DPDK! Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

2019-04-12 Thread Pradeep Satyanarayana
> > > We are still seeing some compilation issues regularly on Power. > > > Before going to DTS, I think you should extend your compilation testing, > > > and basic feature testing with builtin unit tests. > > > > We have not observed any compilation issues since we started the CI. The > > last i

Re: [dpdk-dev] [PATCH v4 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Paul E. McKenney
On Thu, Apr 11, 2019 at 04:35:04AM +, Honnappa Nagarahalli wrote: > Hi Paul, > Thank you for your feedback. > > > -Original Message- > > From: Paul E. McKenney > > Sent: Wednesday, April 10, 2019 1:15 PM > > To: Honnappa Nagarahalli > > Cc: konstantin.anan...@intel.com; step...

Re: [dpdk-dev] [PATCH v3] net/ice: stop lldp by default

2019-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Friday, April 12, 2019 6:10 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v3] net/ice: stop lldp by default > > This patch stopped lldp by default to avoid the statistics error. > > Signed-off-by: Qiming Yang

[dpdk-dev] [PATCH v4 01/13] net/enetc: support physical addressing mode

2019-04-12 Thread Gagandeep Singh
Support added for physical addressing mode and change driver flags to don't care. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 22 -- drivers/net/enetc/enetc_rxtx.c | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v4 02/13] net/enetc: fix SMMU unhandled context fault

2019-04-12 Thread Gagandeep Singh
First configure ring with BDs properly then enable the ring. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enetc/en

[dpdk-dev] [PATCH v4 00/13] ENETC PMD basic features and bug fixes

2019-04-12 Thread Gagandeep Singh
*V1 log: * support added for MTU, jumbo frame, queue start/stop, promiscuous, multicast, crc offload, RX checksum validation, basic stats * some bug fixes V2 change-log: * remove unneeded code from stats get * fix big endian compilation v3 change-log: * commit message updated for 03/13 pa

[dpdk-dev] [PATCH v4 03/13] net/enetc: fix big endian build and correct buffer allocation

2019-04-12 Thread Gagandeep Singh
There was an error at rte_constant_bswap64 while compiling with big endian toolchain. so fixing it by adding type cast. Also, rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx a

[dpdk-dev] [PATCH v4 05/13] net/enetc: add basic statistics

2019-04-12 Thread Gagandeep Singh
Enable basic statistics APIs enetc_stats_get and enetc_stats_reset. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 27 +++- drivers/net/enetc/enetc_ethdev.c | 41 +

[dpdk-dev] [PATCH v4 06/13] net/enetc: replace register read/write macros with functions

2019-04-12 Thread Gagandeep Singh
Replacing read-write macros with already available read-write functions. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc.h| 7 +--- drivers/net/enetc/enetc_ethdev.c | 61 2 files changed, 31 insertions(+), 37 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v4 04/13] net/enetc: set interface mode for SXGMII

2019-04-12 Thread Gagandeep Singh
Support for SXGMII port has been enabled. It will depends on boot loader information passed through IERB. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 13 - drivers/net/enetc/enetc_ethdev.c | 11 +++ 2 files changed, 23 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v4 07/13] net/enetc: remove forward declarations

2019-04-12 Thread Gagandeep Singh
Remove unneeded forward declarations and re-order the code. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 237 ++- 1 file changed, 107 insertions(+), 130 deletions(-) diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethd

[dpdk-dev] [PATCH v4 08/13] net/enetc: enable promiscuous and allmulticast feature

2019-04-12 Thread Gagandeep Singh
Promiscuous and allmulticast enable/disable APIs added. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 3 +- drivers/net/enetc/enetc_ethdev.c | 90 +- 4 f

[dpdk-dev] [PATCH v4 10/13] net/enetc: enable Rx-Tx queue start/stop feature

2019-04-12 Thread Gagandeep Singh
Rx and Tx queue start-stop and deferred queue start features enabled. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/enetc_ethdev.c | 185 - 3 files changed, 134 insertions

[dpdk-dev] [PATCH v4 11/13] net/enetc: enable CRC offload feature

2019-04-12 Thread Gagandeep Singh
CRC offload keep feature supported Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 1 + drivers/net/enetc/enetc.h | 1 + drivers/net/enetc/enetc_ethdev.c | 20 ++

[dpdk-dev] [PATCH v4 09/13] net/enetc: add MTU update and jumbo frames support

2019-04-12 Thread Gagandeep Singh
Enable the jumbo frames and mtu update feature. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 6 ++- drivers/net/enetc/enetc.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 8

[dpdk-dev] [PATCH v4 12/13] net/enetc: enable Rx checksum offload validation

2019-04-12 Thread Gagandeep Singh
Checksum Validation on Rx is supported. Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 15 +++- drivers/net/enetc/enetc_rxtx.c | 107 + 4 files chang

[dpdk-dev] [PATCH v4 13/13] net/enetc: fix crash at high speed traffic

2019-04-12 Thread Gagandeep Singh
On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 +++

[dpdk-dev] [PATCH] vhost: fix silent queue enabling with legacy guests

2019-04-12 Thread Ilya Maximets
vhost should notify the application in case of all vring state changes. In general, application should not care about negotiation of VHOST_USER_F_PROTOCOL_FEATURES. Protocol details like this should be hidden by the vhost library. With this patch applications like OVS will be able to assume that

[dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-12 Thread Andrew Rybchenko
Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 12 ++--

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread Thomas Monjalon
19/03/2019 18:54, Stephen Hemminger: > My preference would be: > 1. Make all DPDK drivers consistent in usage of current statistic values. > 2. Propose an enhancement to have new ethdev statistics match some > pre-existing > standard like SNMP or other RFC. This patch is about basic stat

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread Thomas Monjalon
26/03/2019 10:29, David Marchand: > On Tue, Mar 19, 2019 at 6:18 PM Ferruh Yigit wrote: > > > On 3/14/2019 3:13 PM, David Marchand wrote: > > > Introduce a new api to retrieve per queue statistics from the drivers. > > > The api objectives: > > > - easily add some common per queue statistics and

Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler

2019-04-12 Thread Chas Williams
I should have some time this weekend to run these patches through our regression system. On 4/10/19 8:53 AM, David Marchand wrote: fast queue Rx burst function is missing checks on promisc and the slave collecting state. Define an inline wrapper to have a common base. Fixes: 112891cd27e5 ("net/

[dpdk-dev] [PATCH 1/2] net/ice: code clean

2019-04-12 Thread Wang Ying A
Variable "status" should be difined as "int" instead of "uint_16t". This patch fixes the issue. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[dpdk-dev] [PATCH 0/2] ice: code clean and promisc mode fix

2019-04-12 Thread Wang Ying A
Patch 1/2 modifies the variable type of "status" from "uint16_t" to "int" to follow the standard programming style. Patch 2/2 adds a return value check to give user a correct prompt. Wang Ying A (2): net/ice: code clean net/ice: fix promiscuous mode drivers/net/ice/ice_ethdev.c | 12 +++

[dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode

2019-04-12 Thread Wang Ying A
When device promiscuous mode has already been enabled, if user re-enables the promisc mode, he/she should be prompted with "Promisc has already been enabled" rather than "Failed to enable promisc". Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Wang Y

[dpdk-dev] [PATCH v2] app/test/ipsec: fix logic around dequeue burst

2019-04-12 Thread Bernard Iremonger
Added crypto_dequeue_burst() function to call rte_crypto_dequeue_burst() in a loop with a delay to ensure that all the packets are dequeued from the crtpto device. Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Fiona Trahe

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread David Marchand
On Fri, Apr 12, 2019 at 3:29 PM Thomas Monjalon wrote: > 26/03/2019 10:29, David Marchand: > > On Tue, Mar 19, 2019 at 6:18 PM Ferruh Yigit > wrote: > > > > > On 3/14/2019 3:13 PM, David Marchand wrote: > > > > Introduce a new api to retrieve per queue statistics from the > drivers. > > > > The

[dpdk-dev] [PATCH] net/nfb: remove redundant linking

2019-04-12 Thread Rastislav Cernay
From: Rastislav Cernay Signed-off-by: Rastislav Cernay --- drivers/net/nfb/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfb/Makefile b/drivers/net/nfb/Makefile index 21b09b3..a84b423 100644 --- a/drivers/net/nfb/Makefile +++ b/drivers/net/nfb/Makefile @@ -16,7 +16,6 @

Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-12 Thread Iremonger, Bernard
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, April 12, 2019 2:13 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/testpmd: set fixed flag when exact link speed is > ch

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > It allows applications running packet sockets over KNI interfaces to get > source Ethernet addresses of packets received using recvfrom function. > > Signed-off-by: Igor Ryzhov Acked-by: Ferruh Yigit Hi Igor, I tested this with a quick application

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: >> It allows applications running packet sockets over KNI interfaces to get >> source Ethernet addresses of packets received using recvfrom function. >> >> Signed-off-by: Igor Ryzhov > > Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-12 Thread Xiaolong Ye
As David pointed out, if we reserve N slots, but only submit n slots, we would end up with an incorrect opinion of the number of available slots later, we also would get wrong idx when we call xsk_ring_prod__reserve next time. It also applies to xsk_ring_cons__peek()/xsk_ring_cons__release(). This

[dpdk-dev] [PATCH 1/2] net/af_xdp: enqueue buf ring when allocate Tx queue fails

2019-04-12 Thread Xiaolong Ye
When it fails to allocate enough slots in Tx queue for transmitting packets, we need to return the dequeued addrs to buf ring. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [dpdk-dev] [PATCH] net/nfb: remove redundant linking

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 3:37 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Signed-off-by: Rastislav Cernay Squashed into relevant commit in next-net, thanks.

[dpdk-dev] [RFC PATCH] mbuf: outer offsets must be zero for non-tunnel packets

2019-04-12 Thread Ivan Malov
Make sure that outer L2 and L3 header length fields are equal to zero for non-tunnel packets in order to ensure consistent and predictable behaviour in network drivers. Explain this expectation in comments to help developers. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- Notes:

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-04-12 Thread Thomas Monjalon
11/03/2019 18:22, Ferruh Yigit: > On 3/4/2019 11:18 AM, David Marchand wrote: > > According to the api, the q_errors[] per queue statistic is for reception > > errors not transmit errors. > > This is a first cleanup on statistics before looking at oerrors. > > > > Yes, the patchset looks aligned

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

2019-04-12 Thread Trahe, Fiona
Hi Ayuj, > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.go...@nxp.com; Kusztal, ArkadiuszX ; > Trahe, Fiona > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade...@marvell.com; > dev@dpdk.

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 4:07 PM, Thomas Monjalon wrote: > 11/03/2019 18:22, Ferruh Yigit: >> On 3/4/2019 11:18 AM, David Marchand wrote: >>> According to the api, the q_errors[] per queue statistic is for reception >>> errors not transmit errors. >>> This is a first cleanup on statistics before looking at oer

  1   2   >