Re: [dpdk-dev] [PATCH 3/3] vhost: fix null pointer checking

2019-04-04 Thread Tiwei Bie
On Thu, Apr 04, 2019 at 02:47:24PM +0800, Ye Xiaolong wrote: > Hi, Tiwei, > > On 04/04, Tiwei Bie wrote: > [snip] > >> @@ -515,7 +515,7 @@ rte_vhost_get_ifname(int vid, char *buf, size_t len) > >> { > >>struct virtio_net *dev = get_device(vid); > >> > >> - if (dev == NULL) > >> + if (dev

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Ye Xiaolong > Sent: Thursday, April 4, 2019 1:55 PM > To: Ferruh Yigit ; Luca Boccassi > Cc: dev@dpdk.org; Stephen Hemminger ; > Qi Zhang ; Karlsson Magnus > ; Topel Bjorn ; > Maxime Coquelin ; Bruce Richardson > ; Ananyev Konstantin > ; David

[dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-04 Thread Shreyansh Jain
Removes some unused firmware code which was added in last bump of the firmware version. No current features uses these APIs. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/mc/dpci.c | 75 drivers/bus/fslmc/mc/dpcon.c | 30 - drivers/bus/

[dpdk-dev] [PATCH v2 2/3] drivers: update MC firmware version for FSLMC bus

2019-04-04 Thread Shreyansh Jain
MC firmware is the core component of FSLMC bus and DPAA2 devices. Prior to this patch, MC firmware supported 10.10.x version. This patch bumps the min supported version to 10.14.x. Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- drivers/bus/fslmc/mc/fsl_dpmng.h| 2 +- drivers/ne

[dpdk-dev] [PATCH v2 0/3] Update FSLMC bus firmware

2019-04-04 Thread Shreyansh Jain
Based on net-next: 69f805ac18abe All the patches are strictly within DPAA2/FSLMC driver area. MC firmware is the core component of FSLMC bus which enables all the dpaa2 devices (eth, crypto etc). With recent release of NXP's layerscape SDK, the MC firmware has been bumped up. These patches update

[dpdk-dev] [PATCH v2 3/3] doc: bump SDK support version for dpaa2

2019-04-04 Thread Shreyansh Jain
With the change in MC firmware, minimum supported version of the Layerscape SDK too needs to be changed. Signed-off-by: Shreyansh Jain --- doc/guides/nics/dpaa2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst index

Re: [dpdk-dev] [PATCH v9 3/8] test/stack: add stack test

2019-04-04 Thread Thomas Monjalon
04/04/2019 01:20, Gage Eads: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -431,6 +431,7 @@ M: Olivier Matz > F: lib/librte_stack/ > F: doc/guides/prog_guide/stack_lib.rst > F: drivers/mempool/stack/ > +F: test/test/*stack* Should be app/test/test_stack*

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-04 Thread Mattias Rönnblom
On 2019-04-04 07:39, Venky Venkatesh wrote: On 4/3/19, 12:02 PM, "Mattias Rönnblom" wrote: On 2019-04-03 20:36, Venky Venkatesh wrote: > > > On 4/3/19, 11:34 AM, "Mattias Rönnblom" wrote: > > On 2019-04-03 20:17, Venky Venkatesh wrote: > > Hi,

Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture

2019-04-04 Thread David Marchand
On Tue, Apr 2, 2019 at 5:30 PM Varghese, Vipin wrote: > Hi David, > > > > snipped > #define CMD_LINE_OPT_PDUMP "pdump" > +#define CMD_LINE_OPT_PDUMP_NUM 1 > +#define CMD_LINE_OPT_MULTI "multi" > +#define CMD_LINE_OPT_MULTI_NUM 2 > #define PDUMP_PORT_ARG "port" > #define PDUMP_PCI_ARG "device_i

Re: [dpdk-dev] Query : Does Binding with vfio-pci is supported inside qemu-kvm guest/vm instance.?

2019-04-04 Thread John Sucaet
Hi Maxime, Thanks for your answer. I want to add that I have this problem both with 18.08 and 18.11. Also I am using qemu with machine type pc-q35-2.10 (and pcie-root). When I change it to machine type pc-i440fx-2.4 (and pci-root), I don't see the problem. Ports are in that case, detected in

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-04 Thread Mohammad Abdul Awal
On 03/04/2019 18:32, David Marchand wrote: On Wed, Apr 3, 2019 at 6:53 PM Ferruh Yigit > wrote: On 4/3/2019 5:41 PM, Bruce Richardson wrote: > On Wed, Apr 03, 2019 at 05:35:22PM +0100, Ferruh Yigit wrote: >> On 4/3/2019 5:27 PM, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Luca Boccassi
On Thu, 2019-04-04 at 13:55 +0800, Ye Xiaolong wrote: > Hi, Luca > > On 04/03, Luca Boccassi wrote: > > On Wed, 2019-04-03 at 18:44 +0100, Ferruh Yigit wrote: > > > On 4/3/2019 5:59 PM, Xiaolong Ye wrote: > > > > Add a new PMD driver for AF_XDP which is a proposed faster > > > > version > > > > of

Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Ye Xiaolong
On 04/04, Luca Boccassi wrote: >> >> After apply the fix in af_xdp pmd's meson.build, now I was able to >> build >> library for af_xdp pmd. >> >> $ ls drivers/ |grep xdp >> a715181@@rte_pmd_af_xdp@sha >> a715181@@rte_pmd_af_xdp@sta >> a715181@@tmp_rte_pmd_af_xdp@sta >> librte_pmd_af_xdp.a >> libr

[dpdk-dev] [PATCH v2] vhost: fix null pointer checking

2019-04-04 Thread Mohammad Abdul Awal
Null value for parameters will cause segfault. Fixes: d7280c9fff ("vhost: support selective datapath") Fixes: 72e8543093df ("vhost: add API to get MTU value") Fixes: a277c71598 ("vhost: refactor code structure") Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") Fixes: eb32247

[dpdk-dev] [PATCH v6 0/2] app/pdump: enhance to support unique cores

2019-04-04 Thread Vipin Varghese
The patch series enhances application to support pdump capture to run on unique cores. Motivation == DPDK pdump capture tool currently runs as secondary on the default core 0. For all --pdump, core 0 iterates and capture packets. This leads to drops and delay in the capture. This introduc

[dpdk-dev] [PATCH v6 1/2] app/pdump: remove core restriction

2019-04-04 Thread Vipin Varghese
PDUMP application is being limited to run on default first core. The patch removes the restriction, allowing user to run on any of selected cores in EAL args. If no args are passed, logic runs on default master core. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 14 ++ 1 file

[dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture

2019-04-04 Thread Vipin Varghese
Add option --multi, to enhance pdump application to allow capture on unique cores for each --pdump option. If option --multi is ignored the default capture occurs on single core for all --pdump options. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 99 +++

[dpdk-dev] [PATCH v11 0/1] Introduce AF_XDP PMD

2019-04-04 Thread Xiaolong Ye
Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support i

[dpdk-dev] [PATCH v11 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-04 Thread Ori Kam
Hi Adrien, PSB > -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 3, 2019 3:49 PM > To: Dekel Peled > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; Shahaf > Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH v2 1/

[dpdk-dev] [PATCH v6] net/nfb: new netcope driver

2019-04-04 Thread Rastislav Cernay
From: Rastislav Cernay Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay --- v2: remove unnecessary cast remove unnecessary zeroing move declaration to not mix with code restore skeleton example v3: add release notes add doc to doc index add architec

Re: [dpdk-dev] DPDK ABI/API Stability

2019-04-04 Thread Burakov, Anatoly
On 03-Apr-19 4:42 PM, Ray Kinsella wrote: Hi folks, Recently I started a discussion with the DPDK Technical Board on DPDK ABI/API stability. This was born out informal feedback I had received from a number of users of DPDK about ABI churn. In turn this feedback then prompted an ABI analysis of D

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support creation of no IOVA contig mempools

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 6:14 AM, Shahaf Shuler wrote: providing a command line parameter to set the mempool flags accordingly. This mode is relevant only when creating an empty mempool and then populating with memory. Signed-off-by: Shahaf Shuler --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: map anonymous memory for eth devices

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 6:14 AM, Shahaf Shuler wrote: Mempools can be populated with anonymous memory when using command line parameter --mp-alloc=anon. Considering the mempools are going to be used by the net devices, it is better to DMA map this memory. This patch add such mapping now that we have the A

Re: [dpdk-dev] DPDK ABI/API Stability

2019-04-04 Thread Kevin Traynor
On 03/04/2019 16:42, Ray Kinsella wrote: > Hi folks, > > Recently I started a discussion with the DPDK Technical Board on DPDK > ABI/API stability. This was born out informal feedback I had received > from a number of users of DPDK about ABI churn. In turn this feedback > then prompted an ABI anal

[dpdk-dev] [PATCH v4 0/3] net/mlx5: Add Direct Rule support

2019-04-04 Thread Ori Kam
This patch set adds support for Direct Rules API for MLX5 driver. As more and more applications like OVS are inserting and removing large number of flows, the flow insertion rate become more critical. In current MLX5 PMD rules are inserted to the device using the FW, this limits the max insertion

[dpdk-dev] [PATCH v4 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

2019-04-04 Thread Ori Kam
This is the first patch of a series that is designed to enable the Direct Rules API. The main difference between Direct Verbs and Direct Rules from API prespective, is that in Direct Rules each action has it's own create function and the object itself is of type void. In this patch I'm adding fun

[dpdk-dev] [PATCH v4 3/3] net/mlx5: add jump action support for NIC

2019-04-04 Thread Ori Kam
When using Direct Rules we can add actions to jump between tables. This is extra useful since rule insertion rate is much higher on other tables compared to table zero. if no group is selected the rule is added to group 0. Signed-off-by: Ori Kam Acked-by: Shahaf Shuler --- v4: * Fix compilation

[dpdk-dev] [PATCH v4 2/3] net/mlx5: add Direct Rules API

2019-04-04 Thread Ori Kam
Adds calls to the Direct Rules API inside the glue functions. Due to difference in parameters between the Direct Rules and Direct Verbs some of the glue functions API was updated. Signed-off-by: Ori Kam Acked-by: Shahaf Shuler --- drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.

Re: [dpdk-dev] [PATCH v2] kni: add IOVA va support for kni

2019-04-04 Thread Burakov, Anatoly
On 03-Apr-19 5:29 PM, Ferruh Yigit wrote: On 4/1/2019 10:51 AM, Kiran Kumar Kokkilagadda wrote: From: Kiran Kumar K With current KNI implementation kernel module will work only in IOVA=PA mode. This patch will add support for kernel module to work with IOVA=VA mode. Thanks Kiran for removing

[dpdk-dev] [PATCH v10 0/8] Add stack library and new mempool handler

2019-04-04 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v10 1/8] stack: introduce rte stack library

2019-04-04 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v10 2/8] mempool/stack: convert mempool to use rte stack

2019-04-04 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v10 3/8] test/stack: add stack test

2019-04-04 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 +

[dpdk-dev] [PATCH v10 5/8] stack: add lock-free stack implementation

2019-04-04 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v10 4/8] test/stack: add stack perf test

2019-04-04 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v10 6/8] stack: add C11 atomic implementation

2019-04-04 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli --- lib/librte_sta

[dpdk-dev] [PATCH v10 7/8] test/stack: add lock-free stack tests

2019-04-04 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v10 8/8] mempool/stack: add lock-free stack mempool handler

2019-04-04 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

Re: [dpdk-dev] [PATCH 2/3] net/virtio: fix null pointer checking

2019-04-04 Thread Mohammad Abdul Awal
On 04/04/2019 07:22, Tiwei Bie wrote: On Wed, Apr 03, 2019 at 05:08:11PM +0100, Mohammad Abdul Awal wrote: Null value of device name should return error without further processing. Fixes: 1c8489da56 ("net/virtio-user: fix multi-process support") Signed-off-by: Mohammad Abdul Awal --- driv

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Bruce Richardson
On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > On 03-Apr-19 4:42 PM, Ray Kinsella wrote: > > Hi folks, > > > > Recently I started a discussion with the DPDK Technical Board on DPDK > > ABI/API stability. This was born out informal feedback I had received > > from a number of u

[dpdk-dev] [PATCH] doc/crypto: add supported asymmetric crypto algorithms to qat

2019-04-04 Thread Arek Kusztal
This patch adds missing asymmetric crypto algorithms in documentation files of Intel QuickAssist Technology driver. Signed-off-by: Arek Kusztal --- This patch depends on "doc/crypto: fix missing asymmetric algo table" (http://patchwork.dpdk.org/patch/52168/) doc/guides/cryptodevs/features/qat.i

Re: [dpdk-dev] [PATCH v4 0/3] net/mlx5: Add Direct Rule support

2019-04-04 Thread Shahaf Shuler
Thursday, April 4, 2019 12:54 PM, Ori Kam: > Subject: [PATCH v4 0/3] net/mlx5: Add Direct Rule support > > This patch set adds support for Direct Rules API for MLX5 driver. > > As more and more applications like OVS are inserting and removing large > number of flows, the flow insertion rate becom

[dpdk-dev] [PATCH v2 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Hemant Agrawal
The current value is 10, which is not sufficient for many use-cases. e.g. NXP LX2 with raw qdma devices can use 32-48 raw devices in some use-cases. So, making it to 64 to cover various cases. Signed-off-by: Hemant Agrawal --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[dpdk-dev] [PATCH v2 2/7] raw/dpaa2_qdma: remove experimental tag from APIs

2019-04-04 Thread Hemant Agrawal
These APIs has been in the DPDK for few release now. This patch removes the experimental tags for the APIs. Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 20 ++--- drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 28 +-- .../dpaa2_qdma/r

[dpdk-dev] [PATCH v2 7/7] raw/dpaa2_qdma: add support for non prefetch mode

2019-04-04 Thread Hemant Agrawal
This patch add support for non prefetch mode in Rx functions. Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/Makefile | 1 + drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 215 +++- drivers/raw/dpaa2_qdma/meson.build | 2 +- 3 files changed, 212 insertions(+), 6

[dpdk-dev] [PATCH v2 4/7] raw/dpaa2_qdma: add burst mode support

2019-04-04 Thread Hemant Agrawal
This patch adds support the batch processing for the qdma jobs Signed-off-by: Hemant Agrawal Signed-off-by: Yi Liu --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 305 ++-- drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 6 +- 2 files changed, 164 insertions(+), 147 deletions(

[dpdk-dev] [PATCH v2 6/7] raw/dpaa2x: remove rte logs from data path

2019-04-04 Thread Hemant Agrawal
From: Nipun Gupta The runtime traces shall not be present in datapath Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 4 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 8 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 2 +- 3 files changed, 1 insertion(

[dpdk-dev] [PATCH v2 3/7] raw/dpaa2_qdma: fix to support multiprocess execution

2019-04-04 Thread Hemant Agrawal
From: Shreyansh Jain Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") Cc: nipun.gu...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v2 5/7] raw/dpaa2_qdma: add rbp mode support

2019-04-04 Thread Hemant Agrawal
Add support for route by port mode. The route by port feature in HW helps in translating the PCI address of connected device. Signed-off-by: Minghuan Lian Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/Makefile | 2 +- drivers/raw/dpaa2_qdma

Re: [dpdk-dev] [PATCH v2 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Thursday, April 4, 2019 12:04 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Shreyansh Jain > Subject: [dpdk-dev] [PATCH v2 1/7] config: increase the num of rawdev to > be 64 > > The cu

Re: [dpdk-dev] mlx5 FDIR rule comparison issue

2019-04-04 Thread Dekel Peled
Hi Daniel, The flow_director API will be deprecated in the near future. It was replaced by rte_flow API, which contains much more features, and is fully supported by Mellanox. It is recommended that you use rte_flow API in your application. Regards, Dekel > -Original Message- > From: b

Re: [dpdk-dev] [EXT] Re: [PATCH v2] kni: add IOVA va support for kni

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 6:03 AM, Kiran Kumar Kokkilagadda wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, April 3, 2019 9:59 PM >> To: Kiran Kumar Kokkilagadda >> Cc: dev@dpdk.org; Jerin Jacob >> Subject: [EXT] Re: [dpdk-dev] [PATCH v2] kni: add IOVA va support for kni >

Re: [dpdk-dev] [PATCH v2] kni: add IOVA va support for kni

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 10:57 AM, Burakov, Anatoly wrote: > On 03-Apr-19 5:29 PM, Ferruh Yigit wrote: >> On 4/1/2019 10:51 AM, Kiran Kumar Kokkilagadda wrote: >>> From: Kiran Kumar K >>> >>> With current KNI implementation kernel module will work only in >>> IOVA=PA mode. This patch will add support for kerne

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators

2019-04-04 Thread Ferruh Yigit
On 4/3/2019 7:07 PM, Yongseok Koh wrote: > >> On Apr 3, 2019, at 7:19 AM, Ferruh Yigit wrote: >> >> On 4/1/2019 3:26 AM, Thomas Monjalon wrote: >>> Iterating over siblings was done with RTE_ETH_FOREACH_DEV() >>> which skips the owned ports. >>> The new iterators RTE_ETH_FOREACH_DEV_SIBLING() >>>

[dpdk-dev] [PATCH] devargs: remove experimental from APIs

2019-04-04 Thread Hemant Agrawal
These APIs are available in DPDK for last 4 releases and used by multiple drivers. Cc: gaetan.ri...@6wind.com Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/eal_common_devargs.c | 10 ++ lib/librte_eal/common/include/rte_devargs.h | 6 -- lib/librte_eal/rte_eal_version.ma

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Ferruh Yigit
On 4/3/2019 8:44 PM, Gage Eads wrote: > This operation can be used for non-blocking algorithms, such as a > non-blocking stack or ring. > > It is available only for x86_64. > > Signed-off-by: Gage Eads > Reviewed-by: Honnappa Nagarahalli > --- > This patch addresses x86-64 only; other architect

[dpdk-dev] [PATCH v3 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Hemant Agrawal
The current value is 10, which is not sufficient for many use-cases. e.g. NXP LX2 with raw qdma devices can use 32-48 raw devices in some use-cases. So, making it to 64 to cover various cases. Signed-off-by: Hemant Agrawal --- config/common_base | 2 +- config/rte_config.h | 2 +- 2 files chang

[dpdk-dev] [PATCH v3 2/7] raw/dpaa2_qdma: remove experimental tag from APIs

2019-04-04 Thread Hemant Agrawal
These APIs has been in the DPDK for few release now. This patch removes the experimental tags for the APIs. Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 20 ++--- drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 28 +-- .../dpaa2_qdma/r

[dpdk-dev] [PATCH v3 3/7] raw/dpaa2_qdma: fix to support multiprocess execution

2019-04-04 Thread Hemant Agrawal
From: Shreyansh Jain Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") Cc: nipun.gu...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v3 4/7] raw/dpaa2_qdma: add burst mode support

2019-04-04 Thread Hemant Agrawal
This patch adds support the batch processing for the qdma jobs Signed-off-by: Hemant Agrawal Signed-off-by: Yi Liu --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 305 ++-- drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 6 +- 2 files changed, 164 insertions(+), 147 deletions(

[dpdk-dev] [PATCH v3 5/7] raw/dpaa2_qdma: add rbp mode support

2019-04-04 Thread Hemant Agrawal
Add support for route by port mode. The route by port feature in HW helps in translating the PCI address of connected device. Signed-off-by: Minghuan Lian Signed-off-by: Sachin Saxena Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/Makefile | 2 +- drivers/raw/dpaa2_qdma

[dpdk-dev] [PATCH v3 6/7] raw/dpaa2x: remove rte logs from data path

2019-04-04 Thread Hemant Agrawal
From: Nipun Gupta The runtime traces shall not be present in datapath Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 4 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 8 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 2 +- 3 files changed, 1 insertion(

[dpdk-dev] [PATCH v3 7/7] raw/dpaa2_qdma: add support for non prefetch mode

2019-04-04 Thread Hemant Agrawal
This patch add support for non prefetch mode in Rx functions. Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/Makefile | 1 + drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 215 +++- drivers/raw/dpaa2_qdma/meson.build | 2 +- 3 files changed, 212 insertions(+), 6

Re: [dpdk-dev] [PATCH v2 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Hemant Agrawal
On 04-Apr-19 4:37 PM, Richardson, Bruce wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal >> Sent: Thursday, April 4, 2019 12:04 PM >> To: dev@dpdk.org >> Cc: tho...@monjalon.net; Shreyansh Jain >> Subject: [dpdk-dev] [PATCH v2 1/7] conf

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-04 Thread Hemant Agrawal
ping On 03-Jan-19 5:00 PM, Shreyansh Jain wrote: > Traditionally, only a single buffer pool per port > (or, per-port-per-socket) is created in l3fwd application. > > If separate pools are created per-port, it might lead to gain in > performance as packet alloc/dealloc requests would be isolated >

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Luca Boccassi
On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: > On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > > On 03-Apr-19 4:42 PM, Ray Kinsella wrote: > > > Hi folks, > > > > > > Recently I started a discussion with the DPDK Technical Board on > > > DPDK > > > ABI/API stabili

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Thomas Monjalon
04/04/2019 13:47, Ferruh Yigit: > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: error: ISO > C > does not support ‘__int128’ types [-Werror=pedantic] We can try this kind of workaround (disable pedantic locally): https://github.com/HowardHinnant/date/pull/38/commits/177032852

Re: [dpdk-dev] mlx5 FDIR rule comparison issue

2019-04-04 Thread benli ye
Thanks Dekel for your information. I will have a try. Bests, Daniel > On Apr 4, 2019, at 7:18 PM, Dekel Peled wrote: > > Hi Daniel, > > The flow_director API will be deprecated in the near future. > It was replaced by rte_flow API, which contains much more features, and is > fully supported b

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Thomas Monjalon
04/04/2019 14:08, Thomas Monjalon: > 04/04/2019 13:47, Ferruh Yigit: > > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: error: > > ISO C > > does not support ‘__int128’ types [-Werror=pedantic] > > We can try this kind of workaround (disable pedantic locally): > https://github

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix SPD no-match is misinterpreted

2019-04-04 Thread Konstantin Ananyev
acl_classify() returns zero value when no matching rule was found. Currently ipsec-secgw treats it as a valid SPI value, though it has to discard such packets. Error could be easily observed by sending outbound unmatched packets, user will see something like that in the log: IPSEC: No cryptodev: co

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 4, 2019 7:13 AM > To: Yigit, Ferruh ; Eads, Gage > > Cc: Shahaf Shuler ; Matan Azrad > ; Yongseok Koh ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SPD no-match is misinterpreted

2019-04-04 Thread Ananyev, Konstantin
Hi Akhil, > > > > acl_classify() returns zero value when no matching rule was found. > > > > Currently ipsec-secgw treats it as a valid SPI value, though it has > > > > to discard such packets. > > > > Error could be easily observed by sending outbound unmatched packets, > > > > user will see som

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Thomas Monjalon
04/04/2019 14:14, Eads, Gage: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 04/04/2019 14:08, Thomas Monjalon: > > > 04/04/2019 13:47, Ferruh Yigit: > > > > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: > > > > error: ISO C does not support ‘__int128’ types [-Werror=

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 4, 2019 7:18 AM > To: Eads, Gage ; Yigit, Ferruh > > Cc: Shahaf Shuler ; Matan Azrad > ; Yongseok Koh ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ;

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Eads, Gage > Sent: Thursday, April 4, 2019 7:23 AM > To: 'Thomas Monjalon' ; Yigit, Ferruh > > Cc: Shahaf Shuler ; Matan Azrad > ; Yongseok Koh ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ;

[dpdk-dev] [PATCH] ring: fix namesize macro documentation block

2019-04-04 Thread Gage Eads
'/**<' style comments apply to the previous member, which caused doxygen to emit the RTE_RING_NAMESIZE documentation for RTE_RING_MZ_PREFIX. Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") Cc: sta...@dpdk.org Signed-off-by: Gage Eads --- lib/librte_ring/rte_ring.h | 2 +-

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 1:18 PM, Thomas Monjalon wrote: > 04/04/2019 14:14, Eads, Gage: >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >>> 04/04/2019 14:08, Thomas Monjalon: 04/04/2019 13:47, Ferruh Yigit: > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: > error: ISO C d

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Ray Kinsella
On 04/04/2019 11:54, Bruce Richardson wrote: > On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: >> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: >>> Hi folks, >>> [SNIP] >> >> Hi Ray, >> >> My somewhat rambly 2 cents :) >> >> While i think some solution has to be found for the situa

[dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Thomas Monjalon
When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG, the compiler complains about non standard 128-bit integer type: include/rte_atomic_64.h:223:3: error: ISO C does not support ‘__int128’ types [-Werror=pedantic] It must be marked as an extension of the standard C language to be

Re: [dpdk-dev] [PATCH v3 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Bruce Richardson
On Thu, Apr 04, 2019 at 11:50:18AM +, Hemant Agrawal wrote: > The current value is 10, which is not sufficient for many use-cases. > e.g. NXP LX2 with raw qdma devices can use 32-48 raw devices in some > use-cases. So, making it to 64 to cover various cases. > > Signed-off-by: Hemant Agrawal

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Ray Kinsella
On 04/04/2019 13:02, Luca Boccassi wrote: > On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: >> On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: >>> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: [SNIP] >>> >> >> Actually, I think we *do* need to constrain the pace of devel

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add Direct Rules flow data alloc/free routines

2019-04-04 Thread Viacheslav Ovsiienko
We are going to share the Direct Rules and Direct Verbs flow device data structures between master and representors in the E-Switch configurations over multiport IB device. The code of initializing and destroying these data is moved to dedicated routines, this is just a preparation step for actual

[dpdk-dev] [PATCH v2 0/2] support Direct Rules flows over shared IB context

2019-04-04 Thread Viacheslav Ovsiienko
The Direct Rules/Direct Verbs flows support is going to be added [1]. The master/representor over multiport IB device is added [2]. This patchset adds support for DR/DV flows with shared IB context over multiport IB device. The DV/DR flows applied to the master/representors on the same IB device s

[dpdk-dev] [PATCH v2 2/2] net/mlx5: share Direct Rules/Verbs flow related structures

2019-04-04 Thread Viacheslav Ovsiienko
Direct Rules/Verbs related structures are moved to the shared context: - rx/tx namespaces, shared by master and representors - rx/tx flow tables - matchers - encap/decap action resources - flow tags (MARK actions) - modify action resources - jump tables Signed-off-by: Viacheslav Ovsi

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Bruce Richardson
On Thu, Apr 04, 2019 at 02:05:27PM +0100, Ray Kinsella wrote: > > > On 04/04/2019 13:02, Luca Boccassi wrote: > > On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: > >> On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > >>> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: > [SN

Re: [dpdk-dev] DPDK ABI/API Stability

2019-04-04 Thread Ray Kinsella
On 04/04/2019 10:47, Kevin Traynor wrote: > On 03/04/2019 16:42, Ray Kinsella wrote: >> Hi folks, >> [SNIP] >> >> The DPDK ABI churn has the following affects for users:- >> >> 1. The churn obliges users of DPDK to commit to a constant >> re-integration and re-validation effort for new versions

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Luca Boccassi
On Thu, 2019-04-04 at 14:05 +0100, Ray Kinsella wrote: > > > Question for Kevin, Luca and others who look at distro-packaging: > > > is > > > it the > > > case that each distro will only ship one version of DPDK, or is > > > it > > > possible > > > that if we have ABI breaks, a distro will provide

Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Thomas Monjalon
04/04/2019 15:00, Thomas Monjalon: > When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG, > the compiler complains about non standard 128-bit integer type: > > include/rte_atomic_64.h:223:3: error: > ISO C does not support ‘__int128’ types [-Werror=pedantic] > > It must be marked

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-04 Thread Adrien Mazarguil
Hi Ori, (trimming message down a bit) On Thu, Apr 04, 2019 at 09:01:52AM +, Ori Kam wrote: > Hi Adrien, > > PSB > > > From: Adrien Mazarguil > > On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote: > > > Thanks, PSB. > > > > From: Adrien Mazarguil > > > > I still don't agree w

[dpdk-dev] [PATCH v3 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-04-04 Thread Bernard Iremonger
This patchset fixes the issue of the first inbound packet being dropped for inline crypto. Changes in v3: -- The previous refactoring of the create_session() function has been dropped. The create_session() function is now called from sa_init() at startup. The following functions hav

[dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

2019-04-04 Thread Bernard Iremonger
Inline crypto installs a flow rule in the NIC. This flow rule must be installed before the first inbound packet is received. The create_session() function installs the flow rule. Refactor ipsec-secgw.c, sa.c, ipsec.h and ipsec.c to create sessions at startup to fix the issue of the first packet b

[dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw/test: fix inline test scripts

2019-04-04 Thread Bernard Iremonger
Remove workaround in tun_aesgcm_defs.sh and trs_aesgcm_defs.sh to get around the bug where the first inbound packet is dropped for inline crypto. Fixes: 929784452094 ("examples/ipsec-secgw: add scripts for functional test") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec

Re: [dpdk-dev] [EXT] Re: [PATCH v2] kni: add IOVA va support for kni

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 12:20 PM, Ferruh Yigit wrote: On 4/4/2019 6:03 AM, Kiran Kumar Kokkilagadda wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, April 3, 2019 9:59 PM To: Kiran Kumar Kokkilagadda Cc: dev@dpdk.org; Jerin Jacob Subject: [EXT] Re: [dpdk-dev] [PATCH v2] kni: add

Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library

2019-04-04 Thread Thomas Monjalon
04/04/2019 01:20, Gage Eads: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -87,6 +87,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY) += > -lrte_security > _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV)+= -lrte_compressdev > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += -lrte_eventdev > _LDLI

Re: [dpdk-dev] [PATCH v2] test/ipsec: fix test initialisation

2019-04-04 Thread Iremonger, Bernard
Hi Akhil, > On 3/22/2019 7:17 PM, Bernard Iremonger wrote: > > Fix xform initialisation. > > Fix testsuite_setup. > > Loop on rte_cryptodev_dequeue_burst() calls. > > Remove unused variables. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Fixes: 59d7353b0df0 ("test/ip

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 1:52 PM, Ray Kinsella wrote: On 04/04/2019 11:54, Bruce Richardson wrote: On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: On 03-Apr-19 4:42 PM, Ray Kinsella wrote: Hi folks, [SNIP] Hi Ray, My somewhat rambly 2 cents :) While i think some solution has to b

Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 4, 2019 8:30 AM > To: Eads, Gage > Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha..

Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Eads, Gage
> 04/04/2019 15:00, Thomas Monjalon: > > When enabling pedantic compilation with > CONFIG_RTE_LIBRTE_MLX5_DEBUG, > > the compiler complains about non standard 128-bit integer type: > > > > include/rte_atomic_64.h:223:3: error: > > ISO C does not support ‘__int128’ types [-Werror=pedantic] > > > >

[dpdk-dev] [PATCH v3] app/test/ipsec: fix test initialisation

2019-04-04 Thread Bernard Iremonger
Fix xform initialisation. Fix testsuite_setup. Remove unused variables. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Signed-off-by: Bernard Iremonger --- Changes in v3: drop changes to logic around rte_cryptodev_dequeue_bu

  1   2   >