> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, April 4, 2019 8:30 AM
> To: Eads, Gage <gage.e...@intel.com>
> Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com;
> Richardson, Bruce <bruce.richard...@intel.com>; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; gavin...@arm.com;
> honnappa.nagaraha...@arm.com; n...@arm.com
> Subject: Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library
>
> 04/04/2019 01:20, Gage Eads:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -87,6 +87,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY) += -
> lrte_security
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += -lrte_compressdev
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += -lrte_eventdev
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV) += -lrte_rawdev
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) += -lrte_stack
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool
> > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -
> lrte_mempool_ring
>
> Stack library is used by mempool, so it should appear after mempool in the
> library list.
> It is the same as ring lib being after mempool_ring.
>
> If you agree, please just tell me without sending a new version, because I'm
> doing other minor changes (sorting stack near ring in many files).
>
Agreed. I suspect we haven't seen any linker problems because it's in a
--whole-archive section (line 72), but better to put these in the correct
dependency order.
