[dpdk-dev] [PATCH] net/mlx5: fix packet inline on Tx queue wraparound

2019-03-10 Thread Shahaf Shuler
Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE starts on the end of the ring and ends on the beginning, is not supported and blocked by the data path logic. However, in case of TSO, an extra inline header is required before inlining. This inline header is not taken into accoun

[dpdk-dev] [PATCH v4 0/6] introduce DMA memory mapping for external memory

2019-03-10 Thread Shahaf Shuler
The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in the DPDK memory system (memseg lists) and automatically DMA mapped by the DPDK layers. 2. Use

[dpdk-dev] [PATCH v4 1/6] vfio: allow DMA map of memory for the default vfio fd

2019-03-10 Thread Shahaf Shuler
Enable users the option to call rte_vfio_dma_map with request to map to the default vfio fd. Signed-off-by: Shahaf Shuler Acked-by: Anatoly Burakov --- doc/guides/rel_notes/release_19_05.rst | 3 +++ lib/librte_eal/common/include/rte_vfio.h | 8 ++-- lib/librte_eal/linuxapp/eal/eal_vfio

[dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping

2019-03-10 Thread Shahaf Shuler
The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in the DPDK memory system (memseg lists) and automatically DMA mapped by the DPDK layers. 2. Use

[dpdk-dev] [PATCH v4 2/6] vfio: don't fail to DMA map if memory is already mapped

2019-03-10 Thread Shahaf Shuler
Currently vfio DMA map function will fail in case the same memory segment is mapped twice. This is too strict, as this is not an error to map the same memory twice. Instead, use the kernel return value to detect such state and have the DMA function to return as successful. For type1 mapping the

[dpdk-dev] [PATCH v4 4/6] net/mlx5: refactor external memory registration

2019-03-10 Thread Shahaf Shuler
Move the memory region creation to a separate function to prepare the ground for the reuse of it on the PCI driver map and unmap functions. Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_mr.c | 86 +++-- 1 file changed, 57 insertions(+), 29 deletions(-

[dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-03-10 Thread Shahaf Shuler
As those should be replaced by rte_dev_dma_map and rte_dev_dma_unmap APIs. Signed-off-by: Shahaf Shuler --- doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- doc/guides/rel_notes/deprecation.rst| 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/p

[dpdk-dev] [PATCH v4 5/6] net/mlx5: support PCI device DMA map and unmap

2019-03-10 Thread Shahaf Shuler
The implementation reuses the external memory registration work done by commit[1]. Note about representors: The current representor design will not work with those map and unmap functions. The reason is that for representors we have multiple IB devices share the same PCI function, so mapping will

Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor recognition on kernels 5.x

2019-03-10 Thread Shahaf Shuler
Thursday, March 7, 2019 1:12 PM, Slava Ovsiienko: > Subject: RE: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor > recognition on kernels 5.x > > Monday, February 25, 2019 1:01 PM, Viacheslav Ovsiienko: > > > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: add representor > > > recognition on kern

Re: [dpdk-dev] [PATCH 1/1] net/nfp: fix set_mac_addr

2019-03-10 Thread Alejandro Lucero
On Fri, Mar 8, 2019 at 3:41 PM Pablo Cascón wrote: > Some firmwares, mostly for VFs, do not advertise the feature / > capability of changing the MAC address while the interface is up. With > such firmware a request to change the MAC address that at the same > time also tries to enable the not ava

Re: [dpdk-dev] [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-10 Thread Liron Himi
Adding Alan. -Original Message- From: Liron Himi Sent: Monday, February 25, 2019 13:30 To: ferruh.yi...@intel.com Cc: dev@dpdk.org; Liron Himi ; Liron Himi Subject: RE: [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool Hi, Kind reminder Regards, Liron -Original Messag

Re: [dpdk-dev] [PATCH v2] net/mlx5: support new representors' naming format

2019-03-10 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Shahaf Shuler > Sent: Thursday, March 7, 2019 10:58 AM > To: Dekel Peled ; Yongseok Koh > > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: support new representors' > naming format > > Sunday, March 3, 2

[dpdk-dev] [PATCH v3] net/mlx5: support new representor naming format

2019-03-10 Thread Dekel Peled
Kernel update [1] introduce new format of representors names. This patch implements RFC [2], updating MLX5 PMD to support the new format, while maintaining support of the existing format. [1] https://github.com/torvalds/linux/commit/c12ecc2 [2] http://mails.dpdk.org/archives/dev/2019-March/125676.

[dpdk-dev] [PATCH v4] net/mlx5: support new representor naming format

2019-03-10 Thread Dekel Peled
Kernel update [1] introduce new format of representors names. This patch implements RFC [2], updating MLX5 PMD to support the new format, while maintaining support of the existing format. [1] https://github.com/torvalds/linux/commit/c12ecc2 [2] http://mails.dpdk.org/archives/dev/2019-March/125676.

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-10 Thread Honnappa Nagarahalli
> > > > > > >>> In weak memory models, like arm64, reading the > > > > > > >>> {prod,cons}.tail may get reordered after reading or > > > > > > >>> writing the ring slots, which corrupts the ring and stale data > > > > > > >>> is > observed. > > > > > > >>> > > > > > > >>> This issue was reported b

Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

2019-03-10 Thread Zhao1, Wei
Hi, > -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Friday, March 8, 2019 8:39 PM > To: Zhao1, Wei ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef >

Re: [dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding

2019-03-10 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, March 6, 2019 12:31 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Kevin Traynor ; Yan, Zhirun > > Subject: [RFC 2/2] net/i40e: update requested queue pair num check for > rounding > > Since rounding

Re: [dpdk-dev] [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver

2019-03-10 Thread Xu, Rosen
Hi, > -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Sunday, March 10, 2019 3:34 > To: Xu, Rosen ; dev@dpdk.org > Cc: Yigit, Ferruh ; Zhang, Tianfei > ; Wei, Dan ; Pei, Andy > ; Yang, Qiming ; Wang, > Haiyue ; Chen, Santos ; > Zhang, Zhang > Subject: Re: [dpdk-

[dpdk-dev] [PATCH v1] doc: update cross build tool links

2019-03-10 Thread Joyce Kong
Update cross build tool links as newer cross build tools version are provided on Linaro, and attempts to download the old one give permission denied. Fixes: 01add9da25cd ("doc: add cross compiling guide") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong --- doc/guides/linux_gsg/cross_build_dpdk_fo

Re: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX

2019-03-10 Thread Zhang, Qi Z
Hi: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Monday, March 4, 2019 2:53 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v2 3/8] net/ice: support vector SSE in RX > > Signed-off-by: Wenzhuo Lu > --- . > + >

[dpdk-dev] [PATCH v5 0/2] ticketlock: implement ticketlock and add test case

2019-03-10 Thread Joyce Kong
v5: Change the variants inside rte_ticket_lock from unint to uint16_t for binary compatibility with the plain spin lock. v4: Change some assignment operation in recursive ticket lock to __atomic. V3: 1.Update ticketlock intrduction(suggested by Honnappa Nagarahalli). 2.Change

[dpdk-dev] [PATCH v5 1/2] eal/ticketlock: ticket based to improve fairness

2019-03-10 Thread Joyce Kong
The spinlock implementation is unfair, some threads may take locks aggressively while leaving the other threads starving for long time. This patch introduces ticketlock which gives each waiting thread a ticket and they can take the lock one by one. First come, first serviced. This avoids starvatio

[dpdk-dev] [PATCH v5 2/2] test/ticketlock: add ticket lock test case

2019-03-10 Thread Joyce Kong
Add test cases for ticket lock, recursive ticket lock, and ticket lock performance. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 1 + app/test/test_ticketlock.c

[dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-10 Thread Anoob Joseph
The string compare to the length of driver name might give false positives when there are drivers with similar names (one being the subset of another). Following is such a naming which could result in false positive. 1. crypto_driver 2. crypto_driver1 When strncmp with len = strlen("crypto_driver

[dpdk-dev] [PATCH v2] app/eventdev: configure optimum timers per adapter

2019-03-10 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Previously, the total number of event timers per adapter was set to an arbitrary value, set it to mempool size instead as it defines the max event timers that can be armed. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_perf_common.c | 2

Re: [dpdk-dev] [PATCH] event/opdl: fix sprintf with snprintf

2019-03-10 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-02-04 at 07:18 +, Pallantla Poornima wrote: > sprintf function is not secure as it doesn't check the length of > string. > More secure function snprintf is used. > > Fixes: 3c7f3dcfb0 ("event/opdl: add PMD main body and helper > function") > Cc: sta...@dpdk.org > > Signed-off-by: