Re: [dpdk-dev] [PATCH v2 0/6] HelloWorld example for windows

2019-03-06 Thread Thomas Monjalon
Hi, 06/03/2019 05:16, Anand Rawat: > v2 Changes: > Incorporated reviews from v1. > Fixed license period for updated files. > Renamed 'winapp' folder to 'windows'. > Cleaned unneeded meson changes. > Fixed code style warnings. > Added maintainers information for windows branch About the method, t

Re: [dpdk-dev] [PATCH 6/6] doc: add documention for windows

2019-03-06 Thread Thomas Monjalon
02/03/2019 03:41, Ranjit Menon: > On 3/1/2019 11:02 AM, Stephen Hemminger wrote: > > On Thu, 28 Feb 2019 23:18:47 -0800 > > Anand Rawat wrote: > > > >> Add documentation to build helloworld example > >> on windows using meson and clang. > >> > >> Signed-off-by: Anand Rawat > >> Signed-off-by: Ka

[dpdk-dev] [PATCH] app/test: enhance meson test run for FreeBSD and Linux

2019-03-06 Thread Agalya Babu RadhaKrishnan
From: Agalya Babu RadhaKrishnan 1)For linux, running all tests on same cores can increase failure rate. So instead run each test case on separate lcore using -l EAL option. Lcore for each test case will be selected in the incremental order of 0,1,2 ... till it reaches the maximum available cores

Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

2019-03-06 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, March 5, 2019 2:41 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; Ananyev, > Konstantin ; > sta...@dpdk.org > Subject: [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode > > This patch fixes the inc

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-06 Thread Gaëtan Rivet
On Tue, Mar 05, 2019 at 06:58:04PM +0100, Thomas Monjalon wrote: > Hi, > > 05/03/2019 18:38, Gaëtan Rivet: > > > fs_dev_remove(struct sub_device *sdev) > [...] > > > - rte_eth_dev_close(PORT_ID(sdev)); > > > + rte_eth_dev_close(edev->data->port_id); > > > > Ok I see. I missed tha

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Thomas Monjalon
Hi, 06/03/2019 05:16, Anand Rawat: > -# some libs depend on maths lib > -add_project_link_arguments('-lm', language: 'c') > -dpdk_extra_ldflags += '-lm' > +if cc.find_library('lm', required : false).found() > + # some libs depend on maths lib > + add_project_link_arguments('-lm', language:

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Bruce Richardson
On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > Hi, > > 06/03/2019 05:16, Anand Rawat: > > -# some libs depend on maths lib > > -add_project_link_arguments('-lm', language: 'c') > > -dpdk_extra_ldflags += '-lm' > > +if cc.find_library('lm', required : false).found() > > + # so

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-06 Thread Thomas Monjalon
06/03/2019 05:16, Anand Rawat: > Added header files to support windows on x86 platforms. > Updated rte_config to include rte_windows.h for windows > build. [...] > --- a/config/rte_config.h > +++ b/config/rte_config.h > +/* windows specific*/ > +#ifdef RTE_EXEC_ENV_WINDOWS > +#include > +#endif I

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Thomas Monjalon
06/03/2019 12:20, Bruce Richardson: > On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > > Hi, > > > > 06/03/2019 05:16, Anand Rawat: > > > -# some libs depend on maths lib > > > -add_project_link_arguments('-lm', language: 'c') > > > -dpdk_extra_ldflags += '-lm' > > > +if cc.find_

Re: [dpdk-dev] [v1] ring: enforce reading the tails before ring operations

2019-03-06 Thread Ilya Maximets
On 06.03.2019 6:07, gavin hu wrote: > In weak memory models, like arm64, reading the {prod,cons}.tail may get > reordered after reading or writing the ring slots, which corrupts the ring > and stale data is observed. > This issue was reported by NXP on 8-A72 DPAA2 board. The problem is most > likel

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, March 6, 2019 11:36 AM > To: Richardson, Bruce > Cc: dev@dpdk.org; Rawat, Anand ; Kadam, Pallavi > ; Menon, Ranjit ; Shaw, > Jeffrey B > Subject: Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to

Re: [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup

2019-03-06 Thread Igor Russkikh
On 04.03.2019 12:40, David Marchand wrote: > Those patches are missing Fixes: tags and copying stable where appropriate. > The commitlogs also need some work. > > It looks like those patches were neither checked against checkpatch nor > check-git-log.sh. > Here is what I see (extended the max l

Re: [dpdk-dev] [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add OPAE share code for IPN3KE

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add OPAE share code for Intel FPGA Acceleration NIC IPN3KE. What do you think adding a file to record the version of the shared code, as it is done in Intel NIC drivers, README file? Also can you please add more details on what feautures has been added with

Re: [dpdk-dev] [PATCH v1 04/11] drivers/raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev. > > Signed-off-by: Rosen Xu > Signed-off-by: Tianfei Zhang > Signed-off-by: Andy Pei <...> > +static int > +ifgpa_rawdev_get_attr(struct rte_rawdev *dev, > + const char *at

Re: [dpdk-dev] [PATCH v1 02/11] drivers/bus/ifpga: add function for AFU search by name

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:13 AM, Rosen Xu wrote: > In many scenarios, AFU is needed searched by name, this > function add the feature. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > --- > drivers/bus/ifpga/ifpga_bus.c | 13 + > drivers/bus/ifpga/rte_bus_ifpga.h | 3 +++ > 2 files

Re: [dpdk-dev] [PATCH v1 10/11] doc: add IPN3KE document

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE document. No need to separate the doc patch, can merge into the one that adds the driver. > > Signed-off-by: Rosen Xu > Signed-off-by: Dan Wei > --- > doc/guides/nics/features/ipn3ke.ini | 57 ++

Re: [dpdk-dev] [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE PMD driver. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > Signed-off-by: Dan Wei > --- > drivers/net/Makefile |1 + > drivers/net/ipn3ke/Makefile | 33 + >

Re: [dpdk-dev] [PATCH v1 07/11] mk: add link enablement for IPN3KE

2019-03-06 Thread Yigit, Ferruh
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add link enablement for Intel FPGA Acceleration > NIC IPN3KE. Again, I think no need/benefit to make this separate patch, please merge into main one that add pmd. > > Signed-off-by: Rosen Xu > --- > mk/rte.app.mk | 1 + > 1 file changed, 1 insertion(+) >

Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd

2019-03-06 Thread Yigit, Ferruh
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add IPN3KE support for testpmd I think it is already decided to remove this patch, +1. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > --- > app/test-pmd/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --git a/app/test-pmd/Makefil

Re: [dpdk-dev] [PATCH v1 06/11] config: add build enablement for IPN3KE

2019-03-06 Thread Yigit, Ferruh
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add build enablement for Intel FPGA Acceleration > NIC IPN3KE. No need to make this a separate patch, can squash into previous one. > > Signed-off-by: Rosen Xu > --- > config/common_base | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/con

Re: [dpdk-dev] [PATCH v1 11/11] MAINTAINERS: add MAINTAINERS for IPN3KE

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:13 AM, Rosen Xu wrote: > Add MAINTAINERS for Intel FPGA Acceleration NIC IPN3KE. I think this patch shouldn't be separate, can you please merge with the main patch that adds the pmd. > > Signed-off-by: Rosen Xu > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) >

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-06 Thread Rastislav Černay
> > > --Why is -lfdt added? I don't see any symbols from libfdt used in the > --rest of the patch? > Hi, libnfb is dependent on fdt and there is a special case, where some functions are defined in header (netcope/rxmac.h, netcope/txmac.h). So if one wants to use functions, from these headers fdt n

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-06 Thread Luca Boccassi
On Wed, 2019-03-06 at 15:51 +0100, Rastislav Černay wrote: > > > > --Why is -lfdt added? I don't see any symbols from libfdt used in > > the > > --rest of the patch? > > > > Hi, > libnfb is dependent on fdt and there is a special case, where some > functions are defined in header (netcope/rxmac.

Re: [dpdk-dev] [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add OPAE share code for IPN3KE

2019-03-06 Thread Zhang, Tianfei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, March 6, 2019 8:28 PM > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang > Subject: Re: [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add OP

[dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-06 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v3 2/8] mempool/stack: convert mempool to use rte stack

2019-03-06 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v3 0/8] Add stack library and new mempool handler

2019-03-06 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v3 3/8] test/stack: add stack test

2019-03-06 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 + app/test/test_stack.c | 4

[dpdk-dev] [PATCH v3 5/8] stack: add lock-free stack implementation

2019-03-06 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v3 4/8] test/stack: add stack perf test

2019-03-06 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v3 7/8] test/stack: add lock-free stack tests

2019-03-06 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v3 6/8] stack: add C11 atomic implementation

2019-03-06 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads --- lib/librte_stack/Makefile| 3 +- lib/librte_stack/meson.build

[dpdk-dev] [PATCH v3 8/8] mempool/stack: add lock-free stack mempool handler

2019-03-06 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

Re: [dpdk-dev] mlx5 under FreeBSD

2019-03-06 Thread Shahaf Shuler
Hi Mit, Monday, March 4, 2019 6:45 PM, Mit Matelske: > Subject: Re: [dpdk-dev] mlx5 under FreeBSD > > dev.mlx5_core.1.hw.board_id: LNR3270110033 > dev.mlx5_core.1.hw.fw_version: 12.17.2020 Getting back to you on this one. >From the FW it looks like you are trying to create a TIR (QP) which does

[dpdk-dev] [PATCH v6 0/6] Add lock-free ring and mempool handler

2019-03-06 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a lock-free ring and a mempool based on it. The lock-free

[dpdk-dev] [PATCH v6 1/6] ring: add a pointer-width headtail structure

2019-03-06 Thread Gage Eads
For 64-bit systems, at current CPU speeds, 64-bit head and tail indexes will not wrap-around within the author's lifetime. This is important to avoiding the ABA problem -- in which a thread mistakes reading the same tail index in two accesses to mean that the ring was not modified in the intervenin

[dpdk-dev] [PATCH v6 2/6] ring: add a ring start marker

2019-03-06 Thread Gage Eads
This marker allows us to replace "&r[1]" with "&r->ring" to locate the start of the ring. Signed-off-by: Gage Eads --- lib/librte_ring/rte_ring.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index c78db6916..f16d

[dpdk-dev] [PATCH v6 3/6] ring: add a lock-free implementation

2019-03-06 Thread Gage Eads
This commit adds support for lock-free circular ring enqueue and dequeue functions. The ring is supported on 32- and 64-bit architectures, however it uses a 128-bit compare-and-swap instruction when run on a 64-bit architecture, and thus is currently limited to x86_64. The algorithm is based on Ol

[dpdk-dev] [PATCH v6 5/6] test_ring_perf: add lock-free ring perf test

2019-03-06 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- app/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/app/test/test_ring_

[dpdk-dev] [PATCH v6 4/6] test_ring: add lock-free ring autotest

2019-03-06 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- app/test/test_ring.c | 61 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/

[dpdk-dev] [PATCH v6 6/6] mempool/ring: add lock-free ring handlers

2019-03-06 Thread Gage Eads
These handlers allow an application to create a mempool based on the lock-free ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env_ab

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2019-03-06 Thread Carrillo, Erik G
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, March 5, 2019 8:39 PM > To: Carrillo, Erik G ; rsanf...@akamai.com > Cc: dev@dpdk.org; techbo...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 0/2] Timer library changes > > Hi Erik, > > Apologies if I am reaching out a bit late

[dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

2019-03-06 Thread David Harton
ixgevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable these offloads at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- drivers/net/ixgbe/ix

Re: [dpdk-dev] DPDK Release Status Meeting 21/2/2019

2019-03-06 Thread Luca Boccassi
On Thu, 2019-02-21 at 17:43 +, Luca Boccassi wrote: > On Thu, 2019-02-21 at 16:09 +, Ferruh Yigit wrote: > > Minutes 21 February 2019 > > > > cut > > > * Coverity is partially back, but new analyses aren't running > > * Looking for suggestions from the community

Re: [dpdk-dev] DPDK Release Status Meeting 21/2/2019

2019-03-06 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Luca Boccassi > Sent: Wednesday, March 6, 2019 3:28 PM > To: dpdk-dev > Cc: Mcnamara, John ; Thomas Monjalon > ; Yigit, Ferruh > Subject: Re: [dpdk-dev] DPDK Release Status Meeting 21/2/2019 > > On Thu, 2019-02

Re: [dpdk-dev] [PATCH 2/2] ethdev: use strlcpy instead of snprintf on initialization

2019-03-06 Thread Ferruh Yigit
On 3/4/2019 7:12 PM, Stephen Hemminger wrote: > On Mon, 4 Mar 2019 12:11:20 +0300 > Andrew Rybchenko wrote: > >> On 3/1/19 9:42 PM, Stephen Hemminger wrote: >>> On Fri, 1 Mar 2019 10:48:58 +0300 >>> Andrew Rybchenko wrote: >>> On 3/1/19 1:47 AM, Stephen Hemminger wrote: > Don't need

[dpdk-dev] Segfault when eal thread executing mlx5 nic‘s lsc event

2019-03-06 Thread Zhaohui (zhaohui, Polestar)
Hi: I think the flow list may be accessed in the same time by two different threads and may cause some errors. Do it need a lock to protect the flow list? Thanks

[dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

2019-03-06 Thread Zhaohui (zhaohui, Polestar)
When the number of slave slave devices exceeds 8, it will cause the array subscript to cross the boundary. --- drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_et

[dpdk-dev] 答复: Segfault when eal thread executing mlx5 nic‘s lsc event

2019-03-06 Thread Zhaohui (zhaohui, Polestar)
Hi Williams: We have some questions that need your help. About “Segfault when eal thread executing mlx5 nic‘s lsc event”. In order to solve this problem(core dump), What should we do?( Looking forward to your reply)

[dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped

2019-03-06 Thread Bernard Iremonger
This patchset fixes the issue of the first inbound packet being dropped for inline crypto. It also improves the debug output in esp.c, sa.c and ipsec-secgw.c Bernard Iremonger (6): examples/ipsec-secgw: fix 1st pkt dropped for inline crypto examples/ipsec-secgw: fix 1st packet dropped patch

[dpdk-dev] [PATCH 1/6] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-06 Thread Bernard Iremonger
Refactor create_session() into create_inline_session() and create_lookaside_session() in ipsec.c Use socket_ctx in create_inline_session() Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/ipsec.c

[dpdk-dev] [PATCH 3/6] examples/ipsec-secgw: fix 1st packet dropped patch three

2019-03-06 Thread Bernard Iremonger
Refactor cryprodev_init() and main() in ipsec-secgw.c Add max_session_size(). Start ports before adding flows in main(). Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/ipsec-secgw.c | 246 ++

[dpdk-dev] [PATCH 2/6] examples/ipsec-secgw: fix 1st packet dropped patch two

2019-03-06 Thread Bernard Iremonger
Call create_inline_session() at initialisition in sa.c Call rte_ipsec_session_prepare() in fill_ipsec_session() for inline. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/sa.c | 46 +

[dpdk-dev] [PATCH 4/6] examples/ipsec-secgw: fix debug in esp.c

2019-03-06 Thread Bernard Iremonger
Improve debug code in esp.c Fixes: f159e70b0922 ("examples/ipsec-secgw: support transport mode") Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/esp.c | 5 +++-- 1 file changed, 3 insertions(+),

[dpdk-dev] [PATCH 5/6] examples/ipsec-secgw: fix debug in sa.c

2019-03-06 Thread Bernard Iremonger
Improve debug code in sa.c Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/sa.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/examples/ipsec-secgw/s

[dpdk-dev] [PATCH 6/6] examples/ipsec-secgw: fix debug in ipsec-secgw.c

2019-03-06 Thread Bernard Iremonger
Improve debug in ipsec-secgw.c Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec-secgw/ipsec-secgw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/ex

Re: [dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped

2019-03-06 Thread Akhil Goyal
Hi Bernard, On 3/6/2019 9:30 PM, Bernard Iremonger wrote: > This patchset fixes the issue of the first inbound packet > being dropped for inline crypto. It also improves the debug > output in esp.c, sa.c and ipsec-secgw.c > > Bernard Iremonger (6): >examples/ipsec-secgw: fix 1st pkt dropped fo

[dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-06 Thread Bruce Richardson
The terms linuxapp and bsdapp are legacy names in DPDK that are equivalent to the more usual names of "linux" and "freebsd". Therefore, we can replace the instances of the "app" names with the more usual variants. The only issue in maintaining backward compatibility which can be done by preserving

[dpdk-dev] [PATCH 1/6] eal/bsdapp: rename to freebsd

2019-03-06 Thread Bruce Richardson
The term "bsdapp" is a legacy one, but just calling the subdirectory "freebsd" is just clearer for all concerned. Signed-off-by: Bruce Richardson --- MAINTAINERS | 8 devtools/build-tags.sh| 2 +- doc/guid

[dpdk-dev] [PATCH 2/6] eal/linuxapp: rename to linux

2019-03-06 Thread Bruce Richardson
The term "linuxapp" is a legacy one, but just calling the subdirectory "linux" is just clearer for all concerned. Signed-off-by: Bruce Richardson --- MAINTAINERS | 8 devtools/build-tags.sh| 2 +- doc/guid

[dpdk-dev] [PATCH 3/6] build/linux: rename macro from LINUXAPP to LINUX

2019-03-06 Thread Bruce Richardson
Rename the macro to make things shorter and more comprehensible. For both meson and make builds, keep the old macro around for backward compatibility. Signed-off-by: Bruce Richardson --- app/test/process.h| 2 +- app/test/test_eal_flags.c | 2 +-

[dpdk-dev] [PATCH 4/6] build/freebsd: rename macro from BSDPAPP to FREEBSD

2019-03-06 Thread Bruce Richardson
Rename the macro and all instances in DPDK code, but keep a copy of the old macro defined for legacy code linking against DPDK Signed-off-by: Bruce Richardson --- app/test-bbdev/test_bbdev_vector.c| 2 +- .../cperf_test_vector_parsing.c | 2 +- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH 6/6] build: allow linux and freebsd in build configs

2019-03-06 Thread Bruce Richardson
Rather than using linuxapp and bsdapp everywhere, we can change things to use the, more readable, terms "linux" and "freebsd" in our build configs. Rather than renaming the configs we can just duplicate the existing ones with the new names using symlinks, and use the new names exclusively internall

[dpdk-dev] [PATCH 5/6] build/meson: change linuxapp to linux in meson cross files

2019-03-06 Thread Bruce Richardson
Rename the cross files for meson compilation from having linuxapp in the name to just linux in the name. Signed-off-by: Bruce Richardson --- .../arm/{arm64_armv8_linuxapp_gcc => arm64_armv8_linux_gcc} | 0 .../arm/{arm64_dpaa2_linuxapp_gcc => arm64_dpaa2_linux_gcc} | 0 config/arm/{arm64_dpa

Re: [dpdk-dev] [PATCH v3] cryptodev: rework mod exp and mod inv comments

2019-03-06 Thread Akhil Goyal
On 2/6/2019 4:04 PM, Arek Kusztal wrote: > This patch changes modular exponentiation and modular multiplicative > inverse API comments to make it more precise. > > Signed-off-by: Arek Kusztal > --- > v2: > - grammar fixes > > v3: > - remove information about positive integer > > lib/librte_cry

Re: [dpdk-dev] [PATCH] openssl: fix bad reference of modinv

2019-03-06 Thread Akhil Goyal
On 2/5/2019 10:24 PM, Trahe, Fiona wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Arek Kusztal >> Sent: Tuesday, February 5, 2019 9:13 AM >> To: dev@dpdk.org >> Cc: sunila.s...@caviumnetworks.com; akhil.go...@nxp.com; >> shally.ve...@caviumnetworks

Re: [dpdk-dev] [PATCH] doc/qat: fix table of kernel drivers

2019-03-06 Thread Akhil Goyal
On 2/11/2019 5:38 PM, Jozwiak, TomaszX wrote: > >> -Original Message- >> From: Trahe, Fiona >> Sent: Thursday, February 7, 2019 7:46 PM >> To: dev@dpdk.org >> Cc: Trahe, Fiona ; Jozwiak, TomaszX >> ; Kusztal, ArkadiuszX >> ; akhil.go...@nxp.com; sta...@dpdk.org >> Subject: [PATCH] doc/qat

Re: [dpdk-dev] [PATCH] common/cpt: fix failure with null auth only test case

2019-03-06 Thread Akhil Goyal
On 2/13/2019 2:52 PM, Anoob Joseph wrote: > Fixes: 351fbee21986 ("common/cpt: support hash") > > Signed-off-by: Anoob Joseph > Signed-off-by: Tejasree Kondoj > --- > drivers/common/cpt/cpt_ucode.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/common/cpt/cpt

Re: [dpdk-dev] [PATCH] openssl: fix not clearing big numbers after computations

2019-03-06 Thread Akhil Goyal
On 2/12/2019 4:31 PM, Shally Verma wrote: > >> -Original Message- >> From: dev On Behalf Of Arek Kusztal >> Sent: 07 February 2019 16:25 >> To: dev@dpdk.org >> Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; >> shally.ve...@caviumnetworks.com; sunila.s...@caviumnetworks.com; >> ashish.g

Re: [dpdk-dev] 18.08.1 patches review and test

2019-03-06 Thread Walker, Benjamin
On Wed, 2019-01-30 at 16:27 +, Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for stable release 18.08.1. Please > help review and test. The tentative date for the final release is 28, > February. Before that, please shout if anyone has objections with these > patches be

Re: [dpdk-dev] [PATCH] test/crypto: fix duplicate device id uses by CCP device

2019-03-06 Thread Akhil Goyal
On 2/22/2019 3:36 PM, Hemant Agrawal wrote: > These duplicate device id is causing incorrect mapping > for DPAA_SEC for test case execultion on the basis of > capabilities. > > Fixes: e155ca055e84 ("test/crypto: add tests for AMD CCP") > Cc: sta...@dpdk.org > Cc: ravi1.ku...@amd.com > > Reported-

[dpdk-dev] [PATCH 2/4] .gitignore: ignore python bytecode files

2019-03-06 Thread Bruce Richardson
After you run a python script, a .pyc file is often left behind, which we don't want to track in git. Signed-off-by: Bruce Richardson --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index b23e1dbb7..eb3c23705 100644 --- a/.gitignore +++ b/.gitignore

[dpdk-dev] [PATCH 1/4] .gitignore: add section header comments

2019-03-06 Thread Bruce Richardson
Split the ignored file list into section based on logical groups of files, putting a comment at the top of each section clarifying what it is. Signed-off-by: Bruce Richardson --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 9105e26c5..b23e1dbb7

[dpdk-dev] [PATCH 3/4] .gitignore: ignore hidden files

2019-03-06 Thread Bruce Richardson
Generally hidden files are hidden for good reason and we don't want to track them in git. They can always be manually added to git tracking individually if needed. Signed-off-by: Bruce Richardson --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index

[dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

2019-03-06 Thread Bruce Richardson
test-meson-build.sh generates multiple build directories for various targets. As these follow a few known patterns of reasonable lengths, and since they don't need to be tracked in git, we can add them to the gitignore file. Signed-off-by: Bruce Richardson --- .gitignore | 6 ++ 1 file chang

[dpdk-dev] [PATCH v4 0/2] Timer library changes

2019-03-06 Thread Erik Gabriel Carrillo
This patch series modifies the timer library in such a way that structures that used to be statically allocated in a process's data segment are now allocated in shared memory. As these structures contain lists of timers, new APIs are introduced that allow a caller to specify the particular structu

[dpdk-dev] [PATCH v4 2/2] timer: add function to stop all timers in a list

2019-03-06 Thread Erik Gabriel Carrillo
Add a function to the timer API that allows a caller to traverse a specified set of timer lists, stopping each timer in each list, and invoking a callback function. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 39 ++ lib/librte

[dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-06 Thread Erik Gabriel Carrillo
Currently, the timer library uses a per-process table of structures to manage skiplists of timers presumably because timers contain arbitrary function pointers whose value may not resolve properly in other processes. However, if the same callback is used handle all timers, and that callback is onl

Re: [dpdk-dev] [PATCH] kni: fix possible kernel crash with va2pa

2019-03-06 Thread Ferruh Yigit
On 2/28/2019 7:30 AM, Yangchao Zhou wrote: > va2pa depends on the physical address and virtual address offset of > current mbuf. It may get the wrong physical address of next mbuf which > allocated in another hugepage segment. Hi Yangchao, The problem you described seems valid, when current mbuf

Re: [dpdk-dev] 18.08.1 patches review and test

2019-03-06 Thread Kevin Traynor
On 06/03/2019 16:45, Walker, Benjamin wrote: > On Wed, 2019-01-30 at 16:27 +, Kevin Traynor wrote: >> Hi all, >> >> Here is a list of patches targeted for stable release 18.08.1. Please >> help review and test. The tentative date for the final release is 28, >> February. Before that, please sho

[dpdk-dev] [RFC] ethdev: check for invalid device name

2019-03-06 Thread Stephen Hemminger
Do not allow creating a ethernet device with a name over the allowed maximum (or 0 length). Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 85

Re: [dpdk-dev] [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add OPAE share code for IPN3KE

2019-03-06 Thread Ferruh Yigit
On 3/6/2019 1:59 PM, Zhang, Tianfei wrote: > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, March 6, 2019 8:28 PM >> To: Xu, Rosen ; dev@dpdk.org >> Cc: Zhang, Tianfei ; Wei, Dan >> ; Pei, Andy ; Yang, Qiming >> ; Wang, Haiyue ; Chen, >> Santos ; Zhang, Zhang >> Subject:

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-06 Thread Thomas Monjalon
06/03/2019 11:46, Gaëtan Rivet: > On Tue, Mar 05, 2019 at 06:58:04PM +0100, Thomas Monjalon wrote: > > 05/03/2019 18:38, Gaëtan Rivet: > > > What happens when a primary process closes a device before a secondary? > > > Is the secondary unable to stop / close its own then? Isn't there some > > > mis

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] drivers: fix possible overflow with strcat

2019-03-06 Thread Ferruh Yigit
<...> > @@ -11734,13 +11735,14 @@ static const char *get_bnx2x_flags(uint32_t flags) > > for (i = 0; i < 5; i++) > if (flags & (1 << i)) { > - strcat(flag_str, flag[i]); > + strlcat(flag_str, flag[i], sizeof(flag_str)); >

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 0/2] Timer library changes

2019-03-06 Thread Carrillo, Erik G
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, March 5, 2019 4:59 PM > To: Carrillo, Erik G > Cc: techbo...@dpdk.org; rsanf...@akamai.com; dev@dpdk.org > Subject: Re: [dpdk-techboard] [dpdk-dev] [PATCH v3 0/2] Timer library > changes > > 05/03/2

Re: [dpdk-dev] 答复: Segfault when eal thread executing mlx5 nic‘s lsc event

2019-03-06 Thread Chas Williams
On 3/6/19 4:42 AM, Zhaohui (zhaohui, Polestar) wrote: Hi Williams: We have some questions that need your help. About “Segfault when eal thread executing mlx5 nic‘s lsc event”. In order to solve this problem(core dump), What should we do?( Looking forward to your reply) The link sta

Re: [dpdk-dev] [PATCH 2/6] examples/ipsec-secgw: fix 1st packet dropped patch two

2019-03-06 Thread Ananyev, Konstantin
Hi Bernard, > > Call create_inline_session() at initialisition in sa.c > Call rte_ipsec_session_prepare() in fill_ipsec_session() for inline. Here and in other places - it probably worth to explain what is the purpose for these changes. As a side notice, as these series fixes that problem, i

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 0/2] Timer library changes

2019-03-06 Thread Thomas Monjalon
06/03/2019 19:54, Carrillo, Erik G: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 05/03/2019 23:41, Carrillo, Erik G: > > > Hi all, > > > > > > I'd like to bring this patch proposal up again and see if I can get any > > > more > > feedback from the maintainer or others. > > > > > > I ne

Re: [dpdk-dev] mlx5 under FreeBSD

2019-03-06 Thread Mit Matelske
> > > > dev.mlx5_core.1.hw.board_id: LNR3270110033 > > dev.mlx5_core.1.hw.fw_version: 12.17.2020 > > Getting back to you on this one. > > From the FW it looks like you are trying to create a TIR (QP) which doesn't > use Toeplitz hash function (IBV_RX_HASH_FUNC_TOEPLITZ) but the rss key is not >

Re: [dpdk-dev] [PATCH v2 0/6] HelloWorld example for windows

2019-03-06 Thread Anand Rawat
On 3/6/2019 12:29 AM, Thomas Monjalon wrote: Hi, 06/03/2019 05:16, Anand Rawat: v2 Changes: Incorporated reviews from v1. Fixed license period for updated files. Renamed 'winapp' folder to 'windows'. Cleaned unneeded meson changes. Fixed code style warnings. Added maintainers information for wi

Re: [dpdk-dev] [PATCH v2 0/6] HelloWorld example for windows

2019-03-06 Thread Thomas Monjalon
06/03/2019 23:45, Anand Rawat: > > - Please use --in-reply-to for new revisions in order to have > > all revisions in the same mail thread. > > The best is to make all revisions as replies of the first cover letter. > > > > > > I will make sure to follow this from v3 onward. > Since now that the

Re: [dpdk-dev] [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add OPAE share code for IPN3KE

2019-03-06 Thread Zhang, Tianfei
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 7, 2019 1:55 AM > To: Zhang, Tianfei ; Xu, Rosen > ; dev@dpdk.org > Cc: Wei, Dan ; Pei, Andy ; Yang, > Qiming ; Wang, Haiyue ; > Chen, Santos ; Zhang, Zhang > > Subject: Re: [PATCH v1 03/11] drivers/raw/ifpga_rawdev: add

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Anand Rawat
On 3/6/2019 3:52 AM, Richardson, Bruce wrote: -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Wednesday, March 6, 2019 11:36 AM To: Richardson, Bruce Cc: dev@dpdk.org; Rawat, Anand ; Kadam, Pallavi ; Menon, Ranjit ; Shaw, Jeffrey B Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Anand Rawat
On 3/6/2019 3:20 AM, Richardson, Bruce wrote: On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: # get binutils version for the workaround of Bug 97 -ldver = run_command('ld', '-v').stdout().strip() -if ldver.contains('2.30') - if cc.has_argument('-mno-avx512f') -

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2019-03-06 Thread Varghese, Vipin
Hi Gabriel, Thanks for the clarification. > -Original Message- > From: Carrillo, Erik G > Sent: Wednesday, March 6, 2019 8:46 PM > To: Varghese, Vipin ; rsanf...@akamai.com > Cc: dev@dpdk.org; techbo...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 0/2] Timer library changes > > > -Or

Re: [dpdk-dev] [PATCH v1 2/6] lib/mbuf: enable parse flags when create mempool

2019-03-06 Thread Ye Xiaolong
Hi David, Thanks for you comments. On 03/05, David Marchand wrote: >On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote: > >> This give the option that applicaiton can configure each >> memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD). >> >> Signed-off-by: Qi Zhang >> Signed-off-by: Xiaolon

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-06 Thread Ye Xiaolong
Hi, David Thanks for your review. On 03/05, David Marchand wrote: >On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote: > >> diff --git a/doc/guides/rel_notes/release_18_11.rst >> b/doc/guides/rel_notes/release_18_11.rst >> index 65bab557d..e0918441a 100644 >> --- a/doc/guides/rel_notes/release_18_

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-06 Thread Anand Rawat
On 3/6/2019 3:31 AM, Thomas Monjalon wrote: 06/03/2019 05:16, Anand Rawat: Added header files to support windows on x86 platforms. Updated rte_config to include rte_windows.h for windows build. [...] --- a/config/rte_config.h +++ b/config/rte_config.h +/* windows specific*/ +#ifdef RTE_EXEC_EN

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-03-06 Thread Anoob Joseph
Hi Akhil, Fiona, Would the usage of strcmp be alright? Please check my comment inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Friday, March 1, 2019 11:55 AM > To: Trahe, Fiona ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit,

Re: [dpdk-dev] mlx5 under FreeBSD

2019-03-06 Thread Shahaf Shuler
Wednesday, March 6, 2019 11:02 PM, Mit Matelske: > Subject: Re: [dpdk-dev] mlx5 under FreeBSD > > > > > > > dev.mlx5_core.1.hw.board_id: LNR3270110033 > > > dev.mlx5_core.1.hw.fw_version: 12.17.2020 > > > > Getting back to you on this one. > > > > From the FW it looks like you are trying to create

  1   2   >