Re: [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

2019-01-18 Thread Ferruh Yigit
On 1/18/2019 1:59 AM, Wang, Xiao W wrote: > Hi, > >> -Original Message- >> From: Rami Rosen [mailto:ramir...@gmail.com] >> Sent: Thursday, January 17, 2019 10:51 PM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Wang, Xiao W ; Rami Rosen >> >> Subject: [PATCH] doc: fix an error in ifc NIC do

[dpdk-dev] [PATCH] net/mlx5: fix configuring device parser for VxLAN GPE

2019-01-18 Thread Yongseok Koh
PKT_TX_TUNNEL_UDP is introduced to support generic UDP tunnels which is not defined by PKT_TX_TUNNEL_*. SW parser feature of mlx5 device can be used for generic tunnels unknown to device. Even though PKT_TX_TUNNEL_VXLAN_GPE is defined in rte_mbuf.h, it is not a pre-defined tunnel to mlx5 device and

[dpdk-dev] [PATCH v4 3/4] net/softnic: support QinQ PPPoE encap

2019-01-18 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v4:Added implementation of QinQ PPPoE packet encapsulation action. --- drivers/net/softnic/rte_eth_softnic_cli.c | 44 ++- 1 file changed, 43 inser

[dpdk-dev] [PATCH v4 1/4] pipeline: support QinQ PPPoE encap

2019-01-18 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add support of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v4:Splitting of patches for easier review --- lib/librte_pipeline/rte_table_action.c | 61 ++ lib/librte_pipeline/rte_table_action.h | 16 +++ 2 f

[dpdk-dev] [PATCH v4 4/4] net: add PPPoE ethertypes

2019-01-18 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add PPPoE ethertypes in to rte_ether.h. Signed-off-by: Nemanja Marjanovic --- v4:Added PPPoE ethertypes in to rte_ether.h. --- lib/librte_net/rte_ether.h | 2 ++ lib/librte_pipeline/rte_table_action.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(

[dpdk-dev] [PATCH v4 2/4] examples/ip_pipeline: support QinQ PPPoE encap

2019-01-18 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v4:Splitting of patches for easier review --- examples/ip_pipeline/cli.c | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH] examples/fips_validation: fix physical address

2019-01-18 Thread Fan Zhang
This patch fixes the missed digest and aad data physical addresses filling to crypto operations in fips_validation sample application. Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") Signed-off-by: Fan Zhang --- examples/fips_validation/fips_dev_self_test.c | 39 +++

[dpdk-dev] [PATCH v2 1/2] ticketlock: ticket based to improve fairness

2019-01-18 Thread Joyce Kong
The spinlock implementation is unfair, some threads may take locks aggressively while leaving the other threads starving for long time. As shown in the following test, within same period of time, there are threads taking locks much more times than the others. The ticketlock gives each waiting thre

[dpdk-dev] [PATCH v2 2/2] test/ticketlock: add ticket lock test case

2019-01-18 Thread Joyce Kong
Add test cases for ticket lock, recursive ticket lock, and ticket lock performance. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- test/test/Makefile | 1 + test/test/autotest_data.py | 6 + test/test/meson.build | 1 + test/test/test_ticketloc

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-18 Thread Kovacevic, Marko
> > Sorry for not making it clearer, > > So if someone was reading it and saw this line > > > > "The examples directory contains sample applications that show how > libraries can be used" > > > > It would be nice to have a link to the sample applications in the docs > > like so, which has all the I

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-18 Thread Thomas Monjalon
18/01/2019 10:29, Kovacevic, Marko: > > > Sorry for not making it clearer, > > > So if someone was reading it and saw this line > > > > > > "The examples directory contains sample applications that show how > > libraries can be used" > > > > > > It would be nice to have a link to the sample applica

[dpdk-dev] [PATCH v2] doc: fix references in power management guide

2019-01-18 Thread David Hunt
In the References section in the Power Management overview, both links pointed to the same l3fwd-power app. Fix the links so that one points to l3fwd-power, and the other points to the vm_power_manager sample app. Signed-off-by: David Hunt Acked-by: Marko Kovacevic --- doc/guides/prog_guide/pow

Re: [dpdk-dev] [PATCH v4 1/4] pipeline: support QinQ PPPoE encap

2019-01-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Marjanovic, Nemanja > Sent: Friday, January 18, 2019 9:12 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Dumitrescu, Cristian > ; Marjanovic, Nemanja > > Subject: [PATCH v4 1/4] pipeline: support QinQ PPPoE encap > > From: "Nemanja Marjanovic" > > Add sup

Re: [dpdk-dev] [PATCH] vfio: allow secondary process to query IOMMU type

2019-01-18 Thread Burakov, Anatoly
On 17-Jan-19 5:30 PM, Anatoly Burakov wrote: It is only possible to know IOMMU type of a given VFIO container by attempting to initialize it. Since secondary process never attempts to set up VFIO container itself (because they're shared between primary and secondary), it never knows which IOMMU t

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-18 Thread David Marchand
On Fri, Jan 18, 2019 at 10:33 AM Thomas Monjalon wrote: > 18/01/2019 10:29, Kovacevic, Marko: > > > > Sorry for not making it clearer, > > > > So if someone was reading it and saw this line > > > > > > > > "The examples directory contains sample applications that show how > > > libraries can be u

[dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-18 Thread Anatoly Burakov
It is only possible to know IOMMU type of a given VFIO container by attempting to initialize it. Since secondary process never attempts to set up VFIO container itself (because they're shared between primary and secondary), it never knows which IOMMU type the container is using, and never sets up t

[dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect place in Tx path

2019-01-18 Thread Shahed Shaikh
Incorrect placement of prefetch in Tx path is causing a performance drop of around ~2% on AMD platform. Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Shahed Shaikh
Allocating replacement buffer per received packet is expensive. Instead, process received packets first and allocate replacement buffers in bulk later. This improves performance by ~25% in terms of PPS on AMD platforms. Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: sta...@dpdk.org Signed-off

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile

2019-01-18 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, January 17, 2019 10:27 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile

Re: [dpdk-dev] [PATCH v4 4/4] net: add PPPoE ethertypes

2019-01-18 Thread Thomas Monjalon
+Cc Olivier, maintainer 18/01/2019 10:12, Nemanja Marjanovic: > From: "Nemanja Marjanovic" > > Add PPPoE ethertypes in to rte_ether.h. > > Signed-off-by: Nemanja Marjanovic > --- > v4:Added PPPoE ethertypes in to rte_ether.h. > --- > lib/librte_net/rte_ether.h | 2 ++ > lib/librte

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile

2019-01-18 Thread Thomas Monjalon
18/01/2019 11:57, Ananyev, Konstantin: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > 16/01/2019 14:21, Fan Zhang: > > > This patch fixes the inflexible compile issue AESNI-MB PMD. > > > Originally the compile of the PMD will fail if IPSec_MB is > > > not installed in de

[dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs

2019-01-18 Thread Ferruh Yigit
From: Andy Pei Original driver requires users to input "afu_bts" args. But driver can also work without an explicit "afu_bts" args. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: sta...@dpdk.org Signed-off-by: Andy Pei Acked-by: Rosen Xu --- Cc: rosen...@intel.com Cc: tianf

[dpdk-dev] [PATCH v2] bus/ifpga: fix build for cpp applications

2019-01-18 Thread Ferruh Yigit
From: Andy Pei Brackets unmatch when __cplusplus defined. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: sta...@dpdk.org Signed-off-by: Andy Pei Reviewed-by: Ferruh Yigit --- Cc: rosen...@intel.com --- drivers/bus/ifpga/rte_bus_ifpga.h | 6 +- 1 file changed, 5 inserti

[dpdk-dev] [PATCH v2] bus/ifpga: fix ifpga afu driver probe failure handler

2019-01-18 Thread Ferruh Yigit
From: Andy Pei In the original code, when an AFU device probe a driver, if the first driver in the driver list does not support this device or some error happens, bus probe returns an error. With this patch, a device will try to match driver in the driver list one by one until an appropriate dri

[dpdk-dev] [PATCH v3] raw/ifpga: fix memory leak

2019-01-18 Thread Ferruh Yigit
From: Andy Pei When ifpga_rawdev_create() allocate memory for a new rawdev, the original code allocate redundant memory for adapter, which is a member of the rawdev. What is actually necessary is the adapter to be initialized, not memory allocated. Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA

Re: [dpdk-dev] [PATCH] compress/isal: fix build with old library version

2019-01-18 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lee Daly > Sent: Thursday, January 17, 2019 9:11 PM > To: De Lara Guarch, Pablo ; Trahe, Fiona > > Cc: dev@dpdk.org; Daly, Lee > Subject: [dpdk-dev] [PATCH] compress/isal: fix build with old library > version > >

Re: [dpdk-dev] VF of a X520 card does not process VLAN packets

2019-01-18 Thread Ananyev, Konstantin
Hi It’s been while since I looked at it last time, but shouldn’t you assign desired vlan tag to the VF first: ip link set vf vlan ? Konstantin From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Thursday, January 3, 2019 4:42 PM To: Lu, Wenzhuo ; Ananyev, Konstantin Cc: dev Subject: Re:

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile

2019-01-18 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 18, 2019 11:03 AM > To: Ananyev, Konstantin > Cc: Zhang, Roy Fan ; dev@dpdk.org; > akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix comp

Re: [dpdk-dev] [RFC v2 1/2] rcu: add RCU library supporting QSBR mechanism

2019-01-18 Thread Ananyev, Konstantin
> > > > > diff --git a/lib/librte_rcu/rte_rcu_qsbr.h > > > > > b/lib/librte_rcu/rte_rcu_qsbr.h new file mode 100644 index > > > > > 0..c818e77fd > > > > > --- /dev/null > > > > > +++ b/lib/librte_rcu/rte_rcu_qsbr.h > > > > > @@ -0,0 +1,321 @@ > > > > > +/* SPDX-License-Identifier: BSD-3-

Re: [dpdk-dev] [PATCH] doc/power: fix references in power management

2019-01-18 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 17, 2019 6:51 PM > To: Hunt, David > Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko > Subject: Re: [dpdk-dev] [PATCH] doc/power: fix references in power > management > ... > > -*

Re: [dpdk-dev] [PATCH] doc/qat: add GCM AAD limitation

2019-01-18 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, January 17, 2019 7:23 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; akhil.go...@nxp.com; Kusztal, ArkadiuszX > ; sta...@dpdk.org > Subject: [PATCH] doc/qat: add GCM AAD limitation > > Add limitation that

[dpdk-dev] [PATCH] gso: fix VxLAN/GRE tunnel checks

2019-01-18 Thread Andrew Rybchenko
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits. Fixes: b058d92ea95d ("gso: support VxLAN GSO") Fixes: 70e737e448c7 ("gso: support GRE GSO") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- lib/librte_gso/gso_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [dpdk-dev] [PATCH] doc: update recommended versions for i40e

2019-01-18 Thread Ferruh Yigit
On 1/18/2019 3:25 PM, Lijuan Tu wrote: > add recommended DPDK/kernel driver/firmware version matching list for > i40e for 19.02 > > Signed-off-by: Lijuan Tu Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc/power: fix references in power management

2019-01-18 Thread Thomas Monjalon
18/01/2019 13:15, Mcnamara, John: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > ... > > > -* The "L3 Forwarding with Power Management Sample Application" > > chapter in the *DPDK Sample Application's User Guide*. > > > +* The :doc:`VM Power Management > > Application<../sample_app_ug

Re: [dpdk-dev] DSW eventdev and multi-process DPDK

2019-01-18 Thread Mattias Rönnblom
On 2019-01-17 20:10, Venky Venkatesh wrote: [VV]: I had a question on the eventdev initialization API in the above multi-process setting. The following are the objects and API to init each of them. For each of these can you confirm whether it needs to be called in the PRIMARY process only or e

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Ferruh Yigit
On 1/18/2019 10:29 AM, Shahed Shaikh wrote: > Allocating replacement buffer per received packet is expensive. > Instead, process received packets first and allocate > replacement buffers in bulk later. > > This improves performance by ~25% in terms of PPS on AMD > platforms. > > Fixes: 2ea6f76aff

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Ferruh Yigit
On 1/18/2019 2:41 PM, Ferruh Yigit wrote: > On 1/18/2019 10:29 AM, Shahed Shaikh wrote: >> Allocating replacement buffer per received packet is expensive. >> Instead, process received packets first and allocate >> replacement buffers in bulk later. >> >> This improves performance by ~25% in terms o

Re: [dpdk-dev] DSW eventdev and multi-process DPDK

2019-01-18 Thread Mattias Rönnblom
On 2019-01-18 07:36, Venky Venkatesh wrote: [VV]: Some more information. I went with the assumption that I will call these APIs on both the PRIMARY and SECONDARY processes and that these APIs would do the right thing viz. on the PRIMARY it would allocate and initialize while in the SECONDARY

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2019-01-18 Thread Kovacevic, Marko
> Add tested Intel platforms with Intel NICs to v19.02 release note. > > Signed-off-by: Lijuan Tu > --- > doc/guides/rel_notes/release_19_02.rst | 74 > ++ > 1 file changed, 74 insertions(+) > > diff --git a/doc/guides/rel_notes/release_19_02.rst > b/doc/guides/r

Re: [dpdk-dev] [PATCH] SDK: Add scripts to initialize DPDK runtime

2019-01-18 Thread Ferruh Yigit
On 1/17/2019 5:38 PM, Stephen Hemminger wrote: > On Tue, 13 Dec 2016 16:19:00 +0100 > Christian Ehrhardt wrote: > >> Stefans mail got rejected by moderator (??!), reposting FYI as I'm >> subscribed and should autopass the moderation. >> >> On Tue, Dec 13, 2016 at 3:45 PM, Stefan Bader >> wrote:

[dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat

2019-01-18 Thread Chaitanya Babu Talluri
Strcat does not check the destination length and there might be chances of string overflow so insted of strcat, strncat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Fixes: ef28aa96e5 ("net/nfp: support multiprocess") Fixes: 6f4eec25

[dpdk-dev] [PATCH v3 0/5] Add non-blocking ring

2019-01-18 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking ring, on top of which a mempool can run. C

[dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-18 Thread Gage Eads
This commit adds support for non-blocking circular ring enqueue and dequeue functions. The ring uses a 128-bit compare-and-swap instruction, and thus is currently limited to x86_64. The algorithm is based on the original rte ring (derived from FreeBSD's bufring.h) and inspired by Michael and Scott

[dpdk-dev] [PATCH v3 3/5] test_ring: add non-blocking ring autotest

2019-01-18 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring.c | 57 --- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/

[dpdk-dev] [PATCH v3 1/5] ring: add 64-bit headtail structure

2019-01-18 Thread Gage Eads
64-bit head and tail index widths greatly increases the time it takes for them to wrap-around (with current CPU speeds, it won't happen within the author's lifetime). This is important in avoiding the ABA problem -- in which a thread mistakes reading the same tail index in two accesses to mean that

[dpdk-dev] [PATCH v3 4/5] test_ring_perf: add non-blocking ring perf test

2019-01-18 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/test/test/test_rin

[dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat

2019-01-18 Thread Chaitanya Babu Talluri
Strcat does not check the destination length and there might be chances of string overflow so insted of strcat, strncat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Fixes: ef28aa96e5 ("net/nfp: support multiprocess") Fixes: 6f4eec25

[dpdk-dev] [PATCH v3 5/5] mempool/ring: add non-blocking ring handlers

2019-01-18 Thread Gage Eads
These handlers allow an application to create a mempool based on the non-blocking ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env

Re: [dpdk-dev] [PATCH v4 2/2] doc: add guide for debug and troubleshoot

2019-01-18 Thread Kovacevic, Marko
After checking the patch again I found a few spelling mistakes > Add user guide on debug and troubleshoot for common issues and > bottleneck found in sample application model. > > Signed-off-by: Vipin Varghese > Acked-by: Marko Kovacevic > --- > doc/guides/howto/debug_troubleshoot_guide.rst |

[dpdk-dev] [PATCH v2] doc: announce ring API change

2019-01-18 Thread Gage Eads
In order to support the non-blocking ring[1], an API change (additional argument to rte_ring_get_memsize()) is required in librte_ring. This commit updates the deprecation notice to pave the way for its inclusion in 19.05. [1] http://mails.dpdk.org/archives/dev/2019-January/123774.html Signed-off

[dpdk-dev] [PATCH v2] doc: remove file listings

2019-01-18 Thread David Marchand
No need to keep those file listings, they are very likely to become outdated. Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- Changelog since v1: - added a link to the sample applications index --- doc/guides/prog_guide/dev_kit_build_system.rst | 43 -- doc/guides/prog_

[dpdk-dev] [PATCH v3] doc: announce ring API change

2019-01-18 Thread Gage Eads
In order to support the non-blocking ring[1], an API change (additional argument to rte_ring_get_memsize()) is required in librte_ring. This commit updates the deprecation notice to pave the way for its inclusion in 19.05. [1] http://mails.dpdk.org/archives/dev/2019-January/123774.html Signed-off

Re: [dpdk-dev] [PATCH v2] doc: remove file listings

2019-01-18 Thread Kovacevic, Marko
Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Shahed Shaikh
> -Original Message- > From: Ferruh Yigit > Sent: Friday, January 18, 2019 8:11 PM > To: Shahed Shaikh ; dev@dpdk.org > Cc: sta...@dpdk.org; Rasesh Mody ; Thomas Monjalon > > Subject: [EXT] Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck > in Rx path > > >

[dpdk-dev] [PATCH v6 0/5] create different meson test targets

2019-01-18 Thread Hari Kumar Vemula
1/5: remove existing test cases to reorganize further 2/5: add fast-tests suite to meson targets 3/5: add perf-tests suite to meson targets 4/5: add driver-tests suite to meson targets 5/5: add debug-tests suite to meson targets -- v6: Rebased v5: Renamed test suite names Removed quit and deva

[dpdk-dev] [PATCH v6 4/5] test: add driver dependent tests under driver-tests suite

2019-01-18 Thread Hari Kumar Vemula
Added test cases that depend on specific drivers Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- test/test/meson.build | 27 +++ 1 file changed, 27 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 47c97c276..d56c525ea 100644

[dpdk-dev] [PATCH v6 3/5] test: add performance tests under perf-tests suite

2019-01-18 Thread Hari Kumar Vemula
Grouped performace test cases under perf tests category Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- test/test/meson.build | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 1d416967c..47

[dpdk-dev] [PATCH v6 1/5] test: remove existing testcases for categorization

2019-01-18 Thread Hari Kumar Vemula
Removed testcase list from meson build to categorize testcases into suites Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- test/test/meson.build | 119 -- 1 file changed, 119 deletions(-) diff --git a/test/test/meson.build b/test/test/mes

[dpdk-dev] [PATCH v6 5/5] test: add dump test cases under debug-tests suite

2019-01-18 Thread Hari Kumar Vemula
Grouped logging or dump related test cases to test debug category Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- test/test/meson.build | 20 1 file changed, 20 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index d56c525ea..318e04

[dpdk-dev] [PATCH v6 2/5] test: add quick run tests under fast-tests suite

2019-01-18 Thread Hari Kumar Vemula
Added test cases that runs quickly under fast tests category Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- test/test/meson.build | 107 -- 1 file changed, 102 insertions(+), 5 deletions(-) diff --git a/test/test/meson.build b/test/test/

Re: [dpdk-dev] [PATCH v5] lib/efd: fix to free tail queue entry after use

2019-01-18 Thread Thomas Monjalon
18/01/2019 08:40, Hari Kumar Vemula: > In rte_efd_create() allocated memory for tail queue entry but > not freed. > Added freeing the tail queue entry. > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > Cc: sta...@dpdk.org > > Signed-off-by: Hari Kumar Vemula > Reviewed-by:

Re: [dpdk-dev] [PATCH] compress/isal: fix build with old library version

2019-01-18 Thread Thomas Monjalon
> > This patch removes an unnecessary flag which was breaking the > > build with older versions of the ISA-L library (v2.23 and older) > > and replace with a more appropriate flag which is present > > in older versions of library. > > > > Fixes: bd03d3f1e4f1 ("compress/isal: enable checksum suppor

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications

2019-01-18 Thread Thomas Monjalon
18/01/2019 12:09, Ferruh Yigit: > From: Andy Pei > > Brackets unmatch when __cplusplus defined. > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > Cc: sta...@dpdk.org > > Signed-off-by: Andy Pei > Reviewed-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH v3] raw/ifpga: fix memory leak

2019-01-18 Thread Thomas Monjalon
18/01/2019 12:14, Ferruh Yigit: > From: Andy Pei > > When ifpga_rawdev_create() allocate memory for a new rawdev, > the original code allocate redundant memory for adapter, > which is a member of the rawdev. What is actually necessary is > the adapter to be initialized, not memory allocated. > >

Re: [dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs

2019-01-18 Thread Thomas Monjalon
18/01/2019 12:07, Ferruh Yigit: > From: Andy Pei > > Original driver requires users to input "afu_bts" args. > But driver can also work without an explicit "afu_bts" args. > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > Cc: sta...@dpdk.org > > Signed-off-by: Andy Pei > Acke

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/ifpga: fix ifpga afu driver probe failure handler

2019-01-18 Thread Thomas Monjalon
18/01/2019 12:12, Ferruh Yigit: > From: Andy Pei > > In the original code, when an AFU device probe a driver, > if the first driver in the driver list does not support > this device or some error happens, bus probe returns an error. > > With this patch, a device will try to match driver in the d

Re: [dpdk-dev] [PATCH v4 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-18 Thread Eads, Gage
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, January 17, 2019 11:05 PM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Gavin Hu (Arm Technol

Re: [dpdk-dev] [PATCH v3 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-18 Thread Eads, Gage
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, January 17, 2019 11:28 PM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; nd ; nd > Subject: R

[dpdk-dev] [Bug 193] symmetric_mp example application crashes for Amazon ENA in multiple process mode

2019-01-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=193 Bug ID: 193 Summary: symmetric_mp example application crashes for Amazon ENA in multiple process mode Product: DPDK Version: 18.11 Hardware: x86 OS: Linux

Re: [dpdk-dev] MLX5 QP creation failure - cannot allocate memory

2019-01-18 Thread Yongseok Koh
> On Jan 16, 2019, at 1:07 PM, Amedeo Sapio wrote: > > Hi all, > > I am developing a DPDK program using a Mellanox ConnectX-5 100G. > My program starts N workers (one per core), and each worker deals with its > own dedicated TX and RX queue, therefore I need to setup N TX and N RX > queues. >

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Rasesh Mody
>From: dev On Behalf Of Shahed Shaikh >Sent: Friday, January 18, 2019 2:29 AM > >Allocating replacement buffer per received packet is expensive. >Instead, process received packets first and allocate replacement buffers in >bulk later. > >This improves performance by ~25% in terms of PPS on AMD pla

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-01-18 Thread Shally Verma
HI Fiona, Anoob >-Original Message- >From: Anoob Joseph >Sent: 17 January 2019 19:17 >To: Trahe, Fiona ; Akhil Goyal ; >De Lara Guarch, Pablo > >Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju >Athreya ; Shally Verma >; dev@dpdk.org >Subject: RE: [PATCH] doc: announce ABI change for

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Rasesh Mody
>From: Shahed Shaikh >Sent: Friday, January 18, 2019 8:13 AM > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, January 18, 2019 8:11 PM >> To: Shahed Shaikh ; dev@dpdk.org >> Cc: sta...@dpdk.org; Rasesh Mody ; Thomas >Monjalon >> >> Subject: [EXT] Re: [dpdk-dev] [PATCH 1/2] n

[dpdk-dev] MLX5: Array written to out-of-bounds when freeing memory

2019-01-18 Thread Daniel Pharos
Hi, Recently I had the privilege of some play-time on a IBM Power 9 machine with a Mellanox MLX5-card in it. However, I encountered a seg fault problem using DPDK and DPDK-pktgen. It's the exact same one as somebody else encountered (also on a Power 9) here: https://bugzilla.redhat.com/show_bug

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect place in Tx path

2019-01-18 Thread Rasesh Mody
>From: dev On Behalf Of Shahed Shaikh >Sent: Friday, January 18, 2019 2:30 AM > >Incorrect placement of prefetch in Tx path is causing a performance drop of >around ~2% on AMD platform. > >Fixes: 2ea6f76aff40 ("qede: add core driver") >Cc: sta...@dpdk.org > >Signed-off-by: Shahed Shaikh >--- Ack

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Thomas Monjalon
18/01/2019 17:57, Rasesh Mody: > >From: dev On Behalf Of Shahed Shaikh > >Sent: Friday, January 18, 2019 2:29 AM > > > >Allocating replacement buffer per received packet is expensive. > >Instead, process received packets first and allocate replacement buffers in > >bulk later. > > > >This improves

Re: [dpdk-dev] [PATCH v4 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-18 Thread Eads, Gage
> -Original Message- > From: Eads, Gage > Sent: Friday, January 18, 2019 2:10 PM > To: 'Honnappa Nagarahalli' ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Gavin Hu (Arm Technology China) > ; nd ; nd > Subject: RE:

Re: [dpdk-dev] [PATCH v6 0/5] create different meson test targets

2019-01-18 Thread Thomas Monjalon
18/01/2019 18:40, Hari Kumar Vemula: > v6: Rebased > v5: Renamed test suite names > Removed quit and devargs_autotest from test list > v4: Removed test from file prefix > v3: Updated testcase names in file prefix option > v2: Divided fast-test list into two lists > -- > > Hari Kumar Vemula (5)

Re: [dpdk-dev] [PATCH v4 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-18 Thread Thomas Monjalon
19/01/2019 01:00, Eads, Gage: > > > I am wondering if it makes sense to decouple the NB stack data > > > structure from mempool driver (similar to rte_ring)? I see that stack > > > based mempool implements the stack data structure in the driver. But, > > > NB stack might not be such a trivial data

Re: [dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-18 Thread Wang, Xiao W
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Friday, January 18, 2019 6:25 PM > To: dev@dpdk.org > Cc: Wang, Xiao W ; Zhang, Qi Z > ; qingfu@alibaba-inc.com; tho...@monjalon.net; > Stojaczyk, Dariusz ; sta...@dpdk.org > Subject: [PATCH v2] vfio: allow secondary pro

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

2019-01-18 Thread Yongseok Koh
On Wed, Jan 16, 2019 at 02:02:26AM +, Honnappa Nagarahalli wrote: > > > >> On Wed, 2019-01-09 at 10:22 +, Yongseok Koh wrote: > > > >>> On Jan 9, 2019, at 2:09 AM, Jerin Jacob Kollanukkaran wrote: > > > I think, I way forward is to add > > > config/arm/arm64_a72_li

Re: [dpdk-dev] MLX5: Array written to out-of-bounds when freeing memory

2019-01-18 Thread Yongseok Koh
Appreciate your report. We are aware of the issue and Dekel is investigating it. As I wrote the code, I'm also looking at the issue. Will keep you posted. Thanks, Yongseok > On Jan 18, 2019, at 9:36 AM, Daniel Pharos wrote: > > Hi, > > Recently I had the privilege of some play-time on a IBM Po