On 1/18/2019 10:29 AM, Shahed Shaikh wrote: > Allocating replacement buffer per received packet is expensive. > Instead, process received packets first and allocate > replacement buffers in bulk later. > > This improves performance by ~25% in terms of PPS on AMD > platforms. > > Fixes: 2ea6f76aff40 ("qede: add core driver") > Cc: sta...@dpdk.org > > Signed-off-by: Shahed Shaikh <shsha...@marvell.com>
Hi Shahed, This patch has been sent same day of the RC3, very close to the actual release, and updating data path of the driver, so not a trivial patch. Although I tend to accept driver patches late in process this one was too late, you won't have proper time to fix if any errors detected, but also I can see it has a good amount performance effect. I would like to explicitly ask if you are willing to take the risk. If answer is yes, please also be sure to get Rasesh's ack. Thanks, ferruh