Re: [dpdk-dev] [EXT] [PATCH v1] ticketlock: ticket based to improve fairness

2019-01-14 Thread Jerin Jacob Kollanukkaran
On Sun, 2019-01-13 at 22:46 +0800, Gavin Hu wrote: > --- > --- > From: Joyce Kong > > The spinlock implementation is unfair, some threads may take locks > aggressively while leaving the other threads starving for long time. > As > sh

Re: [dpdk-dev] [EXT] Default cacheline size for ARM

2019-01-14 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-01-14 at 07:47 +, Honnappa Nagarahalli wrote: > > On Sat, 2019-01-05 at 22:47 +, Honnappa Nagarahalli wrote: > > > > On Fri, 2019-01-04 at 19:59 +, Yongseok Koh wrote: > > > > > --- > > > > > > > > > > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-01-14 Thread Jerin Jacob Kollanukkaran
On Fri, 2019-01-11 at 10:45 +, Luca Boccassi wrote: > External Email > > --- > --- > On Mon, 2019-01-07 at 14:11 +, Luca Boccassi wrote: > > When building for generic distribution we need a stable baseline > > architecture, or

Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

2019-01-14 Thread Varghese, Vipin
Hi Qi Z Zhang, snipped > > > > Hi, > > > > Thanks Kevin for redirecting to the maintainer. Appreciate the help. > > > > Thanks Qi Z Zhang for the update. But the reason for request is > > because I did not find the update in patches for 'release notes, faq or > > i40e' > documentation. > > Hence,

[dpdk-dev] [PATCH] net/i40e: fix FPK VF overwrite PF RSS LUT

2019-01-14 Thread Yanglong Wu
i40e_aq_set_rss_lut should set rigister according to the vsi->type. if not, VF may overwrite the rigister of PF Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Cc: sta...@dpdk.org Signed-off-by: Wu Yanglong --- drivers/net/i40e/i40e_ethdev.c | 9 +++-- 1 file changed, 7 insertions

Re: [dpdk-dev] [pull-request] next-crypto 19.02 rc2

2019-01-14 Thread Thomas Monjalon
11/01/2019 18:49, Thomas Monjalon: > 11/01/2019 07:08, Pablo de Lara: > > http://dpdk.org/git/next/dpdk-next-crypto > > "Meson" compilation is not working if IPSec_MB is not installed. This meson issue has been fixed with help of Pablo. Another issue has been fixed in vhost-crypto patches (mo

[dpdk-dev] [PATCH v2] test/hash: reset iter and found in perf test

2019-01-14 Thread Dharmik Thakkar
Reset 'iter' and 'tbl_rw_test_param.found' on each iteration to give correct result for lost and duplicated keys. This patch also changes the default return value of the test to -1 when not enough resources are provided. Fixes: 0eb3726ebcf14 ("test/hash: add test for read/write concurrency") Cc:

[dpdk-dev] mbuf file in BPF test

2019-01-14 Thread Thomas Monjalon
Hi Konstantin, There is an outdated copy of rte_mbuf.h in test/bpf/mbuf.h. It is bringing confusion when grepping code. Would it be possible to remove this file?

[dpdk-dev] [Bug 188] significant multi-core performance degradation with SR-IOV/macswap in some cases

2019-01-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=188 Bug ID: 188 Summary: significant multi-core performance degradation with SR-IOV/macswap in some cases Product: DPDK Version: 19.02 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH 1/2] mbuf: remove deprecated macro

2019-01-14 Thread Thomas Monjalon
14/01/2019 08:40, Andrew Rybchenko: > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > RTE_MBUF_INDIRECT() is replaced with RTE_MBUF_CLONED() and removed. > > This macro was deprecated in release 18.05 when EXT_ATTACHED_MBUF was > > introduced. > > > > Signed-off-by: Yongseok Koh > > Acked-by: Andrew

Re: [dpdk-dev] [EXT] Re: [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-01-14 Thread Luca Boccassi
On Mon, 2019-01-14 at 08:09 +, Jerin Jacob Kollanukkaran wrote: > On Fri, 2019-01-11 at 10:45 +, Luca Boccassi wrote: > > External Email > > > > --- > > --- > > On Mon, 2019-01-07 at 14:11 +, Luca Boccassi wrote: > > > Whe

[dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap

2019-01-14 Thread Yongseok Koh
The pointer is misused and could set wrong MAC address. As a result, some of packets can be dropped in receiver side due to MAC address mismatch. This can be shown as performance degradation. Bugzilla ID: 188 Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86") Cc: qi.z.zh..

[dpdk-dev] [PATCH 2/2] app/testpmd: fix missing prefetch in macswap mode

2019-01-14 Thread Yongseok Koh
Prefetching packet was missing when do_macswap() was optimized. Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86") Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- app/test-pmd/macswap_sse.h | 7 +++ 1 file changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH] ip_pipeline: add QinQ PPPoE encapsulation action

2019-01-14 Thread Marjanovic,Nemanja
Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- examples/ip_pipeline/cli.c | 43 +- lib/librte_net/rte_ether.h | 1 + lib/librte_pipeline/rte_table_action.c | 61 ++ lib/librte_pi

Re: [dpdk-dev] [PATCH v2] app/testpmd: add tos and ttl field to vxlan encapsulation

2019-01-14 Thread Iremonger, Bernard
+Ori, Adrien > -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Monday, January 14, 2019 6:04 AM > To: Slava Ovsiienko ; sha...@mellanox.com; > Yigit, Ferruh ; Lu, Wenzhuo ; > Wu, Jingjing ; Iremonger, Bernard > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC

2019-01-14 Thread Yongseok Koh
> On Jan 13, 2019, at 10:13 PM, Honnappa Nagarahalli > wrote: > > Similarly, the commit heading subject line also needs to change. > >> >>> >>> BlueField is Mellanox's new SoC based on ARMv8. BlueField integrates >>

Re: [dpdk-dev] [PATCH 1/2] vhost: fix memory leak on realloc failure

2019-01-14 Thread Maxime Coquelin
On 1/14/19 4:34 AM, Tiwei Bie wrote: When realloc() fails, the original block isn't freed. Fixes: e246896178e6 ("vhost: get guest/host physical address mappings") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost_user.c | 3 +++ 1 file changed, 3 insertions(+) R

Re: [dpdk-dev] [PATCH 2/2] examples/vhost: fix realloc failure

2019-01-14 Thread Maxime Coquelin
On 1/14/19 4:34 AM, Tiwei Bie wrote: Fixes: ad0eef4d2203 ("examples/vhost: support multiple socket files") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- examples/vhost/main.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Maxime Coquelin Thanks, Maxime

[dpdk-dev] [PATCH v2] ip_pipeline: add QinQ PPPoE encapsulation action

2019-01-14 Thread Marjanovic,Nemanja
Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v2:Fix changes from check patch --- examples/ip_pipeline/cli.c | 43 +- lib/librte_net/rte_ether.h | 1 + lib/librte_pipeline/rte_table_action.c | 61 +

Re: [dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC

2019-01-14 Thread Thomas Monjalon
14/01/2019 11:11, Yongseok Koh: > > On Jan 13, 2019, at 10:13 PM, Honnappa Nagarahalli > > wrote: > > > > Similarly, the commit heading subject line also needs to change. > > > >> > >>> > >>> BlueField is Mellanox's new SoC based on ARMv8. BlueField integrates > >>

Re: [dpdk-dev] [PATCH 3/4] net/enic: support multicast filtering

2019-01-14 Thread Ferruh Yigit
On 1/12/2019 4:49 AM, Hyong Youb Kim wrote: > On Fri, Jan 11, 2019 at 03:46:47PM +, Ferruh Yigit wrote: >> On 12/10/2018 6:28 PM, Hyong Youb Kim wrote: >>> The VIC hardware has 64 MAC filters per vNIC, which can be either >>> unicast or multicast. Use one half for unicast and the other half for

[dpdk-dev] [PATCH v5] eal: fix core number validation

2019-01-14 Thread Hari Kumar Vemula
When incorrect core value or range provided, as part of -l command line option, a crash occurs. Added valid range checks to fix the crash. Added ut check for negative core values. Added unit test case for invalid core number range. Fixes: d888cb8b9613 ("eal: add core list input format") Cc: sta.

Re: [dpdk-dev] [EXT] Re: [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-01-14 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-01-14 at 09:58 +, Luca Boccassi wrote: > On Mon, 2019-01-14 at 08:09 +, Jerin Jacob Kollanukkaran wrote: > > On Fri, 2019-01-11 at 10:45 +, Luca Boccassi wrote: > > > External Email > > > > > > --- > > > > >

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-14 Thread Ferruh Yigit
On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > 11/01/2019 17:42, Ferruh Yigit: >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: >>> The Netronome's Network Flow Processor chip is highly programmable >>> with the goal of processing packets at high speed. Processing units >>> and other chip component

Re: [dpdk-dev] [PATCH v2] ip_pipeline: add QinQ PPPoE encapsulation action

2019-01-14 Thread Dumitrescu, Cristian
Hi Nemanja, > -Original Message- > From: Marjanovic, Nemanja > Sent: Monday, January 14, 2019 10:23 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Dumitrescu, Cristian > ; Marjanovic, Nemanja > > Subject: [PATCH v2] ip_pipeline: add QinQ PPPoE encapsulation action > > Add implementation

Re: [dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC

2019-01-14 Thread Thomas Monjalon
10/01/2019 19:39, Yongseok Koh: > BlueField is Mellanox's new SoC based on ARMv8. BlueField integrates > Mellanox ConnectX-5 interconnect and Cortex-A72 cores into a single device. > > http://www.mellanox.com/page/products_dyn?product_family=256&mtag=soc_overview > > Signed-off-by: Yongseok Koh

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: use static deps of libs for pkg-config libs.private

2019-01-14 Thread Thomas Monjalon
11/01/2019 17:12, Luca Boccassi: > Dependencies of the RTE libraries were not being added to the > Requires.private field of the pc file since the variable used for > dynamic linking was passed to the related field of pkg.generate. > Use the static one so that dependencies are included. > > Fixes:

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix incorrect variable name in error message

2019-01-14 Thread Thomas Monjalon
10/01/2019 14:10, Luca Boccassi: > On Thu, 2019-01-10 at 10:29 +, Bruce Richardson wrote: > > The variable name in the error message had an extra '_' which caused > > an actual meson error when the message would otherwise be printed to > > give meaningful information about what was going wrong.

Re: [dpdk-dev] [EXT] Re: [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-01-14 Thread Luca Boccassi
On Mon, 2019-01-14 at 10:35 +, Jerin Jacob Kollanukkaran wrote: > On Mon, 2019-01-14 at 09:58 +, Luca Boccassi wrote: > > On Mon, 2019-01-14 at 08:09 +, Jerin Jacob Kollanukkaran wrote: > > > On Fri, 2019-01-11 at 10:45 +, Luca Boccassi wrote: > > > > External Email > > > > > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-meson-build: fix check for whether meson has run

2019-01-14 Thread Thomas Monjalon
10/01/2019 14:10, Luca Boccassi: > On Thu, 2019-01-10 at 10:37 +, Bruce Richardson wrote: > > The current check to see whether we need to call meson or just ninja > > simply checked if the build directory existed. However, if meson was > > run > > but failed, the build directory would still exi

[dpdk-dev] [PATCH] build: mention machine=default and its use in documentation

2019-01-14 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- doc/build-sdk-meson.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt index 29a8bd387..2efff58e2 100644 --- a/doc/build-sdk-meson.txt +++ b/doc/build-sdk-meson.txt @@ -87,6 +87,8 @@ Project-specific opti

Re: [dpdk-dev] [PATCH v4 5/5] meson: add cross build targets for thunderx2 and octeontx2

2019-01-14 Thread Thomas Monjalon
09/01/2019 11:39, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Add Thunderx2 and Octeontx2 SoC cross build targets. > meson build --cross-file config/arm/arm64___ > > Signed-off-by: Pavan Nikhilesh > --- > config/arm/arm64_octeontx2_linuxapp_gcc | 14 ++ > config/arm/ar

Re: [dpdk-dev] [PATCH v4 2/5] meson: add infra to support machine specific flags

2019-01-14 Thread Thomas Monjalon
09/01/2019 11:39, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Currently, RTE_* flags are set based on the implementer ID but there might > be some micro arch specific differences from the same vendor > eg. CACHE_LINESIZE. > Add support to set micro arch specific flags. > > Signed-of

Re: [dpdk-dev] [PATCH v4 1/5] mk: introduce helper to check valid compiler argument

2019-01-14 Thread Thomas Monjalon
09/01/2019 11:39, Pavan Nikhilesh Bhagavatula: > From: Jerin Jacob > > Introduce rte_cc_has_argument() Makefile helper to > check a given argument is support by the compiler. > > Example Usage: > > include $(RTE_SDK)/mk/rte.helper.mk > MACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeont

Re: [dpdk-dev] [PATCH] maintainers: resign from maintainership of distributor library

2019-01-14 Thread Thomas Monjalon
11/01/2019 12:48, Bruce Richardson: > The distributor library doesn't see much in the way of changes, and Dave > is well able to manage the library on his own, so remove my name against > it in the MAINTAINERS file. > > Signed-off-by: Bruce Richardson Applied

Re: [dpdk-dev] [PATCH v4] mk: fix scope of disabling AVX512F support

2019-01-14 Thread Thomas Monjalon
Hi, Few details reviewed below, 07/01/2019 17:49, Ferruh Yigit: > --- a/doc/guides/rel_notes/known_issues.rst > +++ b/doc/guides/rel_notes/known_issues.rst > +AVX-512 support disabled > + > + > +**Description**: > + ``AVX-512`` support has been disabled on some conditions

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/5] mk: introduce helper to check valid compiler argument

2019-01-14 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-01-14 at 12:35 +0100, Thomas Monjalon wrote: > --- > --- > 09/01/2019 11:39, Pavan Nikhilesh Bhagavatula: > > From: Jerin Jacob > > > > Introduce rte_cc_has_argument() Makefile helper to > > check a given argument is sup

Re: [dpdk-dev] [PATCH] maintainer: claim maintainership of Hashes

2019-01-14 Thread Thomas Monjalon
09/01/2019 10:14, Bruce Richardson: > On Tue, Jan 08, 2019 at 07:08:34AM -0800, Yipeng Wang wrote: > > Add Yipeng and Sameh as additional maintainers. > > > > Signed-off-by: Yipeng Wang > > Signed-off-by: Sameh Gobriel > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > >

[dpdk-dev] [PATCH] ipsec: fix invalid assert condition

2019-01-14 Thread Konstantin Ananyev
fix invalid RTE_ASSERT condition in rsn_update_finish() Fixes: c0308cd89554 ("ipsec: rework SA replay window/SQN for MT environment") Reported-by: Ferruh Yigit Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/ipsec_sqn.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/5] mk: introduce helper to check valid compiler argument

2019-01-14 Thread Thomas Monjalon
14/01/2019 12:56, Jerin Jacob Kollanukkaran: > On Mon, 2019-01-14 at 12:35 +0100, Thomas Monjalon wrote: > > --- > > --- > > 09/01/2019 11:39, Pavan Nikhilesh Bhagavatula: > > > From: Jerin Jacob > > > > > > Introduce rte_cc_has_argu

Re: [dpdk-dev] [PATCH] net/ice: fix vlan filter Tx issue

2019-01-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Monday, January 14, 2019 9:36 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH] net/ice: fix vlan filter Tx issue > > This patch fixed Tx error and allowed untagged pack

Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer

2019-01-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, December 5, 2018 11:56 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] lib: add warning for NULL pointer > > May return NULL when manage tr

Re: [dpdk-dev] [PATCH] net/i40e: fix FPK VF overwrite PF RSS LUT

2019-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Monday, January 14, 2019 4:24 PM > To: dev@dpdk.org > Cc: Hall, Ryan E ; Zhang, Qi Z ; > Wu, Yanglong ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix FPK VF overwrite PF RSS LUT I think this is not a just for FPK, but for all i40e fam

Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

2019-01-14 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, January 10, 2019 8:08 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Wang, Haiyue > Subject: [PATCH v1] net/i40e: perform basic validation on the VF messages > > Do the VF message basic validation such as OPCODE message length chec

Re: [dpdk-dev] [PATCH v2] examples/ip_fragmentation: support big packets

2019-01-14 Thread Ananyev, Konstantin
> > In some vendors the RX and TX configuration must be the same, therefore > the MTU size need to be equal to max_rx_pkt_len. > The MTU is the largest size packet in bytes that can be sent on the > network, therefore before changing this parameter, the NIC could not > receive packets larger than

Re: [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8

2019-01-14 Thread Thomas Monjalon
19/12/2018 14:47, Ferruh Yigit: > On 12/19/2018 7:07 AM, Xiao Liang wrote: > > 'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8. > > > > Build error log: > > /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct > > net_device_ops’ has no member named ‘ndo_change_mt

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Ferruh Yigit
On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so insted of strcat, strncat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") > Fix

Re: [dpdk-dev] [PATCH] build: mention machine=default and its use in documentation

2019-01-14 Thread Christian Ehrhardt
On Mon, Jan 14, 2019 at 1:23 PM Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > --- > doc/build-sdk-meson.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt > index 29a8bd387..2efff58e2 100644 > --- a/doc/build-sdk-meson.tx

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT

2019-01-14 Thread Thomas Monjalon
21/12/2018 18:02, Ferruh Yigit: > On 12/21/2018 4:27 PM, David Zeng wrote: > > Signed-off-by: David Zeng > > Acked-by: Ferruh Yigit Applied on top of another fix: http://git.dpdk.org/dpdk/commit/?id=4c820b22 and renamed: kni: fix build on RHEL8 for arm and Power9 Thanks

Re: [dpdk-dev] [PATCH] ipsec: fix invalid assert condition

2019-01-14 Thread Ferruh Yigit
On 1/14/2019 12:07 PM, Konstantin Ananyev wrote: > fix invalid RTE_ASSERT condition in rsn_update_finish() > > Fixes: c0308cd89554 ("ipsec: rework SA replay window/SQN for MT environment") > > Reported-by: Ferruh Yigit > Signed-off-by: Konstantin Ananyev Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap

2019-01-14 Thread Iremonger, Bernard
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Monday, January 14, 2019 10:00 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix wrong pointer reference in macsw

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix typo in preprocessor check for macro defined

2019-01-14 Thread Ferruh Yigit
On 1/13/2019 2:50 PM, Andrew Rybchenko wrote: > ISP2() macro function misspelled in a check just before it. > > Fixes: e1b944598579 ("net/sfc: build libefx") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix missing prefetch in macswap mode

2019-01-14 Thread Iremonger, Bernard
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Monday, January 14, 2019 10:00 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH 2/2] app/testpmd: fix missing prefetch in macswap mode

[dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation

2019-01-14 Thread Luca Boccassi
Document the new value, as it's useful for distributions and users who need to use a stable baseline -march Signed-off-by: Luca Boccassi Reviewed-by: Christian Ehrhardt --- v2: fix typo, add commit body and reviewed-by doc/build-sdk-meson.txt | 5 + 1 file changed, 5 insertions(+) diff --

Re: [dpdk-dev] [PATCH] build: mention machine=default and its use in documentation

2019-01-14 Thread Luca Boccassi
On Mon, 2019-01-14 at 15:32 +0200, Christian Ehrhardt wrote: > On Mon, Jan 14, 2019 at 1:23 PM Luca Boccassi > wrote: > > > > Signed-off-by: Luca Boccassi > > --- > >  doc/build-sdk-meson.txt | 5 + > >  1 file changed, 5 insertions(+) > > > > diff --git a/doc/build-sdk-meson.txt b/doc/build

Re: [dpdk-dev] [PATCH] ipsec: fix invalid assert condition

2019-01-14 Thread Thomas Monjalon
14/01/2019 14:37, Ferruh Yigit: > On 1/14/2019 12:07 PM, Konstantin Ananyev wrote: > > fix invalid RTE_ASSERT condition in rsn_update_finish() > > > > Fixes: c0308cd89554 ("ipsec: rework SA replay window/SQN for MT > > environment") > > > > Reported-by: Ferruh Yigit > > Signed-off-by: Konstanti

Re: [dpdk-dev] [PATCH v8] eal_interrupts: add option for pending callback unregister

2019-01-14 Thread Thomas Monjalon
Someone for a review please? 17/12/2018 13:30, Jakub Grajciar: > use case: if callback is used to receive message form socket, > and the message received is disconnect/error, this callback needs > to be unregistered, but cannot because it is still active. > > With this patch it is possible to mar

Re: [dpdk-dev] [PATCH] eal: turn off getopt_long error messages

2019-01-14 Thread Thomas Monjalon
Keith, it seems you missed my questions below: 19/12/2018 21:35, Thomas Monjalon: > 16/12/2018 17:45, Keith Wiles: > > When using dpdk register option api when parsing for log level > > the opterr flags was still set to one causing an error message > > from getopt_long(). Set opterr to zero to dis

Re: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message

2019-01-14 Thread Ferruh Yigit
On 1/11/2019 8:35 PM, Stephen Hemminger wrote: > Printing pointer in log is uninformative (unless in a debugger), > instead print the assigned kernel device name which correlates > well with what TAP is doing. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 0/6] net/tap: fixes and cleanups

2019-01-14 Thread Ferruh Yigit
On 1/11/2019 8:35 PM, Stephen Hemminger wrote: > The tap device (used by vdev_netvsc on Azure) has a bug that > prevents it working with primary/secondary process model because > the device name generation assumed a single process. The fix for > this is to have the kernel assign the device name (p

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

2019-01-14 Thread Thomas Monjalon
10/01/2019 14:38, Anatoly Burakov: > Currently, we use strdup in a few places to store command-line > parameter values for certain internal config values. There are > several issues with that. > > First of all, they're never freed, so memory ends up leaking > either after EAL exit, or when these c

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Bruce Richardson
On Mon, Jan 14, 2019 at 06:04:35AM +, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so insted of strcat, strncat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and

Re: [dpdk-dev] [PATCH] eal/bsdapp: don't clean up files at startup

2019-01-14 Thread Thomas Monjalon
10/01/2019 12:34, Anatoly Burakov: > On FreeBSD, closing the file descriptor drops the lock even if the > file descriptor was mmap'ed. This leads to the cleanup at the end > of EAL init to remove fbarray files that are still in use by the > process itself. > > However, instead of working around th

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-14 Thread Thomas Monjalon
13/01/2019 16:38, Nithin Kumar Dabilpuram: > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > + if (rc >= RTE_MEMZONE_NAMESIZE) { > +

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vfio: don't unregister callback in secondaries

2019-01-14 Thread Thomas Monjalon
10/01/2019 17:33, Anatoly Burakov: > Callbacks are only registered in the primary, so do not attempt to > unregister callbacks in secondary processes. > > Fixes: 43e463137154 ("vfio: support memory event callbacks") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap

2019-01-14 Thread Ferruh Yigit
On 1/14/2019 1:39 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Yongseok Koh [mailto:ys...@mellanox.com] >> Sent: Monday, January 14, 2019 10:00 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org >> Subject: [PATCH

Re: [dpdk-dev] [PATCH] memalloc: fix variable shadowing

2019-01-14 Thread Thomas Monjalon
08/01/2019 17:33, Anatoly Burakov: > A local variable ``flags`` was shadowing another variable from outer > scope. Fix this by renaming the variable and make it const. > > Fixes: c127be93f619 ("mem: support using memfd segments for in-memory mode") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly

Re: [dpdk-dev] [PATCH v5] eal: fix core number validation

2019-01-14 Thread David Marchand
On Mon, Jan 14, 2019 at 11:31 AM Hari Kumar Vemula < hari.kumarx.vem...@intel.com> wrote: > diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c > index 2acab9d69..4dc22ec36 100644 > --- a/test/test/test_eal_flags.c > +++ b/test/test/test_eal_flags.c > @@ -18,6 +18,7 @@ > #include

[dpdk-dev] [PATCH] examples/vhost: fix a typo

2019-01-14 Thread Rami Rosen
This minor patch fixes a typo in examples/vhost/main.c. Fixes: d19533e86f1d ("examples/vhost: copy old vhost example") Signed-off-by: Rami Rosen --- examples/vhost/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index dc9e

Re: [dpdk-dev] [PATCH] memalloc: fix pointer dereferencing

2019-01-14 Thread Thomas Monjalon
08/01/2019 17:46, Anatoly Burakov: > The original code was supposed to overwrite the value pointed to > by the pointer, but the new one is instead overwriting the > pointer value itself, which has no effect outside that function. > Fix it by adding a pointer dereference. > > Fixes: 582bed1e1d1d ("

Re: [dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible

2019-01-14 Thread Olivier Matz
On Fri, Jan 11, 2019 at 02:33:16PM +, Dumitrescu, Cristian wrote: > > > > -Original Message- > > From: Van Haaren, Harry > > Sent: Friday, January 11, 2019 11:33 AM > > To: dev@dpdk.org > > Cc: Van Haaren, Harry ; Pattan, Reshma > > ; Dumitrescu, Cristian > > ; olivier.m...@6wind.com;

[dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

2019-01-14 Thread Hyong Youb Kim
Hyong Youb Kim (2): net/enic: remove useless include net/enic: remove redundant log level check drivers/net/enic/enic_clsf.c | 2 -- drivers/net/enic/enic_ethdev.c | 9 - drivers/net/enic/enic_main.c | 1 - 3 files changed, 4 insertions(+), 8 deletions(-) -- 2.16.2

[dpdk-dev] [PATCH 2/2] net/enic: remove redundant log level check

2019-01-14 Thread Hyong Youb Kim
Fixes: 8d496995346c ("net/enic: support multicast filtering") Cc: sta...@dpdk.org Suggested-by: Ferruh Yigit Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_ethdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net

[dpdk-dev] [PATCH 1/2] net/enic: remove useless include

2019-01-14 Thread Hyong Youb Kim
libgen.h is not used, so do not include it. Fixes: fefed3d1e62c ("enic: new driver") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_clsf.c | 2 -- drivers/net/enic/enic_main.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/enic/enic_clsf.c b/driver

Re: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message

2019-01-14 Thread Wiles, Keith
> On Jan 11, 2019, at 2:35 PM, Stephen Hemminger > wrote: > > Printing pointer in log is uninformative (unless in a debugger), > instead print the assigned kernel device name which correlates > well with what TAP is doing. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth

[dpdk-dev] [PATCH] doc: update description in qat compression guide

2019-01-14 Thread Tomasz Jozwiak
Added limitations description for the QAT compression PMD. Updated intermediate buffers description in qat.rst file. Signed-off-by: Tomasz Jozwiak --- doc/guides/compressdevs/qat_comp.rst | 4 doc/guides/cryptodevs/qat.rst| 6 -- 2 files changed, 8 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH 2/2] mbuf: remove experimental tag of external buffer attachment

2019-01-14 Thread Olivier Matz
On Mon, Jan 14, 2019 at 10:42:21AM +0300, Andrew Rybchenko wrote: > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > Remove the experimental tag of rte_pktmbuf_attach_extbuf() which was > > introduced in 18.05. > > > > Signed-off-by: Yongseok Koh > > Acked-by: Andrew Rybchenko > Acked-by: Olivier

Re: [dpdk-dev] [PATCH 1/2] mbuf: remove deprecated macro

2019-01-14 Thread Olivier Matz
On Mon, Jan 14, 2019 at 10:50:50AM +0100, Thomas Monjalon wrote: > 14/01/2019 08:40, Andrew Rybchenko: > > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > > RTE_MBUF_INDIRECT() is replaced with RTE_MBUF_CLONED() and removed. > > > This macro was deprecated in release 18.05 when EXT_ATTACHED_MBUF was >

Re: [dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible

2019-01-14 Thread Thomas Monjalon
14/01/2019 15:58, Olivier Matz: > On Fri, Jan 11, 2019 at 02:33:16PM +, Dumitrescu, Cristian wrote: > > From: Van Haaren, Harry > > > > > > Although C compilation works with the struct rte_mbuf_sched > > > declared inside the struct rte_mbuf namespace, C++ fails to > > > compile. This fix move

Re: [dpdk-dev] [PATCH] examples/vhost: fix a typo

2019-01-14 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Rami Rosen > Sent: Monday, January 14, 2019 10:48 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; huawei@intel.com; > tiwei@intel.com; Rami Rosen > Subject: [dpdk-dev] [PATCH] examples/vhost: fix a typo > > This minor patch

Re: [dpdk-dev] [PATCH 1/2] mbuf: remove deprecated macro

2019-01-14 Thread Thomas Monjalon
14/01/2019 16:23, Olivier Matz: > On Mon, Jan 14, 2019 at 10:50:50AM +0100, Thomas Monjalon wrote: > > 14/01/2019 08:40, Andrew Rybchenko: > > > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > > > RTE_MBUF_INDIRECT() is replaced with RTE_MBUF_CLONED() and removed. > > > > This macro was deprecated in r

Re: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

2019-01-14 Thread Eads, Gage
From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Sunday, January 13, 2019 6:19 AM To: Eads, Gage ; dev@dpdk.org Cc: olivier.m...@6wind.com; Richardson, Bruce ; Ananyev, Konstantin Subject: Re: [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only) On 1/10/19 11:55 PM, Gage Eads wrote

Re: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

2019-01-14 Thread Eads, Gage
> -Original Message- > From: Varghese, Vipin > Sent: Sunday, January 13, 2019 10:29 PM > To: Andrew Rybchenko ; Eads, Gage > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Richardson, Bruce ; > Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

[dpdk-dev] [PATCH v5] mk: fix scope of disabling AVX512F support

2019-01-14 Thread Ferruh Yigit
AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://g

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-14 Thread Olivier Matz
Hi, On Fri, Jan 11, 2019 at 01:48:12PM +0100, David Marchand wrote: > On Fri, Jan 11, 2019 at 12:57 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > > > On Fri, Jan 11, 2019 at 02:17:04PM +0300, Andrew Rybchenko wrote: > > > Olivier, David, > > > > > > could you take a look at naming

[dpdk-dev] [PATCH] ipsec: fix compilation problem

2019-01-14 Thread Konstantin Ananyev
gcc 6.2 and 6.4 fails to compile lib/librte_ipsec/sa.c with the following errors: /local/kananye1/dpdk.org/lib/librte_ipsec/sa.c: In function âinline_outb_tun_pkt_processâ: dpdk.org/x86_64-native-linuxapp-gcc/include/rte_memcpy.h:337:2: error: array subscript is above array bounds [-Werror=array

Re: [dpdk-dev] [PATCH] doc: update description in qat compression guide

2019-01-14 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Monday, January 14, 2019 3:11 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; De Lara Guarch, Pablo > > Subject: [PATCH] doc: update description in qat compression guide > > Added limitations description for the QAT comp

[dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Ilya Maximets
In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. But 'rte_atomic.h' is a generic header that included to the external apps like OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8 if DPDK built using gcc: include/generic/rte_atomic.h:215:9: error:

Re: [dpdk-dev] [PATCH 2/3] mempool/nb_stack: add non-blocking stack mempool

2019-01-14 Thread Eads, Gage
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Sunday, January 13, 2019 7:31 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Richardson, Bruce ; > Ananyev, Konstantin > Subject: Re: [PATCH 2/3] mempool/nb_stack: add non-blocking

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-14 Thread Stephen Hemminger
On Mon, 14 Jan 2019 13:29:38 + Ferruh Yigit wrote: > On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > > Strcat does not check the destination length and there might be > > chances of string overflow so insted of strcat, strncat is used. > > > > Fixes: 540a211084 ("bnx2x: driver core") >

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Thomas Monjalon
14/01/2019 17:14, Ilya Maximets: > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the > external apps like OVS while building with DPDK. As a result, > clang build of OVS fails on ARMv8 if DPDK built using gcc: > > in

Re: [dpdk-dev] [PATCH v5] mk: fix scope of disabling AVX512F support

2019-01-14 Thread Thomas Monjalon
14/01/2019 16:49, Ferruh Yigit: > AVX512 was disabled for GCC because of Bugzilla issue 97 [1], > the GCC defect submitted for the issue [2] highlighted that this is > a known binutils version 2.30 issue. > > Narrowed the scope of no-avx512 to the this specific binutils version. > > [1] > https:/

Re: [dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

2019-01-14 Thread Ferruh Yigit
On 1/14/2019 3:01 PM, Hyong Youb Kim wrote: > Hyong Youb Kim (2): > net/enic: remove useless include > net/enic: remove redundant log level check Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya Maximets > Sent: Monday, January 14, 2019 4:15 PM > To: dev@dpdk.org; Thomas Monjalon > Cc: Pavan Nikhilesh ; Ilya Maximets > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix build of external apps w

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Honnappa Nagarahalli
> > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the external apps like > OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8

Re: [dpdk-dev] [EXT] [PATCH v1] ticketlock: ticket based to improve fairness

2019-01-14 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, January 14, 2019 4:00 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: step...@networkplumber.org; Honnappa Nagarahalli > ; tho...@monjalon.net; nd > ; Joyce Kong (Arm Technology China) > ; hemant.agra.

Re: [dpdk-dev] [EXT] [PATCH v3 5/6] spinlock: reimplement with atomic one-way barrier builtins

2019-01-14 Thread Gavin Hu (Arm Technology China)
> > > > > *sl); static > > > > > inline void rte_spinlock_lock(rte_spinlock_t *sl) { > > > > > - while (__sync_lock_test_and_set(&sl->locked, 1)) > > > > > - while(sl->locked) > > > > > + int exp = 0; > > > > > + > > > > > + while (!__atomic_compare_exchange_n(&sl->locked

Re: [dpdk-dev] TX unable to enqueue packets to NIC due to no free TX descriptor

2019-01-14 Thread Soni, Shivam
I doubled the mempool size to 65535 but the issue is not resolved. On 1/11/19, 4:27 PM, "dev on behalf of Soni, Shivam" wrote: Hi Stephen, Thanks for the reply. Our mbuf pool is big enough. We have 2 RX cores, 2 TX cores and 8 worker cores. NTxd and NRxd is 1024 each

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-14 Thread Alejandro Lucero
On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit wrote: > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > 11/01/2019 17:42, Ferruh Yigit: > >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > >>> The Netronome's Network Flow Processor chip is highly programmable > >>> with the goal of processing pac

[dpdk-dev] [PATCH] config: remove NFP PMD from 32-bits builds

2019-01-14 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- config/defconfig_i686-native-linuxapp-gcc| 5 + config/defconfig_i686-native-linuxapp-icc| 5 + config/defconfig_x86_x32-native-linuxapp-gcc | 5 + 3 files changed, 15 insertions(+) diff --git a/config/defconfig_i686-native-linuxapp-gcc b/

  1   2   >