> On Jan 11, 2019, at 2:35 PM, Stephen Hemminger <step...@networkplumber.org>
> wrote:
>
> Printing pointer in log is uninformative (unless in a debugger),
> instead print the assigned kernel device name which correlates
> well with what TAP is doing.
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 705c90dadee5..586c8a952df9 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -853,6 +853,8 @@ tap_dev_stop(struct rte_eth_dev *dev)
> static int
> tap_dev_configure(struct rte_eth_dev *dev)
> {
> + struct pmd_internals *pmd = dev->data->dev_private;
> +
> if (dev->data->nb_rx_queues > RTE_PMD_TAP_MAX_QUEUES) {
> TAP_LOG(ERR,
> "%s: number of rx queues %d exceeds max num of queues
> %d",
> @@ -870,11 +872,11 @@ tap_dev_configure(struct rte_eth_dev *dev)
> return -1;
> }
>
> - TAP_LOG(INFO, "%s: %p: TX configured queues number: %u",
> - dev->device->name, (void *)dev, dev->data->nb_tx_queues);
> + TAP_LOG(INFO, "%s: %s: TX configured queues number: %u",
> + dev->device->name, pmd->name, dev->data->nb_tx_queues);
>
> - TAP_LOG(INFO, "%s: %p: RX configured queues number: %u",
> - dev->device->name, (void *)dev, dev->data->nb_rx_queues);
> + TAP_LOG(INFO, "%s: %s: RX configured queues number: %u",
> + dev->device->name, pmd->name, dev->data->nb_rx_queues);
Acked-by: Keith Wiles <keith.wi...@intel.com>
>
> return 0;
> }
> --
> 2.20.1
>
Regards,
Keith
