Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide

> -Original Message- > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, January 10, 2019 5:32 AM > To: Ananyev, Konstantin ; Stephen > Hemminger ; Hu, Jiayu > > Cc: dev@dpdk.org; tho...@monjalon.net; Varghese, Vipin > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v3 2/3] net/virtio: update memory ordering comment for vq notify

> -Original Message- > From: dev On Behalf Of Ilya Maximets > Sent: Wednesday, January 9, 2019 10:50 PM > To: dev@dpdk.org; Maxime Coquelin ; > Michael S . Tsirkin ; Xiao Wang > > Cc: Tiwei Bie ; Zhihong Wang > ; jfreim...@redhat.com; Jason Wang > ; xiaolong...@intel.com; > alejandro.lu

Re: [dpdk-dev] [RFC] function to parse packet headers

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > long...@viettel.com.vn > > Also for the bulk API, another option would be passing in a `uint64_t > malformed_mask` and let the bulk function set the correspond bit (1 << > pos) of that mask if the packet at position pos is malformed. > > vo

Re: [dpdk-dev] [PATCH v4 0/2] lib/librte_meter: add RFC4115 trTCM meter support

Thanks Thomas! On 10 Jan 2019, at 0:22, Thomas Monjalon wrote: > 07/01/2019 16:58, Dumitrescu, Cristian: >> From: Eelco Chaudron [mailto:echau...@redhat.com] >>> >>> This patch adds support for RFC4115 trTCM meters. >>> >>> >>> Signed-off-by: Eelco Chaudron >>> >>> v4: >>> - Fixed typo >>> - C

Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hu, Jiayu > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > > Konstantin > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > > > > > > O

Re: [dpdk-dev] [PATCH v6 10/10] doc: add IPsec library guide

03/01/2019 21:16, Konstantin Ananyev: > Add IPsec library guide and update release notes. > > Signed-off-by: Bernard Iremonger > Signed-off-by: Konstantin Ananyev > --- > doc/guides/prog_guide/index.rst| 1 + > doc/guides/prog_guide/ipsec_lib.rst| 168 + >

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

10/01/2019 04:08, Varghese, Vipin: > snipped > > > > Hi Vipin, > > > > The code split in this v8 looks really better, except this patch which > > makes no > > sense alone. > Hi Thomas, I need this base patch as first one. These include the helper > MACRO and include which pans out for next 7 pa

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: 09/01/2019 21:51, Bruce Richardson: On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov <[1]anatoly.bura...@intel.com> wrote: Currently, while EAL does depend on librte_compat

Re: [dpdk-dev] [PATCH] virtio-user: ctrl vq support for packed

Hi Jens, On 1/9/19 5:59 PM, Jens Freimann wrote: Add support to virtio-user for control virtqueues and reverts commit "5e4e7a752 net/virtio-user: fail if cq used with packed vq". I would prefer you send two patches: 1. add ctrl vq support 2. revert 5e4e7a752 Signed-off-by: Jens Freimann -

Re: [dpdk-dev] DPDK on IBM Power9

On 09-Jan-19 10:25 PM, Daniel Waddington wrote: Hi, I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to DPDK on Power). Thx, Daniel Below is what I get: $ sudo ./examples/ethtool/ethtool-app/ppc_64-power8-linuxapp-gcc/app/ethtool --iova-mode=pa -c7 -w :01:00.0 EAL: D

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

10/01/2019 09:45, Burakov, Anatoly: > On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > > 09/01/2019 21:51, Bruce Richardson: > >> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > >>> On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov > >>> <[1]anatoly.bura...@intel.com> wrote: >

[dpdk-dev] [PATCH] crypto/octeontx: remove usage of DEPDIRS

DEPDIRS is no longer used in DPDK driver makefiles. Removing it. Suggested-by: Ferruh Yigit Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/Makefile | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/crypto/octeontx/Makefile b/drivers/crypto/octeontx/Makefile index 2e78e6

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

Hi Thomas, snipped > > 10/01/2019 04:08, Varghese, Vipin: > > snipped > > > > > > Hi Vipin, > > > > > > The code split in this v8 looks really better, except this patch > > > which makes no sense alone. > > Hi Thomas, I need this base patch as first one. These include the helper > MACRO and inclu

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

10/01/2019 09:53, Varghese, Vipin: > Hi Thomas, > > snipped > > > > 10/01/2019 04:08, Varghese, Vipin: > > > snipped > > > > > > > > Hi Vipin, > > > > > > > > The code split in this v8 looks really better, except this patch > > > > which makes no sense alone. > > > Hi Thomas, I need this base pat

Re: [dpdk-dev] [PATCH] virtio-user: ctrl vq support for packed

On Thu, Jan 10, 2019 at 09:46:37AM +0100, Maxime Coquelin wrote: Hi Jens, On 1/9/19 5:59 PM, Jens Freimann wrote: Add support to virtio-user for control virtqueues and reverts commit "5e4e7a752 net/virtio-user: fail if cq used with packed vq". I would prefer you send two patches: 1. add ctrl

Re: [dpdk-dev] [PATCH v3 2/3] net/virtio: update memory ordering comment for vq notify

Hi Gavin, On 1/10/19 9:19 AM, Gavin Hu (Arm Technology China) wrote: -Original Message- From: dev On Behalf Of Ilya Maximets Sent: Wednesday, January 9, 2019 10:50 PM To: dev@dpdk.org; Maxime Coquelin ; Michael S . Tsirkin ; Xiao Wang Cc: Tiwei Bie ; Zhihong Wang ; jfreim...@redhat.

Re: [dpdk-dev] [EXT] [PATCH v3] devtools: fix wrong headline lowercase for arm

27/12/2018 13:34, Jerin Jacob Kollanukkaran: > On Fri, 2018-12-21 at 14:02 +0800, Gavin Hu wrote: > > Change to the new wording according to Arm corp: > > https://mails.dpdk.org/archives/dev/2018-October/115174.html > > otherwise, "Wrong headline lowercase" may be falsely reported. > > > > Fixes:

Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair configure structure

> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v4 01/12] cryptodev: change queue pair configure structure > > This patch changes the cryptodev

Re: [dpdk-dev] [PATCH v3 2/3] net/virtio: update memory ordering comment for vq notify

On 10.01.2019 12:18, Maxime Coquelin wrote: > Hi Gavin, > > On 1/10/19 9:19 AM, Gavin Hu (Arm Technology China) wrote: >> >> >>> -Original Message- >>> From: dev On Behalf Of Ilya Maximets >>> Sent: Wednesday, January 9, 2019 10:50 PM >>> To: dev@dpdk.org; Maxime Coquelin ; >>> Michael S

Re: [dpdk-dev] [PATCH 20/20] bus/fslmc: add function to map any addr via VFIO

Hello Ferruh, Replying on behalf of Hemant... On 08/01/19 7:40 PM, Ferruh Yigit wrote: > On 12/27/2018 6:23 AM, Hemant Agrawal wrote: >> From: Pankaj Chauhan >> >> This is required to map any accelerator memory >> and PCI address to VFIO using QDMA. >> >> Signed-off-by: Minghuan Lian >> Signed-

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Thu, Jan 10, 2019 at 09:52:43AM +0100, Thomas Monjalon wrote: > 10/01/2019 09:45, Burakov, Anatoly: > > On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > > > 09/01/2019 21:51, Bruce Richardson: > > >> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > > >>> On Wed, Jan 9, 2019 at

Re: [dpdk-dev] [PATCH v3] eal: fix core number validation

Hello Hari, On Mon, Jan 7, 2019 at 11:26 AM Hari Kumar Vemula < hari.kumarx.vem...@intel.com> wrote: > When incorrect core value or range provided, > as part of -l command line option, a crash occurs. > > Added valid range checks to fix the crash. > > Added ut check for negative core values. > Ad

[dpdk-dev] [PATCH 0/2] net/bonding: a couple minor fixes

A couple patches for minor issues found during in-house testing. I do not have a strong opinion on the first one, as it is just a warning message not technically a bug. But, the second one addresses an easy-to-reproduce crash. If someone has a better/cleaner fix, I am all ears. Hyong Youb Kim (2):

[dpdk-dev] [PATCH 1/2] net/bonding: do not set promisc on non-existent primary port

For active-backup, tlb, and alb mode, bond_ethdev_promiscuous_{enable,disable} tries to set promisc mode on the primary port, even when there are no slaves. It is harmless, as rte_eth_promiscuous_{enable,disable} does nothing if the port number is invalid. But, it does print a warning message. Here

[dpdk-dev] [PATCH 2/2] net/bonding: avoid the next active slave going out of bound

For bonding modes like broadcast that use bond_ethdev_rx_burst(), it is fairly easy to produce a crash simply by bringing a slave port's link down. When slave links go down, the driver on one thread reduces active_slave_count via the LSC callback and deactivate_slave(). At the same time, bond_ethde

[dpdk-dev] [PATCH] build: fix incorrect variable name in error message

The variable name in the error message had an extra '_' which caused an actual meson error when the message would otherwise be printed to give meaningful information about what was going wrong. Fixes: 203b61dc5e18 ("build: improve error message for missing dependency") CC: sta...@dpdk.org Signed-

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

10/01/2019 11:02, Bruce Richardson: > On Thu, Jan 10, 2019 at 09:52:43AM +0100, Thomas Monjalon wrote: > > 10/01/2019 09:45, Burakov, Anatoly: > > > On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > > > > 09/01/2019 21:51, Bruce Richardson: > > > >> One other point I'd make is that having compat as a

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On 10-Jan-19 10:02 AM, Bruce Richardson wrote: On Thu, Jan 10, 2019 at 09:52:43AM +0100, Thomas Monjalon wrote: 10/01/2019 09:45, Burakov, Anatoly: On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: 09/01/2019 21:51, Bruce Richardson: On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote:

[dpdk-dev] [PATCH] test-meson-build: fix check for whether meson has run

The current check to see whether we need to call meson or just ninja simply checked if the build directory existed. However, if meson was run but failed, the build directory would still exist. We can fix this by instead checking for the build.ninja file inside the directory. Once that is present, w

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Thu, Jan 10, 2019 at 10:34:19AM +, Burakov, Anatoly wrote: > On 10-Jan-19 10:02 AM, Bruce Richardson wrote: > > On Thu, Jan 10, 2019 at 09:52:43AM +0100, Thomas Monjalon wrote: > > > 10/01/2019 09:45, Burakov, Anatoly: > > > > On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > > > > > 09/01/2019

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Thu, Jan 10, 2019 at 10:34:19AM +, Burakov, Anatoly wrote: > > On 10-Jan-19 10:02 AM, Bruce Richardson wrote: > > > I also forgot that. However, that does bring up the thought that for > some > > > of o

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Thu, Jan 10, 2019 at 11:44:07AM +0100, David Marchand wrote: >On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Thu, Jan 10, 2019 at 10:34:19AM +, Burakov, Anatoly wrote: > > On 10-Jan-19 10:02 AM, Bruce Richardson wrote: >

[dpdk-dev] [Bug 185] PVP zero-loss performance degradation without --legacy-mem

https://bugs.dpdk.org/show_bug.cgi?id=185 Bug ID: 185 Summary: PVP zero-loss performance degradation without --legacy-mem Product: DPDK Version: 18.05 Hardware: All OS: All Status: CONFIRMED

[dpdk-dev] [Bug 186] Huge testpmd startup time without --legacy-mem option

https://bugs.dpdk.org/show_bug.cgi?id=186 Bug ID: 186 Summary: Huge testpmd startup time without --legacy-mem option Product: DPDK Version: 18.05 Hardware: All OS: All Status: CONFIRMED Severity: normal

[dpdk-dev] [PATCH] compat: merge compat library into EAL

Since compat library is only a single header, we can easily move it into the EAL common headers instead of tracking it separately. The downside of this is that it becomes a little more difficult to have any libs that are built before EAL depend on it. Thankfully, this is not the case, so there are

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Thu, Jan 10, 2019 at 10:48:39AM +, Bruce Richardson wrote: > On Thu, Jan 10, 2019 at 11:44:07AM +0100, David Marchand wrote: > >On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson > ><[1]bruce.richard...@intel.com> wrote: > > > > On Thu, Jan 10, 2019 at 10:34:19AM +, Burakov,

Re: [dpdk-dev] [PATCH v4 02/12] cryptodev: add sym session mempool create

> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v4 02/12] cryptodev: add sym session mempool create > > This patch adds a new API "rte_cryptode

Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair configure structure

Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, January 10, 2019 9:47 AM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: Re: [dpdk-dev] [PATCH v4 01/12] cryptodev: change queue

Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL

On 10-Jan-19 11:11 AM, Bruce Richardson wrote: Since compat library is only a single header, we can easily move it into the EAL common headers instead of tracking it separately. The downside of this is that it becomes a little more difficult to have any libs that are built before EAL depend on it

[dpdk-dev] [PATCH] eal/bsdapp: don't clean up files at startup

On FreeBSD, closing the file descriptor drops the lock even if the file descriptor was mmap'ed. This leads to the cleanup at the end of EAL init to remove fbarray files that are still in use by the process itself. However, instead of working around this issue, we can take advantage of the fact tha

[dpdk-dev] [PATCH v2] net/softnic: add support for service cores

Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- Changes in V2: -fixed compilation for some 32-bit targets by removing the need for function pointer conversion drivers/net/softnic/rte_eth_softnic.c | 11 ++ drivers/net/softnic/rte_eth_softnic.h | 20 +++ .

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On Wed, Jan 9, 2019 at 4:15 PM Ferruh Yigit wrote: > On 1/9/2019 2:20 PM, Alejandro Lucero wrote: > > > > > > On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit > > wrote: > > > > On 1/3/2019 8:56 AM, Alejandro Lucero wrote: > > > The Netronome's Network Flow Pro

Re: [dpdk-dev] [PATCH] net/ice: fix firmware-version in the drvinfo result of ethtool

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong > Sent: Thursday, January 10, 2019 1:22 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH] net/ice: fix firmware-version in the drvinfo > result > of e

[dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

Do the VF message basic validation such as OPCODE message length check, some special OPCODE message format check, to protect the i40e PMD from malicious VF message attack. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_pf.c | 25 +

Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL

On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson < bruce.richard...@intel.com> wrote: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have an

Re: [dpdk-dev] [PATCH v4 11/12] cryptodev: add reference count to session private data

> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v4 11/12] cryptodev: add reference count to session private > data > > This patch adds a refcnt

[dpdk-dev] [PATCH] app/testpmd: initialize WRED profile packet mode from cli

Add struct rte_tm_wred_params::packet_mode to the "add port tm node wred profile" cli command. Fixes: 2fcf2f104fa2 ("ethdev: support WRED thresholds in bytes") Cc: sta...@dpdk.org Signed-off-by: Nikhil Rao --- app/test-pmd/cmdline_tm.c | 8 doc/guides/testpmd_app_ug/t

Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL

On Thu, Jan 10, 2019 at 1:28 PM David Marchand wrote: > > > On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > >> Since compat library is only a single header, we can easily move it into >> the EAL common headers instead of tracking it separately. The downs

Re: [dpdk-dev] [PATCH v4 09/12] cryptodev: update symmetric session structure

> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v4 09/12] cryptodev: update symmetric session structure > > This patch updates the rte_cryptode

Re: [dpdk-dev] [RFC v1 00/11] scapy/python extension

Hi Xueming, I was wondering if this patch went anywhere, could not find anything in the list archive? I like the idea, as it’s useful for quick unit testing, without relying on Trex or trafgen. Cheers, Eelco quick guide document: https://github.com/steevenlee/dpdk/blob/master_scapy/doc/

Re: [dpdk-dev] [PATCH] test-meson-build: fix check for whether meson has run

On Thu, 2019-01-10 at 10:37 +, Bruce Richardson wrote: > The current check to see whether we need to call meson or just ninja > simply checked if the build directory existed. However, if meson was > run > but failed, the build directory would still exist. We can fix this by > instead checking f

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix incorrect variable name in error message

On Thu, 2019-01-10 at 10:29 +, Bruce Richardson wrote: > The variable name in the error message had an extra '_' which caused > an actual meson error when the message would otherwise be printed to > give meaningful information about what was going wrong. > > Fixes: 203b61dc5e18 ("build: improv

[dpdk-dev] [PATCH v2 2/2] Revert "net/virtio-user: fail if cq used with packed vq"

This reverts commit 5e4e7a7524a30c176bd6b1789ab30963f27f2681. Not a clean revert, I had to resolve a conflict due to 616ea5519 net/virtio-user: fix packed vq option parsing Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 11 +++ 1 file changed, 3 in

[dpdk-dev] [PATCH v2 1/2] net/virtio-user: ctrl vq support for packed

Add support to virtio-user for control virtqueues. Signed-off-by: Jens Freimann --- .../net/virtio/virtio_user/virtio_user_dev.c | 92 ++- .../net/virtio/virtio_user/virtio_user_dev.h | 8 +- drivers/net/virtio/virtio_user_ethdev.c | 49 +- 3 files changed, 141 i

[dpdk-dev] [PATCH v2 0/2] net/virtio-user: add packed vq support

Revert patch to error out when cq is used with packed vq and in second patch add support for packed virtqueues in control virtqueue code. v1->v2: * split into two patches * handle ring wrap correctly * add to unsupported_features when packed_vq is 0 Jens Freimann (2): net/virtio-user: ctrl

Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL

On Thu, Jan 10, 2019 at 01:53:20PM +0100, David Marchand wrote: >On Thu, Jan 10, 2019 at 1:28 PM David Marchand ><[1]david.march...@redhat.com> wrote: > >On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson ><[2]bruce.richard...@intel.com> wrote: > > Since compat library is only

Re: [dpdk-dev] [PATCH] compat: merge compat library into EAL

On Thu, Jan 10, 2019 at 11:31:31AM +, Burakov, Anatoly wrote: > On 10-Jan-19 11:11 AM, Bruce Richardson wrote: > > Since compat library is only a single header, we can easily move it into > > the EAL common headers instead of tracking it separately. The downside of > > this is that it becomes a

[dpdk-dev] [PATCH v3] net/softnic: add support for service cores

Add support to run the Soft NIC device on service cores, based on the value of the sc parameter: 0: The current Soft NIC device is run explicitly by the application. The firmware creates one or several pipelines for this dev and maps them to CPU cores that should not be service cores. The ap

Re: [dpdk-dev] [PATCH v4 08/12] cryptodev: add sym session header size API

> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH v4 08/12] cryptodev: add sym session header size API > > This patch adds a new API in Cryptodev

[dpdk-dev] [PATCH] eal: fix strdup usages in internal config

Currently, we use strdup in a few places to store command-line parameter values for certain internal config values. There are several issues with that. First of all, they're never freed, so memory ends up leaking either after EAL exit, or when these command-line options are supplied multiple times

[dpdk-dev] [PATCH v2] compat: merge compat library into EAL

Since compat library is only a single header, we can easily move it into the EAL common headers instead of tracking it separately. The downside of this is that it becomes a little more difficult to have any libs that are built before EAL depend on it. Thankfully, this is not a major problem as the

Re: [dpdk-dev] [PATCH v2] compat: merge compat library into EAL

On Thu, Jan 10, 2019 at 2:48 PM Bruce Richardson wrote: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before

Re: [dpdk-dev] [PATCH v2] compat: merge compat library into EAL

On 10-Jan-19 1:47 PM, Bruce Richardson wrote: Since compat library is only a single header, we can easily move it into the EAL common headers instead of tracking it separately. The downside of this is that it becomes a little more difficult to have any libs that are built before EAL depend on it.

Re: [dpdk-dev] [PATCH v2] compat: merge compat library into EAL

On Thu, Jan 10, 2019 at 02:57:41PM +0100, David Marchand wrote: >On Thu, Jan 10, 2019 at 2:48 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > Since compat library is only a single header, we can easily move it > into > the EAL common headers instead of tracki

Re: [dpdk-dev] [PATCH v2] compat: merge compat library into EAL

On 10-Jan-19 1:47 PM, Bruce Richardson wrote: Since compat library is only a single header, we can easily move it into the EAL common headers instead of tracking it separately. The downside of this is that it becomes a little more difficult to have any libs that are built before EAL depend on it.

Re: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, January 9, 2019 10:32 PM > To: Trahe, Fiona ; Zhang, Roy Fan > ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Nowak, DamianX ; > Krakowiak, LukaszX > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v7 00/10] ipsec: new library for IPsec data-path processing

v6 -> v7 - Changes to address Thomas comments: bump ABI version remove related deprecation notice update release notes, ABI changes section v5 -> v6 - Fix issues reported by Akhil: rte_ipsec_session_prepare() fails for lookaside-proto v4 -> v5 - Fix issue with SQN overflows -

[dpdk-dev] [PATCH v7 01/10] cryptodev: add opaque userdata pointer into crypto sym session

Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Fiona Trahe Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- do

[dpdk-dev] [PATCH v7 02/10] security: add opaque userdata pointer into security session

Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecati

[dpdk-dev] [PATCH v7 04/10] lib: introduce ipsec library

Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v7 03/10] net: add ESP trailer structure definition

define esp_tail structure. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_es

[dpdk-dev] [PATCH v7 05/10] ipsec: add SA data-path API

Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH v7 06/10] ipsec: implement SA data-path API

Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH v7 08/10] ipsec: helper functions to group completed crypto-ops

Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev Acked-by: Declan Doherty --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_i

[dpdk-dev] [PATCH v7 07/10] ipsec: rework SA replay window/SQN for MT environment

With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH v7 09/10] test/ipsec: introduce functional test

Create functional test for librte_ipsec. Note that the test requires null crypto pmd to pass successfully. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Acked-by: Declan Doherty Signed-off-by: Konstantin Ananyev --- test/test/Makefile |3 + test/test/meson.build

Re: [dpdk-dev] [PATCH v2 1/2] net/virtio-user: ctrl vq support for packed

On 1/10/19 2:17 PM, Jens Freimann wrote: Add support to virtio-user for control virtqueues. Signed-off-by: Jens Freimann --- .../net/virtio/virtio_user/virtio_user_dev.c | 92 ++- .../net/virtio/virtio_user/virtio_user_dev.h | 8 +- drivers/net/virtio/virtio_user_ethde

[dpdk-dev] [PATCH v7 10/10] doc: add IPsec library guide

Add IPsec library guide and update release notes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/ipsec_lib.rst| 168 + doc/guides/rel_notes/release_19_02.rst | 11 ++ 3 fil

Re: [dpdk-dev] [PATCH v2 2/2] Revert "net/virtio-user: fail if cq used with packed vq"

On 1/10/19 2:17 PM, Jens Freimann wrote: This reverts commit 5e4e7a7524a30c176bd6b1789ab30963f27f2681. Not a clean revert, I had to resolve a conflict due to 616ea5519 net/virtio-user: fix packed vq option parsing Maybe good to explain why it can be reverted now. Signed-off-by: Jens F

Re: [dpdk-dev] [PATCH v7 00/10] ipsec: new library for IPsec data-path processing

10/01/2019 15:20, Konstantin Ananyev: > v6 -> v7 > - Changes to address Thomas comments: > bump ABI version > remove related deprecation notice > update release notes, ABI changes section You did not update the lib versions in the release notes. I think you missed a deprecation notice

Re: [dpdk-dev] [PATCH v3 1/3] net/virtio: add missing barrier before reading the flags

On 1/9/19 3:50 PM, Ilya Maximets wrote: Reading the used->flags could be reordered with avail->idx update. vhost in kernel disables notifications for the time of packets receiving, like this: 1. disable notify 2. process packets 3. enable notify 4. has more packets ? goto

Re: [dpdk-dev] [PATCH v3 2/3] net/virtio: update memory ordering comment for vq notify

On 1/9/19 3:50 PM, Ilya Maximets wrote: We're not using io ports in case of modern device even on IA. Also, this comment useless for other architectures. Signed-off-by: Ilya Maximets --- drivers/net/virtio/virtqueue.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) Review

Re: [dpdk-dev] [PATCH v3 3/3] net/virtio: add platform memory ordering feature support

On 1/9/19 3:50 PM, Ilya Maximets wrote: VIRTIO_F_ORDER_PLATFORM is required to use proper memory barriers in case of HW vhost implementations like vDPA. DMA barriers (rte_cio_*) are sufficent for that purpose. Previously known as VIRTIO_F_IO_BARRIER. Signed-off-by: Ilya Maximets --- drive

Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

On 1/9/19 3:57 PM, Rami Rosen wrote: This cleanup patch removes a method and a constant which are now unnecessary in the VHOST sample applicaiopn, namely the s/applicaiopn/application/ validate_num_devices() method and the MAX_DEVICES constant. Fixes: 56fe86f8dcaf ("examples/vhost: embed

Re: [dpdk-dev] [PATCH v7 00/10] ipsec: new library for IPsec data-path processing

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 10, 2019 2:25 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: Re: [PATCH v7 00/10] ipsec: new library for IPsec data-pat

Re: [dpdk-dev] [PATCH v2 2/2] Revert "net/virtio-user: fail if cq used with packed vq"

On Thu, Jan 10, 2019 at 02:17:51PM +0100, Jens Freimann wrote: > This reverts commit 5e4e7a7524a30c176bd6b1789ab30963f27f2681. > > Not a clean revert, I had to resolve a conflict due to > 616ea5519 net/virtio-user: fix packed vq option parsing > > Signed-off-by: Jens Freimann > --- > drivers/

Re: [dpdk-dev] [PATCH] vhostuser: fix deadlock when vhost unregister

Hi Sunwenjie, Thanks for your patch. Please resend with following contribution guidelines, that can be found in doc/guides/contributing/. First, the commit message prefix should be vhost. For other comments, please see inline: On 1/8/19 12:45 PM, sunwenjie wrote: When rte_vhost_driver_unre

[dpdk-dev] [PATCH v5 00/12] cryptodev: change qp conf and sym session

This patchset changes the queue pair configure structure and sym session structure for cryptodev. An RFC patch http://patchwork.dpdk.org/patch/43883/ has been sent to state the change. The patchset also includes two added APIs for creating symmetric session mempool and getting the session header d

[dpdk-dev] [PATCH v5 01/12] cryptodev: change queue pair configure structure

This patch changes the cryptodev queue pair configure structure to enable two mempool passed into cryptodev PMD simutaneously. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- app/test-crypto-perf/main.c| 6 ++-- doc/guides/prog_guide/cryptodev_lib.rst| 19

[dpdk-dev] [PATCH v5 02/12] cryptodev: add sym session mempool create

This patch adds a new API "rte_cryptodev_sym_session_pool_create()" to cryptodev library. All applications are required to use this API to create sym session mempool as it adds private data and nb_drivers information to the mempool private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe ---

[dpdk-dev] [PATCH v5 03/12] app/test-crypto-perf: use separate session mempools

This patch uses the two session mempool approach to crypto perf application. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- app/test-crypto-perf/cperf.h | 1 + app/test-crypto-perf/cp

[dpdk-dev] [PATCH v5 05/12] examples: use separate session mempools

This patch uses the two session mempool approach to all cryptodev sample applications. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- examples/fips_validation/main.c | 34 +- exam

[dpdk-dev] [PATCH v5 04/12] net/softnic: use separate session mempools

This patch uses the two session mempool approach to softnic PMD. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- drivers/net/softnic/rte_eth_softnic_cli.c | 52 - drivers/net/s

[dpdk-dev] [PATCH v5 07/12] test/crypto: use separate session mempools

This patch uses the two session mempool approach to crypto unit test. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- test/test/test_cryptodev.c | 229 - test/tes

[dpdk-dev] [PATCH v5 06/12] vhost/crypto: use separate session mempools

This patch uses the two session mempool approach to vhost crypto. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- lib/librte_vhost/rte_vhost_crypto.h | 9 ++--- lib/librte_vhost/vhost_crypto.c | 8 +

[dpdk-dev] [PATCH v5 08/12] cryptodev: add sym session header size API

This patch adds a new API in Cryptodev Framework. The API is used to get the header size for the created symmetric Cryptodev session. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- drivers/crypto/aesni_gcm/Makefile | 1 + drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 3 ++-

[dpdk-dev] [PATCH v5 09/12] cryptodev: update symmetric session structure

This patch updates the rte_cryptodev_sym_session structure for cryptodev library. The updates include a changed session private data array and an added nb_drivers field. They are used to calculate the correct session header size and ensure safe access of the session private data. Signed-off-by: Fa

[dpdk-dev] [PATCH v5 10/12] cryptodev: add user data size to symmetric session

This patch adds a user_data_sz field to cryptodev symmetric session. The field is used to check if reading or writing the session's user data field is eligible. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_guide/cryptodev_lib.rst | 4 + doc/guides/prog_guide/img

[dpdk-dev] [PATCH v5 11/12] cryptodev: add reference count to session private data

This patch adds a refcnt field to every session private data in the cryptodev symmetric session. The counter is used to prevent freeing symmetric session blindly before it is not cleared by every type of crypto device in use. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_gu

[dpdk-dev] [PATCH v5 12/12] cryptodev: add opaque data field to symmetric session

This patch adds a opaque data field to cryptodev symmetric session. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_guide/img/cryptodev_sym_sess.svg | 7 +++ lib/librte_cryptodev/rte_cryptodev.c | 1 + lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 3

  1   2   3   >