On 1/4/19 5:06 AM, Tiwei Bie wrote:
Descs in desc table should be indexed using the desc idx
instead of the idx of avail ring and used ring.
Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay")
Signed-off-by: Tiwei Bie
---
lib/librte_vhost/vdpa.c | 12 ++--
1 file
> -Original Message-
> From: Zhang, Qi Z
> Sent: Thursday, January 3, 2019 9:47 PM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org; Wu, Jingjing ; Zhao1, Wei
>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix MAT enable for VF in
> multicast
>
> Hi Wei
>
> > -Original Messag
On 1/4/19 5:06 AM, Tiwei Bie wrote:
Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay")
Signed-off-by: Tiwei Bie
---
lib/librte_vhost/vdpa.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 1/4/19 5:06 AM, Tiwei Bie wrote:
Fix a possible dead loop which may happen, e.g. when
driver created a loop in the desc list.
Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay")
Signed-off-by: Tiwei Bie
---
lib/librte_vhost/vdpa.c | 16
1 file changed
On 1/4/19 5:06 AM, Tiwei Bie wrote:
Fixes: 7f74b95c444f ("vhost: pre update used ring for Tx and Rx")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
lib/librte_vhost/virtio_net.c | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 1/4/19 5:06 AM, Tiwei Bie wrote:
Fix a possible dead loop which may happen, e.g. when driver
created a loop in the desc list and lens in descs are zero.
Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path")
Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring
On 1/4/19 5:06 AM, Tiwei Bie wrote:
Fixes: 30920b1e2b15 ("vhost: ensure all range is mapped when translating QVAs")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
lib/librte_vhost/vhost_user.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Maxime C
In ixgbe PMD code, all vf ars set with bit IXGBE_VMOLR_ROMPE,
which make vf accept packets that match the MTA table,
if some vf update IXGBE_MTA in function ixgbe_vf_set_multicast,
then all vf will receive packets from these address.
So thhere is need to set VMOLR register bit ROPE only after this
There is no parameter called "eth-peer-configfile" in testpmd. It should
be "eth-peers-configfile". See the usage() method in
app/test-pmd/parameters.c.
v2: Fix line too long in the patch commit log.
Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
Cc: sta...@dpdk.org
Sign
There is no parameter called "eth-peer-configfile" in testpmd. It should
be "eth-peers-configfile". See the usage() method in
app/test-pmd/parameters.c.
v2: Fix line too long in the patch commit log.
Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
Cc: sta...@dpdk.org
Sign
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, January 4, 2019 12:26 AM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org; akhil.go...@nxp.com
> Subject: Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata
> pointer into crypto
> -Original Message-
> From: Rami Rosen [mailto:ramir...@gmail.com]
> Sent: Friday, January 4, 2019 9:11 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Iremonger, Bernard ;
> Rami Rosen
> Subject: [PATCH v2] doc: fix a parameter name in testpmd guide
>
> There is no parameter called "eth-pe
Hi Cristian,
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Thursday, January 3, 2019 4:37 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Wu, Jingjing
> ; Iremonger, Bernard
> Subject: [PATCH] app/test-pmd: stop all ports before any close
./devtools/check-git-log.sh -1
Wrong headli
On 1/4/2019 2:40 AM, Varghese, Vipin wrote:
> Hi Ferruh,
>
> Should not be there a documentation update in 'Known Issues and Limitations
> in Legacy Releases' for the limitation. If it is already added can you please
> add the patchwork link for the same.
It is good idea to document this limita
> -Original Message-
> From: Yigit, Ferruh
> Sent: Friday, January 4, 2019 3:58 PM
> To: Varghese, Vipin ; Yongseok Koh
>
> Cc: Thomas Monjalon ; dev ; dpdk
> stable ; Tom Barbette ; Ananyev,
> Konstantin ; Richardson, Bruce
>
> Subject: Re: [PATCH v3] mk: fix scope of disabling AVX512F
https://bugs.dpdk.org/show_bug.cgi?id=179
Bug ID: 179
Summary: mp_socket is not well handled when secondary process
is exited
Product: DPDK
Version: 18.11
Hardware: x86
OS: Linux
Status: CONFIRME
Hi Bernard,
Thanks for reviewing this patch.
> -Original Message-
> From: Iremonger, Bernard
> Sent: Friday, January 4, 2019 10:16 AM
> To: Dumitrescu, Cristian ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Wu, Jingjing
>
> Subject: RE: [PATCH] app/test-pmd: stop all ports before any close
>
> Hi
This patchset fixes two possible issues in vhost crypto. They are:
- The possible dead loop issue
- The out of bound access issue.
The fixes are in line with the following patchset
"[dpdk-dev] [PATCH 0/6] Some fixes for vhost"
(https://mails.dpdk.org/archives/dev/2019-January/122372.html)
Fan Zha
This patch fixes a possible infinite loop caused by incorrect
descriptor chain created by the driver.
Cc: sta...@dpdk.org
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 121 +++-
1 file
This patch fixes a out of bound access possbility in vhost
crypto. Originally the incorrect next descriptor index may
cause the library read invalid memory content and crash
the application.
Cc: sta...@dpdk.org
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
--
Hi Konstantin,
With this patchset, I am seeing a 3% drop in legacy mode lookaside and
12% drop with -l option.
I am debugging this. Will let you know if I find something.
-Akhil
On 1/4/2019 1:55 AM, Konstantin Ananyev wrote:
> This patch series depends on the patch series:
>
> ipsec: new librar
> -Original Message-
> From: Zhao1, Wei
> Sent: Friday, January 4, 2019 4:35 PM
> To: Zhang, Qi Z ; dev@dpdk.org
> Cc: sta...@dpdk.org; Wu, Jingjing
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix MAT enable for VF in multicast
>
>
>
> > -Original Message-
> > From: Zhang, Q
> -Original Message-
> From: Zhao1, Wei
> Sent: Friday, January 4, 2019 4:34 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhang, Qi Z ; Wu, Jingjing
> ; Zhao1, Wei
> Subject: [PATCH v2] net/ixgbe: fix multicast table enable error for VF
>
> In ixgbe PMD code, all vf ars set with bit IX
Hi ,
>
> In some vendors the RX and TX configuration must be the same, therefore
> the MTU size need to be equal to max_rx_pkt_len.
> The MTU is the largest size packet in bytes that can be sent on the
> network, therefore before changing this parameter, the NIC could not
> receive packets larger
On Wednesday 26 December 2018 05:03 PM, Hemant Agrawal wrote:
> Few fixes and minor enhancements in NXP DPAA driver
>
> Hemant Agrawal (4):
>bus/dpaa: fix the logical to physical core affine logic
>net/dpaa: fix the secondary process
>net/dpaa: update supported ptypes
>net/dpaa: up
This patch proposes a slightly different test-pmd quit operation: stop
all devices before starting to close any device. Basically, stop all
moving parts before beginning to remove them. The current test-pmd quit
is stopping and closing each device before moving to the next device.
If all devices i
Hi Akhil,
>
> Hi Konstantin,
>
> With this patchset, I am seeing a 3% drop in legacy mode lookaside and
> 12% drop with -l option.
> I am debugging this. Will let you know if I find something.
Ok, thanks.
For legacy mode do you know which patch in the series causing 3% drop?
Is it still: " fix
> -Original Message-
> From: Wang, Xiao W
> Sent: Thursday, January 3, 2019 10:10 AM
> To: Julien Meunier ; Zhang, Qi Z
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
>
> Hi Julien,
>
> > -Original Message-
> > From: Julien
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Friday, January 4, 2019 12:29 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Wu, Jingjing
> ; Iremonger, Bernard ;
> sta...@dpdk.org
> Subject: [PATCH v2] app/testpmd: fix quit to stop all ports before close
>
> This patch proposes a sli
This patch adds support for RFC4115 trTCM meters.
Signed-off-by: Eelco Chaudron
v4:
- Fixed typo
- Cleaned up code to be aligned with RFC diagram
v3:
- Gave the rfc4115 meter it's own data structures
v2:
- Marked all functions with __rte_experimental, and added
"EXPERIMENTAL:..." to do
This patch adds support for RFC4115 trTCM meters.
Signed-off-by: Eelco Chaudron
---
lib/librte_meter/rte_meter.c | 42 ++
lib/librte_meter/rte_meter.h | 233
lib/librte_meter/rte_meter_version.map |9 +
3 files changed, 282 insertio
Add test cases for RFC4115 meters
Signed-off-by: Eelco Chaudron
---
test/test/test_meter.c | 212
1 file changed, 212 insertions(+)
diff --git a/test/test/test_meter.c b/test/test/test_meter.c
index 8bb47e75c..f935faa53 100644
--- a/test/test/te
On 21 Dec 2018, at 17:15, Dumitrescu, Cristian wrote:
Hi Eelco,
+/** trTCM parameters per metered traffic flow. The CIR, EIT, CBS and
EBS
Small typo here: EIT to be replaced by EIR.
+parameters only count bytes of IP packets and do not include link
specific
+headers. The CBS and EBS
On 1/4/2019 5:59 PM, Ananyev, Konstantin wrote:
> Hi Akhil,
>
>> Hi Konstantin,
>>
>> With this patchset, I am seeing a 3% drop in legacy mode lookaside and
>> 12% drop with -l option.
>> I am debugging this. Will let you know if I find something.
> Ok, thanks.
> For legacy mode do you know which
On 1/4/2019 1:55 AM, Konstantin Ananyev wrote:
> /* process ipv4 packets */
> - inbound_sp_sa(ctx->sp4_ctx, ctx->sa_ctx, &trf.ip4, 0);
> - route4_pkts(qconf->rt4_ctx, trf.ip4.pkts, trf.ip4.num);
> + if (trf.ip4.num != 0) {
> + inbound_sp_sa(ctx->sp4_ctx, ctx->sa_ctx,
On 1/4/2019 8:10 PM, Akhil Goyal wrote:
>
> On 1/4/2019 5:59 PM, Ananyev, Konstantin wrote:
>> Hi Akhil,
>>
>>> Hi Konstantin,
>>>
>>> With this patchset, I am seeing a 3% drop in legacy mode lookaside and
>>> 12% drop with -l option.
>>> I am debugging this. Will let you know if I find something
>
> On 1/4/2019 1:55 AM, Konstantin Ananyev wrote:
> > /* process ipv4 packets */
> > - inbound_sp_sa(ctx->sp4_ctx, ctx->sa_ctx, &trf.ip4, 0);
> > - route4_pkts(qconf->rt4_ctx, trf.ip4.pkts, trf.ip4.num);
> > + if (trf.ip4.num != 0) {
> > + inbound_sp_sa(ctx->sp4_ctx, ctx->sa_
> On 1/4/2019 5:59 PM, Ananyev, Konstantin wrote:
> > Hi Akhil,
> >
> >> Hi Konstantin,
> >>
> >> With this patchset, I am seeing a 3% drop in legacy mode lookaside and
> >> 12% drop with -l option.
> >> I am debugging this. Will let you know if I find something.
> > Ok, thanks.
> > For legacy mod
On 12/13/2018 1:30 PM, Jakub Grajciar wrote:
> Memory interface (memif), provides high performance
> packet transfer over shared memory.
>
> Signed-off-by: Jakub Grajciar
Hi Jakub,
I put some comments but overall it is a long patch, I am almost sure there are
some details missed, it can make ea
On 1/4/19 12:22 PM, Fan Zhang wrote:
This patch fixes a possible infinite loop caused by incorrect
descriptor chain created by the driver.
Cc: sta...@dpdk.org
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 121 +
On 1/4/19 12:22 PM, Fan Zhang wrote:
This patch fixes a out of bound access possbility in vhost
crypto. Originally the incorrect next descriptor index may
cause the library read invalid memory content and crash
the application.
Cc: sta...@dpdk.org
Fixes: 3bb595ecd682 ("vhost/crypto: add reque
On 1/4/2019 1:04 PM, Zhang, Qi Z wrote:
>
>
>> -Original Message-
>> From: Wang, Xiao W
>> Sent: Thursday, January 3, 2019 10:10 AM
>> To: Julien Meunier ; Zhang, Qi Z
>>
>> Cc: dev@dpdk.org; sta...@dpdk.org
>> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
>>
>> Hi Julien,
On 1/4/2019 10:34 PM, Ananyev, Konstantin wrote:
>> On 1/4/2019 5:59 PM, Ananyev, Konstantin wrote:
>>> Hi Akhil,
>>>
Hi Konstantin,
With this patchset, I am seeing a 3% drop in legacy mode lookaside and
12% drop with -l option.
I am debugging this. Will let you know if I
On 1/4/19 12:22 PM, Fan Zhang wrote:
This patchset fixes two possible issues in vhost crypto. They are:
- The possible dead loop issue
- The out of bound access issue.
The fixes are in line with the following patchset
"[dpdk-dev] [PATCH 0/6] Some fixes for vhost"
(https://mails.dpdk.org/archi
On 1/4/19 5:06 AM, Tiwei Bie wrote:
Tiwei Bie (6):
vhost: fix desc access in relay helpers
vhost: fix possible out of bound access in relay helpers
vhost: fix possible dead loop in relay helpers
vhost: fix possible out of bound access in vector filling
vhost: fix possible dead l
On 1/3/19 3:40 AM, Tiwei Bie wrote:
Tiwei Bie (2):
net/virtio-user: fix packed vq option parsing
net/virtio-user: fix supported features list
drivers/net/virtio/virtio_user/virtio_user_dev.c | 14 +-
drivers/net/virtio/virtio_user_ethdev.c | 7 ---
2 files
On Thu, 13 Dec 2018 14:30:51 +0100
Jakub Grajciar wrote:
> +CFLAGS += -O3
> +CFLAGS += -I$(SRCDIR)
> +CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -Wno-pointer-arith
Why this additional compiler flag?
On Thu, 13 Dec 2018 14:30:51 +0100
Jakub Grajciar wrote:
> +static ssize_t
> +memif_msg_send(int fd, memif_msg_t *msg, int afd)
> +{
> + struct msghdr mh = { 0 };
> + struct iovec iov[1];
> + char ctl[CMSG_SPACE(sizeof(int))];
> +
> + iov[0].iov_base = (void *)msg;
Since iov_base
On Thu, 13 Dec 2018 14:30:51 +0100
Jakub Grajciar wrote:
> + role = MEMIF_ROLE_SLAVE;
> + flags = 0;
> + id = 0;
> + buffer_size = 2048;
> + log2_ring_size = 10;
> + nrxq = 1;
> + ntxq = 1;
> + socket_filename = ETH_MEMIF_DEFAULT_SOCKET_FILENAME;
> + secret = N
On Tue, 18 Dec 2018 12:25:19 +0800
Jiayu Hu wrote:
> +.. note::
> +To use the GRO library, applications must guarantee that
> +MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len and
> +MBUF->pkt_len/data_len of input packets are set to correct
> +values.
> +
Thi
On Fri, 4 Jan 2019 13:59:42 +
Eelco Chaudron wrote:
> This patch adds support for RFC4115 trTCM meters.
>
> Signed-off-by: Eelco Chaudron
Fix comment formatting.
### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support
WARNING:BLOCK_COMMENT_STYLE: Block comments
Hi,
The cacheline size (RTE_CACHE_LINE_SIZE) for ARM CPUs is set to be 128B by
default. Mellanox's BlueField is an ARM CPU having Cortex-A72 and its CL size is
64B.
I can add config/defconfig_arm64-bluefield-linuxapp-gcc for legacy build anyway.
For the meson build, I know it parses the Main ID
On Fri, 2019-01-04 at 19:59 +, Yongseok Koh wrote:
> ---
> ---
> Hi,
>
> The cacheline size (RTE_CACHE_LINE_SIZE) for ARM CPUs is set to be
> 128B by
> default. Mellanox's BlueField is an ARM CPU having Cortex-A72 and its
> CL siz
53 matches
Mail list logo
