On 1/4/2019 1:04 PM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Wang, Xiao W >> Sent: Thursday, January 3, 2019 10:10 AM >> To: Julien Meunier <julien.meun...@nokia.com>; Zhang, Qi Z >> <qi.z.zh...@intel.com> >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable >> >> Hi Julien, >> >>> -----Original Message----- >>> From: Julien Meunier [mailto:julien.meun...@nokia.com] >>> Sent: Wednesday, January 2, 2019 11:58 PM >>> To: Zhang, Qi Z <qi.z.zh...@intel.com>; Wang, Xiao W >>> <xiao.w.w...@intel.com> >>> Cc: dev@dpdk.org; sta...@dpdk.org >>> Subject: [PATCH] net/fm10k: initialize sm_down variable >>> >>> Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics") >>> Cc: sta...@dpdk.org >>> >>> Signed-off-by: Julien Meunier <julien.meun...@nokia.com> >>> --- >>> drivers/net/fm10k/fm10k_ethdev.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/fm10k/fm10k_ethdev.c >>> b/drivers/net/fm10k/fm10k_ethdev.c >>> index 85fb6c5..caf4d1b 100644 >>> --- a/drivers/net/fm10k/fm10k_ethdev.c >>> +++ b/drivers/net/fm10k/fm10k_ethdev.c >>> @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev) >>> hw->bus.payload = fm10k_bus_payload_256; >>> >>> info->rx_vec_allowed = true; >>> + info->sm_down = false; >>> } >>> >>> static int >>> -- >>> 2.10.2 >> >> Acked-by: Xiao Wang <xiao.w.w...@intel.com> > > Applied to dpdk-next-net-intel.
Is it possible to add more information to commit log? What happens if "sm_down" is not initialized? What "sm_down" is for? Should patch title be a 'fix' patch?
